[00:23:58] I don't know if this is the right place to ask... this patch for mediawiki-config just adds two comments to CommonSettings.php (which I think is why the diffConfig-docker test failed) [00:24:00] https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/651890/ [00:24:22] is it okay for me to +2 this? or do we still have to schedule a backport window? [00:25:54] in other words, there's nothing to actually deploy, but I wasn't sure if the only-deployers-can-merge rule still applied here [00:27:26] probably better to ask in -operations, but it'll need to actually be deployed to keep the repo state correct, even if its a no-op [00:30:08] okay, well if that's the case we'll just schedule a backport window. It'll be the easiest deploy ever! Hehe [00:32:04] see documentation at https://wikitech.wikimedia.org/wiki/How_to_deploy_code#Problem:_undeployed_code [00:46:13] musikanimal: 1) changes in ops/mw-config should be synced out regardless of their contents, just to avoid inconsistent state and surprises for the next deployer 2) relying on extension load order is always a bad idea and unreliable/not supported long term [00:48:10] good to know, thanks [01:03:32] (03CR) 10Jforrester: "Tsk, this was the last use." [integration/config] - 10https://gerrit.wikimedia.org/r/655379 (https://phabricator.wikimedia.org/T271575) (owner: 10MaxSem) [01:05:03] (03PS1) 10Jforrester: Zuul: [labs/tools/stewardbots] Enable PHP 8.0 jobs; drop special template [integration/config] - 10https://gerrit.wikimedia.org/r/655534 [01:06:23] (03CR) 10Jforrester: [C: 03+2] Zuul: [labs/tools/stewardbots] Enable PHP 8.0 jobs; drop special template [integration/config] - 10https://gerrit.wikimedia.org/r/655534 (owner: 10Jforrester) [01:07:29] (03Merged) 10jenkins-bot: Zuul: [labs/tools/stewardbots] Enable PHP 8.0 jobs; drop special template [integration/config] - 10https://gerrit.wikimedia.org/r/655534 (owner: 10Jforrester) [01:07:56] !log Zuul: [labs/tools/stewardbots] Enable PHP 8.0 jobs; drop special template [01:07:58] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [01:08:41] (03PS6) 10Jforrester: Ensure Parsoid's integration job tests against the Disambiguator extension [integration/config] - 10https://gerrit.wikimedia.org/r/655098 (https://phabricator.wikimedia.org/T237538) (owner: 10C. Scott Ananian) [01:08:51] (03CR) 10Jforrester: [C: 03+2] "This should work; let's find out." [integration/config] - 10https://gerrit.wikimedia.org/r/655098 (https://phabricator.wikimedia.org/T237538) (owner: 10C. Scott Ananian) [01:10:13] (03Merged) 10jenkins-bot: Ensure Parsoid's integration job tests against the Disambiguator extension [integration/config] - 10https://gerrit.wikimedia.org/r/655098 (https://phabricator.wikimedia.org/T237538) (owner: 10C. Scott Ananian) [01:11:38] !log Zuul: Ensure Parsoid's integration job tests against the Disambiguator extension T237538 [01:11:40] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [01:11:40] T237538: Merge Disambiguation in core or add hook - https://phabricator.wikimedia.org/T237538 [01:47:39] (03CR) 10Legoktm: [C: 03+2] Forbid use of super global $_FILES [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/654302 (owner: 10Umherirrender) [01:49:34] (03Merged) 10jenkins-bot: Forbid use of super global $_FILES [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/654302 (owner: 10Umherirrender) [01:52:58] (03CR) 10Jforrester: [C: 03+2] Check and require @var on files ending in Test.php [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/654925 (owner: 10Umherirrender) [01:53:20] (03CR) 10Jforrester: [C: 03+2] "> Patch Set 13: Code-Review+1" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591381 (https://phabricator.wikimedia.org/T241520) (owner: 10DannyS712) [01:54:05] (03Merged) 10jenkins-bot: Check and require @var on files ending in Test.php [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/654925 (owner: 10Umherirrender) [01:54:26] (03Merged) 10jenkins-bot: Add WhiteSpaceBeforeFunction sniff for whitespace in function signature [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591381 (https://phabricator.wikimedia.org/T241520) (owner: 10DannyS712) [01:54:53] (03PS9) 10Jforrester: Add AssertionOrderSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/636380 (https://phabricator.wikimedia.org/T253910) (owner: 10DannyS712) [01:55:05] (03CR) 10Jforrester: [C: 03+1] "Any last-minute thoughts on this?" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/636380 (https://phabricator.wikimedia.org/T253910) (owner: 10DannyS712) [01:58:57] 10MediaWiki-Codesniffer, 10User-DannyS712: Remove tabs in function signature - https://phabricator.wikimedia.org/T241520 (10DannyS712) 05Open→03Resolved [02:02:16] 10MediaWiki-Codesniffer, 10Release, 10User-DannyS712: Release mediawiki-codesniffer v35.0.0 - https://phabricator.wikimedia.org/T271392 (10DannyS712) [02:21:27] (03PS1) 10Jforrester: Zuul: [mediawiki/vendor] Experimental composer-php80 job, not 72 [integration/config] - 10https://gerrit.wikimedia.org/r/655538 [02:22:51] (03CR) 10jerkins-bot: [V: 04-1] Zuul: [mediawiki/vendor] Experimental composer-php80 job, not 72 [integration/config] - 10https://gerrit.wikimedia.org/r/655538 (owner: 10Jforrester) [02:30:26] (03PS2) 10Jforrester: Zuul: [mediawiki/vendor] Experimental composer-php80 job, not 72 [integration/config] - 10https://gerrit.wikimedia.org/r/655538 [02:30:29] (03PS1) 10Jforrester: jjb: Create mwgate-composer-php{74,80}-docker [integration/config] - 10https://gerrit.wikimedia.org/r/655539 [02:33:18] (03CR) 10Jforrester: [C: 03+2] Zuul: [mediawiki/vendor] Experimental composer-php80 job, not 72 [integration/config] - 10https://gerrit.wikimedia.org/r/655538 (owner: 10Jforrester) [02:33:24] (03CR) 10Jforrester: [C: 03+2] "Deployed." [integration/config] - 10https://gerrit.wikimedia.org/r/655539 (owner: 10Jforrester) [02:34:12] 10Beta-Cluster-Infrastructure, 10Acme-chief: Issues with acme-chief cert rotation on deployment-prep, 2021-01-12 - https://phabricator.wikimedia.org/T271778 (10Krenair) [02:34:44] (03Merged) 10jenkins-bot: jjb: Create mwgate-composer-php{74,80}-docker [integration/config] - 10https://gerrit.wikimedia.org/r/655539 (owner: 10Jforrester) [02:34:46] (03Merged) 10jenkins-bot: Zuul: [mediawiki/vendor] Experimental composer-php80 job, not 72 [integration/config] - 10https://gerrit.wikimedia.org/r/655538 (owner: 10Jforrester) [02:34:54] 10Beta-Cluster-Infrastructure, 10Acme-chief: Issues with acme-chief cert rotation on deployment-prep, 2021-01-12 - https://phabricator.wikimedia.org/T271778 (10Krenair) [02:35:25] !log Zuul: [mediawiki/vendor] Experimental composer-php80 job, not 72 [02:35:27] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [02:37:11] 10Beta-Cluster-Infrastructure, 10Acme-chief: Issues with acme-chief cert rotation on deployment-prep, 2021-01-12 - https://phabricator.wikimedia.org/T271778 (10Krenair) re acme-chief part: It looks like the same thing happened to the mx and wikibase certs too. Haven't checked those updated on the machines that... [03:02:55] (03PS1) 10Legoktm: docker: Update Rust to 1.49.0 [integration/config] - 10https://gerrit.wikimedia.org/r/655541 [03:02:57] (03PS1) 10Legoktm: jjb: Update Rust images for 1.49.0 [integration/config] - 10https://gerrit.wikimedia.org/r/655542 [03:05:30] legoktm: Does Rust come out with a new version every couple of months? [03:06:30] James_F: every 6 weeks [03:06:36] Huh. [03:08:09] legoktm: BTW, if you C+2 https://gerrit.wikimedia.org/r/c/mediawiki/vendor/+/655536/1 we'll be >< this much close to PHP 8.0. [03:08:30] No pressure. ;-) [07:21:07] Project mediawiki-core-doxygen-docker build #21830: 04FAILURE in 16 min: https://integration.wikimedia.org/ci/job/mediawiki-core-doxygen-docker/21830/ [08:00:04] Project mwcore-phpunit-coverage-master build #1149: 04STILL FAILING in 5 hr 0 min: https://integration.wikimedia.org/ci/job/mwcore-phpunit-coverage-master/1149/ [08:18:53] Yippee, build fixed! [08:18:54] Project mediawiki-core-doxygen-docker build #21831: 09FIXED in 14 min: https://integration.wikimedia.org/ci/job/mediawiki-core-doxygen-docker/21831/ [09:43:43] (03CR) 10DannyS712: [C: 04-1] "> Patch Set 9: Code-Review+1" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/636380 (https://phabricator.wikimedia.org/T253910) (owner: 10DannyS712) [09:44:37] (03PS10) 10DannyS712: Add AssertionOrderSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/636380 (https://phabricator.wikimedia.org/T253910) [09:46:55] (03CR) 10DannyS712: Add AssertionOrderSniff (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/636380 (https://phabricator.wikimedia.org/T253910) (owner: 10DannyS712) [10:52:57] 10MediaWiki-Codesniffer, 10Wikidata, 10User-Addshore, 10Wikidata-Campsite (Wikidata-Campsite-Iteration-∞): Use mediawiki codesniffer v33 in actively developed Wikibase related repositories and retire wikibase-codesniffer - https://phabricator.wikimedia.org/T266823 (10WMDE-leszek) [11:57:16] hashar: kostajh: Meeting today? [12:10:10] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.26 deployment blockers - https://phabricator.wikimedia.org/T267419 (10LarsWirzenius) [13:07:10] awight: kostajh: na we should move that meeting away sorry. 13:00 CET doesn't work for me anymore :\ [13:07:14] I had kids at home again [13:07:41] gehel: I might have fixed a java 8 / 11 compatibility issue with java.NIO / Selectors :] [13:07:59] I have just burned 1 day and a half over it cause I know nothing about that env hehe [13:20:39] hashar: I want to know more ! [13:22:53] maryum: ^^ [13:22:56] :] [13:23:38] gehel: audio ? ;) [13:24:05] In the bus, on my way back from Oscar's school [13:24:13] But can try audio ... [13:24:57] well the short story is that java 11 has a bunch of nice breaking changes listed at https://www.oracle.com/java/technologies/javase/jdk-11-relnote.html [13:25:08] my specific code just blocks / spin infinitely when run on java 11 [13:25:34] I have failed to hook a debugger in java and thus relied on the good old print statements [13:25:43] well more explicitly, LOG statements all other the code [13:25:56] and having to figure out how to print those debug logs when running the code [13:26:30] Oh, for some reason I thought you fixe the Java 8/11 issues with sonar [13:26:31] and eventually I found the infinite loop in java 11 which is that after a select.selectNow() for some socket events, it keep reading from it over and over and over [13:26:35] That's unrelated [13:26:58] although in java8 after reading the payload, the channel is successfully marked as not readable, in java 11 that is not the case [13:27:01] If you need code review for java, feel free to ask ! [13:27:06] and the code loops infinitely cause it is always readable [13:27:21] Interesting [13:27:26] turns out [13:27:31] it was a bug in java 8 and previous [13:27:51] meet.google.com/iwo-ohpx-nab [13:27:55] after a select.selectNow() the selected channels readable state should not be cleared [13:27:56] https://www.oracle.com/java/technologies/javase/jdk-11-relnote.html#JDK-8200458 :) [13:27:57] haha [13:27:59] If you want to try... [13:59:55] (03PS1) 10Hashar: Rename .bzrignore to .gitignore [integration/gearman-java] - 10https://gerrit.wikimedia.org/r/655660 [13:59:57] (03PS1) 10Hashar: Replace junit.framework.Assert by org.junit.Assert [integration/gearman-java] - 10https://gerrit.wikimedia.org/r/655661 [13:59:59] (03PS1) 10Hashar: Update pom.xml and target java8 [integration/gearman-java] - 10https://gerrit.wikimedia.org/r/655662 [14:00:01] (03PS1) 10Hashar: Fix read infinite loop under Java 11 [integration/gearman-java] - 10https://gerrit.wikimedia.org/r/655663 (https://phabricator.wikimedia.org/T271683) [14:00:19] gehel: a "one" line fix https://gerrit.wikimedia.org/r/c/integration/gearman-java/+/655663/1/src/main/java/org/gearman/common/GearmanNIOJobServerConnection.java :] [14:01:17] 10Continuous-Integration-Infrastructure, 10Jenkins, 10Release-Engineering-Team (CI & Testing services), 10Patch-For-Review: Upgrade Jenkins Gearman plugin from a forked repo - https://phabricator.wikimedia.org/T271683 (10hashar) [14:01:28] just have to add CI on top of that repo [14:03:26] hashar: these issues are so lovely... [14:03:51] then try to explain to a non-dev how these can take days [14:03:56] Platonides: definitely :) [14:04:11] fun fact, that code has been left untouched since 2010 or so [14:04:26] originally targettted java 5 and went through java 6, 7 and 8 included just fine! [14:04:36] relying in an actually wrong but working-due-to-a-bug [14:07:07] yeah [14:07:20] that brings good old memories about select.select() and using buffers for io [14:07:36] that's probably how it is implemented [14:07:53] or actually, maybe they completely changed the implementation in java 11 to use something else [14:08:04] and thus the behavior now matches the docs [14:13:48] 10phan-taint-check-plugin, 10MediaWiki-User-management: UserGroupMembership::getLink() causes a significant portion of false positives for phan-taint-check-plugin - https://phabricator.wikimedia.org/T183174 (10Daimona) This is still causing many false positives. I agree with everything that was written above,... [14:15:05] Platonides: yeah the API was prety clear about the behavior [14:15:11] but the JDK implementation was wrong [14:15:38] hunting these bugs hurt :P [14:18:17] happy new year, btw [14:18:25] the devil was really to understand the java stack / API [14:18:44] all to end up to discovering that java NIO stuff is really just a wrapper around select() :] [14:18:53] I'm not a java programmer, i can feel your pain :) [14:27:16] I am not either :D [14:27:24] Platonides: but the fundamentals are the same :D [14:29:43] * hashar processes pending code reviews [15:10:01] gehel: and I now even able to track a java memory leak in Gerrit all by myself thanks to VisualVM ! [15:10:25] I still can't write hello_world.java by myself though [15:13:15] hashar, you don't need to do that, it's been written already, so you can just treat it as a solved problem [15:13:37] yeah probably ;D [15:13:47] still have to find out how to fetch the solution though! [15:41:31] (03PS1) 10C. Scott Ananian: Add Parsoid to the gatedextensions list [integration/config] - 10https://gerrit.wikimedia.org/r/655695 [15:43:00] (03CR) 10jerkins-bot: [V: 04-1] Add Parsoid to the gatedextensions list [integration/config] - 10https://gerrit.wikimedia.org/r/655695 (owner: 10C. Scott Ananian) [15:56:05] (03PS2) 10C. Scott Ananian: Add Parsoid to the gatedextensions list [integration/config] - 10https://gerrit.wikimedia.org/r/655695 [15:57:21] (03CR) 10jerkins-bot: [V: 04-1] Add Parsoid to the gatedextensions list [integration/config] - 10https://gerrit.wikimedia.org/r/655695 (owner: 10C. Scott Ananian) [15:59:51] hashar: I'm late, but that should be HelloWorld.java ! [16:00:03] (03PS4) 10C. Scott Ananian: The parsoidsvc-parsertests-docker CI job is no longer needed [integration/config] - 10https://gerrit.wikimedia.org/r/655104 (https://phabricator.wikimedia.org/T271562) [16:07:47] 10Release-Engineering-Team, 10Product-Infrastructure-Team-Backlog, 10Recommendation-API, 10Services, and 2 others: Migrate recommendation-api to kubernetes - https://phabricator.wikimedia.org/T241230 (10Andrew) Changes associated with this patch (mostly 27152427487bed18321d582a7f77a301ea114968) have left t... [16:13:58] (03PS3) 10C. Scott Ananian: Add Parsoid to the gatedextensions list [integration/config] - 10https://gerrit.wikimedia.org/r/655695 [16:14:00] (03PS1) 10C. Scott Ananian: Allow parsoid to be added to dependency and gatedextensions lists [integration/config] - 10https://gerrit.wikimedia.org/r/655705 [16:17:39] 10Release-Engineering-Team, 10WVUI, 10Release Pipeline (Blubber): Use npm version 6.x on blubber-generated docker images - https://phabricator.wikimedia.org/T269957 (10jbond) I came across this issues from T270321 and after speaking with @MoritzMuehlenhoff we think its better to use buster-backports. The re... [16:19:57] gehel: lol [16:26:20] 10Phabricator, 10Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)), 10Developer Productivity: Enhance phabricator project metrics and reporting - https://phabricator.wikimedia.org/T255703 (10mmodell) Notes: * Make each bar into a link to search for id="[list of ids that were counted in this cate... [16:27:51] 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)): echostore helm test service checker failing in staging cluster - https://phabricator.wikimedia.org/T259686 (10akosiaris) @jeena. With https://gerrit.wikimedia.org/r/641790 reviewed and merged I just release 0.2.1 and the relevant image was built. T... [16:32:20] (03PS2) 10C. Scott Ananian: Allow parsoid to be added to dependency and gatedextensions lists [integration/config] - 10https://gerrit.wikimedia.org/r/655705 [16:32:22] (03PS4) 10C. Scott Ananian: Add Parsoid to the gatedextensions list [integration/config] - 10https://gerrit.wikimedia.org/r/655695 [16:33:25] (03CR) 10jerkins-bot: [V: 04-1] Add Parsoid to the gatedextensions list [integration/config] - 10https://gerrit.wikimedia.org/r/655695 (owner: 10C. Scott Ananian) [16:33:56] 10Release-Engineering-Team, 10Product-Infrastructure-Team-Backlog, 10Recommendation-API, 10Services, and 2 others: Migrate recommendation-api to kubernetes - https://phabricator.wikimedia.org/T241230 (10akosiaris) >>! In T241230#6740058, @Andrew wrote: > Changes associated with this patch (mostly 271524274... [16:34:05] (03CR) 10jerkins-bot: [V: 04-1] Allow parsoid to be added to dependency and gatedextensions lists [integration/config] - 10https://gerrit.wikimedia.org/r/655705 (owner: 10C. Scott Ananian) [16:34:34] * apergos peeks in [16:37:31] deployment-prep folks, sca01 and sca02 are now broken and probably unfixable. Would someone like to takeon the job of deleting them and handling the related fallout? https://phabricator.wikimedia.org/T241230#6740193 [16:39:29] (03PS3) 10C. Scott Ananian: Allow parsoid to be added to dependency and gatedextensions lists [integration/config] - 10https://gerrit.wikimedia.org/r/655705 [16:40:47] (03CR) 10jerkins-bot: [V: 04-1] Allow parsoid to be added to dependency and gatedextensions lists [integration/config] - 10https://gerrit.wikimedia.org/r/655705 (owner: 10C. Scott Ananian) [16:47:47] (03PS4) 10C. Scott Ananian: Allow parsoid to be added to dependency and gatedextensions lists [integration/config] - 10https://gerrit.wikimedia.org/r/655705 [16:49:01] (03CR) 10jerkins-bot: [V: 04-1] Allow parsoid to be added to dependency and gatedextensions lists [integration/config] - 10https://gerrit.wikimedia.org/r/655705 (owner: 10C. Scott Ananian) [16:50:01] (03PS5) 10C. Scott Ananian: Allow parsoid to be added to dependency and gatedextensions lists [integration/config] - 10https://gerrit.wikimedia.org/r/655705 [16:51:01] who's running the rain today? liw is that you? [16:51:16] (03PS6) 10C. Scott Ananian: Allow parsoid to be added to dependency and gatedextensions lists [integration/config] - 10https://gerrit.wikimedia.org/r/655705 [16:51:21] apergos, I'm the train conductor yes, how can I help you? [16:51:21] (03CR) 10jerkins-bot: [V: 04-1] Allow parsoid to be added to dependency and gatedextensions lists [integration/config] - 10https://gerrit.wikimedia.org/r/655705 (owner: 10C. Scott Ananian) [16:51:56] I have your backport, it is usual procedure for the person that +2ed the fix into master to go ahead and do that for the backport as well? [16:52:21] i.e. should I just do that and get it done? [16:52:44] (03PS5) 10C. Scott Ananian: Add Parsoid to the gatedextensions list [integration/config] - 10https://gerrit.wikimedia.org/r/655695 [16:52:46] (03PS1) 10C. Scott Ananian: Add parsoid as a dependency of the Disambiguator extension [integration/config] - 10https://gerrit.wikimedia.org/r/655713 [16:52:49] apergos, I don't actually know, but since I don't know how to do the backports (and train week is an awful time for me to learn), I would appreciate it if someon would do the backport [16:53:02] (03PS2) 10C. Scott Ananian: Add parsoid as a dependency of the Disambiguator extension [integration/config] - 10https://gerrit.wikimedia.org/r/655713 [16:53:04] (03PS6) 10C. Scott Ananian: Add Parsoid to the gatedextensions list [integration/config] - 10https://gerrit.wikimedia.org/r/655695 [16:53:05] I'll just do it then and someone can tell me off later if it's inappropriate [16:53:32] apergos, I'm sure it'll be fine [16:54:46] waiting for jenkins now [17:01:35] (03CR) 10C. Scott Ananian: "Note that this is redundant if we (a) add Disambiguator to the gated extension list (I2bfbbd9b9864eda20dbf4d7d379acf3d3ddcaf1b) and (b) ad" [integration/config] - 10https://gerrit.wikimedia.org/r/655695 (owner: 10C. Scott Ananian) [17:18:32] liw: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/655671 merged. [17:18:49] apergos, thank you [17:20:14] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Cloud-VPS, 10cloud-services-team (Kanban): integration instances suffer from high IO latency due to Ceph - https://phabricator.wikimedia.org/T266777 (10Andrew) @hashar , are you getting adequate performance now?... [17:20:34] can I assist further or are you good to go? [17:22:03] apergos, sorry, in meeting for a while [17:22:12] i'll take that as a yes :-) [17:22:23] have a good meeting [17:25:24] apergos, did you deploy the change to production as well? [17:25:32] I have not [17:26:04] are you still in a meeting? [17:26:12] yeah [17:26:16] ok. [17:28:25] next meeting starting soon, too ;) [17:29:13] heh [17:34:32] apergos, moment between meeings: getting the change deployed would be good, and that's something I'm not up to yet; I you're not either, I/we can ask someone else to help [17:34:44] I'll see [17:34:48] 10Release-Engineering-Team, 10WVUI, 10Release Pipeline (Blubber): Use npm version 6.x on blubber-generated docker images - https://phabricator.wikimedia.org/T269957 (10nnikkhoui) Thanks @jbond for the reasoning and explanation! Just because I'm not very familiar with package management, wouldn't this be an i... [17:34:49] if I get it done I'll drop a note here! [17:34:58] apergos, cool, thanks [17:52:31] Want me to do it? [17:53:37] Reedy, I'd be OK with that [17:55:50] (also known as: yes please) [17:56:00] Reedy: [17:56:01] 10Release-Engineering-Team, 10WVUI, 10Release Pipeline (Blubber): Use npm version 6.x on blubber-generated docker images - https://phabricator.wikimedia.org/T269957 (10jbond) >>! In T269957#6740577, @nnikkhoui wrote: > Thanks @jbond for the reasoning and explanation! Just because I'm not very familiar with p... [17:56:04] I'm happy to do it but [17:56:11] we need an sre and I don't have one atm [17:56:23] the quarterly update thingie is happening so maybe folks are at that [17:57:01] Need an SRE? [17:57:13] yes [17:57:30] see my request in wikimedia-sre and in -operations [17:57:41] but there is a tech dept quartly something or other [17:57:56] at least some of them are in there presenting or following [18:03:32] 10Project-Admins, 10Security, 10user-sbassett: Create two new security-related project tags - https://phabricator.wikimedia.org/T271729 (10sbassett) >>! In T271729#6736709, @RhinosF1 wrote: > It sounds too vague to me. Is there a guideline on when it should be used? It's primarily internal to the #security-... [18:04:33] sbassett: I get your point [18:04:47] Ok thanks [18:05:24] Not sure of a good way to word it that's not alarmist and is explanatory [18:05:38] I'll comment on the task later thanking for the explanation [18:05:49] I'm honestly fine with anything that doesn't contain the words "security" or "incident" [18:06:07] cyber event maybe? [18:06:15] That's better than project [18:06:20] I don't theoretically have a problem with that. [18:06:37] Only slightly alarmist, I suppose. [18:06:44] Yeah [18:28:19] Reedy: see BlackWidowMovie on phab [18:28:36] They've caused problems with us before so they know they shouldn't be randomly changing priorities [18:29:07] https://phabricator.wikimedia.org/T271846 [18:29:13] Oh they might be socking [18:29:18] So give me a sec [18:29:39] https://phabricator.wikimedia.org/p/BlackWidowMovie0000Editor/ [18:30:23] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10MW-on-K8s, 10Release Pipeline, 10Patch-For-Review: Define a PipelineLib based MW image build job on releases-jenkins.wikimedia.org - https://phabricator.wikimedia.org/T271477 (10dduvall) [18:31:02] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10MW-on-K8s, 10Release Pipeline: Move private settings to a k8s compatible location - https://phabricator.wikimedia.org/T271475 (10dduvall) [18:31:27] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10MW-on-K8s, 10Release Pipeline: Determine whether PipelineLib can run on releases-jenkins.wikimedia.org - https://phabricator.wikimedia.org/T271472 (10dduvall) [18:31:45] 10Release-Engineering-Team, 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10MW-on-K8s: Proof of concept for multi-version MediaWiki images - https://phabricator.wikimedia.org/T271448 (10dduvall) [18:31:56] Reedy: seen you've done it so I've gone and done https://phabricator.wikimedia.org/p/BlackWidowMovie0000/ too [18:32:06] Might be worth looking in people logs for others [18:32:14] They're PM-ing me now [18:32:38] Tell them to do one [18:33:46] https://en.wikipedia.org/wiki/Wikipedia:Sockpuppet_investigations/PhilCoulson20/Archive are the others on wiki [18:40:21] I am tired of those one liner fixes that takes days to concretize [18:40:28] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10MW-on-K8s: Proof of concept for multi-version MediaWiki images - https://phabricator.wikimedia.org/T271448 (10dduvall) [18:40:55] I wrote exactly 4 lines of code over two days which follow a couple weeks at least of investigation / debugging [18:41:55] hashar: Sometimes the smallest of things cause the most issues [18:51:20] (03PS1) 10C. Scott Ananian: Test Parsoid as if it were an extension [integration/quibble] - 10https://gerrit.wikimedia.org/r/655732 [18:51:44] RhinosF1: yeah definitely [18:52:02] I wish I could have the patience to write a blog post summarizing each of those adventures [18:52:42] Heh [18:54:20] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Release Pipeline: Enforce image names and namespaces in PipelineLib to avoid collisions - https://phabricator.wikimedia.org/T271125 (10dduvall) [18:54:51] 10Release-Engineering-Team (Pipeline), 10Release Pipeline (Blubber): Include section in Blubber/PipelineLib docs about writing for image layer efficiency - https://phabricator.wikimedia.org/T268780 (10dduvall) [18:54:57] (03CR) 10jerkins-bot: [V: 04-1] Test Parsoid as if it were an extension [integration/quibble] - 10https://gerrit.wikimedia.org/r/655732 (owner: 10C. Scott Ananian) [19:00:55] (03PS2) 10C. Scott Ananian: Test Parsoid as if it were an extension [integration/quibble] - 10https://gerrit.wikimedia.org/r/655732 [19:04:27] 10Release-Engineering-Team, 10WVUI, 10Release Pipeline (Blubber): Use npm version 6.x on blubber-generated docker images - https://phabricator.wikimedia.org/T269957 (10nnikkhoui) @jbond Gotcha! So just to make sure I understand, no matter the approach we'll have to manage the security of the package and its... [19:04:45] (03PS1) 10C. Scott Ananian: Revert "Ensure Parsoid's integration job tests against the Disambiguator extension" [integration/config] - 10https://gerrit.wikimedia.org/r/655676 [19:05:16] (03CR) 10jerkins-bot: [V: 04-1] Test Parsoid as if it were an extension [integration/quibble] - 10https://gerrit.wikimedia.org/r/655732 (owner: 10C. Scott Ananian) [19:05:48] (03CR) 10jerkins-bot: [V: 04-1] Revert "Ensure Parsoid's integration job tests against the Disambiguator extension" [integration/config] - 10https://gerrit.wikimedia.org/r/655676 (owner: 10C. Scott Ananian) [19:07:20] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10SRE, 10serviceops, and 2 others: Upgrade MediaWiki clusters to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10ops-monitoring-bot) Script wmf-auto-reimage was launched by dzahn on cumin1001.eqiad.w... [19:08:37] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10SRE, 10serviceops, and 2 others: Upgrade MediaWiki clusters to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10ops-monitoring-bot) Completed auto-reimage of hosts: ` ['mw2224.codfw.wmnet'] ` Of wh... [19:11:21] (03PS12) 10Brennen Bearnes: Move xdebug build & php entrypoint to stretch; xdebug 3.0.1 [releng/dev-images] - 10https://gerrit.wikimedia.org/r/640567 [19:12:14] liw: deployed, so it's all you whenever you like [19:12:47] cc longma ^ [19:13:13] (lars is about to suspend his brain, jeena is backup conductor this week) [19:13:19] I think we've already rolled to group0 earlier? [19:13:43] yeah, just fyi that the backport is done, I believe [19:14:08] okay, just wanted to confirm [19:14:25] that I wasn't supposed to deploy something right now [19:14:45] +1 [19:15:47] (03CR) 10Jeena Huneidi: [C: 03+2] Move xdebug build & php entrypoint to stretch; xdebug 3.0.1 [releng/dev-images] - 10https://gerrit.wikimedia.org/r/640567 (owner: 10Brennen Bearnes) [19:16:42] 10Beta-Cluster-Infrastructure, 10MediaWiki-extensions-StopForumSpam, 10Wikimedia-extension-review-queue: Deploy StopForumSpam to the Beta Cluster - https://phabricator.wikimedia.org/T181217 (10sbassett) 05Stalled→03Resolved p:05Triage→03Medium a:03sbassett I'm going to resolve this for now. The ex... [19:20:59] (03CR) 10Jeena Huneidi: [V: 03+2 C: 03+2] Move xdebug build & php entrypoint to stretch; xdebug 3.0.1 [releng/dev-images] - 10https://gerrit.wikimedia.org/r/640567 (owner: 10Brennen Bearnes) [19:21:18] did it go out to group0? I thought it was stuck at 'only testwiki' according to one of the tasks about the blocker [19:22:06] maybe that is out of date? [19:22:24] otherwise all of my tests were bogus :-D [19:29:50] (03PS2) 10Jforrester: Revert "Ensure Parsoid's integration job tests against the Disambiguator…" [integration/config] - 10https://gerrit.wikimedia.org/r/655676 (owner: 10C. Scott Ananian) [19:30:20] (I have since done an actual against test.wp.o test and it's ok. now i am going away for the evening.) [19:31:24] (03CR) 10Jforrester: [C: 03+2] Revert "Ensure Parsoid's integration job tests against the Disambiguator…" [integration/config] - 10https://gerrit.wikimedia.org/r/655676 (owner: 10C. Scott Ananian) [19:31:58] apergos: https://versions.toolforge.org/ [19:32:04] apergos: It's on group0. [19:32:05] yeah but see [19:32:41] (03Merged) 10jenkins-bot: Revert "Ensure Parsoid's integration job tests against the Disambiguator…" [integration/config] - 10https://gerrit.wikimedia.org/r/655676 (owner: 10C. Scott Ananian) [19:32:57] https://phabricator.wikimedia.org/T271804 [19:33:06] Only on testwiki so far. But train hasn't gone further than that yet, not even to group0. [19:33:11] from the task description. [19:33:12] !log Zuul: Revert Parsoid integration job injection. [19:33:14] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [19:33:36] I don't know if the version checker can distinguish between 'it's on one group0 wiki' and 'it's on all group0 wikis' [19:33:42] It can. [19:33:53] It'd show wmf.25/26 if that were the case. [19:33:54] ah whew because that's what I relied on at the start of this [19:33:58] AH [19:34:01] gtk, thank you! [19:34:08] Any time. Sorry for the confusion! [19:34:18] no worries! happy deploys. [19:37:48] (03PS1) 10C. Scott Ananian: Ensure Parsoid's integration job tests against the Disambiguator extension [integration/config] - 10https://gerrit.wikimedia.org/r/655742 (https://phabricator.wikimedia.org/T237538) [19:39:17] (03PS2) 10C. Scott Ananian: Ensure Parsoid's tests include the Disambiguator extension (take 2) [integration/config] - 10https://gerrit.wikimedia.org/r/655742 (https://phabricator.wikimedia.org/T237538) [19:54:41] (03PS7) 10Jforrester: Allow parsoid to be added to dependency and gatedextensions lists [integration/config] - 10https://gerrit.wikimedia.org/r/655705 (owner: 10C. Scott Ananian) [19:54:47] (03CR) 10Jforrester: Allow parsoid to be added to dependency and gatedextensions lists (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/655705 (owner: 10C. Scott Ananian) [19:58:52] (03PS3) 10C. Scott Ananian: Test Parsoid as if it were an extension [integration/quibble] - 10https://gerrit.wikimedia.org/r/655732 [20:00:03] Project mwcore-phpunit-coverage-master build #1150: 04STILL FAILING in 5 hr 0 min: https://integration.wikimedia.org/ci/job/mwcore-phpunit-coverage-master/1150/ [20:00:47] (03CR) 10Jforrester: [C: 03+2] "Let's try this." [integration/config] - 10https://gerrit.wikimedia.org/r/655705 (owner: 10C. Scott Ananian) [20:01:06] (03PS3) 10Jforrester: Add parsoid as a dependency of the Disambiguator extension [integration/config] - 10https://gerrit.wikimedia.org/r/655713 (owner: 10C. Scott Ananian) [20:02:36] 10Project-Admins, 10Security, 10user-sbassett: Create two new security-related project tags - https://phabricator.wikimedia.org/T271729 (10sbassett) [20:02:48] (03Merged) 10jenkins-bot: Allow parsoid to be added to dependency and gatedextensions lists [integration/config] - 10https://gerrit.wikimedia.org/r/655705 (owner: 10C. Scott Ananian) [20:03:05] !log Zuul: Allow parsoid to be added to dependency and gatedextensions lists [20:03:06] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [20:03:20] (03PS4) 10C. Scott Ananian: Test Parsoid as if it were an extension [integration/quibble] - 10https://gerrit.wikimedia.org/r/655732 [20:03:29] (03PS4) 10Jforrester: Add parsoid as a dependency of the Disambiguator extension [integration/config] - 10https://gerrit.wikimedia.org/r/655713 (owner: 10C. Scott Ananian) [20:03:45] (03PS5) 10Jforrester: Zuul: Add parsoid as a dependency of the Disambiguator extension [integration/config] - 10https://gerrit.wikimedia.org/r/655713 (owner: 10C. Scott Ananian) [20:03:51] (03CR) 10Jforrester: [C: 03+2] Zuul: Add parsoid as a dependency of the Disambiguator extension [integration/config] - 10https://gerrit.wikimedia.org/r/655713 (owner: 10C. Scott Ananian) [20:04:09] (03PS7) 10Jforrester: Zuul: Add Parsoid to the gatedextensions list [integration/config] - 10https://gerrit.wikimedia.org/r/655695 (owner: 10C. Scott Ananian) [20:04:14] (03PS8) 10Jforrester: Zuul: Add Parsoid to the gatedextensions list [integration/config] - 10https://gerrit.wikimedia.org/r/655695 (owner: 10C. Scott Ananian) [20:05:17] (03Merged) 10jenkins-bot: Zuul: Add parsoid as a dependency of the Disambiguator extension [integration/config] - 10https://gerrit.wikimedia.org/r/655713 (owner: 10C. Scott Ananian) [20:06:19] !log Zuul: Add parsoid as a dependency of the Disambiguator extension [20:06:20] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [20:06:33] (03CR) 10jerkins-bot: [V: 04-1] Test Parsoid as if it were an extension [integration/quibble] - 10https://gerrit.wikimedia.org/r/655732 (owner: 10C. Scott Ananian) [20:10:03] (03PS1) 10C. Scott Ananian: Zuul: Remove Disambiguator from Parsoid dependencies [integration/config] - 10https://gerrit.wikimedia.org/r/655752 [20:10:44] (03CR) 10Jforrester: [C: 03+2] Zuul: Remove Disambiguator from Parsoid dependencies [integration/config] - 10https://gerrit.wikimedia.org/r/655752 (owner: 10C. Scott Ananian) [20:11:59] (03Merged) 10jenkins-bot: Zuul: Remove Disambiguator from Parsoid dependencies [integration/config] - 10https://gerrit.wikimedia.org/r/655752 (owner: 10C. Scott Ananian) [20:13:01] !log Zuul: Remove Disambiguator from Parsoid dependencies (again) [20:13:03] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [20:23:59] (03PS1) 10Reedy: Add tab-width=4 and increase line length to 120 [tools/codesniffer] (19.x) - 10https://gerrit.wikimedia.org/r/655681 (https://phabricator.wikimedia.org/T243598) [20:24:57] (03PS5) 10C. Scott Ananian: Test Parsoid as if it were an extension [integration/quibble] - 10https://gerrit.wikimedia.org/r/655732 [20:30:53] (03CR) 10jerkins-bot: [V: 04-1] Add tab-width=4 and increase line length to 120 [tools/codesniffer] (19.x) - 10https://gerrit.wikimedia.org/r/655681 (https://phabricator.wikimedia.org/T243598) (owner: 10Reedy) [20:31:06] (03CR) 10Reedy: [C: 03+2] "Don't care about PHP 8.0" [tools/codesniffer] (19.x) - 10https://gerrit.wikimedia.org/r/655681 (https://phabricator.wikimedia.org/T243598) (owner: 10Reedy) [20:31:18] oh ffs [20:31:30] I can't V+2? [20:32:56] (03CR) 10jerkins-bot: [V: 04-1] Add tab-width=4 and increase line length to 120 [tools/codesniffer] (19.x) - 10https://gerrit.wikimedia.org/r/655681 (https://phabricator.wikimedia.org/T243598) (owner: 10Reedy) [20:36:01] 10Project-Admins, 10Security, 10user-sbassett: Create two new security-related project tags - https://phabricator.wikimedia.org/T271729 (10RhinosF1) >>! In T271729#6740716, @sbassett wrote: >>>! In T271729#6736709, @RhinosF1 wrote: >> It sounds too vague to me. Is there a guideline on when it should be used?... [20:37:05] (03CR) 10Reedy: [V: 03+2 C: 03+2] Add tab-width=4 and increase line length to 120 [tools/codesniffer] (19.x) - 10https://gerrit.wikimedia.org/r/655681 (https://phabricator.wikimedia.org/T243598) (owner: 10Reedy) [20:38:01] (03CR) 10jerkins-bot: [V: 04-1] Test Parsoid as if it were an extension [integration/quibble] - 10https://gerrit.wikimedia.org/r/655732 (owner: 10C. Scott Ananian) [20:55:10] (03CR) 10Reedy: [V: 03+2 C: 03+2] Release 19.3.0 [tools/codesniffer] (19.x) - 10https://gerrit.wikimedia.org/r/655683 (owner: 10Reedy) [20:56:13] 10Release-Engineering-Team (Logspam), 10MediaWiki-extensions-Graph, 10JavaScript, 10Wikimedia-production-error: Uncaught TypeError: Cannot read property 'type' of undefined at axis_def - https://phabricator.wikimedia.org/T270508 (10Jdlrobson) Word of warning: we will likely be deploying error logging to E... [20:56:48] 10Release-Engineering-Team (Logspam), 10MediaWiki-extensions-Graph, 10Wikimedia-production-error: TypeError: field is not a function. (In 'field(g[i])', 'field' is undefined) in partition - https://phabricator.wikimedia.org/T269694 (10Jdlrobson) p:05Triage→03High Word of warning: we will likely be deplo... [21:13:25] (03CR) 10Brennen Bearnes: "> Patch Set 8:" (031 comment) [releng/dev-images] - 10https://gerrit.wikimedia.org/r/640567 (owner: 10Brennen Bearnes) [21:14:55] !log Updating dev-images docker-pkg files on primary contint for https://gerrit.wikimedia.org/r/c/releng/dev-images/+/640567 [21:15:04] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [21:18:04] (03CR) 10Reedy: [V: 03+2 C: 03+2] "PHP 8.0 failure gonna happen. 0 cares given" [tools/codesniffer] (19.x) - 10https://gerrit.wikimedia.org/r/655769 (owner: 10Reedy) [21:22:11] (03CR) 10Reedy: [C: 03+2] HISTORY.md: Add 19.x point releases [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/655768 (owner: 10Reedy) [21:22:35] (03PS1) 10C. Scott Ananian: Zuul: Remove parsoid dependencies [integration/config] - 10https://gerrit.wikimedia.org/r/655760 (https://phabricator.wikimedia.org/T271863) [21:23:49] (03Merged) 10jenkins-bot: HISTORY.md: Add 19.x point releases [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/655768 (owner: 10Reedy) [21:25:52] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10SRE, 10serviceops, and 2 others: Upgrade MediaWiki clusters to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10ops-monitoring-bot) Script wmf-auto-reimage was launched by dzahn on cumin1001.eqiad.w... [21:27:21] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10SRE, 10serviceops, and 2 others: Upgrade MediaWiki clusters to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10ops-monitoring-bot) Script wmf-auto-reimage was launched by dzahn on cumin1001.eqiad.w... [21:28:41] (03CR) 10Reedy: [V: 03+2 C: 03+2] Release 19.4.0 [tools/codesniffer] (19.x) - 10https://gerrit.wikimedia.org/r/655771 (owner: 10Reedy) [21:29:37] (03PS2) 10C. Scott Ananian: Zuul: Remove parsoid dependencies [integration/config] - 10https://gerrit.wikimedia.org/r/655760 (https://phabricator.wikimedia.org/T271863) [21:33:33] (03PS3) 10C. Scott Ananian: Ensure Parsoid's tests include the Disambiguator extension (take 2) [integration/config] - 10https://gerrit.wikimedia.org/r/655742 (https://phabricator.wikimedia.org/T271863) [21:48:46] (03PS6) 10C. Scott Ananian: Test Parsoid as if it were an extension [integration/quibble] - 10https://gerrit.wikimedia.org/r/655732 (https://phabricator.wikimedia.org/T271863) [22:02:50] (03CR) 10jerkins-bot: [V: 04-1] Test Parsoid as if it were an extension [integration/quibble] - 10https://gerrit.wikimedia.org/r/655732 (https://phabricator.wikimedia.org/T271863) (owner: 10C. Scott Ananian) [22:08:13] (03CR) 10Reedy: [C: 03+2] HISTORY.md: Add 19.4.0 point release [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/655773 (owner: 10Reedy) [22:09:43] (03Merged) 10jenkins-bot: HISTORY.md: Add 19.4.0 point release [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/655773 (owner: 10Reedy) [22:33:57] (03CR) 10Ahmon Dancy: [C: 03+1] Fix read infinite loop under Java 11 [integration/gearman-java] - 10https://gerrit.wikimedia.org/r/655663 (https://phabricator.wikimedia.org/T271683) (owner: 10Hashar) [22:35:01] (03CR) 10Ahmon Dancy: [C: 03+1] Rename .bzrignore to .gitignore [integration/gearman-java] - 10https://gerrit.wikimedia.org/r/655660 (owner: 10Hashar) [22:35:40] (03CR) 10Ahmon Dancy: [C: 03+1] Replace junit.framework.Assert by org.junit.Assert [integration/gearman-java] - 10https://gerrit.wikimedia.org/r/655661 (owner: 10Hashar) [22:36:18] (03CR) 10Ahmon Dancy: [C: 03+1] Update pom.xml and target java8 [integration/gearman-java] - 10https://gerrit.wikimedia.org/r/655662 (owner: 10Hashar) [22:44:27] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10SRE, 10serviceops, and 2 others: Upgrade MediaWiki clusters to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10ops-monitoring-bot) Completed auto-reimage of hosts: ` ['mw2224.codfw.wmnet'] ` and w... [22:47:12] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10SRE, 10serviceops, and 2 others: Upgrade MediaWiki clusters to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10ops-monitoring-bot) Completed auto-reimage of hosts: ` ['mw2225.codfw.wmnet'] ` and w...