[00:21:19] twentyafterfour: thcipriani: Hey, is it okay if I move several herald rules to the bot instead? https://phabricator.wikimedia.org/T108586 [00:21:33] Amir1: seems fine [00:21:59] Thanks! [00:23:12] Amir1: also, thanks for working on phabricator automation. I like what I see! [00:23:42] lots of people helped a lot, specially Majavah [00:24:08] I love the wiki creation having its tickets created automatically [00:24:09] :D [00:24:38] yeah that's cool, I was aware of this bot but I didn't realize it had progressed so far [00:26:20] Is there a way to make it not send notification to users? [00:26:28] like enabling a setting? [00:27:18] the only way currently to do silent edits is using the batch editor and it requires a sudo command on the server for each batch [00:27:38] it would be nice if we could grant that ability to people [00:27:54] that's pretty much all I use my sudo for. [00:28:05] (my sudo rights on the phab server, that is) [00:28:14] the risk is if someone got ahold of credentials with that authority they could do a lot of damage before anyone would notice [00:28:33] yeah [00:28:34] though I agree it would be nice [00:28:51] I don't think it would be technically difficult but I don't know how to mitigate the risk [00:29:54] specially since we had attacks on phabricator before [00:30:02] maybe if we sent a notice to IRC in a well-monitored channel then we could see if something not-right was happening [00:30:42] like skip the phabricator notifications but instead send a one-off notification for each batch / silent edit in an async medium for casual monitoring [00:30:52] the herald grouper works now: https://phabricator.wikimedia.org/T272196#6752801 [00:31:02] I'll say that if an attacker knows about bulk actions...they're doing better than me in my first few years of using phab :) [00:32:22] thcipriani: unfortunately there is a high likelyhood that such hypothetical attacker would know how to cause maximum annoyance [00:33:00] based on past experience anyway. maybe not a high likelyhood but at least a reasonable possibility [00:33:51] maximum annoyance is an untenable level of annoyance. [00:36:51] 10Phabricator, 10Performance Issue: Herald rules causing delays to task edit saves - getting worse - https://phabricator.wikimedia.org/T108586 (10Ladsgroup) The patch is merged and working as expected. I disabled cases in group 5. It'll be done by @Maintenance_bot [00:39:49] 10Phabricator, 10Performance Issue: Herald rules causing delays to task edit saves - getting worse - https://phabricator.wikimedia.org/T108586 (10Ladsgroup) I still think doing group 4 is also pretty easy. You just should go through transactions to make sure the project has not been added before. [05:10:06] James_F are you around? [05:10:34] was hoping you could take another look at https://gerrit.wikimedia.org/r/c/mediawiki/tools/codesniffer/+/649913 [08:00:03] Project mwcore-phpunit-coverage-master build #1157: 04STILL FAILING in 5 hr 0 min: https://integration.wikimedia.org/ci/job/mwcore-phpunit-coverage-master/1157/ [09:16:20] Project beta-scap-eqiad build #334090: 04FAILURE in 1 min 53 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/334090/ [09:25:51] Project beta-scap-eqiad build #334091: 04STILL FAILING in 1 min 27 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/334091/ [09:38:03] Yippee, build fixed! [09:38:04] Project beta-scap-eqiad build #334092: 09FIXED in 3 min 42 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/334092/ [09:46:14] Project beta-scap-eqiad build #334093: 04FAILURE in 1 min 48 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/334093/ [13:05:34] Project beta-scap-eqiad build #334113: 04STILL FAILING in 1 min 8 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/334113/ [13:15:40] Project beta-scap-eqiad build #334114: 04STILL FAILING in 1 min 15 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/334114/ [13:17:24] (03PS1) 10Umherirrender: Improve check for test function in FunctionCommentSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/656557 [13:18:01] 10Beta-Cluster-Infrastructure, 10Jenkins, 10Release-Engineering-Team: deployment-deploy01 is out of disk space, causing beta-scap-eqiad to fail - https://phabricator.wikimedia.org/T272216 (10Majavah) [13:22:13] (03PS1) 10Umherirrender: Use PHPUnitTestTrait in LowerCamelFunctionsNameSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/656560 [13:24:00] (03CR) 10jerkins-bot: [V: 04-1] Use PHPUnitTestTrait in LowerCamelFunctionsNameSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/656560 (owner: 10Umherirrender) [13:25:35] Project beta-scap-eqiad build #334115: 04STILL FAILING in 1 min 10 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/334115/ [13:25:48] (03PS2) 10Umherirrender: Use PHPUnitTestTrait in LowerCamelFunctionsNameSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/656560 [13:27:17] (03PS1) 10QChris: Allow “Gerrit Managers” to import history [extensions/Acrolinx] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/656562 [13:27:19] (03CR) 10QChris: [V: 03+2 C: 03+2] Allow “Gerrit Managers” to import history [extensions/Acrolinx] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/656562 (owner: 10QChris) [13:27:27] (03PS1) 10QChris: Import done. Revoke import grants [extensions/Acrolinx] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/656563 [13:27:29] (03CR) 10QChris: [V: 03+2 C: 03+2] Import done. Revoke import grants [extensions/Acrolinx] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/656563 (owner: 10QChris) [13:28:51] Ty for the better task name Majavah [13:29:06] yw [13:29:50] (03CR) 10jerkins-bot: [V: 04-1] Use PHPUnitTestTrait in LowerCamelFunctionsNameSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/656560 (owner: 10Umherirrender) [13:30:02] do we have any specific processes for getting shell access on deployment-prep? [13:32:36] Not a clue [13:35:33] Project beta-scap-eqiad build #334116: 04STILL FAILING in 1 min 10 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/334116/ [13:44:18] (03PS3) 10Umherirrender: Use PHPUnitTestTrait in LowerCamelFunctionsNameSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/656560 [13:45:31] Project beta-scap-eqiad build #334117: 04STILL FAILING in 1 min 10 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/334117/ [13:49:52] (03PS1) 10Umherirrender: Expand FunctionCommentSniff::SKIP_STANDARD_METHODS [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/656566 [13:55:32] Project beta-scap-eqiad build #334118: 04STILL FAILING in 1 min 11 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/334118/ [14:05:34] Project beta-scap-eqiad build #334119: 04STILL FAILING in 1 min 8 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/334119/ [14:15:32] Project beta-scap-eqiad build #334120: 04STILL FAILING in 1 min 9 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/334120/ [14:15:33] (03PS2) 10Umherirrender: Improve check for test function in FunctionCommentSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/656557 [14:15:43] (03CR) 10Umherirrender: Improve check for test function in FunctionCommentSniff (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/656557 (owner: 10Umherirrender) [14:25:32] Project beta-scap-eqiad build #334121: 04STILL FAILING in 1 min 9 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/334121/ [14:35:35] Project beta-scap-eqiad build #334122: 04STILL FAILING in 1 min 12 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/334122/ [14:45:33] Project beta-scap-eqiad build #334123: 04STILL FAILING in 1 min 9 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/334123/ [14:55:31] Project beta-scap-eqiad build #334124: 04STILL FAILING in 1 min 10 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/334124/ [15:05:31] Project beta-scap-eqiad build #334125: 04STILL FAILING in 1 min 9 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/334125/ [15:15:33] Project beta-scap-eqiad build #334126: 04STILL FAILING in 1 min 12 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/334126/ [15:25:33] Project beta-scap-eqiad build #334127: 04STILL FAILING in 1 min 10 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/334127/ [15:35:33] Project beta-scap-eqiad build #334128: 04STILL FAILING in 1 min 10 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/334128/ [15:45:30] Project beta-scap-eqiad build #334129: 04STILL FAILING in 1 min 7 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/334129/ [15:55:32] Project beta-scap-eqiad build #334130: 04STILL FAILING in 1 min 8 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/334130/ [16:05:25] Project beta-scap-eqiad build #334131: 04STILL FAILING in 1 min 3 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/334131/ [16:15:25] Project beta-scap-eqiad build #334132: 04STILL FAILING in 1 min 5 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/334132/ [16:25:30] Project beta-scap-eqiad build #334133: 04STILL FAILING in 1 min 7 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/334133/ [16:35:29] Project beta-scap-eqiad build #334134: 04STILL FAILING in 1 min 7 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/334134/ [16:45:27] Project beta-scap-eqiad build #334135: 04STILL FAILING in 1 min 6 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/334135/ [16:55:28] Project beta-scap-eqiad build #334136: 04STILL FAILING in 1 min 7 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/334136/ [17:05:31] Project beta-scap-eqiad build #334137: 04STILL FAILING in 1 min 7 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/334137/ [17:15:32] Project beta-scap-eqiad build #334138: 04STILL FAILING in 1 min 9 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/334138/ [17:25:38] Project beta-scap-eqiad build #334139: 04STILL FAILING in 1 min 13 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/334139/ [17:33:40] (03CR) 10Jforrester: [C: 03+1] "Last call." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/649913 (https://phabricator.wikimedia.org/T253618) (owner: 10DannyS712) [17:35:34] 10Continuous-Integration-Infrastructure, 10Jenkins, 10Release-Engineering-Team-TODO: Restore IRC alerts for beta-scap-eqiad job - https://phabricator.wikimedia.org/T271122 (10Jdforrester-WMF) ` lang=irc 08:35:29 Project beta-scap-eqiad build #334134: STILL FAILING in 1 min 7 sec: https://inte... [17:37:20] James_F: definately seems working [17:37:21] 10Beta-Cluster-Infrastructure: beta-scap-eqiad job failing with `sudo: ldap_start_tls_s(): Can't contact LDAP server`, 2021-01-16 - https://phabricator.wikimedia.org/T272224 (10Jdforrester-WMF) [17:37:26] I filed T272216 to make it happy [17:37:27] T272216: deployment-deploy01 is out of disk space, causing beta-scap-eqiad to fail - https://phabricator.wikimedia.org/T272216 [17:37:31] Oh, ha. [17:37:42] Yippee, build fixed! [17:37:43] Project beta-scap-eqiad build #334140: 09FIXED in 3 min 20 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/334140/ [17:37:50] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team: deployment-deploy01 is out of disk space, causing beta-scap-eqiad to fail - https://phabricator.wikimedia.org/T272216 (10Reedy) 05Open→03Resolved a:03Reedy Fixed [17:37:51] … did you do something? [17:37:58] Ah, no, the glorious Reedy did. [17:38:05] Is this also T272224 ? [17:38:06] T272224: beta-scap-eqiad job failing with `sudo: ldap_start_tls_s(): Can't contact LDAP server`, 2021-01-16 - https://phabricator.wikimedia.org/T272224 [17:38:30] James_F: I don't have beta access, just read the Jenkins log [17:38:37] Yeah Reedy just fixed it [17:38:49] Of sure if they're related [17:38:52] Not* [17:39:14] The ldap and disk space errors [17:39:15] It's an odd error for disc-full, but UNIX systems often give odd errors in that circumstance. [17:39:39] 10Beta-Cluster-Infrastructure: beta-scap-eqiad job failing with `sudo: ldap_start_tls_s(): Can't contact LDAP server`, 2021-01-16 - https://phabricator.wikimedia.org/T272224 (10Jdforrester-WMF) Going to assume this is the same as {T272216}. [17:39:46] Errors are always odd [17:39:48] 10Beta-Cluster-Infrastructure: beta-scap-eqiad job failing with `sudo: ldap_start_tls_s(): Can't contact LDAP server`, 2021-01-16 - https://phabricator.wikimedia.org/T272224 (10Jdforrester-WMF) [17:40:03] Artefact of the network-is-a-file model. [17:40:06] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team: deployment-deploy01 is out of disk space, causing beta-scap-eqiad to fail - https://phabricator.wikimedia.org/T272216 (10Jdforrester-WMF) [17:40:09] True [17:40:46] I've spent hours debugging stuff that make no sense [17:42:26] (03CR) 10Jforrester: [C: 03+2] "Ah, nice." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/656557 (owner: 10Umherirrender) [17:43:54] (03Merged) 10jenkins-bot: Improve check for test function in FunctionCommentSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/656557 (owner: 10Umherirrender) [18:17:37] (03PS4) 10Umherirrender: Use PHPUnitTestTrait in LowerCamelFunctionsNameSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/656560 [18:18:16] (03PS2) 10Umherirrender: Expand FunctionCommentSniff::SKIP_STANDARD_METHODS [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/656566 [18:34:07] (03CR) 10Jforrester: [C: 03+2] Use PHPUnitTestTrait in LowerCamelFunctionsNameSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/656560 (owner: 10Umherirrender) [18:35:13] (03CR) 10Jforrester: [C: 03+1] Expand FunctionCommentSniff::SKIP_STANDARD_METHODS (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/656566 (owner: 10Umherirrender) [18:35:21] (03Merged) 10jenkins-bot: Use PHPUnitTestTrait in LowerCamelFunctionsNameSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/656560 (owner: 10Umherirrender) [18:50:30] (03CR) 10Umherirrender: Expand FunctionCommentSniff::SKIP_STANDARD_METHODS (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/656566 (owner: 10Umherirrender) [18:51:11] (03CR) 10Jforrester: [C: 03+2] Expand FunctionCommentSniff::SKIP_STANDARD_METHODS [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/656566 (owner: 10Umherirrender) [18:52:22] (03Merged) 10jenkins-bot: Expand FunctionCommentSniff::SKIP_STANDARD_METHODS [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/656566 (owner: 10Umherirrender) [20:00:03] Project mwcore-phpunit-coverage-master build #1158: 04STILL FAILING in 5 hr 0 min: https://integration.wikimedia.org/ci/job/mwcore-phpunit-coverage-master/1158/ [20:07:27] ^ timed out [20:07:47] Reedy: ^ [20:29:02] it's been broken for a while [20:29:41] Okay [20:29:45] * RhinosF1 shrugs [20:29:55] Write simpler code and it'll pass again. [20:30:50] I've spent enough time this week simplifying code [20:31:20] * James_F grins. [20:33:37] I'm scared to look at some of the code I maintain [20:33:42] Because it's that bad [20:35:08] RhinosF1: let me introduce you to FlaggedRevs [20:36:23] Majavah: I've found code that I cut it down to ~20% of its original size without loosing any functionality [20:37:19] Using 1000 npm libraries is cheating [20:37:53] you don't like is-odd and is-even? [20:37:53] No, the code was just that much bloat [20:38:00] I've done it a few times [20:38:34] People are very good at duplicating code [20:39:07] * RhinosF1 also wonders why people don't deal with code style from the start [20:39:46] RhinosF1: because that new feature needs to be available in production yesterday, you can fix the style later of course [20:39:47] It would help a lot if people didn't write code where half the variable are a single letter and consistency doesn't exist [20:41:02] Majavah: I've stopped allowing that [20:41:37] * RhinosF1 is very strict on code meeting certain standards and if your feature is that important, you can fix your style [20:42:01] The only thing I'll waver on is line length [20:43:16] I've been trying to clean up CentralAuth's code but no-one is reviewing my patches :( [20:43:29] :( [20:44:28] I'm unfortunately at python dev [20:44:37] So can't help with central auth [23:12:03] kostajh: so... I had to try out mediawiki-docker (vs mwdd) and... yeah, it'd be great not to have to stash my previous LocalSettings.php elsewhere while doing so. Circling back to the ENV issue, I guess one way to make it simple *and* performant for production, might be to structure it such that a LocalSettings.php file has precedence, but that absence of one try a standard ENV variable, before serving the "No LS" error page. [23:12:58] I'm also thinking about this in context of PlatformSettings.php, of which the outcome previously led me to think it was better to leave this out of core and instead have users add indirection to their LocalSettings.php as they see fit. And indeed that seems easy, you (or the installer) just creates a 2-line LS.php file that reads ENV and loads whatever file you want to load etc. [23:13:17] that plays fine for distributions like debian and other things using PlatformSettings.php [23:13:44] but doesn't play well when you are developing locally and want to utilise multiple otherwise completely unrelated and independent distros/environments to test with [23:14:19] then you need them to agree on an ENV name and create the exact same placeholder file, at whicih point it makes sense to bring that into core rathe rthan trying to herd each dev env to do it the same way [23:16:11] (03PS2) 10Jforrester: Follow-up 7123732e: dockerfiles: Also cascade new php-ast image [integration/config] - 10https://gerrit.wikimedia.org/r/656441 (https://phabricator.wikimedia.org/T271428) [23:16:24] (03PS2) 10Jforrester: jjb: Update jobs for php-ast 1.0.10 update [integration/config] - 10https://gerrit.wikimedia.org/r/656442 (https://phabricator.wikimedia.org/T271428) [23:16:42] (03PS3) 10Jforrester: Follow-up 7123732e: dockerfiles: Also cascade new php-ast image [integration/config] - 10https://gerrit.wikimedia.org/r/656441 (https://phabricator.wikimedia.org/T271428) [23:21:54] (03CR) 10Jforrester: [C: 03+2] Follow-up 7123732e: dockerfiles: Also cascade new php-ast image [integration/config] - 10https://gerrit.wikimedia.org/r/656441 (https://phabricator.wikimedia.org/T271428) (owner: 10Jforrester) [23:23:12] (03Merged) 10jenkins-bot: Follow-up 7123732e: dockerfiles: Also cascade new php-ast image [integration/config] - 10https://gerrit.wikimedia.org/r/656441 (https://phabricator.wikimedia.org/T271428) (owner: 10Jforrester) [23:23:35] (03PS3) 10Jforrester: jjb: Update jobs for php-ast 1.0.10 update [integration/config] - 10https://gerrit.wikimedia.org/r/656442 (https://phabricator.wikimedia.org/T271428) [23:24:19] !log Docker: Building cascade of new php-ast image T271428 [23:24:22] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [23:24:22] T271428: Bump php-ast to 1.0.10 for all phan jobs - https://phabricator.wikimedia.org/T271428 [23:48:23] (03PS4) 10Jforrester: jjb: Update jobs for php-ast 1.0.10 update [integration/config] - 10https://gerrit.wikimedia.org/r/656442 (https://phabricator.wikimedia.org/T271428) [23:48:34] (03CR) 10Jforrester: [C: 03+2] "Deployed." [integration/config] - 10https://gerrit.wikimedia.org/r/656442 (https://phabricator.wikimedia.org/T271428) (owner: 10Jforrester) [23:49:58] (03Merged) 10jenkins-bot: jjb: Update jobs for php-ast 1.0.10 update [integration/config] - 10https://gerrit.wikimedia.org/r/656442 (https://phabricator.wikimedia.org/T271428) (owner: 10Jforrester)