[01:26:56] Strange, php code sniffer did not detect this unexpected indentation on RHS line 150: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/655765/2/includes/libs/rdbms/loadmonitor/LoadMonitor.php [02:22:19] (03CR) 10Subramanya Sastry: "> Patch Set 1:" [integration/visualdiff] - 10https://gerrit.wikimedia.org/r/654310 (https://phabricator.wikimedia.org/T258719) (owner: 10Arlolra) [06:38:20] 10Diffusion, 10Gerrit, 10Release-Engineering-Team, 10Wikimedia-GitHub: Create and maintain somehow a list of repos mastered in GitHub (and in Phabricator Diffusion) - https://phabricator.wikimedia.org/T237470 (10Ladsgroup) I just want to point out some unexpected part of keeping canonical repos in github.... [08:00:03] Project mwcore-phpunit-coverage-master build #1163: 04STILL FAILING in 5 hr 0 min: https://integration.wikimedia.org/ci/job/mwcore-phpunit-coverage-master/1163/ [09:30:25] 10Release-Engineering-Team (Kanban), 10Discovery, 10Discovery-Search (Current work), 10Patch-For-Review: [Epic] Port Selenium tests from Ruby to Node.js for the Search Platform - https://phabricator.wikimedia.org/T174103 (10Pradhanmantriinfo) Change 399178 had a related patch set uploaded [[ https://pra... [09:45:33] (03PS2) 10Hashar: test: make test failures under Python3 fail tox test run [tools/scap] - 10https://gerrit.wikimedia.org/r/656951 (https://phabricator.wikimedia.org/T246025) (owner: 10Lars Wirzenius) [09:45:35] (03PS1) 10Hashar: tests: pytest should not process our json logs [tools/scap] - 10https://gerrit.wikimedia.org/r/657055 (https://phabricator.wikimedia.org/T246025) [09:46:00] (03CR) 10Hashar: test: make test failures under Python3 fail tox test run (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/656951 (https://phabricator.wikimedia.org/T246025) (owner: 10Lars Wirzenius) [09:53:18] (03CR) 10Hashar: [C: 04-1] "Rebased on top of https://gerrit.wikimedia.org/r/c/mediawiki/tools/scap/+/657055/1 which fixes the test. See inline for actual review of " (032 comments) [tools/scap] - 10https://gerrit.wikimedia.org/r/656951 (https://phabricator.wikimedia.org/T246025) (owner: 10Lars Wirzenius) [09:55:12] (03CR) 10Hashar: [C: 04-1] "And I forgot scap.git relies on the pipeline which only has python2.7 in the crafted image. So we got:" [tools/scap] - 10https://gerrit.wikimedia.org/r/656951 (https://phabricator.wikimedia.org/T246025) (owner: 10Lars Wirzenius) [09:58:28] awight: kostajh: can't do it for the quibble meeting since I got kids at lunch again ;D [09:58:42] the only update is that I got to move the CI jobs to be based on buster first [09:58:59] then I guess once that has settled the images can be updated to use the latest Quibble [09:59:07] or the other way around [09:59:50] kids & [10:06:35] hasharOut: kostajh: just checking, it looks like we're not meeting about Quibble today? [12:15:41] awight: correct, cant make it at this hour :/ [12:46:56] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services): Puppet is failing to run on the "integration-cumin.integration.eqiad.wmflabs" instance in Wikimedia Cloud VPS. - https://phabricator.wikimedia.org/T272362 (10hashar) [12:48:36] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services): Puppet is failing to run on the "integration-cumin.integration.eqiad.wmflabs" instance in Wikimedia Cloud VPS. - https://phabricator.wikimedia.org/T272362 (10hashar) [12:54:59] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services): Puppet is failing to run on the "integration-cumin.integration.eqiad.wmflabs" instance in Wikimedia Cloud VPS. - https://phabricator.wikimedia.org/T272362 (10hashar) 05Open→03Resolved a:03hashar The instance pupp... [13:17:23] (03PS1) 10Hashar: jjb: gearman-java jobs should timeout earlier [integration/config] - 10https://gerrit.wikimedia.org/r/657073 (https://phabricator.wikimedia.org/T271683) [13:17:42] (03CR) 10Hashar: [C: 03+2] "Deploy" [integration/config] - 10https://gerrit.wikimedia.org/r/657073 (https://phabricator.wikimedia.org/T271683) (owner: 10Hashar) [13:19:12] (03Merged) 10jenkins-bot: jjb: gearman-java jobs should timeout earlier [integration/config] - 10https://gerrit.wikimedia.org/r/657073 (https://phabricator.wikimedia.org/T271683) (owner: 10Hashar) [13:30:40] (03CR) 10Hashar: Update pom.xml and target java8 (031 comment) [integration/gearman-java] - 10https://gerrit.wikimedia.org/r/655662 (owner: 10Hashar) [13:33:08] (03PS4) 10Hashar: Update pom.xml and target java8 [integration/gearman-java] - 10https://gerrit.wikimedia.org/r/655662 [13:35:04] (03CR) 10Lars Wirzenius: [C: 03+2] "This is a better way to avoid the Pytest injected code from breaking the test. I'm going to CR+2 this, but I'll note that this whole debac" [tools/scap] - 10https://gerrit.wikimedia.org/r/657055 (https://phabricator.wikimedia.org/T246025) (owner: 10Hashar) [13:36:12] (03PS4) 10Hashar: Fix read infinite loop under Java 11 [integration/gearman-java] - 10https://gerrit.wikimedia.org/r/655663 (https://phabricator.wikimedia.org/T271683) [13:36:24] (03CR) 10Hashar: "check experimental" [integration/gearman-java] - 10https://gerrit.wikimedia.org/r/655662 (owner: 10Hashar) [13:36:31] (03CR) 10Hashar: "check experimental" [integration/gearman-java] - 10https://gerrit.wikimedia.org/r/655663 (https://phabricator.wikimedia.org/T271683) (owner: 10Hashar) [13:37:13] (03Merged) 10jenkins-bot: tests: pytest should not process our json logs [tools/scap] - 10https://gerrit.wikimedia.org/r/657055 (https://phabricator.wikimedia.org/T246025) (owner: 10Hashar) [13:38:19] gehel: another fun java8 > 11 migration step. The `javadoc` executable is at a different place so I went with some maven profiles for each java to set javadocExecutable properly https://gerrit.wikimedia.org/r/c/integration/gearman-java/+/655662/4/pom.xml :] [14:06:48] (03CR) 10Lars Wirzenius: "I can make changes (drop ignore_outcome=True) or I'm OK with this version. What do you all think?" (032 comments) [tools/scap] - 10https://gerrit.wikimedia.org/r/656951 (https://phabricator.wikimedia.org/T246025) (owner: 10Lars Wirzenius) [14:25:18] (03CR) 10Hashar: [V: 03+2 C: 03+2] "Thanks Ahmon. This one can go before CI is configured it is straightforward." [integration/gearman-java] - 10https://gerrit.wikimedia.org/r/655660 (owner: 10Hashar) [14:25:41] (03CR) 10Hashar: [V: 03+2 C: 03+2] "Thanks Ahmon. This one can go before CI is configured it is straightforward." [integration/gearman-java] - 10https://gerrit.wikimedia.org/r/655661 (owner: 10Hashar) [14:28:22] (03PS1) 10Hashar: zuul: add java8 jobs for gearman-java [integration/config] - 10https://gerrit.wikimedia.org/r/657094 (https://phabricator.wikimedia.org/T271683) [14:28:55] (03CR) 10Hashar: [C: 03+2] "Java8 passed on https://gerrit.wikimedia.org/r/c/integration/gearman-java/+/655662/" [integration/config] - 10https://gerrit.wikimedia.org/r/657094 (https://phabricator.wikimedia.org/T271683) (owner: 10Hashar) [14:30:08] (03PS1) 10Hashar: zuul: add java11 jobs for gearman-java [integration/config] - 10https://gerrit.wikimedia.org/r/657097 (https://phabricator.wikimedia.org/T271683) [14:30:36] (03Merged) 10jenkins-bot: zuul: add java8 jobs for gearman-java [integration/config] - 10https://gerrit.wikimedia.org/r/657094 (https://phabricator.wikimedia.org/T271683) (owner: 10Hashar) [14:30:52] (03PS5) 10Hashar: Fix read infinite loop under Java 11 [integration/gearman-java] - 10https://gerrit.wikimedia.org/r/655663 (https://phabricator.wikimedia.org/T271683) [14:32:07] (03CR) 10Hashar: "It is probably ready to go, but we will first need CI to be configured to run the Java 11 based jobs, so I have marked this gearman-java c" [integration/gearman-java] - 10https://gerrit.wikimedia.org/r/655663 (https://phabricator.wikimedia.org/T271683) (owner: 10Hashar) [14:32:58] (03CR) 10Hashar: "recheck after CI got made to run the java8 job https://gerrit.wikimedia.org/r/c/integration/config/+/657094" [integration/gearman-java] - 10https://gerrit.wikimedia.org/r/655662 (owner: 10Hashar) [14:35:40] (03CR) 10jerkins-bot: [V: 04-1] Update pom.xml and target java8 [integration/gearman-java] - 10https://gerrit.wikimedia.org/r/655662 (owner: 10Hashar) [14:35:49] ohhh my [14:35:50] god [15:08:05] (03CR) 10Hashar: "The test that fails with a timeout is:" [integration/gearman-java] - 10https://gerrit.wikimedia.org/r/655662 (owner: 10Hashar) [15:21:57] (03CR) 10Hashar: "recheck race condition / perf issue? :-\" [integration/gearman-java] - 10https://gerrit.wikimedia.org/r/655662 (owner: 10Hashar) [15:28:26] (03CR) 10Hashar: "recheck bis" [integration/gearman-java] - 10https://gerrit.wikimedia.org/r/655662 (owner: 10Hashar) [15:33:31] (03CR) 10Arlolra: "> Patch Set 1:" [integration/visualdiff] - 10https://gerrit.wikimedia.org/r/654310 (https://phabricator.wikimedia.org/T258719) (owner: 10Arlolra) [15:52:20] 10Phabricator-Bot-Requests, 10observability: Create Phabricator bot for Alertmanager - https://phabricator.wikimedia.org/T272391 (10fgiunchedi) [16:00:18] 10Diffusion, 10Gerrit, 10Release-Engineering-Team, 10Wikimedia-GitHub: Create and maintain somehow a list of repos mastered in GitHub (and in Phabricator Diffusion) - https://phabricator.wikimedia.org/T237470 (10thcipriani) >>! In T237470#6756842, @Ladsgroup wrote: > I just want to point out some unexpecte... [16:22:39] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Patch-For-Review, 10Release, 10Train Deployments, 10User-brennen: 1.36.0-wmf.27 deployment blockers - https://phabricator.wikimedia.org/T271341 (10brennen) [16:24:30] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10SRE, 10serviceops, 10User-jijiki: Upgrade MediaWiki clusters to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10ops-monitoring-bot) Script wmf-auto-reimage was launched by dzahn on cumin1001.eqia... [16:24:43] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10SRE, 10serviceops, 10User-jijiki: Upgrade MediaWiki clusters to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10ops-monitoring-bot) Script wmf-auto-reimage was launched by dzahn on cumin1001.eqia... [16:26:03] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10SRE, 10serviceops, 10User-jijiki: Upgrade MediaWiki clusters to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10ops-monitoring-bot) Script wmf-auto-reimage was launched by dzahn on cumin1001.eqia... [16:26:20] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10SRE, 10serviceops, 10User-jijiki: Upgrade MediaWiki clusters to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10ops-monitoring-bot) Script wmf-auto-reimage was launched by dzahn on cumin1001.eqia... [16:49:50] (03CR) 10Thiemo Kreuz (WMDE): New sniff: MediaWiki.PHPUnit.SpecificAssertions (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/649913 (https://phabricator.wikimedia.org/T253618) (owner: 10DannyS712) [16:53:36] (03CR) 10Subramanya Sastry: "> This looks right to me," [integration/visualdiff] - 10https://gerrit.wikimedia.org/r/654310 (https://phabricator.wikimedia.org/T258719) (owner: 10Arlolra) [16:54:42] Hi, how do I disable php80 tests for a repository, please? I want it to be disabled for labs/tools/stewardbots, at least for the timebeing. Thanks! [16:54:51] cc Majavah [16:54:58] Urbanecm: We asked for the repo to be fixed months ago. [16:55:02] No response. [16:55:12] Just V+2 it. [16:55:16] hm, is it really broken _months_? [16:57:31] On PHP 8.0, yes. [16:59:38] James_F: but ci started to enforce it only recently AFAICS. Dunno where were the maintainers asked to fix it, I don't see anything in https://phabricator.wikimedia.org/project/board/1821/. Anyway, let's fix it for real then [16:59:55] Urbanecm: Yeah, sorry. [17:00:29] :) [17:00:40] Ah, the project doesn't have 'labs' or 'tools' in it so I couldn't find the project and assumed it didn't exist. [17:00:48] I asked in -stewards but got no response. [17:01:34] 10Release-Engineering-Team (CI & Testing services), 10stewardbots: PHP 8.0 support - https://phabricator.wikimedia.org/T272399 (10Jdforrester-WMF) [17:01:35] There. [17:05:25] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10SRE, 10serviceops, 10User-jijiki: Upgrade MediaWiki clusters to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10ops-monitoring-bot) Completed auto-reimage of hosts: ` ['mw2312.codfw.wmnet'] ` an... [17:06:08] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10SRE, 10serviceops, 10User-jijiki: Upgrade MediaWiki clusters to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10ops-monitoring-bot) Completed auto-reimage of hosts: ` ['mw2313.codfw.wmnet'] ` an... [17:07:20] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10SRE, 10serviceops, 10User-jijiki: Upgrade MediaWiki clusters to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10ops-monitoring-bot) Completed auto-reimage of hosts: ` ['mw2315.codfw.wmnet'] ` an... [17:07:38] (03PS1) 10Jforrester: Zuul: [mediawiki/services/function-orchestrator] Add pipeline CI [integration/config] - 10https://gerrit.wikimedia.org/r/657153 (https://phabricator.wikimedia.org/T271761) [17:07:51] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10SRE, 10serviceops, 10User-jijiki: Upgrade MediaWiki clusters to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10ops-monitoring-bot) Completed auto-reimage of hosts: ` ['mw2314.codfw.wmnet'] ` an... [17:09:40] (03CR) 10Jforrester: [C: 03+2] Zuul: [mediawiki/services/function-orchestrator] Add pipeline CI [integration/config] - 10https://gerrit.wikimedia.org/r/657153 (https://phabricator.wikimedia.org/T271761) (owner: 10Jforrester) [17:10:56] (03Merged) 10jenkins-bot: Zuul: [mediawiki/services/function-orchestrator] Add pipeline CI [integration/config] - 10https://gerrit.wikimedia.org/r/657153 (https://phabricator.wikimedia.org/T271761) (owner: 10Jforrester) [17:11:06] !log Zuul: [mediawiki/services/function-orchestrator] Add pipeline CI T271761 [17:11:09] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [17:11:09] T271761: Create initial Function Orchestrator service - https://phabricator.wikimedia.org/T271761 [17:29:17] (03PS5) 10Hashar: Update pom.xml and target java8 [integration/gearman-java] - 10https://gerrit.wikimedia.org/r/655662 [17:34:20] 10Diffusion, 10Gerrit, 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Wikimedia-GitHub: Create and maintain somehow a list of repos mastered in GitHub (and in Phabricator Diffusion) - https://phabricator.wikimedia.org/T237470 (10thcipriani) p:05Triage→03Low a:03thcipriani To updat... [17:34:47] (03CR) 10Ahmon Dancy: [C: 03+1] Update pom.xml and target java8 [integration/gearman-java] - 10https://gerrit.wikimedia.org/r/655662 (owner: 10Hashar) [17:36:50] 10Diffusion, 10Gerrit, 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Wikimedia-GitHub: Create and maintain a list of organization repos that are maintained on Gerrit, GitHub, and Diffusion - https://phabricator.wikimedia.org/T237470 (10thcipriani) [17:42:20] (03CR) 10Ahmon Dancy: [C: 03+2] "let 'er rip" [integration/gearman-java] - 10https://gerrit.wikimedia.org/r/655662 (owner: 10Hashar) [17:45:39] (03Merged) 10jenkins-bot: Update pom.xml and target java8 [integration/gearman-java] - 10https://gerrit.wikimedia.org/r/655662 (owner: 10Hashar) [17:49:48] (03CR) 10Hashar: [C: 03+2] zuul: add java11 jobs for gearman-java [integration/config] - 10https://gerrit.wikimedia.org/r/657097 (https://phabricator.wikimedia.org/T271683) (owner: 10Hashar) [17:51:03] (03Merged) 10jenkins-bot: zuul: add java11 jobs for gearman-java [integration/config] - 10https://gerrit.wikimedia.org/r/657097 (https://phabricator.wikimedia.org/T271683) (owner: 10Hashar) [17:52:50] (03CR) 10Hashar: "recheck after enabling CI java 11 job ( https://gerrit.wikimedia.org/r/c/integration/config/+/657097 )" [integration/gearman-java] - 10https://gerrit.wikimedia.org/r/655663 (https://phabricator.wikimedia.org/T271683) (owner: 10Hashar) [17:55:32] (03CR) 10jerkins-bot: [V: 04-1] Fix read infinite loop under Java 11 [integration/gearman-java] - 10https://gerrit.wikimedia.org/r/655663 (https://phabricator.wikimedia.org/T271683) (owner: 10Hashar) [18:24:52] 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Scap: Applying security patches should be robust and also give some useful output - https://phabricator.wikimedia.org/T269153 (10brennen) Noting here that I ran into a situation with a patch... [18:42:49] (03PS1) 10Umherirrender: Check for yield in AssignmentInReturnSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/657168 [18:43:32] (03PS1) 10Umherirrender: Check for yield in FunctionCommentSniff when looking for @return [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/657169 [18:55:18] (03PS2) 10Yaron Koren: layout: Add CI for mediawiki/extensions/Acrolinx [integration/config] - 10https://gerrit.wikimedia.org/r/657110 [19:17:02] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10MW-on-K8s, 10Release Pipeline, 10serviceops: Request volume for Docker images and container filesystems on releases machines - https://phabricator.wikimedia.org/T272092 (10dduvall) >>! In T272092#674... [19:27:41] 10Release-Engineering-Team-TODO, 10MediaWiki-Docker, 10Developer Productivity, 10Patch-For-Review, 10User-Addshore: Port mediawiki-docker-dev "mwdd" v1 cli in to go - https://phabricator.wikimedia.org/T253313 (10kostajh) >>! In T253313#6158412, @Addshore wrote: > In PS9 of https://gerrit.wikimedia.org/r/... [19:30:01] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10MW-on-K8s, 10Release Pipeline, 10serviceops: Request volume for Docker images and container filesystems on releases machines - https://phabricator.wikimedia.org/T272092 (10dancy) +1 on the estimate. [19:54:54] 10Release-Engineering-Team (CI & Testing services), 10stewardbots, 10PHP 8.0 support: PHP 8.0 support - https://phabricator.wikimedia.org/T272399 (10Aklapper) [19:56:36] 10Release-Engineering-Team (CI & Testing services), 10stewardbots, 10PHP 8.0 support, 10User-Urbanecm: PHP 8.0 support - https://phabricator.wikimedia.org/T272399 (10Jdforrester-WMF) a:03Urbanecm [20:00:03] Project mwcore-phpunit-coverage-master build #1164: 04STILL FAILING in 5 hr 0 min: https://integration.wikimedia.org/ci/job/mwcore-phpunit-coverage-master/1164/ [20:22:13] Project mediawiki-core-doxygen-docker build #22008: 04FAILURE in 17 min: https://integration.wikimedia.org/ci/job/mediawiki-core-doxygen-docker/22008/ [20:51:13] (03PS1) 10Hashar: Raise client timeout in simpleAttachedJobBulk test [integration/gearman-java] - 10https://gerrit.wikimedia.org/r/657187 [20:51:41] (03PS2) 10Hashar: Raise client timeout in simpleAttachedJobBulk test [integration/gearman-java] - 10https://gerrit.wikimedia.org/r/657187 [20:57:12] (03CR) 10jerkins-bot: [V: 04-1] Raise client timeout in simpleAttachedJobBulk test [integration/gearman-java] - 10https://gerrit.wikimedia.org/r/657187 (owner: 10Hashar) [20:58:39] 10Release-Engineering-Team (CI & Testing services), 10stewardbots, 10PHP 8.0 support, 10User-Urbanecm: PHP 8.0 support - https://phabricator.wikimedia.org/T272399 (10Urbanecm) 05Open→03Resolved Already done with https://gerrit.wikimedia.org/r/c/labs/tools/stewardbots/+/657150. [21:19:38] Yippee, build fixed! [21:19:38] Project mediawiki-core-doxygen-docker build #22009: 09FIXED in 15 min: https://integration.wikimedia.org/ci/job/mediawiki-core-doxygen-docker/22009/ [21:22:40] 10MediaWiki-Codesniffer, 10MediaWiki-General, 10TechCom, 10at-ease, 10Proposal: Liberate the @ for AtEase - https://phabricator.wikimedia.org/T253461 (10Jdforrester-WMF) This should probably have a custom sniff to spot use of AtEase and require use of `phpcs:ignore` instead. [21:35:07] (03CR) 10DannyS712: "can you add a test case please?" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/657168 (owner: 10Umherirrender) [21:35:24] (03CR) 10DannyS712: "can you add a test case please?" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/657169 (owner: 10Umherirrender) [21:36:10] 10LibUp, 10FR-Smashpig, 10Fundraising-Backlog, 10Fundraising Sprint Airline Passenger Experience, and 2 others: LibUp times out trying to update mediawiki/extensions/DonationInterface because of unsatisfiable dependencies - https://phabricator.wikimedia.org/T271180 (10DStrine) [21:58:36] (03CR) 10Hashar: "No luck gotta dig more" (032 comments) [integration/gearman-java] - 10https://gerrit.wikimedia.org/r/657187 (owner: 10Hashar) [22:00:08] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Patch-For-Review, 10Release, 10Train Deployments, 10User-brennen: 1.36.0-wmf.27 deployment blockers - https://phabricator.wikimedia.org/T271341 (10brennen) [22:14:52] (03PS2) 10Umherirrender: Check for yield in AssignmentInReturnSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/657168 [22:15:19] (03CR) 10Umherirrender: "> Patch Set 1:" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/657168 (owner: 10Umherirrender) [22:28:49] (03PS2) 10Umherirrender: Check for yield in FunctionCommentSniff when looking for @return [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/657169 [22:29:06] (03CR) 10Umherirrender: "> Patch Set 1:" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/657169 (owner: 10Umherirrender) [22:39:26] 10Phabricator-Bot-Requests, 10observability: Create Phabricator bot for Alertmanager - https://phabricator.wikimedia.org/T272391 (10Aklapper) a:03Aklapper @fgiunchedi: Hi, @phaultfinder account created. P13840 includes the token. Please resolve this task once it works as expected. Thanks! :) [22:48:08] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Patch-For-Review, 10Release, 10Train Deployments, 10User-brennen: 1.36.0-wmf.27 deployment blockers - https://phabricator.wikimedia.org/T271341 (10brennen) As we're coming up on 15:00 Pacific, blocking on T272428 for the (US) day. Can res... [22:51:39] (03CR) 10Umherirrender: "Maybe needs handling for yield (coming with I8859663c7a7462230e18e1f68c7560e3231d80a5), because an empty "yield;" returns null, not void -" (033 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/591451 (https://phabricator.wikimedia.org/T168994) (owner: 10DannyS712) [22:53:53] (03PS3) 10Umherirrender: Check for yield in FunctionCommentSniff when looking for @return [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/657169 [22:53:56] (03CR) 10Umherirrender: "Own token for T_YIELD_FROM - https://www.php.net/manual/en/language.generators.syntax.php#control-structures.yield.from" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/657169 (owner: 10Umherirrender) [22:54:15] (03PS3) 10Umherirrender: Check for yield in AssignmentInReturnSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/657168 [22:54:19] (03CR) 10Umherirrender: "Own token for T_YIELD_FROM - https://www.php.net/manual/en/language.generators.syntax.php#control-structures.yield.from" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/657168 (owner: 10Umherirrender) [23:03:13] (03PS2) 10Jeena Huneidi: Fix documentation for deploy step [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/649445 (owner: 10Dduvall) [23:05:28] (03CR) 10Jeena Huneidi: [C: 03+2] Fix documentation for deploy step [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/649445 (owner: 10Dduvall) [23:06:05] (03Merged) 10jenkins-bot: Fix documentation for deploy step [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/649445 (owner: 10Dduvall) [23:16:04] 10Gerrit, 10Phabricator, 10Release-Engineering-Team, 10Diffusion-Repository-Administrators, 10Wikimedia-GitHub: Create some automation for management of gerrit/phabricator/github mirrors - https://phabricator.wikimedia.org/T235874 (10thcipriani) [23:16:13] 10Diffusion, 10Gerrit, 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Wikimedia-GitHub: Create and maintain a list of organization repos that are maintained on Gerrit, GitHub, and Diffusion - https://phabricator.wikimedia.org/T237470 (10thcipriani) 05Open→03Resolved TIL thanks to @m... [23:17:27] (03PS4) 10Umherirrender: Check for yield in AssignmentInReturnSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/657168 [23:27:21] (03CR) 10DannyS712: [C: 03+1] Check for yield in AssignmentInReturnSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/657168 (owner: 10Umherirrender) [23:27:46] (03CR) 10DannyS712: [C: 03+1] Check for yield in FunctionCommentSniff when looking for @return [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/657169 (owner: 10Umherirrender) [23:31:32] (03CR) 10Jforrester: [C: 03+2] Check for yield in FunctionCommentSniff when looking for @return [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/657169 (owner: 10Umherirrender) [23:34:12] (03CR) 10Jforrester: [C: 03+2] Check for yield in AssignmentInReturnSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/657168 (owner: 10Umherirrender) [23:41:16] (03Merged) 10jenkins-bot: Check for yield in FunctionCommentSniff when looking for @return [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/657169 (owner: 10Umherirrender) [23:41:46] (03CR) 10jerkins-bot: [V: 04-1] Check for yield in AssignmentInReturnSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/657168 (owner: 10Umherirrender) [23:43:01] (03PS5) 10Jforrester: Check for yield in AssignmentInReturnSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/657168 (owner: 10Umherirrender) [23:52:24] (03CR) 10Jforrester: [C: 03+2] "…" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/657168 (owner: 10Umherirrender) [23:56:06] (03Merged) 10jenkins-bot: Check for yield in AssignmentInReturnSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/657168 (owner: 10Umherirrender) [23:58:24] (03PS2) 10Jforrester: Rewrite ParenthesesAroundKeywordSniff to fix whitespace handling [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/650595 (https://phabricator.wikimedia.org/T265741) (owner: 10Umherirrender) [23:58:55] (03CR) 10Zoranzoki21: [C: 03+1] "LGTM!" [integration/config] - 10https://gerrit.wikimedia.org/r/657110 (owner: 10Yaron Koren)