[00:16:44] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10SRE, 10serviceops, 10User-jijiki: Upgrade MediaWiki clusters to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10ops-monitoring-bot) Completed auto-reimage of hosts: ` ['mw1278.eqiad.wmnet'] ` an... [00:21:01] 10phan, 10MediaWiki-General, 10ci-test-error: Adding (return) type hints to mediawiki/core function can break phan runs on extensions - https://phabricator.wikimedia.org/T273936 (10Daimona) I guess we have three main options: # Just fix the issues when they occur (not really a solution, I know) # Write a c... [00:26:56] 10phan, 10MediaWiki-General, 10ci-test-error: Adding (return) type hints to mediawiki/core function can break phan runs on extensions - https://phabricator.wikimedia.org/T273936 (10DannyS712) >>! In T273936#6805492, @Daimona wrote: > I guess we have three main options: > # Just fix the issues when they occu... [00:38:57] 10phan-taint-check-plugin, 10Platform Team Workboards (MW Expedition): Obscure phan taint-check failures for ActorStore patches - https://phabricator.wikimedia.org/T273932 (10Daimona) > in seemingly entirely unrelated codepaths This is a direct consequence of how taint-check tracks method dependencies. It bui... [00:54:39] (03PS1) 10Eileen: Remove reference to drupal repo [integration/config] - 10https://gerrit.wikimedia.org/r/661825 [00:56:06] (03CR) 10jerkins-bot: [V: 04-1] Remove reference to drupal repo [integration/config] - 10https://gerrit.wikimedia.org/r/661825 (owner: 10Eileen) [00:58:45] (03PS1) 10Eileen: Remove drupal submodule from docker zuul coner [integration/config] - 10https://gerrit.wikimedia.org/r/661826 (https://phabricator.wikimedia.org/T273822) [01:05:10] (03PS2) 10Eileen: Remove drupal submodule from docker zuul coner [integration/config] - 10https://gerrit.wikimedia.org/r/661826 (https://phabricator.wikimedia.org/T273822) [01:06:12] (03PS3) 10Eileen: Remove drupal submodule from docker zuul coner [integration/config] - 10https://gerrit.wikimedia.org/r/661826 (https://phabricator.wikimedia.org/T273822) [01:06:14] (03PS2) 10Eileen: Remove reference to drupal repo [integration/config] - 10https://gerrit.wikimedia.org/r/661825 [01:06:16] (03PS1) 10Eileen: Attempt to switch to recurse_submodules [integration/config] - 10https://gerrit.wikimedia.org/r/661828 (https://phabricator.wikimedia.org/T273822) [01:07:24] (03CR) 10jerkins-bot: [V: 04-1] Remove reference to drupal repo [integration/config] - 10https://gerrit.wikimedia.org/r/661825 (owner: 10Eileen) [01:24:22] (03PS1) 10Eileen: Switch fundraising tech setup to use recurse_submodules [integration/config] - 10https://gerrit.wikimedia.org/r/661829 (https://phabricator.wikimedia.org/T273822) [01:25:45] (03CR) 10jerkins-bot: [V: 04-1] Switch fundraising tech setup to use recurse_submodules [integration/config] - 10https://gerrit.wikimedia.org/r/661829 (https://phabricator.wikimedia.org/T273822) (owner: 10Eileen) [01:27:46] (03PS2) 10Eileen: Switch fundraising tech setup to use recurse_submodules [integration/config] - 10https://gerrit.wikimedia.org/r/661829 (https://phabricator.wikimedia.org/T273822) [01:48:10] (03Abandoned) 10Eileen: Switch fundraising tech setup to use recurse_submodules [integration/config] - 10https://gerrit.wikimedia.org/r/661829 (https://phabricator.wikimedia.org/T273822) (owner: 10Eileen) [01:48:20] (03Abandoned) 10Eileen: Remove drupal submodule from docker zuul coner [integration/config] - 10https://gerrit.wikimedia.org/r/661826 (https://phabricator.wikimedia.org/T273822) (owner: 10Eileen) [01:48:32] (03Abandoned) 10Eileen: Remove reference to drupal repo [integration/config] - 10https://gerrit.wikimedia.org/r/661825 (owner: 10Eileen) [01:49:25] (03Restored) 10Eileen: Switch fundraising tech setup to use recurse_submodules [integration/config] - 10https://gerrit.wikimedia.org/r/661829 (https://phabricator.wikimedia.org/T273822) (owner: 10Eileen) [01:50:03] (03Abandoned) 10Eileen: Attempt to switch to recurse_submodules [integration/config] - 10https://gerrit.wikimedia.org/r/661828 (https://phabricator.wikimedia.org/T273822) (owner: 10Eileen) [01:57:14] 10Phabricator, 10Project-Admins, 10Diffusion-Repository-Administrators: Modify projects Wikimedia-VE-Tech and related ACL to use for WikiSP - https://phabricator.wikimedia.org/T273344 (10White-Master) @Aklapper any update about this? [01:57:41] 10Project-Admins: Create project tag for WikiSP - https://phabricator.wikimedia.org/T273346 (10White-Master) Any update about this? [02:22:17] Project mediawiki-core-doxygen-docker build #22408: 04FAILURE in 17 min: https://integration.wikimedia.org/ci/job/mediawiki-core-doxygen-docker/22408/ [03:19:24] Yippee, build fixed! [03:19:24] Project mediawiki-core-doxygen-docker build #22409: 09FIXED in 14 min: https://integration.wikimedia.org/ci/job/mediawiki-core-doxygen-docker/22409/ [05:31:12] (03CR) 10DannyS712: "This change is ready for review." [integration/config] - 10https://gerrit.wikimedia.org/r/661661 (owner: 10DannyS712) [08:05:25] (03PS1) 10Zoranzoki21: Archive ConfigurableCounters and PreferencesMaster extensions [integration/config] - 10https://gerrit.wikimedia.org/r/661886 (https://phabricator.wikimedia.org/T240784) [08:37:01] (03CR) 10Hashar: [C: 03+2] Archive the Solarium extension [integration/config] - 10https://gerrit.wikimedia.org/r/661792 (https://phabricator.wikimedia.org/T252911) (owner: 10Zoranzoki21) [08:38:23] (03Merged) 10jenkins-bot: Archive the Solarium extension [integration/config] - 10https://gerrit.wikimedia.org/r/661792 (https://phabricator.wikimedia.org/T252911) (owner: 10Zoranzoki21) [08:47:19] hashar: I was trying to reproduce https://phabricator.wikimedia.org/T273242 in beta but failing, I went to https://en.wikipedia.beta.wmflabs.org/wiki/Special:FeedItem/featured/20210202000000/en both as a logged out user and a logged in one but no dice, no errors... were you able to get the item feed to break? [08:47:19] (03CR) 10Hashar: [C: 03+2] Archive ConfigurableCounters and PreferencesMaster extensions [integration/config] - 10https://gerrit.wikimedia.org/r/661886 (https://phabricator.wikimedia.org/T240784) (owner: 10Zoranzoki21) [08:48:11] apergos: I'm still not sure if we're sure that error is FeaturedFeeds breaking or something else [08:48:47] Majavah: I know; I'm trying to answer a question Krinkle raised on one of the 'add more logging' patches about reproducibility [08:48:57] (03Merged) 10jenkins-bot: Archive ConfigurableCounters and PreferencesMaster extensions [integration/config] - 10https://gerrit.wikimedia.org/r/661886 (https://phabricator.wikimedia.org/T240784) (owner: 10Zoranzoki21) [08:55:52] Majavah: how can I get to the list of items in the feed to try each one in turn and see if I get lucky? [09:17:10] apergos: hi, nop I haven't. [09:17:14] the item feed itself should work [09:17:29] it is apparently a deferred job / background job that emit the error [09:17:33] yeah i tried several, they all "just worked" [09:17:35] so [09:18:09] I'm on the log host in beta and grepping through today's logs and nada [09:18:26] these derferred updates shouldn't take that long to have run [09:19:00] anyways I have now commented on the task and on one of the logging patches that so far reproducibility seems to not be possible [09:20:01] 10Phabricator, 10Project-Admins, 10Diffusion-Repository-Administrators: Modify projects Wikimedia-VE-Tech and related ACL to use for WikiSP - https://phabricator.wikimedia.org/T273344 (10Aklapper) I'd prefer to have input if Wikimedia still supports creation of manual Diffusion repositories and then use a pr... [09:20:27] maybe that is reproducible on testwiki [09:21:00] testwiki in beta? [09:21:09] do we have feed items over there? [09:22:19] https://test.wikipedia.org/wiki/Special:Version [09:22:21] the prod one [09:22:51] oh it's still on .29, I didn't realize [09:23:47] well I"ll try over there and see if anything shows up on mwlog [09:23:52] not hopeful but it's worth a shot [09:26:19] apergos: I am trying to create the config on tstwiki [09:26:27] ok! [09:27:24] https://test.wikipedia.org/wiki/MediaWiki:Ffeed-featured-page [09:30:34] nothing yet :-/ [09:32:16] ah we don't have any feed items maybe [09:32:21] right... [09:32:46] how o we make those? [09:33:07] will update the task [09:33:10] but yeah I have created https://test.wikipedia.org/wiki/Wikipedia:Today%27s_featured_article/February_5,_2021 [09:33:21] and it shows up on https://test.wikipedia.org/wiki/Special:FeedItem/featured/20210205000000/en [09:33:27] though well the feed is cached apparently ? [09:37:23] lovely [09:37:34] thanks for making this available though [09:40:51] nothing show up [09:40:56] apergos: reported at https://phabricator.wikimedia.org/T273242#6805983 [09:41:16] who knows really. Maybe that is related to some user preference [09:41:24] or some cached state [09:41:39] yeah I'v been grepping for the memcachedbagostuff error. not happening [09:41:45] thans for the repot [09:41:53] *thanks *report [09:42:44] I'm really beginning to think we need to merge one of these 'additional logging' patches and roll back out to group1 :-( [09:43:01] on test.wikipedia.org we at least benefit from our production logstash and the mwdebug thing [09:43:15] yeah we would need more logs [09:43:23] and investigate on live prod [09:43:34] the thing is [09:43:52] it is a complicated stack of mess (cache + deferred job + featurefeeds) [09:44:31] yeah [09:44:37] hence, more logging... [09:46:19] and if I look at the end of https://gerrit.wikimedia.org/r/c/mediawiki/core/+/661673/2/includes/libs/objectcache/wancache/WANObjectCache.php [09:46:27] I understand nothing about the code [09:46:36] and the comment makes it even more obscure :] [09:47:22] I'm inclined towards the other patch which does less and doesn't have the case issue [09:48:31] https://gerrit.wikimedia.org/r/c/mediawiki/core/+/661456 [09:49:05] (03CR) 10Hashar: [C: 03+2] zuul/layout: remove outdated comment [integration/config] - 10https://gerrit.wikimedia.org/r/661661 (owner: 10DannyS712) [09:49:43] apergos: and the issue might well be caused by something entirely different :| [09:49:52] oh yeah, I have that in mind [09:50:06] it's another reason I lean towards getting more logging out [09:50:27] (03Merged) 10jenkins-bot: zuul/layout: remove outdated comment [integration/config] - 10https://gerrit.wikimedia.org/r/661661 (owner: 10DannyS712) [10:32:14] (03Abandoned) 10Hashar: Add jsonevent-layout to lib, managed by maven [software/gerrit] (deploy/wmf/stable-3.2) - 10https://gerrit.wikimedia.org/r/659289 (https://phabricator.wikimedia.org/T268020) (owner: 10Hashar) [10:33:06] 10Gerrit, 10Release-Engineering-Team (Development services): Use upstream Gerrit.war instead of building our own - https://phabricator.wikimedia.org/T268019 (10hashar) I have done so update to https://wikitech.wikimedia.org/wiki/Gerrit but need to continue. Notably how to retrieve the .jar from upstream and h... [10:33:42] (03Abandoned) 10Hashar: Merge tag 'v2.15.14' into wmf/stable-2.15 [software/gerrit] (wmf/stable-2.15) - 10https://gerrit.wikimedia.org/r/595228 (owner: 10Thcipriani) [10:33:45] (03Abandoned) 10Hashar: Merge branch 'stable-2.16' into wmf/stable-2.16 [software/gerrit] (wmf/stable-2.16) - 10https://gerrit.wikimedia.org/r/593836 (owner: 10Paladox) [10:33:48] (03Abandoned) 10Hashar: Merge branch 'stable-2.16' into wmf/stable-2.16 [software/gerrit] (wmf/stable-2.16) - 10https://gerrit.wikimedia.org/r/549901 (owner: 10Paladox) [10:33:51] (03Abandoned) 10Hashar: Add websession-flatfile plugin [software/gerrit] (wmf/stable-2.15) - 10https://gerrit.wikimedia.org/r/543940 (https://phabricator.wikimedia.org/T222472) (owner: 10Paladox) [10:33:54] (03Abandoned) 10Hashar: Merge branch 'stable-2.16' into wmf/stable-2.16 [software/gerrit] (wmf/stable-2.16) - 10https://gerrit.wikimedia.org/r/518447 (owner: 10Paladox) [10:33:57] (03Abandoned) 10Hashar: Update image-diff plugin [software/gerrit] (wmf/stable-2.16) - 10https://gerrit.wikimedia.org/r/498427 (owner: 10Paladox) [10:34:00] (03Abandoned) 10Hashar: Add "multi-site" plugin so gerrit can have multi masters [software/gerrit] (wmf/stable-2.16) - 10https://gerrit.wikimedia.org/r/494865 (owner: 10Paladox) [10:37:41] (03CR) 10Thiemo Kreuz (WMDE): Cache PHPUnitTestTrait::isTestFile() results (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/659249 (owner: 10Thiemo Kreuz (WMDE)) [11:40:30] 10Phabricator: tooltip mentions non-existent "Wishlist priority" in Open Tasks by Project and Priority report - https://phabricator.wikimedia.org/T91428 (10Aklapper) [11:41:14] 10phan-taint-check-plugin: Add taintedness data for new methods in Shellbox - https://phabricator.wikimedia.org/T273965 (10Daimona) [11:51:44] 10phan-taint-check-plugin, 10Patch-For-Review: Add taintedness data for new methods in Shellbox - https://phabricator.wikimedia.org/T273965 (10Daimona) a:03Daimona [12:34:07] (03PS5) 10Lars Wirzenius: have tox run scripts/check, require py3 to work, fix [tools/scap] - 10https://gerrit.wikimedia.org/r/661129 [12:34:37] (03CR) 10jerkins-bot: [V: 04-1] have tox run scripts/check, require py3 to work, fix [tools/scap] - 10https://gerrit.wikimedia.org/r/661129 (owner: 10Lars Wirzenius) [12:56:27] (03PS1) 10Hashar: Review access change [extensions/FlickrAPI] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/661662 [12:56:30] (03PS1) 10Hashar: Review access change [extensions/MassMessageEmail] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/661663 [12:56:32] (03PS1) 10Hashar: Review access change [extensions/MetaMaster] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/661664 [12:56:34] (03PS1) 10Hashar: Review access change [extensions/LinkTarget] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/661665 [12:56:36] (03PS1) 10Hashar: Review access change [extensions/NamespaceHTML] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/661926 [12:56:49] (03PS2) 10Hashar: Review access change [extensions/FlickrAPI] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/661662 (https://phabricator.wikimedia.org/T273927) [12:56:55] (03PS2) 10Hashar: Review access change [extensions/MassMessageEmail] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/661663 (https://phabricator.wikimedia.org/T273927) [12:56:58] (03PS2) 10Hashar: Review access change [extensions/MetaMaster] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/661664 (https://phabricator.wikimedia.org/T273927) [12:57:04] (03PS2) 10Hashar: Review access change [extensions/LinkTarget] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/661665 (https://phabricator.wikimedia.org/T273927) [12:57:10] (03PS2) 10Hashar: Review access change [extensions/NamespaceHTML] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/661926 (https://phabricator.wikimedia.org/T273927) [13:05:39] (03Abandoned) 10Hashar: build: Upgrade phpunit to ^9.5 for PHP 8.0 compatibility [integration/docroot] - 10https://gerrit.wikimedia.org/r/651195 (owner: 10Jforrester) [13:09:15] it is friday, it is backlog grooming afternoon ;) [13:10:13] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10SRE-tools, and 2 others: debmonitor: enhance filtering options for packages - https://phabricator.wikimedia.org/T261207 (10hashar) 05Open→03Dec... [13:11:55] (03Abandoned) 10Hashar: Reuse previous artifacts as a wheel cache [integration/zuul/deploy] - 10https://gerrit.wikimedia.org/r/606242 (owner: 10Hashar) [13:12:22] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Zuul, and 4 others: Improve scheduling of CI jobs invoked by zuul - https://phabricator.wikimedia.org/T258630 (10hashar) [13:12:40] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10SRE, 10Patch-For-Review: The python-build images regenerate wheels even when matching ones are already available - https://phabricator.wikimedia.org/T259611 (10hashar) 05Open→... [13:13:25] (03Abandoned) 10Hashar: Add dedicated pipelines for fundraising/REL1_35 [integration/config] - 10https://gerrit.wikimedia.org/r/629320 (https://phabricator.wikimedia.org/T261777) (owner: 10Hashar) [13:17:02] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Fundraising-Backlog, 10Patch-For-Review: JJB / zuul support for upgrading payments-wiki to php7.3 and MW 1.35 - https://phabricator.wikimedia.org/T261777 (... [13:29:08] 10Project-Admins: Create project tag for WikiSP - https://phabricator.wikimedia.org/T273346 (10Aklapper) 05Open→03Resolved a:03Aklapper Requested public project #Wikimedia-Small-Projects-User-Group has been created: https://phabricator.wikimedia.org/project/view/5197/ Interested people are welcome to join... [13:37:05] 10Gerrit, 10Projects-Cleanup: mediawiki/extensions/WSArrays unreachable in Gerrit - https://phabricator.wikimedia.org/T264596 (10hashar) 05Open→03Resolved Checked, it is not in mediawiki/extensions nor in integration/config. I have deleted it from Github though. [13:37:31] 10phan-taint-check-plugin, 10Platform Team Workboards (MW Expedition): Obscure phan taint-check failures for ActorStore patches - https://phabricator.wikimedia.org/T273932 (10Pchelolo) 05Open→03Resolved a:03Pchelolo Thank you. Fixed it. [13:37:44] 10Continuous-Integration-Infrastructure, 10Jenkins, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Patch-For-Review: Upgrade Jenkins Gearman plugin from a forked repo - https://phabricator.wikimedia.org/T271683 (10hashar) p:05Triage... [13:37:50] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Gerrit (Gerrit 3.3), 10Patch-For-Review: Build Gerrit in CI using Bazelisk instead of Bazel - https://phabricator.wikimedia.org/T271205 (10hashar) p:05Triage→03Medium [13:37:55] 10Continuous-Integration-Infrastructure, 10Jenkins, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)): Switch Jenkins servers to Java 11 - https://phabricator.wikimedia.org/T269354 (10hashar) p:05Triage→03Medium [13:40:20] (03CR) 10Hashar: [C: 03+2] dockerfiles: bazelisk a wrapper for Bazel [integration/config] - 10https://gerrit.wikimedia.org/r/647023 (https://phabricator.wikimedia.org/T271205) (owner: 10Hashar) [13:42:08] (03CR) 10Hashar: [C: 03+2] dockerfiles: switch gerrit to use Bazelisk [integration/config] - 10https://gerrit.wikimedia.org/r/654428 (https://phabricator.wikimedia.org/T271205) (owner: 10Hashar) [13:42:20] (03Merged) 10jenkins-bot: dockerfiles: bazelisk a wrapper for Bazel [integration/config] - 10https://gerrit.wikimedia.org/r/647023 (https://phabricator.wikimedia.org/T271205) (owner: 10Hashar) [13:43:19] (03Merged) 10jenkins-bot: dockerfiles: switch gerrit to use Bazelisk [integration/config] - 10https://gerrit.wikimedia.org/r/654428 (https://phabricator.wikimedia.org/T271205) (owner: 10Hashar) [14:06:09] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Gerrit (Gerrit 3.3), 10Patch-For-Review: Build Gerrit in CI using Bazelisk instead of Bazel - https://phabricator.wikimedia.org/T271205 (10hashar) Built: => Building image docker-registry.discovery.wmnet/releng/... [14:27:59] (03PS1) 10Hashar: jjb: switch Gerrit build to Bazelisk [integration/config] - 10https://gerrit.wikimedia.org/r/661920 (https://phabricator.wikimedia.org/T271205) [14:31:28] hashar: o/ am trying to follow https://phabricator.wikimedia.org/T272863, do we just need to merge https://gerrit.wikimedia.org/r/c/integration/config/+/658946 ? [14:38:45] (03CR) 10Hashar: [C: 03+2] "Bazelisk works!" [integration/config] - 10https://gerrit.wikimedia.org/r/661920 (https://phabricator.wikimedia.org/T271205) (owner: 10Hashar) [14:38:46] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Gerrit (Gerrit 3.3), 10Patch-For-Review: Build Gerrit in CI using Bazelisk instead of Bazel - https://phabricator.wikimedia.org/T271205 (10hashar) 05Open→03Resolved Tried against `stable-3.2`: 00:01:02.701 S... [14:40:21] (03Merged) 10jenkins-bot: jjb: switch Gerrit build to Bazelisk [integration/config] - 10https://gerrit.wikimedia.org/r/661920 (https://phabricator.wikimedia.org/T271205) (owner: 10Hashar) [14:54:43] (03PS1) 10Hashar: Dummy build for stable-3.3 [software/gerrit] (wmf/stable-3.3) - 10https://gerrit.wikimedia.org/r/661946 [15:08:05] (03Abandoned) 10Hashar: Dummy build for stable-3.3 [software/gerrit] (wmf/stable-3.3) - 10https://gerrit.wikimedia.org/r/661946 (owner: 10Hashar) [15:28:03] 10Gerrit, 10Phabricator, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO, 10Technical-Debt: Stop using Differential for code review - https://phabricator.wikimedia.org/T191182 (10hashar) [15:28:36] 10Gerrit, 10Upstream: git-review: unclear/useless error message when using "git review -d 1234" in wrong repository - https://phabricator.wikimedia.org/T38170 (10hashar) 05Open→03Declined [15:31:30] 10Gerrit: ldap/wmf group should not have +2 in Gerrit - https://phabricator.wikimedia.org/T62412 (10hashar) 05Open→03Declined Nowadays that is explicitly documented in https://www.mediawiki.org/wiki/Gerrit/Privilege_policy , the current rights being the implementation of that policy. It can be amended via t... [15:34:33] 10Gerrit: Address Gerrit MediaWiki extension project descriptions - https://phabricator.wikimedia.org/T54685 (10hashar) 05Open→03Declined Indeed they are not that helpful in Gerrit (see: https://gerrit.wikimedia.org/r/admin/repos/q/filter:mediawiki%252Fextensions ) then I don't the description is shown anywh... [15:36:58] 10Gerrit, 10SRE, 10cloud-services-team, 10serviceops: Change /r/p/ to /r/ on all hosts (where https://gerrit.wikimedia.org/r/p/ exists) - https://phabricator.wikimedia.org/T222093 (10hashar) 05Open→03Resolved a:03Paladox AFAIK @Paladox has handled the whole migration. We might have some rewrite rule... [15:37:03] 10Gerrit, 10Wikimedia-General-or-Unknown, 10Documentation, 10Epic, and 2 others: Update Gerrit /r/p/ links to /r/ - https://phabricator.wikimedia.org/T218844 (10hashar) [15:41:54] 10Gerrit, 10Phabricator, 10Release-Engineering-Team, 10SRE, and 2 others: Add gerrit.wikimedia.org to the Phabricator CSP - https://phabricator.wikimedia.org/T218308 (10hashar) 05Open→03Declined Closing this since it is an old task. Either Pherrit got fixed or nobody uses it at all. If there is a nee... [15:45:33] 10Gerrit, 10Upstream: Gerrit's New UI reply dialog ignores Ctrl-Z - https://phabricator.wikimedia.org/T192666 (10hashar) That is still a valid bug in Gerrit 3.2.7. [15:46:57] 10Gerrit: Gerrit's "Show Diffs" button does not always expand all diffs for each changed file - https://phabricator.wikimedia.org/T199012 (10hashar) 05Open→03Resolved a:03hashar Looks like it is working nowadays with Gerrit 3.2.7. Maybe Gerrit had some troubles generating a diff for the large InitialiseSe... [15:54:10] 10Gerrit, 10Developer-Wishlist (2017): [MediaWiki-commits] Reverts are not notified by gerrit - https://phabricator.wikimedia.org/T49252 (10hashar) 05Open→03Declined The last message on markmail was from Oct 24, 2015 https://lists.wikimedia.org/pipermail/mediawiki-commits/ is empty nowadays We had all su... [15:58:25] 10Gerrit, 10Upstream: Add an icon to a patchset in a changeset view when the patchset has attached comments - https://phabricator.wikimedia.org/T52600 (10hashar) 05Open→03Resolved a:03hashar This got filed in 2013. We now run Gerrit 3.2 and inline comments are now standing out. [16:02:01] 10Gerrit, 10Phabricator, 10Release-Engineering-Team, 10SRE, and 2 others: Add gerrit.wikimedia.org to the Phabricator CSP - https://phabricator.wikimedia.org/T218308 (10Jdlrobson) FWIW I stopped using Pherrit because I couldn't get it to work without this fix. I don't think that's a great reason to decline... [16:04:23] (03CR) 10Ahmon Dancy: [C: 03+1] Further optimize initial checkout [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/661446 (owner: 10Dduvall) [16:06:47] Does Wikimedia still allow hosting repos in Phab Diffusion when not created by Striker (and then using ACL projects in Phab for that repo)? I'd welcome RelEng input added on https://phabricator.wikimedia.org/T273344 [16:08:36] 10Phabricator: Add a Phabricator policy capability "Can create Countdowns" - https://phabricator.wikimedia.org/T258599 (10valerio.bozzolan) I can't wait to try this feature! Is it deployed? A good place to try it: {T258106} [16:21:12] 10Gerrit, 10Phabricator, 10LDAP: Having difficulty logging into Phabricator via LDAP when multiple accounts returned for username (gerrit: Duplicate users: smccandlish) - https://phabricator.wikimedia.org/T138672 (10hashar) The whole summary is: Gerrit uses the LDAP `cn` fields for the account: ` [ldap]... [16:24:05] 10Gerrit, 10Phabricator, 10LDAP-Access-Requests, 10LDAP, 10cloud-services-team (Kanban): Duplicate LDAP user for cn=smccandlish - https://phabricator.wikimedia.org/T138672 (10hashar) [16:26:26] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO: Setup reply emails for gerrit - https://phabricator.wikimedia.org/T158915 (10hashar) 05Open→03Declined I could potentially like reviewing by email but: * we never used that so I guess folks can just use the web... [16:39:40] 10Release-Engineering-Team (Logspam), 10Collection, 10Wikimedia-production-error: InvalidArgumentException: Invalid or virtual namespace -1 given - Collection extension - https://phabricator.wikimedia.org/T273805 (10dancy) [16:46:54] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10SRE, 10Patch-For-Review, and 2 others: Shell/Python/other scripts should not be generated by ERB files; dynamic parts should be a simple ERB config file - https://phabricator.wikimedia.org/T254480 (10crusnov) I'm scoping... [17:25:25] (03CR) 10Umherirrender: [C: 03+2] Cache PHPUnitTestTrait::isTestFile() results [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/659249 (owner: 10Thiemo Kreuz (WMDE)) [17:26:59] (03Merged) 10jenkins-bot: Cache PHPUnitTestTrait::isTestFile() results [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/659249 (owner: 10Thiemo Kreuz (WMDE)) [17:29:35] 10Gerrit, 10Phabricator, 10LDAP-Access-Requests, 10SRE, and 2 others: Duplicate LDAP user for cn=smccandlish - https://phabricator.wikimedia.org/T138672 (10bd808) >>! In T138672#6806956, @hashar wrote: > And as pointed above ( T138672#2408607 ) there are two accounts matching: > ` > $ ldapsearch -x -LL 'cn... [17:30:00] 10Gerrit, 10Phabricator, 10Release-Engineering-Team, 10SRE, and 2 others: Add gerrit.wikimedia.org to the Phabricator CSP - https://phabricator.wikimedia.org/T218308 (10Tgr) Yeah, I would also use Oherrit if not for this issue. Nevertheless, I don't think a CSP exemption is the right way to fix it. [17:43:48] 10Phabricator, 10Diffusion-Repository-Administrators: Request for adding Kizule in #Repository-Admins - https://phabricator.wikimedia.org/T250119 (10Kizule) [17:44:59] 10Phabricator, 10Diffusion-Repository-Administrators: Request for adding Kizule in #Repository-Admins - https://phabricator.wikimedia.org/T250119 (10Kizule) Hello, I would like to know the status of this request. [17:47:04] 10Phabricator, 10Diffusion-Repository-Administrators: Request for adding Kizule in #Repository-Admins - https://phabricator.wikimedia.org/T250119 (10Kizule) > Secondly why would you need to archive mirrored repositories? I'm sorry for not responding to this question. It is a defined step in the process of ar... [17:47:16] 10Gerrit, 10Phabricator, 10LDAP-Access-Requests, 10SRE, and 3 others: Duplicate LDAP user for cn=smccandlish - https://phabricator.wikimedia.org/T138672 (10bd808) 05Open→03Resolved a:03bd808 `name=T138672.ldif dn: uid=smccandlish,ou=people,dc=wikimedia,dc=org changetype: modify replace: cn cn: Smccan... [17:50:34] 10Gerrit, 10LDAP: Gerrit login failure for user SMcCandlish - https://phabricator.wikimedia.org/T196597 (10bd808) [17:50:36] 10Gerrit, 10Phabricator, 10LDAP-Access-Requests, 10SRE, and 3 others: Duplicate LDAP user for cn=smccandlish - https://phabricator.wikimedia.org/T138672 (10bd808) [17:53:57] 10Phabricator, 10LDAP: Fix @Jarry1250's Phab account who cannot log in due to T138672 (two LDAP records) - https://phabricator.wikimedia.org/T138653 (10Jarry1250) Okay, sorry, just looked at this again. When i tried to log in with LDAP, it prompted me to link it instead (email address already in use). I just d... [17:56:55] 10Gerrit, 10Phabricator, 10LDAP-Access-Requests, 10SRE, and 3 others: Duplicate LDAP user for cn=smccandlish - https://phabricator.wikimedia.org/T138672 (10hashar) Thank you @bd808 and extra kudos for keeping the proper account. @SMcCandlish that should work. I am not sure why it never got noticed before,... [18:03:22] 10LibUp: libup fail to run eslint --fix on repos which does not config eslint in existing Gruntfile.js - https://phabricator.wikimedia.org/T273993 (10Umherirrender) [18:33:06] (03PS1) 10Dduvall: Derive project name from remote URL for non-Zuul jobs [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/661978 [18:41:10] (03PS2) 10Dduvall: Derive project name from remote URL for non-Zuul jobs [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/661978 [18:41:16] 10LibUp: libup does not remove php5 and inc file extensions from some .phpcs.xml files - https://phabricator.wikimedia.org/T273996 (10Umherirrender) [18:47:19] 10LibUp, 10Upstream: libup update of eslint-config-wikimedia for TEI extension fatals - https://phabricator.wikimedia.org/T273997 (10Umherirrender) [18:52:24] 10Gerrit, 10Phabricator, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO, 10Technical-Debt: Stop using Differential for code review - https://phabricator.wikimedia.org/T191182 (10valerio.bozzolan) The right context here is that we are successfully investing in lot of Ph... [18:58:06] (03CR) 10Dduvall: [C: 04-2] "Tested this locally and it isn't working correctly for other collection objects such as `hudson.plugins.git.GitSCM`." [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/661446 (owner: 10Dduvall) [19:02:31] (03PS3) 10Dduvall: Further optimize initial checkout [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/661446 [19:03:12] (03CR) 10Dduvall: [C: 03+1] "Ok, should be fixed now. You can run `make systemtest` locally to verify." [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/661446 (owner: 10Dduvall) [19:05:04] (03CR) 10Tosfos: [V: 03+2 C: 03+2] "Thanks!" [extensions/NamespaceHTML] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/661926 (https://phabricator.wikimedia.org/T273927) (owner: 10Hashar) [19:05:26] (03CR) 10Tosfos: [V: 03+2 C: 03+2] "Thanks!" [extensions/LinkTarget] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/661665 (https://phabricator.wikimedia.org/T273927) (owner: 10Hashar) [19:05:40] (03CR) 10Tosfos: [V: 03+2 C: 03+2] "Thanks!" [extensions/MetaMaster] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/661664 (https://phabricator.wikimedia.org/T273927) (owner: 10Hashar) [19:05:52] (03CR) 10Tosfos: [V: 03+2 C: 03+2] "Thanks!" [extensions/MassMessageEmail] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/661663 (https://phabricator.wikimedia.org/T273927) (owner: 10Hashar) [19:05:56] (03CR) 10Tosfos: [V: 03+2 C: 03+2] "Thanks!" [extensions/FlickrAPI] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/661662 (https://phabricator.wikimedia.org/T273927) (owner: 10Hashar) [19:13:36] (03CR) 10Ahmon Dancy: [C: 03+1] Further optimize initial checkout [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/661446 (owner: 10Dduvall) [19:13:39] 10LibUp: libup can fail when there is no .eslintrc.json, but a .eslintrc.js - https://phabricator.wikimedia.org/T273999 (10Umherirrender) [19:14:51] (03CR) 10Ahmon Dancy: [C: 03+1] Derive project name from remote URL for non-Zuul jobs [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/661978 (owner: 10Dduvall) [19:19:39] 10LibUp: libup fail to run eslint --fix on repos which does not config eslint in existing Gruntfile.js - https://phabricator.wikimedia.org/T273993 (10Umherirrender) There is the same code for stylelint [19:20:27] 10Release-Engineering-Team: Deploy process should be updated so JavaScript errors block the train - https://phabricator.wikimedia.org/T274000 (10Jdlrobson) [19:20:31] 10LibUp: libup can fail when there is no .eslintrc.json, but a .eslintrc.js - https://phabricator.wikimedia.org/T273999 (10Krinkle) [19:20:37] 10Release-Engineering-Team, 10Instrument-ClientError: Deploy process should be updated so JavaScript errors block the train - https://phabricator.wikimedia.org/T274000 (10Jdlrobson) [19:22:55] Project mediawiki-core-doxygen-docker build #22426: 04FAILURE in 18 min: https://integration.wikimedia.org/ci/job/mediawiki-core-doxygen-docker/22426/ [19:30:08] how can a change id be used for two different commits? I5bfca33c1d4d920d54c2c54b483be78c61b6d0d7 is https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/365682 and https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Cite/+/365685 [19:33:33] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10SRE, 10serviceops, 10User-jijiki: Upgrade MediaWiki clusters to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10ops-monitoring-bot) Script wmf-auto-reimage was launched by dzahn on cumin1001.eqia... [19:34:40] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10SRE, 10serviceops, 10User-jijiki: Upgrade MediaWiki clusters to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10ops-monitoring-bot) Script wmf-auto-reimage was launched by dzahn on cumin1001.eqia... [19:35:52] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10SRE, 10serviceops, 10User-jijiki: Upgrade MediaWiki clusters to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10ops-monitoring-bot) Script wmf-auto-reimage was launched by dzahn on cumin1001.eqia... [19:36:03] manual cherry pick, I guess? [19:38:04] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10SRE, 10serviceops, 10User-jijiki: Upgrade MediaWiki clusters to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10ops-monitoring-bot) Script wmf-auto-reimage was launched by dzahn on cumin1001.eqia... [19:39:11] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10SRE, 10serviceops, 10User-jijiki: Upgrade MediaWiki clusters to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10ops-monitoring-bot) Script wmf-auto-reimage was launched by dzahn on cumin1001.eqia... [19:44:02] DannyS712: thcipriani: when they are in different repos, usually just by copying into your local commit message, prior to git-review generating one for you. This is sometimes done to link similar commits in multiple repos. Care must be taken that change IDs must be unique with (repo,branch) scope. from repo/branch, the change ID decides the change number. Eg the change page and patch sets and review comments. So if you do this [19:44:02] incorrectly you might end up overwriting an existing commit with a new patch set draft [20:05:35] (03CR) 10Jeena Huneidi: [C: 03+2] "LGTM" [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/661978 (owner: 10Dduvall) [20:06:19] cscott should I send more incremental patches for dodo? [20:06:27] (03Merged) 10jenkins-bot: Derive project name from remote URL for non-Zuul jobs [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/661978 (owner: 10Dduvall) [20:11:49] 10Phabricator, 10LDAP: Fix @Jarry1250's Phab account who cannot log in due to T138672 (two LDAP records) - https://phabricator.wikimedia.org/T138653 (10hashar) 05Open→03Resolved Was probably similar to T138672. Thanks @Jarry1250 to have confirmed this is no more an issue! [20:15:27] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10SRE, 10serviceops, 10User-jijiki: Upgrade MediaWiki clusters to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10ops-monitoring-bot) Completed auto-reimage of hosts: ` ['mw1395.eqiad.wmnet'] ` an... [20:16:36] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10SRE, 10serviceops, 10User-jijiki: Upgrade MediaWiki clusters to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10ops-monitoring-bot) Completed auto-reimage of hosts: ` ['mw1394.eqiad.wmnet'] ` an... [20:20:54] Yippee, build fixed! [20:20:55] Project mediawiki-core-doxygen-docker build #22427: 09FIXED in 16 min: https://integration.wikimedia.org/ci/job/mediawiki-core-doxygen-docker/22427/ [20:23:54] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10SRE, 10serviceops, 10User-jijiki: Upgrade MediaWiki clusters to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10ops-monitoring-bot) Completed auto-reimage of hosts: ` ['mw2289.codfw.wmnet'] ` an... [20:28:48] (03PS1) 10Umherirrender: Fix spacing around exception type on @throws tag [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/661991 [20:33:42] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10SRE, 10serviceops, 10User-jijiki: Upgrade MediaWiki clusters to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10ops-monitoring-bot) Script wmf-auto-reimage was launched by dzahn on cumin1001.eqia... [20:38:41] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10SRE, 10serviceops, 10User-jijiki: Upgrade MediaWiki clusters to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10ops-monitoring-bot) Script wmf-auto-reimage was launched by dzahn on cumin1001.eqia... [20:41:41] 10VPS-project-Codesearch, 10Parsoid (Dodo), 10User-DannyS712: Add dodo to codesearch - https://phabricator.wikimedia.org/T274006 (10DannyS712) [20:42:39] 10LibUp: libup can fail when there is no .eslintrc.json, but a .eslintrc.js - https://phabricator.wikimedia.org/T273999 (10Jdforrester-WMF) I think it's reasonable to ask repos to have the `.eslintrc.json` shim like MobileFrontend does. [20:44:16] (03CR) 10Hashar: [C: 04-1] "This change is ready for review." (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/656951 (owner: 10Lars Wirzenius) [20:44:24] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10SRE, 10serviceops, 10User-jijiki: Upgrade MediaWiki clusters to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10ops-monitoring-bot) Script wmf-auto-reimage was launched by dzahn on cumin1001.eqia... [20:52:37] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10SRE, 10serviceops, 10User-jijiki: Upgrade MediaWiki clusters to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10ops-monitoring-bot) Completed auto-reimage of hosts: ` ['mw1307.eqiad.wmnet'] ` an... [20:53:48] 10MediaWiki-Codesniffer, 10User-DannyS712: Allow configuring prefixes in PrefixedGlobalFunctionsSniff - https://phabricator.wikimedia.org/T274007 (10DannyS712) [21:00:07] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10SRE, 10serviceops, 10User-jijiki: Upgrade MediaWiki clusters to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10ops-monitoring-bot) Script wmf-auto-reimage was launched by dzahn on cumin1001.eqia... [21:00:58] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10SRE, 10observability: "MediaWiki exceptions and fatals per minute" alarm is too slow (half an hour delay!) - https://phabricator.wikimedia.org/T141520 (10hashar) In a nutshell the first issue is that the first spike of err... [21:02:12] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10SRE, 10serviceops, 10User-jijiki: Upgrade MediaWiki clusters to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10ops-monitoring-bot) Completed auto-reimage of hosts: ` ['mw2254.codfw.wmnet'] ` an... [21:04:51] Does Wikimedia still allow hosting repos in Phab Diffusion when not created by Striker (and then using ACL projects in Phab for that repo)? I'd welcome RelEng input added on https://phabricator.wikimedia.org/T273344 [21:07:53] (03PS1) 10Dduvall: Set setup.branch to local branch name [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/662000 [21:08:49] 10Gerrit, 10Phabricator, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO, 10Technical-Debt: Stop using Differential for code review - https://phabricator.wikimedia.org/T191182 (10Aklapper) No, the fact that "we" use some parts and invest in those parts does not mean tha... [21:11:09] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10SRE, 10serviceops, 10User-jijiki: Upgrade MediaWiki clusters to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10ops-monitoring-bot) Script wmf-auto-reimage was launched by dzahn on cumin1001.eqia... [21:15:47] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10SRE, 10serviceops, 10User-jijiki: Upgrade MediaWiki clusters to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10ops-monitoring-bot) Completed auto-reimage of hosts: ` ['mw1393.eqiad.wmnet'] ` an... [21:16:17] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Instrument-ClientError, 10Documentation, 10User-brennen: Deploy process should be updated so JavaScript errors block the train - https://phabricator.wikimedia.org/T274000 (10brennen) After... [21:19:38] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Instrument-ClientError, 10Documentation, 10User-brennen: Deploy process should be updated so JavaScript errors block the train - https://phabricator.wikimedia.org/T274000 (10brennen) > Thi... [21:21:04] (03CR) 10Ahmon Dancy: [C: 03+1] Set setup.branch to local branch name [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/662000 (owner: 10Dduvall) [21:21:35] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10SRE, 10serviceops, 10User-jijiki: Upgrade MediaWiki clusters to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10ops-monitoring-bot) Completed auto-reimage of hosts: ` ['mw1392.eqiad.wmnet'] ` an... [21:22:50] 10VPS-project-Codesearch, 10Parsoid (Dodo), 10User-DannyS712: Add dodo to codesearch - https://phabricator.wikimedia.org/T274006 (10Legoktm) 05Open→03Invalid Anything under `mediawiki/libs/` will automatically be added to codesearch (might take a day after repo creation). https://codesearch.wmcloud.org/l... [21:23:24] (03CR) 10DannyS712: "This change is ready for review." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/661937 (https://phabricator.wikimedia.org/T274007) (owner: 10DannyS712) [21:24:28] (03PS1) 10Dduvall: Sanitize all image names/tags [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/662003 [21:25:18] 10VPS-project-Codesearch, 10Parsoid (Dodo): Add dodo to codesearch - https://phabricator.wikimedia.org/T274006 (10DannyS712) Hmm, it wasn't there when I checked - thanks anyway [21:26:30] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10SRE, 10serviceops, 10User-jijiki: Upgrade MediaWiki clusters to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10ops-monitoring-bot) Completed auto-reimage of hosts: ` ['mw2266.codfw.wmnet'] ` an... [21:26:59] 10LibUp: libup can fail when there is no .eslintrc.json, but a .eslintrc.js - https://phabricator.wikimedia.org/T273999 (10Legoktm) >>! In T273999#6807628, @Jdforrester-WMF wrote: > I think it's reasonable to ask repos to have the `.eslintrc.json` shim like MobileFrontend does. Will disables in eslintrc.json st... [21:31:38] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Documentation, 10User-brennen: Update/organize train deployment and related policy documentation - https://phabricator.wikimedia.org/T273802 (10brennen) [21:33:24] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10SRE, 10serviceops, 10User-jijiki: Upgrade MediaWiki clusters to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10ops-monitoring-bot) Script wmf-auto-reimage was launched by legoktm on cumin1001.eq... [21:35:16] (03CR) 10Jforrester: "I was going to ask that we document the new config option in the README, but apparently we don't document any there at all as of now?" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/661937 (https://phabricator.wikimedia.org/T274007) (owner: 10DannyS712) [21:36:51] 10LibUp: libup can fail when there is no .eslintrc.json, but a .eslintrc.js - https://phabricator.wikimedia.org/T273999 (10Jdforrester-WMF) If the merge strategy is correct in the `.js` file, yes, I think so. [21:46:07] (03CR) 10Jeena Huneidi: [C: 03+1] Sanitize all image names/tags [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/662003 (owner: 10Dduvall) [21:50:01] (03CR) 10Jeena Huneidi: [C: 03+1] "Is that even being used? I couldn't find where." [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/662000 (owner: 10Dduvall) [22:15:53] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10SRE, 10serviceops, 10User-jijiki: Upgrade MediaWiki clusters to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10ops-monitoring-bot) Completed auto-reimage of hosts: ` ['mw1306.eqiad.wmnet'] ` an... [22:21:51] Project mediawiki-core-doxygen-docker build #22429: 04FAILURE in 17 min: https://integration.wikimedia.org/ci/job/mediawiki-core-doxygen-docker/22429/ [22:29:39] (03PS1) 10Zoranzoki21: Archive the OpenStreetMapSlippyMap extension [integration/config] - 10https://gerrit.wikimedia.org/r/662016 (https://phabricator.wikimedia.org/T257873) [22:30:05] 10Release-Engineering-Team-TODO, 10MW-on-K8s, 10Release Pipeline, 10serviceops: Create restricted docker-registry namespace for security patched images - https://phabricator.wikimedia.org/T273521 (10Legoktm) a:03Legoktm Should the existence of these images also be secret? Or is it okay if they're listed... [22:30:16] (03PS1) 10QChris: Allow “Gerrit Managers” to import history [extensions/CIForms] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/662017 [22:30:18] (03CR) 10QChris: [V: 03+2 C: 03+2] Allow “Gerrit Managers” to import history [extensions/CIForms] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/662017 (owner: 10QChris) [22:30:20] (03PS1) 10QChris: Import done. Revoke import grants [extensions/CIForms] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/662018 [22:30:22] (03CR) 10QChris: [V: 03+2 C: 03+2] Import done. Revoke import grants [extensions/CIForms] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/662018 (owner: 10QChris) [22:31:41] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10SRE, 10serviceops, 10User-jijiki: Upgrade MediaWiki clusters to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10ops-monitoring-bot) Completed auto-reimage of hosts: ` ['mw1269.eqiad.wmnet'] ` an... [22:34:40] 10Diffusion, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO, 10Machine Learning Team, 10Wikimedia-GitHub: LFS objects are not mirroring from Github through Phab to Gerrit consistently - https://phabricator.wikimedia.org/T212818 (10bd808) a:05Halfak→03None [22:53:21] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10SRE, 10serviceops, 10User-jijiki: Upgrade MediaWiki clusters to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10ops-monitoring-bot) Completed auto-reimage of hosts: ` ['mw1285.eqiad.wmnet'] ` an... [22:57:07] 10Release-Engineering-Team-TODO, 10MW-on-K8s, 10Release Pipeline, 10serviceops: Create restricted docker-registry namespace for security patched images - https://phabricator.wikimedia.org/T273521 (10Legoktm) Also, is there a chance developers will ask to be able to pull images locally for debugging? I supp... [23:03:56] 10MediaWiki-Codesniffer, 10Documentation, 10User-DannyS712: Document sniffs that support configuration properties - https://phabricator.wikimedia.org/T274016 (10DannyS712) [23:03:58] (03CR) 10DannyS712: "> Patch Set 2:" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/661937 (https://phabricator.wikimedia.org/T274007) (owner: 10DannyS712) [23:04:08] 10Release-Engineering-Team-TODO, 10MW-on-K8s, 10Release Pipeline, 10serviceops: Create restricted docker-registry namespace for security patched images - https://phabricator.wikimedia.org/T273521 (10dduvall) >>! In T273521#6807963, @Legoktm wrote: > Also, is there a chance developers will ask to be able to... [23:06:42] (03CR) 10Jforrester: [C: 03+1] Allow configuring prefixes in PrefixedGlobalFunctionsSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/661937 (https://phabricator.wikimedia.org/T274007) (owner: 10DannyS712) [23:08:12] (03CR) 10Dduvall: "> Patch Set 1: Code-Review+1" [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/662000 (owner: 10Dduvall) [23:12:44] 10MediaWiki-Codesniffer, 10Documentation, 10User-DannyS712: Document sniffs that support configuration properties - https://phabricator.wikimedia.org/T274016 (10DannyS712) Scanning through the existing sniffs manually shows the following configuration properties: ` FullQualifiedClassNameSniff: allowMainNames... [23:20:39] Yippee, build fixed! [23:20:40] Project mediawiki-core-doxygen-docker build #22430: 09FIXED in 16 min: https://integration.wikimedia.org/ci/job/mediawiki-core-doxygen-docker/22430/ [23:43:50] Does Wikimedia still allow hosting repos in Phab Diffusion when not created by Striker (and then using ACL projects in Phab for that repo)? I'd welcome RelEng input added on https://phabricator.wikimedia.org/T273344 [23:46:58] andre__: I'd be happy with the answer being that only Toolforge repos are allowed. As soon as we have gerrit++ (whenever and whatever that is) I will try to work to move all the Toolforge repos to the new system. [23:47:50] They are literally only in Diffusion now because Diffusion was the planned geritt++ when I wrote the code [23:48:02] I'd personally also like that answer (heh), but I'd like Release Engineering to clarify in that ticket where someone would like to (re)use a Diffusion repo for hosting stuff. [23:48:43] because without clear statements and guidelines we just encourage more and more fragmentation, I guess. [23:54:36] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10SRE, 10serviceops, 10User-jijiki: Upgrade MediaWiki clusters to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10ops-monitoring-bot) Script wmf-auto-reimage was launched by dzahn on cumin1001.eqia... [23:56:57] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10SRE, 10serviceops, 10User-jijiki: Upgrade MediaWiki clusters to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10ops-monitoring-bot) Script wmf-auto-reimage was launched by dzahn on cumin1001.eqia... [23:58:55] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10SRE, 10serviceops, 10User-jijiki: Upgrade MediaWiki clusters to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10ops-monitoring-bot) Script wmf-auto-reimage was launched by dzahn on cumin1001.eqia...