[00:00:34] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10SRE, 10serviceops, 10User-jijiki: Upgrade MediaWiki clusters to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10ops-monitoring-bot) Script wmf-auto-reimage was launched by dzahn on cumin1001.eqia... [00:40:34] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10SRE, 10serviceops, 10User-jijiki: Upgrade MediaWiki clusters to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10ops-monitoring-bot) Completed auto-reimage of hosts: ` ['mw1366.eqiad.wmnet'] ` an... [00:43:12] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10SRE, 10serviceops, 10User-jijiki: Upgrade MediaWiki clusters to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10ops-monitoring-bot) Completed auto-reimage of hosts: ` ['mw2265.codfw.wmnet'] ` an... [01:16:24] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10SRE, 10serviceops, 10User-jijiki: Upgrade MediaWiki clusters to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10ops-monitoring-bot) Completed auto-reimage of hosts: ` ['mw1319.eqiad.wmnet'] ` an... [01:21:20] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10SRE, 10serviceops, 10User-jijiki: Upgrade MediaWiki clusters to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10ops-monitoring-bot) Completed auto-reimage of hosts: ` ['mw1313.eqiad.wmnet'] ` an... [01:21:34] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10SRE, 10serviceops, 10User-jijiki: Upgrade MediaWiki clusters to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10Dzahn) [01:22:16] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10SRE, 10serviceops, 10User-jijiki: Upgrade MediaWiki clusters to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10Dzahn) [01:23:24] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10SRE, 10serviceops, 10User-jijiki: Upgrade MediaWiki clusters to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10Dzahn) p:05Medium→03High [01:24:08] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO: Drop MediaWiki testing in stretch and instead test only in buster - https://phabricator.wikimedia.org/T252432 (10Dzahn) T274023 - create mwdebug1004, mwdebug2003 and mwdebug2004 as me... [01:24:29] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO: Drop MediaWiki testing in stretch and instead test only in buster - https://phabricator.wikimedia.org/T252432 (10Dzahn) [01:57:56] cscott are you around? [02:14:48] Yup [02:14:54] What's up? [02:15:31] DannyS712: ^ [02:25:32] DannyS712: saw your patches to dodo, thanks a lot! [02:27:32] DannyS712: fyi, the WebIDL.md document is current thinking on how DOM specs *should* map to PHP methods. wikimedia/webidl is step 1 in a plan to automatically generate some of these method signatures from the official IDL spec to ensure we're following the spec. [02:31:04] I think I eventually want a better naming scheme for private methods and implementation fields vs methods-defined-in-the-spec as well. Prepending underscores doesn't make phpcs happy, but the IDL spec does reserve leading underscores for implementation use, so maybe that's the way to go. [02:33:10] There are some other options, but I think "everything private should have an underscore, and everything with an underscore should be private" is reasonable. There are a few places where you want something like C++ 'friend' access, so maybe some of the underscore properties/methods will end up public. Hoping I can avoid that, though. [02:33:31] Jason also seemed to avoid using Traits for mixins, but I think we definitely want to do that. [02:50:06] I'm right now working on a bigger cleanup of the reflected attributes, and then will look into this [03:08:34] (03CR) 10DannyS712: "This change is ready for review." [libs/Dodo] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/662049 (owner: 10DannyS712) [03:17:44] cscott when you have a minute, could you take a look at ^ ? It'll make stuff clearer [03:40:03] (03CR) 10C. Scott Ananian: [C: 03+2] "Yup, that's how Parsoid is configured as well. I like rebasing." [libs/Dodo] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/662049 (owner: 10DannyS712) [03:45:39] I've been thinking about proposing that it be the default ^ [03:45:49] also, patch needs manual verified and merge [03:55:22] cscott ^ would you mind merging the patch? Until then I'm keeping the code changes in a relation chain to make sure they don't result in merge commits [04:20:25] (03CR) 10C. Scott Ananian: [V: 03+2 C: 03+2] Edit Repo Config - rebase if necessary [libs/Dodo] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/662049 (owner: 10DannyS712) [04:22:13] thanks [07:09:49] 10MediaWiki-Codesniffer, 10Documentation, 10User-DannyS712: Document sniffs that support configuration properties - https://phabricator.wikimedia.org/T274016 (10thiemowmde) At least in the sniffs I wrote you will find longer pieces of documentation in comments at the top of the class as well as on these pro... [07:20:40] 10Beta-Cluster-Infrastructure, 10Deployments, 10MediaWiki-Internationalization, 10I18n: en-rtl l10n cache not being rebuilt, eventually resulting in fatal exceptions when magic words are not dealt with properly - https://phabricator.wikimedia.org/T106125 (10Nikerabbit) I'd guess this is no longer an issue,... [07:58:58] 10Beta-Cluster-Infrastructure, 10Deployments, 10MediaWiki-Internationalization, 10I18n: en-rtl l10n cache not being rebuilt, eventually resulting in fatal exceptions when magic words are not dealt with properly - https://phabricator.wikimedia.org/T106125 (10hashar) 05Open→03Resolved And after five year... [08:00:23] 10Beta-Cluster-Infrastructure, 10Deployments, 10MediaWiki-Internationalization, 10I18n: en-rtl l10n cache not being rebuilt, eventually resulting in fatal exceptions when magic words are not dealt with properly - https://phabricator.wikimedia.org/T106125 (10hashar) Sorry replied too fast. What I meant is t... [08:15:20] 10LibUp: Move libup to a bigger server - https://phabricator.wikimedia.org/T273690 (10Legoktm) https://wikitech.wikimedia.org/wiki/Help:Adding_Disk_Space_to_Cloud_VPS_instances#Cinder:_Attachable_Block_Storage_for_cloud-vps [08:37:54] 10Gerrit, 10Phabricator, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO, 10Technical-Debt: Stop using Differential for code review - https://phabricator.wikimedia.org/T191182 (10valerio.bozzolan) Yup. In fact we should not do, or should do, but continue to allow to do. [08:56:51] 10Gerrit, 10Phabricator, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO, 10Technical-Debt: Stop using Differential for code review - https://phabricator.wikimedia.org/T191182 (10Aklapper) For the records, we're talking about **6¾ users** (monthly average for last 12 ca... [09:33:39] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO: Setup reply emails for gerrit - https://phabricator.wikimedia.org/T158915 (10Aklapper) > like I guess nobody does Phabricator comments by emails. Just for the records: A number of people do, actually. :) [13:48:27] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO: Setup reply emails for gerrit - https://phabricator.wikimedia.org/T158915 (10hashar) >>! In T158915#6808346, @Aklapper wrote: >> like I guess nobody does Phabricator comments by emails. > > Just for the records: A... [17:15:38] 10phan: Enable some more plugins in the default config - https://phabricator.wikimedia.org/T274037 (10Daimona) [17:20:34] 10phan: Enforce use of static closures - https://phabricator.wikimedia.org/T274038 (10Daimona) [17:36:54] 10phan: Enable some more plugins in the default config - https://phabricator.wikimedia.org/T274037 (10Reedy) DuplicateArrayKeyPlugin definitely sounds useful. Come across that numerous times in various parts of code [18:00:18] 10phan: Enforce use of static closures - https://phabricator.wikimedia.org/T274038 (10Reedy) [21:13:38] !log unstuck beta jobs [21:13:40] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [21:14:04] it's funny how it's not run for 50 hours and no one notices [21:17:32] Jobs are painful [21:39:02] what was not run? I haven't needed the latest puppet or mediawiki master commit in the last couple days [22:34:57] no mw config, no mw code, no scap, no database updates [23:36:49] 10phan, 10Patch-For-Review: Enable some more plugins in the default config - https://phabricator.wikimedia.org/T274037 (10Daimona) a:03Daimona [23:39:02] 10Phabricator (Upstream), 10Upstream: Unknown search function "XXX". Supported functions are: all, title, body, core, comment. - https://phabricator.wikimedia.org/T243483 (10Aklapper) 05Open→03Resolved It nowadays says `Unknown search function "foo". Supported functions are: all, body, comment, core, title... [23:46:11] 10Project-Admins: Replace tracking T40638 by new project tag for "Interface messages" - https://phabricator.wikimedia.org/T140077 (10Aklapper) >>! In T140077#4478613, @Aklapper wrote: > I'd rather deprecate it in favor of #voice_tone Clarified that tag a bit more in T107593#6716089