[00:38:56] 10Deployments, 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)): L10n cache files building up on backup deploy hosts - https://phabricator.wikimedia.org/T275826 (10Urbanecm) >>! In T275826#6876977, @gerritbot wrote: > Change 667919 **merged** b... [00:40:03] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10GitLab (Initialization), 10User-brennen: Remove Speed & Function blockers for GitLab work - https://phabricator.wikimedia.org/T274458 (10wkandek) [04:42:30] 10Continuous-Integration-Config, 10LuaSandbox: Run LuaSandbox tests against PHP with ZTS - https://phabricator.wikimedia.org/T206591 (10Legoktm) And now #excimer too: {T276287} [05:04:13] 10Continuous-Integration-Config, 10LuaSandbox: Run LuaSandbox tests against PHP with ZTS - https://phabricator.wikimedia.org/T206591 (10Legoktm) deb.sury.org doesn't have ZTS builds, see https://github.com/oerdnj/deb.sury.org/issues/327 Either we'll need to add ZTS support to Ondrej's packages (best long-term... [08:01:07] 10Beta-Cluster-Infrastructure, 10Discovery-Search (Current work): Search broken on beta cluster wikis - https://phabricator.wikimedia.org/T275975 (10dcausse) 05Open→03Resolved Search is functional again. [08:09:01] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10SRE, 10GitLab (Initialization), 10User-brennen: SSH Access of Git data in GitLab - https://phabricator.wikimedia.org/T276148 (10JMeybohm) p:05Triage→03Medium [08:19:03] (03PS1) 10Gehel: Add minimal sonar configuration. [integration/gearman-java] - 10https://gerrit.wikimedia.org/r/667984 (https://phabricator.wikimedia.org/T264873) [08:22:46] (03CR) 10jerkins-bot: [V: 04-1] Add minimal sonar configuration. [integration/gearman-java] - 10https://gerrit.wikimedia.org/r/667984 (https://phabricator.wikimedia.org/T264873) (owner: 10Gehel) [08:31:17] (03CR) 10Gehel: "recheck" [integration/gearman-java] - 10https://gerrit.wikimedia.org/r/667984 (https://phabricator.wikimedia.org/T264873) (owner: 10Gehel) [10:13:01] (03CR) 10Hashar: [C: 03+1] Replace the java-codehealth-patch by adding step in the standard job (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/666869 (https://phabricator.wikimedia.org/T264873) (owner: 10Gehel) [10:19:32] (03PS10) 10Gehel: Replace the java-codehealth-patch by adding step in the standard job [integration/config] - 10https://gerrit.wikimedia.org/r/666869 (https://phabricator.wikimedia.org/T264873) [10:28:26] (03CR) 10Hashar: [C: 03+2] "Jobs deployed lets go!!!" [integration/config] - 10https://gerrit.wikimedia.org/r/666869 (https://phabricator.wikimedia.org/T264873) (owner: 10Gehel) [10:30:25] (03Merged) 10jenkins-bot: Replace the java-codehealth-patch by adding step in the standard job [integration/config] - 10https://gerrit.wikimedia.org/r/666869 (https://phabricator.wikimedia.org/T264873) (owner: 10Gehel) [10:33:48] !log REplaced java-codehealth-patch job in favor of running sonar:sonar inline in all the java jobs. Thanks gehel! # T264873 | https://gerrit.wikimedia.org/r/c/integration/config/+/666869/ [10:33:51] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [10:33:52] T264873: Ensure that SonarQube is commenting on gerrit code reviews of the Search Platform team - https://phabricator.wikimedia.org/T264873 [10:42:25] (03CR) 10Addshore: Reinstate wikidata-query-gui-build job (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/664848 (https://phabricator.wikimedia.org/T210286) (owner: 10Lucas Werkmeister (WMDE)) [10:44:09] (03PS4) 10Addshore: Reinstate wikidata-query-gui-build job [integration/config] - 10https://gerrit.wikimedia.org/r/664848 (https://phabricator.wikimedia.org/T210286) (owner: 10Lucas Werkmeister (WMDE)) [10:44:28] (03PS5) 10Addshore: Reinstate wikidata-query-gui-build job [integration/config] - 10https://gerrit.wikimedia.org/r/664848 (https://phabricator.wikimedia.org/T210286) (owner: 10Lucas Werkmeister (WMDE)) [10:45:10] (03CR) 10Addshore: "> Patch Set 1:" [integration/config] - 10https://gerrit.wikimedia.org/r/664848 (https://phabricator.wikimedia.org/T210286) (owner: 10Lucas Werkmeister (WMDE)) [10:45:29] (03PS6) 10Addshore: Reinstate wikidata-query-gui-build job [integration/config] - 10https://gerrit.wikimedia.org/r/664848 (https://phabricator.wikimedia.org/T210286) (owner: 10Lucas Werkmeister (WMDE)) [10:55:08] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10observability: Enhance Gerrit logs ingested by Logstash - https://phabricator.wikimedia.org/T274661 (10hashar) 05Open→03Resolved The log formatting issue has been a long stand... [10:56:48] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10observability, 10Technical-Debt: Enhance Gerrit logs ingested by Logstash - https://phabricator.wikimedia.org/T274661 (10hashar) [10:57:28] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Wikimedia-Logstash, and 2 others: Look into shoving gerrit logs into logstash - https://phabricator.wikimedia.org/T141324 (10hashar) The remaining issues have been addressed via a... [11:01:03] (03CR) 10Addshore: [C: 03+2] "This is deployed https://integration.wikimedia.org/ci/job/wikidata-query-gui-build/" [integration/config] - 10https://gerrit.wikimedia.org/r/664848 (https://phabricator.wikimedia.org/T210286) (owner: 10Lucas Werkmeister (WMDE)) [11:03:53] (03Merged) 10jenkins-bot: Reinstate wikidata-query-gui-build job [integration/config] - 10https://gerrit.wikimedia.org/r/664848 (https://phabricator.wikimedia.org/T210286) (owner: 10Lucas Werkmeister (WMDE)) [11:04:21] (03CR) 10Hashar: [C: 03+2] Add minimal sonar configuration. [integration/gearman-java] - 10https://gerrit.wikimedia.org/r/667984 (https://phabricator.wikimedia.org/T264873) (owner: 10Gehel) [11:05:46] hashar: how can i make a manual tirgger in jenkins? [11:06:00] addshore: what do you mean ? ;] [11:06:09] so rather than triggers: [11:06:09] - zuul [11:06:13] oh [11:06:16] i want there to be a button in the jenkins ui for it [11:06:20] so that is some oddity from jjb [11:06:38] afaik its only purposes is to add zuul* parameters to the job as a convenience for end users [11:06:43] but really is not needed [11:07:02] cause the parameters injected by Zuul over gearman are added to the build regardless of whether they are defined in the job [11:07:07] oh right, so i proabably should just hit the "rebuild last" button> [11:07:15] if you have access to that yet [11:07:16] or [11:07:21] there is a link "build with parameters" [11:07:31] aaah yes! [11:07:35] so I would then file in the parameters that got crafted by triggers: - zuul [11:07:44] ZUUL_URL: https://gerrit.wikimedia.org/r [11:07:48] right, so i dont need to add anything to the config! cool! :) [11:07:49] ZUUL_PROJECT: mediawiki/core [11:07:54] ZUUL_BRANCH: REL1_35 [11:08:00] ZUUL_REF: REL1_35 [11:08:11] you need all four of those [11:08:19] else behavior is undefined [11:08:47] there are other dirty tricks [11:09:05] such as invoking the job via the gearman protocol directly frmo the contint machine but that is well .. not that convenient hehe [11:09:31] `11:07:42 /utils/ci-src-setup.sh: line 11: ZUUL_URL: unbound variable` D: [11:09:38] hehe [11:09:41] but https://integration.wikimedia.org/ci/job/wikidata-query-gui-build/1/parameters/ [11:09:44] its set! [11:09:59] hmm [11:10:04] but they are unset below [11:10:08] ???????????????????????? [11:10:19] oh it is there twice xD [11:10:27] (03Merged) 10jenkins-bot: Add minimal sonar configuration. [integration/gearman-java] - 10https://gerrit.wikimedia.org/r/667984 (https://phabricator.wikimedia.org/T264873) (owner: 10Gehel) [11:10:42] hmmmm https://gerrit.wikimedia.org/r/c/integration/config/+/664848/6/jjb/wikidata.yaml#88 [11:10:44] well I dont know why [11:10:52] OHHH [11:10:54] so yeah [11:10:58] hehe [11:11:01] xD [11:11:04] so what happens is [11:11:12] you gefined parameters with some default values [11:11:19] oh right, this is a default, and it gets overwritten by a blank string? [11:11:22] but triggers: - zuul defines them as well [11:11:29] and the triggers: step happens later in JJB processing [11:11:40] so i remove the triggers thing and it may work? [11:11:42] so I guess the empty parameters are added below and end up overriding what you did [11:11:45] yeah [11:11:50] and even without the triggers thing, ti can still be triggered bu zuul? [11:11:51] I think [11:11:57] okay! [11:11:58] it is a bit of a mess really [11:11:59] let me try! [11:12:04] cause most CI jobs are solely triggered by Zuul [11:12:15] while a handful of Jenkins jobs are solely intended ot be run by a human [11:13:16] (03PS1) 10Addshore: Remove zuul trigger for wikidata-query-gui-build [integration/config] - 10https://gerrit.wikimedia.org/r/668038 [11:13:30] addshore: have a look at '{name}-maven-release-docker at line 261 of jjb/job-templates.yaml [11:13:44] it is a manual job to manually run a java maven release [11:13:49] and indeed it does not have triggers: -zuul [11:13:54] (03PS2) 10Addshore: Remove zuul trigger for wikidata-query-gui-build [integration/config] - 10https://gerrit.wikimedia.org/r/668038 (https://phabricator.wikimedia.org/T210286) [11:13:55] cause well... it is not triggered by zuul [11:14:02] (03CR) 10Addshore: [C: 03+2] "deployed" [integration/config] - 10https://gerrit.wikimedia.org/r/668038 (https://phabricator.wikimedia.org/T210286) (owner: 10Addshore) [11:14:19] looks better https://integration.wikimedia.org/ci/job/wikidata-query-gui-build/build?delay=0sec [11:14:21] addshore: kudos! [11:14:27] yar, awesome! [11:16:18] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Wikidata, and 4 others: Create docker based CI job to build the wikidata-query-gui - https://phabricator.wikimedia.org/T210286 (10Addshore) So the `triggers - zuul` needs to be re... [11:16:27] (03Merged) 10jenkins-bot: Remove zuul trigger for wikidata-query-gui-build [integration/config] - 10https://gerrit.wikimedia.org/r/668038 (https://phabricator.wikimedia.org/T210286) (owner: 10Addshore) [11:23:29] (03PS2) 10Addshore: Add {name}-node10-browser-webdriver-docker [integration/config] - 10https://gerrit.wikimedia.org/r/667623 (https://phabricator.wikimedia.org/T222200) [11:25:21] (03CR) 10jerkins-bot: [V: 04-1] Add {name}-node10-browser-webdriver-docker [integration/config] - 10https://gerrit.wikimedia.org/r/667623 (https://phabricator.wikimedia.org/T222200) (owner: 10Addshore) [11:25:41] (03PS1) 10Addshore: Add {name}-node10-browser-webdriver-docker [integration/config] - 10https://gerrit.wikimedia.org/r/668040 (https://phabricator.wikimedia.org/T222200) [11:26:20] (03PS3) 10Addshore: Use {name}-node10-browser-webdriver-docker for wikidata/query/gui [integration/config] - 10https://gerrit.wikimedia.org/r/667623 (https://phabricator.wikimedia.org/T222200) [11:27:49] (03CR) 10jerkins-bot: [V: 04-1] Use {name}-node10-browser-webdriver-docker for wikidata/query/gui [integration/config] - 10https://gerrit.wikimedia.org/r/667623 (https://phabricator.wikimedia.org/T222200) (owner: 10Addshore) [11:28:05] (03CR) 10Addshore: "will not be green until i deploy the job..." [integration/config] - 10https://gerrit.wikimedia.org/r/667623 (https://phabricator.wikimedia.org/T222200) (owner: 10Addshore) [11:29:56] (03PS2) 10Addshore: Add {name}-node10-browser-webdriver-docker [integration/config] - 10https://gerrit.wikimedia.org/r/668040 (https://phabricator.wikimedia.org/T222200) [11:30:45] 10Phabricator (Upstream), 10Upstream: drydock: translation typo on source: `chagne` - https://phabricator.wikimedia.org/T218447 (10MarcoAurelio) So it looks like the original message found at https://translatewiki.net/wiki/Phabricator:phabricator-drydock-2eef34a08962e0de/en is no longer operative. Checking {s... [11:31:48] (03CR) 10Addshore: [C: 03+2] "deployed" [integration/config] - 10https://gerrit.wikimedia.org/r/668040 (https://phabricator.wikimedia.org/T222200) (owner: 10Addshore) [11:31:54] (03PS4) 10Addshore: Use {name}-node10-browser-webdriver-docker for wikidata/query/gui [integration/config] - 10https://gerrit.wikimedia.org/r/667623 (https://phabricator.wikimedia.org/T222200) [11:33:16] (03CR) 10jerkins-bot: [V: 04-1] Use {name}-node10-browser-webdriver-docker for wikidata/query/gui [integration/config] - 10https://gerrit.wikimedia.org/r/667623 (https://phabricator.wikimedia.org/T222200) (owner: 10Addshore) [11:33:26] (03Merged) 10jenkins-bot: Add {name}-node10-browser-webdriver-docker [integration/config] - 10https://gerrit.wikimedia.org/r/668040 (https://phabricator.wikimedia.org/T222200) (owner: 10Addshore) [11:34:24] hashar: sorry to poke you again, but any idea why https://gerrit.wikimedia.org/r/c/integration/config/+/667623 fails? [11:34:54] (03PS5) 10Addshore: Use {name}-node10-browser-webdriver-docker for wikidata/query/gui [integration/config] - 10https://gerrit.wikimedia.org/r/667623 (https://phabricator.wikimedia.org/T222200) [11:34:58] reading that job output is haaardd [11:36:06] hmmmmmm 11:32:55 FAILURE: Job generic-node10-browser-webdriver-docker not defined [11:36:29] oh, its greent now [11:36:30] bah [11:36:33] sorry for the noise [11:37:51] enjoy your tomato lunch [11:37:56] addshore: merci! [11:38:13] (03CR) 10Addshore: [C: 03+2] Use {name}-node10-browser-webdriver-docker for wikidata/query/gui [integration/config] - 10https://gerrit.wikimedia.org/r/667623 (https://phabricator.wikimedia.org/T222200) (owner: 10Addshore) [11:39:31] (03Merged) 10jenkins-bot: Use {name}-node10-browser-webdriver-docker for wikidata/query/gui [integration/config] - 10https://gerrit.wikimedia.org/r/667623 (https://phabricator.wikimedia.org/T222200) (owner: 10Addshore) [11:39:47] addshore: I should dig into what this job is about or I guess I can just blindly trust yahehe [11:39:49] anyway food [11:39:52] ! [11:40:24] !log reload zuul for https://gerrit.wikimedia.org/r/667623 [11:40:27] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [11:41:11] The job is the same as the other node10 browser one, but it runs webdriver by default in the docker entrypoint (rather than the current default which is not doing that) [11:41:23] it could perhaps do with some more refactoring if it ends up acheiving our goal [11:57:45] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.33 deployment blockers - https://phabricator.wikimedia.org/T274937 (10LarsWirzenius) Reported {T276316}, but not as a blocker, since it's only happened once so far. [12:00:41] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.33 deployment blockers - https://phabricator.wikimedia.org/T274937 (10kostajh) Not sure if {T276307} should be a blocker considering the volume of logspam it's generating, but in... [12:12:24] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.33 deployment blockers - https://phabricator.wikimedia.org/T274937 (10LarsWirzenius) Eh, editing wrong task I am. [12:12:57] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.33 deployment blockers - https://phabricator.wikimedia.org/T274937 (10LarsWirzenius) [12:15:41] liw: did you mean to tag secteam in T276316#6878228? you added the #security tag but the security team workboard is a separate project [12:16:42] Majavah, good catch [12:17:13] what tag should I use? [12:17:16] 10Continuous-Integration-Infrastructure, 10Wikidata, 10Patch-For-Review, 10User-Addshore, and 3 others: Run browser tests as part of "npm test" for wikidata/query/gui in CI - https://phabricator.wikimedia.org/T222200 (10Addshore) a:03Addshore https://gerrit.wikimedia.org/r/c/wikidata/query/gui/+/666368 i... [12:17:24] #security-team if you want secteam [12:17:47] not sure how often they check the inbox of that project, but in theory that is the correct tag [12:18:49] ta [12:19:27] #security is still also wanted - I believe #security is "this task might have a security impact" and #security-team is "this is something the security team is interested/doing/etc" [12:20:12] ook, ta [12:26:48] (03PS1) 10Addshore: wikidata-query-gui-build run webdriver [integration/config] - 10https://gerrit.wikimedia.org/r/668069 [12:27:15] (03PS2) 10Addshore: wikidata-query-gui-build run webdriver [integration/config] - 10https://gerrit.wikimedia.org/r/668069 (https://phabricator.wikimedia.org/T210286) [12:27:29] (03CR) 10Addshore: [C: 03+2] "deployed" [integration/config] - 10https://gerrit.wikimedia.org/r/668069 (https://phabricator.wikimedia.org/T210286) (owner: 10Addshore) [12:28:10] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Wikidata, and 4 others: Create docker based CI job to build the wikidata-query-gui - https://phabricator.wikimedia.org/T210286 (10Addshore) Now failing with: ` 12:26:08 12:26:08... [12:28:41] (03Merged) 10jenkins-bot: wikidata-query-gui-build run webdriver [integration/config] - 10https://gerrit.wikimedia.org/r/668069 (https://phabricator.wikimedia.org/T210286) (owner: 10Addshore) [12:32:50] 10MediaWiki-Codesniffer: Create a sniff to enforce alphabetical order of literal arrays - https://phabricator.wikimedia.org/T247813 (10Lucas_Werkmeister_WMDE) In Wikibase, the autofixer of this sniff seems to indent the array with spaces instead of tabs. That doesn’t seem to happen in the sniff’s test, and as fa... [12:33:50] Can I access the stuff provided by ssh-agent-credentials in a docker container? [12:36:46] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Wikidata, and 4 others: Create docker based CI job to build the wikidata-query-gui - https://phabricator.wikimedia.org/T210286 (10Addshore) The main difference between our current... [12:42:30] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Wikidata, and 5 others: Create docker based CI job to build the wikidata-query-gui - https://phabricator.wikimedia.org/T210286 (10Addshore) a:05Lucas_Werkmeister_WMDE→03Addshore [14:59:09] (03PS1) 10Esanders: Zuul: [mediawiki/extensions/DiscussionTools] Run phan with Echo [integration/config] - 10https://gerrit.wikimedia.org/r/668101 [15:07:34] Majavah liw: that is indeed correct, re: ' #security is still also wanted - I believe #security is "this task might have a security impact" and #security-team is "this is something the security team is interested/doing/etc" ' [15:07:59] sbassett, thank you for confirming [15:21:44] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.33 deployment blockers - https://phabricator.wikimedia.org/T274937 (10LarsWirzenius) Train is on group1 now. [15:26:02] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Scap, 10Patch-For-Review: Update Scap to perform rolling restart for all MW deploy - https://phabricator.wikimedia.org/T266055 (10LarsWirzenius) A data point, in case it's useful. I just pro... [15:29:08] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Release, 10Train Deployments: 1.36.0-wmf.34 deployment blockers - https://phabricator.wikimedia.org/T274938 (10Urbanecm) [15:39:54] 10Project-Admins: Create a #WMIT-LimeSurvey Tag - https://phabricator.wikimedia.org/T276343 (10valerio.bozzolan) [15:40:38] 10Project-Admins, 10WMIT-Infrastructure: Create a #WMIT-LimeSurvey Tag - https://phabricator.wikimedia.org/T276343 (10valerio.bozzolan) [15:50:50] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO, 10SRE, and 2 others: Add prometheus exporter to Gerrit - https://phabricator.wikimedia.org/T184086 (10hashar) I kind of forgot about this task. It is still not complete since we need to collect metrics for the rep... [15:51:16] 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Phatality: Phatality can't report bugs from very long messages - https://phabricator.wikimedia.org/T255671 (10Krinkle) Does Phabricator support reading form fields from POST when opening a create form URL? [16:41:55] (03Abandoned) 10David Caro: tox: Allow passing the injected parameters to tox itself [integration/config] - 10https://gerrit.wikimedia.org/r/663212 (https://phabricator.wikimedia.org/T274370) (owner: 10David Caro) [16:46:42] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.33 deployment blockers - https://phabricator.wikimedia.org/T274937 (10LarsWirzenius) [16:46:50] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.33 deployment blockers - https://phabricator.wikimedia.org/T274937 (10LarsWirzenius) Reported {T276353}, as a blocker. [16:47:02] (03CR) 10Jforrester: [C: 03+2] Zuul: [mediawiki/extensions/DiscussionTools] Run phan with Echo [integration/config] - 10https://gerrit.wikimedia.org/r/668101 (owner: 10Esanders) [16:48:32] (03Merged) 10jenkins-bot: Zuul: [mediawiki/extensions/DiscussionTools] Run phan with Echo [integration/config] - 10https://gerrit.wikimedia.org/r/668101 (owner: 10Esanders) [16:49:12] greg-g: Oh dear, that's not good. I assume that means both bots are broken? [16:49:35] !log Zuul: [mediawiki/extensions/DiscussionTools] Run phan with Echo [16:49:39] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [16:51:36] James_F: kunal took care of those two yesterday, and I didn't notice any other obvious-bot email addresses being removed [16:51:43] so, hopefully not?! [16:51:45] greg-g: Ah, good. [16:51:50] * James_F was off yesterday. [16:51:58] sorry for the day-off ping [16:52:19] :-) [16:57:26] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO, 10Release Pipeline, 10serviceops-radar: Pipeline: provide a way to rebuild all blubber images - https://phabricator.wikimedia.org/T214431 (10thcipriani) p:05Triage→03Low >>! In T214431#6479172, @LarsWirzenius wrote: > Meta comment:... [17:19:05] (03PS1) 10Umherirrender: Preserve tabs when autofix @phpcs-require-sorted-array [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/668136 (https://phabricator.wikimedia.org/T247813) [17:19:10] 10MediaWiki-Codesniffer, 10Patch-For-Review: Create a sniff to enforce alphabetical order of literal arrays - https://phabricator.wikimedia.org/T247813 (10Umherirrender) phpcs replaces all spaces with tabs before processing internally. The sniff itself does not change the tabs to spaces, but when the spaces ar... [17:22:45] (03CR) 10jerkins-bot: [V: 04-1] Preserve tabs when autofix @phpcs-require-sorted-array [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/668136 (https://phabricator.wikimedia.org/T247813) (owner: 10Umherirrender) [17:24:47] (03PS2) 10Umherirrender: Preserve tabs when autofix @phpcs-require-sorted-array [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/668136 (https://phabricator.wikimedia.org/T247813) [17:35:44] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Phatality, 10Developer Productivity: Phatality: Move Request ID back to task description - https://phabricator.wikimedia.org/T237683 (10Krinkle) a:03Krinkle [17:41:56] 10MediaWiki-Codesniffer, 10Patch-For-Review: Create a sniff to enforce alphabetical order of literal arrays - https://phabricator.wikimedia.org/T247813 (10Lucas_Werkmeister_WMDE) Odd, we should have that `DisallowSpaceIndent` in the Wikibase ruleset (it’s in the MediaWiki one and we don’t disable it). But that... [17:44:10] (03CR) 10Lucas Werkmeister (WMDE): [C: 03+2] Preserve tabs when autofix @phpcs-require-sorted-array [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/668136 (https://phabricator.wikimedia.org/T247813) (owner: 10Umherirrender) [17:44:54] 10MediaWiki-Codesniffer, 10Patch-For-Review: Create a sniff to enforce alphabetical order of literal arrays - https://phabricator.wikimedia.org/T247813 (10Lucas_Werkmeister_WMDE) …and of course, when I tried to test your fix, I couldn’t reproduce the issue in Wikibase with or without it :D but I +2ed it anyways. [17:45:03] 10MediaWiki-Codesniffer, 10Patch-For-Review: Create a sniff to enforce alphabetical order of literal arrays - https://phabricator.wikimedia.org/T247813 (10Umherirrender) >>! In T247813#6879762, @Lucas_Werkmeister_WMDE wrote: > Odd, we should have that `DisallowSpaceIndent` in the Wikibase ruleset (it’s in the... [17:46:12] (03Merged) 10jenkins-bot: Preserve tabs when autofix @phpcs-require-sorted-array [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/668136 (https://phabricator.wikimedia.org/T247813) (owner: 10Umherirrender) [18:03:21] 10Release-Engineering-Team (Code Health), 10MediaWiki-extensions-FlaggedRevs, 10Code-Stewardship-Reviews: Code stewardship review: FlaggedRevs - https://phabricator.wikimedia.org/T185664 (10Ladsgroup) Seen new errors causing issues for users: {T275322} [18:21:46] (03CR) 1020after4: [C: 03+1] scap: restart php-fpm on promote [integration/docroot] - 10https://gerrit.wikimedia.org/r/666308 (https://phabricator.wikimedia.org/T275468) (owner: 10Hashar) [18:22:17] (03PS1) 10Umherirrender: Preserve tabs when autofix in DocCommentSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/668170 [18:56:45] 10Release-Engineering-Team (Logspam), 10JavaScript, 10MediaWiki-Interface (Tables), 10Patch-For-Review, and 2 others: Some tables cannot be sorted (TypeError: $nextRows[i] is undefined in table sorting / Uncaught TypeError: Cannot read property 'type' of undefine... - https://phabricator.wikimedia.org/T265503 [19:12:14] 10Continuous-Integration-Infrastructure: CI tox-buster image failing with python 2 errors - https://phabricator.wikimedia.org/T276384 (10awight) [19:16:34] (03CR) 10Awight: "I want to say that the error is caused by T276384 and not the fault of the patch. I'll push a workaround to test that theory." [integration/quibble] - 10https://gerrit.wikimedia.org/r/587885 (https://phabricator.wikimedia.org/T235449) (owner: 10Awight) [19:23:35] (03PS35) 10Awight: Parallelism as a command object [integration/quibble] - 10https://gerrit.wikimedia.org/r/587885 (https://phabricator.wikimedia.org/T235449) [19:24:05] (03PS10) 10Awight: Split extension and skin npm and composer tests [integration/quibble] - 10https://gerrit.wikimedia.org/r/587888 [19:24:10] (03PS4) 10Awight: Split core npm and composer tests [integration/quibble] - 10https://gerrit.wikimedia.org/r/588087 [19:24:12] (03PS1) 10Awight: Work around python2 in tox container [integration/quibble] - 10https://gerrit.wikimedia.org/r/668176 (https://phabricator.wikimedia.org/T276384) [19:25:58] (03CR) 10jerkins-bot: [V: 04-1] Split extension and skin npm and composer tests [integration/quibble] - 10https://gerrit.wikimedia.org/r/587888 (owner: 10Awight) [19:34:24] 10Release-Engineering-Team, 10serviceops: switch prod Phabricator from phab1003 to phab1001 - https://phabricator.wikimedia.org/T238956 (10Cmjohnson) [19:46:39] Krinkle: The instructions at https://www.mediawiki.org/wiki/Gerrit/Advanced_usage#Manage_a_team_dashboard give me `fatal: invalid refspec 'refs/meta/dashboards/:refs/remotes/origin/dashboards_teams'`. Is the documentation out of date, or am I doing something wrong? [19:48:27] James_F: neither [19:48:57] I made a typo when I did this edit: https://www.mediawiki.org/w/index.php?title=Gerrit/Advanced_usage&diff=prev&oldid=4410530&diffmode=source [19:48:58] fixed now [19:49:02] Oooh. :-) [19:49:45] Thanks. [19:50:34] 10phabricator maintenance bot: Remove Patch for review when patch is abandoned - https://phabricator.wikimedia.org/T276390 (10Zabe) [19:51:27] Krinkle: I'm kicking you out of the AW group in gerrit to clean up the dashboard. No hard feelings. :-) [19:53:10] yep, np [19:53:45] 10Release-Engineering-Team (Logspam), 10Collection, 10Wikimedia-production-error: CollectionProposals.php: count(): Parameter must be an array or an object that implements Countable - https://phabricator.wikimedia.org/T275785 (10thcipriani) [19:55:21] (03CR) 10Jforrester: [C: 03+2] Revert "Zuul: [mediawiki/services/function-schemata] Use bespoke pipeline jobs" [integration/config] - 10https://gerrit.wikimedia.org/r/667812 (owner: 10Cory Massaro) [19:56:11] (03CR) 10jerkins-bot: [V: 04-1] Work around python2 in tox container [integration/quibble] - 10https://gerrit.wikimedia.org/r/668176 (https://phabricator.wikimedia.org/T276384) (owner: 10Awight) [19:56:54] (03Merged) 10jenkins-bot: Revert "Zuul: [mediawiki/services/function-schemata] Use bespoke pipeline jobs" [integration/config] - 10https://gerrit.wikimedia.org/r/667812 (owner: 10Cory Massaro) [19:58:00] 10Beta-Cluster-Infrastructure, 10Cloud-VPS (Debian Jessie Deprecation): Migrate deployment-prep away from Debian Jessie to Debian Stretch/Buster - https://phabricator.wikimedia.org/T218729 (10Andrew) We're coming up on a year since Jessie support ended. Here are the remaining Jessie VMs in deployment-prep: d... [19:58:11] thcipriani et al, there are > 10 VMs in deployment-prep still running Debian Jessie: https://phabricator.wikimedia.org/T218729#6880503 [19:58:36] Majavah has expressed interest in rebuilding some of those; can someone here offer support with that? [19:59:14] !log Zuul: [mediawiki/services/function-schemata] Revert "Use bespoke pipeline jobs" [19:59:20] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [20:02:49] (03CR) 10Jforrester: "(And jjb definitions manually deleted from prod CI.)" [integration/config] - 10https://gerrit.wikimedia.org/r/667812 (owner: 10Cory Massaro) [20:03:14] 10Beta-Cluster-Infrastructure, 10Cloud-VPS (Debian Jessie Deprecation): Migrate deployment-prep away from Debian Jessie to Debian Stretch/Buster - https://phabricator.wikimedia.org/T218729 (10Andrew) On the one-year anniversary of Debian's EOL (June 30, 2021) I'll just delete these unless there's some indicati... [20:03:33] andrewbogott: ah, great! my honest answer is that the amount of support depends on which 10 VMs it is, but I'm willing to do some air traffic control there. Adding tasks for Release Engineering Team will get tasks seen, but, again, support is going to be pretty variable there. [20:03:59] thcipriani: the particular VMs are listed at that phab link, https://phabricator.wikimedia.org/T218729#6880503. Thank you! [20:04:01] some of those instances prod equivalents are also still on jessie :( [20:04:23] Indeed, we only dropped jessie support from CI last month. [20:04:46] WMCS support seems to be rather more forward-positioned than SRE, let alone RelEng. [20:04:57] I am responding to Moritz's comments here: https://gerrit.wikimedia.org/r/c/operations/puppet/+/668005 [20:05:06] If he is wrong then… I will do my best to stop caring [20:05:35] * James_F grins. [20:06:26] mwlog (fka flourine) and etcd are both jessie [20:06:43] Yup. [20:06:45] "Debian GNU/Linux 8.11 (jessie)" [20:06:55] As of three seconds ago logging into prod. [20:07:19] legoktm: like what? mwlog? [20:07:20] Is this the difference between "new boxes are born stretch" and "old boxes on jessie have been re-imaged"? [20:07:27] mutante: Yeah. mwlog1001. [20:07:32] yes [20:07:41] that's the only one then i think [20:07:51] probably shouldnt block all the others [20:08:14] indeed [20:08:35] and no reason that deployment-prep should not move to buster in advance of prod doing so [20:10:04] Is there a plan for Beta Cluster in the m7i-on-k8s world? [20:10:41] * James_F has an interest, given he's going to be putting new services into production in a few months' time and would like to avoid deploying to faux-scb [20:13:07] if beta is supposed to be "like prod", then it should be all buster, if beta is supposed to be used to test the next version, then maybe even bullseye. it's 2 different use cases though that are imho not really compatible. [20:13:23] More than two. :-( [20:13:50] "Like prod", "like prod in the near future" ^ (200 config changes). [20:13:55] To all questions /is there a plan for Beta Cluster .*/ I believe the answer is 'no' until someone above our pay grades decides to fund it. [20:14:02] andrewbogott: Ack. [20:17:08] but as mentioned above I might be interested in getting rid of Jessie, but don't have shell/admin access [20:22:36] * legoktm tries to remember whether deployment-prep access needs a NDA [20:22:48] I think it doesn't [20:22:55] bd808 said it does nor [20:23:01] s/nor/not [20:24:19] ok [20:24:47] thcipriani: any objection to adding Majavah as a deployment-prep project admin? [20:25:22] stepped into a meeting which is why I vanished, no objection :) [20:26:50] (03CR) 10Awight: "recheck" [integration/quibble] - 10https://gerrit.wikimedia.org/r/668176 (https://phabricator.wikimedia.org/T276384) (owner: 10Awight) [20:29:57] thanks legoktm [20:30:00] !log added Majavah as projectadmin in deployment-prep (Beta Cluster) [20:30:03] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [20:30:40] thanks! I'll avoid breaking everything [20:30:45] Majavah: try not to break things, feel free to ask for help in here, etc. :) [20:33:38] Majavah: if any of the existing VMs turn out to have flavors with more than 20Gb disk allocation, please ping me for additional excitement :) [20:33:44] Wait, we're /not/ meant to break things? That's where I've been going wrong. [20:35:21] andrewbogott: sure, thanks! [20:46:01] * bd808 reassures James_F that he does the right kind of breaking [20:46:49] Aha, well, that's OK then. [20:53:49] (03PS1) 10QChris: Allow “Gerrit Managers” to import history [debs/pygments] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/668194 [20:53:51] (03CR) 10QChris: [V: 03+2 C: 03+2] Allow “Gerrit Managers” to import history [debs/pygments] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/668194 (owner: 10QChris) [20:54:37] (03PS1) 10QChris: Import done. Revoke import grants [debs/pygments] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/668195 [20:54:39] (03CR) 10QChris: [V: 03+2 C: 03+2] Import done. Revoke import grants [debs/pygments] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/668195 (owner: 10QChris) [21:01:49] (03CR) 10Awight: "Another unrelated build failure:" [integration/quibble] - 10https://gerrit.wikimedia.org/r/668176 (https://phabricator.wikimedia.org/T276384) (owner: 10Awight) [21:01:54] (03CR) 10Awight: "recheck" [integration/quibble] - 10https://gerrit.wikimedia.org/r/668176 (https://phabricator.wikimedia.org/T276384) (owner: 10Awight) [21:07:16] (03PS36) 10Awight: Parallelism as a command object [integration/quibble] - 10https://gerrit.wikimedia.org/r/587885 (https://phabricator.wikimedia.org/T235449) [21:16:47] (03CR) 10Awight: Parallelism as a command object (032 comments) [integration/quibble] - 10https://gerrit.wikimedia.org/r/587885 (https://phabricator.wikimedia.org/T235449) (owner: 10Awight) [21:26:44] (03CR) 10Hashar: [C: 04-1] "I am not sure what is the exact problem you are trying to solve, but at least this one cause all venvs to use python3 for all env!" (033 comments) [integration/quibble] - 10https://gerrit.wikimedia.org/r/668176 (https://phabricator.wikimedia.org/T276384) (owner: 10Awight) [21:30:07] (03PS11) 10Awight: Split extension and skin npm and composer tests [integration/quibble] - 10https://gerrit.wikimedia.org/r/587888 [21:36:11] 10Continuous-Integration-Infrastructure, 10Patch-For-Review: CI tox-buster image failing with python 2 errors - https://phabricator.wikimedia.org/T276384 (10hashar) I am not sure what leads to: ` /usr/bin/python -m virtualenv --no-download --python /usr/bin/python venv-py3 >venv-py3/log/check-0.log ` Even if... [21:39:23] (03PS1) 10Jeena Huneidi: Define and pass allowed credentials to pipeline [integration/config] - 10https://gerrit.wikimedia.org/r/668199 (https://phabricator.wikimedia.org/T269900) [21:42:03] 10Continuous-Integration-Infrastructure, 10Patch-For-Review, 10ci-test-error: CI tox-buster image failing with python 2 errors - https://phabricator.wikimedia.org/T276384 (10hashar) To clarify: I pretty sure it is a behavior change introduced by the tox 3.10.0 to 3.21.4 The CI tooling being hit by a regress... [21:42:40] (03PS1) 10Krinkle: helpers: Remove search for obsolete 'fatal_error' field [releng/phatality] - 10https://gerrit.wikimedia.org/r/668201 [21:42:42] (03PS1) 10Krinkle: Various updates and alignment with MediaWiki/PHP semantics [releng/phatality] - 10https://gerrit.wikimedia.org/r/668202 (https://phabricator.wikimedia.org/T237682) [21:42:44] (03PS1) 10Krinkle: Add .editorconfig [releng/phatality] - 10https://gerrit.wikimedia.org/r/668203 [21:44:51] 10Continuous-Integration-Infrastructure, 10Patch-For-Review, 10ci-test-error: CI tox-buster image failing with python 2 errors - https://phabricator.wikimedia.org/T276384 (10awight) Sorry, I left out the error report itself, I was seeing unrelated CI failures from my quibble patches, for example [[ https://i... [21:45:03] (03PS2) 10Krinkle: Various updates and alignment with MediaWiki/PHP semantics [releng/phatality] - 10https://gerrit.wikimedia.org/r/668202 (https://phabricator.wikimedia.org/T237682) [21:45:05] (03PS2) 10Krinkle: Add .editorconfig [releng/phatality] - 10https://gerrit.wikimedia.org/r/668203 [21:46:14] (03PS3) 10Krinkle: Various updates and alignment with MediaWiki/PHP semantics [releng/phatality] - 10https://gerrit.wikimedia.org/r/668202 (https://phabricator.wikimedia.org/T237682) [21:46:16] (03PS3) 10Krinkle: Add .editorconfig [releng/phatality] - 10https://gerrit.wikimedia.org/r/668203 [21:48:33] (03CR) 10Awight: Work around python2 in tox container (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/668176 (https://phabricator.wikimedia.org/T276384) (owner: 10Awight) [21:54:49] (03PS4) 10Krinkle: Various updates and alignment with MediaWiki/PHP semantics [releng/phatality] - 10https://gerrit.wikimedia.org/r/668202 (https://phabricator.wikimedia.org/T237682) [21:54:51] (03PS4) 10Krinkle: Add .editorconfig [releng/phatality] - 10https://gerrit.wikimedia.org/r/668203 [21:54:53] (03PS1) 10Krinkle: helpers: Refuse to pre-fill trace if it contains unredacted strings [releng/phatality] - 10https://gerrit.wikimedia.org/r/668207 [21:55:35] (03PS2) 10Krinkle: helpers: Refuse to pre-fill trace if it contains unredacted strings [releng/phatality] - 10https://gerrit.wikimedia.org/r/668207 [22:03:13] (03CR) 10jerkins-bot: [V: 04-1] Split extension and skin npm and composer tests [integration/quibble] - 10https://gerrit.wikimedia.org/r/587888 (owner: 10Awight) [22:11:06] 10Continuous-Integration-Infrastructure, 10Patch-For-Review, 10ci-test-error: CI tox-buster image failing with python 2 errors - https://phabricator.wikimedia.org/T276384 (10hashar) Yes forcing python3 is definitely the thing to do. However when one does: ` [testenv] basepython = python3 ` tox will enforces... [22:30:31] (03PS3) 10Krinkle: helpers: Refact trace and url when needed [releng/phatality] - 10https://gerrit.wikimedia.org/r/668207 [22:31:46] (03PS4) 10Krinkle: helpers: Redact trace and url [releng/phatality] - 10https://gerrit.wikimedia.org/r/668207 [22:37:11] 10Beta-Cluster-Infrastructure, 10Parsoid (Tracking): beta: broken puppet deployment-parsoid11; Server Error; deployment-puppetdb03.deployment-prep.eqiad.wmflabs - https://phabricator.wikimedia.org/T270355 (10Arlolra) [23:53:14] (03CR) 10Jeena Huneidi: "This change is ready for review." [integration/config] - 10https://gerrit.wikimedia.org/r/668199 (https://phabricator.wikimedia.org/T269900) (owner: 10Jeena Huneidi)