[06:03:53] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10SRE, 10Traffic, 10GitLab (Initialization), and 2 others: open firewall ports on gitlab1001.wikimedia.org (was: Port map of how Gitlab is accessed) - https://phabricator.wikimedia.org/T276144 (10Sergey.Trofimovsky.SF) >>! In T276144#6887981,... [07:32:06] 10Phabricator (Upstream), 10Upstream: drydock: translation typo on source: `chagne` - https://phabricator.wikimedia.org/T218447 (10Aklapper) 05Open→03Resolved Sounds fixed to me, thanks everyone [07:34:45] 10Release-Engineering-Team (Code Health), 10MediaWiki-extensions-FlaggedRevs, 10Code-Stewardship-Reviews: Code stewardship review: FlaggedRevs - https://phabricator.wikimedia.org/T185664 (10Aklapper) @Jrbranaa: How to proceed here? [07:52:20] 10Project-Admins, 10WikiProject-X: Archive #WikiProject-X in Phabricator? Wiki page says it's defunct. - https://phabricator.wikimedia.org/T274351 (10Aklapper) @Danny_B, @Harej, @Isarra, @XZise: No reply, so I guess that's a Yes. [07:57:51] (03CR) 10DCausse: [C: 03+1] "> Patch Set 1:" [releng/dev-images] - 10https://gerrit.wikimedia.org/r/668549 (https://phabricator.wikimedia.org/T276499) (owner: 10Kosta Harlan) [08:50:48] 10Continuous-Integration-Config, 10Striker: Striker CI fails when run under Buster due to libmariadbclient - https://phabricator.wikimedia.org/T276605 (10hashar) That might be the cache that needs to be deleted. I imagine `mysqlclient` requirements requires some compilation and the resulting wheel build under... [08:52:47] (03PS1) 10Hashar: jjb: labs/tools/striker jobs to Buster again [integration/config] - 10https://gerrit.wikimedia.org/r/669732 (https://phabricator.wikimedia.org/T276605) [08:57:43] !log Nuked castor cache for labs/striker # T276605 [08:57:46] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [08:57:46] T276605: Striker CI fails when run under Buster due to libmariadbclient - https://phabricator.wikimedia.org/T276605 [08:58:02] (03CR) 10Hashar: [C: 03+2] "Cache nuked :)" [integration/config] - 10https://gerrit.wikimedia.org/r/669732 (https://phabricator.wikimedia.org/T276605) (owner: 10Hashar) [08:59:52] (03Merged) 10jenkins-bot: jjb: labs/tools/striker jobs to Buster again [integration/config] - 10https://gerrit.wikimedia.org/r/669732 (https://phabricator.wikimedia.org/T276605) (owner: 10Hashar) [09:02:30] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Striker: Striker CI fails when run under Buster due to libmariadbclient - https://phabricator.wikimedia.org/T276605 (10hashar) [09:02:43] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Striker: Striker CI fails when run under Buster due to libmariadbclient - https://phabricator.wikimedia.org/T276605 (10hashar) 05Open→03Resolved a:03hashar [10:14:14] 10Gerrit: gerrit's sshd is incompatible with RSA pubkeys + Fedora 33 clients (and future versions of OpenSSH proper) - https://phabricator.wikimedia.org/T276486 (10hashar) My understanding is that recent OpenSsh client has deprecated `ssh-rsa (RSA/SHA1)` and that now has to be explicitly allowed on the client si... [10:17:19] (03PS1) 10Gehel: Run sonar analysis with proper parameters for Java projects. [integration/config] - 10https://gerrit.wikimedia.org/r/669760 (https://phabricator.wikimedia.org/T264873) [10:19:17] 10Gerrit: Can't `git pull` mediawiki/core from Gerrit: "fatal: the remote end hung up unexpectedly" - https://phabricator.wikimedia.org/T263293 (10hashar) [10:23:31] 10Gerrit: Can't `git pull` mediawiki/core from Gerrit: "fatal: the remote end hung up unexpectedly" - https://phabricator.wikimedia.org/T263293 (10hashar) [10:48:55] (03CR) 10Kosta Harlan: [C: 03+1] "Seems OK to me but we'd have to run it to be sure :)" (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/669760 (https://phabricator.wikimedia.org/T264873) (owner: 10Gehel) [11:03:33] (03PS1) 10ZPapierski: Add sonar scanner to discolytics [integration/config] - 10https://gerrit.wikimedia.org/r/669770 (https://phabricator.wikimedia.org/T264877) [11:04:30] (03CR) 10jerkins-bot: [V: 04-1] Add sonar scanner to discolytics [integration/config] - 10https://gerrit.wikimedia.org/r/669770 (https://phabricator.wikimedia.org/T264877) (owner: 10ZPapierski) [11:08:25] (03PS2) 10ZPapierski: Add sonar scanner to discolytics [integration/config] - 10https://gerrit.wikimedia.org/r/669770 (https://phabricator.wikimedia.org/T264877) [11:14:09] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10GitLab (Initialization), 10User-brennen: Define auth strategy for GitLab - https://phabricator.wikimedia.org/T274461 (10MoritzMuehlenhoff) >>! In T274461#6887973, @thcipriani wrote: > Aside question for outbound ports for {T276144}. Looking a... [11:18:44] (03CR) 10Kosta Harlan: "> Patch Set 1: Code-Review+1" [releng/dev-images] - 10https://gerrit.wikimedia.org/r/668549 (https://phabricator.wikimedia.org/T276499) (owner: 10Kosta Harlan) [11:29:48] 10Project-Admins, 10User-Kizule: Create User-Zabe project - https://phabricator.wikimedia.org/T276719 (10Kizule) 05Open→03Resolved Requested public project #user-zabe has been created: https://phabricator.wikimedia.org/project/view/5242/ Feel free to [watch the project](https://www.mediawiki.org/wiki/Phab... [11:29:50] 10Phabricator (Upstream), 10Upstream: Per-user projects for personal work in progress tracking - https://phabricator.wikimedia.org/T555 (10Kizule) [12:19:39] 10Phabricator (phabricator-next), 10Upstream: Unhandled exception clicking "Next" button on Notifications page: Rows must have unique IDs. An underlying query may be missing a GROUP BY. - https://phabricator.wikimedia.org/T276447 (10Aklapper) [12:44:53] (03CR) 10Gehel: Run sonar analysis with proper parameters for Java projects. (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/669760 (https://phabricator.wikimedia.org/T264873) (owner: 10Gehel) [12:55:33] (03PS2) 10Gehel: Run sonar analysis with proper parameters for Java projects. [integration/config] - 10https://gerrit.wikimedia.org/r/669760 (https://phabricator.wikimedia.org/T264873) [13:18:41] 10Continuous-Integration-Config, 10Code-Health-Metrics, 10Sonarqubebot: Remove independent code health pipeline and integrate into test pipeline - https://phabricator.wikimedia.org/T240935 (10hashar) For Maven based projects, Sonar has been integrated in the test pipeline via a series of change. The latest b... [13:30:10] hashar: I think I finally found the issue with those sonar comments! https://gerrit.wikimedia.org/r/c/integration/config/+/669760 [13:30:23] meeting starting now [13:50:43] (03CR) 10Hashar: [C: 03+2] "That is a lot of copy paste but that can be fixed later :]" [integration/config] - 10https://gerrit.wikimedia.org/r/669760 (https://phabricator.wikimedia.org/T264873) (owner: 10Gehel) [13:50:58] gehel: nice :) [13:51:02] gehel: I have updated all the jobs [13:52:10] hashar: Cool! I'll need to merge something to properly test it... [13:52:32] or rebuild the job in jenkins maybe [13:52:45] (03Merged) 10jenkins-bot: Run sonar analysis with proper parameters for Java projects. [integration/config] - 10https://gerrit.wikimedia.org/r/669760 (https://phabricator.wikimedia.org/T264873) (owner: 10Gehel) [13:53:52] hashar: right! let me try that [14:03:22] hashar: looks like it is working on a trivial project: https://integration.wikimedia.org/ci/job/discovery-parent-pom-maven-java8-docker-site-publish/55/console [14:03:39] wdqs still running: https://integration.wikimedia.org/ci/job/wikidata-query-rdf-maven-java8-docker-site-publish/153/console [14:12:40] hashar: wdqs in success as well [14:12:55] now let's recheck an open CR and see if sonar comments work [14:21:51] 10Gerrit: gerrit's sshd is incompatible with RSA pubkeys + Fedora 33 clients (and future versions of OpenSSH proper) - https://phabricator.wikimedia.org/T276486 (10CDanis) >>! In T276486#6891521, @hashar wrote: > What I understand is that the Mina SSHD version embedded in our Gerrit does not have support for the... [15:35:55] 10Release-Engineering-Team (Logspam), 10MediaWiki-extensions-LiquidThreads, 10Wikimedia-production-error: PHP Notice: unserialize(): Error at offset 65519 of 65535 bytes - https://phabricator.wikimedia.org/T259111 (10Daimona) This seems to be caused by the value being truncated: ` > $title = Title::makeTit... [15:39:12] 10Phabricator: Proposed changes to the SRE Access request (Phabricator form 8) - https://phabricator.wikimedia.org/T276473 (10RobH) I'm happy to edit the form once this is signed off on, but unsubscribing for now until then. Once this is ready for the actual change to the form (approved the directors I suppose... [16:25:32] 10Gerrit: gerrit's sshd is incompatible with RSA pubkeys + Fedora 33 clients (and future versions of OpenSSH proper) - https://phabricator.wikimedia.org/T276486 (10Legoktm) The "easy" workaround/solution is to use a `ssh-ed25519` key, which is both supported by Gerrit and not deprecated by Fedora. [16:37:33] 10phan-taint-check-plugin: Make "escaped" specific for taint type - https://phabricator.wikimedia.org/T269260 (10Daimona) While doing this, one thing to keep in mind: we can't add as many constants as we want. Right now, the maximum taint constant in use is 1<<26, and every taint flavour (there are 12) has a nor... [16:42:21] (03CR) 10Lars Wirzenius: [C: 03+2] mirror-repos.sh: Add additional repos [tools/train-dev] - 10https://gerrit.wikimedia.org/r/668732 (owner: 10Ahmon Dancy) [16:42:23] (03CR) 10Lars Wirzenius: [V: 03+2 C: 03+2] mirror-repos.sh: Add additional repos [tools/train-dev] - 10https://gerrit.wikimedia.org/r/668732 (owner: 10Ahmon Dancy) [16:43:10] (03CR) 10Lars Wirzenius: [C: 03+2] "Not sure if --update shouldn't be the default, but if want that, we can change it later." [tools/train-dev] - 10https://gerrit.wikimedia.org/r/668729 (owner: 10Ahmon Dancy) [16:43:12] (03CR) 10Lars Wirzenius: [V: 03+2 C: 03+2] mirror-repos.sh: add --update mode [tools/train-dev] - 10https://gerrit.wikimedia.org/r/668729 (owner: 10Ahmon Dancy) [16:43:37] (03CR) 10Lars Wirzenius: [C: 03+2] create-databases: use a more complex admin password [tools/train-dev] - 10https://gerrit.wikimedia.org/r/668728 (owner: 10Ahmon Dancy) [16:43:39] (03CR) 10Lars Wirzenius: [V: 03+2 C: 03+2] create-databases: use a more complex admin password [tools/train-dev] - 10https://gerrit.wikimedia.org/r/668728 (owner: 10Ahmon Dancy) [16:45:10] (03CR) 10Lars Wirzenius: [C: 03+2] Terminate ControlMaster ssh process after playbooks [tools/train-dev] - 10https://gerrit.wikimedia.org/r/668731 (owner: 10Ahmon Dancy) [16:45:12] (03CR) 10Lars Wirzenius: [V: 03+2 C: 03+2] Terminate ControlMaster ssh process after playbooks [tools/train-dev] - 10https://gerrit.wikimedia.org/r/668731 (owner: 10Ahmon Dancy) [16:45:55] (03CR) 10Lars Wirzenius: [C: 03+2] nginx: Add X-Forwarded-Proto: https header [tools/train-dev] - 10https://gerrit.wikimedia.org/r/668730 (owner: 10Ahmon Dancy) [16:45:58] (03CR) 10Lars Wirzenius: [V: 03+2 C: 03+2] nginx: Add X-Forwarded-Proto: https header [tools/train-dev] - 10https://gerrit.wikimedia.org/r/668730 (owner: 10Ahmon Dancy) [16:46:24] (03CR) 10Lars Wirzenius: [C: 03+2] Move to 1.36.0-wmf.30 and 1.36.0-wmf.31 [tools/train-dev] - 10https://gerrit.wikimedia.org/r/668733 (owner: 10Ahmon Dancy) [16:46:27] (03CR) 10Lars Wirzenius: [V: 03+2 C: 03+2] Move to 1.36.0-wmf.30 and 1.36.0-wmf.31 [tools/train-dev] - 10https://gerrit.wikimedia.org/r/668733 (owner: 10Ahmon Dancy) [17:24:43] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Release, 10Train Deployments, 10User-brennen: 1.36.0-wmf.34 deployment blockers - https://phabricator.wikimedia.org/T274938 (10brennen) [17:33:23] 10Project-Admins: Create an #ai-governance tag - https://phabricator.wikimedia.org/T276639 (10ACraze) @Aklapper Yes, tasks under the "AI/ML Governance" umbrella seek to develop a set of processes/best practices that deliver on ethical or legal responsibilities in order to uphold fairness, accountability, and tra... [17:33:56] 10Project-Admins: Create an #AI-Governance tag - https://phabricator.wikimedia.org/T276639 (10ACraze) [17:53:13] 10Release-Engineering-Team (Logspam), 10MediaWiki-extensions-LiquidThreads, 10Wikimedia-production-error: PHP Notice: unserialize(): Error at offset 65519 of 65535 bytes - https://phabricator.wikimedia.org/T259111 (10Krinkle) @Daimona What is the impact on end-user experience currently? The object that we ar... [17:55:14] (03PS1) 10Lars Wirzenius: fix: add missing "template" to subplot YAML metadata [tools/train-dev] - 10https://gerrit.wikimedia.org/r/669924 [17:55:36] (03CR) 10AndyRussG: "> Getting this on build:" [releng/dev-images] - 10https://gerrit.wikimedia.org/r/663159 (https://phabricator.wikimedia.org/T262975) (owner: 10AndyRussG) [17:55:51] (03CR) 10Ahmon Dancy: [C: 03+2] fix: add missing "template" to subplot YAML metadata [tools/train-dev] - 10https://gerrit.wikimedia.org/r/669924 (owner: 10Lars Wirzenius) [17:56:55] (03CR) 10Brennen Bearnes: "> Hi! Thanks so much for digging in!!!" [releng/dev-images] - 10https://gerrit.wikimedia.org/r/663159 (https://phabricator.wikimedia.org/T262975) (owner: 10AndyRussG) [18:01:40] (03CR) 10Lars Wirzenius: [V: 03+2] fix: add missing "template" to subplot YAML metadata [tools/train-dev] - 10https://gerrit.wikimedia.org/r/669924 (owner: 10Lars Wirzenius) [18:07:44] 10Release-Engineering-Team (Logspam), 10MediaWiki-extensions-LiquidThreads, 10Wikimedia-production-error: PHP Notice: unserialize(): Error at offset 65519 of 65535 bytes - https://phabricator.wikimedia.org/T259111 (10Daimona) >>! In T259111#6893449, @Krinkle wrote: > @Daimona What is the impact on end-user e... [18:25:53] 10Release-Engineering-Team (Logspam), 10JavaScript, 10MediaWiki-Interface (Tables), 10Patch-For-Review, and 2 others: Some tables cannot be sorted (TypeError: $nextRows[i] is undefined in table sorting / Uncaught TypeError: Cannot read property 'type' of undefine... - https://phabricator.wikimedia.org/T265503 [18:34:19] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10GitLab (Initialization), 10User-brennen: Remove Speed & Function blockers for GitLab work - https://phabricator.wikimedia.org/T274458 (10Dzahn) [19:33:18] (03CR) 10DannyS712: [C: 03+1] build: Updating eslint-config-wikimedia to 0.18.2 [integration/docroot] - 10https://gerrit.wikimedia.org/r/669950 (owner: 10Libraryupgrader) [19:48:39] FYI: I just removed the legacy "uploader" account from docker-registry.wm.o, so if pushes start failing, it means we didn't update the credentials somewhere [19:52:52] (03CR) 10Legoktm: [C: 04-1] "Doesn't work" [integration/config] - 10https://gerrit.wikimedia.org/r/668335 (owner: 10Legoktm) [19:57:01] 10Beta-Cluster-Infrastructure, 10Patch-For-Review, 10User-Majavah: deployment-prometheus02 puppet failures due to Apache not recognizing "RewriteRule" - https://phabricator.wikimedia.org/T276654 (10Majavah) 05Open→03Resolved [20:01:15] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Patch-For-Review: l10n process for MW containerization - https://phabricator.wikimedia.org/T260827 (10dancy) [20:01:19] Majavah: I assume https://gerrit.wikimedia.org/r/c/operations/puppet/+/669477 isn't ready yet? [20:01:30] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Patch-For-Review: l10n process for MW containerization - https://phabricator.wikimedia.org/T260827 (10dancy) [20:02:20] legoktm: it should be, but I want to watch for breakage when it's deployed and haven't had time for that yet [20:02:33] ack [20:28:28] 10Project-Admins: Create an #AI-Governance tag - https://phabricator.wikimedia.org/T276639 (10Aklapper) 05Open→03Resolved a:03Aklapper Requested public project #AI-Governance has been created: https://phabricator.wikimedia.org/project/view/5244/ I edited the project description (see also https://www.media... [21:09:12] (03CR) 10Hashar: [C: 04-1] Add sonar scanner to discolytics (033 comments) [integration/config] - 10https://gerrit.wikimedia.org/r/669770 (https://phabricator.wikimedia.org/T264877) (owner: 10ZPapierski) [21:19:08] 10Beta-Cluster-Infrastructure, 10Continuous-Integration-Infrastructure, 10DBA, 10Wikimedia-Rdbms, and 2 others: Enable MariaDB/MySQL's Strict Mode - https://phabricator.wikimedia.org/T108255 (10Krinkle) [21:37:15] (03CR) 10Brennen Bearnes: [V: 03+2 C: 03+2] "Builds locally; publishing momentarily." [releng/dev-images] - 10https://gerrit.wikimedia.org/r/663159 (https://phabricator.wikimedia.org/T262975) (owner: 10AndyRussG) [21:38:57] !log Updating dev-images docker-pkg files on primary contint for https://gerrit.wikimedia.org/r/c/releng/dev-images/+/663159 [21:38:59] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [21:39:12] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10serviceops, 10Patch-For-Review: Replace production deployment servers and update them to Buster - https://phabricator.wikimedia.org/T265963 (10Dzahn) @Andrew Could you please deploy a change... [21:47:06] 10Release-Engineering-Team-TODO, 10DNS, 10SRE, 10Traffic, and 3 others: DNS for GitLab - https://phabricator.wikimedia.org/T276170 (10Dzahn) The change above is abandoned because it was about adding a director to the traffic/caching layer and now the VM moved from private to public network. So it is not be... [21:52:31] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10SRE, 10GitLab (Initialization), 10User-brennen: SSH Access of Git data in GitLab - https://phabricator.wikimedia.org/T276148 (10Dzahn) >>! In T276148#6875418, @Legoktm wrote: > Also I believe `git-ssh.wikimedia.org` ran/runs a public sshd o... [21:55:22] 10Release-Engineering-Team-TODO, 10DNS, 10SRE, 10Traffic, and 3 others: DNS for GitLab - https://phabricator.wikimedia.org/T276170 (10brennen) > Do you really want "gitlab" for the MVP though, not like gitlab-test.wikimedia.org or gitlab-beta.wikimedia.org ? Yeah, I think so. Users (and other consumers o... [21:58:29] 10Release-Engineering-Team-TODO, 10DNS, 10SRE, 10Traffic, and 3 others: DNS for GitLab - https://phabricator.wikimedia.org/T276170 (10Sergey.Trofimovsky.SF) >>! In T276170#6894252, @Dzahn wrote: > Do you really want "gitlab" for the MVP though, not like gitlab-test.wikimedia.org or gitlab-beta.wikimedi... [22:02:48] why isnt https://gerrit.wikimedia.org/r/c/mediawiki/core/+/668463 going into gate and submit? [22:09:32] (03PS5) 1020after4: Various updates and alignment with MediaWiki/PHP semantics [releng/phatality] - 10https://gerrit.wikimedia.org/r/668202 (https://phabricator.wikimedia.org/T237682) (owner: 10Krinkle) [22:09:56] 10Release-Engineering-Team-TODO, 10DNS, 10SRE, 10Traffic, and 3 others: DNS for GitLab - https://phabricator.wikimedia.org/T276170 (10Dzahn) > not like gitlab-test.wikimedia.org or gitlab-beta.wikimedia.org ? > > Yeah, I think so. Users (and other consumers of data, like bots) are going to have git remot... [22:10:03] Zppix: Reedy just rebased it [22:10:17] * Zppix saw [22:10:23] It's still recheck though not resubmit [22:10:46] See what happens next [22:10:57] But it didn't go through because you didn't recheck it [22:11:28] Not sure why for 9:18 [22:11:48] But anyway if it still gets awkward then Reedy can kick it a bit more [22:12:08] I can't +2 it though [22:12:35] It already has a +2 [22:12:42] Reedy: my guess is because the first +2 tests failed, jenkins doesnt see the original +2 ive seen this before [22:12:45] Just needs to actually submit [22:12:59] (03CR) 1020after4: "@krinkle: I fixed a couple of minor issues:" [releng/phatality] - 10https://gerrit.wikimedia.org/r/668202 (https://phabricator.wikimedia.org/T237682) (owner: 10Krinkle) [22:13:26] Reedy: remove your +2 and +2 again ;) [22:13:50] depend on the change of course [22:13:59] I'm not blessed with FR +2 powa [22:14:27] ahhh yeah [22:14:47] so someone from fundraising has to CR+2 [22:14:57] I find it weird how no one can even +1 it [22:15:01] or Cstone has to drop the CR+2 vote and vote again [22:15:04] which will trigger the event [22:15:12] it is not weird [22:15:25] the fundraising/* branches have very specific and exclusive rights [22:15:39] which only let member of the fundraising team to act on patches [22:15:50] I can revote [22:15:54] a Gerrit administrator can obviously work around that but should not [22:16:04] hashar: why don't Jenkins recognise the +2 already there? Is that deliberate? [22:16:04] hashar: it was more why it didn't gate and submit it originally [22:16:14] It failed the first few times [22:16:16] the first CR+2 did trigger the gate and submit [22:16:18] but it failed [22:16:37] so jenkins-bot votes verified -1 which prevents the change from being submitted [22:16:53] the CR+2 vote stick around, cause jenkins-bot does not magically remove other people votes [22:17:08] But when it re +2'd and 9:18PM should it not have submitted? [22:17:18] the rebase done by reedy has the CR+2 votes carried from PS1 to PS2 because that is only a rebase [22:17:30] but that does not trigger a CI run [22:17:30] It would have been C+2,V+2 then [22:17:34] Oh [22:17:43] one has to emit a comment with CR+2 vote to trigger gate-and-submit [22:17:43] Is that intended or just Jenkins ? [22:17:49] a rebase is merely just a new patchset created [22:18:12] but maybe a Code-Review +2 should not be kept after a rebase [22:18:27] cstone: you might want to remove your +2 and reapply it :) [22:18:36] Someone -1'd it anyway [22:18:39] we might have just decided to not merge it at all [22:18:49] heh [22:18:50] ;D [22:19:04] but thanks for looking at it :) [22:19:13] But the short answer is only a new C+2 triggers Jenkins not old ones from rebases or past checks [22:19:16] lol [22:19:21] RhinosF1: yes [22:19:23] I sleep with new knowledge about how weird CI is [22:19:29] which is a bit of an oddity [22:20:55] I used to do training session about gerrit/ci etc years and years ago [22:21:01] guess I can do those again :D [22:22:16] in short a change enters gate and submit if has CR+2 comment [22:23:21] I learn by asking questions when confused [22:23:47] that is the good attitude to have :] [22:24:05] and how I learned most of that stuff by asking around myself! [22:24:09] At least I remembered to set my alarm rig before falling asleep because my journey is no longer the 2 minutes down stairs! That would have been a fun tommorow! I should actually sleep now though! [22:24:32] Half the time I just talk out loud and eventually my nonsense makes enough sense I find out anyway [22:24:46] ;-]] [22:24:53] I am heading to sleep as well! [22:24:58] happy hacking everyone [22:25:08] You're in front of me so definately should [22:25:12] Anyway actually might [22:40:58] 10Release-Engineering-Team-TODO, 10DNS, 10SRE, 10Traffic, and 3 others: DNS for GitLab - https://phabricator.wikimedia.org/T276170 (10brennen) Yeah, good question - sorry I conflated machine-specific with a `-test` / `-beta` hostname in my response. I //think// `gitlab.wikimedia.org` is good, on my curren... [22:55:41] (03CR) 10Eileen: "woohoo" [releng/dev-images] - 10https://gerrit.wikimedia.org/r/663159 (https://phabricator.wikimedia.org/T262975) (owner: 10AndyRussG) [23:05:04] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Zuul, 10observability, 10User-dancy: Monitor /var/log/zuul/error.log - https://phabricator.wikimedia.org/T258821 (10brennen) [23:05:20] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Zuul, and 3 others: Improve scheduling of CI jobs invoked by zuul - https://phabricator.wikimedia.org/T258630 (10brennen) [23:17:59] 10Release-Engineering-Team-TODO, 10DNS, 10SRE, 10Traffic, and 3 others: DNS for GitLab - https://phabricator.wikimedia.org/T276170 (10Sergey.Trofimovsky.SF) >>! In T276170#6894358, @brennen wrote: > Yeah, good question - sorry I conflated machine-specific with a `-test` / `-beta` hostname in my response. >... [23:33:00] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10GitLab (Initialization), 10User-brennen: Define auth strategy for GitLab - https://phabricator.wikimedia.org/T274461 (10brennen) @MoritzMuehlenhoff - @Sergey.Trofimovsky.SF is hoping to do some testing of CAS setup from `gitlab-test`. Could... [23:40:23] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Release, 10Train Deployments: 1.36.0-wmf.35 deployment blockers - https://phabricator.wikimedia.org/T274939 (10thcipriani) p:05Triage→03Medium a:03dancy [23:41:31] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Release, 10Train Deployments: 1.36.0-wmf.36 deployment blockers - https://phabricator.wikimedia.org/T274940 (10thcipriani) p:05Triage→03Medium a:03hashar [23:46:19] (03PS6) 10Krinkle: Various updates and alignment with MediaWiki/PHP semantics [releng/phatality] - 10https://gerrit.wikimedia.org/r/668202 (https://phabricator.wikimedia.org/T237682) [23:47:34] (03PS7) 10Krinkle: Various updates and alignment with MediaWiki/PHP semantics [releng/phatality] - 10https://gerrit.wikimedia.org/r/668202 (https://phabricator.wikimedia.org/T237682) [23:48:10] (03CR) 10Krinkle: [C: 03+1] "* Fixed bad argument pass." [releng/phatality] - 10https://gerrit.wikimedia.org/r/668202 (https://phabricator.wikimedia.org/T237682) (owner: 10Krinkle) [23:55:18] 10Release-Engineering-Team (Logspam), 10Wikimedia-General-or-Unknown, 10JavaScript, 10Patch-For-Review, 10Wikimedia-production-error: TypeError: format.replace is not a function in randomToken function used by SearchSatisfaction schema - https://phabricator.wikimedia.org/T272904 (10Jdlrobson) https://ger... [23:57:39] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Release, 10Train Deployments, 10User-brennen: 1.36.0-wmf.34 deployment blockers - https://phabricator.wikimedia.org/T274938 (10brennen)