[00:49:39] 10Continuous-Integration-Config, 10Release-Engineering-Team-TODO, 10Platform Engineering: Enable PHP assertions in WMF CI - https://phabricator.wikimedia.org/T276940 (10Krinkle) Can you provide an example of an `assert()` statement you'd want to add, where, and why? And what alternatives there may be nativel... [03:33:18] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Release, 10Train Deployments: 1.36.0-wmf.35 deployment blockers - https://phabricator.wikimedia.org/T274939 (10Ladsgroup) >>! In T274939#6926527, @brennen wrote: > @Ladsgroup any chance T277795 qualifies? Fortunately for me, it doesn't :D [04:03:18] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Release, 10Train Deployments: 1.36.0-wmf.36 deployment blockers - https://phabricator.wikimedia.org/T274940 (10Ladsgroup) ### Risky Patch! đŸš‚đŸ”„ * **Change**: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FlaggedRevs/+/672570 (in gene... [05:36:52] is there a way to run the gate checks without actually submitting? re https://gerrit.wikimedia.org/r/c/mediawiki/core/+/672845 [05:49:55] TimStarling: I don't know the context of the patch but "check experimental" does some of the gate checks (like postgres) [05:50:00] not all [05:50:39] if not, you can +2 it and immediately remove it [05:51:03] I need the PHP 7.3 checks, it only seems to run PHP 7.2 on upload [05:51:58] looks like check experimental should do it, looking at layout.yaml, thanks Amir1 [05:52:26] Awesome [06:40:59] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10SRE, 10GitLab (Initialization), 10User-brennen: Define auth strategy for GitLab - https://phabricator.wikimedia.org/T274461 (10Sergey.Trofimovsky.SF) >> Something missing from the docs? > ahh yes, i have placed the ldap cn=admin password in... [07:40:05] 10Release-Engineering-Team (Code Health), 10MediaWiki-extensions-FlaggedRevs, 10Code-Stewardship-Reviews, 10User-notice: Code stewardship review: FlaggedRevs - https://phabricator.wikimedia.org/T185664 (10Ladsgroup) >>! In T185664#6924606, @Tgr wrote: > Thank you @Ladsgroup for chipping away at this pile o... [07:44:17] 10Release-Engineering-Team (Unit & Int & System Tooling), 10Pywikibot, 10Pywikibot-tests: Lint test to match function signature and documentation - https://phabricator.wikimedia.org/T277396 (10Xqt) @Huji: I didn’t found a flake8 package for it but deep source can do it for us: https://deepsource.io/gh/ankitd... [07:44:30] 10Release-Engineering-Team (Unit & Int & System Tooling), 10Pywikibot, 10Pywikibot-tests: Lint test to match function signature and documentation - https://phabricator.wikimedia.org/T277396 (10Xqt) p:05Triage→03Medium [07:49:53] 10Release-Engineering-Team (Code Health), 10MediaWiki-extensions-FlaggedRevs, 10Code-Stewardship-Reviews, 10User-notice: Code stewardship review: FlaggedRevs - https://phabricator.wikimedia.org/T185664 (10Ladsgroup) Two other aspects to work on: - Frontend. It has two options `wgSimpleFlaggedRevsUI` that'... [08:28:41] (03PS1) 10Addshore: Remove unused mediawiki-quibble-apitests-{packages-source}-docker jobs [integration/config] - 10https://gerrit.wikimedia.org/r/673438 (https://phabricator.wikimedia.org/T277750) [08:36:34] (03CR) 10Hashar: [C: 03+1] "IIRC the originally idea was to run API tests with production in mind, hence why that was hardcoded to use php7.2. Now that we have vario" [integration/config] - 10https://gerrit.wikimedia.org/r/673438 (https://phabricator.wikimedia.org/T277750) (owner: 10Addshore) [08:37:42] (03CR) 10Addshore: "> Patch Set 1: Code-Review+1" [integration/config] - 10https://gerrit.wikimedia.org/r/673438 (https://phabricator.wikimedia.org/T277750) (owner: 10Addshore) [08:38:19] (03CR) 10Addshore: "Is it okay to just remove the jobs from JJB?" [integration/config] - 10https://gerrit.wikimedia.org/r/673438 (https://phabricator.wikimedia.org/T277750) (owner: 10Addshore) [08:38:21] addshore: you can merge that one ;) [08:38:33] (03CR) 10Addshore: [C: 03+2] Remove unused mediawiki-quibble-apitests-{packages-source}-docker jobs [integration/config] - 10https://gerrit.wikimedia.org/r/673438 (https://phabricator.wikimedia.org/T277750) (owner: 10Addshore) [08:38:46] and if a job is no more defined in jjb but is still triggered in zuul/layout.yaml , we should have a test that fails [08:38:47] I dont even need to deploy right? as it won't actually remove the jobs? [08:39:05] 👍 [08:39:11] yeah jobs gotta be removed manually [08:39:30] till someone get to figure out how to automatize that ;] [08:39:37] I thought about using scap to deploy integration/config [08:39:47] and then invoke jjb from the deployment server to realize the jobs on Jenkins [08:40:01] which means dealing with credentials, configuring scap and packaging jjb for deployment [08:40:07] (03Merged) 10jenkins-bot: Remove unused mediawiki-quibble-apitests-{packages-source}-docker jobs [integration/config] - 10https://gerrit.wikimedia.org/r/673438 (https://phabricator.wikimedia.org/T277750) (owner: 10Addshore) [08:40:25] as for which php version to use for which branches / repos [08:40:30] that is not formalized unfortunately [08:40:51] we probably need a reference documentation/policy and some process to modify it [08:41:10] it just happens organically every couple years or so as a new php version is released [08:42:24] I think php 7.0 and 7.1 got phased out already [08:42:33] with mediawiki old branches dropping support for them [08:42:43] or maybe we still have some jobs for the old REL1_31 [08:42:59] ah yeah still have php7.0 / php7.1 for REL1_31 :] [08:45:18] !log disable puppet and stop restbase service on deployment-restbase02 for T250574 [08:45:22] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [08:45:23] T250574: Replace deployment-restbase0[12] - https://phabricator.wikimedia.org/T250574 [08:48:06] hehe, ye olde branches [08:54:35] I am also fed up by the docker images we use [08:54:36] ;D [08:54:42] !log remove deployment-restbase02 from cassandra and shut it down T250574 [08:54:45] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [08:54:46] T250574: Replace deployment-restbase0[12] - https://phabricator.wikimedia.org/T250574 [08:59:42] 10Beta-Cluster-Infrastructure, 10Cloud-VPS (Debian Jessie Deprecation), 10Patch-For-Review: Replace deployment-restbase0[12] - https://phabricator.wikimedia.org/T250574 (10Majavah) deployment-restbase02 is also now removed from the cluster and shut down. I'll delete those in a week or so. [08:59:47] (03PS3) 10Hashar: jjb: increase shared memory to 1g for node10-browser jobs [integration/config] - 10https://gerrit.wikimedia.org/r/673188 (https://phabricator.wikimedia.org/T240955) (owner: 10Ladsgroup) [09:12:12] 10Beta-Cluster-Infrastructure, 10Cloud-VPS (Debian Jessie Deprecation): Migrate deployment-prep away from Debian Jessie to Debian Stretch/Buster - https://phabricator.wikimedia.org/T218729 (10Majavah) [09:13:17] 10Release-Engineering-Team-TODO, 10MW-on-K8s, 10Release Pipeline, 10serviceops, 10Patch-For-Review: Create restricted docker-registry namespace for security patched images - https://phabricator.wikimedia.org/T273521 (10JMeybohm) I did add a the fact that we require a puppet run on the docker registry hos... [09:14:10] 10Release-Engineering-Team-TODO, 10MW-on-K8s, 10Release Pipeline, 10serviceops, 10Patch-For-Review: Create restricted docker-registry namespace for security patched images - https://phabricator.wikimedia.org/T273521 (10JMeybohm) >>! In T273521#6926308, @Legoktm wrote: > OK, we really should be done now :... [09:14:16] (03CR) 10Hashar: [C: 03+2] "Thank you Amir for pushing this! I have deployed the jobs, gave it a try for VisualEditor/VisualEditor on a dummy change and:" [integration/config] - 10https://gerrit.wikimedia.org/r/673188 (https://phabricator.wikimedia.org/T240955) (owner: 10Ladsgroup) [09:14:59] 10Continuous-Integration-Config, 10Release-Engineering-Team-TODO, 10VisualEditor, 10Editing-team (Tracking), 10Technical-Debt: Firefox CI tests keep failing in VE with Firefox 68 - https://phabricator.wikimedia.org/T240955 (10hashar) 05Open→03Resolved a:03hashar Firefox 68.0 (Linux x86_64): Execute... [09:15:55] (03Merged) 10jenkins-bot: jjb: increase shared memory to 1g for node10-browser jobs [integration/config] - 10https://gerrit.wikimedia.org/r/673188 (https://phabricator.wikimedia.org/T240955) (owner: 10Ladsgroup) [09:31:48] hashar: cool blog post! https://phabricator.wikimedia.org/phame/post/view/232/tracking_memory_issue_in_a_java_application/ [09:31:53] * gehel just finished reading [09:32:02] tried my best with my limited java knowledge [09:32:20] glad you liked it ;) [09:33:14] There are some strange behaviours around -XX:ExitOnMemoryError. It doesn't not actually exit in some cases. [09:33:26] I can't remember the exact details right now :/ [09:33:43] But I do remembered that it actually made sense once I understood it. [09:35:06] in other news: sonar seems to use git merge-base to find the starting point for the analysis [09:35:32] which is unlikely to work in our case, since the merge already happened via Zuul [09:35:56] I'm tempted to try an ugly workaround: checking out the gerrit branch after analysis [09:36:46] It would mean that in non-ff merges, the code analyzed might be slightly different the the code used to build the artifacts, but that probably does not matter in most casess [09:37:09] hashar: do you think it makes sense? [09:37:10] depends on the commits / refs being passed to git merge-base I uess? [09:37:38] cause if you do: git merge-base HEAD^ HEAD [09:37:45] that should yields the commit of HEAD^ [09:38:04] aka if you have a chain of commit A -> B -> C [09:38:05] * gehel definitely does not understand enough about git [09:38:07] B being the current master [09:38:09] C being your patch [09:38:13] git merge-base B C [09:38:15] should yields B [09:38:31] and I would expect sonar to compare that B with the tip of the current branch (C) [09:38:45] that being said [09:39:01] I have noticed in the sonar console output that there is some message looking like: [SCM] Found merge base: xxxxxx [09:40:33] or maybe we need an extra parameter to give it what the reference branch is? [09:42:32] guess we can add some git log debugging output to the job? [09:42:53] like git log --decorate --graph --oneline --all -n 20 [09:43:09] which would show up the local topology for the last 20 commits or so with tags/branch showing up [09:43:14] * gehel trusts hashar on everything he said above! [09:43:27] let me find the ci config change ;D [09:43:56] I dont even remember writing the commit message of https://gerrit.wikimedia.org/r/c/integration/config/+/673273 bah [09:45:51] (03PS4) 10Hashar: (WIP) please SonarQube git heuristic [integration/config] - 10https://gerrit.wikimedia.org/r/673273 [09:46:22] ^ LGTM! [09:46:25] gehel: jobs updated with some git branch -vva and the git log thing [09:46:45] do we have sonar running with debug output? [09:46:50] yes [09:47:36] Let me know if you deploy that change, I can restart https://integration.wikimedia.org/ci/job/wikimedia-discovery-analytics-patch-tox-docker-with-sonar/ [09:49:09] updated [09:49:15] and I triggered one manually https://integration.wikimedia.org/ci/job/wikimedia-discovery-analytics-patch-tox-docker-with-sonar/25/parameters/ [09:49:25] using parameters to fetch this pending change: https://gerrit.wikimedia.org/r/c/wikimedia/discovery/analytics/+/672730 [09:49:38] which fails cause well I screwed it up somehow [09:49:59] extra space bah [09:50:06] https://integration.wikimedia.org/ci/job/wikimedia-discovery-analytics-patch-tox-docker-with-sonar/26/console [09:50:09] will see how it goes [09:50:27] In Gerrit the commit is d3cec28 and the parent is 4300929 [09:51:00] which is the tip of origin/master [09:52:39] where do you see that? I can't find those in the output [09:53:39] ofc, after the tox build, not before [09:58:22] I'm continuing to add context on https://community.sonarsource.com/t/empty-short-lived-branch-analysis/40177 [09:59:15] gehel: from https://gerrit.wikimedia.org/r/c/wikimedia/discovery/analytics/+/672730 [09:59:37] on the left side there are owner/reviewer/cc, below the repo and branch and then the parent commit sha1 [10:00:14] ack [10:00:17] ZUUL_CHANGE: unbound variable [10:00:18] pfff [10:01:23] next try https://integration.wikimedia.org/ci/job/wikimedia-discovery-analytics-patch-tox-docker-with-sonar/27/console [10:04:11] * d3cec28 (HEAD -> master, refs/changes/30/672730/1) Hive sensor naming fix in export queries to relforge [10:04:12] * 4300929 (origin/master) convert_to_esbulk: Accept partial hour timestamps [10:04:33] 10:04:15.804 DEBUG: Merge base sha1: d3cec2812ed500fab6f27d18599b5e83db60424a [10:04:38] looks like we can specify the current revision: `-Dsonar.scm.revision=...` [10:05:02] but what we need is the target [10:05:16] so yeah it find hte merge base to be ... the HEAD! [10:05:19] hence there is no diff [10:05:42] sonar using: -Dsonar.branch.target=master -Dsonar.branch.name=672730-1 [10:05:48] however from the git log [10:05:52] the master branch is ... the head [10:13:02] I guess it is confused [10:13:40] sonar.branch.target is used in the UI, and in our setup the patch has been checkoued to a local master branch [10:13:56] so maybe sonar expects the local branch to be named after sonar.branch.name [10:14:35] if Sonar is not smart enough to look at the remote tracking branch (ie: origin/master) [10:14:43] we might want to try: [10:15:05] git checkout -B master origin/master # create a local branch "master" that is set to the tip of the Gerrit branch [10:15:31] then: git checkout -B 672730-1 FETCH_HEAD # a local branch holding the patch which matches sonar.branch.name [10:15:34] and that might fix it [10:21:57] the magic is around https://github.com/SonarSource/sonarqube/blob/master/sonar-scanner-engine/src/main/java/org/sonar/scm/git/GitScmProvider.java#L241 [10:22:13] (03PS5) 10Hashar: (WIP) please SonarQube git heuristic [integration/config] - 10https://gerrit.wikimedia.org/r/673273 [10:24:07] jobs updated [10:24:08] https://integration.wikimedia.org/ci/job/wikimedia-discovery-analytics-patch-tox-docker-with-sonar/28/console [10:24:25] ah yu found the code [10:24:53] it expects an upstream remote? [10:25:01] so it's looking for a ref matching the target branch name, with some fallback mechanism [10:25:16] it picks the first one it finds [10:25:17] so yeah [10:25:31] and it search for the local ref first ( refs/heads/master ) [10:25:33] which is what we do [10:25:42] yep [10:25:43] and that refs/heads/master is the one already having the patch [10:25:45] so that is broken [10:25:50] there is already a special case for CircleCI [10:25:54] :) [10:25:56] unless we can trigger the CircleCI thing yeah [10:26:00] but that sounds like a hack [10:26:05] so maybe what I did would work [10:26:10] add Gerrit as a remote [10:26:11] return "true".equals(system2.envVariable("CIRCLECI")); [10:26:19] create a local "master" branch which match the one in Gerrit [10:26:21] we could just set that :) [10:26:28] and checkout the patch to the XXXX-YY branch [10:26:37] but that means the sonar scanner report will be made compared to the gerrit branch [10:26:48] so in a series of patch such as A (master) -> B -> C [10:26:57] the scan for C would also include issues from B [10:27:13] so we should find a way to compare against the parent commit [10:27:16] that's not the end of the world [10:27:19] yeah [10:27:22] can be tuned later [10:27:28] already better than what we (dont') have now! [10:27:35] guess we can have the local "master" branch to just be a checkout of HEAD^ [10:27:42] instead of the one from Gerrit [10:27:49] yep, that should work [10:27:56] well [10:28:04] maybe that build will do what is expected [10:28:05] but [10:28:13] I gotta head out to prepare for lunch [10:28:24] thanks for all the help! [10:28:28] and take care of the youngest kid which has been playing Minecraft for an hour+ ;] [10:28:32] et bon appĂ©tit ! [10:28:41] kudos on finding the code! [10:29:18] 10:28:24.439 DEBUG: Merge base sha1: 4300929301dcf25dc06175db3be927b902056ca1 [10:30:03] * d3cec28 (HEAD -> 672730-1, refs/changes/30/672730/1) Hive sensor naming fix in export queries to relforge [10:30:04] * 4300929 (grafted, origin/master, master) convert_to_esbulk: Accept partial hour timestamps [10:30:05] which is [10:30:11] the master branch from gerrit [10:30:29] grafted means the history is not available cause that is a shallow fetch (git fetch -d 2) [10:30:36] but turns out to not be a problem for this specific one [10:30:42] that would be otherwise for a chain of commits [10:31:21] and there is code in https://sonarcloud.io/code?branch=672730-1&id=discovery-analytics ! [10:31:22] the analysis is at https://sonarcloud.io/dashboard?id=discovery-analytics&branch=672730-1&resolved=false [10:31:24] \o/ [10:31:27] Coverage on 3 New Lines to cover [10:31:29] \o/ [10:31:32] well done! [10:31:35] amazing! [10:31:42] not go do some cooking! [10:31:48] then I guess we have to do some whiteboard design this afternoon to address the case of a series of patch [10:31:53] We can clean that this afternoon (or next week) [10:32:02] and apply the same strategy for Java projects [10:32:23] aka A (master) -> B -> C , what happens for C and against what do we want to compare ( I am inclined to compare against B [10:32:26] yeah [10:32:28] success [10:32:32] then we can write a blog post ;] [10:33:07] off for a long lunch break. Will poke you when I am back [10:33:11] ~ 14:00 hopefully [10:48:04] 10Beta-Cluster-Infrastructure, 10Cloud-VPS (Debian Jessie Deprecation): Migrate deployment-prep away from Debian Jessie to Debian Stretch/Buster - https://phabricator.wikimedia.org/T218729 (10MoritzMuehlenhoff) >>! In T218729#6907904, @Majavah wrote: >> I think we can simply remove deployment-sca01/sca02? The... [10:54:41] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10SRE, 10GitLab (Initialization), 10User-brennen: Define auth strategy for GitLab - https://phabricator.wikimedia.org/T274461 (10jbond) >>! In T274461#6927626, @Sergey.Trofimovsky.SF wrote: >>> Something missing from the docs? >> ahh yes, i h... [11:08:32] 10Continuous-Integration-Infrastructure, 10Browser-Tests: Centrally look for flakey browser tests - https://phabricator.wikimedia.org/T277205 (10Addshore) I collected some more data today. We now have some non voting `-apache-` jobs, and I want to filter those out, so switching to the follwing command: `ls ./*... [11:10:49] 10Release-Engineering-Team (Code Health), 10MediaWiki-extensions-FlaggedRevs, 10Code-Stewardship-Reviews, 10User-notice: Code stewardship review: FlaggedRevs - https://phabricator.wikimedia.org/T185664 (10Count_Count) >>! In T185664#6927669, @Ladsgroup wrote: > - User permission and auto-promote rules, we... [11:13:20] I see you talking above sonarcloud code covergae [11:13:27] it seems to not be working for Wikibase :) [11:13:28] :( [11:42:01] (03CR) 10Lars Wirzenius: [C: 03+2] Fix link to scap3 upgrade instructions [tools/scap] - 10https://gerrit.wikimedia.org/r/673335 (owner: 10Ahmon Dancy) [11:42:46] (03Merged) 10jenkins-bot: Fix link to scap3 upgrade instructions [tools/scap] - 10https://gerrit.wikimedia.org/r/673335 (owner: 10Ahmon Dancy) [11:49:17] !log remove now-deleted deployment-cumin02 from hiera allowed cumin masters [11:49:20] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [11:55:04] does anyone happen to know if deployment-cumin ssh key has a password or something? keyholder arm is asking for one and I haven't found it on a file anywhere [12:24:34] 10Continuous-Integration-Config, 10Release-Engineering-Team-TODO, 10Platform Engineering: Enable PHP assertions in WMF CI - https://phabricator.wikimedia.org/T276940 (10Daimona) >>! In T276940#6927403, @Krinkle wrote: > Can you provide an example of an `assert()` statement you'd want to add, where, and why?... [12:25:24] (03CR) 10Tobias Andersson: "This change is ready for review." [integration/config] - 10https://gerrit.wikimedia.org/r/673472 (https://phabricator.wikimedia.org/T277750) (owner: 10Tobias Andersson) [12:48:11] !log shutdown deployment-sca*, services on them are too old and broken to be useful according to the SREs, have no maintainers and the hosts are running Jessie, T218729 [12:48:17] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [12:48:17] T218729: Migrate deployment-prep away from Debian Jessie to Debian Stretch/Buster - https://phabricator.wikimedia.org/T218729 [12:51:02] 10Beta-Cluster-Infrastructure, 10Cloud-VPS (Debian Jessie Deprecation): Migrate deployment-prep away from Debian Jessie to Debian Stretch/Buster - https://phabricator.wikimedia.org/T218729 (10Majavah) [12:51:39] (03CR) 10WMDE-leszek: [C: 03+1] zuul: [mediawiki/extensions/Wikibase] remove api-tests [integration/config] - 10https://gerrit.wikimedia.org/r/673472 (https://phabricator.wikimedia.org/T277750) (owner: 10Tobias Andersson) [13:30:50] (03CR) 10Addshore: [C: 03+2] zuul: [mediawiki/extensions/Wikibase] remove api-tests [integration/config] - 10https://gerrit.wikimedia.org/r/673472 (https://phabricator.wikimedia.org/T277750) (owner: 10Tobias Andersson) [13:32:40] (03Merged) 10jenkins-bot: zuul: [mediawiki/extensions/Wikibase] remove api-tests [integration/config] - 10https://gerrit.wikimedia.org/r/673472 (https://phabricator.wikimedia.org/T277750) (owner: 10Tobias Andersson) [13:35:49] !log reload zuul for https://gerrit.wikimedia.org/r/673472 (https://phabricator.wikimedia.org/T277750) [13:35:54] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [13:40:48] 10Release-Engineering-Team (Code Health), 10MediaWiki-extensions-FlaggedRevs, 10Code-Stewardship-Reviews, 10User-notice: Code stewardship review: FlaggedRevs - https://phabricator.wikimedia.org/T185664 (10DannyS712) >>! In T185664#6927642, @Ladsgroup wrote: >>>! In T185664#6924606, @Tgr wrote: >> QualityOv... [14:05:32] 10Beta-Cluster-Infrastructure, 10Cloud-VPS (Debian Jessie Deprecation): Migrate from deployment-logstash2 (jessie) to deployment-logstash03 (stretch) - https://phabricator.wikimedia.org/T238707 (10Majavah) Note: other Cloud VPS projects (wikidata-query, striker, ores, phabricator) [[ https://codesearch.wmcloud... [14:07:15] gehel: un long repas et une bouteille de vin plus tard, me voilĂ  finalement [14:08:52] 10Continuous-Integration-Config, 10Code-Health, 10Discovery-Search (Current work), 10Patch-For-Review: Ensure that SonarQube is commenting on gerrit code reviews of the Search Platform team - https://phabricator.wikimedia.org/T264873 (10Gehel) Looking at the [[ https://github.com/SonarSource/sonarqube/blob... [14:09:40] cool! [14:10:34] c'Ă©tait quoi le next step? Tu fais un peu de magie et tu corriges tout ça ? [14:10:40] le fromage et un cafĂ©? [14:10:54] Ah ouais, ou bien ça... [14:11:05] en gros on fait l'analyse sur le patch prĂ©cĂ©dent ( HEAD^ ) ou sur la branche dans Gerrit? [14:11:41] je pense qu'il faut faire par rapport Ă  HEAD^ [14:12:07] mais ça ne fonctionne que si on a un merge fast-forward, no? [14:12:19] si on a deux parent, HEAD^ est ambigu? [14:12:59] ou alors on passe tous nos dĂ©pos on ff-only? [14:14:07] hmm [14:14:17] aucune idĂ©e [14:16:33] j'aurais tendance Ă  dire: on (enfin, tu) sait comment faire l'analyse par rapport Ă  la branche gerrit, et c'est suffisant, mĂȘme si c'est pas idĂ©al [14:16:52] commençons par lĂ , comme ça on a du feedback [14:16:57] done is better than perfect [14:17:21] et il y a deux cas Ă  gĂ©rer [14:17:29] analyse de branche vs patch [14:19:00] l'analyse de branch devrait fonctionner dans tous les cas, on ne passe pas sonar.target.branch et du coup on ne fait pas d'analyse differentielle du tout [14:19:11] (Ă  vĂ©rifier) [14:19:55] yep, je suis Ă  peu prĂšs sĂ»r que l'analyse de branche est un cas simple [14:22:08] je suis pas sur [14:22:22] je crois que pour l'analyse de branche il va se perdre [14:22:26] on verra bien [14:24:35] je crois que pour l'analyse de branche, il n'utilise pas git du tout (Ă  part pour le blame, mais lĂ  on est dĂ©jĂ  perdu avec no shallow clones) [14:36:43] (03PS6) 10Hashar: jjb: fix sonar code comparison [integration/config] - 10https://gerrit.wikimedia.org/r/673273 [14:38:04] gehel: ^ dĂ©ploys [14:38:26] j'ai mis Ă  jour le message de commit [14:38:45] Je vais juste faire des courses et j'arrive ;) [14:39:06] Une chance que tu puisses faire la mĂȘme chose pour les builds Java ? [14:42:19] ouais :-\ [14:42:30] faut un avenant au contra,t il y aura des frais [14:42:32] :D [14:46:57] si ce changement marche pour l'analyse de branche et celui de patch je pense que c'est bon [14:47:05] ensuite on peut utiliser la meme logique pour les autres jobs [14:47:22] j'aimerai bien que l'invocation de sonar:scaner soit la meme quelque soit le type de job [14:51:48] (03CR) 10WMDE-leszek: "This change is ready for review." [integration/config] - 10https://gerrit.wikimedia.org/r/673503 (https://phabricator.wikimedia.org/T277750) (owner: 10WMDE-leszek) [14:57:46] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Wikidata, and 5 others: Create docker based CI job to build the wikidata-query-gui - https://phabricator.wikimedia.org/T210286 (10Silvan_WMDE) This successfully ran in CI here: ht... [14:58:20] (03CR) 10Addshore: "afaik this won't do a composer install" [integration/config] - 10https://gerrit.wikimedia.org/r/673503 (https://phabricator.wikimedia.org/T277750) (owner: 10WMDE-leszek) [14:58:51] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Wikidata, and 5 others: Create docker based CI job to build the wikidata-query-gui - https://phabricator.wikimedia.org/T210286 (10Addshore) 05Open→03Resolved [14:58:54] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10castor: Don't hardcode castor url in castor docker container - https://phabricator.wikimedia.org/T216244 (10Addshore) [15:00:07] (03CR) 10WMDE-leszek: "> Patch Set 1:" [integration/config] - 10https://gerrit.wikimedia.org/r/673503 (https://phabricator.wikimedia.org/T277750) (owner: 10WMDE-leszek) [15:00:56] (03CR) 10Addshore: "> Patch Set 1:" [integration/config] - 10https://gerrit.wikimedia.org/r/673503 (https://phabricator.wikimedia.org/T277750) (owner: 10WMDE-leszek) [15:04:04] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10castor: Don't hardcode castor url in castor docker container - https://phabricator.wikimedia.org/T216244 (10Addshore) Can the host just be exposed in CI generally as an env var? [15:05:35] (03CR) 10Gehel: [C: 03+1] "LGTM" [integration/config] - 10https://gerrit.wikimedia.org/r/673273 (owner: 10Hashar) [15:06:10] (03CR) 10Hashar: [C: 03+2] jjb: fix sonar code comparison [integration/config] - 10https://gerrit.wikimedia.org/r/673273 (owner: 10Hashar) [15:06:14] hashar: "l'invocation de sonar:scaner soit la meme" ? Qu'entends-tu par lĂ ? [15:06:28] passer les meme parametres pour tox ou maven [15:06:38] er java [15:06:53] (03PS1) 10Hashar: jjb: remove unused assert-node-version [integration/config] - 10https://gerrit.wikimedia.org/r/673512 [15:07:49] (03Merged) 10jenkins-bot: jjb: fix sonar code comparison [integration/config] - 10https://gerrit.wikimedia.org/r/673273 (owner: 10Hashar) [15:09:20] hashar: il manque effectivement `-Dsonar.analysis.allowCommentOnMaster="1" -Dsonar.analysis.gerritProjectName="$ZUUL_PROJECT"` pour python [15:10:03] Ă  part ça les seules differences, je crois que c'est liĂ© Ă  sonnar-scanner vs maven [15:11:45] !log Re-cherry-picking https://gerrit.wikimedia.org/r/c/operations/puppet/+/623068 in beta. [15:11:48] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [15:20:59] 10Release-Engineering-Team (Code Health), 10MediaWiki-extensions-FlaggedRevs, 10Code-Stewardship-Reviews, 10User-notice: Code stewardship review: FlaggedRevs - https://phabricator.wikimedia.org/T185664 (10stjn) >>! In T185664#6927669, @Ladsgroup wrote: > - Frontend. It has two options `wgSimpleFlaggedRevs... [15:27:43] (03PS1) 10Gehel: jjb: fix sonar code comparison [integration/config] - 10https://gerrit.wikimedia.org/r/673517 (https://phabricator.wikimedia.org/T264873) [15:28:12] hashar: ^ I shamelessly stole your code and comments to apply them to Java as well [15:28:28] 10Release-Engineering-Team (Code Health), 10MediaWiki-extensions-FlaggedRevs, 10Code-Stewardship-Reviews, 10User-notice: Code stewardship review: FlaggedRevs - https://phabricator.wikimedia.org/T185664 (10stjn) >>! In T185664#6924606, @Tgr wrote: > RevisionReview sounds important but I'm not really sure wh... [15:28:59] (03CR) 10jerkins-bot: [V: 04-1] jjb: fix sonar code comparison [integration/config] - 10https://gerrit.wikimedia.org/r/673517 (https://phabricator.wikimedia.org/T264873) (owner: 10Gehel) [15:29:39] presque :D [15:31:40] (03PS1) 10Gehel: search/python: add proper options for sonar bot commenting [integration/config] - 10https://gerrit.wikimedia.org/r/673518 (https://phabricator.wikimedia.org/T264877) [15:33:00] (03CR) 10jerkins-bot: [V: 04-1] search/python: add proper options for sonar bot commenting [integration/config] - 10https://gerrit.wikimedia.org/r/673518 (https://phabricator.wikimedia.org/T264877) (owner: 10Gehel) [15:35:53] gehel: il manque le parametre {branch} je crois [15:36:34] 00:00:35.229 jenkins_jobs.errors.JenkinsJobsException: branch parameter missing to format branch -m "{branch}" [15:36:35] ouais [15:36:48] branch: $ZUUL_BRANCH [15:36:54] c'est ce qu'on a pour le job python [15:37:01] (03PS2) 10Gehel: search/python: add proper options for sonar bot commenting [integration/config] - 10https://gerrit.wikimedia.org/r/673518 (https://phabricator.wikimedia.org/T264877) [15:38:18] (03CR) 10jerkins-bot: [V: 04-1] search/python: add proper options for sonar bot commenting [integration/config] - 10https://gerrit.wikimedia.org/r/673518 (https://phabricator.wikimedia.org/T264877) (owner: 10Gehel) [15:38:33] hashar: on it [15:39:26] (03PS2) 10Gehel: jjb: fix sonar code comparison [integration/config] - 10https://gerrit.wikimedia.org/r/673517 (https://phabricator.wikimedia.org/T264873) [15:39:28] (03PS3) 10Gehel: search/python: add proper options for sonar bot commenting [integration/config] - 10https://gerrit.wikimedia.org/r/673518 (https://phabricator.wikimedia.org/T264877) [15:40:29] (03CR) 10jerkins-bot: [V: 04-1] jjb: fix sonar code comparison [integration/config] - 10https://gerrit.wikimedia.org/r/673517 (https://phabricator.wikimedia.org/T264873) (owner: 10Gehel) [15:40:45] (03CR) 10jerkins-bot: [V: 04-1] search/python: add proper options for sonar bot commenting [integration/config] - 10https://gerrit.wikimedia.org/r/673518 (https://phabricator.wikimedia.org/T264877) (owner: 10Gehel) [15:41:58] (03PS3) 10Gehel: jjb: fix sonar code comparison [integration/config] - 10https://gerrit.wikimedia.org/r/673517 (https://phabricator.wikimedia.org/T264873) [15:42:00] (03PS4) 10Gehel: search/python: add proper options for sonar bot commenting [integration/config] - 10https://gerrit.wikimedia.org/r/673518 (https://phabricator.wikimedia.org/T264877) [15:42:06] maybe finally correct :/ [15:45:10] yeah [15:45:11] lets try [15:45:50] at least the build is green, not sure if it actually works [15:47:10] (03CR) 10Hashar: [C: 03+2] "Deployed" [integration/config] - 10https://gerrit.wikimedia.org/r/673517 (https://phabricator.wikimedia.org/T264873) (owner: 10Gehel) [15:47:14] ça se deploit [15:47:24] ideally we will want a single macro which is shared by all the jobs [15:47:28] but that can be fixed later [15:48:23] testing in https://integration.wikimedia.org/ci/job/search-extra-maven-java8-docker/247/console [15:48:36] I'll let you do the macro magic! [15:48:38] (03Merged) 10jenkins-bot: jjb: fix sonar code comparison [integration/config] - 10https://gerrit.wikimedia.org/r/673517 (https://phabricator.wikimedia.org/T264873) (owner: 10Gehel) [15:49:33] 10Release-Engineering-Team (Unit & Int & System Tooling), 10Pywikibot, 10Pywikibot-tests: Lint test to match function signature and documentation - https://phabricator.wikimedia.org/T277396 (10Xqt) Probably https://pypi.org/project/darglint/ would be appropriate for this [15:53:59] 10Phabricator: Spaces request for Technical-Program-Management - https://phabricator.wikimedia.org/T277107 (10MBinder_WMF) >>! In T277107#6924050, @Aklapper wrote: > @MBinder_WMF: Thanks for elaborating! The four project tags plus #Technical-Program-Management have a restricted Join policy and restricted Edit Po... [15:54:04] (03PS5) 10Dduvall: Default image tags to included any given git tag [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/673070 (https://phabricator.wikimedia.org/T277346) [15:55:46] (03CR) 10Hashar: [C: 03+2] search/python: add proper options for sonar bot commenting [integration/config] - 10https://gerrit.wikimedia.org/r/673518 (https://phabricator.wikimedia.org/T264877) (owner: 10Gehel) [15:57:23] looks like still nothing reported :/ [15:58:07] Oh, but that one was already merged, so that might explain [15:58:09] (03Merged) 10jenkins-bot: search/python: add proper options for sonar bot commenting [integration/config] - 10https://gerrit.wikimedia.org/r/673518 (https://phabricator.wikimedia.org/T264877) (owner: 10Gehel) [15:59:11] 10Release-Engineering-Team (Code Health), 10MediaWiki-extensions-FlaggedRevs, 10Code-Stewardship-Reviews, 10User-notice: Code stewardship review: FlaggedRevs - https://phabricator.wikimedia.org/T185664 (10Asartea) I have clicked the ‘advertise to other users that you are checking the edits’ at some point b... [15:59:11] rebuilding https://gerrit.wikimedia.org/r/c/search/glent/+/673154 instead [16:00:27] (03CR) 10Hashar: [C: 03+2] jjb: remove unused assert-node-version [integration/config] - 10https://gerrit.wikimedia.org/r/673512 (owner: 10Hashar) [16:01:43] (03Merged) 10jenkins-bot: jjb: remove unused assert-node-version [integration/config] - 10https://gerrit.wikimedia.org/r/673512 (owner: 10Hashar) [16:03:54] still not working on the Java side. I'll stop for today and maybe get back to it next week [16:04:30] yeah :-\ [16:04:45] at least it works for the python job [16:04:48] so we had some progress [16:06:01] gehel: it does not seem to checkout to a branch named 673154-2 [16:06:07] there are two checkouts, both for "master" [16:06:21] :/ [16:06:33] different logic ;D [16:06:49] there are two python jobs [16:06:56] one for branch analysis, the other for per patch [16:07:01] the later has the checkout of {branch} [16:07:10] which turns out to be the chanage + patchset [16:07:14] the maven job does not have that logic [16:07:34] but yeah not that far [16:07:44] I will give up for today. Triaged emails [16:07:53] I am going out to get some sun and fresh air before the curfew [16:08:57] hashar: enjoy the weekend! [16:11:56] (03PS1) 10Lars Wirzenius: chore: get lib/runcmd.py from Subplot, use it [tools/scap] - 10https://gerrit.wikimedia.org/r/673529 [16:12:03] (03CR) 10Jforrester: "Nice!" [integration/config] - 10https://gerrit.wikimedia.org/r/673188 (https://phabricator.wikimedia.org/T240955) (owner: 10Ladsgroup) [16:13:08] (03PS1) 10David Caro: Review access change [cloud/storage-performance-tests] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/673122 [16:13:30] (03CR) 10David Caro: [C: 03+1] Review access change [cloud/storage-performance-tests] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/673122 (owner: 10David Caro) [16:14:49] 10Deployments, 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)): L10n cache files building up on backup deploy hosts - https://phabricator.wikimedia.org/T275826 (10dancy) [16:16:58] (03PS2) 10WMDE-leszek: Run phan on changes onto Wikibase REL1_35 branch [integration/config] - 10https://gerrit.wikimedia.org/r/673503 (https://phabricator.wikimedia.org/T277750) [16:17:13] (03CR) 10WMDE-leszek: "I have to admit I don't understand what I am doing any more fully, got lost in the maze of JJB macros." [integration/config] - 10https://gerrit.wikimedia.org/r/673503 (https://phabricator.wikimedia.org/T277750) (owner: 10WMDE-leszek) [16:17:19] 10Release-Engineering-Team (Code Health), 10MediaWiki-extensions-FlaggedRevs, 10Code-Stewardship-Reviews, 10User-notice: Code stewardship review: FlaggedRevs - https://phabricator.wikimedia.org/T185664 (10MBH) If you set this checkbox, users who browse "Pages for reviewing" special page, will see "Some use... [16:23:51] 10Release-Engineering-Team (Code Health), 10MediaWiki-extensions-FlaggedRevs, 10Code-Stewardship-Reviews, 10User-notice: Code stewardship review: FlaggedRevs - https://phabricator.wikimedia.org/T185664 (10Tgr) Ping @Mglaser - it seems like BlueSpice contains some amount of FlagRev customizations so this mi... [16:27:25] 10Release-Engineering-Team (Code Health), 10MediaWiki-extensions-FlaggedRevs, 10Code-Stewardship-Reviews, 10User-notice: Code stewardship review: FlaggedRevs - https://phabricator.wikimedia.org/T185664 (10Tgr) >>! In T185664#6928822, @stjn wrote: >>>! In T185664#6924606, @Tgr wrote: >> RevisionReview sound... [16:30:15] 10Release-Engineering-Team (Code Health), 10MediaWiki-extensions-FlaggedRevs, 10Code-Stewardship-Reviews, 10User-notice: Code stewardship review: FlaggedRevs - https://phabricator.wikimedia.org/T185664 (10Zache) "SimpleUI" will currently break the fiwikis page layout as it will collide with some templates.... [16:44:37] 10Release-Engineering-Team (Code Health), 10MediaWiki-extensions-FlaggedRevs, 10Code-Stewardship-Reviews, 10User-notice: Code stewardship review: FlaggedRevs - https://phabricator.wikimedia.org/T185664 (10Jdforrester-WMF) >>! In T185664#6928945, @Tgr wrote: > (BTW do we want to move to a dedicated task?)... [16:46:25] (03CR) 10Ahmon Dancy: chore: get lib/runcmd.py from Subplot, use it (037 comments) [tools/scap] - 10https://gerrit.wikimedia.org/r/673529 (owner: 10Lars Wirzenius) [17:07:18] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Release, 10Train Deployments: 1.36.0-wmf.36 deployment blockers - https://phabricator.wikimedia.org/T274940 (10dancy) [17:24:39] 10Deployments, 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)): L10n cache files building up on backup deploy hosts - https://phabricator.wikimedia.org/T275826 (10dancy) @Dzahn If scap-master-sync is what it used to keep deploy2002 with deplo... [17:39:06] 10Deployments, 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)): L10n cache files building up on backup deploy hosts - https://phabricator.wikimedia.org/T275826 (10dancy) >>! In T275826#6929197, @dancy wrote: > @Dzahn If scap-master-sync is wh... [18:07:38] (03CR) 10Legoktm: "Do you still need this now that T277881 is done?" [cloud/storage-performance-tests] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/673122 (owner: 10David Caro) [19:04:46] 10Project-Admins: Create an #Daty Tag - https://phabricator.wikimedia.org/T277909 (10Legoktm) [19:30:06] 10Project-Admins: Create a #Daty Tag - https://phabricator.wikimedia.org/T277909 (10Ogoorcs) [19:30:27] 10Project-Admins: Create a #Daty Tag - https://phabricator.wikimedia.org/T277909 (10Ogoorcs) [19:35:13] 10Release-Engineering-Team-TODO, 10MediaWiki-Docker, 10Developer Productivity, 10Patch-For-Review, 10User-Addshore: Port mediawiki-docker-dev "mwdd" v1 cli in to go - https://phabricator.wikimedia.org/T253313 (10Addshore) Now that various refactorings have happened in mwcli this gets a bit easier from he... [19:46:21] 10phan-taint-check-plugin: Add taintedness data for new methods in Shellbox - https://phabricator.wikimedia.org/T273965 (10Daimona) 05Open→03Resolved [19:49:37] 10phan-taint-check-plugin: Move hardcoded taintedness annotations to MW core - https://phabricator.wikimedia.org/T277918 (10Daimona) [19:56:15] 10Continuous-Integration-Config, 10Release-Engineering-Team-TODO, 10Platform Engineering: Enable PHP assertions in WMF CI - https://phabricator.wikimedia.org/T276940 (10Krinkle) @Daimona I thought you were asking about starting to use `assert()` in "regular" source code of MW core and extensions, but I think... [20:01:28] 10Deployments, 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)): L10n cache files building up on backup deploy hosts - https://phabricator.wikimedia.org/T275826 (10Krinkle) I think maybe the reason these are not backed up in this way is because... [20:05:56] 10Deployments, 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)): L10n cache files building up on backup deploy hosts - https://phabricator.wikimedia.org/T275826 (10Krinkle) Aye, I missed the /srv/mediawiki vs mediawiki-staging distinction. This... [20:12:10] 10Continuous-Integration-Config, 10Release-Engineering-Team-TODO, 10Platform Engineering: Enable PHP assertions in WMF CI - https://phabricator.wikimedia.org/T276940 (10Daimona) >>! In T276940#6929813, @Krinkle wrote: > @Daimona I thought you were asking about starting to use `assert()` in "regular" source c... [20:16:59] 10Continuous-Integration-Config, 10Release-Engineering-Team-TODO, 10Platform Engineering: Enable PHP assertions in WMF CI - https://phabricator.wikimedia.org/T276940 (10Krinkle) OK, let me try one more time to understand: * This is not about starting use of `assert()`. It is about existing code already using... [20:23:28] 10Continuous-Integration-Config, 10Release-Engineering-Team-TODO, 10Platform Engineering: Enable PHP assertions in WMF CI - https://phabricator.wikimedia.org/T276940 (10Daimona) >>! In T276940#6929886, @Krinkle wrote: > OK, let me try one more time to understand: > * This is not about starting use of `assert... [20:25:35] 10Continuous-Integration-Config, 10Release-Engineering-Team-TODO: Enable PHP assertions in WMF CI - https://phabricator.wikimedia.org/T276940 (10Krinkle) p:05Triage→03Medium [20:39:13] 10Continuous-Integration-Config, 10Release-Engineering-Team-TODO: Enable PHP assertions in WMF CI - https://phabricator.wikimedia.org/T276940 (10Legoktm) Can you inject it in the phan-taint-check repo by running `php -dzend.assertions=1 [command]` like how we enable xdebug for PHPUnit? [20:57:20] (03CR) 10Umherirrender: [C: 04-1] FunctionAnnotationsSniff: recognize more phpunit annotations (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/670120 (https://phabricator.wikimedia.org/T276971) (owner: 10DannyS712) [21:14:31] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10SRE, 10serviceops, and 2 others: Upgrade MediaWiki clusters to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10Dzahn) [21:17:49] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10SRE, 10serviceops, and 2 others: Upgrade MediaWiki clusters to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10Dzahn) [22:06:18] 10Project-Admins, 10User-Urbanecm: Create a #Daty Tag - https://phabricator.wikimedia.org/T277909 (10Urbanecm) 05Open→03Resolved a:03Urbanecm Requested public project #daty has been created: https://phabricator.wikimedia.org/project/view/5266/ Please encourage interested people to visit the project and... [22:06:44] (03PS1) 10Umherirrender: Test ValidGlobalNameSniff with multi prefixes [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673605 [22:08:17] 10Project-Admins, 10User-Urbanecm: Create a #Daty Tag - https://phabricator.wikimedia.org/T277909 (10valerio.bozzolan) Whoa! That was quick. Thank you so much! [22:34:52] 10Project-Admins, 10User-Urbanecm: Create a #Daty Tag - https://phabricator.wikimedia.org/T277909 (10Aklapper) 05Resolved→03Open @Ogoorcs: Hi, there is already an issue tracker at https://gitlab.gnome.org/World/Daty/-/issues . Where is the canonical place to maintain bug reports and feature requests? [22:40:24] (03PS7) 10DannyS712: FunctionAnnotationsSniff: recognize more phpunit annotations [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/670120 (https://phabricator.wikimedia.org/T276971) [22:40:28] (03CR) 10DannyS712: FunctionAnnotationsSniff: recognize more phpunit annotations (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/670120 (https://phabricator.wikimedia.org/T276971) (owner: 10DannyS712) [22:51:18] (03PS1) 10Umherirrender: Test PrefixedGlobalFunctionsSniff with ignore list [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673609 [23:02:39] (03CR) 10Umherirrender: FunctionAnnotationsSniff: recognize more phpunit annotations (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/670120 (https://phabricator.wikimedia.org/T276971) (owner: 10DannyS712) [23:03:39] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team (Other / Uncategorized), 10Release-Engineering-Team-TODO, 10Cloud-Services, and 2 others: Re-think puppet management for deployment-prep - https://phabricator.wikimedia.org/T161675 (10dpifke) Intermediate proposal: can we give +2 rights on labs/priv... [23:13:13] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team (Other / Uncategorized), 10Release-Engineering-Team-TODO, 10Cloud-Services, and 2 others: Re-think puppet management for deployment-prep - https://phabricator.wikimedia.org/T161675 (10bd808) >>! In T161675#6930652, @dpifke wrote: > Intermediate prop... [23:14:17] 10MediaWiki-Codesniffer, 10Voice & Tone: Address Voice and Tone issues in MediaWiki Codesniffer - https://phabricator.wikimedia.org/T277983 (10Reedy) [23:14:43] 10phan-taint-check-plugin, 10Voice & Tone: Address Voice and Tone issues in phan-taint-check-plugin - https://phabricator.wikimedia.org/T277984 (10Reedy) [23:20:10] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team (Other / Uncategorized), 10Release-Engineering-Team-TODO, 10Cloud-Services, and 2 others: Re-think puppet management for deployment-prep - https://phabricator.wikimedia.org/T161675 (10dpifke) >>! In T161675#6930689, @bd808 wrote: > For anyone wonder... [23:21:05] (03PS1) 10Umherirrender: Test no parenthesis branch in OpeningKeywordParenthesisSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673611 [23:29:37] (03PS1) 10Umherirrender: Remove special check from SpaceBeforeBracketSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673612 [23:29:57] (03PS2) 10Umherirrender: Remove special check from SpaceBeforeBracketSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673612 [23:30:03] (03PS2) 10Umherirrender: Test no parenthesis branch in OpeningKeywordParenthesisSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673611 [23:30:21] (03PS2) 10Umherirrender: Test PrefixedGlobalFunctionsSniff with ignore list [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673609 [23:35:19] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team (Other / Uncategorized), 10Release-Engineering-Team-TODO, 10Cloud-Services, and 2 others: Re-think puppet management for deployment-prep - https://phabricator.wikimedia.org/T161675 (10bd808) >>! In T161675#6930741, @dpifke wrote: >>>! In T161675#693... [23:37:31] (03PS1) 10Umherirrender: Test missing scope branch in SpaceBeforeClassBraceSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673613 [23:39:49] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team (Other / Uncategorized), 10Release-Engineering-Team-TODO, 10Cloud-Services, and 2 others: Re-think puppet management for deployment-prep - https://phabricator.wikimedia.org/T161675 (10Legoktm) >>! In T161675#6930652, @dpifke wrote: > Intermediate pr... [23:40:28] (03PS1) 10Umherirrender: Test empty comment branch in SpaceBeforeSingleLineCommentSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673615 [23:51:24] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team (Other / Uncategorized), 10Release-Engineering-Team-TODO, 10Cloud-Services, and 2 others: Re-think puppet management for deployment-prep - https://phabricator.wikimedia.org/T161675 (10bd808) >>! In T161675#6930761, @Legoktm wrote: >>>! In T161675#69... [23:54:02] 10Beta-Cluster-Infrastructure, 10SRE-swift-storage: Swift uses http in deployment-prep, https in production - https://phabricator.wikimedia.org/T277990 (10dpifke)