[00:05:11] (03PS1) 10Umherirrender: Fix error message for short array case in SpaceyParenthesisSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673626 [00:05:50] (03PS2) 10Umherirrender: Fix error message for long array case in SpaceyParenthesisSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673626 [00:14:11] (03PS1) 10Umherirrender: Add newline test to WhiteSpaceBeforeFunction [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673627 [00:21:20] (03PS1) 10Umherirrender: Test non-parenthesis branch in DirUsageSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673628 [00:26:07] (03PS3) 10Umherirrender: Test non-parenthesis branch in OpeningKeywordParenthesisSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673611 [00:26:56] 10Beta-Cluster-Infrastructure, 10SRE-swift-storage: Swift uses http in deployment-prep, https in production - https://phabricator.wikimedia.org/T277990 (10dpifke) In https://gerrit.wikimedia.org/r/plugins/gitiles/operations/puppet/+/refs/heads/production/hieradata/common/profile/swift.yaml, we have a mix of ht... [00:31:59] 10Beta-Cluster-Infrastructure, 10Puppet: Unduplicate beta cluster hiera keys set both in Horizon and in ops/puppet - https://phabricator.wikimedia.org/T277680 (10dpifke) It appears much of the hiera divergence between deployment-prep and production can be attributed to T254917. [00:33:30] (03PS1) 10Umherirrender: Combine two early returns in FinalPrivateSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673629 [00:50:15] (03PS1) 10Umherirrender: Test non-parenthesis branch in ForbiddenFunctionsSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673633 [00:54:37] (03PS1) 10Umherirrender: Test nested but not in_array branch in InArrayUsageSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673635 [01:05:00] (03PS8) 10DannyS712: FunctionAnnotationsSniff: recognize more phpunit annotations [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/670120 (https://phabricator.wikimedia.org/T276971) [01:05:14] (03CR) 10DannyS712: FunctionAnnotationsSniff: recognize more phpunit annotations (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/670120 (https://phabricator.wikimedia.org/T276971) (owner: 10DannyS712) [01:20:34] (03CR) 10Umherirrender: FunctionAnnotationsSniff: recognize more phpunit annotations (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/670120 (https://phabricator.wikimedia.org/T276971) (owner: 10DannyS712) [01:20:54] (03PS1) 10Umherirrender: Test global function is_null in IsNullSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673639 [01:41:47] (03PS1) 10Umherirrender: Add newline test to IfElseStructureSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673640 [02:04:38] (03PS1) 10Umherirrender: Remove reference to T_RETURN_TYPE [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673643 [02:18:22] (03PS1) 10Umherirrender: Test doc comment does not belongs to function in PhpunitAnnotationsSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673644 [02:37:30] (03PS1) 10Umherirrender: Test RedundantVarNameSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673647 [02:51:04] (03PS1) 10Umherirrender: Test spacing around @var in PropertyDocumentationSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673649 [02:54:34] (03PS9) 10DannyS712: FunctionAnnotationsSniff: recognize more phpunit annotations [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/670120 (https://phabricator.wikimedia.org/T276971) [02:54:54] (03CR) 10DannyS712: FunctionAnnotationsSniff: recognize more phpunit annotations (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/670120 (https://phabricator.wikimedia.org/T276971) (owner: 10DannyS712) [02:56:41] (03PS1) 10Umherirrender: Test bad @phan-var in UnusedUseStatementSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673650 [03:06:41] (03PS1) 10Umherirrender: Test for param name in FunctionCommentSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673651 [03:28:44] (03PS1) 10Umherirrender: Remove unreachable code around doc comments [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673652 [03:59:06] (03PS1) 10Umherirrender: Test ClassLevelLicenseSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673656 [04:30:27] (03CR) 10Krinkle: [C: 03+2] Test nested but not in_array branch in InArrayUsageSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673635 (owner: 10Umherirrender) [04:32:03] (03Merged) 10jenkins-bot: Test nested but not in_array branch in InArrayUsageSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673635 (owner: 10Umherirrender) [04:36:16] (03CR) 10Reedy: "Should we be updating the entries in the HISTORY too?" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673573 (https://phabricator.wikimedia.org/T277983) (owner: 10Reedy) [07:14:51] 10Beta-Cluster-Infrastructure, 10Puppet: Unduplicate beta cluster hiera keys set both in Horizon and in ops/puppet - https://phabricator.wikimedia.org/T277680 (10Majavah) >>! In T277680#6930841, @dpifke wrote: > It appears much of the hiera divergence between deployment-prep and production can be attributed to... [07:17:07] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team (Other / Uncategorized), 10Release-Engineering-Team-TODO, 10Cloud-Services, and 2 others: Re-think puppet management for deployment-prep - https://phabricator.wikimedia.org/T161675 (10Majavah) deployment-spec specific Hiera keys are also kept in the... [07:22:36] 10Beta-Cluster-Infrastructure, 10SRE-swift-storage: Swift uses http in deployment-prep, https in production - https://phabricator.wikimedia.org/T277990 (10Majavah) We don't have Envoy and we don't have [[ https://wikitech.wikimedia.org/wiki/Cergen | Cergen ]] which (as I understand it) is used to create the ce... [07:41:14] 10Beta-Cluster-Infrastructure, 10SRE, 10Technical-Debt, 10Tracking-Neverending: Minimize infrastructure differences between Beta Cluster and production - https://phabricator.wikimedia.org/T87220 (10Majavah) [07:41:16] 10Beta-Cluster-Infrastructure, 10SRE-swift-storage: Swift uses http in deployment-prep, https in production - https://phabricator.wikimedia.org/T277990 (10Majavah) [08:21:34] 10Project-Admins: Replace tracking T40638 by "Voice & Tone" - https://phabricator.wikimedia.org/T140077 (10Aklapper) [08:25:53] 10Project-Admins: Replace tracking T40638 by "Voice & Tone" - https://phabricator.wikimedia.org/T140077 (10Aklapper) a:03Aklapper * #voice_tone is being used in parallel to T40638 (see e.g. `T254646#6930650` for a recent example). SAeveral places to track same things are not helpful. * Edited description of ht... [10:14:14] (03CR) 10Umherirrender: [C: 03+2] FunctionAnnotationsSniff: recognize more phpunit annotations [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/670120 (https://phabricator.wikimedia.org/T276971) (owner: 10DannyS712) [10:14:58] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team (Other / Uncategorized), 10Release-Engineering-Team-TODO, 10Cloud-Services, and 2 others: Re-think puppet management for deployment-prep - https://phabricator.wikimedia.org/T161675 (10Majavah) >>! In T161675#6930689, @bd808 wrote: >>>! In T161675#69... [10:15:34] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-DannyS712: "UnrecognizedAnnotation" sniff conflicts with "PhpunitAnnotations" - https://phabricator.wikimedia.org/T276971 (10Umherirrender) 05Open→03Resolved a:03DannyS712 [10:15:49] (03Merged) 10jenkins-bot: FunctionAnnotationsSniff: recognize more phpunit annotations [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/670120 (https://phabricator.wikimedia.org/T276971) (owner: 10DannyS712) [10:21:08] (03PS2) 10Umherirrender: Test doc comment does not belongs to function in PhpunitAnnotationsSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673644 [10:26:26] (03CR) 10Umherirrender: [C: 03+1] "I am okay with changing the history" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673573 (https://phabricator.wikimedia.org/T277983) (owner: 10Reedy) [10:28:09] (03PS2) 10Umherirrender: internal: Remove unreachable code around doc comment tokens [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673652 [10:35:53] (03PS2) 10Umherirrender: Test for param name and duplicate @return in FunctionCommentSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673651 [10:40:45] 10Continuous-Integration-Config, 10MediaWiki-Codesniffer: Check coverage on open patches for mediawiki/codesniffer with phpunit-coverage-patch - https://phabricator.wikimedia.org/T278000 (10Umherirrender) [10:43:24] (03PS2) 10Umherirrender: Test spacing around @var in PropertyDocumentationSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673649 [10:44:26] (03PS2) 10Umherirrender: Remove reference to T_RETURN_TYPE [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673643 [10:48:01] (03PS2) 10Umherirrender: Test namespaced function is_null in IsNullSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673639 [10:51:40] (03PS2) 10Umherirrender: Test nested parenthesis in arguments in ForbiddenFunctionsSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673633 [10:52:29] (03PS2) 10Umherirrender: internal: Combine two early returns in FinalPrivateSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673629 [10:58:00] 10Beta-Cluster-Infrastructure, 10Platform Team Initiatives (API Gateway), 10Platform Team Workboards (Green): Implement API Gateway solution for deployment-prep - https://phabricator.wikimedia.org/T254917 (10Majavah) [10:59:14] 10Beta-Cluster-Infrastructure, 10Platform Team Initiatives (API Gateway), 10Platform Team Workboards (Green): Implement API Gateway solution for deployment-prep - https://phabricator.wikimedia.org/T254917 (10Majavah) deployment-prep does not currently have a kubernetes cluster (at least yet, T276650). [11:11:13] (03PS1) 10Umherirrender: Test non-parenthesis branch in AssertCountSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673682 [11:14:02] (03PS1) 10Umherirrender: Test non-parenthesis branch in AssertEqualsSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673684 [11:23:08] (03PS2) 10Umherirrender: Test non-parenthesis and complex value branch in AssertionOrderSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673684 [11:32:25] (03PS1) 10Umherirrender: Test non-parenthesis and complex value branch in SpecificAssertionsSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673686 [11:43:15] (03PS1) 10Umherirrender: Test non-parenthesis branch in DeprecatedPHPUnitMethodsSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673688 [11:54:24] (03PS3) 10Umherirrender: Test nested parenthesis in arguments in ForbiddenFunctionsSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673633 [11:54:51] 10Continuous-Integration-Config, 10MediaWiki-Codesniffer: Check coverage on open patches for mediawiki/codesniffer with phpunit-coverage-patch - https://phabricator.wikimedia.org/T278000 (10Daimona) I should note that currently, this wouldn't work because the project doesn't use `@covers` tags. Adding those sh... [12:13:19] 10Continuous-Integration-Config, 10MediaWiki-Codesniffer: Check coverage on open patches for mediawiki/codesniffer with phpunit-coverage-patch - https://phabricator.wikimedia.org/T278000 (10Umherirrender) There is coverage report: https://doc.wikimedia.org/cover/mediawiki-tools-codesniffer/index.html static @... [12:29:37] (03PS1) 10Umherirrender: Add test for ExtensionInfo util class [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673689 [12:38:07] (03PS1) 10Umherirrender: internal: Add @codeCoverageIgnore to untestable code [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673690 [12:39:41] (03CR) 10Umherirrender: "Together with many other patch sets[1] this should bring the coverage to 100% on https://doc.wikimedia.org/cover/mediawiki-tools-codesniff" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673690 (owner: 10Umherirrender) [13:10:58] (03PS1) 10Umherirrender: Remove DocComment.SpacingDocTag for no-spaces before @param [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673694 [13:13:17] 10Beta-Cluster-Infrastructure: Configure etcd/confd/conftool in beta/deployment-prep like production - https://phabricator.wikimedia.org/T278007 (10Majavah) [13:13:42] 10Beta-Cluster-Infrastructure: Configure etcd/confd/conftool in beta/deployment-prep like production - https://phabricator.wikimedia.org/T278007 (10Majavah) [13:13:44] 10Beta-Cluster-Infrastructure, 10Technical-Debt: Set up LVS in beta like prod - https://phabricator.wikimedia.org/T196662 (10Majavah) [13:13:47] 10Beta-Cluster-Infrastructure, 10SRE, 10Technical-Debt, 10Tracking-Neverending: Minimize infrastructure differences between Beta Cluster and production - https://phabricator.wikimedia.org/T87220 (10Majavah) [13:15:07] 10Beta-Cluster-Infrastructure: Beta cron jobs seem broken - https://phabricator.wikimedia.org/T277206 (10Majavah) Puppet likely has something that removes it when conftool isn't being used. I guess it could be hacked out, but I filed a task for the proper long-term solution, {T278007}. [13:58:17] (03CR) 10Umherirrender: SpecificAssertionsSniff: fix order of assertStringContainsString parameters (033 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/661247 (https://phabricator.wikimedia.org/T273624) (owner: 10DannyS712) [14:10:12] 10phan-taint-check-plugin, 10Voice & Tone: Address Voice and Tone issues in phan-taint-check-plugin - https://phabricator.wikimedia.org/T277984 (10Daimona) 05Open→03Resolved a:03Reedy [14:10:16] 10phan-taint-check-plugin, 10Voice & Tone: Address Voice and Tone issues in phan-taint-check-plugin - https://phabricator.wikimedia.org/T277984 (10Daimona) [14:28:59] (03CR) 10Umherirrender: "UnusedUseStatementSniff.php also looking into such types and stops after the first space and may be takes class wrong as unused" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/670832 (https://phabricator.wikimedia.org/T277176) (owner: 10Thiemo Kreuz (WMDE)) [14:36:21] 10Continuous-Integration-Config, 10Release-Engineering-Team-TODO: Enable PHP assertions in WMF CI - https://phabricator.wikimedia.org/T276940 (10Daimona) >>! In T276940#6929923, @Legoktm wrote: > Can you inject it in the phan-taint-check repo by running `php -dzend.assertions=1 [command]` like how we enable xd... [14:41:31] (03CR) 10Umherirrender: Include class names in UnusedUse messages (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/666893 (owner: 10Lucas Werkmeister (WMDE)) [15:17:25] (03CR) 10Reedy: "> Patch Set 2: Code-Review+1" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673573 (https://phabricator.wikimedia.org/T277983) (owner: 10Reedy) [15:22:03] 10MediaWiki-Codesniffer, 10MediaWiki-Core-Testing, 10Patch-For-Review: Stop using MockBuilder::setMethods - https://phabricator.wikimedia.org/T278010 (10Daimona) If the patch above has a good success ratio, the same fix should be applied by PHPCS, which should also prevent the addition of new setMethods(). [15:34:30] 10MediaWiki-Codesniffer, 10MediaWiki-Core-Testing, 10Patch-For-Review: Stop using MockBuilder::setMethods - https://phabricator.wikimedia.org/T278010 (10Daimona) >>! In T278010#6931476, @Daimona wrote: > If the patch above has a good success ratio, the same fix should be applied by PHPCS, which should also p... [15:53:44] 10Release-Engineering-Team (Unit & Int & System Tooling), 10Pywikibot, 10Patch-For-Review, 10Pywikibot-tests: Lint test to match function signature and documentation - https://phabricator.wikimedia.org/T277396 (10Xqt) I proposed to support epytext with darglint: https://github.com/terrencepreilly/darglint/... [16:02:58] (03CR) 10DannyS712: [C: 03+2] internal: Combine two early returns in FinalPrivateSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673629 (owner: 10Umherirrender) [16:04:23] (03CR) 10DannyS712: [C: 03+2] Test RedundantVarNameSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673647 (owner: 10Umherirrender) [16:04:30] (03Merged) 10jenkins-bot: internal: Combine two early returns in FinalPrivateSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673629 (owner: 10Umherirrender) [16:04:54] (03CR) 10DannyS712: [C: 03+2] Test bad @phan-var in UnusedUseStatementSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673650 (owner: 10Umherirrender) [16:05:18] (03CR) 10DannyS712: [C: 03+1] Test for param name and duplicate @return in FunctionCommentSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673651 (owner: 10Umherirrender) [16:05:55] (03Merged) 10jenkins-bot: Test RedundantVarNameSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673647 (owner: 10Umherirrender) [16:06:21] (03Merged) 10jenkins-bot: Test bad @phan-var in UnusedUseStatementSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673650 (owner: 10Umherirrender) [16:06:25] (03CR) 10DannyS712: [C: 03+2] Test ClassLevelLicenseSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673656 (owner: 10Umherirrender) [16:07:45] (03CR) 10DannyS712: [C: 03+1] Test non-parenthesis branch in OpeningKeywordParenthesisSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673611 (owner: 10Umherirrender) [16:08:10] (03Merged) 10jenkins-bot: Test ClassLevelLicenseSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673656 (owner: 10Umherirrender) [16:08:33] (03CR) 10DannyS712: [C: 03+1] "History is generally only generated for the changes since the last release, so it shouldn't be reverted - suggest updating history too" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673573 (https://phabricator.wikimedia.org/T277983) (owner: 10Reedy) [16:09:29] (03CR) 10DannyS712: [C: 03+1] Add test for ExtensionInfo util class [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673689 (owner: 10Umherirrender) [16:09:54] (03CR) 10DannyS712: [C: 03+1] Remove reference to T_RETURN_TYPE [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673643 (owner: 10Umherirrender) [16:10:25] (03CR) 10DannyS712: [C: 03+2] Test spacing around @var in PropertyDocumentationSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673649 (owner: 10Umherirrender) [16:10:55] (03CR) 10DannyS712: [C: 03+1] internal: Remove unreachable code around doc comment tokens [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673652 (owner: 10Umherirrender) [16:11:23] (03CR) 10DannyS712: [C: 03+2] Test doc comment does not belongs to function in PhpunitAnnotationsSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673644 (owner: 10Umherirrender) [16:11:53] (03Merged) 10jenkins-bot: Test spacing around @var in PropertyDocumentationSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673649 (owner: 10Umherirrender) [16:13:21] (03Merged) 10jenkins-bot: Test doc comment does not belongs to function in PhpunitAnnotationsSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673644 (owner: 10Umherirrender) [16:13:45] (03CR) 10DannyS712: [C: 03+1] Test nested parenthesis in arguments in ForbiddenFunctionsSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673633 (owner: 10Umherirrender) [16:21:05] 10Beta-Cluster-Infrastructure, 10Kubernetes: Re-consider setting up a Kubernetes cluster on the Beta cluster - https://phabricator.wikimedia.org/T276650 (10Majavah) [16:25:27] (03CR) 10DannyS712: [C: 04-1] Test non-parenthesis branch in AssertCountSniff (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673682 (owner: 10Umherirrender) [16:25:55] (03CR) 10DannyS712: [C: 03+1] Remove DocComment.SpacingDocTag for no-spaces before @param [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673694 (owner: 10Umherirrender) [16:26:16] (03CR) 10DannyS712: [C: 03+1] Test namespaced function is_null in IsNullSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673639 (owner: 10Umherirrender) [16:27:23] (03CR) 10DannyS712: [C: 03+1] internal: Add @codeCoverageIgnore to untestable code [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673690 (owner: 10Umherirrender) [16:49:44] 10Beta-Cluster-Infrastructure, 10cloud-services-team (Kanban): Delegate beta.wmcloud.org and svc.deployment-prep.eqiad1.wikimedia.cloud DNS zones to deployment-prep - https://phabricator.wikimedia.org/T276624 (10Majavah) [17:01:42] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] Remove special check from SpaceBeforeBracketSniff (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673612 (owner: 10Umherirrender) [17:02:11] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Test missing scope branch in SpaceBeforeClassBraceSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673613 (owner: 10Umherirrender) [17:02:29] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Test empty comment branch in SpaceBeforeSingleLineCommentSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673615 (owner: 10Umherirrender) [17:03:44] (03Merged) 10jenkins-bot: Test missing scope branch in SpaceBeforeClassBraceSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673613 (owner: 10Umherirrender) [17:04:01] (03Merged) 10jenkins-bot: Test empty comment branch in SpaceBeforeSingleLineCommentSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673615 (owner: 10Umherirrender) [17:04:39] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Test namespaced function is_null in IsNullSniff (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673639 (owner: 10Umherirrender) [17:05:24] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Test nested parenthesis in arguments in ForbiddenFunctionsSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673633 (owner: 10Umherirrender) [17:06:15] (03Merged) 10jenkins-bot: Test namespaced function is_null in IsNullSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673639 (owner: 10Umherirrender) [17:07:38] (03Merged) 10jenkins-bot: Test nested parenthesis in arguments in ForbiddenFunctionsSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673633 (owner: 10Umherirrender) [17:19:34] (03CR) 10Umherirrender: Remove special check from SpaceBeforeBracketSniff (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673612 (owner: 10Umherirrender) [17:22:52] (03PS2) 10Umherirrender: Test non-parenthesis branch in AssertCountSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673682 [17:23:02] (03CR) 10Umherirrender: Test non-parenthesis branch in AssertCountSniff (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673682 (owner: 10Umherirrender) [17:56:06] 10Deployments, 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10Wikimedia-Site-requests, 10I18n: Why is the LocalisationUpdate extension still enabled in WMF production? - https://phabricator.wikimedia.org/T278019 (10Reedy) [19:55:50] (03PS3) 10Reedy: Use neutral language [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673573 (https://phabricator.wikimedia.org/T277983) [20:39:39] (03CR) 10Jforrester: [C: 03+2] Use neutral language [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673573 (https://phabricator.wikimedia.org/T277983) (owner: 10Reedy) [20:41:19] (03Merged) 10jenkins-bot: Use neutral language [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673573 (https://phabricator.wikimedia.org/T277983) (owner: 10Reedy) [20:48:16] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10Voice & Tone: Address Voice and Tone issues in MediaWiki Codesniffer - https://phabricator.wikimedia.org/T277983 (10Reedy) 05Open→03Resolved a:03Reedy