[02:24:29] 10Project-Admins, 10User-Urbanecm: Create a #Daty Tag - https://phabricator.wikimedia.org/T277909 (10Ogoorcs) @Aklapper: Hi! Sorry if I reply only now, been a busy start of the week. Yes, we have already an issue tracker on gitlab we basically use as an... issue tracker. In short we thought it could be benefi... [02:32:09] 10Project-Admins, 10User-Urbanecm: Create a #Daty Tag - https://phabricator.wikimedia.org/T277909 (10Ogoorcs) tl;dr gnomers usually have a saying about the gnome part of the of the application and wikidatians usually have a saying about the wikidata part of the application we now miss the latter side and that... [03:03:20] 10MediaWiki-Codesniffer, 10Composer: Files don't comply with psr-4 autoloading standard - https://phabricator.wikimedia.org/T278282 (10Reedy) [03:04:52] 10MediaWiki-Codesniffer, 10Composer: Files don't comply with psr-4 autoloading standard - https://phabricator.wikimedia.org/T278282 (10Reedy) [03:05:49] 10MediaWiki-Codesniffer, 10Composer: Files don't comply with psr-4 autoloading standard - https://phabricator.wikimedia.org/T278282 (10Reedy) [03:16:26] 10MediaWiki-Codesniffer, 10Composer, 10Patch-For-Review: Files don't comply with psr-4 autoloading standard - https://phabricator.wikimedia.org/T278282 (10Reedy) I imagine this would benefit from being in 1.35 with composer 2 support landing there too... Is it worth backporting this to 34.x.x, making 34.0.1... [06:03:29] 10Release-Engineering-Team (Code Health), 10MediaWiki-extensions-FlaggedRevs, 10Code-Stewardship-Reviews, 10User-notice: Code stewardship review: FlaggedRevs - https://phabricator.wikimedia.org/T185664 (10Melberg) Hello. Following the message at Georgian wikipedia - ka.wiki - I assume that this ticket shou... [06:58:04] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Fix PSR-4 autoloading for composer 2.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/674379 (https://phabricator.wikimedia.org/T278282) (owner: 10Reedy) [06:59:23] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Release, 10Train Deployments: Flagged revs will break if the dimension is set to something other than "accuracy" - https://phabricator.wikimedia.org/T278285 (10Ladsgroup) p:05Triage→03Unbreak! [06:59:52] (03PS2) 10Thiemo Kreuz (WMDE): Fix UnusedUseStatement sniff for Java-style array [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/674308 (https://phabricator.wikimedia.org/T277176) [07:00:00] (03Merged) 10jenkins-bot: Fix PSR-4 autoloading for composer 2.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/674379 (https://phabricator.wikimedia.org/T278282) (owner: 10Reedy) [07:03:33] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10MediaWiki-extensions-FlaggedRevs, 10Release, 10Train Deployments: Flagged revs will break if the dimension is set to something other than "accuracy" - https://phabricator.wikimedia.org/T278285 (10RhinosF1) [07:12:53] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10MediaWiki-extensions-FlaggedRevs, 10Patch-For-Review, 10Release, 10Train Deployments: Flagged revs will break if the dimension is set to something other than "accuracy" - https://phabricator.wikimedia.org/T278285 (10Ladsgroup) I couldn't... [07:29:34] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10MediaWiki-extensions-FlaggedRevs, 10Patch-For-Review, 10Release, 10Train Deployments: Flagged revs will break if the dimension is set to something other than "accuracy" - https://phabricator.wikimedia.org/T278285 (10Ladsgroup) [07:29:36] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.36 deployment blockers - https://phabricator.wikimedia.org/T274940 (10Ladsgroup) [07:30:08] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10MediaWiki-extensions-FlaggedRevs, 10Patch-For-Review, 10Release, 10Train Deployments: Flagged revs will break if the dimension is set to something other than "accuracy" - https://phabricator.wikimedia.org/T278285 (10Ladsgroup) p:05Unbrea... [07:35:23] 10Phabricator: Custom generic and simplified task form - https://phabricator.wikimedia.org/T278287 (10valerio.bozzolan) [07:35:33] 10Release-Engineering-Team (Code Health), 10MediaWiki-extensions-FlaggedRevs, 10Code-Stewardship-Reviews, 10User-notice: Code stewardship review: FlaggedRevs - https://phabricator.wikimedia.org/T185664 (10Ladsgroup) Your wki won't be affected. [07:37:18] (03PS1) 10Thiemo Kreuz (WMDE): Make UnusedUseStatement sniff understand multiple namespaces [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/674515 (https://phabricator.wikimedia.org/T277708) [07:37:59] 10Beta-Cluster-Infrastructure, 10Cloud-VPS (Debian Jessie Deprecation), 10Patch-For-Review: Migrate from deployment-logstash2 (jessie) to deployment-logstash03 (stretch) - https://phabricator.wikimedia.org/T238707 (10MoritzMuehlenhoff) I've merged https://gerrit.wikimedia.org/r/674392 and shut down deploymen... [07:42:30] !log remove deployment-logstash2 hiera from horizon, instahce was shut off earlier by moritzm T238707 [07:42:34] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [07:42:34] T238707: Migrate from deployment-logstash2 (jessie) to deployment-logstash03 (stretch) - https://phabricator.wikimedia.org/T238707 [07:44:30] 10MediaWiki-Codesniffer, 10Patch-For-Review: Namespace confusion - https://phabricator.wikimedia.org/T277708 (10thiemowmde) a:03thiemowmde The reason for this behavior is because I wrote the UnusedUseStatement sniff with the assumption that there is only a single `namespace` instruction at the top of a .php... [07:59:54] (03PS2) 10Thiemo Kreuz (WMDE): Fix false positive for Java-style array types [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/670832 (https://phabricator.wikimedia.org/T277176) [08:34:19] 10Project-Admins, 10User-Urbanecm: Create a #Daty Tag - https://phabricator.wikimedia.org/T277909 (10Aklapper) @Ogoorcs: Thanks for the reply. Wikimedia Phabricator is an issue tracker. It is not a random place to 'collect feedback' - that's what talk pages or forums are meant for (ideally, people should not c... [08:45:46] 10Project-Admins, 10User-Urbanecm: Create a #Daty Tag - https://phabricator.wikimedia.org/T277909 (10Aklapper) I do understand that more visibility is wanted (and that's legitimate and a great intention, as that project looks valuable to me). I'd propose to create a dedicated Daty project page on a Wikimedia w... [08:47:11] 10Project-Admins, 10User-Urbanecm: Create a #Daty Tag - https://phabricator.wikimedia.org/T277909 (10Urbanecm) Sorry @Aklapper, apparently I should've looked more for an existing issue tracker :/. [08:48:06] 10Phabricator: Custom generic and simplified task form - https://phabricator.wikimedia.org/T278287 (10Aklapper) 05Open→03Stalled a:05mmodell→03None Hi, I'm not sure I understand what is requested here - https://phabricator.wikimedia.org/maniphest/task/edit/form/1/ exists. [08:48:53] 10Project-Admins, 10User-Urbanecm: Create a #Daty Tag - https://phabricator.wikimedia.org/T277909 (10valerio.bozzolan) IMVHO if someone is not a maintainer or a developer of #daty should not warry about spending time about maintaining #daty's issues. Couldn't someone just take the project off the watch to avo... [08:51:21] 10Project-Admins, 10User-Urbanecm: Create a #Daty Tag - https://phabricator.wikimedia.org/T277909 (10Aklapper) @Urbanecm: No problem at all - thanks for all the help dealing with tickets! :) @valerio.bozzolan: Could you elaborate what you mean by "taking off the watch"? [08:52:51] 10Phabricator: Custom generic and simplified task form - https://phabricator.wikimedia.org/T278287 (10Aklapper) Hmm, is this maybe about having a form which also hides the "Subscribers" and "Assigned To" fields? [08:53:18] 10Phabricator: Custom generic and simplified task form - https://phabricator.wikimedia.org/T278287 (10valerio.bozzolan) >>! In T278287#6940252, @Aklapper wrote: > Hmm, is this maybe about having a form which also hides the "Subscribers" and "Assigned To" fields? Bingo! [08:56:22] 10Project-Admins, 10User-Urbanecm: Create a #Daty Tag - https://phabricator.wikimedia.org/T277909 (10Urbanecm) >>! In T277909#6940250, @valerio.bozzolan wrote: > IMVHO if someone is not a maintainer or a developer of #daty should not warry about spending time about maintaining #daty's issues. I'd treat it it... [08:58:02] 10Phabricator: Have a task creation form which only shows Title, Description, Tags fields - https://phabricator.wikimedia.org/T278287 (10Aklapper) [08:58:10] 10Phabricator: Have a task creation form which only shows Title, Description, Tags fields - https://phabricator.wikimedia.org/T278287 (10Aklapper) 05Stalled→03Open [09:05:25] 10Project-Admins, 10User-Urbanecm: Create a #Daty Tag - https://phabricator.wikimedia.org/T277909 (10valerio.bozzolan) I mean that you are very kind to worry about @ogoorcs but we are not so nice to tell him "//don't waste time in Wikimedia Phabricator, just stay on GNOME and send everyone to GNOME because it'... [09:10:31] 10Project-Admins, 10User-Urbanecm: Create a #Daty Tag - https://phabricator.wikimedia.org/T277909 (10Urbanecm) >>! In T277909#6940288, @valerio.bozzolan wrote: > I mean that you are very kind to worry about @ogoorcs but we are not so nice to tell him something like "//don't waste time in Wikimedia Phabricator,... [09:37:21] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services): doc1001 permission problems for doc.wikimedia.org deploy - https://phabricator.wikimedia.org/T237707 (10hashar) The permission madness has been finally addressed by moving deployment of integration/docroot.git to use s... [09:41:23] 10Release-Engineering-Team, 10Quality-and-Test-Engineering-Team (QTE), 10Platform Team Initiatives (API Integration Tests), 10Testing-Roadblocks: Create and run a suite of end-to-end tests for the Wikimedia environment - https://phabricator.wikimedia.org/T248683 (10hashar) [10:11:00] 10Release-Engineering-Team (Development services), 10phabricator maintenance bot, 10GerritBot: GerritBot doesn't add #Patch-for-review to restored patches - https://phabricator.wikimedia.org/T277597 (10hashar) a:03hashar The implementation is the #Gerrit plugin `its-phabricator`. The doc is at https://gerr... [10:21:05] 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO, 10phabricator maintenance bot, 10GerritBot, 10Patch-For-Review: GerritBot doesn't add #Patch-for-review to restored patches - https://phabricator.wikimedia.org/T277597 (10hashar) [10:22:13] 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO, 10GerritBot: Patch author and owner swapped in gerritbot comments - https://phabricator.wikimedia.org/T224262 (10hashar) [10:43:31] 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO, 10GerritBot: Patch author and owner swapped in gerritbot comments - https://phabricator.wikimedia.org/T224262 (10hashar) See https://phabricator.wikimedia.org/source/operations-puppet/browse/production/modules/gerrit/template... [10:47:46] 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO, 10GerritBot, 10Patch-For-Review: Patch author and owner swapped in gerritbot comments - https://phabricator.wikimedia.org/T224262 (10hashar) a:03hashar [11:05:42] 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO, 10GerritBot, 10Patch-For-Review: gerritbot doesnt escape sequences from commitmsg - https://phabricator.wikimedia.org/T93331 (10hashar) [11:28:36] (03Abandoned) 10Ladsgroup: Install 6.14.8 [integration/npm] - 10https://gerrit.wikimedia.org/r/673179 (owner: 10Ladsgroup) [11:32:59] 10Release-Engineering-Team (Code Health), 10MediaWiki-extensions-FlaggedRevs, 10Code-Stewardship-Reviews, 10User-notice: Code stewardship review: FlaggedRevs - https://phabricator.wikimedia.org/T185664 (10Green_Giant) Ladsgroup, thank you for looking into this. Should we assume that English Wikinews will l... [11:37:03] 10Project-Admins, 10User-Urbanecm: Create a #Daty Tag - https://phabricator.wikimedia.org/T277909 (10Aklapper) >>! In T277909#6940288, @valerio.bozzolan wrote: > something like "//don't waste time in Wikimedia Phabricator, just stay on GNOME and send everyone to GNOME because it's better for Daty//". @valerio... [11:42:01] 10Release-Engineering-Team (Logspam), 10JavaScript, 10MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), 10MediaWiki-Interface (Tables), and 2 others: Some tables cannot be sorted (TypeError: $nextRows[i] is undefined in table sorting / Uncaught TypeError: Cannot read pro... - https://phabricator.wikimedia.org/T265503 [11:58:36] 10Project-Admins, 10User-Urbanecm: Create a #Daty Tag - https://phabricator.wikimedia.org/T277909 (10valerio.bozzolan) Anyway I'm happy that @Ogoorcs requested the creation of this Tag so, even if archived, it would be still useful as information point. Also thanks to its description editable by @Ogoorcs at hi... [12:03:44] 10Release-Engineering-Team-TODO, 10Phatality, 10Developer Productivity: Phatality: Keep error message and trace closer together - https://phabricator.wikimedia.org/T237682 (10mmodell) 05Open→03Resolved a:05mmodell→03Krinkle [12:13:58] 10Phabricator, 10SRE, 10Traffic: Phabricator should cache tasks for a few minutes for logged-out users - https://phabricator.wikimedia.org/T274228 (10mmodell) @epriestley: Thanks for the tips. I think we may have already enabled persistant connections, I will double check. As for caching, our phabricator s... [12:17:32] 10Phabricator, 10SRE, 10Traffic: Phabricator should cache tasks for a few minutes for logged-out users - https://phabricator.wikimedia.org/T274228 (10mmodell) Although I thought we were using `cluster.databases` to configure mysql connections, it appears that we are not. [12:23:14] 10Phabricator, 10SRE, 10Traffic: Phabricator should cache tasks for a few minutes for logged-out users - https://phabricator.wikimedia.org/T274228 (10jcrespo) >>! In T274228#6940987, @mmodell wrote: > Although I thought we were using `cluster.databases` to configure mysql connections, it appears that we are... [12:24:49] 10Phabricator, 10SRE, 10Traffic: Phabricator should cache tasks for a few minutes for logged-out users - https://phabricator.wikimedia.org/T274228 (10mmodell) @jcrespo: I think we can use cluster.databases in phabricator's config even with a single mysql server name/password. Do you know if the proxy suppor... [12:35:02] 10Phabricator, 10SRE, 10Traffic: Phabricator should cache tasks for a few minutes for logged-out users - https://phabricator.wikimedia.org/T274228 (10jcrespo) There is HTTP-reuse functionality: https://cbonte.github.io/haproxy-dconv/1.8/configuration.html#4.2-http-reuse but I don't think there is something l... [12:55:05] 10Project-Admins, 10User-Urbanecm: Create a #Daty Tag - https://phabricator.wikimedia.org/T277909 (10Ogoorcs) >Thanks for the reply. Wikimedia Phabricator is an issue tracker. It is not a random place to 'collect feedback' - that's what talk pages or forums are meant for (ideally, people should not come to you... [13:30:27] 10Project-Admins, 10User-Urbanecm: Create a #Daty Tag - https://phabricator.wikimedia.org/T277909 (10Aklapper) Thanks for the clarification! If I get it correctly: I'd be happy with a tag similar to #affects-kiwix-and-openzim (as the Kiwix and OpenZim projects do not track their issues here, but they asked for... [13:34:05] 10Phabricator, 10SRE, 10Traffic: Phabricator should cache tasks for a few minutes for logged-out users - https://phabricator.wikimedia.org/T274228 (10Aklapper) [13:34:26] 10Phabricator, 10SRE, 10Traffic: Phabricator should cache tasks for a few minutes for logged-out users - https://phabricator.wikimedia.org/T274228 (10Aklapper) [13:57:57] 10Phabricator, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO, 10Wikimedia-Phabricator-Extensions, 10Developer Productivity: Phab reports: Improve clarity between labels and values - https://phabricator.wikimedia.org/T276513 (10mmodell) {4fac3fde9539d76fb2bce7ac7875cf4... [14:00:11] 10Phabricator, 10SRE, 10Traffic: Phabricator should cache tasks for a few minutes for logged-out users - https://phabricator.wikimedia.org/T274228 (10mmodell) @jcrespo: sure, no argument from me. I was just curious if we could easily implement epriestley's advice (or whether we already had) [14:18:43] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10GitLab (Initialization), 10User-brennen: Remove Speed & Function blockers for GitLab work - https://phabricator.wikimedia.org/T274458 (10debt) [14:26:50] 10MediaWiki-Codesniffer, 10Patch-For-Review: Namespace confusion - https://phabricator.wikimedia.org/T277708 (10Reedy) >>! In T277708#6940174, @thiemowmde wrote: > But please let's avoid `namespace`s in the middle of a file, as shown in the example above. Code like this should be split into multiple files. Ye... [14:56:13] 10Release-Engineering-Team (Code Health), 10MediaWiki-extensions-FlaggedRevs, 10Code-Stewardship-Reviews, 10User-notice: Code stewardship review: FlaggedRevs - https://phabricator.wikimedia.org/T185664 (10Ladsgroup) English Wikinews seems to have "quality" tier (unlike kawiki), Compare https://en.wikinews.... [14:57:32] 10MediaWiki-Codesniffer, 10Composer: Files don't comply with psr-4 autoloading standard - https://phabricator.wikimedia.org/T278282 (10Reedy) Just the question of how we want to handle this for 1.35... [15:11:39] 10LibUp: On LibUp's status page, break out by Wikimedia production state and tarball inclusiveness as well as "canaries" - https://phabricator.wikimedia.org/T278340 (10Jdforrester-WMF) [15:15:11] 10Release-Engineering-Team (Code Health), 10MediaWiki-extensions-FlaggedRevs, 10Code-Stewardship-Reviews, 10User-notice: Code stewardship review: FlaggedRevs - https://phabricator.wikimedia.org/T185664 (10Zache) Hmm, If I understand this correctly the "sighted" (stable version) is enough for Google News an... [15:24:59] (03CR) 10DannyS712: [C: 03+1] Make UnusedUseStatement sniff understand multiple namespaces [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/674515 (https://phabricator.wikimedia.org/T277708) (owner: 10Thiemo Kreuz (WMDE)) [15:26:13] (03CR) 10DannyS712: Fix false positive for Java-style array types (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/670832 (https://phabricator.wikimedia.org/T277176) (owner: 10Thiemo Kreuz (WMDE)) [15:52:33] 10MediaWiki-Codesniffer, 10Composer: Files don't comply with psr-4 autoloading standard - https://phabricator.wikimedia.org/T278282 (10Legoktm) https://libraryupgrader2.wmcloud.org/library/composer/mediawiki/mediawiki-codesniffer?branch=REL1_35 is really a mess :| - most are on 31, but some, including core, ar... [15:55:33] 10MediaWiki-Codesniffer, 10User-DannyS712: UnsortedUseStatementsSniff doesn't complain about use statements in namespace {} - https://phabricator.wikimedia.org/T278348 (10DannyS712) [15:55:42] 10MediaWiki-Codesniffer, 10Composer: Files don't comply with psr-4 autoloading standard - https://phabricator.wikimedia.org/T278282 (10Reedy) I'm guessing due to weight and no other upgrades being necessary to those repos to bring in this bump? [15:56:52] 10MediaWiki-Codesniffer, 10User-DannyS712: UnsortedUseStatementsSniff doesn't complain about use statements in namespace {} - https://phabricator.wikimedia.org/T278348 (10DannyS712) [15:56:55] 10MediaWiki-Codesniffer, 10User-DannyS712: UnsortedUseStatementsSniff doesn't complain about use statements in namespace {} - https://phabricator.wikimedia.org/T278348 (10DannyS712) This is because UnsortedUseStatementsSniff only checks use statements in the global scope ` lang=php, name=UnsortedUseStatementsS... [16:05:19] 10MediaWiki-Codesniffer, 10User-DannyS712: UnsortedUseStatementsSniff doesn't complain about use statements in namespace {} - https://phabricator.wikimedia.org/T278348 (10thiemowmde) Can we please stop people writing code like this? I'm dead serious. The reason for the line of code you found is not because of... [16:22:05] 10Project-Admins, 10User-Urbanecm: Create a #Daty Tag - https://phabricator.wikimedia.org/T277909 (10Ogoorcs) exactly! [16:28:59] 10MediaWiki-Codesniffer, 10User-DannyS712: UnsortedUseStatementsSniff doesn't complain about use statements in namespace {} - https://phabricator.wikimedia.org/T278348 (10DannyS712) >>! In T278348#6942036, @thiemowmde wrote: > Can we please stop people writing code like this? I'm dead serious. > > The reason... [16:30:14] 10Phabricator, 10SRE, 10Traffic: Phabricator should cache tasks for a few minutes for logged-out users - https://phabricator.wikimedia.org/T274228 (10epriestley) It's perfectly fine to configure `cluster.databases` with one service, and Phabricator internally (in effect) builds a one-service `cluster.databas... [16:39:16] 10MediaWiki-Codesniffer, 10User-DannyS712: UnsortedUseStatementsSniff doesn't complain about use statements in namespace {} - https://phabricator.wikimedia.org/T278348 (10thiemowmde) I wrote the sniff. I'm talking about these nested `namespace`s and `use` statements. We are all here – in the CodeSniffer projec... [16:40:29] 10MediaWiki-Codesniffer, 10User-DannyS712: UnsortedUseStatementsSniff doesn't complain about use statements in namespace {} - https://phabricator.wikimedia.org/T278348 (10DannyS712) >>! In T278348#6942186, @thiemowmde wrote: > I wrote the sniff. I'm talking about these nested `namespace`s and `use` statements.... [16:46:56] (03PS3) 10Thiemo Kreuz (WMDE): Fix false positive for Java-style array types [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/670832 (https://phabricator.wikimedia.org/T277176) [16:48:32] (03CR) 10Thiemo Kreuz (WMDE): Fix false positive for Java-style array types (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/670832 (https://phabricator.wikimedia.org/T277176) (owner: 10Thiemo Kreuz (WMDE)) [16:57:02] (03PS3) 10Thiemo Kreuz (WMDE): Fix UnusedUseStatement sniff for Java-style array [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/674308 (https://phabricator.wikimedia.org/T277176) [17:21:21] 10Phabricator (Upstream), 10Upstream: Herald rule to suppress Task activity? (and just receive Task creation) - https://phabricator.wikimedia.org/T277132 (10Aklapper) That would be an option. :) [17:23:00] 10Project-Admins: Create project tag for Slow-DB-Query - https://phabricator.wikimedia.org/T277124 (10Aklapper) Could someone outline project descriptions for each of these tags that ideally allow folks to avoid miscategorization, please? TIA [17:26:39] 10MediaWiki-Codesniffer, 10Composer: MediaWiki-Codesniffer test files not complying with PSR-4 - https://phabricator.wikimedia.org/T251913 (10Umherirrender) [17:26:42] 10MediaWiki-Codesniffer, 10Composer: Files don't comply with psr-4 autoloading standard - https://phabricator.wikimedia.org/T278282 (10Umherirrender) [17:34:59] (03CR) 10Umherirrender: "It is possible to use <> also inside <>, with an unknown recursion depth" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/670832 (https://phabricator.wikimedia.org/T277176) (owner: 10Thiemo Kreuz (WMDE)) [17:36:41] (03CR) 10Umherirrender: "It is possible to use <> also inside <>, with an unknown recursion depth" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/674308 (https://phabricator.wikimedia.org/T277176) (owner: 10Thiemo Kreuz (WMDE)) [17:38:41] (03CR) 10Umherirrender: "There is one job running the new sniffs against mediawiki/core master, which is no reporting unused use for the nested <> problem: https:/" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/674308 (https://phabricator.wikimedia.org/T277176) (owner: 10Thiemo Kreuz (WMDE)) [17:41:12] (03CR) 10Umherirrender: Make UnusedUseStatement sniff understand multiple namespaces (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/674515 (https://phabricator.wikimedia.org/T277708) (owner: 10Thiemo Kreuz (WMDE)) [17:43:03] (03CR) 10Umherirrender: [C: 03+2] "Okay, I am okay with your changes, you are okay with my changes, let's merge" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/661247 (https://phabricator.wikimedia.org/T273624) (owner: 10DannyS712) [17:47:08] (03Merged) 10jenkins-bot: SpecificAssertionsSniff: fix order of assertStringContainsString parameters [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/661247 (https://phabricator.wikimedia.org/T273624) (owner: 10DannyS712) [17:48:53] 10Phabricator: Spaces request for Technical-Program-Management - https://phabricator.wikimedia.org/T277107 (10MBinder_WMF) @Aklapper Thanks again for helping with this. I would be grateful for your additional thoughts on https://phabricator.wikimedia.org/T277107#6928870. Among other things we're holding off on m... [17:49:06] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-DannyS712: Incorrect fix for MediaWiki.PHPUnit.SpecificAssertions - https://phabricator.wikimedia.org/T273624 (10Umherirrender) 05Open→03Resolved a:03DannyS712 [17:55:18] (03PS2) 10Thiemo Kreuz (WMDE): Make UnusedUseStatement sniff understand multiple namespaces [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/674515 (https://phabricator.wikimedia.org/T277708) [18:08:26] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10SRE, 10GitLab (Initialization), 10Patch-For-Review, 10User-brennen: SSH Access of Git data in GitLab - https://phabricator.wikimedia.org/T276148 (10Dzahn) gitlab100 has 2 IPs (2x v4, 2 x v6) now: ` @gitlab1001:~# ip a s | grep 208 i... [18:15:41] (03CR) 10Umherirrender: [C: 03+2] Make UnusedUseStatement sniff understand multiple namespaces [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/674515 (https://phabricator.wikimedia.org/T277708) (owner: 10Thiemo Kreuz (WMDE)) [18:16:06] 10MediaWiki-Codesniffer, 10User-DannyS712: UnsortedUseStatementsSniff doesn't complain about use statements in namespace {} - https://phabricator.wikimedia.org/T278348 (10Aklapper) @thiemowmde: I'd think people take you (and/or your arguments) seriously, without explicitly having to mention that. [18:17:49] 10MediaWiki-Codesniffer, 10Patch-For-Review: Namespace confusion in UnusedUseStatementSniff - https://phabricator.wikimedia.org/T277708 (10Umherirrender) 05Open→03Resolved [18:18:21] (03Merged) 10jenkins-bot: Make UnusedUseStatement sniff understand multiple namespaces [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/674515 (https://phabricator.wikimedia.org/T277708) (owner: 10Thiemo Kreuz (WMDE)) [18:18:45] (03PS3) 10Umherirrender: Remove reference to T_RETURN_TYPE [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673643 [18:20:55] (03Abandoned) 10Umherirrender: Preserve tabs when autofix in DocCommentSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/668170 (owner: 10Umherirrender) [18:31:19] 10MediaWiki-Codesniffer, 10Upstream: Enable Squiz.ControlStructures.ForLoopDeclaration/ForEachLoopDeclaration sniff - https://phabricator.wikimedia.org/T214332 (10Umherirrender) 05Stalled→03Declined Just keep this code fragments around loops as is [18:31:22] 10MediaWiki-Codesniffer, 10Upstream: Enable Squiz.ControlStructures.ForLoopDeclaration/ForEachLoopDeclaration sniff - https://phabricator.wikimedia.org/T214332 (10Umherirrender) a:05Umherirrender→03None [18:38:08] (03PS4) 10Thiemo Kreuz (WMDE): Fix false positive for Java-style array types [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/670832 (https://phabricator.wikimedia.org/T277176) [19:08:45] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.36 deployment blockers - https://phabricator.wikimedia.org/T274940 (10hashar) I have synchronized php: group1 wikis to 1.36.0-wmf.36 [19:21:46] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.36 deployment blockers - https://phabricator.wikimedia.org/T274940 (10hashar) [19:25:52] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.36 deployment blockers - https://phabricator.wikimedia.org/T274940 (10hashar) [19:29:27] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.36 deployment blockers - https://phabricator.wikimedia.org/T274940 (10hashar) [19:35:37] (03PS1) 10Dduvall: Support default values in variable expressions [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/674689 [19:36:22] (03CR) 10jerkins-bot: [V: 04-1] Support default values in variable expressions [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/674689 (owner: 10Dduvall) [19:47:43] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.36 deployment blockers - https://phabricator.wikimedia.org/T274940 (10hashar) A minute on group 1 wikis and we got three issues: * {T278375} * {T278376} * {T278379} I have sent... [20:24:50] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.36 deployment blockers - https://phabricator.wikimedia.org/T274940 (10Pchelolo) [20:48:42] 10Release-Engineering-Team-TODO, 10DNS, 10SRE, 10Traffic, and 3 others: DNS for GitLab - https://phabricator.wikimedia.org/T276170 (10Dzahn) [20:48:46] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10GitLab (Initialization), 10User-brennen: Remove Speed & Function blockers for GitLab work - https://phabricator.wikimedia.org/T274458 (10Dzahn) [20:49:22] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10SRE, 10Traffic, 10GitLab (Initialization), and 2 others: open firewall ports on gitlab1001.wikimedia.org (was: Port map of how Gitlab is accessed) - https://phabricator.wikimedia.org/T276144 (10Dzahn) 05Stalled→03Resolved There are now... [20:55:00] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10GitLab (Initialization), 10User-brennen: Remove Speed & Function blockers for GitLab work - https://phabricator.wikimedia.org/T274458 (10Dzahn) This task is open and High prio but are there actually blockers for Speed & Function left? The onl... [21:16:23] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.36 deployment blockers - https://phabricator.wikimedia.org/T274940 (10hashar) [21:18:07] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.36 deployment blockers - https://phabricator.wikimedia.org/T274940 (10hashar) [21:19:19] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.36 deployment blockers - https://phabricator.wikimedia.org/T274940 (10hashar) T278375 got hotfixed T278376 has been determined as not being a blocker (deprecation warning) T2783... [21:26:38] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.36 deployment blockers - https://phabricator.wikimedia.org/T274940 (10hashar) @Catrope @Ladsgroup looks like your risky patches went well for group 1! No errors about FlaggedRev... [21:38:22] 10Phabricator (Upstream), 10Upstream: project.search API broken for all calls: "Undefined index: PHID-PROJ-277qef67dlcfi5e7rhzm" - https://phabricator.wikimedia.org/T266966 (10Pppery) 05Open→03Resolved a:03Pppery Seems to be working now [21:38:36] 10Phabricator (Upstream), 10Upstream: project.search API broken for all calls: "Undefined index: PHID-PROJ-277qef67dlcfi5e7rhzm" - https://phabricator.wikimedia.org/T266966 (10Pppery) a:05Pppery→03None [21:38:42] (03PS1) 10Cwhite: mount templates directory for logstash-filter-verifier [integration/config] - 10https://gerrit.wikimedia.org/r/674720 (https://phabricator.wikimedia.org/T234565) [21:43:36] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO: Setup reply emails for gerrit - https://phabricator.wikimedia.org/T158915 (10Dzahn) T276459 brings up the same question but now for gitlab. [22:05:01] (03PS2) 10Dduvall: Support default values in variable expressions [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/674689 [22:46:30] (03PS4) 10Thiemo Kreuz (WMDE): Fix UnusedUseStatement sniff for Java-style array [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/674308 (https://phabricator.wikimedia.org/T277176) [22:47:47] (03PS5) 10Thiemo Kreuz (WMDE): Fix false positive for Java-style array types [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/670832 (https://phabricator.wikimedia.org/T277176) [23:46:02] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.36 deployment blockers - https://phabricator.wikimedia.org/T274940 (10dancy)