[00:17:38] 10Phabricator, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO, 10Wikimedia-Phabricator-Extensions, 10Developer Productivity: Phab reports: Improve clarity between labels and values - https://phabricator.wikimedia.org/T276513 (10mmodell) 05Open→03Resolved This has n... [03:22:14] (03PS1) 10Legoktm: zuul: Update my email [integration/config] - 10https://gerrit.wikimedia.org/r/674749 [03:22:25] (03CR) 10Legoktm: [C: 03+2] zuul: Update my email [integration/config] - 10https://gerrit.wikimedia.org/r/674749 (owner: 10Legoktm) [03:23:38] (03Merged) 10jenkins-bot: zuul: Update my email [integration/config] - 10https://gerrit.wikimedia.org/r/674749 (owner: 10Legoktm) [03:24:19] !log reloaded zuul for https://gerrit.wikimedia.org/r/674749 [03:24:22] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [07:07:03] 10Phabricator (Upstream), 10Upstream: Herald rule to suppress Task activity? (and just receive Task creation) - https://phabricator.wikimedia.org/T277132 (10valerio.bozzolan) 05Open→03Declined >>! In T277132#6942393, @Aklapper wrote: > That would be an option. :) Indeed. I've unwatched some projects migra... [08:54:52] 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO, 10GerritBot, 10Patch-For-Review: Patch author and owner swapped in gerritbot comments - https://phabricator.wikimedia.org/T224262 (10hashar) 05Open→03Resolved https://gerrit.wikimedia.org/r/674810 is a dummy patch I hav... [08:58:05] 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO, 10phabricator maintenance bot, 10GerritBot, 10Patch-For-Review: GerritBot doesn't add #Patch-for-review to restored patches - https://phabricator.wikimedia.org/T277597 (10hashar) p:05Triage→03Low [10:51:43] 10Phabricator (Upstream), 10Upstream: Phabricator fonts look broken on systems with JoyPixels (formerly EmojiOne) installed - https://phabricator.wikimedia.org/T235339 (10Aklapper) 05Open→03Declined No plans to fix / work around in the Phabricator codebase, reflecting status. [11:33:02] 10Project-Admins, 10User-Urbanecm: Create an #affects-Daty tag for issues in other Wikimedia codebases which affect Daty tasks - https://phabricator.wikimedia.org/T277909 (10Aklapper) [11:33:19] 10Project-Admins, 10User-Urbanecm: Create an #affects-Daty tag for issues in other Wikimedia codebases which affect Daty tasks - https://phabricator.wikimedia.org/T277909 (10Aklapper) 05Open→03Resolved Thanks everyone! :) See https://phabricator.wikimedia.org/project/profile/5266/ [12:52:47] 10Continuous-Integration-Infrastructure, 10MediaWiki-Installer, 10Platform Engineering (Icebox), 10Regression: MediaWiki web installer does not show extension when their dependency is missing - https://phabricator.wikimedia.org/T220514 (10Mainframe98) [13:14:12] (03PS1) 10Lars Wirzenius: feat! rewrite apply-patches, drop list-patches and test-patches [tools/scap] - 10https://gerrit.wikimedia.org/r/674871 (https://phabricator.wikimedia.org/T269153) [13:16:25] (03CR) 10Lars Wirzenius: "The commit message should explain things. If not, tell me and I'll improve it." [tools/scap] - 10https://gerrit.wikimedia.org/r/674871 (https://phabricator.wikimedia.org/T269153) (owner: 10Lars Wirzenius) [13:36:11] 10Phabricator: Spaces request for Technical-Program-Management - https://phabricator.wikimedia.org/T277107 (10Aklapper) @mbinder_WMF: Sorry for the belated reply and thanks for the ping! * Looking at the HTML code of the Spaces dropdown, it seems https://phabricator.wikimedia.org/maniphest/task/edit/form/3/?spa... [13:49:27] 10Phabricator: Spaces request for Technical-Program-Management - https://phabricator.wikimedia.org/T277107 (10Majavah) >>! In T277107#6945287, @Aklapper wrote: > * If I interpret upstream [T10025](https://secure.phabricator.com/T10025) / [T10004](https://secure.phabricator.com/T10004) / [rPbb8cf8eca8c3306048a0d9... [13:54:06] 10Phabricator: Spaces request for Technical-Program-Management - https://phabricator.wikimedia.org/T277107 (10Aklapper) Ah, my eyes were searching for an explicit Space field but that makes total sense. Thanks, Majavah! [13:58:57] 10Phabricator (Upstream), 10Upstream: Unneeded line break between "MediaWiki User" and username - https://phabricator.wikimedia.org/T127448 (10Mainframe98) 05Open→03Invalid Cannot reproduce: smooshed browser window to 156px, but the field remained consistent with the other fields. [14:51:38] (03CR) 10Hashar: [C: 03+2] "INFO:jenkins_jobs.builder:Reconfiguring jenkins job operations-puppet-logstash-filter-verifier" [integration/config] - 10https://gerrit.wikimedia.org/r/674720 (https://phabricator.wikimedia.org/T234565) (owner: 10Cwhite) [14:53:29] (03Merged) 10jenkins-bot: mount templates directory for logstash-filter-verifier [integration/config] - 10https://gerrit.wikimedia.org/r/674720 (https://phabricator.wikimedia.org/T234565) (owner: 10Cwhite) [15:11:31] Thank you, hashar! [15:12:00] I just verified it all works :) [15:57:06] shdubsh: amazing! :] [15:57:26] shdubsh: and I have created https://grafana.wikimedia.org/d/L0-l1o0Mz/apache :] [15:57:51] I guess we will want apache error logs to be ingested as well [15:57:57] err wrong link [15:58:27] https://logstash.wikimedia.org/app/dashboards#/view/825c5c80-8aef-11eb-8ab2-63c7f3b019fc is for the ECS Apache access logs [15:59:59] 10Phabricator: Spaces request for Technical-Program-Management - https://phabricator.wikimedia.org/T277107 (10MBinder_WMF) Thanks, both! I was also able to create this form: https://phabricator.wikimedia.org/maniphest/task/edit/form/94/ I noticed when populating some tasks that the board view for a task is pre... [16:00:55] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10SRE, 10serviceops, 10Patch-For-Review: replace doc1001.eqiad.wmnet with a buster VM and create the codfw equivalent - https://phabricator.wikimedia.org/T247653 (10LarsWirzenius) I've not managed to do anything... [16:03:00] 10Release-Engineering-Team (Logspam), 10Structured-Data-Backlog, 10Wikimedia-production-error: undefined is not a function when mounting in Special:MediaSearch - https://phabricator.wikimedia.org/T278448 (10Jdlrobson) [16:03:48] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10SRE, 10serviceops, 10Patch-For-Review: replace doc1001.eqiad.wmnet with a buster VM and create the codfw equivalent - https://phabricator.wikimedia.org/T247653 (10Dzahn) Please see details on T211974 where @Ha... [16:10:54] 10Release-Engineering-Team (Logspam), 10VisualEditor, 10Editing-team (Tracking), 10JavaScript, 10Wikimedia-production-error: Uncaught Error: Cannot add a child to text node in checkCanInsertNodeType - https://phabricator.wikimedia.org/T261785 (10Jdlrobson) [16:12:20] 10Release-Engineering-Team (Logspam), 10VisualEditor, 10Editing-team (Tracking), 10JavaScript, 10Wikimedia-production-error: Uncaught TypeError: Cannot read property 'node' of null (in importTable ) - https://phabricator.wikimedia.org/T262842 (10Jdlrobson) [16:21:39] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.36 deployment blockers - https://phabricator.wikimedia.org/T274940 (10hashar) [16:24:56] !log install openssl security update and restart trafficserver-tls on deployment-cache-* [16:25:00] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [16:28:23] 10Release-Engineering-Team (Logspam), 10MediaWiki-extensions-Graph, 10JavaScript, 10covid-19: Uncaught TypeError: Cannot read property 'marktype' of undefined in CanvasHandler.pick() / undefined - https://phabricator.wikimedia.org/T258170 (10Jdlrobson) [16:33:15] 10Phabricator: Spaces request for Technical-Program-Management - https://phabricator.wikimedia.org/T277107 (10Aklapper) Good point, hadn't thought about that when naming. :-/ It cannot be disabled; could be shortened though. Could you [rename S21](https://phabricator.wikimedia.org/spaces/edit/21/) to something l... [16:47:42] (03CR) 10Ahmon Dancy: feat! rewrite apply-patches, drop list-patches and test-patches (0310 comments) [tools/scap] - 10https://gerrit.wikimedia.org/r/674871 (https://phabricator.wikimedia.org/T269153) (owner: 10Lars Wirzenius) [16:52:36] (03PS1) 10Dduvall: Allow inline blubber configuration at the pipeline scope [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/674931 [16:57:21] (03CR) 10Dduvall: "Note this change is meant to be considered alongside Ic4a711a0fad2afc8dcb96e68758d31fd45b2dc12 since an inline pipeline-level blubberfile " [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/674931 (owner: 10Dduvall) [17:04:22] 10Phabricator: Spaces request for Technical-Program-Management - https://phabricator.wikimedia.org/T277107 (10MBinder_WMF) That worked great, thanks! I updated the S21 description to mitigate the confusion such a short name might cause. :) [17:14:17] 10Phabricator: Spaces request for Technical-Program-Management - https://phabricator.wikimedia.org/T277107 (10MBinder_WMF) I //think// we're sorted now. I will show the state of things to the group to see if there is any user experience use case I have missed, but otherwise we're sorted! Thanks so much for your... [18:38:47] 10MediaWiki-Codesniffer: codesniffer's RedundantVarNameSniff does not remove var name from @var on static class properties - https://phabricator.wikimedia.org/T278471 (10Umherirrender) [18:50:35] 10MediaWiki-Codesniffer, 10Doxygen: Investigate conflict between RedundantVarName and Doxygen due to how the variable name is wanted on @var - https://phabricator.wikimedia.org/T278474 (10Umherirrender) [18:52:43] 10MediaWiki-Codesniffer, 10Doxygen: Investigate conflict between RedundantVarName sniff and Doxygen due to how the variable name is wanted on @var - https://phabricator.wikimedia.org/T278474 (10Umherirrender) [19:00:24] 10Phabricator: Spaces request for Technical-Program-Management - https://phabricator.wikimedia.org/T277107 (10Aklapper) Uh, thank //you// for the patience and for faciliating this! Hope things will work well, and also happy to help/discuss more. :) [19:00:35] 10Phabricator: Spaces request for Technical-Program-Management - https://phabricator.wikimedia.org/T277107 (10Aklapper) 05Open→03Resolved [19:07:16] 10MediaWiki-Codesniffer, 10Doxygen: Investigate conflict between RedundantVarName sniff and Doxygen due to how the variable name is wanted on @var - https://phabricator.wikimedia.org/T278474 (10Krinkle) Doxygen requires the variable to be named, just like we do for `@param` in method docs. Our codesniffer sho... [19:07:37] 10MediaWiki-Codesniffer, 10MediaWiki-Documentation, 10Doxygen: Investigate conflict between RedundantVarName sniff and Doxygen due to how the variable name is wanted on @var - https://phabricator.wikimedia.org/T278474 (10Krinkle) [19:17:22] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.36 deployment blockers - https://phabricator.wikimedia.org/T274940 (10hashar) [19:27:45] 10MediaWiki-Releasing, 10phan: use phan to generate a list of extensions likely to be broken by new mediawiki release - https://phabricator.wikimedia.org/T186771 (10Mainframe98) [19:30:36] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.36 deployment blockers - https://phabricator.wikimedia.org/T274940 (10Krinkle) [19:48:26] marxarelli: I know I'm late to the party, but I guess https://gerrit.wikimedia.org/r/c/integration/pipelinelib/+/673070 is what we talked about vis-a-vis git tags? Is it enough now to just push a tag? [19:51:10] urandom: it should work so long as the project is setup to schedule the job upon zuul "publish" (the zuul pipeline that responds to git tag pushes [19:51:21] iirc, your project is already set up that way [19:51:36] that's awesome, thanks for doing that! [19:51:44] i should probably double check. which project is it? [19:51:47] no problem! [19:52:15] https://gerrit.wikimedia.org/r/admin/repos/mediawiki/services/kask [19:54:04] hmm, actually it doesn't seem to schedule anything for publish [19:54:05] https://gerrit.wikimedia.org/r/plugins/gitiles/integration/config/+/refs/heads/master/zuul/layout.yaml#7691 [19:54:54] did you want to trigger this https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/services/kask/+/refs/heads/master/.pipeline/config.yaml#18 upon a new tag push? [19:58:08] umm, yes? [19:58:36] I think this was created for us, or best-case, it was an act of cargo culting [19:59:07] looks like it, yeah [19:59:08] so I'm pretty ignorant about what's going on here [19:59:41] it's very confusing. there are a few different systems and they all use the same terminology (e.g. pipeline) [20:00:15] heh [20:00:27] naming things is hard [20:01:01] we should put in place a pipeline for establishing terminology [20:01:23] but in the case, our Zuul instance (middleware between Gerrit and Jenkins that listens for events and schedules jobs) is configured with a (zuul) pipeline called "publish" which listens for ref-update events to refs/tags/foo [20:01:24] haha [20:02:15] the actual job that gets triggered lives in jenkins and is managed with jjb. both the zuul config and jjb definitions live in integration/config [20:03:39] there are a number of jjb projects defined that have boilerplate code for ingesting .pipeline/config.yaml files from a given project and building out a jenkins pipeline (yet another "pipeline"). the plugin we wrote and maintain for doing this is called... pipelinelib [20:03:44] wee! [20:03:49] anyway, i'll write a patch :) [20:07:04] hmm. wikibugs isn't working [20:07:10] here's the patch https://gerrit.wikimedia.org/r/c/integration/config/+/674964 [20:08:08] urandom: oh and your .pipeline/config.yaml needs one small change [20:09:07] right now, you have `tags: [stable]`. if you want to keep `stable` and add a tag that matches the git tag, do `tags: [stable, '${setup.tag}']` [20:09:43] `setup.tag` is set with the bare git tag name during setup if the ref matches `refs/tags/*` [20:10:16] I see [20:10:28] if you want to nix the stable tag and just use the git tag name, you can either do it explicitly (`tags: ['${setup.tag}']`) or remove `tags` since that is the default value [20:10:34] we haven't used the `stable` tag, but maybe that's a convention? [20:11:01] doesn't seem like it could hurt to have something that always points to the latest [20:11:56] up to you really but yeah, kinda serves as a latest tag [20:12:20] i'll go ahead and merge/deploy the zuul config change [20:15:06] cool, https://gerrit.wikimedia.org/r/c/mediawiki/services/kask/+/674966/1/.pipeline/config.yaml fwiw [20:15:14] (keeping the `stable` tag) [20:20:44] !log reloading zuul to deploy https://gerrit.wikimedia.org/r/c/integration/config/+/674964 [20:20:47] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [20:22:14] urandom: awesome. your change looks good to me. once you merge it, you should be able to push a tag and have it build! [20:22:23] * marxarelli crosses fingers [20:22:49] that's awesome; maybe I'll burn a version number just to be sure :) [20:23:12] :) [20:33:14] marxarelli: how long would that take? [20:33:58] the job should schedule right away [20:34:22] it could always be queued, but it would at least show at https://integration.wikimedia.org/zuul [20:35:07] was it this job https://integration.wikimedia.org/ci/job/trigger-kask-pipeline-publish/8/ ? [20:36:09] yeah, it was [20:36:11] huh. `step: publish, config: ['name':'production', 'build':['variant':'production', 'context':'.'], 'publish':['image':['id':'${.imageID}', 'tags':['stable'], 'name':${setup.project}, 'tag':${setup.timestamp}-${.stage}]]]` doesn't look like it contains '${setup.tag}' [20:36:19] yeah, was just noticing the same [20:36:51] was the tag ref created at or after the newly merged patch? [20:37:10] after [20:37:29] that's odd [20:37:49] hrmm.... [20:38:01] let's see. it did `git fetch --no-tags --progress --depth=1 -- git://contint2001.wikimedia.org/mediawiki/services/kask refs/tags/v1.0.8` [20:38:21] oh [20:38:26] err... `--no-tags` [20:38:33] the tag points to master prior to the change [20:38:37] wait no. that's fine [20:38:42] ooooh [20:38:50] ok, phew. well, that's logical at least [20:39:37] trying again... [20:39:59] k. i think it'll work if you force push the tag to include a new commit btw [20:40:06] but a new tag would work too [20:41:01] the output looks better this time [20:41:17] `stage production completed. exported: ['stage':'production', 'imageID':'227b7e2eb722325eaef59f2f6e412ec0ad7946035a8385b87981315ce2a3e65a', 'imageName':'mediawiki-services-kask', 'imageFullName':'docker-registry.wikimedia.org/wikimedia/mediawiki-services-kask', 'imageTag':'2021-03-25-203946-production', 'imageTags':['2021-03-25-203946-production', 'stable', 'v1.0.9'], [20:41:17] 'publishedImage':'docker-registry.wikimedia.org/wikimedia/mediawiki-services-kask:2021-03-25-203946-production']` [20:41:39] `['2021-03-25-203946-production', 'stable', 'v1.0.9']` [20:41:46] nice! [20:42:00] and `docker tag 227b7e2eb722325eaef59f2f6e412ec0ad7946035a8385b87981315ce2a3e65a docker-registry.discovery.wmnet/wikimedia/mediawiki-services-kask:v1.0.9` [20:42:07] oh yeah, it works! \o/ [20:42:25] https://dockerregistry.toolforge.org/wikimedia/mediawiki-services-kask/tags/ [20:42:29] awesome! [20:42:55] yeah! thanks again, I'm glad to have this back [20:43:21] no problem. glad to restore the functionality and i think it'll be useful for others too [20:43:39] Now I don't have to update the docs: https://www.mediawiki.org/wiki/Kask#Releasing :) [20:44:05] same. we should probably add a user guide for gitops-y pipelinelib use :) [20:51:44] (03CR) 10Jforrester: [C: 03+2] Fix a few terminators in the CI allow list [integration/config] - 10https://gerrit.wikimedia.org/r/674967 (owner: 10Jforrester) [20:52:53] (03Merged) 10jenkins-bot: Fix a few terminators in the CI allow list [integration/config] - 10https://gerrit.wikimedia.org/r/674967 (owner: 10Jforrester) [21:41:40] (03CR) 10Thcipriani: [C: 03+2] check-new-error-tasks: single maniphest.search call, UX improvements (031 comment) [tools/release] - 10https://gerrit.wikimedia.org/r/673184 (owner: 10Brennen Bearnes) [21:43:11] (03Merged) 10jenkins-bot: check-new-error-tasks: single maniphest.search call, UX improvements [tools/release] - 10https://gerrit.wikimedia.org/r/673184 (owner: 10Brennen Bearnes) [22:05:44] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10MW-on-K8s: Jenkins job exists for building patched MediaWiki image - https://phabricator.wikimedia.org/T273676 (10dduvall) 05Open→03Resolved The existing `.pipeline/config.yaml` was extended to patch... [22:05:46] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10MW-on-K8s: Security patch workflow for MediaWiki on k8s - https://phabricator.wikimedia.org/T271274 (10dduvall) [22:06:06] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Release Pipeline: PipelineBuilder based jobs need to handle git tags and other ref updates - https://phabricator.wikimedia.org/T277346 (10dduvall) 05Open→03Resolved [22:07:26] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.36 deployment blockers - https://phabricator.wikimedia.org/T274940 (10Pchelolo) Blocker T277795 - should finally be solved by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/674836 [22:10:37] 10Release-Engineering-Team-TODO, 10Release Pipeline, 10Documentation: Write PipelineLib user guide for setting up a GitOps-y workflow - https://phabricator.wikimedia.org/T278492 (10dduvall) [22:11:11] (03CR) 10Jeena Huneidi: [C: 03+1] Support default values in variable expressions [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/674689 (owner: 10Dduvall) [22:11:40] 10Release-Engineering-Team, 10Release Pipeline, 10Documentation: Write PipelineLib user guide for setting up a GitOps-y workflow - https://phabricator.wikimedia.org/T278492 (10dduvall) [22:32:26] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10GitLab (Initialization), 10User-brennen: Remove Speed & Function blockers for GitLab work - https://phabricator.wikimedia.org/T274458 (10brennen) [22:32:44] 10Gerrit, 10GitLab (Initialization), 10User-brennen: Provide Speed & Function rough numbers for our current Gerrit web traffic - https://phabricator.wikimedia.org/T275564 (10brennen) 05Resolved→03Open Reopening this for a request from @Sergey.Trofimovsky.SF: > Gitlab's resource usage for checkouts/clone... [22:49:42] (03CR) 10Jeena Huneidi: Allow inline blubber configuration at the pipeline scope (031 comment) [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/674931 (owner: 10Dduvall) [23:00:24] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10SRE, 10serviceops, 10Patch-For-Review: replace doc1001.eqiad.wmnet with a buster VM and create the codfw equivalent - https://phabricator.wikimedia.org/T247653 (10Krinkle) >>! In T247653#6945787, @LarsWirzenius...