[01:43:26] 10Phabricator, 10TechCom-RFC: Either update or disable Phabricator Form 82 ("Create a TechCom RFC") - https://phabricator.wikimedia.org/T276655 (10LNguyen) [06:27:08] (03PS1) 10Octfx: Generate coverage reports for WikiSEO [integration/config] - 10https://gerrit.wikimedia.org/r/675004 [07:05:34] !log delete remaining shutdown deployment-prep jessies: deployment-sca[01-02], deplyoment-logstash2 (T218729) [07:05:38] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [07:05:39] T218729: Migrate deployment-prep away from Debian Jessie to Debian Stretch/Buster - https://phabricator.wikimedia.org/T218729 [07:08:20] 10Beta-Cluster-Infrastructure, 10Cloud-VPS (Debian Jessie Deprecation): Migrate deployment-prep away from Debian Jessie to Debian Stretch/Buster - https://phabricator.wikimedia.org/T218729 (10Majavah) 05Open→03Resolved [07:08:48] 10Beta-Cluster-Infrastructure, 10Cloud-VPS (Debian Jessie Deprecation): Migrate deployment-prep away from Debian Jessie to Debian Stretch/Buster - https://phabricator.wikimedia.org/T218729 (10Majavah) [07:09:20] 10Beta-Cluster-Infrastructure, 10Cloud-VPS (Debian Jessie Deprecation): Migrate from deployment-logstash2 (jessie) to deployment-logstash03 (stretch) - https://phabricator.wikimedia.org/T238707 (10Majavah) 05Open→03Resolved a:0330000lightyears [07:09:30] 10Beta-Cluster-Infrastructure, 10Cloud-VPS (Debian Jessie Deprecation): Migrate from deployment-logstash2 (jessie) to deployment-logstash03 (stretch) - https://phabricator.wikimedia.org/T238707 (10Majavah) a:0530000lightyears→03None [07:44:35] 10Beta-Cluster-Infrastructure: Beta cluster has reached its quota - https://phabricator.wikimedia.org/T257118 (10Peachey88) The project is now down to 67 / 100 instances, Should the task now be closed off. [07:48:24] 10Beta-Cluster-Infrastructure: Beta cluster has reached its quota - https://phabricator.wikimedia.org/T257118 (10Ladsgroup) Number of VCPUs is still at 84% but that's not that bad {F34191490} [08:10:59] 10Phabricator, 10TechCom-RFC: Either update or disable Phabricator Form 82 ("Create a TechCom RFC") - https://phabricator.wikimedia.org/T276655 (10Aklapper) @LNguyen: If #tech-decision-forum is not responsible for providing input how to clean up stuff of its predecessor, then could you provide info who is? Tha... [08:12:25] (03CR) 10Hashar: [C: 03+2] "Lets try! :)" [integration/config] - 10https://gerrit.wikimedia.org/r/675004 (owner: 10Octfx) [08:13:14] 10Phabricator (Upstream), 10Upstream: Phabricator auto-complete isn't finding our project - https://phabricator.wikimedia.org/T175755 (10Mainframe98) 05Open→03Invalid Cannot reproduce and all mentioned project are archived, making this moot. [08:14:27] (03Merged) 10jenkins-bot: Generate coverage reports for WikiSEO [integration/config] - 10https://gerrit.wikimedia.org/r/675004 (owner: 10Octfx) [08:16:34] !log reloading zuul for https://gerrit.wikimedia.org/r/c/integration/config/+/675004 [08:16:38] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [08:19:56] (03CR) 10Octfx: "> Patch Set 1: Code-Review+2" [integration/config] - 10https://gerrit.wikimedia.org/r/675004 (owner: 10Octfx) [08:24:44] 10Project-Admins: Create new tag #manuel-and-jaime-gsoc - https://phabricator.wikimedia.org/T278513 (10jcrespo) [08:53:18] (03CR) 10Thiemo Kreuz (WMDE): Fix false positive for Java-style array types (033 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/670832 (https://phabricator.wikimedia.org/T277176) (owner: 10Thiemo Kreuz (WMDE)) [08:57:02] (03CR) 10Thiemo Kreuz (WMDE): Fix UnusedUseStatement sniff for Java-style array (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/674308 (https://phabricator.wikimedia.org/T277176) (owner: 10Thiemo Kreuz (WMDE)) [09:05:25] 10MediaWiki-Codesniffer, 10MediaWiki-Documentation, 10Doxygen: Investigate conflict between RedundantVarName sniff and Doxygen due to how the variable name is wanted on @var - https://phabricator.wikimedia.org/T278474 (10thiemowmde) Can we please fix Doxygen instead? `@var int $foo` directly followed by `pri... [09:12:19] (03PS6) 10Thiemo Kreuz (WMDE): Fix false positive for Java-style array types [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/670832 (https://phabricator.wikimedia.org/T277176) [09:27:56] (03PS1) 10Thiemo Kreuz (WMDE): Move helper to DocumentationTypeTrait and reuse more often [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/675092 [09:28:12] 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO, 10phabricator maintenance bot, 10GerritBot: GerritBot doesn't add #Patch-for-review to restored patches - https://phabricator.wikimedia.org/T277597 (10hashar) [09:30:59] 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO, 10phabricator maintenance bot, 10GerritBot, 10Patch-For-Review: GerritBot doesn't add #Patch-for-review to restored patches - https://phabricator.wikimedia.org/T277597 (10hashar) 05Open→03Resolved The rule works, when... [09:41:57] (03PS1) 10Thiemo Kreuz (WMDE): Make UnusedUseStatement sniff accept Java-style in @phan-var [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/675098 (https://phabricator.wikimedia.org/T277176) [09:43:35] (03PS2) 10Thiemo Kreuz (WMDE): Make UnusedUseStatement sniff accept Java-style in @phan-var [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/675098 (https://phabricator.wikimedia.org/T277176) [10:03:47] 10Beta-Cluster-Infrastructure: Configure etcd/confd/conftool in beta/deployment-prep like production - https://phabricator.wikimedia.org/T278007 (10Majavah) [10:06:10] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10GitLab (Initialization), 10User-brennen: Remove Speed & Function blockers for GitLab work - https://phabricator.wikimedia.org/T274458 (10dcaro) [10:09:43] If anyone is awake and watching in here; what would folks think of having a dedicated instance in deployment-prep that would just be for testing mediawiki-core/config changes, an instance not in the pool so changing stuff on it couldn't break things for everyone? the idea would be... [10:10:33] to test changs before they get to master but after one has done whatever testing can be done on the laptop. and so it would not be in the mwinstall target list, every user testing would need to scap pull before doing anything over there, then put their changes to php-master and test (non-destructive) changes... [10:10:48] and possibly have phpunit set up over there too [10:11:36] I am happy to discuss this on a task or somewhere else that makes sense, if appropriate. plus give background on why it is even maybe a nice thing to have [10:12:11] another thing that might be nice is to have an analogue to the mwdebug hosts in production, having one in beta so tests could be done for things that are browser based [10:13:29] I'm not sure if I see the benefit over testing on your laptop or on patchdemo, so a task with more context would be very much appreciated [10:17:33] ok! I'll get that up today or monday [10:18:13] (tl;dr: setting up the combo of extensions that we have in prod, on one's laptop, is not easy, and behavior of a change can differ depending on config) [10:30:21] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.36 deployment blockers - https://phabricator.wikimedia.org/T274940 (10Ram202177) [10:37:36] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.36 deployment blockers - https://phabricator.wikimedia.org/T274940 (10Asartea) [10:46:01] 10Phabricator (Upstream), 10Upstream: Allow admins to delete specific messages from Conpherence - https://phabricator.wikimedia.org/T190276 (10Mainframe98) 05Open→03Declined Conpherence was disabled (T127640#5402230). [10:57:07] (03CR) 10Lars Wirzenius: "I'll add support for skins and vendor and submit a new patch set." (038 comments) [tools/scap] - 10https://gerrit.wikimedia.org/r/674871 (https://phabricator.wikimedia.org/T269153) (owner: 10Lars Wirzenius) [11:06:50] 10MediaWiki-Releasing: Review 1.33.1 tarball - https://phabricator.wikimedia.org/T227599 (10Mainframe98) 05Open→03Resolved MW 1.33 is EOL and has had several releases since 1.33.1, so I'm assuming this is resolved. [12:12:05] (03CR) 10Hashar: "That worked! You can find the coverage from:" [integration/config] - 10https://gerrit.wikimedia.org/r/675004 (owner: 10Octfx) [13:50:14] 10Release-Engineering-Team (CI & Testing services), 10Cloud-VPS, 10Patch-For-Review, 10cloud-services-team (Kanban): Support Cinder for CI docker workers - https://phabricator.wikimedia.org/T277078 (10Andrew) a:05Andrew→03None [14:46:37] o/ If I want to get a new secret deployed to be used MediaWiki extension, should I file a Phab task with a certain template/assignee? I haven't figured out the correct keywords to search for on wt for documentation. [15:17:45] phuedx: I saw your q earlier but don't have any great ideas. because that requires +2 in the private repo = sre-level access, maybe ask in the wikimedia-sre channel about it and see what they say? [15:20:03] *facepalm* I didn't think about -sre. Thanks, apergos [15:20:20] don't thank me until you get an answer ;-) good luck! happy friday [15:35:50] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Cloud-VPS, 10Patch-For-Review, 10cloud-services-team (Kanban): Support Cinder for CI docker workers - https://phabricator.wikimedia.org/T277078 (10thcipriani) [15:43:07] hashar: we have a fix (well, revert of the problematic patch) for a train blocker (T278429), and also a patch proposed for T278478. Do we want to try to backport & roll forward today, or wait for Monday to come? [15:43:10] T278429: Argument 1 passed to MediaWiki\Extension\Translate\PageTranslation\ParserOutput::sourcePageTextForRendering() must be an instance of Language, instance of StubUserLang given, called in /srv/mediawiki/php-1.36.0-wmf.36/extensions/Translate/tag/PageTranslationHooks.php on line 53 - https://phabricator.wikimedia.org/T278429 [15:43:10] T278478: FlaggedRevs: PHP Notice: Undefined index: status - https://phabricator.wikimedia.org/T278478 [16:13:56] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.36 deployment blockers - https://phabricator.wikimedia.org/T274940 (10hashar) [16:15:38] Urbanecm: sorry was busy elsewhere [16:15:50] np hashar [16:15:57] but still curious what will happen with train :) [16:15:58] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.36 deployment blockers - https://phabricator.wikimedia.org/T274940 (10hashar) I have added T278562 as a subtask since that is related to the roll out of 1.36.0-wmf.36. mediawiki/... [16:16:06] we don't deploy on friday [16:16:13] so we are stuck to the current state [16:16:23] but I guess we can do a backport to 1.36.0-wmf.36 today [16:16:32] in the interest of veryfing the future works on the testwikis [16:16:35] if that can help [16:16:45] or at least merge to master and check on beta [16:16:57] then deploy the backport today so it can be verified again on testwiki [16:17:23] i already verified the issue with translate pages, and I'm confident T278429 will not happen again [16:17:24] T278429: Argument 1 passed to MediaWiki\Extension\Translate\PageTranslation\ParserOutput::sourcePageTextForRendering() must be an instance of Language, instance of StubUserLang given, called in /srv/mediawiki/php-1.36.0-wmf.36/extensions/Translate/tag/PageTranslationHooks.php on line 53 - https://phabricator.wikimedia.org/T278429 [16:17:46] i can try to intentionally break the testwikis [16:20:03] oh and that is an issue in core nice [16:20:28] yeah [16:20:34] translate's a victim [16:20:43] thcipriani: we are fine deploying hotfix on wmf.36 given it is only on group 0 right? [16:20:58] it is in the interest of validating a hotfix (actually a revert in mediawiki/core) is working properly [16:21:05] which will help move things forward on monday [16:21:09] hashar: I'm fine with it if you're fine deploying [16:21:27] it must still be thursday somewhere on the planet ;] [16:21:32] :D [16:21:33] doing so [16:21:36] <3 [16:21:56] hashar: can you wait few minutes? i want to break testwiki to make sure i can actually test it there [16:22:05] of course! [16:22:14] I am +2 ing it to get CI to merge it [16:22:17] thanks [16:22:20] will sync up once you are done [16:22:39] and I guess if it is reproducible on testwiki we can even confirm it is fine by checking via mwdebug* [16:22:42] * thcipriani reads "break testwiki", quietly worries to himself [16:22:44] :D [16:22:56] :D [16:23:03] :D [16:27:29] Urbanecm: I caught up on the task, that is a nice investigation [16:27:42] fun to see we have some unique corner cases such as the main page being ... a special page! [16:27:53] it's not the first time hashar [16:27:59] (03CR) 10Thiemo Kreuz (WMDE): "Ammarpad, 3 people disagree with you. It sounds like your position is that these people are all wrong." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/665198 (owner: 10Umherirrender) [16:28:06] yeah I imagine [16:28:10] it is a bit challenging :/ [16:28:33] one day MediaWiki will have native multilanguage support without the need of a Special:MyLanguage ;) [16:29:23] we'll have integration tests for it sooner [16:30:13] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.36 deployment blockers - https://phabricator.wikimedia.org/T274940 (10Raymond) >>! In T274940#6949275, @hashar wrote: > I have added T278562 as a subtask since that is related to... [16:33:04] 10MediaWiki-Codesniffer: Codesniffer should warn if output functions like print are used - https://phabricator.wikimedia.org/T278564 (10Tpt) [16:33:44] I will deploy the other patch as well https://gerrit.wikimedia.org/r/c/mediawiki/core/+/674836 [16:34:03] cool [16:37:19] so far I'm unable to repro it on testwiki [16:37:32] :-\ [16:38:39] and now i have a different error than i expected, funny https://usercontent.irccloud-cdn.com/file/pB42bnww/image.png [16:45:42] hashar: let's make sure it does not break editing on a few tests and then test on monday [17:49:23] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.36 deployment blockers - https://phabricator.wikimedia.org/T274940 (10hashar) @Raymond yes that is what the task is about and you have fixed it :-] I have attached the task to th... [17:52:32] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.36 deployment blockers - https://phabricator.wikimedia.org/T274940 (10Ladsgroup) The fix for flagged revs is merged on master and cherry-picked on wmf.36, if you want to deploy it... [17:53:14] Krinkle: what can you tell me about integration-agent-qemu-1001.integration.eqiad1.wikimedia.cloud? I'm looking at it because it's the only user of role::ci::slave::labs::docker without role::ci::slave::labs::docker::docker_lvm_volume set; if that VM is obsolete then I can simplify some puppet code [17:53:22] if it's still used then I will leave things as they are [17:57:20] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Release, 10Train Deployments: 1.36.0-wmf.37 deployment blockers - https://phabricator.wikimedia.org/T278343 (10thcipriani) p:05Triage→03Medium a:03mmodell [18:00:39] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Cloud-VPS, 10Patch-For-Review, 10cloud-services-team (Kanban): Support Cinder for CI docker workers - https://phabricator.wikimedia.org/T277078 (10Andrew) Hashar requested on the task that I make a feature flag... [18:01:20] 10Release-Engineering-Team-TODO (Release-Engineering-Team-TODO (2021-04-01 to 2021-06-30 (Q4))), 10Release, 10Train Deployments: 1.36.0-wmf.38 deployment blockers - https://phabricator.wikimedia.org/T278344 (10thcipriani) [18:02:39] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.36 deployment blockers - https://phabricator.wikimedia.org/T274940 (10hashar) It is fine on Monday morning. It is 7pm here, it has been a busy week so I am going to take care of t... [18:04:25] 10Release-Engineering-Team-TODO (2021-04-01 to 2021-06-30 (Q4)), 10Release, 10Train Deployments: 1.36.0-wmf.38 deployment blockers - https://phabricator.wikimedia.org/T278344 (10thcipriani) [18:05:55] 10Release-Engineering-Team-TODO (2021-04-01 to 2021-06-30 (Q4)), 10Release, 10Train Deployments: 1.36.0-wmf.39 deployment blockers - https://phabricator.wikimedia.org/T278345 (10thcipriani) p:05Triage→03Medium a:03jeena [18:06:52] 10Release-Engineering-Team-TODO (2021-04-01 to 2021-06-30 (Q4)), 10Release, 10Train Deployments: 1.36.0-wmf.40 deployment blockers - https://phabricator.wikimedia.org/T278346 (10thcipriani) p:05Triage→03Medium a:03LarsWirzenius [18:08:02] 10Release-Engineering-Team-TODO (2021-04-01 to 2021-06-30 (Q4)), 10Release, 10Train Deployments: 1.36.0-wmf.41 deployment blockers - https://phabricator.wikimedia.org/T278347 (10thcipriani) p:05Triage→03Medium a:03brennen [18:08:25] (03PS1) 10SBassett: Remove wikimedia/fundraising/tools from php-security jobs [integration/config] - 10https://gerrit.wikimedia.org/r/675186 (https://phabricator.wikimedia.org/T271352) [18:23:39] andrewbogott: it is definitely not obsolete [18:23:48] Krinkle: ok! [18:24:04] andrewbogott: what would setting docker_lvm_volume change or gain us? [18:24:33] it is used by CI to run tests for software that itself spawns docker containers, such as fresh-node and mw-docker-cli [18:24:41] Krinkle: It puts docker things in a separate volume so that if docker runs amock it doesn't break other things on the host [18:25:01] basically it spawns a Qemu VM from a snapshot with debian and docker installed, and then runs git clone + make test; inside of it [18:25:12] *amok [18:25:35] Krinkle: probably we should just let it alone; I was just hoping to remove an unused config flag [18:26:25] ok, it might be fine to enable, I don't know. best to ask releng. fewer differences and special cases is probably better so worth taking a quick loook at with a taks perhaps? [18:26:29] task* [18:27:01] (03PS2) 10SBassett: Remove wikimedia/fundraising/tools from php-security jobs [integration/config] - 10https://gerrit.wikimedia.org/r/675186 (https://phabricator.wikimedia.org/T271352) [18:27:04] yep, it's on a task already [18:32:48] (03PS3) 10Jforrester: jjb: [fundraising-php-security] Drop wikimedia/fundraising/tools repo [integration/config] - 10https://gerrit.wikimedia.org/r/675186 (https://phabricator.wikimedia.org/T271352) (owner: 10SBassett) [18:34:18] (03CR) 10Jforrester: [C: 03+2] "Deployed." [integration/config] - 10https://gerrit.wikimedia.org/r/675186 (https://phabricator.wikimedia.org/T271352) (owner: 10SBassett) [18:35:25] (03Merged) 10jenkins-bot: jjb: [fundraising-php-security] Drop wikimedia/fundraising/tools repo [integration/config] - 10https://gerrit.wikimedia.org/r/675186 (https://phabricator.wikimedia.org/T271352) (owner: 10SBassett) [18:37:56] (03CR) 10SBassett: "Thanks, Jdforrester!" [integration/config] - 10https://gerrit.wikimedia.org/r/675186 (https://phabricator.wikimedia.org/T271352) (owner: 10SBassett) [18:38:11] 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO, 10GerritBot, 10Patch-For-Review: gerritbot doesnt escape sequences from commitmsg - https://phabricator.wikimedia.org/T93331 (10hashar) Looks like the `%%%` token has to be at the start of line. Seems like we can go with:... [18:53:32] (03PS2) 10Thcipriani: deployment calendar: Fully automated deployment calendar [tools/release] - 10https://gerrit.wikimedia.org/r/662778 [18:57:40] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.36 deployment blockers - https://phabricator.wikimedia.org/T274940 (10Urbanecm) >>! In T274940#6949300, @Raymond wrote: >>>! In T274940#6949275, @hashar wrote: >> I have added T27... [19:10:51] (03PS1) 10QChris: Allow “Gerrit Managers” to import history [debs/hyperkitty] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/675201 [19:10:54] (03CR) 10QChris: [V: 03+2 C: 03+2] Allow “Gerrit Managers” to import history [debs/hyperkitty] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/675201 (owner: 10QChris) [19:11:02] (03PS1) 10QChris: Import done. Revoke import grants [debs/hyperkitty] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/675202 [19:11:05] (03CR) 10QChris: [V: 03+2 C: 03+2] Import done. Revoke import grants [debs/hyperkitty] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/675202 (owner: 10QChris) [19:56:41] (03CR) 10Thcipriani: [C: 03+2] deployment calendar: Fully automated deployment calendar [tools/release] - 10https://gerrit.wikimedia.org/r/662778 (owner: 10Thcipriani) [19:58:10] (03Merged) 10jenkins-bot: deployment calendar: Fully automated deployment calendar [tools/release] - 10https://gerrit.wikimedia.org/r/662778 (owner: 10Thcipriani) [20:04:34] (03CR) 10Greg Grossmeier: "\o/" [tools/release] - 10https://gerrit.wikimedia.org/r/662778 (owner: 10Thcipriani) [20:15:10] (03CR) 10Umherirrender: [C: 03+2] Fix false positive for Java-style array types (033 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/670832 (https://phabricator.wikimedia.org/T277176) (owner: 10Thiemo Kreuz (WMDE)) [20:17:19] (03Merged) 10jenkins-bot: Fix false positive for Java-style array types [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/670832 (https://phabricator.wikimedia.org/T277176) (owner: 10Thiemo Kreuz (WMDE)) [20:19:43] (03PS2) 10Umherirrender: Move helper to DocumentationTypeTrait and reuse more often [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/675092 (owner: 10Thiemo Kreuz (WMDE)) [20:20:09] (03CR) 10Umherirrender: [C: 03+2] Move helper to DocumentationTypeTrait and reuse more often [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/675092 (owner: 10Thiemo Kreuz (WMDE)) [20:21:45] (03Merged) 10jenkins-bot: Move helper to DocumentationTypeTrait and reuse more often [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/675092 (owner: 10Thiemo Kreuz (WMDE)) [20:30:36] (03CR) 10Umherirrender: Fix UnusedUseStatement sniff for Java-style array (034 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/674308 (https://phabricator.wikimedia.org/T277176) (owner: 10Thiemo Kreuz (WMDE)) [20:32:36] (03CR) 10Umherirrender: [C: 03+1] Make UnusedUseStatement sniff accept Java-style in @phan-var (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/675098 (https://phabricator.wikimedia.org/T277176) (owner: 10Thiemo Kreuz (WMDE)) [20:54:12] thcipriani: reminds me of https://wikitech.wikimedia.org/wiki/User:Krinkle/Deployments_sandbox [20:54:49] if I recall correctly, that was complicated at the time as it wasn't easy to change in the script, but maybe that's different now? [20:55:38] if you end up changing deployment calendar wikitext, please let me know so that I can make sure train-blockers.toolforge.org does not break [20:56:26] Krinkle: actually...I did make a patch for the script to do that [20:56:42] and now I'm trying to remember what happened to it [20:58:08] (03PS1) 10Umherirrender: internal: Use param and return type hint on non-inherited functions [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/675220 [21:08:03] (03PS2) 10Umherirrender: internal: Use param and return type hint on non-inherited functions [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/675220 [21:08:07] Krinkle: it's still there (I just have to change 'old' -> 've' in the config) but it looks strange under timeless for some reason: https://wikitech.wikimedia.org/wiki/User:Thcipriani/Deployments [21:09:41] (03PS1) 10Thcipriani: Calendar: Remove ableist language [tools/release] - 10https://gerrit.wikimedia.org/r/675222 [21:09:43] (03PS1) 10Thcipriani: Calendar: add deployment training timeslots [tools/release] - 10https://gerrit.wikimedia.org/r/675223 [21:10:42] (03CR) 10Thcipriani: [C: 03+2] Calendar: Remove ableist language [tools/release] - 10https://gerrit.wikimedia.org/r/675222 (owner: 10Thcipriani) [21:10:54] (03PS1) 10Umherirrender: internal: Fix doc type for token argument in SpaceyParenthesisSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/675224 [21:11:36] (03Merged) 10jenkins-bot: Calendar: Remove ableist language [tools/release] - 10https://gerrit.wikimedia.org/r/675222 (owner: 10Thcipriani) [21:11:52] thcipriani: what am I looking for exactly? [21:11:55] https://wikitech.wikimedia.org/wiki/User:Thcipriani/Deployments?useskin=timeless [21:12:36] seems to shrink the boxes in my browser [21:12:41] * thcipriani screenshots [21:12:56] lemme see if this is some...plugin [21:13:10] no, just my browser [21:13:41] Timeless has some javascript code that shrinks each table into a scrollable box [21:13:56] I'm not sure why that exists or why it's done client-side [21:14:05] I'll see if I can mayble make that inert [21:15:37] sounds like you know what I'm seeing, but in case it's helpful https://phabricator.wikimedia.org/M318 [21:15:47] (plus I braved phab's mocks :)) [21:16:35] yeah, got it [21:16:58] I've got a workaround, will work it into the stylesheet now [21:18:12] (03PS3) 10Umherirrender: Test for param name and duplicate @return in FunctionCommentSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673651 [21:18:22] (03CR) 10Umherirrender: "Rebased" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673651 (owner: 10Umherirrender) [21:28:17] (03PS6) 10Umherirrender: Check for superfluous @return statements and missing void types [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/658070 [21:28:26] (03CR) 10Umherirrender: "Rebased" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/658070 (owner: 10Umherirrender) [21:31:25] thcipriani: fixed :) [21:45:58] (03PS2) 10Thcipriani: Calendar: add deployment training timeslots [tools/release] - 10https://gerrit.wikimedia.org/r/675223 [21:46:00] (03PS1) 10Thcipriani: Calendar: ve format is the default [tools/release] - 10https://gerrit.wikimedia.org/r/675229 [21:48:07] (03CR) 10Thcipriani: [C: 03+2] Calendar: ve format is the default [tools/release] - 10https://gerrit.wikimedia.org/r/675229 (owner: 10Thcipriani) [21:48:34] ^ Krinkle let's see what breaks :) https://wikitech.wikimedia.org/wiki/Deployments#Week_of_March_29 -- I'll send an email to wikitech [21:48:59] thank you for the update, looks great [21:49:12] hopefully will make the process of proposing a patch easier [21:49:13] (03Merged) 10jenkins-bot: Calendar: ve format is the default [tools/release] - 10https://gerrit.wikimedia.org/r/675229 (owner: 10Thcipriani) [21:49:18] <3 [21:51:44] train-blockers.toolforge.org will definitely break, I'll try to fix that during the weekend [21:52:35] (03PS3) 10Umherirrender: Fix spacing around exception type on @throws tag [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/661991 [21:53:18] (03CR) 10Umherirrender: "Rebased (this was not a simply merge resolving, rework code around splitTypeAndComment which was added to the trait by another patch set)" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/661991 (owner: 10Umherirrender) [21:56:28] thcipriani: looks like there's an odd bracket [21:56:29] ig training>]]
"EU Backport and Config training>" [21:57:21] * thcipriani looks [21:57:49] not sure where it came from [21:57:58] I typoed the name in the config [21:57:59] https://wikitech.wikimedia.org/w/index.php?title=Deployments&diff=prev&oldid=1905610 [21:58:01] of course [21:58:06] yeah, right before the ve switch [22:02:20] (03PS3) 10Thcipriani: Calendar: add deployment training timeslots [tools/release] - 10https://gerrit.wikimedia.org/r/675223 [22:02:32] 10MediaWiki-Codesniffer: Codesniffer should warn if output functions like print are used - https://phabricator.wikimedia.org/T278564 (10Umherirrender) Not sure if there are too many places where it needs to be print/printf Could search for var_export without a second argument as well. https://codesearch.wmclou... [22:06:39] (03CR) 10Ladsgroup: [C: 03+1] Calendar: add deployment training timeslots [tools/release] - 10https://gerrit.wikimedia.org/r/675223 (owner: 10Thcipriani) [22:08:34] Majavah: I should know better than to make changes on a Friday -- no one should have to scramble on a weekend -- I left next week in the old format and updated the following week to use the new format :) [22:08:50] https://wikitech.wikimedia.org/wiki/Deployments#Week_of_March_29 vs https://wikitech.wikimedia.org/wiki/Deployments#Week_of_April_05 [22:09:37] (also I use the train-blockers tool all the time) [22:11:50] (03CR) 10Brennen Bearnes: [C: 03+1] "LGTM - consider this a +2 unless there's quibbling to be done about timing or anything." [tools/release] - 10https://gerrit.wikimedia.org/r/675223 (owner: 10Thcipriani) [22:13:25] of course i +1'd that _before_ coming in here and reading scrollback [22:13:39] :D [22:15:43] i even checked the output in a preview of editing the page and went "huh, i guess this format changed while i wasn't paying attention". [22:19:20] (03PS1) 10Umherirrender: Use Generic.WhiteSpace.LanguageConstructSpacing sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/675230 [22:22:50] (03CR) 10jerkins-bot: [V: 04-1] Use Generic.WhiteSpace.LanguageConstructSpacing sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/675230 (owner: 10Umherirrender) [22:30:26] have a good friday everybody, what's left of it, and a good quiet weekend [22:31:19] you too :) [22:35:09] (03PS1) 10Umherirrender: internal: Add return type hint to Sniff::register implementation [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/675232 [22:41:23] (03PS2) 10Umherirrender: Use Generic.WhiteSpace.LanguageConstructSpacing sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/675230 [22:45:27] (03CR) 10jerkins-bot: [V: 04-1] Use Generic.WhiteSpace.LanguageConstructSpacing sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/675230 (owner: 10Umherirrender) [22:50:15] 10MediaWiki-Codesniffer, 10Epic: Replace deprecated @codingStandardsIgnore in repos using codesniffer - https://phabricator.wikimedia.org/T278594 (10Umherirrender) [22:52:48] (03PS3) 10Umherirrender: Use Generic.WhiteSpace.LanguageConstructSpacing sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/675230 [22:55:10] 10MediaWiki-Codesniffer, 10MediaWiki-General, 10MediaWiki-extensions-General, 10Epic: Replace deprecated @codingStandardsIgnore in repos using codesniffer - https://phabricator.wikimedia.org/T278594 (10Umherirrender) [23:12:41] 10Beta-Cluster-Infrastructure, 10MediaWiki-Export-or-Import, 10Beta-Cluster-reproducible: Special:Export broken on beta cluster: XML Parsing Error: no root element found - https://phabricator.wikimedia.org/T278579 (10Reedy) This might just be a beta issue in some for or another. WFM locally on master on my d... [23:43:19] (03CR) 10DannyS712: [C: 03+1] Use Generic.WhiteSpace.LanguageConstructSpacing sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/675230 (owner: 10Umherirrender) [23:46:49] (03CR) 10DannyS712: [C: 03+1] "okay, but why?" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/675232 (owner: 10Umherirrender)