[02:19:39] 10Phabricator (Upstream): Darkmode displays JavaScript incorrectly - https://phabricator.wikimedia.org/T279403 (10Base) [06:45:06] 10Phabricator (Upstream), 10Upstream: Darkmode displays JavaScript incorrectly - https://phabricator.wikimedia.org/T279403 (10Aklapper) 05Open→03Stalled 1. Go to https://phabricator.wikimedia.org/settings/panel/display 2. Set "Accessibility" to "Dark Mode (experimental)" 3. Go to https://phabricator.wikime... [06:59:44] 10Project-Admins: Create new tag #manuel-and-jaime-gsoc - https://phabricator.wikimedia.org/T278513 (10jcrespo) Thank you, Andre, and sorry for problems caused, they were unintended. [08:41:37] 10Release-Engineering-Team, 10Performance-Team, 10serviceops: Create warmup procedure for MediaWiki app servers - https://phabricator.wikimedia.org/T230037 (10Seb35) Link to {T240775} given this other one could be part of some warmup procedure. I mention also [[https://github.com/php-pm/php-pm|PHP-PM]], whi... [08:41:52] (03CR) 10Bharatkhatri: [C: 03+1] "> Patch Set 1:" [integration/config] - 10https://gerrit.wikimedia.org/r/676460 (owner: 10Zabe) [08:56:15] 10Release-Engineering-Team, 10Release-Engineering-Team-TODO (2021-04-01 to 2021-06-30 (Q4)), 10Release Pipeline: Profile single-version and multi-version image builds to identify bottlenecks - https://phabricator.wikimedia.org/T279323 (10akosiaris) >>! In T279323#6973417, @dduvall wrote: > @akosiaris I don't... [09:31:54] PROBLEM - Work requests waiting in Zuul Gearman server on contint2001 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [150.0] https://www.mediawiki.org/wiki/Continuous_integration/Zuul https://grafana.wikimedia.org/dashboard/db/zuul-gearman?panelId=10&fullscreen&orgId=1 [09:34:50] RECOVERY - Work requests waiting in Zuul Gearman server on contint2001 is OK: OK: Less than 100.00% above the threshold [90.0] https://www.mediawiki.org/wiki/Continuous_integration/Zuul https://grafana.wikimedia.org/dashboard/db/zuul-gearman?panelId=10&fullscreen&orgId=1 [09:40:57] 10Phabricator: Project-Admins can't set Source Repos on Projects - https://phabricator.wikimedia.org/T279284 (10Peachey88) Creation now shows, The editing form [[ https://phabricator.wikimedia.org/transactions/editengine/projects.project/view/9/ | (#9) ]] doesn't show it [09:43:40] 10Phabricator: Project-Admins can't set Source Repos on Projects - https://phabricator.wikimedia.org/T279284 (10Aklapper) Ah, thanks. I get https://phabricator.wikimedia.org/transactions/editengine/projects.project/view/6/ . You seem to get https://phabricator.wikimedia.org/transactions/editengine/projects.proj... [10:24:19] 10phan-taint-check-plugin: Enable coverage reports for taint-check - https://phabricator.wikimedia.org/T279423 (10Daimona) [10:24:38] 10phan-taint-check-plugin: Enable coverage reports for taint-check - https://phabricator.wikimedia.org/T279423 (10Daimona) [10:24:41] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Patch-For-Review, 10Test-Coverage: Switch mediawiki code coverage from xdebug to pcov - https://phabricator.wikimedia.org/T234020 (10Daimona) [10:36:32] 10phan-taint-check-plugin: Enable coverage reports for taint-check - https://phabricator.wikimedia.org/T279423 (10Daimona) [10:39:15] 10phan-taint-check-plugin: Enable coverage reports for taint-check - https://phabricator.wikimedia.org/T279423 (10Daimona) > Integration tests only might still run reasonabley quick Or maybe not. On my machine, 6m 49s with xdebug 2.9.1. Which gets a little better with xdebug 3.0.0 in "coverage" mode: 2m 13s. T... [10:39:28] 10phan-taint-check-plugin: Enable coverage reports for taint-check - https://phabricator.wikimedia.org/T279423 (10Daimona) [10:39:31] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Patch-For-Review, 10Test-Coverage: Switch mediawiki code coverage from xdebug to pcov - https://phabricator.wikimedia.org/T234020 (10Daimona) [10:39:34] 10phan-taint-check-plugin: Enable coverage reports for taint-check - https://phabricator.wikimedia.org/T279423 (10Daimona) [10:39:37] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Patch-For-Review, 10Test-Coverage: Switch mediawiki code coverage from xdebug to pcov - https://phabricator.wikimedia.org/T234020 (10Daimona) [10:40:34] 10Project-Admins: Cleaning up #Mediawiki-extensions-other - https://phabricator.wikimedia.org/T213880 (10Peachey88) 05Open→03Resolved a:03Peachey88 After discussions on IRC, we basically scoped this to extensions that had 5 or more (from memory) open tasks which I did, I will probably do another sweap thou... [10:47:46] 10Project-Admins: Create a project for the Toolforge Tool 'itwiki' - https://phabricator.wikimedia.org/T279425 (10valerio.bozzolan) [10:49:38] 10Project-Admins: Create a project for the Toolforge Tool 'itwiki' - https://phabricator.wikimedia.org/T279425 (10valerio.bozzolan) [10:52:15] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "I wrote many similar parsers the past years, and found that such optimizations typically don't make a difference in real-world scenarios. " [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/676942 (owner: 10Daimona Eaytoy) [10:52:50] 10Project-Admins: Create a project for the Toolforge Tool 'itwiki' - https://phabricator.wikimedia.org/T279425 (10Peachey88) This can be self-serviced from within Toolsadmin/striker I believe. [10:57:48] 10Phabricator, 10User-LokalProfil, 10WMSE (IT): Move a WMSE subproject into a separate top-level user project - https://phabricator.wikimedia.org/T240710 (10Aklapper) [10:58:02] 10Project-Admins, 10WMSE (IT): Move "Magnus Sälgö" and "so9q" to top level projects - https://phabricator.wikimedia.org/T272137 (10Aklapper) [11:41:09] 10Project-Admins: Create a project for the Toolforge Tool 'itwiki' - https://phabricator.wikimedia.org/T279425 (10Aklapper) In my understanding of https://phabricator.wikimedia.org/T144111 it should be possible to create a subproject under https://phabricator.wikimedia.org/project/profile/703/ (It's also very re... [11:42:22] 10Release-Engineering-Team-TODO (2021-04-01 to 2021-06-30 (Q4)), 10Release, 10Train Deployments: 1.36.0-wmf.38 deployment blockers - https://phabricator.wikimedia.org/T278344 (10mmodell) @ladsgroup: Thank you for the risky patch notice. That is always very helpful and appreciated. [12:05:21] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team, 10Testing-Roadblocks, 10User-ArielGlenn: create instance in deployment-prep just for testing MediaWiki code not yet merged into master - https://phabricator.wikimedia.org/T278666 (10daniel) [12:07:48] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team, 10Testing-Roadblocks, 10User-ArielGlenn: create instance in deployment-prep just for testing MediaWiki code not yet merged into master - https://phabricator.wikimedia.org/T278666 (10daniel) This is pretty similar to the ground work we'd need for {T... [12:09:10] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team, 10Testing-Roadblocks, 10User-ArielGlenn: create instance in deployment-prep just for testing MediaWiki code not yet merged into master - https://phabricator.wikimedia.org/T278666 (10ArielGlenn) >>! In T278666#6975958, @daniel wrote: > This is prett... [12:28:17] 10Gerrit, 10Gerrit-Privilege-Requests: Give access to l10n-bot to wikidata/query-builder repo - https://phabricator.wikimedia.org/T279279 (10Umherirrender) auto-merge https://gerrit.wikimedia.org/r/c/translatewiki/+/676862 [12:57:24] (03CR) 10Lars Wirzenius: "New patch set incoming." (035 comments) [tools/scap] - 10https://gerrit.wikimedia.org/r/674871 (https://phabricator.wikimedia.org/T269153) (owner: 10Lars Wirzenius) [12:57:34] (03PS3) 10Lars Wirzenius: feat! rewrite apply-patches, drop list-patches and test-patches [tools/scap] - 10https://gerrit.wikimedia.org/r/674871 (https://phabricator.wikimedia.org/T269153) [12:57:46] (03CR) 10jerkins-bot: [V: 04-1] feat! rewrite apply-patches, drop list-patches and test-patches [tools/scap] - 10https://gerrit.wikimedia.org/r/674871 (https://phabricator.wikimedia.org/T269153) (owner: 10Lars Wirzenius) [12:59:21] (03PS4) 10Lars Wirzenius: feat! rewrite apply-patches, drop list-patches and test-patches [tools/scap] - 10https://gerrit.wikimedia.org/r/674871 (https://phabricator.wikimedia.org/T269153) [13:01:12] 10LibUp, 10MediaWiki-extensions-General, 10Voice & Tone: rename *-blacklist to *-disallowed-list in .stylelintrc.json and .eslintrc.json - https://phabricator.wikimedia.org/T279431 (10Umherirrender) [13:01:21] 10LibUp, 10MediaWiki-extensions-General, 10Voice & Tone: rename *-blacklist to *-disallowed-list in .stylelintrc.json and .eslintrc.json - https://phabricator.wikimedia.org/T279431 (10Umherirrender) [13:25:51] 10Project-Admins: Create a project for the Toolforge Tool 'itwiki' - https://phabricator.wikimedia.org/T279425 (10valerio.bozzolan) 05Open→03Resolved a:03valerio.bozzolan >>! In T279425#6975791, @Peachey88 wrote: > This can be self-serviced from within Toolsadmin/striker I believe. Uh very handy! Thank y... [14:19:10] 10Release-Engineering-Team (Logspam), 10Wikimedia-General-or-Unknown, 10Platform Team Workboards (Clinic Duty Team), 10Wikimedia-database-error, 10Wikimedia-production-error: Occasional "Cannot access the database: Unknown error" in Wikimedia production - https://phabricator.wikimedia.org/T268715 (10Maros... [14:22:58] (03CR) 10Ahmon Dancy: feat! rewrite apply-patches, drop list-patches and test-patches (032 comments) [tools/scap] - 10https://gerrit.wikimedia.org/r/674871 (https://phabricator.wikimedia.org/T269153) (owner: 10Lars Wirzenius) [14:25:04] 10Release-Engineering-Team-TODO (2021-04-01 to 2021-06-30 (Q4)), 10Release, 10Train Deployments: 1.36.0-wmf.38 deployment blockers - https://phabricator.wikimedia.org/T278344 (10cscott) Parsoid missed the branch cut again (sorry!) so https://gerrit.wikimedia.org/r/c/mediawiki/vendor/+/676957 was cherry-picke... [14:49:53] 10Deployments: Deploy MW+Extensions by percentage of users (instead of by domain/wiki) - https://phabricator.wikimedia.org/T104398 (10dancy) [14:51:42] (03CR) 10Lars Wirzenius: "Thanks. New patch set imminent." (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/674871 (https://phabricator.wikimedia.org/T269153) (owner: 10Lars Wirzenius) [14:59:51] (03CR) 10Majavah: feat! rewrite apply-patches, drop list-patches and test-patches (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/674871 (https://phabricator.wikimedia.org/T269153) (owner: 10Lars Wirzenius) [15:02:23] (03CR) 10Lars Wirzenius: "Thanks. Fix in next patch set." (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/674871 (https://phabricator.wikimedia.org/T269153) (owner: 10Lars Wirzenius) [15:07:03] (03PS5) 10Lars Wirzenius: feat! rewrite apply-patches, drop list-patches and test-patches [tools/scap] - 10https://gerrit.wikimedia.org/r/674871 (https://phabricator.wikimedia.org/T269153) [15:08:38] 10Release-Engineering-Team (Logspam), 10VisualEditor, 10Wikimedia-production-error: TypeError: Cannot read property 'getModel' of null - https://phabricator.wikimedia.org/T279441 (10Jdlrobson) [15:08:58] (03CR) 10Ahmon Dancy: [C: 03+1] "Nice work Lars" [tools/scap] - 10https://gerrit.wikimedia.org/r/674871 (https://phabricator.wikimedia.org/T269153) (owner: 10Lars Wirzenius) [15:40:23] 10Release-Engineering-Team (Logspam), 10Growth-Team, 10MediaWiki-Recent-changes, 10JavaScript, 10Wikimedia-production-error: Recent Changes/Watchlist - click on empty 'Saved filters" give "item.getID is not a function" - https://phabricator.wikimedia.org/T256923 (10Jdlrobson) [15:42:59] 10Release-Engineering-Team, 10Release-Engineering-Team-TODO (2021-04-01 to 2021-06-30 (Q4)), 10MW-on-K8s, 10Release Pipeline: Provide a development environment for testing m8s deployment tooling - https://phabricator.wikimedia.org/T279324 (10LarsWirzenius) Would a train-dev environment with a k8s cluster d... [15:57:49] 10Release-Engineering-Team-TODO (2021-04-01 to 2021-06-30 (Q4)), 10Release, 10Train Deployments: 1.36.0-wmf.38 deployment blockers - https://phabricator.wikimedia.org/T278344 (10mmodell) @cscott thanks for the heads-up [16:01:33] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.36.0-wmf.37 deployment blockers - https://phabricator.wikimedia.org/T278343 (10mmodell) 05Open→03Resolved [16:06:49] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO (Yak Shaving 🐃🪒 ): Automatically tag the release task in the commit message of the weekly branch cut - https://phabricator.wikimedia.org/T278994 (10thcipriani) [16:09:00] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO (2021-04-01 to 2021-06-30 (Q4)): Automate the merge of the weekly branch cut - https://phabricator.wikimedia.org/T278993 (10thcipriani) p:05Triage→03Medium May be controversial, added to discussion at next #together team meeting [16:10:41] 10Release-Engineering-Team-TODO: echostore helm test service checker failing in staging cluster - https://phabricator.wikimedia.org/T259686 (10thcipriani) 05Open→03Resolved a:03akosiaris >>! In T259686#6952623, @Aklapper wrote: > No reply; removing archived project tag and adding #Release-Engineering-Team-... [16:12:33] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO (2021-04-01 to 2021-06-30 (Q4)), 10MW-on-K8s, 10Release Pipeline: Include MediaWiki testing in .pipeline/config.yaml execution graph - https://phabricator.wikimedia.org/T279340 (10thcipriani) [16:19:04] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO (2021-04-01 to 2021-06-30 (Q4)), 10Scap, 10observability: Update Scap to emit ECS-compatible structured logs - https://phabricator.wikimedia.org/T279086 (10thcipriani) a:03mmodell [16:19:53] 10Beta-Cluster-Infrastructure, 10Continuous-Integration-Config, 10Release-Engineering-Team-TODO, 10User-Majavah: Upgrade deployment-prep deploy* hosts to Buster - https://phabricator.wikimedia.org/T278689 (10thcipriani) [16:22:32] 10Release-Engineering-Team (Pipeline), 10Release-Engineering-Team-TODO (2021-04-01 to 2021-06-30 (Q4)), 10Release Pipeline, 10Documentation: Write PipelineLib user guide for setting up a GitOps-y workflow - https://phabricator.wikimedia.org/T278492 (10thcipriani) a:03dduvall [16:24:57] 10Release-Engineering-Team-TODO (2021-04-01 to 2021-06-30 (Q4)): Learn to do backports - https://phabricator.wikimedia.org/T272148 (10LarsWirzenius) [16:25:00] 10Phabricator, 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Developer Productivity: Implement more phabricator project metrics - https://phabricator.wikimedia.org/T273087 (10thcipriani) 05Open→03Resolved Resolving this task as we h... [16:25:44] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO (2021-04-01 to 2021-06-30 (Q4)), 10Scap, 10Performance-Team (Radar), 10Sustainability (Incident Followup): Localisation cache must be purged after or during train deploy, not (just)... - https://phabricator.wikimedia.org/T263872 [16:26:06] 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (2021-04-01 to 2021-06-30 (Q4)), 10Scap, 10Patch-For-Review, 10User-brennen: Applying security patches should be robust and also give some useful output - https://phabricator.wikimedia.org/T269153 (10LarsWirzenius) [16:26:31] 10Release-Engineering-Team-TODO (2021-04-01 to 2021-06-30 (Q4)), 10Scap: Tag Scap release 1.37.0 and ask serviceops to deploy it to production - https://phabricator.wikimedia.org/T272145 (10LarsWirzenius) [16:27:42] 10Deployments, 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10Wikimedia-Site-requests, 10I18n: Why is the LocalisationUpdate extension still enabled in WMF production? - https://phabricator.wikimedia.org/T278019 (10thcipriani) p:05Medium→03Lowest [16:28:14] 10Release-Engineering-Team-TODO (2021-04-01 to 2021-06-30 (Q4)), 10Scap: scap 3.16.0-1 deb package on deploy1002 does not contain all commits from the debian/3.16.0-1 tag - https://phabricator.wikimedia.org/T277782 (10LarsWirzenius) [16:28:47] 10Release-Engineering-Team (Local Dev), 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10MediaWiki-Docker, 10Developer Productivity, and 3 others: mediawiki-docker exec feature - https://phabricator.wikimedia.org/T262370 (10thcipriani) 05Open→03Resolved [16:28:50] 10Release-Engineering-Team, 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10MediaWiki-Docker, 10Developer Productivity, and 3 others: Command-line wrapper for interacting with core's docker-compose stack - https://phabricator.wikimedia.org/T246111 (10thcipriani) [16:30:30] 10Deployments, 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO (2021-04-01 to 2021-06-30 (Q4)): L10n cache files building up on backup deploy hosts - https://phabricator.wikimedia.org/T275826 (10thcipriani) [16:33:22] 10Phabricator, 10Release-Engineering-Team-TODO (Yak Shaving 🐃🪒 ), 10Security, 10User-MModell: Deprecate phabricator's fixed_settings.yaml (in puppet) and just use phabricator's built in configuration tools - https://phabricator.wikimedia.org/T239355 (10thcipriani) p:05Medium→03Low [16:33:24] 10Phabricator, 10Release-Engineering-Team-TODO (Yak Shaving 🐃🪒 ), 10Security, 10User-MModell: Deprecate phabricator's fixed_settings.yaml (in puppet) and just use phabricator's built in configuration tools - https://phabricator.wikimedia.org/T239355 (10thcipriani) [16:34:02] 10Release-Engineering-Team-TODO, 10MW-on-K8s, 10Release Pipeline, 10serviceops-radar, 10Epic: Deploy MediaWiki to Wikimedia production in containers - https://phabricator.wikimedia.org/T238770 (10thcipriani) [16:35:15] 10Gerrit, 10Phabricator, 10Release-Engineering-Team-TODO, 10Diffusion-Repository-Administrators, 10Wikimedia-GitHub: Create some automation for management of gerrit/phabricator/github mirrors - https://phabricator.wikimedia.org/T235874 (10thcipriani) [16:35:48] 10Gerrit, 10Phabricator, 10Release-Engineering-Team-TODO, 10Diffusion-Repository-Administrators, 10Wikimedia-GitHub: Create some automation for management of gerrit/phabricator/github mirrors - https://phabricator.wikimedia.org/T235874 (10thcipriani) 05Open→03Stalled Stalling on GitLab work which wil... [16:40:16] 10Release-Engineering-Team-TODO, 10MediaWiki-extensions-LocalisationUpdate, 10Security: Reenable l10update in production - https://phabricator.wikimedia.org/T220481 (10thcipriani) [16:41:53] 10Release-Engineering-Team-TODO, 10MediaWiki-extensions-LocalisationUpdate, 10Security: Reenable l10update in production - https://phabricator.wikimedia.org/T220481 (10thcipriani) Re-enabling this will mean having l10n go through the regular backport process happy to work with language folks on this. [16:44:12] 10Release-Engineering-Team, 10Scap: Track scap syncs that are part of a given SWAT window - https://phabricator.wikimedia.org/T193311 (10thcipriani) 05Open→03Declined Declining this in favor of {T279322} -- which encapsulates pipeline work as well. [16:45:10] 10Release-Engineering-Team-TODO, 10Scap, 10MediaWiki-Internationalization, 10Performance-Team, 10Patch-For-Review: Use static php array files for l10n cache at WMF (instead of CDB) - https://phabricator.wikimedia.org/T99740 (10thcipriani) [16:46:42] 10Release-Engineering-Team, 10Release-Engineering-Team-TODO (2021-04-01 to 2021-06-30 (Q4)), 10MW-on-K8s, 10Release Pipeline: Design m8s deployment workflows and tooling - https://phabricator.wikimedia.org/T279322 (10dduvall) [16:48:58] 10Release-Engineering-Team, 10Release-Engineering-Team-TODO (2021-04-01 to 2021-06-30 (Q4)), 10MW-on-K8s, 10Release Pipeline: Design m8s deployment workflows and tooling - https://phabricator.wikimedia.org/T279322 (10dduvall) >>! In T279322#6973652, @thcipriani wrote: > `scap backport --revert change_id [c... [16:55:02] 10Project-Admins: Create a project for the Toolforge Tool 'itwiki' - https://phabricator.wikimedia.org/T279425 (10Aklapper) @valerio.bozzolan: Yay. :) Could you please add a description and if possible a link to the code repository to it? Thanks! [16:56:02] 10Project-Admins: Create a project for the Toolforge Tool 'itwiki' - https://phabricator.wikimedia.org/T279425 (10valerio.bozzolan) >>! In T279425#6977078, @Aklapper wrote: > @valerio.bozzolan: Yay. :) Could you please add a description and if possible a link to the code repository to it? Thanks! Yup that's the... [16:57:53] 10Release-Engineering-Team, 10MediaWiki-Core-Testing, 10ci-test-error: parser tests running under phpunit are broken in extensions - https://phabricator.wikimedia.org/T248180 (10thcipriani) 05Open→03Invalid Not sure where this one is today, but if we're still in a broken state we need new analysis since... [17:03:02] 10MediaWiki-Releasing, 10MW-1.36-notes, 10MW-1.36-release, 10Platform Team Workboards (Initiatives): Release MW 1.36.0 - https://phabricator.wikimedia.org/T279455 (10Jdforrester-WMF) [17:03:14] 10MediaWiki-Releasing, 10MW-1.36-release: Branch REL1_36 for MediaWiki and deployed extensions - https://phabricator.wikimedia.org/T279456 (10Jdforrester-WMF) [17:04:49] 10Deployments, 10Release-Engineering-Team, 10Performance-Team (Radar): Take heat off day before the weekly branch-cut? - https://phabricator.wikimedia.org/T118212 (10thcipriani) 05Open→03Declined We discussed at the team meeting on [[ https://www.mediawiki.org/wiki/Wikimedia_Release_Engineering_Team/Chec... [17:18:39] 10Phabricator, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO: Switch phabricator production to codfw - https://phabricator.wikimedia.org/T164810 (10LSobanski) Removing the DBA tag and subscribing myself instead. Once there are specific actions for DBA please re-add us and... [17:18:59] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO (2021-04-01 to 2021-06-30 (Q4)): Automate the merge of the weekly branch cut - https://phabricator.wikimedia.org/T278993 (10dduvall) If we're auto +2'ing, does this commit still need to go through review? I ask because `branch.py... [17:25:05] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO (2021-04-01 to 2021-06-30 (Q4)): Automate the merge of the weekly branch cut - https://phabricator.wikimedia.org/T278993 (10Jdforrester-WMF) >>! In T278993#6977249, @dduvall wrote: > If we're auto +2'ing, does the branch cut chan... [17:25:35] 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10MediaWiki-Internationalization, 10MW-1.36-notes (1.36.0-wmf.20; 2020-12-01): Add flag to rebuildLocalisationCache.php to skip MessageBlobStore::clearGlobalCacheEntry - https://phabricator.wikimedia.org/T268698 (10dancy) For the record https:/... [17:26:35] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO (2021-04-01 to 2021-06-30 (Q4)): Automate the merge of the weekly branch cut - https://phabricator.wikimedia.org/T278993 (10dduvall) >>! In T278993#6977267, @Jdforrester-WMF wrote: >>>! In T278993#6977249, @dduvall wrote: >> If w... [17:26:51] 10Phabricator, 10User-DannyS712: Unhandled exception while viewing phab notifications - https://phabricator.wikimedia.org/T279458 (10DannyS712) [17:38:17] (03PS1) 10Ahmon Dancy: Localisation cache must be purged after or during train deploy, not (just) before [tools/scap] - 10https://gerrit.wikimedia.org/r/677318 (https://phabricator.wikimedia.org/T263872) [17:38:45] 10Continuous-Integration-Config, 10MediaWiki-Releasing, 10MW-1.36-release: Configure CI to support REL1_36 - https://phabricator.wikimedia.org/T279459 (10Jdforrester-WMF) [17:39:52] 10MediaWiki-Releasing, 10MediaWiki-Vendor, 10MW-1.36-notes, 10MW-1.36-release: Prune /vendor for REL1_36 - https://phabricator.wikimedia.org/T279460 (10Jdforrester-WMF) [17:40:18] (03PS2) 10Ahmon Dancy: Pass --offline to rebuildLocalisationCache.php [tools/scap] - 10https://gerrit.wikimedia.org/r/677318 (https://phabricator.wikimedia.org/T263872) [17:44:55] 10MediaWiki-Releasing, 10MW-1.36-release: Branch REL1_36 for MediaWiki and all extensions and skins - https://phabricator.wikimedia.org/T279456 (10Jdforrester-WMF) [17:45:35] 10MediaWiki-Releasing, 10MW-1.36-notes, 10MW-1.36-release: Finish up RELEASE-NOTES for 1.36.0 - https://phabricator.wikimedia.org/T279461 (10Jdforrester-WMF) [17:46:25] 10MediaWiki-Releasing, 10MW-1.36-notes, 10MW-1.36-release: Release 1.36.0-rc.0 - https://phabricator.wikimedia.org/T279462 (10Jdforrester-WMF) [17:47:00] 10MediaWiki-Releasing, 10MW-1.36-notes, 10MW-1.36-release: Write release announcement for 1.36.0-rc.0 - https://phabricator.wikimedia.org/T279463 (10Jdforrester-WMF) [17:53:27] (03PS1) 10Jforrester: Zuul: [mediawiki/services/function-{orchestr,evalu}ator] Publish images [integration/config] - 10https://gerrit.wikimedia.org/r/677320 [17:54:56] (03PS3) 10Thcipriani: Pass --offline to rebuildLocalisationCache.php [tools/scap] - 10https://gerrit.wikimedia.org/r/677318 (https://phabricator.wikimedia.org/T263872) (owner: 10Ahmon Dancy) [17:56:23] (03CR) 10Jforrester: [C: 03+2] Zuul: [mediawiki/services/function-{orchestr,evalu}ator] Publish images [integration/config] - 10https://gerrit.wikimedia.org/r/677320 (owner: 10Jforrester) [17:57:58] (03Merged) 10jenkins-bot: Zuul: [mediawiki/services/function-{orchestr,evalu}ator] Publish images [integration/config] - 10https://gerrit.wikimedia.org/r/677320 (owner: 10Jforrester) [17:58:44] !log Zuul: [mediawiki/services/function-{orchestr,evalu}ator] Publish images [17:58:47] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [18:02:03] 10Deployments, 10Jouncebot: Jouncebot: Ability to mark calendar entries as non-reporting - https://phabricator.wikimedia.org/T187228 (10bd808) A current example: `lang=irc [18:00] Deploy window Pre MediaWiki train break (https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20210406T1800) ` [18:03:01] 10Release-Engineering-Team (Logspam), 10VisualEditor, 10Editing-team (Tracking), 10JavaScript, 10Wikimedia-production-error: TypeError: undefined is not an object (evaluating 'param.aliases.length') - https://phabricator.wikimedia.org/T261884 (10Jdlrobson) [18:04:49] 10Deployments, 10Jouncebot: Jouncebot: Ability to mark calendar entries as non-reporting - https://phabricator.wikimedia.org/T187228 (10Jdforrester-WMF) At least theoretically, it's meant to be an in-channel reminder to not deploy anything. :-) But yeah, maybe they don't need announcing. [18:07:47] 10Deployments, 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10Wikimedia-Site-requests, 10I18n: Why is the LocalisationUpdate extension still enabled in WMF production? - https://phabricator.wikimedia.org/T278019 (10dancy) @Reedy scap does not do anything directly rel... [18:09:01] 10Deployments, 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10Wikimedia-Site-requests, 10I18n: Why is the LocalisationUpdate extension still enabled in WMF production? - https://phabricator.wikimedia.org/T278019 (10Jdforrester-WMF) Excellent. [18:14:11] 10Deployments, 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10Wikimedia-Site-requests, 10I18n: Why is the LocalisationUpdate extension still enabled in WMF production? - https://phabricator.wikimedia.org/T278019 (10Jdforrester-WMF) 05Open→03Resolved [18:14:14] 10Deployments, 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10TechCom-RFC, 10I18n: RFC: Reevaluate LocalisationUpdate extension for WMF - https://phabricator.wikimedia.org/T158360 (10Jdforrester-WMF) [18:18:07] (03PS1) 10Dduvall: make-release: Add `--push-option` to branch.py [tools/release] - 10https://gerrit.wikimedia.org/r/677324 (https://phabricator.wikimedia.org/T278993) [18:33:57] (03PS1) 10Jforrester: Zuul: Configure the REL1_36 test and gate pipelines [integration/config] - 10https://gerrit.wikimedia.org/r/677328 (https://phabricator.wikimedia.org/T279459) [18:35:06] (03CR) 10Jforrester: [C: 03+1] "Neat." [tools/release] - 10https://gerrit.wikimedia.org/r/677324 (https://phabricator.wikimedia.org/T278993) (owner: 10Dduvall) [18:36:30] 10Release-Engineering-Team-TODO (2021-04-01 to 2021-06-30 (Q4)), 10Release, 10Train Deployments: 1.36.0-wmf.39 deployment blockers - https://phabricator.wikimedia.org/T278345 (10Jdlrobson) [18:45:52] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10SRE, 10serviceops, 10Patch-For-Review: replace doc1001.eqiad.wmnet with a buster VM and create the codfw equivalent - https://phabricator.wikimedia.org/T247653 (10Dzahn) 05Open→03Stalled replacement VMs wit... [18:49:11] 10Release-Engineering-Team (Logspam), 10JavaScript, 10MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), 10Patch-For-Review, and 3 others: document.body.append is not a function / undefined is not a function when mounting in Special:MediaSearch in ES5 browsers - https://phabricator.wikimedia.org/T278448 (10AnneT)... [18:51:18] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10SRE, 10serviceops, 10Patch-For-Review: replace doc1001.eqiad.wmnet with a buster VM and create the codfw equivalent - https://phabricator.wikimedia.org/T247653 (10Dzahn) Maybe someone could run some tests from... [18:53:06] 10Release-Engineering-Team (Logspam), 10JavaScript, 10MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), 10Patch-For-Review, and 3 others: document.body.append is not a function / undefined is not a function when mounting in Special:MediaSearch in ES5 browsers - https://phabricator.wikimedia.org/T278448 (10Jdlrobso... [19:04:03] 10Release-Engineering-Team (Logspam), 10JavaScript, 10MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), 10Patch-For-Review, and 3 others: document.body.append is not a function / undefined is not a function when mounting in Special:MediaSearch in ES5 browsers - https://phabricator.wikimedia.org/T278448 (10Krinkle... [19:04:44] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10SRE, 10GitLab (Initialization), 10User-brennen: SSH Access of Git data in GitLab - https://phabricator.wikimedia.org/T276148 (10Dzahn) boldly assigning this to @Sergey.Trofimovsky.SF now. There are 2 public IPs on the VM, gitlab1001.wikim... [19:05:05] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10SRE, 10GitLab (Initialization), 10User-brennen: SSH Access of Git data in GitLab - https://phabricator.wikimedia.org/T276148 (10Dzahn) a:05Dzahn→03Sergey.Trofimovsky.SF [19:14:19] 10Release-Engineering-Team (Logspam), 10JavaScript, 10MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), 10Patch-For-Review, and 3 others: document.body.append is not a function / undefined is not a function when mounting in Special:MediaSearch in ES5 browsers - https://phabricator.wikimedia.org/T278448 (10AnneT)... [19:14:54] 10Release-Engineering-Team (Logspam), 10ContentTranslation, 10JavaScript, 10Patch-For-Review, 10Wikimedia-production-error: Uncaught TypeError: Cannot read property 'offsetHeight' of null - https://phabricator.wikimedia.org/T261992 (10Esanders) The above patch suppresses the error in VE. If the error onl... [19:50:30] 10Release-Engineering-Team-TODO (2021-04-01 to 2021-06-30 (Q4)), 10Release, 10Train Deployments: 1.36.0-wmf.39 deployment blockers - https://phabricator.wikimedia.org/T278345 (10thcipriani) [19:52:35] 10Release-Engineering-Team-TODO (2021-04-01 to 2021-06-30 (Q4)), 10Release, 10Train Deployments: 1.37.0-wmf.1 deployment blockers - https://phabricator.wikimedia.org/T278345 (10jeena) [19:54:21] 10Release-Engineering-Team (Logspam), 10MediaWiki-Interface (active libraries), 10Readers-Web-Backlog (Tracking), 10Wikimedia-production-error: TypeError: str is undefined at byteLength - https://phabricator.wikimedia.org/T279301 (10Jdlrobson) [19:54:52] (03CR) 10Jforrester: [C: 03+2] Zuul: Configure the REL1_36 test and gate pipelines [integration/config] - 10https://gerrit.wikimedia.org/r/677328 (https://phabricator.wikimedia.org/T279459) (owner: 10Jforrester) [19:56:03] (03Merged) 10jenkins-bot: Zuul: Configure the REL1_36 test and gate pipelines [integration/config] - 10https://gerrit.wikimedia.org/r/677328 (https://phabricator.wikimedia.org/T279459) (owner: 10Jforrester) [19:58:27] !log Zuul: Configure the REL1_36 test and gate pipelines T279459 [19:58:31] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [19:58:31] T279459: Configure CI to support REL1_36 - https://phabricator.wikimedia.org/T279459 [19:59:29] 10MediaWiki-Releasing, 10MW-1.36-release: Branch REL1_36 for MediaWiki and all extensions and skins - https://phabricator.wikimedia.org/T279456 (10Jdforrester-WMF) [19:59:52] 10Continuous-Integration-Config, 10MediaWiki-Releasing, 10MW-1.36-release, 10Patch-For-Review: Configure CI to support REL1_36 - https://phabricator.wikimedia.org/T279459 (10Jdforrester-WMF) 05Open→03Resolved a:03Jdforrester-WMF [20:02:19] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10SRE, 10GitLab (Initialization), 10User-brennen: SSH Access of Git data in GitLab - https://phabricator.wikimedia.org/T276148 (10Sergey.Trofimovsky.SF) >>! In T276148#6977653, @Dzahn wrote: > boldly assigning this to @Sergey.Trofimovsky.SF n... [20:04:51] 10Release-Engineering-Team-TODO (2021-04-01 to 2021-06-30 (Q4)), 10Release, 10Train Deployments: 1.37.0-wmf.2 deployment blockers - https://phabricator.wikimedia.org/T278347 (10Jdforrester-WMF) [20:12:46] (03PS1) 10Umherirrender: Warn about use of define with deprecated third argument [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/677357 [20:12:48] 10MediaWiki-Releasing, 10MW-1.36-release: Branch REL1_36 for MediaWiki and all extensions and skins - https://phabricator.wikimedia.org/T279456 (10Jdforrester-WMF) a:03jeena [20:14:59] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10SRE, 10GitLab (Initialization), 10User-brennen: SSH Access of Git data in GitLab - https://phabricator.wikimedia.org/T276148 (10Dzahn) Personally I think this (the IP address) would be a good line to do the separation at. We handle the admi... [20:16:22] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10SRE, 10GitLab (Initialization), 10User-brennen: SSH Access of Git data in GitLab - https://phabricator.wikimedia.org/T276148 (10brennen) > Personally I think this (the IP address) would be a good line to do the separation at. We handle the... [20:18:52] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10SRE, 10GitLab (Initialization), 10User-brennen: SSH Access of Git data in GitLab - https://phabricator.wikimedia.org/T276148 (10Sergey.Trofimovsky.SF) Sounds like a plan to me then. [20:24:05] (03PS2) 10Jforrester: Zuul: [mediawiki/extensions/Gravatar] Add basic quibble and phan jobs [integration/config] - 10https://gerrit.wikimedia.org/r/676833 (https://phabricator.wikimedia.org/T279260) (owner: 10Mainframe98) [20:24:11] (03CR) 10Jforrester: [C: 03+2] Zuul: [mediawiki/extensions/Gravatar] Add basic quibble and phan jobs [integration/config] - 10https://gerrit.wikimedia.org/r/676833 (https://phabricator.wikimedia.org/T279260) (owner: 10Mainframe98) [20:24:47] (03CR) 10Jforrester: [C: 03+2] Archive the D3Loader extension [integration/config] - 10https://gerrit.wikimedia.org/r/676697 (https://phabricator.wikimedia.org/T277626) (owner: 10Zoranzoki21) [20:25:31] (03Merged) 10jenkins-bot: Zuul: [mediawiki/extensions/Gravatar] Add basic quibble and phan jobs [integration/config] - 10https://gerrit.wikimedia.org/r/676833 (https://phabricator.wikimedia.org/T279260) (owner: 10Mainframe98) [20:25:57] (03Merged) 10jenkins-bot: Archive the D3Loader extension [integration/config] - 10https://gerrit.wikimedia.org/r/676697 (https://phabricator.wikimedia.org/T277626) (owner: 10Zoranzoki21) [20:26:00] !log Zuul: [mediawiki/extensions/Gravatar] Add basic quibble and phan jobs T279260 [20:26:04] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [20:26:04] T279260: Publish Gravatar extension - https://phabricator.wikimedia.org/T279260 [20:26:41] (03CR) 10Zoranzoki21: [C: 03+1] "@Jdforrester Please +2 and this please." [integration/config] - 10https://gerrit.wikimedia.org/r/676460 (owner: 10Zabe) [20:26:55] !log Zuul: [mediawiki/extensions/D3Loader] Mark as archived T277626 [20:26:58] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [20:26:58] T277626: Archive the D3Loader extension - https://phabricator.wikimedia.org/T277626 [20:27:21] (03CR) 10Jforrester: [C: 04-1] "Why are you using the banned term?" [integration/config] - 10https://gerrit.wikimedia.org/r/676460 (owner: 10Zabe) [20:27:58] (03CR) 10Jforrester: [C: 04-1] "Please confirm you intend what this does, and don't intend what the commit summary claims it does." [integration/config] - 10https://gerrit.wikimedia.org/r/676780 (owner: 10Xqt) [20:28:12] (03CR) 10Zoranzoki21: [C: 03+1] "> Patch Set 1: Code-Review-1" [integration/config] - 10https://gerrit.wikimedia.org/r/676460 (owner: 10Zabe) [20:31:07] (03CR) 10Jforrester: "I'd rather we just drop coverage reports for REL1_31 instead of adding this tech debt. Does that work for you? (see https://libraryupgrade" [integration/config] - 10https://gerrit.wikimedia.org/r/567938 (https://phabricator.wikimedia.org/T234020) (owner: 10Daimona Eaytoy) [20:39:20] 10Beta-Cluster-Infrastructure, 10ContentTranslation, 10Wikimedia-Site-requests: Beta cluster Special:ContentTranslation Error: Unsupported operand types - https://phabricator.wikimedia.org/T276656 (10Urbanecm) @Jdlrobson You are the only one who I remember touching beta logos recently. Maybe you want to have... [20:45:05] 10MediaWiki-Releasing, 10MW-1.36-release: Branch REL1_36 for MediaWiki and all extensions and skins - https://phabricator.wikimedia.org/T279456 (10Jdforrester-WMF) From the git log, {e497482ee4} should be the branch point as that was the last commit that landed in 1.36.0-wmf.38 before code started being 1.37.0... [20:56:44] (03CR) 10Jforrester: [C: 04-1] "> Patch Set 1:" [integration/config] - 10https://gerrit.wikimedia.org/r/676460 (owner: 10Zabe) [20:58:30] (03CR) 10Zabe: "> Patch Set 1:" [integration/config] - 10https://gerrit.wikimedia.org/r/676460 (owner: 10Zabe) [21:11:24] (03CR) 10Ahmon Dancy: [C: 03+1] make-release: Add `--push-option` to branch.py [tools/release] - 10https://gerrit.wikimedia.org/r/677324 (https://phabricator.wikimedia.org/T278993) (owner: 10Dduvall) [21:12:58] (03PS5) 10Umherirrender: Add a new StaticClosureSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/662110 (https://phabricator.wikimedia.org/T274038) [21:18:25] 10Phabricator, 10Wikimedia-production-error: Opening next page of Phabricator notifications given an Unhandled Exception - https://phabricator.wikimedia.org/T279481 (10Base) [21:19:01] (03CR) 10Umherirrender: [C: 04-1] Add a new StaticClosureSniff (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/662110 (https://phabricator.wikimedia.org/T274038) (owner: 10Umherirrender) [21:20:03] 10Phabricator (Upstream), 10Upstream: Darkmode displays JavaScript incorrectly - https://phabricator.wikimedia.org/T279403 (10Base) @Aklapper , but you did reproduce it. Try selecting the code on the screenshot, you will see that it actually contains curly braces (as one would expect a JS file to do), but they... [21:35:47] Reedy: would a big jump skipping 40 versions :) [21:36:00] Why stop there? MW 2.0!!! [21:36:33] That'll be fun [22:00:21] 10Phabricator, 10Wikimedia-production-error: Opening next page of Phabricator notifications gives an Unhandled Exception - https://phabricator.wikimedia.org/T279481 (10Base) [22:03:38] 10Phabricator, 10Wikimedia-production-error: Opening next page of Phabricator notifications gives an Unhandled Exception - https://phabricator.wikimedia.org/T279481 (10Base) [22:03:44] 10Phabricator, 10User-DannyS712: Unhandled exception while viewing phab notifications - https://phabricator.wikimedia.org/T279458 (10Base) [22:33:28] 10Beta-Cluster-Infrastructure, 10ContentTranslation, 10Language-Team, 10Wikimedia-Site-requests: Beta cluster Special:ContentTranslation Error: Unsupported operand types - https://phabricator.wikimedia.org/T276656 (10Jdlrobson) `wmgSiteLogoWordmark` is set to false. https://gerrit.wikimedia.org/r/plugins/... [23:08:30] 10Release-Engineering-Team (Logspam), 10Wikimedia-General-or-Unknown, 10Platform Team Workboards (Clinic Duty Team), 10Wikimedia-database-error, 10Wikimedia-production-error: Occasional "Cannot access the database: Unknown error" in Wikimedia production - https://phabricator.wikimedia.org/T268715 (10Krink... [23:40:05] 10Beta-Cluster-Infrastructure, 10MediaWiki-Export-or-Import, 10Beta-Cluster-reproducible, 10MW-1.35-notes, and 3 others: Special:Export broken: always generates an empty file - https://phabricator.wikimedia.org/T278579 (10tstarling) A wholesale revert is not really a resolution. Maybe we can reopen with lo...