[01:11:48] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO: Gerrit: default branch for new projects should be "main" - https://phabricator.wikimedia.org/T279612 (10thcipriani) [01:12:27] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO: Gerrit: default branch for new projects should be "main" - https://phabricator.wikimedia.org/T279612 (10thcipriani) [01:13:03] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO: Gerrit: default branch for new projects should be "main" - https://phabricator.wikimedia.org/T279612 (10thcipriani) 05Open→03Stalled Marking as stalled at the moment as we need a new Gerrit release before this i... [02:56:37] (03Abandoned) 10Ejegg: Add 'patch' utility to base fundraising image [releng/dev-images] - 10https://gerrit.wikimedia.org/r/677381 (owner: 10Ejegg) [03:09:23] (03CR) 10Jforrester: [C: 03+2] "Oh yeah, good one." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/677357 (owner: 10Umherirrender) [03:10:15] (03CR) 10Jforrester: [C: 03+2] Support @phan annotation in UnusedUseStatementSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/676148 (owner: 10Umherirrender) [03:13:38] James_F are you around? [03:15:01] (03Merged) 10jenkins-bot: Warn about use of define with deprecated third argument [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/677357 (owner: 10Umherirrender) [03:15:03] (03Merged) 10jenkins-bot: Support @phan annotation in UnusedUseStatementSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/676148 (owner: 10Umherirrender) [03:26:19] DannyS712: Ish. [03:26:24] DannyS712: How can I help? [03:38:48] I was hoping you could take a look at https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Flow/+/675302 - its kind of blocking some of the migration of services to ServiceWiring since it doesn't make sense to move services if they are only needed in a single place, the creation of other services [03:40:12] I looked at it quickly but it's a bit large. [03:40:25] would it help to split it up? [03:40:33] That'd be great if you could. [03:40:37] I know it's a chore. [03:45:09] okay, part one is at https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Flow/+/677711 and I'll rebase the other patch and probably split it again after this one merges [03:46:21] thanks for the reviews - I should have some extra time tomorrow to send patches to move more services [03:46:48] Ack/ [03:47:29] also, if you have time: https://gerrit.wikimedia.org/r/q/topic:%22delete-empty-translations%22+status:open I sent a bunch of patches to remove empty translation files, each of them should be really easy to review [03:47:36] but thats not urgent [03:48:24] I was leaving that to TWN team; Raimond was merging at least a few of them . [04:08:40] 10Continuous-Integration-Infrastructure, 10Jenkins, 10Release-Engineering-Team: Upgrade Jenkins to 2.277.x - https://phabricator.wikimedia.org/T279033 (10Jdforrester-WMF) [06:19:56] DannyS712: we could have done that automatically with a small configuration change [06:22:19] Nikerabbit alas, I couldn't find the source for the translation updater bot and figured it was easier to just send the patches - I wasn't expecting there to be so many [06:24:17] for reference, at the start I did it by manually looking at each json file, but then I realized codesearch could help, and then I refined my search to `\s}$` (the } for the end of the metadata, preceded by whitespace to ensure that it is not the closing } at the end of the file, and must be the end of the line so there is no comma and translations [06:24:17] afterwards) - I didn't send a patch for DonationInterface though, so if the bot is changed to do it automatically you can test it out on that extension [06:31:37] DannyS712: https://translatewiki.net/wiki/Project:News#February_2021 (the exceptions are mediawiki extensions and skins which have export-threshold at 0% which prevents deletions) [06:31:55] I should fix that [06:41:04] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO: Gerrit: default branch for new projects should be "main" - https://phabricator.wikimedia.org/T279612 (10Aklapper) I'd like to note that this will complicate patch contributions further. See the commands including t... [06:46:35] 10Phabricator (Upstream), 10Logos, 10Upstream, 10User-MacFan4000: Update the MediaWiki sprite logos within phabricator core - https://phabricator.wikimedia.org/T279573 (10Aklapper) @MacFan4000: I don't think that subscribing upstream maintainers on every downstream issue across all and any downstream issue... [06:47:44] 10Phabricator (Upstream), 10Logos, 10Upstream, 10User-MacFan4000: Update the MediaWiki sprite logos within phabricator core - https://phabricator.wikimedia.org/T279573 (10Aklapper) >>! In T279573#6981837, @MacFan4000 wrote: > Phabricator does that by default when you use the “Create subtask” button. That's... [06:52:13] !log deployment-docker-cpjobqueue01 edit configuration to pick up https://gerrit.wikimedia.org/r/c/operations/deployment-charts/+/676563 [06:52:15] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [08:14:12] (03PS1) 10ZPapierski: jjb:Enable Sonar analysis for mjolnir builds [integration/config] - 10https://gerrit.wikimedia.org/r/677813 (https://phabricator.wikimedia.org/T264877) [08:14:35] 10Phabricator, 10DBA: Upgrade mysql on db1132 (phabricator db master) - https://phabricator.wikimedia.org/T279625 (10Marostegui) [08:14:45] 10Phabricator, 10DBA: Upgrade mysql on db1132 (phabricator db master) - https://phabricator.wikimedia.org/T279625 (10Marostegui) p:05Triage→03Medium [08:15:26] (03CR) 10jerkins-bot: [V: 04-1] jjb:Enable Sonar analysis for mjolnir builds [integration/config] - 10https://gerrit.wikimedia.org/r/677813 (https://phabricator.wikimedia.org/T264877) (owner: 10ZPapierski) [08:28:12] 10Scap, 10SRE, 10Python3-Porting: Porting scap to Python 3 - https://phabricator.wikimedia.org/T279628 (10MoritzMuehlenhoff) [08:42:28] (03PS2) 10ZPapierski: jjb:Enable Sonar analysis for mjolnir builds [integration/config] - 10https://gerrit.wikimedia.org/r/677813 (https://phabricator.wikimedia.org/T264877) [08:43:34] (03CR) 10jerkins-bot: [V: 04-1] jjb:Enable Sonar analysis for mjolnir builds [integration/config] - 10https://gerrit.wikimedia.org/r/677813 (https://phabricator.wikimedia.org/T264877) (owner: 10ZPapierski) [08:48:53] (03PS3) 10ZPapierski: jjb:Enable Sonar analysis for mjolnir builds [integration/config] - 10https://gerrit.wikimedia.org/r/677813 (https://phabricator.wikimedia.org/T264877) [08:50:31] (03CR) 10jerkins-bot: [V: 04-1] jjb:Enable Sonar analysis for mjolnir builds [integration/config] - 10https://gerrit.wikimedia.org/r/677813 (https://phabricator.wikimedia.org/T264877) (owner: 10ZPapierski) [09:03:10] (03PS4) 10ZPapierski: jjb:Enable Sonar analysis for mjolnir builds [integration/config] - 10https://gerrit.wikimedia.org/r/677813 (https://phabricator.wikimedia.org/T264877) [09:08:59] 10Phabricator, 10DBA: Upgrade mysql on db1132 (phabricator db master) - https://phabricator.wikimedia.org/T279625 (10Marostegui) [09:48:18] 10Continuous-Integration-Infrastructure, 10Zuul: Move trusted user allow list out of layout.yaml and into a trusted users file which can be more easily reviewed - https://phabricator.wikimedia.org/T279594 (10hashar) The `parameter-function` is used to add more build parameters just before a job is launched in... [09:53:49] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10SRE, 10GitLab (Initialization), 10User-brennen: SSH Access of Git data in GitLab - https://phabricator.wikimedia.org/T276148 (10jbond) > We're making it a part of the Ansible playbook that manages Gitlab installation. I believe you should h... [09:59:34] 10Continuous-Integration-Infrastructure, 10Jenkins, 10Release-Engineering-Team: Upgrade Jenkins to 2.277.x - https://phabricator.wikimedia.org/T279033 (10hashar) **I am on limited hours this week.** We are not affected by the security issues reported in https://www.jenkins.io/security/advisory/2021-04-07/... [09:59:56] 10Continuous-Integration-Infrastructure, 10Jenkins, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2021-04-01 to 2021-06-30 (Q4)): Upgrade Jenkins to 2.277.x - https://phabricator.wikimedia.org/T279033 (10hashar) [10:03:44] (03PS1) 10Hashar: Revert "jjb: compress fresnel browser performance reports" [integration/config] - 10https://gerrit.wikimedia.org/r/677715 (https://phabricator.wikimedia.org/T249268) [10:03:59] (03PS2) 10Hashar: Revert "jjb: compress fresnel browser performance reports" [integration/config] - 10https://gerrit.wikimedia.org/r/677715 (https://phabricator.wikimedia.org/T249268) [10:04:11] is 1.36 actually being cut in the next week? [10:04:15] did I miss an email? :O [10:05:49] (03CR) 10Hashar: [C: 03+2] "I have updated mediawiki-fresnel-patch-docker" [integration/config] - 10https://gerrit.wikimedia.org/r/677715 (https://phabricator.wikimedia.org/T249268) (owner: 10Hashar) [10:07:11] (03Merged) 10jenkins-bot: Revert "jjb: compress fresnel browser performance reports" [integration/config] - 10https://gerrit.wikimedia.org/r/677715 (https://phabricator.wikimedia.org/T249268) (owner: 10Hashar) [10:09:04] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Patch-For-Review, 10Technical-Debt: Reduce size of artifacts stored on the CI Jenkins master - https://phabricator.wikimedia.org/T249268 (10hashar... [10:19:54] addshore: I don't think the 1 week warning email was sent yet [10:20:04] But it'll be soon I'd guess [10:20:22] the deploy cal seems to say next wee 1.37.wmfx is being deployed! but that could just be old? [10:20:32] No that's true [10:23:07] (03PS2) 10Daimona Eaytoy: Micro-optimization for UnusedUseStatementSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/676942 [11:09:54] (03CR) 10Umherirrender: [C: 03+2] Micro-optimization for UnusedUseStatementSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/676942 (owner: 10Daimona Eaytoy) [11:11:19] (03Merged) 10jenkins-bot: Micro-optimization for UnusedUseStatementSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/676942 (owner: 10Daimona Eaytoy) [11:19:02] (03PS6) 10Umherirrender: Include class names in UnusedUse messages [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/666893 (owner: 10Lucas Werkmeister (WMDE)) [11:19:14] (03PS7) 10Umherirrender: internal: Add return type hint to Sniff::register implementation [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/675232 [11:19:20] (03PS6) 10Umherirrender: Remove reference to T_RETURN_TYPE [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673643 [11:19:47] (03PS7) 10Umherirrender: internal: Use param and return type hint on non-inherited functions [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/675220 [11:19:57] (03PS5) 10Umherirrender: internal: Add @codeCoverageIgnore to untestable code [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673690 [11:23:29] 10Project-Admins, 10WMSE (IT): Move "Magnus Sälgö" and "so9q" to top level projects - https://phabricator.wikimedia.org/T272137 (10Lokal_Profil) >>! In T272137#6964470, @Aklapper wrote: > Thanks! > * Archived https://phabricator.wikimedia.org/project/profile/3477/ and moved all tasks to https://phabricator.wik... [12:11:26] 10LibUp, 10MediaWiki-Releasing, 10MW-1.36-release: Run libup on Branch REL1_36 - https://phabricator.wikimedia.org/T279655 (10Umherirrender) [12:11:40] 10LibUp, 10MediaWiki-Releasing, 10MW-1.36-release: Run libup on Branch REL1_36 - https://phabricator.wikimedia.org/T279655 (10Umherirrender) [12:11:42] 10MediaWiki-Releasing, 10MW-1.36-release, 10MW-1.37-notes (1.37.0-wmf.1; 2021-04-13): Branch REL1_36 for MediaWiki and all extensions and skins - https://phabricator.wikimedia.org/T279456 (10Umherirrender) [12:27:31] (03CR) 10Daimona Eaytoy: "> I seem to recall that there's a page somewhere on integration.wm.org with the historical timings of each job, but cannot find it right n" [integration/config] - 10https://gerrit.wikimedia.org/r/567938 (https://phabricator.wikimedia.org/T234020) (owner: 10Daimona Eaytoy) [12:36:14] 10phan-taint-check-plugin, 10Patch-For-Review: Optimize phan-taint-check speed - https://phabricator.wikimedia.org/T203651 (10Daimona) I managed to fix my issue with kcachegrind so I was able to load bigger cachegrind files. I also managed to profile a complete run on AbuseFilter, after removing vendor and a p... [12:52:58] (03PS1) 10Umherirrender: Zuul: [mediawiki/extensions/WikiToLDAP] Add quibble and phan job [integration/config] - 10https://gerrit.wikimedia.org/r/677874 [13:14:34] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO (2021-04-01 to 2021-06-30 (Q4)), 10Scap, 10SRE, 10Python3-Porting: Porting scap to Python 3 - https://phabricator.wikimedia.org/T279628 (10thcipriani) [13:20:39] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10SRE, 10serviceops, and 2 others: Upgrade MediaWiki clusters to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10ops-monitoring-bot) Script wmf-auto-reimage was launched by jiji on cumin1001.eqiad.wm... [14:00:39] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10SRE, 10serviceops, and 2 others: Upgrade MediaWiki clusters to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10ops-monitoring-bot) Completed auto-reimage of hosts: ` ['parse2001.codfw.wmnet'] ` an... [14:02:23] (03CR) 10Krinkle: [C: 03+2] Remove reference to T_RETURN_TYPE [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673643 (owner: 10Umherirrender) [14:04:06] (03Merged) 10jenkins-bot: Remove reference to T_RETURN_TYPE [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673643 (owner: 10Umherirrender) [14:04:08] (03CR) 10Krinkle: "> Patch Set 24:" [integration/config] - 10https://gerrit.wikimedia.org/r/567938 (https://phabricator.wikimedia.org/T234020) (owner: 10Daimona Eaytoy) [14:04:52] (03PS7) 10Umherirrender: Include class names in UnusedUse messages [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/666893 (owner: 10Lucas Werkmeister (WMDE)) [14:07:38] (03PS8) 10Umherirrender: internal: Use param and return type hint on non-inherited functions [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/675220 [14:07:42] (03PS8) 10Umherirrender: internal: Add return type hint to Sniff::register implementation [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/675232 [14:13:56] (03CR) 10Lucas Werkmeister (WMDE): [C: 03+1] Include class names in UnusedUse messages [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/666893 (owner: 10Lucas Werkmeister (WMDE)) [14:17:06] (03CR) 10Daimona Eaytoy: "> Patch Set 24:" [integration/config] - 10https://gerrit.wikimedia.org/r/567938 (https://phabricator.wikimedia.org/T234020) (owner: 10Daimona Eaytoy) [14:36:08] 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10SRE, 10puppet-compiler, and 2 others: Integrate the puppet compiler in the puppet CI pipeline - https://phabricator.wikimedia.org/T166066 (10dcaro) >>! In T166066#5039654, @hashar wrote: > We have a Jenkins job T97513 wh... [15:13:45] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "Uh, nice. Thanks a lot for the update. I wonder why I haven't done this when I wrote the sniff. Other sniffs do this already." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/666893 (owner: 10Lucas Werkmeister (WMDE)) [15:16:29] (03CR) 10AndyRussG: "> Seems unnecessary except with a very specific combo of buildkit version and existing drupal version, and not worth its own commit in any" [releng/dev-images] - 10https://gerrit.wikimedia.org/r/677381 (owner: 10Ejegg) [15:25:08] 10Release-Engineering-Team, 10Release-Engineering-Team-TODO (2021-04-01 to 2021-06-30 (Q4)), 10Release Pipeline: Profile single-version and multi-version image builds to identify bottlenecks - https://phabricator.wikimedia.org/T279323 (10dancy) Some additional measurements: # Max single threaded unbuffered... [15:29:17] (03CR) 10Jforrester: [C: 03+2] Zuul: [mediawiki/extensions/WikiToLDAP] Add quibble and phan job [integration/config] - 10https://gerrit.wikimedia.org/r/677874 (owner: 10Umherirrender) [15:30:51] (03Merged) 10jenkins-bot: Zuul: [mediawiki/extensions/WikiToLDAP] Add quibble and phan job [integration/config] - 10https://gerrit.wikimedia.org/r/677874 (owner: 10Umherirrender) [15:32:56] 10Project-Admins, 10Community-Tech: Decide what to do with "Cross-wiki watchlist" tasks - archive? - https://phabricator.wikimedia.org/T278928 (10Aklapper) Thanks a lot! [15:34:11] 10Project-Admins, 10Community-Tech: Decide what to do with "Cross-wiki watchlist" tasks - archive? - https://phabricator.wikimedia.org/T278928 (10Aklapper) 05Open→03Resolved a:03Aklapper [15:37:23] (03CR) 10AndyRussG: [C: 03+1] WIP: Added image for civiproxy (031 comment) [releng/dev-images] - 10https://gerrit.wikimedia.org/r/664919 (https://phabricator.wikimedia.org/T268683) (owner: 10Jgleeson) [15:42:44] (03PS12) 10AndyRussG: Fundraising images: Separate Mediawiki and Civi setups [releng/dev-images] - 10https://gerrit.wikimedia.org/r/663294 (https://phabricator.wikimedia.org/T262975) [15:52:50] 10Phabricator: On Maniphest task pages, show on the Task Graph the milestones each task is in - https://phabricator.wikimedia.org/T279685 (10Jdforrester-WMF) [15:56:56] 10Phabricator (Upstream), 10Upstream: On Maniphest task pages, show on the Task Graph the milestones each task is in - https://phabricator.wikimedia.org/T279685 (10Aklapper) [15:57:01] 10Phabricator (Upstream), 10Upstream: On Maniphest task pages, show on the Task Graph the milestones each task is in - https://phabricator.wikimedia.org/T279685 (10Aklapper) [15:57:42] 10Phabricator (Upstream), 10Upstream: On Maniphest task pages, show on the Task Graph the milestones each task is in - https://phabricator.wikimedia.org/T279685 (10Jdforrester-WMF) I didn't tag it as Upstream as I didn't want to decide that this is something we'd want upstream to do, or do locally. [15:57:44] !log Zuul: [mediawiki/extensions/WikiToLDAP] Add quibble and phan job [15:57:47] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [16:03:58] (03PS1) 10Lars Wirzenius: Scap version 3.17.0 [tools/scap] - 10https://gerrit.wikimedia.org/r/677940 [16:05:20] (03PS4) 10Jforrester: jjb: Provide 'bridge' and 'repo' Wikibase selenium jobs [integration/config] - 10https://gerrit.wikimedia.org/r/676107 (owner: 10Hashar) [16:06:36] (03CR) 10Ahmon Dancy: [C: 03+2] Scap version 3.17.0 [tools/scap] - 10https://gerrit.wikimedia.org/r/677940 (owner: 10Lars Wirzenius) [16:07:26] (03Merged) 10jenkins-bot: Scap version 3.17.0 [tools/scap] - 10https://gerrit.wikimedia.org/r/677940 (owner: 10Lars Wirzenius) [16:17:57] liw: hi, I've been working on the beta cluster recently so if you see any breakage when testing the new scap release there let me know or open a phab task, https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/tools/scap/+/refs/heads/master/RELEASE.md should currently be up-to-date except that you'll need to use [16:17:57] deployment-cumin.deployment-prep.eqiad.wmflabs (or .eqiad1.wikimedia.cloud) instead of deployment-cumin02.deployment-prep.eqiad.wmflabs. I'll update that document once the current set of mediawiki+deployment_server Buster updates is done [16:33:38] Majavah, ack, thanks [16:44:02] 10Phabricator, 10Developer-Advocacy (Jul-Sep 2021): Decrease issues created many years ago with no recent activity (aka stale tickets) - https://phabricator.wikimedia.org/T248034 (10Aklapper) [16:54:21] 10Release-Engineering-Team (Deployment services), 10Patch-For-Review, 10SDAW-MediaSearch (MediaSearch-ReleaseCandidate), 10Structured-Data-Backlog (Current Work), 10Wikimedia-extension-review-queue: Split MediaSearch out into its own extension - https://phabricator.wikimedia.org/T265939 (10sbassett) [16:54:54] 10Continuous-Integration-Infrastructure, 10Zuul: Move trusted user allow list out of layout.yaml and into a trusted users file which can be more easily reviewed - https://phabricator.wikimedia.org/T279594 (10Jdforrester-WMF) Right. :-( [16:56:28] 10LibUp: LibUp hasn't successfully run on AutoCreateCategoryPages for 7 weeks - https://phabricator.wikimedia.org/T275292 (10Umherirrender) 05Resolved→03Open >>! In T275292#6883979, @Legoktm wrote: > I had to manually delete the clone on the libup server so it did a fresh checkout and now we have a successfu... [16:58:49] (03CR) 10Umherirrender: [C: 03+2] "My changes are reviewed, so +2 even I have done changes here." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/666893 (owner: 10Lucas Werkmeister (WMDE)) [16:59:00] 10Continuous-Integration-Infrastructure, 10Zuul: Move trusted user allow list out of layout.yaml and into a trusted users file which can be more easily reviewed - https://phabricator.wikimedia.org/T279594 (10Legoktm) We could have a script that reformats and dumps our pretty `trusted-users.yaml` into zuul/layo... [17:02:02] (03Merged) 10jenkins-bot: Include class names in UnusedUse messages [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/666893 (owner: 10Lucas Werkmeister (WMDE)) [17:03:06] (03PS9) 10Umherirrender: internal: Add return type hint to Sniff::register implementation [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/675232 [17:03:48] (03PS3) 10Umherirrender: UnsortedUseStatementsSniff can loop on live coding/incomplete code [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/675905 [17:07:06] 10Continuous-Integration-Infrastructure, 10Zuul: Move trusted user allow list out of layout.yaml and into a trusted users file which can be more easily reviewed - https://phabricator.wikimedia.org/T279594 (10Jdforrester-WMF) >>! In T279594#6984861, @Legoktm wrote: > We could have a script that reformats and du... [17:07:15] (03PS9) 10Umherirrender: internal: Use param and return type hint on non-inherited functions [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/675220 [17:07:31] (03CR) 10Umherirrender: "Rebased" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/675220 (owner: 10Umherirrender) [17:16:19] 10MediaWiki-Releasing, 10MW-1.36-release, 10MW-1.37-notes (1.37.0-wmf.1; 2021-04-13): Branch REL1_36 for MediaWiki and all extensions and skins - https://phabricator.wikimedia.org/T279456 (10Jdforrester-WMF) [17:16:21] 10LibUp, 10MediaWiki-Releasing, 10MW-1.36-release: Run libup on Branch REL1_36 - https://phabricator.wikimedia.org/T279655 (10Jdforrester-WMF) [17:16:30] 10LibUp, 10MediaWiki-Releasing, 10MW-1.36-release: Run libup on Branch REL1_36 - https://phabricator.wikimedia.org/T279655 (10Jdforrester-WMF) [17:16:33] 10MediaWiki-Releasing, 10MW-1.36-release, 10MW-1.37-notes (1.37.0-wmf.1; 2021-04-13): Branch REL1_36 for MediaWiki and all extensions and skins - https://phabricator.wikimedia.org/T279456 (10Jdforrester-WMF) [17:26:27] (03PS6) 10Umherirrender: Add a new StaticClosureSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/662110 (https://phabricator.wikimedia.org/T274038) [17:27:11] (03CR) 10Umherirrender: Add a new StaticClosureSniff (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/662110 (https://phabricator.wikimedia.org/T274038) (owner: 10Umherirrender) [17:28:53] 10Release-Engineering-Team-TODO, 10Scap, 10serviceops: Deploy Scap version 3.17.0-1 - https://phabricator.wikimedia.org/T279695 (10LarsWirzenius) [17:29:30] 10Release-Engineering-Team-TODO, 10Scap, 10serviceops: Deploy Scap version 3.17.0-1 - https://phabricator.wikimedia.org/T279695 (10LarsWirzenius) [18:03:27] 10Scap: Scap "import scap.git" fails on beta in CI - https://phabricator.wikimedia.org/T279703 (10LarsWirzenius) [18:05:29] 10Release-Engineering-Team-TODO, 10Scap, 10serviceops: Deploy Scap version 3.17.0-1 - https://phabricator.wikimedia.org/T279695 (10LarsWirzenius) We had a problem on beta; {{T279703}}. Until that's fixed, let's not not build or deploy the 3.17.0 release. [18:20:54] 10Scap: Scap "import scap.git" fails on beta in CI - https://phabricator.wikimedia.org/T279703 (10Majavah) Running scap as `jenkins-deploy` fails differently than if I run it with my own account (`taavi`), which seems to be caused by that on deployment-deploy01 some files in `/srv/mediawiki-staging/php-master/ca... [18:27:40] dancy: how did you deploy the new scap version? `scap version` says 3.16 everywhere [18:28:46] I rolled back to 3.16 after we saw the `beta-scap-eqiad` job failures. However, the rollback to 3.16 didn't make a difference (I believe because it's using a 3.16 that was built yesterday, probably based on the master branch) [18:29:11] So as it stands I believe that all of deployment-prep is running a scap that reports itself as 3.16 but which is actually closer to 3.17. [18:29:24] ah [18:29:54] I could use some information on what exact version of the scap deb was installed as of yesterday. That would allow for a true rollback. [18:32:34] dancy: left a few notes on the crashes that I could quickly identify at https://phabricator.wikimedia.org/T279703#6985193, otherwise I'm leaving for today [18:32:57] Thanks Majavah. I'm digging into it as well. [18:54:36] 10Release-Engineering-Team (Logspam), 10VisualEditor, 10Wikimedia-production-error: TypeError: Cannot read property 'getModel' of null - https://phabricator.wikimedia.org/T279441 (10matmarex) [18:54:38] 10Release-Engineering-Team (Logspam), 10VisualEditor, 10Wikimedia-production-error: TypeError: Cannot read property 'isWrapped' of null in shallowCloneFromRange - https://phabricator.wikimedia.org/T279321 (10matmarex) [18:54:41] 10Release-Engineering-Team (Logspam), 10VisualEditor, 10Mobile, 10Wikimedia-production-error: TypeError: null is not an object (evaluating 've.init.target.tryTeardown') / TypeError: Cannot read property 'tryTeardown' of null at VeUiMWBackCommand.ve.ui.MWBackComman... - https://phabricator.wikimedia.org/T279313 [18:54:44] 10Release-Engineering-Team (Logspam), 10VisualEditor, 10Wikimedia-production-error: TypeError: Cannot read property 'canHaveChildrenNotContent' of null at VeCeSurface.ve.ce.Surface.findBlockSlug - https://phabricator.wikimedia.org/T279299 (10matmarex) [18:54:47] 10Release-Engineering-Team (Logspam), 10ContentTranslation, 10VisualEditor, 10Wikimedia-production-error: Error: Unable to parse title at ve.ce.MWImageNode.static.getDescription - https://phabricator.wikimedia.org/T279297 (10matmarex) [18:54:50] 10Release-Engineering-Team (Logspam), 10VisualEditor, 10JavaScript, 10Wikimedia-production-error: TypeError: content.parts is undefined - https://phabricator.wikimedia.org/T279215 (10matmarex) [18:54:53] 10Release-Engineering-Team (Logspam), 10VisualEditor, 10JavaScript, 10Wikimedia-production-error: TypeError: Cannot read property 'node' of undefined / Error: domNode has no ancestor with a .data( 'view' ) - https://phabricator.wikimedia.org/T279169 (10matmarex) [19:00:53] 10MediaWiki-Releasing, 10MW-1.36-release: Announce 1.36 retrospective "pencils down" and likely timeline to wikitech-l etc. - https://phabricator.wikimedia.org/T279708 (10Jdforrester-WMF) [19:03:47] Hi all – is this channel a good place to ask a question about the deployment training that's happening in a few hours? [19:03:49] 10Release-Engineering-Team (Logspam), 10VisualEditor, 10Editing-team (FY2020-21 Kanban Board), 10JavaScript, 10Wikimedia-production-error: Uncaught TypeError: Cannot read property 'node' of null (in importTable ) - https://phabricator.wikimedia.org/T262842 (10matmarex) [19:03:55] 10Release-Engineering-Team (Logspam), 10ContentTranslation, 10Editing-team (FY2020-21 Kanban Board), 10JavaScript, and 2 others: Uncaught TypeError: Cannot read property 'offsetHeight' of null - https://phabricator.wikimedia.org/T261992 (10matmarex) [19:06:04] EricGardner: uh, it is but is there a training one coming up? there was one earlier in the EU tz but I don't see another one on the calendar for today [19:06:41] 10Release-Engineering-Team (Logspam), 10VisualEditor, 10Editing-team (FY2020-21 Kanban Board), 10JavaScript, 10Wikimedia-production-error: Uncaught TypeError: Cannot read property 'node' of null (in importTable ) - https://phabricator.wikimedia.org/T262842 (10matmarex) a:03Esanders [19:06:58] 10Release-Engineering-Team (Logspam), 10ContentTranslation, 10Editing-team (FY2020-21 Kanban Board), 10JavaScript, and 2 others: Uncaught TypeError: Cannot read property 'offsetHeight' of null - https://phabricator.wikimedia.org/T261992 (10matmarex) a:03Esanders [19:08:02] oh I see, 2 am for me so in like 4 hours. [19:08:47] 10MediaWiki-Releasing, 10MW-1.36-release, 10MW-1.37-notes (1.37.0-wmf.1; 2021-04-13): Branch REL1_36 for MediaWiki and all extensions and skins - https://phabricator.wikimedia.org/T279456 (10Jdforrester-WMF) [19:09:40] Yes, this one: https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20210408T2300 [19:10:45] yeah, just on my google calendar it is of course tomorrow, not today :-D [19:10:49] 10Continuous-Integration-Infrastructure, 10Browser-Tests: Centrally look for flakey browser tests - https://phabricator.wikimedia.org/T277205 (10Addshore) Running this once more: ` ls /srv/jenkins/builds/*-selenium-*/*/log | grep -v apache | xargs cat | grep ✖ | sort | uniq -c | sort -nr ` The output can be... [19:10:58] yes this is a great channel to ask about it [19:11:24] 10Continuous-Integration-Infrastructure, 10Browser-Tests, 10User-Addshore: Centrally look for flakey browser tests - https://phabricator.wikimedia.org/T277205 (10Addshore) a:03Addshore [19:15:28] apergos: thanks! I was able to bug brennan for some of the details. I'll try to join this one even though I don't yet have production keys [19:15:59] you can learn plenty just by following the process along in the channel and in the google meetup, even if you can't be on the host doing things [19:16:21] there's a few good pages to look at on wikitech too, if you haven't been given the pointers to those already [19:17:39] https://wikitech.wikimedia.org/wiki/Backport_windows/Deployers and of course https://wikitech.wikimedia.org/wiki/Deployments/Training for tl'dr versions of a few things [19:17:44] enjoy! [19:21:40] 10MediaWiki-Releasing: Add more sanity checks to makerelease2 - https://phabricator.wikimedia.org/T270452 (10Reedy) [19:21:54] 10MediaWiki-Releasing, 10MediaWiki-Release-Tools: Add more sanity checks to makerelease2 - https://phabricator.wikimedia.org/T270452 (10Reedy) [19:25:35] 10MediaWiki-Releasing, 10MW-1.36-release, 10MW-1.37-notes (1.37.0-wmf.1; 2021-04-13): Branch REL1_36 for MediaWiki and all extensions and skins - https://phabricator.wikimedia.org/T279456 (10Jdforrester-WMF) [19:27:16] 10MediaWiki-Releasing, 10MW-1.36-release, 10MW-1.37-notes (1.37.0-wmf.1; 2021-04-13): Branch REL1_36 for MediaWiki and all extensions and skins - https://phabricator.wikimedia.org/T279456 (10Jdforrester-WMF) [19:31:01] 10MediaWiki-Releasing, 10MediaWiki-Release-Tools: Add more preflight checks to makerelease2 - https://phabricator.wikimedia.org/T270452 (10Reedy) [19:33:48] 10MediaWiki-Releasing, 10Reference Previews, 10MW-1.37-release: Bundle Popups extension with MediaWiki - https://phabricator.wikimedia.org/T231797 (10Jdforrester-WMF) [19:34:59] 10MediaWiki-Releasing, 10MediaWiki-Installer, 10MediaWiki-Stakeholders-Group, 10Epic, 10MW-1.36-release: Expand the set of bundled extensions and skins in MediaWiki 1.36 - https://phabricator.wikimedia.org/T246381 (10Jdforrester-WMF) RC.0 ships in a week or two's time. Are any of these happening? [19:36:32] 10LibUp, 10MediaWiki-Releasing, 10MW-1.36-release: Run libup on Branch REL1_36 - https://phabricator.wikimedia.org/T279655 (10Umherirrender) Would suggest that {T275937} is resolved first. [19:37:16] 10LibUp: Reduce frequency of libup non-master branch runs - https://phabricator.wikimedia.org/T275937 (10Umherirrender) +1 [19:39:51] (03PS1) 10Ahmon Dancy: Don't pass cwd="." to gitcmd() [tools/scap] - 10https://gerrit.wikimedia.org/r/678027 (https://phabricator.wikimedia.org/T279703) [19:40:51] (03CR) 10Ahmon Dancy: [C: 03+2] Don't pass cwd="." to gitcmd() [tools/scap] - 10https://gerrit.wikimedia.org/r/678027 (https://phabricator.wikimedia.org/T279703) (owner: 10Ahmon Dancy) [19:41:41] (03Merged) 10jenkins-bot: Don't pass cwd="." to gitcmd() [tools/scap] - 10https://gerrit.wikimedia.org/r/678027 (https://phabricator.wikimedia.org/T279703) (owner: 10Ahmon Dancy) [19:44:09] 10Gerrit: Can't `git pull` mediawiki/core from Gerrit: "fatal: the remote end hung up unexpectedly" - https://phabricator.wikimedia.org/T263293 (10hashar) [19:51:59] Reedy: no tags on GitHub? [19:52:09] Oh ye [19:53:20] RhinosF1: Tags always come last, because there's wrangling and stuff [19:53:28] Ah [19:53:37] I assume you'll make everything public then too [19:53:38] Especially this time around, cause I have to manage submodule bumps, that get replaced by submodule bumps done by gerrit automagically etc [19:53:44] Ah [19:53:51] Yeah, should all be public in a few hours [19:53:58] Feel free to poke later/tomorrow if I miss something [19:55:58] Will do [19:56:11] Some very interesting CVEs [19:59:02] the one I found was assigned an CVE before we realized it only applies to master, which is kind of interesting :P [20:13:04] 10MediaWiki-Releasing, 10MW-1.36-release, 10MW-1.37-notes (1.37.0-wmf.1; 2021-04-13): Branch REL1_36 for MediaWiki and all extensions and skins - https://phabricator.wikimedia.org/T279456 (10Jdforrester-WMF) [20:18:21] 10MediaWiki-Releasing, 10MW-1.36-release, 10MW-1.37-notes (1.37.0-wmf.1; 2021-04-13): Branch REL1_36 for MediaWiki and all extensions and skins - https://phabricator.wikimedia.org/T279456 (10Jdforrester-WMF) [20:37:48] 10MediaWiki-Releasing, 10Security: Tag 1.31.13/1.35.2 - https://phabricator.wikimedia.org/T270464 (10Reedy) 05Open→03Resolved a:03Reedy [20:37:50] 10MediaWiki-Releasing, 10Security: Tag 1.31.13/1.35.2 - https://phabricator.wikimedia.org/T270464 (10Reedy) [20:38:42] 10MediaWiki-Releasing, 10Security: Write and send release announcements for MediaWiki 1.31.13/1.35.2 - https://phabricator.wikimedia.org/T270461 (10Reedy) [20:39:13] 10MediaWiki-Releasing, 10Security: Obtain CVEs for 1.31.13/1.35.2 security releases - https://phabricator.wikimedia.org/T270465 (10Reedy) [21:07:45] 10LibUp, 10MediaWiki-Releasing, 10MW-1.36-release: Run libup on Branch REL1_36 - https://phabricator.wikimedia.org/T279655 (10Jdforrester-WMF) [21:07:50] 10MediaWiki-Releasing, 10MW-1.36-notes, 10MW-1.36-release, 10Platform Team Workboards (Initiatives): Release MW 1.36.0 - https://phabricator.wikimedia.org/T279455 (10Jdforrester-WMF) [21:08:01] 10MediaWiki-Releasing, 10MW-1.36-notes, 10MW-1.36-release, 10MW-1.37-notes (1.37.0-wmf.1; 2021-04-13), 10Patch-For-Review: Branch REL1_36 for MediaWiki and all extensions and skins - https://phabricator.wikimedia.org/T279456 (10Jdforrester-WMF) 05Open→03Resolved OK, this is done, though in the end we... [21:08:05] 10MediaWiki-Releasing, 10MW-1.36-notes, 10MW-1.36-release, 10MW-1.37-notes (1.37.0-wmf.1; 2021-04-13), 10Patch-For-Review: Branch REL1_36 for MediaWiki and all extensions and skins - https://phabricator.wikimedia.org/T279456 (10Jdforrester-WMF) [21:08:10] Does someone know why `Unnecessary use statement in the same namespace ` would be a new PHPCS warning on PHP 8.0, but not happen on PHP 7.x? – https://github.com/Krinkle/intuition/runs/2300723183?check_suite_focus=true [21:08:18] kind of scratching my head over this one for a while now [21:09:55] 10MediaWiki-Releasing, 10Security: Tracking bug for MediaWiki 1.31.13/1.35.2 - https://phabricator.wikimedia.org/T270459 (10Reedy) [21:10:06] 10MediaWiki-Releasing, 10Security: Tracking bug for MediaWiki 1.31.13/1.35.2 - https://phabricator.wikimedia.org/T270459 (10Reedy) 05Open→03Resolved a:03Reedy [21:10:41] 10MediaWiki-Releasing, 10Security: Release MediaWiki 1.31.13/1.35.2 - https://phabricator.wikimedia.org/T270458 (10Reedy) [21:11:00] 10MediaWiki-Releasing, 10Security: Update onwiki release notes for 1.31.13/1.31.14/1.35.2 - https://phabricator.wikimedia.org/T270462 (10Reedy) [21:11:14] 10MediaWiki-Releasing, 10Security: Update HISTORY in master after 1.31.13/1.31.14/1.35.2 - https://phabricator.wikimedia.org/T270463 (10Reedy) [21:12:44] 10Release-Engineering-Team, 10MediaWiki-Release-Tools: Branch script doesn't respect `branchpoint` when creating submodules, resulting in "implicit merges" error from gerrit - https://phabricator.wikimedia.org/T279718 (10Jdforrester-WMF) [21:18:57] 10phan, 10MediaWiki-Vendor, 10MW-1.36-release: REL1_36 doesn't pass phan; PhanUndeclaredExtendedClass for Doctrine\DBAL\Platforms\PostgreSqlPlatform - https://phabricator.wikimedia.org/T279719 (10Jdforrester-WMF) [21:24:00] 10MediaWiki-Releasing, 10MW-1.36-release: Announce 1.36 retrospective "pencils down" and likely timeline to wikitech-l etc. - https://phabricator.wikimedia.org/T279708 (10Jdforrester-WMF) Draft ready to send at the bottom of https://etherpad.wikimedia.org/p/1.36-release [21:25:16] 10MediaWiki-Releasing, 10Security: Tracking bug for MediaWiki 1.31.13/1.35.2 - https://phabricator.wikimedia.org/T270459 (10Reedy) [22:25:25] 10MediaWiki-Releasing, 10Security: Update onwiki release notes for 1.31.13/1.31.14/1.35.2 - https://phabricator.wikimedia.org/T270462 (10Reedy) 05Open→03Resolved a:03Reedy [22:25:27] 10MediaWiki-Releasing, 10Security: Release MediaWiki 1.31.13/1.35.2 - https://phabricator.wikimedia.org/T270458 (10Reedy) [22:28:57] (03PS1) 10Brennen Bearnes: WIP: backports/stage.py - stage patches for deployment [tools/release] - 10https://gerrit.wikimedia.org/r/678084 [22:37:56] 10phan, 10MediaWiki-Vendor, 10MW-1.36-release: REL1_36 doesn't pass phan; PhanUndeclaredExtendedClass for Doctrine\DBAL\Platforms\PostgreSqlPlatform - https://phabricator.wikimedia.org/T279719 (10Reedy) doctrine/dbal is a dev only package... I'm guessing something like b80b8230c40ade84d221364fb48732a4d72aa7... [22:39:41] 10phan, 10MediaWiki-Vendor, 10MW-1.36-release: REL1_36 doesn't pass phan; PhanUndeclaredExtendedClass for Doctrine\DBAL\Platforms\PostgreSqlPlatform - https://phabricator.wikimedia.org/T279719 (10Reedy) And {e563b680ca048965eb03c9ba2a00c8134e149756} [22:52:12] 10MediaWiki-Releasing, 10Security: Update HISTORY in master after 1.31.13/1.31.14/1.35.2 - https://phabricator.wikimedia.org/T270463 (10Reedy) 05Open→03Resolved a:03Reedy [22:52:14] 10MediaWiki-Releasing, 10Patch-For-Review, 10Security: Release MediaWiki 1.31.13/1.35.2 - https://phabricator.wikimedia.org/T270458 (10Reedy) [23:22:19] 10Scap: Scap "import scap.git" fails on beta in CI - https://phabricator.wikimedia.org/T279703 (10dancy) 05Open→03Resolved [23:27:34] 10Release-Engineering-Team-TODO (2021-04-01 to 2021-06-30 (Q4)), 10Release, 10Train Deployments: 1.36.0-wmf.38 deployment blockers - https://phabricator.wikimedia.org/T278344 (10dduvall) 05Open→03Resolved [23:50:51] (03PS1) 10Ahmon Dancy: Add descriptions to scap-beta-deb and beta-* jobs [integration/config] - 10https://gerrit.wikimedia.org/r/678123 [23:52:54] (03PS2) 10Ahmon Dancy: Add descriptions to scap-beta-deb and beta-* jobs [integration/config] - 10https://gerrit.wikimedia.org/r/678123