[00:04:43] (03PS1) 10Ahmon Dancy: beta-scap-eqiad: Run scap version before scap sync-world [integration/config] - 10https://gerrit.wikimedia.org/r/678126 [00:08:34] (03CR) 10Ahmon Dancy: [C: 03+2] beta-scap-eqiad: Run scap version before scap sync-world [integration/config] - 10https://gerrit.wikimedia.org/r/678126 (owner: 10Ahmon Dancy) [00:10:59] (03Merged) 10jenkins-bot: beta-scap-eqiad: Run scap version before scap sync-world [integration/config] - 10https://gerrit.wikimedia.org/r/678126 (owner: 10Ahmon Dancy) [00:13:41] 10phan, 10MediaWiki-Vendor, 10MW-1.36-release, 10Patch-For-Review: REL1_36 doesn't pass phan; PhanUndeclaredExtendedClass for Doctrine\DBAL\Platforms\PostgreSqlPlatform - https://phabricator.wikimedia.org/T279719 (10Reedy) 05Open→03Resolved a:03Reedy [00:19:55] 10Release-Engineering-Team-TODO (2021-04-01 to 2021-06-30 (Q4)), 10Release, 10Train Deployments: 1.37.0-wmf.1 deployment blockers - https://phabricator.wikimedia.org/T278345 (10Etonkovidova) [00:57:09] 10MediaWiki-Releasing, 10MediaWiki-Vendor, 10MW-1.36-notes, 10MW-1.36-release: Prune /vendor for REL1_36 - https://phabricator.wikimedia.org/T279460 (10Jdforrester-WMF) 05Open→03Resolved a:03Reedy [00:57:12] 10MediaWiki-Releasing, 10MW-1.36-notes, 10MW-1.36-release, 10Platform Team Workboards (Initiatives): Release MW 1.36.0 - https://phabricator.wikimedia.org/T279455 (10Jdforrester-WMF) [01:03:17] (03CR) 10Jforrester: "Nice." [integration/config] - 10https://gerrit.wikimedia.org/r/678123 (owner: 10Ahmon Dancy) [01:13:26] OK, so, I figured out the weird "unused use" warning. There was something about PHP 8.0 an mediawiki-codesniffer < 32 that made it treat each and every use statement as unused for no reason. [01:13:55] krinkle/intuition is now passing on php 8.0 https://github.com/Krinkle/intuition/commit/a13c879bfa54caa617fb9cee33b1125848f23a87 [01:14:16] James_F: btw, here's a sight for sore eyes https://github.com/Krinkle/intuition/blob/main/package-lock.json [01:14:21] noting this is a lock file. [01:18:21] Krinkle: do you even need tests/banana-checker.js? banana-checker has a CLI [01:20:57] I know, I vaguely recall writing that :P [01:21:10] but I don't think it supports multiple directories [01:21:22] there was something I had to do here that was unusual and didn't work with the CLI [01:21:34] this contains many unrelated message groups [01:22:02] and three directories with slightly different options [01:22:07] but only because they have legacy issues [01:22:16] which I don't maintain [01:22:28] for any realistic consumer, they would not need different configs within the same repo I think [01:22:59] thought maybe we could call the CLI twice [01:23:28] but hey, at least it's not a bash script [01:23:43] I do learn, with time :) [01:24:27] In other news, it seems the github repo we use with github CI and php, is using a node.js process with webpack-compiled code in order to install php from apt-get [01:24:34] Yeah, we use grunt for the globbing. [01:25:02] I looked at that and thought, there has to be a better way. https://github.com/shivammathur/setup-php/tree/master/dist [01:25:13] Krinkle: Sounds about right for Modern Web Scale®™ technology solutions. ;-) [01:25:22] turns out, the github ci ubuntu images etc already have all versions of php pre-installed [01:25:31] so however made this either made it before they did that, or didn't bother reading the manual [01:25:43] and then half the world just copied that [01:26:28] the issue I ran into trying it at first is that it meant it would dip into three differnt contains with different compilations of and extensions since they have every step in its own container. [01:26:41] but for intuition I found a way to not use any of that, seems much simpler [01:26:57] https://github.com/Krinkle/intuition/blob/main/.github/workflows/CI.yaml#L12-L32 [01:27:09] just one update-alterantives call to set up the symlink from 'php' to phpN.M' [01:27:21] uses deb.sury I think [01:28:02] composer is pre-installed too, version 2 even [02:27:19] https://github.com/wikimedia/composer-merge-plugin/pull/215 [02:29:52] heh [02:32:29] Krinkle: I still blame legoktm [02:33:22] What is also funny, is all that overhead is still faster than travis [02:34:33] I'm sorry [02:35:00] heh [02:52:40] 10Release-Engineering-Team-TODO, 10MediaWiki-Release-Tools, 10MW-1.35-release: mediawiki/extensions and mediawiki/skins missing the REL1_35 and REL1_36 branches - https://phabricator.wikimedia.org/T264365 (10Jdforrester-WMF) [02:52:54] 10Release-Engineering-Team-TODO, 10MediaWiki-Release-Tools, 10MW-1.35-release: mediawiki/extensions and mediawiki/skins missing the REL1_35 and REL1_36 branches - https://phabricator.wikimedia.org/T264365 (10Jdforrester-WMF) We didn't fix this for REL1_36, it turns out. [03:29:54] (03PS25) 10Jforrester: dockerfiles: [quibble*] Add pcov and use it for test coverage [integration/config] - 10https://gerrit.wikimedia.org/r/567938 (https://phabricator.wikimedia.org/T234020) (owner: 10Daimona Eaytoy) [03:29:59] (03CR) 10Jforrester: [C: 03+2] dockerfiles: [quibble*] Add pcov and use it for test coverage [integration/config] - 10https://gerrit.wikimedia.org/r/567938 (https://phabricator.wikimedia.org/T234020) (owner: 10Daimona Eaytoy) [03:31:05] (03Merged) 10jenkins-bot: dockerfiles: [quibble*] Add pcov and use it for test coverage [integration/config] - 10https://gerrit.wikimedia.org/r/567938 (https://phabricator.wikimedia.org/T234020) (owner: 10Daimona Eaytoy) [03:32:08] !log Docker: Publishing new quibble images with pcov instead of xdebug for test coverage T234080 [03:32:12] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [03:43:21] (03PS1) 10Jforrester: jjb: Switch quibble jobs to images using pcov not xdebug [integration/config] - 10https://gerrit.wikimedia.org/r/678141 (https://phabricator.wikimedia.org/T234020) [05:31:31] 10LibUp, 10User-DannyS712: "build: Updating y18n to 3.2.2" commits didn't all work properly - https://phabricator.wikimedia.org/T278857 (10Legoktm) LibUp just runs `npm audit fix`, sometimes the endpoint it hits is buggy. What does having an empty URL even mean in practice? Those repos are no longer listed o... [05:32:06] 10LibUp: LibUp doesn't use enough memes - https://phabricator.wikimedia.org/T277418 (10Legoktm) [05:35:16] Hi folks, I'm interested in populating scholarly WikiData with metadata with papers from arXiv.org. I want to do it properly with a real ETL process that runs daily rather than with a one-time script. I've done some digging and found this Wikidata ETL grant - https://meta.wikimedia.org/wiki/Grants:Project/MFFUK/Wikidata_%26_ETL that gave money to [05:35:17] these folks - https://github.com/linkedpipes/etl . I also found this Phabricator issue: https://secure.phabricator.com/T1562 . However, I can't find some central Git repo I can branch and make a pull request to in order to add my own ETL process. Hoping someone here can point me in the right direction... [05:40:20] NameVariant: I'm not sure how you ended up here, but I'd suggest asking/discussing in #wikidata [05:43:53] legoktm: Thanks for the pointer, I'll go ask there. I ended up here because you guys are the ones with the CI/CD pipeline :D [05:44:23] Wikidata has its own bot process [05:47:56] somehow a "bot process" doesn't sound as promising as a "properly reviewed Git repo with continuous integration and deployment" but I'll try to keep an open mind :D [05:48:23] 10LibUp: LibUp hasn't successfully run on AutoCreateCategoryPages for 7 weeks - https://phabricator.wikimedia.org/T275292 (10Legoktm) ` Apr 09 05:43:01 upgrader-06 libup-celery[619]: From https://gerrit-replica.wikimedia.org/r/mediawiki/extensions/AutoCreateCategoryPages Apr 09 05:43:01 upgrader-06 libup-celery[... [05:57:25] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO: Gerrit: default branch for new projects should be "main" - https://phabricator.wikimedia.org/T279612 (10Legoktm) Agreed with @Aklapper - plenty of tooling relies on the `master` branch. We should rename everything a... [06:00:56] 10LibUp, 10Patch-For-Review: Reduce frequency of libup non-master branch runs - https://phabricator.wikimedia.org/T275937 (10Legoktm) 05Open→03Resolved a:03Legoktm [06:08:58] 10LibUp, 10MediaWiki-Releasing, 10MW-1.36-release, 10Patch-For-Review: Run libup on Branch REL1_36 - https://phabricator.wikimedia.org/T279655 (10Legoktm) 05Open→03Resolved a:03Jdforrester-WMF The first REL1_36 run will be on Saturday. Also in the future I think LibUp config can have the branch added... [06:53:57] (03CR) 10Legoktm: [C: 03+2] internal: Use param and return type hint on non-inherited functions [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/675220 (owner: 10Umherirrender) [06:54:39] (03CR) 10Legoktm: [C: 03+2] UnsortedUseStatementsSniff can loop on live coding/incomplete code [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/675905 (owner: 10Umherirrender) [06:55:00] (03CR) 10Legoktm: [C: 03+2] internal: Add return type hint to Sniff::register implementation [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/675232 (owner: 10Umherirrender) [06:55:29] (03Merged) 10jenkins-bot: internal: Use param and return type hint on non-inherited functions [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/675220 (owner: 10Umherirrender) [06:56:13] (03Merged) 10jenkins-bot: UnsortedUseStatementsSniff can loop on live coding/incomplete code [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/675905 (owner: 10Umherirrender) [07:17:01] 10LibUp: composer test command cleanup where they use `composer foo` - https://phabricator.wikimedia.org/T278635 (10Legoktm) [08:49:43] 10VPS-project-Codesearch: Move codesearch to cinder - https://phabricator.wikimedia.org/T279763 (10Legoktm) [08:55:30] 10VPS-project-Codesearch: Move codesearch to cinder - https://phabricator.wikimedia.org/T279763 (10Legoktm) current usage of `/srv`: ` /dev/mapper/vd-second--local--disk 60G 40G 18G 69% /srv ` and inodes: ` /dev/mapper/vd-second--local--disk 3.9M 3.2M 658K 84% /srv ` I think allocating 60G is rea... [09:03:51] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), 10Platform Engineering, 10Goal, 10Patch-For-Review: Decide timing of the automatic mediawiki branch cut - https://phabricator.wikimedia.org/T242446 (10awight) [09:21:18] 10Gerrit: Can't `git pull` mediawiki/core from Gerrit: "fatal: the remote end hung up unexpectedly" - https://phabricator.wikimedia.org/T263293 (10hashar) [09:26:03] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO: Can't `git pull` mediawiki/core from Gerrit: "fatal: the remote end hung up unexpectedly" SSH_MSG_CHANNEL_WINDOW_ADJUST - https://phabricator.wikimedia.org/T263293 (10hashar) Not much we can do ourselves but that ha... [09:26:21] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO: Can't `git pull` mediawiki/core from Gerrit: "fatal: the remote end hung up unexpectedly" SSH_MSG_CHANNEL_WINDOW_ADJUST - https://phabricator.wikimedia.org/T263293 (10hashar) p:05Triage→03Medium [09:51:25] !log deleting deployment-jobrunner03 T278664 [09:51:30] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [09:51:30] T278664: Upgrade deployment-prep MediaWiki clusters to Buster - https://phabricator.wikimedia.org/T278664 [09:52:07] 10Beta-Cluster-Infrastructure, 10User-Majavah: Upgrade deployment-prep MediaWiki clusters to Buster - https://phabricator.wikimedia.org/T278664 (10Majavah) [09:52:34] (03CR) 10Thiemo Kreuz (WMDE): "\o/" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/606157 (owner: 10Thiemo Kreuz (WMDE)) [09:54:55] 10VPS-project-Codesearch, 10Patch-For-Review: Move codesearch to cinder - https://phabricator.wikimedia.org/T279763 (10Legoktm) codesearch8 is probably going to take another hour to finish bootstrapping. tomorrow I'll merge https://gerrit.wikimedia.org/r/c/operations/puppet/+/678216/ do some tests and try swit... [09:59:20] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "I was reading the changelog but couldn't spot anything that sounds like it can affect us in a negative way. Basically only bugfixes and ad" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/678211 (owner: 10Umherirrender) [11:25:43] 10Continuous-Integration-Config, 10Wikidata, 10Wikidata Query Builder, 10wdwb-tech: Add branch hosting to Query Builder integration pipline - https://phabricator.wikimedia.org/T278706 (10Michael) p:05Triage→03Medium Similarly to T278705, this also was functionality that we used to have on GitHub and lo... [12:41:41] 10Continuous-Integration-Config, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO, 10Patch-For-Review, 10Test-Coverage: Switch mediawiki code coverage from xdebug to pcov - https://phabricator.wikimedia.org/T234020 (10Daimona) Memo: I missed [[https://codesearch.wmcloud... [12:43:12] 10Phabricator: Understand which Phab forms are used how often (by analyzing referer logs?) - https://phabricator.wikimedia.org/T268886 (10Aklapper) a:03Aklapper [12:47:00] 10Phabricator: Understand which Phab forms are used how often (by analyzing referer logs?) - https://phabricator.wikimedia.org/T268886 (10Aklapper) I've set up a panel in Logstash for the last 3mo at https://logstash.wikimedia.org/app/dashboards#/view/b20f37b0-992a-11eb-85b7-9d1831ce7631 . Basically: `url.domain... [12:51:49] (03CR) 10Addshore: [C: 03+2] "Checked with `check experimental` at https://integration.wikimedia.org/ci/job/mwext-php72-phan-docker/105454/console and its green, so LGT" [integration/config] - 10https://gerrit.wikimedia.org/r/673503 (https://phabricator.wikimedia.org/T277750) (owner: 10WMDE-leszek) [12:51:59] (03CR) 10jerkins-bot: [V: 04-1] Run phan on changes onto Wikibase REL1_35 branch [integration/config] - 10https://gerrit.wikimedia.org/r/673503 (https://phabricator.wikimedia.org/T277750) (owner: 10WMDE-leszek) [12:53:04] 10Phabricator: Understand which Phab forms are used how often (by analyzing referer logs?) - https://phabricator.wikimedia.org/T268886 (10Aklapper) Phab task forms access stats between 2021-01-09 to 2021-04-09 (does not include disabled forms): {P15269} [12:55:34] (03PS3) 10Addshore: Run phan on changes onto Wikibase REL1_35 branch [integration/config] - 10https://gerrit.wikimedia.org/r/673503 (https://phabricator.wikimedia.org/T277750) (owner: 10WMDE-leszek) [12:57:08] (03PS1) 10Addshore: Run phan on changes onto Wikibase REL1_36 branch [integration/config] - 10https://gerrit.wikimedia.org/r/678242 (https://phabricator.wikimedia.org/T277750) [12:57:28] (03CR) 10Addshore: [C: 03+2] Run phan on changes onto Wikibase REL1_35 branch [integration/config] - 10https://gerrit.wikimedia.org/r/673503 (https://phabricator.wikimedia.org/T277750) (owner: 10WMDE-leszek) [12:57:42] (03CR) 10Addshore: [C: 03+2] Run phan on changes onto Wikibase REL1_36 branch [integration/config] - 10https://gerrit.wikimedia.org/r/678242 (https://phabricator.wikimedia.org/T277750) (owner: 10Addshore) [12:58:46] (03Merged) 10jenkins-bot: Run phan on changes onto Wikibase REL1_35 branch [integration/config] - 10https://gerrit.wikimedia.org/r/673503 (https://phabricator.wikimedia.org/T277750) (owner: 10WMDE-leszek) [12:58:48] (03Merged) 10jenkins-bot: Run phan on changes onto Wikibase REL1_36 branch [integration/config] - 10https://gerrit.wikimedia.org/r/678242 (https://phabricator.wikimedia.org/T277750) (owner: 10Addshore) [12:59:29] !log reload zuul for https://gerrit.wikimedia.org/r/673503 and https://gerrit.wikimedia.org/r/678242 T277750 phan for wikibase release branches [12:59:34] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [12:59:34] T277750: Enable more tests for REL1_35 Wikibase - https://phabricator.wikimedia.org/T277750 [13:33:49] (03CR) 10Umherirrender: "> Patch Set 1: Code-Review+1" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/678211 (owner: 10Umherirrender) [13:37:26] 10Phabricator: Phab Forms 70 and 81 look like duplicates of form 47 - https://phabricator.wikimedia.org/T279785 (10Aklapper) p:05Triage→03Lowest [13:38:25] 10Phabricator: Understand which Phab forms are used how often (by analyzing referer logs?) - https://phabricator.wikimedia.org/T268886 (10Aklapper) [13:38:28] 10Phabricator, 10Developer-Advocacy (Apr-Jun 2021): Review the default options in Phab's Favorites menu; offer dedicated forms for bug reports vs feature requests? - https://phabricator.wikimedia.org/T253744 (10Aklapper) [13:41:14] 10Phabricator, 10Developer-Advocacy (Apr-Jun 2021): Understand which Phab forms are used how often (by analyzing referer logs?) - https://phabricator.wikimedia.org/T268886 (10Aklapper) 05Open→03Resolved Done here; to be continued in T253744. [13:41:16] 10Phabricator, 10Developer-Advocacy (Apr-Jun 2021): Review the default options in Phab's Favorites menu; offer dedicated forms for bug reports vs feature requests? - https://phabricator.wikimedia.org/T253744 (10Aklapper) [13:52:50] 10Phabricator, 10Developer-Advocacy (Apr-Jun 2021): Review the default options in Phab's Favorites menu; offer dedicated forms for bug reports vs feature requests? - https://phabricator.wikimedia.org/T253744 (10Aklapper) Looked at task forms and gathering task form stats in T268886: * Form 43 is the "bug repor... [13:55:05] 10Phabricator, 10Developer-Advocacy (Apr-Jun 2021): Improve initial Phab task quality: Encourage use of bug report/feature request task subtypes; Review default options in Favorites menu - https://phabricator.wikimedia.org/T253744 (10Aklapper) 05Stalled→03Open [15:25:13] 10Phabricator, 10PM: Decrease high/medium Priority value of open tasks after being still open after a longer time - https://phabricator.wikimedia.org/T279788 (10Aklapper) p:05Triage→03Lowest [15:28:30] 10LibUp: LibUp hasn't successfully run on AutoCreateCategoryPages for 7 weeks - https://phabricator.wikimedia.org/T275292 (10Umherirrender) It is possible that the delete of the branch in T275946 does not get published to the replica and pull from there still fails? [15:31:30] 10Release-Engineering-Team-TODO (2021-04-01 to 2021-06-30 (Q4)), 10Release, 10Train Deployments: 1.37.0-wmf.1 deployment blockers - https://phabricator.wikimedia.org/T278345 (10Lucas_Werkmeister_WMDE) >>! In T278345#6980879, @Lucas_Werkmeister_WMDE wrote: > Nonrisky change: we added a hard deprecation to Wik... [16:51:55] 10MediaWiki-Codesniffer, 10User-DannyS712: Autofix for switch indentation adds indentation to the wrong places - https://phabricator.wikimedia.org/T266739 (10Umherirrender) >>! In T266739#6607442, @Umherirrender wrote: >>>! In T266739#6601145, @Umherirrender wrote: >> upstream reported - https://github.com/squ... [16:52:35] 10MediaWiki-Codesniffer, 10MW-1.35-notes, 10MW-1.36-notes (1.36.0-wmf.1; 2020-07-21), 10Patch-For-Review: Require indentation of CASE statements in PHP code - https://phabricator.wikimedia.org/T182546 (10Umherirrender) >>! In T182546#6589245, @Huji wrote: > Reopening so the parties involved can decide if a... [17:17:58] 10Project-Admins, 10InternetArchiveBot: Disable issues on InternetArchiveBot GitHub repository - https://phabricator.wikimedia.org/T279767 (10Aklapper) [18:02:43] 10Phabricator, 10Security-Team: Enable risk rating field in Phabricator's task form - https://phabricator.wikimedia.org/T279690 (10sguebo_WMF) Hello @Aklapper, Originally I was interested in having the risk rating field being added to [[ https://phabricator.wikimedia.org/transactions/editengine/maniphest.tas... [18:39:46] !log Logstash in beta has no messages for 24 hours. [18:39:49] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [18:40:13] for mediawiki* [18:41:20] !log Logstash in beta shows no messages from mediawiki for 24 hours, T233134. [18:41:23] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [18:41:23] T233134: logstash-beta.wmflabs.org does not receive any mediawiki events - https://phabricator.wikimedia.org/T233134 [18:41:52] Krinkle: hasn't had for weeks now :/ [20:50:29] 10Phabricator, 10Security-Team: Enable risk rating field in Phabricator's task form - https://phabricator.wikimedia.org/T279690 (10Aklapper) The "Risk Rating" field in form 73 got locked by Chase in https://phabricator.wikimedia.org/transactions/editengine/maniphest.task/view/73/#1620 for reasons that I do not... [22:05:06] James_F: nice regarding unused eslint directive via config. https://eslint.org/blog/2019/08/eslint-v6.3.0-released#eslint-v630-released [22:05:10] that wasn't possible before [22:05:32] ( https://gerrit.wikimedia.org/r/c/mediawiki/extensions/NavigationTiming/+/677945 ) [22:42:23] Krinkle: Yeah, Ed spotted it and we implemented it in v0.15.0 https://github.com/wikimedia/eslint-config-wikimedia/commit/8064f94732a0f2c2ba0953457b6981d662752869 [22:43:02] oh, that was a while ago [22:43:05] you guys were early [22:43:19] nice [22:43:25] Yeah, but I forgot to do clean-up until Ed pointed it out yesterday. [23:50:08] 10MediaWiki-Releasing, 10MediaWiki-Release-Tools: Add more preflight checks to makerelease2 - https://phabricator.wikimedia.org/T270452 (10Legoktm) Initially I thought we could just run the CI phan docker image, but we don't actually have the development composer dependencies checked out. My new idea is we bu...