[00:08:37] 10MediaWiki-Codesniffer, 10MW-1.35-notes, 10MW-1.36-notes (1.36.0-wmf.1; 2020-07-21), 10Patch-For-Review: Require indentation of CASE statements in PHP code - https://phabricator.wikimedia.org/T182546 (10Huji) @Umherirrender what about what @DannyS712 said in T182546#6589546? [05:22:53] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Patch-For-Review, 10Technical-Debt: Reduce size of artifacts stored on the CI Jenkins master - https://phabricator.wikimedia.org/T249268 (10Func)... [07:11:32] 10MediaWiki-Codesniffer: ValidGlobalNameSniff assumes that allowed global variable name prefix alway consists of two characters - https://phabricator.wikimedia.org/T279814 (10alex-mashin) [07:11:53] 10MediaWiki-Codesniffer: ValidGlobalNameSniff assumes that allowed global variable name prefix always consists of two characters - https://phabricator.wikimedia.org/T279814 (10alex-mashin) [07:29:05] 10Phabricator: Merge the Phabricator Priority values "Low" and "Lowest" - https://phabricator.wikimedia.org/T228759 (10Aklapper) How often each non-initial "Priority" field value got set/changed within last 12 months by those 76 users who set/changed the "Priority" field ≥50 times within last 12 months: | Prior... [07:35:38] (03PS1) 10Alex Mashin: Allow non-two-characters prefixes for global variables [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/678304 (https://phabricator.wikimedia.org/T279814) [07:36:27] 10MediaWiki-Codesniffer, 10Patch-For-Review: ValidGlobalNameSniff assumes that allowed global variable name prefix always consists of two characters - https://phabricator.wikimedia.org/T279814 (10alex-mashin) a:03alex-mashin [07:38:38] 10Phabricator, 10PM: Decrease high/medium Priority value of open tasks after being still open after a longer time - https://phabricator.wikimedia.org/T279788 (10Aklapper) > I'm also aware that this idea is about dealing with symptoms and not with root problems. For the root problem, see the stats in T228759#... [07:41:53] (03PS2) 10Alex Mashin: Allow non-two-characters prefixes for global variables [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/678304 (https://phabricator.wikimedia.org/T279814) [07:44:04] (03PS3) 10Alex Mashin: Allow non-two-characters prefixes for global variables [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/678304 (https://phabricator.wikimedia.org/T279814) [07:48:00] (03PS4) 10Alex Mashin: Allow non-two-characters prefixes for global variables [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/678304 (https://phabricator.wikimedia.org/T279814) [09:46:47] 10Phabricator, 10PM: Merge the Phabricator Priority values "Low" and "Lowest" - https://phabricator.wikimedia.org/T228759 (10Aklapper) [10:12:22] 10Release-Engineering-Team (CI & Testing services), 10Pywikibot: TRAVIS jobs cannot be restarted anymore - https://phabricator.wikimedia.org/T279817 (10Xqt) [10:31:47] (03PS2) 10Xqt: [CR] Add Meno25 to &email_allowlist list to enable Pywikibot flake8 tests [integration/config] - 10https://gerrit.wikimedia.org/r/676780 [14:47:14] 10Phabricator: "The owner of a task can always view and edit it." is either wrong or confusing language - https://phabricator.wikimedia.org/T279827 (10AlexisJazz) [14:47:37] 10Phabricator: "The owner of a task can always view and edit it." is confusing - https://phabricator.wikimedia.org/T279827 (10AlexisJazz) [14:49:44] 10Phabricator: "The owner of a task can always view and edit it." is confusing - https://phabricator.wikimedia.org/T279827 (10AlexisJazz) [14:56:52] 10Phabricator: "The owner of a task can always view and edit it." is confusing - https://phabricator.wikimedia.org/T279827 (10Krenair) I would assume the owner of a task is the assignee, not the author. [14:58:35] 10Phabricator: "The owner of a task can always view and edit it." is confusing - https://phabricator.wikimedia.org/T279827 (10RhinosF1) The default policy when escalating to a security policy includes task author. That simply means though whoever made it private either did it manually and forgot or isn't using t... [14:59:55] 10Phabricator: "The owner of a task can always view and edit it." is confusing - https://phabricator.wikimedia.org/T279827 (10AlexisJazz) >>! In T279827#6988589, @Krenair wrote: > I would assume the owner of a task is the assignee, not the author. I guess that needs clarification as well in that case as at leas... [15:00:33] 10Phabricator: "The owner of a task can always view and edit it." is confusing - https://phabricator.wikimedia.org/T279827 (10Majavah) >>! In T279827#6988590, @RhinosF1 wrote: > The default policy when escalating to a security policy includes task author. That simply means though whoever made it private either... [15:01:28] Majavah: by standard security I meant when you use the file sec issue or protect as sec issue button [15:01:35] Which use #acl*security [15:01:48] But yeah if they've used a WMF-nda button that might explain it [15:04:23] RhinosF1: yeah I got what you mean [15:12:51] 10Phabricator: "The owner of a task can always view and edit it." is confusing - https://phabricator.wikimedia.org/T279827 (10AlexisJazz) >>! In T279827#6988593, @Majavah wrote: > > >>>! In T279827#6988590, @RhinosF1 wrote: >> The default policy when escalating to a security policy includes task author. That s... [16:10:57] (03PS5) 10Alex Mashin: Allow non-two-characters prefixes for global variables [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/678304 (https://phabricator.wikimedia.org/T279814) [17:22:05] (03CR) 10Jforrester: "Does this work? MediaWiki 1.35 requires PHP 7.3.19+." [integration/config] - 10https://gerrit.wikimedia.org/r/673503 (https://phabricator.wikimedia.org/T277750) (owner: 10WMDE-leszek) [17:22:28] (03CR) 10Jforrester: "(Same as parent patch.)" [integration/config] - 10https://gerrit.wikimedia.org/r/678242 (https://phabricator.wikimedia.org/T277750) (owner: 10Addshore) [17:24:58] (03PS3) 10Jforrester: Zuul: Add Meno25 to &email_allowlist list [integration/config] - 10https://gerrit.wikimedia.org/r/676780 (owner: 10Xqt) [17:25:03] (03CR) 10Jforrester: [C: 03+2] Zuul: Add Meno25 to &email_allowlist list [integration/config] - 10https://gerrit.wikimedia.org/r/676780 (owner: 10Xqt) [17:26:21] (03Merged) 10jenkins-bot: Zuul: Add Meno25 to &email_allowlist list [integration/config] - 10https://gerrit.wikimedia.org/r/676780 (owner: 10Xqt) [17:28:00] (03CR) 10Jforrester: "So, I made the classic mistake here; php7.2-pcov doesn't exist as a package anywhere, AFAICT. So this has built find for PHP 7.3+, but fai" [integration/config] - 10https://gerrit.wikimedia.org/r/567938 (https://phabricator.wikimedia.org/T234020) (owner: 10Daimona Eaytoy) [17:33:05] (03PS1) 10Jforrester: Revert "dockerfiles: [quibble*] Add pcov and use it for test coverage" [integration/config] - 10https://gerrit.wikimedia.org/r/678346 [17:35:08] (03PS2) 10Jforrester: Revert "dockerfiles: [quibble*] Add pcov and use it for test coverage" [integration/config] - 10https://gerrit.wikimedia.org/r/678346 [17:35:18] (03PS3) 10Jforrester: Partial revert "dockerfiles: [quibble*] Add pcov and use it for test coverage" [integration/config] - 10https://gerrit.wikimedia.org/r/678346 [17:35:30] (03PS4) 10Jforrester: Partial revert "dockerfiles: [quibble*] Add pcov and use it for test coverage" [integration/config] - 10https://gerrit.wikimedia.org/r/678346 [17:35:33] (03CR) 10Jforrester: [C: 03+2] Partial revert "dockerfiles: [quibble*] Add pcov and use it for test coverage" [integration/config] - 10https://gerrit.wikimedia.org/r/678346 (owner: 10Jforrester) [17:35:54] (03CR) 10Jforrester: [C: 04-2] jjb: Switch quibble jobs to images using pcov not xdebug [integration/config] - 10https://gerrit.wikimedia.org/r/678141 (https://phabricator.wikimedia.org/T234020) (owner: 10Jforrester) [17:36:34] !log Zuul: Add Meno25 to &email_allowlist list [17:36:38] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [17:36:42] (03Merged) 10jenkins-bot: Partial revert "dockerfiles: [quibble*] Add pcov and use it for test coverage" [integration/config] - 10https://gerrit.wikimedia.org/r/678346 (owner: 10Jforrester) [17:49:31] 10Phabricator: "The owner of a task can always view and edit it." is confusing - https://phabricator.wikimedia.org/T279827 (10Aklapper) p:05Triage→03Low Yes the task is/was valid, thanks for reporting it. :) [17:51:42] 10MediaWiki-Releasing, 10MediaWiki-Release-Tools: Add more preflight checks to makerelease2 - https://phabricator.wikimedia.org/T270452 (10Jdforrester-WMF) I'm minded to trust phan a fair bit. I think the `ro` and `--network none` hardening steps sound reasonable. [18:05:47] 10Continuous-Integration-Config, 10MediaWiki-Core-Testing, 10Test-Coverage: Switch coverage jobs to PHP >= 7.3 - https://phabricator.wikimedia.org/T279833 (10Daimona) [18:06:16] (03CR) 10Daimona Eaytoy: "> Patch Set 25:" [integration/config] - 10https://gerrit.wikimedia.org/r/567938 (https://phabricator.wikimedia.org/T234020) (owner: 10Daimona Eaytoy) [18:06:50] (03CR) 10Addshore: "Yes it's seemingly fine and passing." [integration/config] - 10https://gerrit.wikimedia.org/r/673503 (https://phabricator.wikimedia.org/T277750) (owner: 10WMDE-leszek) [18:09:43] (03CR) 10Daimona Eaytoy: "Alternatively... Would it be possible to pull the package from sury like for the php73, 74, and 80 flavours?" [integration/config] - 10https://gerrit.wikimedia.org/r/567938 (https://phabricator.wikimedia.org/T234020) (owner: 10Daimona Eaytoy) [18:34:18] (03PS2) 10Jforrester: jjb: Switch quibble jobs to images with pcov (no-op) [integration/config] - 10https://gerrit.wikimedia.org/r/678141 (https://phabricator.wikimedia.org/T234020) [18:43:08] 10MediaWiki-Codesniffer, 10MW-1.35-notes, 10MW-1.36-notes (1.36.0-wmf.1; 2020-07-21), 10Patch-For-Review: Require indentation of CASE statements in PHP code - https://phabricator.wikimedia.org/T182546 (10Umherirrender) >>! In T182546#6988212, @Huji wrote: > @Umherirrender what about what @DannyS712 said in... [18:44:23] (03Abandoned) 10Umherirrender: internal: Add @codeCoverageIgnore to untestable code [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673690 (owner: 10Umherirrender) [18:57:19] 10MediaWiki-Codesniffer: How to handle the nullable operator on multi type lists in code - https://phabricator.wikimedia.org/T250734 (10Umherirrender) the rfc for union types in php8 gives a good answer -https://wiki.php.net/rfc/union_types_v2#nullable_union_types > Union types and the ?T nullable type notatio... [19:26:22] (03CR) 10Jforrester: "> Patch Set 3:" [integration/config] - 10https://gerrit.wikimedia.org/r/673503 (https://phabricator.wikimedia.org/T277750) (owner: 10WMDE-leszek) [20:13:18] (03CR) 10Jforrester: [C: 03+2] build: Update squizlabs/php_codesniffer to 3.6.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/678211 (owner: 10Umherirrender) [20:14:54] (03Merged) 10jenkins-bot: build: Update squizlabs/php_codesniffer to 3.6.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/678211 (owner: 10Umherirrender) [20:14:57] (03Merged) 10jenkins-bot: Add test for index error in AssignmentInReturnSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/606157 (owner: 10Thiemo Kreuz (WMDE)) [22:40:41] 10MediaWiki-Releasing, 10MediaWiki-Installer, 10MW-1.36-release: Enhance installer to support dependencies between skins and extensions - https://phabricator.wikimedia.org/T196670 (10Jdforrester-WMF) Hey there, should this be moved to 1.37? The cut for 1.36 has happened, and 1.36.0-rc.0 will be cut in a fort... [22:47:27] 10MediaWiki-Releasing, 10MediaWiki-Installer, 10MediaWiki-Stakeholders-Group, 10Epic, 10MW-1.37-release: Expand the set of bundled extensions and skins in MediaWiki 1.37 - https://phabricator.wikimedia.org/T279842 (10Jdforrester-WMF) [22:47:45] 10MediaWiki-Releasing, 10MediaWiki-Installer, 10MediaWiki-Stakeholders-Group, 10Epic, 10MW-1.36-release: Expand the set of bundled extensions and skins in MediaWiki 1.36 - https://phabricator.wikimedia.org/T246381 (10Jdforrester-WMF) [22:49:27] 10MediaWiki-Releasing, 10MediaWiki-Installer, 10MediaWiki-Stakeholders-Group, 10Epic, 10MW-1.37-release: Expand the set of bundled extensions and skins in MediaWiki 1.37 - https://phabricator.wikimedia.org/T279842 (10Jdforrester-WMF) [22:49:29] 10MediaWiki-Releasing, 10Reference Previews, 10MW-1.37-release: Bundle Popups extension with MediaWiki - https://phabricator.wikimedia.org/T231797 (10Jdforrester-WMF) [22:49:34] 10MediaWiki-Releasing, 10MediaWiki-extensions-LoginNotify, 10MW-1.36-release: Bundle LoginNotify extension with MediaWiki - https://phabricator.wikimedia.org/T191746 (10Jdforrester-WMF) [22:49:39] 10MediaWiki-Releasing, 10MW-1.36-release, 10MinervaNeue (Tracking), 10Readers-Web-Backlog (Tracking): Bundle MinervaNeue skin with MediaWiki - https://phabricator.wikimedia.org/T191743 (10Jdforrester-WMF) [22:49:42] 10MediaWiki-Releasing, 10Growth-Team, 10Thanks, 10MW-1.36-release: Bundle Thanks extension with MediaWiki - https://phabricator.wikimedia.org/T191739 (10Jdforrester-WMF) [22:49:46] 10MediaWiki-Releasing, 10AntiSpoof, 10MW-1.36-release: Bundle AntiSpoof extension with MediaWiki - https://phabricator.wikimedia.org/T191736 (10Jdforrester-WMF) [22:50:25] 10MediaWiki-Releasing, 10MediaWiki-extensions-OATHAuth, 10MW-1.36-release: Bundle WebAuthn extension with MediaWiki - https://phabricator.wikimedia.org/T258007 (10Jdforrester-WMF) [22:50:27] 10MediaWiki-Releasing, 10MediaWiki-Installer, 10MediaWiki-Stakeholders-Group, 10Epic, 10MW-1.36-release: Expand the set of bundled extensions and skins in MediaWiki 1.36 - https://phabricator.wikimedia.org/T246381 (10Jdforrester-WMF) [22:50:38] 10MediaWiki-Releasing, 10MediaWiki-extensions-OATHAuth, 10MW-1.36-release: Bundle WebAuthn extension with MediaWiki - https://phabricator.wikimedia.org/T258007 (10Jdforrester-WMF) [22:50:40] 10MediaWiki-Releasing, 10MediaWiki-Installer, 10MediaWiki-Stakeholders-Group, 10Epic, 10MW-1.37-release: Expand the set of bundled extensions and skins in MediaWiki 1.37 - https://phabricator.wikimedia.org/T279842 (10Jdforrester-WMF) [22:50:50] 10MediaWiki-Releasing, 10MediaWiki-extensions-OATHAuth, 10MW-1.37-release: Bundle WebAuthn extension with MediaWiki - https://phabricator.wikimedia.org/T258007 (10Jdforrester-WMF) [22:51:43] 10MediaWiki-Releasing, 10MediaWiki-Installer, 10MediaWiki-Stakeholders-Group, 10Epic, 10MW-1.36-release: Expand the set of bundled extensions and skins in MediaWiki 1.36 - https://phabricator.wikimedia.org/T246381 (10Jdforrester-WMF) I'm optimistic that we might achieve AbuseFilter, but none of the other... [22:53:29] 10MediaWiki-Releasing, 10AntiSpoof, 10MW-1.37-release: Bundle AntiSpoof extension with MediaWiki - https://phabricator.wikimedia.org/T191736 (10Jdforrester-WMF) [22:53:39] 10MediaWiki-Releasing, 10Growth-Team, 10Thanks, 10MW-1.37-release: Bundle Thanks extension with MediaWiki - https://phabricator.wikimedia.org/T191739 (10Jdforrester-WMF) [22:53:47] 10MediaWiki-Releasing, 10MW-1.37-release, 10MinervaNeue (Tracking), 10Readers-Web-Backlog (Tracking): Bundle MinervaNeue skin with MediaWiki - https://phabricator.wikimedia.org/T191743 (10Jdforrester-WMF) [22:53:58] 10MediaWiki-Releasing, 10MW-1.37-release, 10MobileFrontend (Tracking), 10Readers-Web-Backlog (Tracking): Bundle MobileFrontend extension with MediaWiki - https://phabricator.wikimedia.org/T191734 (10Jdforrester-WMF) [22:54:08] 10MediaWiki-Releasing, 10MediaWiki-extensions-LoginNotify, 10MW-1.37-release: Bundle LoginNotify extension with MediaWiki - https://phabricator.wikimedia.org/T191746 (10Jdforrester-WMF) [22:54:23] 10MediaWiki-Releasing, 10Growth-Team, 10Notifications, 10MW-1.37-release, 10Patch-For-Review: Bundle Echo extension with MediaWiki - https://phabricator.wikimedia.org/T191738 (10Jdforrester-WMF) [23:25:29] (03PS4) 10Jforrester: dockerfiles: Provide quibble-buster-php* [integration/config] - 10https://gerrit.wikimedia.org/r/674179 (https://phabricator.wikimedia.org/T252432) [23:48:53] (03PS5) 10Jforrester: dockerfiles: Provide quibble-buster-php* [integration/config] - 10https://gerrit.wikimedia.org/r/674179 (https://phabricator.wikimedia.org/T252432) [23:49:11] (03PS2) 10Jforrester: dockerfiles: Provide quibble-buster-php73-coverage [integration/config] - 10https://gerrit.wikimedia.org/r/674188 (https://phabricator.wikimedia.org/T278203) [23:53:05] (03CR) 10Jforrester: [C: 03+2] dockerfiles: Provide quibble-buster-php* [integration/config] - 10https://gerrit.wikimedia.org/r/674179 (https://phabricator.wikimedia.org/T252432) (owner: 10Jforrester) [23:53:14] (03CR) 10Jforrester: [C: 03+2] dockerfiles: Provide quibble-buster-php73-coverage [integration/config] - 10https://gerrit.wikimedia.org/r/674188 (https://phabricator.wikimedia.org/T278203) (owner: 10Jforrester) [23:54:59] (03Merged) 10jenkins-bot: dockerfiles: Provide quibble-buster-php* [integration/config] - 10https://gerrit.wikimedia.org/r/674179 (https://phabricator.wikimedia.org/T252432) (owner: 10Jforrester) [23:55:02] (03Merged) 10jenkins-bot: dockerfiles: Provide quibble-buster-php73-coverage [integration/config] - 10https://gerrit.wikimedia.org/r/674188 (https://phabricator.wikimedia.org/T278203) (owner: 10Jforrester)