[01:18:19] (03PS9) 10Reedy: scap_lint.py: Output errors from `php -l` [tools/release] - 10https://gerrit.wikimedia.org/r/657930 (https://phabricator.wikimedia.org/T272760) [01:18:23] (03CR) 10Reedy: [C: 03+2] scap_lint.py: Output errors from `php -l` [tools/release] - 10https://gerrit.wikimedia.org/r/657930 (https://phabricator.wikimedia.org/T272760) (owner: 10Reedy) [01:20:00] (03Merged) 10jenkins-bot: scap_lint.py: Output errors from `php -l` [tools/release] - 10https://gerrit.wikimedia.org/r/657930 (https://phabricator.wikimedia.org/T272760) (owner: 10Reedy) [05:56:46] 10Beta-Cluster-Infrastructure: Migrate deployment-prep away from Debian Stretch to Buster/Bullseye - https://phabricator.wikimedia.org/T278641 (10Majavah) [08:10:36] 10Phabricator: Set visibility policy of the Phabricator's Countdown application to "public" - https://phabricator.wikimedia.org/T258106 (10valerio.bozzolan) Is there anything I can do for this? I would like to make this cute CountDown public: {C4} Thank you so much! [08:11:32] 10Continuous-Integration-Config, 10Wikidata, 10Wikidata Query Builder, 10wdwb-tech: Add branch hosting to Query Builder integration pipeline - https://phabricator.wikimedia.org/T278706 (10Michael) [10:01:08] 10Continuous-Integration-Config, 10Wikidata, 10wdwb-tech: Wikibase CI, phan & mediawiki-vendor issues. - https://phabricator.wikimedia.org/T279898 (10Addshore) [10:02:25] 10Continuous-Integration-Config, 10Wikidata, 10wdwb-tech: Wikibase CI, phan & mediawiki-vendor issues. - https://phabricator.wikimedia.org/T279898 (10Addshore) p:05Triageβ†’03High [10:03:07] 10MediaWiki-Releasing, 10MediaWiki-Installer, 10MediaWiki-Stakeholders-Group, 10Epic, 10MW-1.36-release: Expand the set of bundled extensions and skins in MediaWiki 1.36 - https://phabricator.wikimedia.org/T246381 (10Daimona) >>! In T246381#6989063, @Jdforrester-WMF wrote: > I'm optimistic that we might... [10:03:17] 10Continuous-Integration-Config, 10phan, 10MediaWiki-Vendor, 10Wikidata, 10wdwb-tech: Wikibase CI, phan & mediawiki-vendor issues. - https://phabricator.wikimedia.org/T279898 (10Addshore) [10:43:18] 10Continuous-Integration-Config, 10phan, 10MediaWiki-Vendor, 10Wikidata, 10wdwb-tech: Wikibase CI, phan & mediawiki-vendor issues. - https://phabricator.wikimedia.org/T279898 (10WMDE-leszek) [10:46:35] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Pywikibot: TRAVIS jobs cannot be restarted anymore - https://phabricator.wikimedia.org/T279817 (10hashar) //K-and-R// looks like an organization and is unrelated. If I look at https://travis-ci.com/organizations/w... [11:30:07] !log deployment-prep: Beta is down due to my change, fix on its way (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/678578) [11:30:10] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [11:32:33] Urbanecm: why are you parsing strings when it's an int value? [11:32:52] Majavah: look into extension.json-provided defaults [11:33:15] https://github.com/wikimedia/mediawiki-extensions-GrowthExperiments/blob/master/extension.json#L1338 [11:33:19] it was originally intended to parse this [11:35:55] Majavah: does that make sense? [11:36:11] Urbanecm: yes [11:37:46] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (CI & Testing services), 10Pywikibot: TRAVIS jobs cannot be restarted anymore - https://phabricator.wikimedia.org/T279817 (10Xqt) Most repositories are running at travis.**org**: https://travis-ci.org/organizations/wikimedia/repositories but... [13:12:14] 10MediaWiki-Codesniffer: Enforce usage of java-like array union types instead of PSR5-style - https://phabricator.wikimedia.org/T279922 (10Daimona) [14:23:32] oh fun, beta puppet cherry picks are breaking prod yet again, I'm trying to fix it [14:38:07] !log fix parsoid CI ferm rule local hack puppet patch on deployment-puppetmaster04 after it broke due to operations/puppet changes [14:38:12] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [14:39:37] !log remove https://gerrit.wikimedia.org/r/c/operations/puppet/+/263024 cherry pick from beta cluster per T106915#6279270 - T135427 [14:39:43] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [14:39:43] T135427: Beta puppetmaster cherry-pick process - https://phabricator.wikimedia.org/T135427 [14:39:43] T106915: Use Sentry in production - https://phabricator.wikimedia.org/T106915 [14:48:34] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team, 10Release-Engineering-Team-TODO, 10Patch-For-Review: Beta puppetmaster cherry-pick process - https://phabricator.wikimedia.org/T135427 (10Majavah) Today I found out that a local hack had conflicts with upstream changes some time ago and fixed beta... [14:50:43] 10Phabricator, 10Security-Team: Enable risk rating field in Phabricator's task form - https://phabricator.wikimedia.org/T279690 (10sbassett) Hey @Aklapper - > It could be re-enabled in that edit form if that is wanted. (Note that edit forms refer to existing tasks and are separate from task creation forms.)... [15:17:31] sorry about all the Wikibase stuff in gate-and-submit πŸ˜” [15:17:49] we built up a comparatively large backlog of changes to merge on Thursday and Friday, because one colleague was away [15:18:06] and then earlier today CI was broken for a while, so the backlog grew even larger [15:18:17] I guess it’ll clear out over the rest of the day… [15:40:49] !log deployment-prep: urbanecm@deployment-deploy01:~$ mwscript extensions/GrowthExperiments/maintenance/migrateMentorMenteeRelationship.php --wiki=cswiki # T279853 [15:40:54] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [15:40:54] T279853: Migrate mentor/mentee relationship to a separate database table on Wikimedia wikis - https://phabricator.wikimedia.org/T279853 [15:46:52] !log deployment-prep: Run `mwscript extensions/GrowthExperiments/maintenance/migrateMentorMenteeRelationship.php` on all beta wikis with GrowthExperiments installed (wikis that are both in all-labs and growthexperiments, plus enwiki; T279853) [15:46:55] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [15:46:56] T279853: Migrate mentor/mentee relationship to a separate database table on Wikimedia wikis - https://phabricator.wikimedia.org/T279853 [16:39:30] 10Phabricator (Upstream), 10Logos, 10Upstream, 10User-MacFan4000: Update the MediaWiki sprite logos within phabricator core - https://phabricator.wikimedia.org/T279573 (10MacFan4000) Looks like the upstream patch is accepted, though still needs to be landed. [16:58:13] 10Beta-Cluster-Infrastructure: Repeated deployment-mediawiki-07 socket timeouts - https://phabricator.wikimedia.org/T246577 (10Majavah) Is this still happening? [17:02:18] 10Release-Engineering-Team-TODO (2021-04-01 to 2021-06-30 (Q4)), 10Release, 10Train Deployments: User_talk:8.8.8.8 is broken on beta: Error: Call to a member function equals() on boolean - https://phabricator.wikimedia.org/T279949 (10Urbanecm) p:05Triageβ†’03Medium [17:02:36] 10Release-Engineering-Team-TODO (2021-04-01 to 2021-06-30 (Q4)), 10DiscussionTools, 10Release, 10Train Deployments: User_talk:8.8.8.8 is broken on beta: Error: Call to a member function equals() on boolean - https://phabricator.wikimedia.org/T279949 (10Urbanecm) p:05Mediumβ†’03Unbreak! Train blocker => U... [17:03:56] 10Release-Engineering-Team-TODO (2021-04-01 to 2021-06-30 (Q4)), 10DiscussionTools, 10Release, 10Train Deployments: User_talk:8.8.8.8 is broken on beta: Error: Call to a member function equals() on boolean - https://phabricator.wikimedia.org/T279949 (10Urbanecm) a:05jeenaβ†’03None [17:16:38] 10Beta-Cluster-Infrastructure, 10Kubernetes: Re-consider setting up a Kubernetes cluster on the Beta cluster - https://phabricator.wikimedia.org/T276650 (10Majavah) I chatted about this on IRC with some people some time ago, the main takeaways basically were: * Something needs to be done at some point, since a... [17:18:27] 10Beta-Cluster-Infrastructure, 10User-zeljkofilipin, 10WorkType-NewFunctionality: Make selenium users use botflags at beta-cluster by setting the bot flag (passing "bot=1" parameter) when saving edits - https://phabricator.wikimedia.org/T116027 (10Aklapper) 05Stalledβ†’03Open [19:24:03] 10Phabricator (2021-03-24), 10Upstream: Phabricator should warn users when they mention other users on content (tasks/mockups) that the mentioned users cannot access - https://phabricator.wikimedia.org/T78184 (10Aklapper) 05Declinedβ†’03Resolved The behavior is not going to change, however Phabricator now vi... [19:32:00] 10Project-Admins, 10Contributors-UX-Research: Is #Contributors-UX-Research still in use? - https://phabricator.wikimedia.org/T279953 (10Aklapper) [20:06:27] 10Release-Engineering-Team-TODO (2021-04-01 to 2021-06-30 (Q4)), 10DiscussionTools, 10Release, 10Train Deployments: User_talk:8.8.8.8 is broken on beta: Error: Call to a member function equals() on boolean - https://phabricator.wikimedia.org/T279949 (10matmarex) The is a duplicate, there a patch pending re... [20:14:12] 10Release-Engineering-Team-TODO (2021-04-01 to 2021-06-30 (Q4)), 10DiscussionTools, 10Release, 10Train Deployments: User_talk:8.8.8.8 is broken on beta: Error: Call to a member function equals() on boolean - https://phabricator.wikimedia.org/T279949 (10Zabe) Yes, probably same as T279604 [20:34:49] 10Release-Engineering-Team (Development services), 10Gerrit (Gerrit 3.3): Switch Gerrit from Java 8 to Java 11 - https://phabricator.wikimedia.org/T268225 (10Paladox) I think that we use java 11 now? see: https://github.com/wikimedia/puppet/blob/production/modules/profile/manifests/gerrit.pp#L23 https://gi... [20:43:19] (03PS4) 10Umherirrender: Use Generic.WhiteSpace.LanguageConstructSpacing sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/675230 [21:08:18] 10Release-Engineering-Team-TODO (2021-04-01 to 2021-06-30 (Q4)), 10DiscussionTools, 10Release, 10Train Deployments: User_talk:8.8.8.8 is broken on beta: Error: Call to a member function equals() on boolean - https://phabricator.wikimedia.org/T279949 (10matmarex) [21:08:53] 10Release-Engineering-Team-TODO (2021-04-01 to 2021-06-30 (Q4)), 10Release, 10Train Deployments: 1.37.0-wmf.1 deployment blockers - https://phabricator.wikimedia.org/T278345 (10matmarex) [21:08:55] 10Release-Engineering-Team-TODO (2021-04-01 to 2021-06-30 (Q4)), 10DiscussionTools, 10Release, 10Train Deployments: User_talk:8.8.8.8 is broken on beta: Error: Call to a member function equals() on boolean - https://phabricator.wikimedia.org/T279949 (10matmarex) [21:23:03] Reedy: any way to make phan work for https://integration.wikimedia.org/ci/job/mediawiki-core-php72-phan-docker/44797/console ? [21:23:37] What did you do to break it? :P [21:23:38] 10MediaWiki-Codesniffer, 10MW-1.35-notes, 10MW-1.36-notes (1.36.0-wmf.1; 2020-07-21), 10Patch-For-Review: Require indentation of CASE statements in PHP code - https://phabricator.wikimedia.org/T182546 (10Umherirrender) Do we need the following error? I will upload a patch set with the fixes for core to hav... [21:25:52] AaronSchulz what is the patch for that? [21:25:59] https://gerrit.wikimedia.org/r/c/mediawiki/core/+/524663 [21:26:09] Phan doesn't know about autoload.php [21:26:17] It can't know there's a random alias in a random file [21:26:27] The simplest fix is to keep something in includes/libs/objectcache/BagOStuff.php [21:26:41] whether a class New extends Old {} or put the class_alias in there [21:26:55] And then remove it (or move it) when all references have been updated to use the new namespaced version of it [21:28:13] 10MediaWiki-Codesniffer, 10MW-1.35-notes, 10MW-1.36-notes (1.36.0-wmf.1; 2020-07-21), 10Patch-For-Review: Require indentation of CASE statements in PHP code - https://phabricator.wikimedia.org/T182546 (10Jdforrester-WMF) >>! In T182546#6992361, @Umherirrender wrote: > Do we need the following error? I will... [22:00:58] Can anyone confirm if gerrit.wikimedia.org uses java 11 for https://phabricator.wikimedia.org/T268225 ? (so we can close it as resolved) [22:08:53] 10MediaWiki-Codesniffer, 10MW-1.35-notes, 10MW-1.36-notes (1.36.0-wmf.1; 2020-07-21), 10Patch-For-Review: Require indentation of CASE statements in PHP code - https://phabricator.wikimedia.org/T182546 (10Umherirrender) >>! In T182546#6992361, @Umherirrender wrote: > - `βˆ’` It seems to have problems with tr... [22:20:29] 10MediaWiki-Codesniffer: MediaWiki.NamingConventions.ValidGlobalName stops validation after php reserved global - https://phabricator.wikimedia.org/T279968 (10Umherirrender) [23:09:15] Reedy: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/524663 that doesn't seem to help [23:12:02] Try the extends way? [23:12:21] AaronSchulz: lol [23:12:25] From .phan/config.php [23:12:25] / Do not use aliases in core. [23:12:25] / Use the correct name, because we don't need backward compatibility [23:12:25] $cfg['enable_class_alias_support'] = false; [23:12:28] that'll be why :) [23:12:36] so yeah, you'll need [23:12:46] class BagOStuff extends Wikimedia\LightweightObjectStore\BagOStuff {} [23:15:11] Reedy: I was looking at https://phabricator.wikimedia.org/T224784 a bit ago [23:15:56] https://github.com/wikimedia/mediawiki/commit/f74400487fdb4c48833f566524d4079bce098250 [23:16:13] Looks like umherirrender fixed the usages, and disabled it [23:29:00] 10MediaWiki-Releasing, 10MediaWiki-Installer, 10MediaWiki-Stakeholders-Group, 10Epic, 10MW-1.36-release: Expand the set of bundled extensions and skins in MediaWiki 1.36 - https://phabricator.wikimedia.org/T246381 (10Jdforrester-WMF) >>! In T246381#6990648, @Daimona wrote: >>>! In T246381#6989063, @Jdfor... [23:34:22] 10MediaWiki-Releasing, 10AbuseFilter (Overhaul-2020), 10MW-1.36-release, 10Patch-For-Review: Bundle AbuseFilter extension with MediaWiki - https://phabricator.wikimedia.org/T191740 (10Reedy) [23:49:59] beta cluster has three deploy0x hosts now? [23:50:26] I'm guessing Majavah hasn't got round to decomissioning some yet [23:50:27] and 03 and 02 are both the wrong one it seems [23:50:33] 01 claims to be the right one [23:50:37] Because moving them is also hard (and probably needs releng help) [23:51:06] I'm curently trying to figure out why Special:Version in beta claims to be at 2 months ago for CentralNotice [23:51:13] which matches never master nor wmf_deploy [23:51:25] lol [23:51:29] neither& [23:51:33] hmmm [23:51:48] last deploy I checked I thought it looked ok... [23:51:48] hello CentralNotice :) [23:52:00] hellooooooooooooo [23:52:28] server says php-masterextneions/CN is at * 31804f34 - (HEAD, origin/master) Remove php entry point (5 days ago) [23:52:36] so maybe its just gitinfo/specialversion that's wrong [23:52:51] AndyRussG: what if we restrcted CN master the way wmf_deploy is, and then got rid of wmf_deploy? [23:52:54] Krinkle: blame https://github.com/wikimedia/mediawiki-extensions [23:53:21] which is up to date? [23:53:35] so yeah, maybe gitinfo et al [23:53:38] welp is has been a pain point, but there also are definitely times there are code freezes but folks still want to merge stuff [23:54:32] frankly the 2-month old thing sounds right