[00:29:36] 10phan, 10MediaWiki-Vagrant, 10SRE: It should be possible to install php-ast using apt-get on MediaWiki-Vagrant - https://phabricator.wikimedia.org/T234240 (10Reedy) https://packages.debian.org/stretch/php-ast php-ast is packaged for stretch... What's the issue with using that? [00:29:45] 10phan, 10MediaWiki-Vagrant, 10SRE: Phan should work out of the box on MediaWiki-Vagrant - https://phabricator.wikimedia.org/T234240 (10Reedy) [01:38:27] 10phan, 10MediaWiki-Vagrant, 10SRE: Phan should work out of the box on MediaWiki-Vagrant - https://phabricator.wikimedia.org/T234240 (10Reedy) Hmm. So that wants to install PHP 7.0... I guess this is blocked by {T256822}... Though https://packages.debian.org/buster/php-ast might be a bit too old.. [01:38:59] 10phan, 10MediaWiki-Vagrant, 10SRE: Phan should work out of the box on MediaWiki-Vagrant - https://phabricator.wikimedia.org/T234240 (10Reedy) [01:42:10] 10phan, 10MediaWiki-Vagrant: Phan should work out of the box on MediaWiki-Vagrant - https://phabricator.wikimedia.org/T234240 (10Reedy) [02:00:31] 10Phabricator: Update Herald (H260) to include project 4739 (Wikimedia OCR) - https://phabricator.wikimedia.org/T280211 (10ldelench_wmf) [04:57:23] 10Release-Engineering-Team-TODO (2021-04-01 to 2021-06-30 (Q4)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.37.0-wmf.1 deployment blockers - https://phabricator.wikimedia.org/T278345 (10TTO) We [[https://en.wiktionary.org/wiki/Wiktionary:Grease_pit/2021/April#Template%3Asenseid_is_not_working_pr... [05:08:08] https://www.mediawiki.org/wiki/MediaWiki_1.37/wmf.1 is missing a whole bunch of changes - any ideas why? Eg https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/FlaggedRevs/ has a number of commits between the REL1_36 branch and wmf/1.37.0-wmf1, but none are listed [05:28:30] 10Release-Engineering-Team-TODO (2021-04-01 to 2021-06-30 (Q4)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.37.0-wmf.1 deployment blockers - https://phabricator.wikimedia.org/T278345 (10TTO) It seems that `content.parser-output.less` is no longer being included in the minified CSS. @Jdlrobson @A... [07:22:23] (03CR) 10Daimona Eaytoy: [C: 03+1] "I wanted to verify the memory usage locally, but even if my machine is pretty quick, it's still slower than the contint machines and the s" (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/679422 (https://phabricator.wikimedia.org/T234020) (owner: 10Jforrester) [07:30:51] 10Phabricator: Update Herald (H260) to include project 4739 (Wikimedia OCR) - https://phabricator.wikimedia.org/T280211 (10Peachey88) [08:27:49] (03CR) 10Daimona Eaytoy: [C: 03+1] "Other actionables for T280167:" [integration/config] - 10https://gerrit.wikimedia.org/r/679422 (https://phabricator.wikimedia.org/T234020) (owner: 10Jforrester) [08:42:29] 10Continuous-Integration-Infrastructure: Add pcov to composer images - https://phabricator.wikimedia.org/T280170 (10Daimona) Thinking about this again, I think it would make more sense to install pcov in the base PHPXY images, since xdebug is installed there, and it'd be easier to reuse. My next question is: is... [09:02:52] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "> […] most MW repos this would only have one value to check for anyway." (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/678304 (https://phabricator.wikimedia.org/T279814) (owner: 10Alex Mashin) [09:07:09] 10Release-Engineering-Team, 10Release-Engineering-Team-TODO, 10Release Pipeline, 10serviceops: Provide the official production base images for Wikimedia use - https://phabricator.wikimedia.org/T238774 (10akosiaris) 05Open→03Resolved a:03akosiaris I am boldy gonna resolve this. The images are in the r... [09:07:11] 10Release-Engineering-Team-TODO, 10Release Pipeline, 10serviceops-radar: Create initial production MW-land images with blubber - https://phabricator.wikimedia.org/T238773 (10akosiaris) [09:07:13] 10Release-Engineering-Team (Pipeline), 10Release Pipeline, 10Wikimedia-Portals, 10serviceops: Migrate www.wikimedia.org (the portal) to be hosted as a service - https://phabricator.wikimedia.org/T238747 (10akosiaris) [09:09:37] 10Release-Engineering-Team (Unit & Int & System Tooling), 10Release-Engineering-Team-TODO, 10Wikidata, 10Wikidata-Campsite, and 5 others: Stop using jsonlint and instead use eslint-plugin-json for the linting - https://phabricator.wikimedia.org/T220036 (10Addshore) [09:09:39] 10phan, 10MediaWiki-Vagrant: Phan should work out of the box on MediaWiki-Vagrant - https://phabricator.wikimedia.org/T234240 (10Daimona) >>! In T234240#7001220, @Reedy wrote: > Though https://packages.debian.org/buster/php-ast might be a bit too old.. Confirming this. We need at the very least 1.0.1, or most... [09:19:55] 10phan, 10MediaWiki-Vagrant: Phan should work out of the box on MediaWiki-Vagrant - https://phabricator.wikimedia.org/T234240 (10Reedy) Looks like in CI we grab it from sury, but we don't use php-ast it on 7.2.... So potentially a long tail of dependancies in different ways, potentially including, but not limi... [09:20:26] (03PS1) 10Daimona Eaytoy: [WIP] dockerfiles: Install pcov in base PHP images + composer-package [integration/config] - 10https://gerrit.wikimedia.org/r/679725 (https://phabricator.wikimedia.org/T280170) [09:21:39] 10Continuous-Integration-Config, 10Wikidata, 10Wikidata Query Builder, 10Wikidata-Campsite, 10wdwb-tech: Add branch hosting to Query Builder integration pipeline - https://phabricator.wikimedia.org/T278706 (10Addshore) [09:30:11] 10Release-Engineering-Team, 10SRE, 10SRE-Access-Requests: Requesting deployment access for HMonroy - https://phabricator.wikimedia.org/T280177 (10fgiunchedi) [09:32:25] 10Release-Engineering-Team, 10SRE, 10SRE-Access-Requests: Requesting deployment access for HMonroy - https://phabricator.wikimedia.org/T280177 (10fgiunchedi) Thank you @Dzahn ! We're indeed seeking approval from #release-engineering-team (cc @thcipriani perhaps?) [09:45:07] 10LibUp: Move libup to a new, puppetized server - https://phabricator.wikimedia.org/T273690 (10aborrero) [09:45:10] 10LibUp, 10Cloud-VPS (Quota-requests): Request increased quota for library-upgrader Cloud VPS project - https://phabricator.wikimedia.org/T280103 (10aborrero) 05Open→03Resolved [09:45:13] 10phan, 10Upstream: Phan should handle always-throw-function like ApiBase::dieWithError better - https://phabricator.wikimedia.org/T240141 (10Daimona) The ultimate fix for this is going to be the `never` return type implemented in PHP 8.1 ([[https://wiki.php.net/rfc/noreturn_type | RFC]]). Upstream issue for s... [09:57:37] (03PS1) 10DCausse: Review access change [wmf-jvm-utils] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/679459 [10:08:07] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Remove special check from SpaceBeforeBracketSniff (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673612 (owner: 10Umherirrender) [10:10:24] (03Merged) 10jenkins-bot: Remove special check from SpaceBeforeBracketSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673612 (owner: 10Umherirrender) [10:11:24] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Remove DocComment.SpacingDocTag for no-spaces before @param [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673694 (owner: 10Umherirrender) [10:13:24] (03Merged) 10jenkins-bot: Remove DocComment.SpacingDocTag for no-spaces before @param [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673694 (owner: 10Umherirrender) [10:13:26] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] internal: Remove unreachable code around doc comment tokens [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673652 (owner: 10Umherirrender) [11:08:31] 10Beta-Cluster-Infrastructure: Repeated deployment-mediawiki-07 socket timeouts - https://phabricator.wikimedia.org/T246577 (10AlexisJazz) >>! In T246577#6991866, @Majavah wrote: > Is this still happening? I don't think so. [11:17:45] (03CR) 10QChris: [V: 03+2 C: 03+2] Review access change [wmf-jvm-utils] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/679459 (owner: 10DCausse) [11:24:20] 10Beta-Cluster-Infrastructure, 10User-Ryasmeen: Repeated deployment-mediawiki-07 socket timeouts - https://phabricator.wikimedia.org/T246577 (10Majavah) 05Open→03Resolved Thanks! Closing in that case. [12:08:01] 10Gerrit: Merge duplicated accounts on the Gerrit - https://phabricator.wikimedia.org/T280250 (10Kizule) [12:15:07] 10Gerrit: Merge duplicated accounts on the Gerrit - https://phabricator.wikimedia.org/T280250 (10Peachey88) [13:06:03] 10MediaWiki-Codesniffer, 10Quality-and-Test-Engineering-Team (QTE), 10Code-Health: Run codehealth pipeline/sonar qube for mediawiki/tools/codesniffer repo - https://phabricator.wikimedia.org/T280194 (10kostajh) Yes, definitely possible (and IMO a good idea). I think this would be the first implementation for... [13:35:03] 10Release-Engineering-Team, 10SRE, 10SRE-Access-Requests: Requesting deployment access for HMonroy - https://phabricator.wikimedia.org/T280177 (10thcipriani) >>! In T280177#7002028, @fgiunchedi wrote: > Thank you @Dzahn ! We're indeed seeking approval from #release-engineering-team (cc @thcipriani perhaps?)... [13:39:32] (03PS1) 10Lars Wirzenius: chore: use new binary name for Subplot [tools/scap] - 10https://gerrit.wikimedia.org/r/679803 [13:41:32] (03CR) 10Lars Wirzenius: "This is a really small change." [tools/scap] - 10https://gerrit.wikimedia.org/r/679803 (owner: 10Lars Wirzenius) [13:43:24] (03PS2) 10DCausse: Add wmf-jvm-utils [integration/config] - 10https://gerrit.wikimedia.org/r/679402 [13:46:24] (03CR) 10Hashar: [C: 03+2] "INFO:jenkins_jobs.builder:Number of jobs generated: 2" [integration/config] - 10https://gerrit.wikimedia.org/r/679402 (owner: 10DCausse) [13:49:12] (03Merged) 10jenkins-bot: Add wmf-jvm-utils [integration/config] - 10https://gerrit.wikimedia.org/r/679402 (owner: 10DCausse) [13:51:57] 10phan-taint-check-plugin: Create a web demo for phan taint-check - https://phabricator.wikimedia.org/T257301 (10Daimona) @Legoktm I've just tried packaging php and taint-check separately. It should be doable if we: - Remove taint-check from the emcc invocation - Build PHP with `-s FORCE_FILESYSTEM=1` - Run... [13:56:51] (03CR) 10Lars Wirzenius: [C: 03+2] RELEASE.md: add apt-get update to instructions [tools/scap] - 10https://gerrit.wikimedia.org/r/679416 (owner: 10Ahmon Dancy) [13:57:11] (03Merged) 10jenkins-bot: RELEASE.md: add apt-get update to instructions [tools/scap] - 10https://gerrit.wikimedia.org/r/679416 (owner: 10Ahmon Dancy) [13:57:55] (03CR) 10Lars Wirzenius: [C: 03+2] cumin02 -> cumin in RELEASE.md [tools/scap] - 10https://gerrit.wikimedia.org/r/679404 (owner: 10Ahmon Dancy) [13:58:57] (03Merged) 10jenkins-bot: cumin02 -> cumin in RELEASE.md [tools/scap] - 10https://gerrit.wikimedia.org/r/679404 (owner: 10Ahmon Dancy) [14:01:12] 10Gerrit: Merge duplicated accounts on the Gerrit - https://phabricator.wikimedia.org/T280250 (10alex-mashin) I confirm the request and thank @Kizule for the trouble he took. [14:07:14] 10Release-Engineering-Team, 10SRE, 10SRE-Access-Requests: Requesting deployment access for HMonroy - https://phabricator.wikimedia.org/T280177 (10marcella) Hiring manager approved! [14:28:40] 10Beta-Cluster-Infrastructure, 10Wikidata, 10Wikidata-Campsite, 10Regression, and 2 others: A revision of https://wikidata.beta.wmflabs.org/wiki/Q64 consistently doesn't load on beta wikidata - https://phabricator.wikimedia.org/T249018 (10Addshore) 05Open→03Resolved a:03Addshore [14:46:09] (03CR) 10Ahmon Dancy: [C: 03+2] chore: use new binary name for Subplot [tools/scap] - 10https://gerrit.wikimedia.org/r/679803 (owner: 10Lars Wirzenius) [14:46:54] (03Merged) 10jenkins-bot: chore: use new binary name for Subplot [tools/scap] - 10https://gerrit.wikimedia.org/r/679803 (owner: 10Lars Wirzenius) [14:54:22] 10Release-Engineering-Team-TODO (2021-04-01 to 2021-06-30 (Q4)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.37.0-wmf.1 deployment blockers - https://phabricator.wikimedia.org/T278345 (10Jdlrobson) @TTO thanks for the report. I have opened a ticket: T280260 [14:54:23] (03CR) 10Ahmon Dancy: [C: 03+2] Reformatted description of beta-build-scap-deb job [integration/config] - 10https://gerrit.wikimedia.org/r/679516 (owner: 10Ahmon Dancy) [14:55:21] (03CR) 10Lars Wirzenius: [C: 03+2] Feature flag for T263872 [tools/scap] - 10https://gerrit.wikimedia.org/r/679518 (https://phabricator.wikimedia.org/T263872) (owner: 10Ahmon Dancy) [14:55:56] (03Merged) 10jenkins-bot: Reformatted description of beta-build-scap-deb job [integration/config] - 10https://gerrit.wikimedia.org/r/679516 (owner: 10Ahmon Dancy) [14:59:03] (03Merged) 10jenkins-bot: Feature flag for T263872 [tools/scap] - 10https://gerrit.wikimedia.org/r/679518 (https://phabricator.wikimedia.org/T263872) (owner: 10Ahmon Dancy) [15:14:23] 10Phabricator-Sprint-Extension, 10Diffusion-Repository-Administrators, 10Projects-Cleanup, 10Wikimedia-GitHub: Archive Phabricator Sprint extension ? - https://phabricator.wikimedia.org/T275325 (10Aklapper) [15:17:00] 10phan-taint-check-plugin: Create a web demo for phan taint-check - https://phabricator.wikimedia.org/T257301 (10Daimona) >>! In T257301#7002737, @Daimona wrote: > but taint-check doesn't because it cannot be found in the virtual FS. I'm currently trying to understand why. So apparently the JS is not being inje... [15:21:02] 10Phabricator, 10CSS: "Change Story Points (Estimate)" overflow - https://phabricator.wikimedia.org/T264253 (10Aklapper) p:05Triage→03Lowest Setting the class `label.aphront-form-label` to use `overflow: hidden; text-overflow: ellipsis;` doesn't add an ellipsis at all...heh. [15:29:32] 10phan-taint-check-plugin: Create a web demo for phan taint-check - https://phabricator.wikimedia.org/T257301 (10Daimona) [[https://github.com/Daimona/demo/commit/b686e8043ba02606c8abcd54b832f51cabb569f1 | Done ]]. There are also [[https://github.com/Daimona/demo/commit/12301610db2483b965fcb9b52e639dbed99cd7f8 |... [15:31:57] (03PS2) 10Daimona Eaytoy: docker: Switch back to Daimona's repo for phan-taint-check demo [integration/config] - 10https://gerrit.wikimedia.org/r/644367 (https://phabricator.wikimedia.org/T257301) (owner: 10Legoktm) [15:34:13] 10Phabricator: Request Edit permissions to the "SRE Access Request" form - https://phabricator.wikimedia.org/T276446 (10Aklapper) @jbond: There is no per-form 'who can edit this form itself' setting and no 'who can edit forms' setting, as Forms are not a Phab app itself. Means: Fulfilling this request would mea... [15:38:51] 10Phabricator: @Phabricator_maintenance is sending email notifications - https://phabricator.wikimedia.org/T216867 (10Aklapper) I guess nowadays it makes more sense to simply disable the @Phabricator_maintenance user account? And [how to silence batch-edits via CLI is covered in the docs](https://www.mediawiki.o... [15:43:09] 10Release-Engineering-Team (Deployment services), 10Release-Engineering-Team-TODO, 10SRE, 10serviceops, and 2 others: Upgrade MediaWiki clusters to Debian Buster (debian 10) - https://phabricator.wikimedia.org/T245757 (10jijiki) [15:52:45] 10Phabricator: Update Herald (H260) to include project 4739 (Wikimedia OCR) - https://phabricator.wikimedia.org/T280211 (10MBinder_WMF) 05Open→03Resolved {meme, src="seal-of-approval", above=SEAL, below="OF APPROVAL"} [16:13:16] (03PS1) 10Jforrester: Add Arthur Lorenzi to CI allow list [integration/config] - 10https://gerrit.wikimedia.org/r/679874 [16:24:55] (03CR) 10Jforrester: [C: 03+2] Add Arthur Lorenzi to CI allow list [integration/config] - 10https://gerrit.wikimedia.org/r/679874 (owner: 10Jforrester) [16:26:06] (03Merged) 10jenkins-bot: Add Arthur Lorenzi to CI allow list [integration/config] - 10https://gerrit.wikimedia.org/r/679874 (owner: 10Jforrester) [16:26:26] 10Continuous-Integration-Config, 10Better Use Of Data, 10Product-Data-Infrastructure: Add CI jobs for mediawiki/libs/metrics-platform - https://phabricator.wikimedia.org/T279180 (10Mholloway) a:03Mholloway [16:37:53] (03PS4) 10Umherirrender: internal: Remove unreachable code around doc comment tokens [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673652 [16:38:08] (03CR) 10Umherirrender: [C: 03+2] "rebased" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673652 (owner: 10Umherirrender) [16:39:53] (03Merged) 10jenkins-bot: internal: Remove unreachable code around doc comment tokens [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/673652 (owner: 10Umherirrender) [16:46:15] 10MediaWiki-Releasing, 10MW-1.36-notes, 10MW-1.36-release: Release 1.36.0-rc.0 - https://phabricator.wikimedia.org/T279462 (10Reedy) [16:47:33] !log manually rebase deployment-puppetmaster04 due to local hacks having conflicts [16:47:35] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [17:06:51] (03CR) 10DannyS712: docker: Switch back to Daimona's repo for phan-taint-check demo (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/644367 (https://phabricator.wikimedia.org/T257301) (owner: 10Legoktm) [17:14:27] (03PS1) 10Umherirrender: internal: Rename and remove variables in FunctionCommentSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/679895 [17:24:53] (03PS10) 10Umherirrender: Check for superfluous @return statements and missing void types [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/658070 [17:25:35] (03CR) 10Umherirrender: "Moved the variable rename into own patch set - Ia1a106d21a806a3e11676294e690df6ebdf42d4d - to make the diff/review easier" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/658070 (owner: 10Umherirrender) [17:27:54] (03CR) 10Umherirrender: [C: 03+1] Allow non-two-characters prefixes for global variables (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/678304 (https://phabricator.wikimedia.org/T279814) (owner: 10Alex Mashin) [18:09:37] 10MediaWiki-Releasing, 10MW-1.36-release: Announce 1.36 retrospective "pencils down" and likely timeline to wikitech-l etc. - https://phabricator.wikimedia.org/T279708 (10Jdforrester-WMF) 05Open→03Resolved [18:09:40] 10MediaWiki-Releasing, 10MW-1.36-notes, 10MW-1.36-release, 10Platform Team Workboards (Initiatives): Release MW 1.36.0 - https://phabricator.wikimedia.org/T279455 (10Jdforrester-WMF) [18:26:49] !log gerrit: created openstack/horizon/trove-dashboard per andrewbogott (with parent set as openstack/horizon/horizon) [18:26:51] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [18:37:58] (03PS1) 10Jforrester: MediaWiki.Usage.DeprecatedConstantUsage: Replace DB_MASTER from 1.36.0+ [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/679917 (https://phabricator.wikimedia.org/T278026) [18:38:27] (03CR) 10Jforrester: [C: 04-1] "Need to determine release targets first." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/679917 (https://phabricator.wikimedia.org/T278026) (owner: 10Jforrester) [19:12:32] (03PS5) 10Jforrester: dockerfiles: [quibble-buster-php73-coverage] Performance tuning config tweaks [integration/config] - 10https://gerrit.wikimedia.org/r/679422 (https://phabricator.wikimedia.org/T234020) [19:12:34] (03CR) 10Jforrester: dockerfiles: [quibble-buster-php73-coverage] Performance tuning config tweaks (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/679422 (https://phabricator.wikimedia.org/T234020) (owner: 10Jforrester) [19:12:36] (03CR) 10Jforrester: "> Patch Set 4:" [integration/config] - 10https://gerrit.wikimedia.org/r/679422 (https://phabricator.wikimedia.org/T234020) (owner: 10Jforrester) [19:26:52] (03CR) 10Umherirrender: "recheck" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/679895 (owner: 10Umherirrender) [19:28:48] 10MediaWiki-Codesniffer, 10MW-1.35-notes, 10MW-1.36-notes (1.36.0-wmf.1; 2020-07-21), 10MW-1.37-notes (1.37.0-wmf.2; 2021-04-20), 10Patch-For-Review: Require indentation of CASE statements in PHP code - https://phabricator.wikimedia.org/T182546 (10Umherirrender) 05Open→03Resolved >>! In T182546#69923... [19:49:40] thcipriani: strange that we didn't notice this https://phabricator.wikimedia.org/T280220 [19:49:49] went from dormant to 1000x a day [19:49:55] over a week ago [20:01:59] (03CR) 10Daimona Eaytoy: [C: 03+1] "Thank you, LGTM" [integration/config] - 10https://gerrit.wikimedia.org/r/679422 (https://phabricator.wikimedia.org/T234020) (owner: 10Jforrester) [21:11:14] 10LibUp: LibUp hasn't successfully run on AutoCreateCategoryPages for 7 weeks - https://phabricator.wikimedia.org/T275292 (10Umherirrender) 05Open→03Resolved There is a run today - https://libraryupgrader2.wmcloud.org/logs2/228424 Thanks for the analyze and work on it. [21:31:06] (03PS1) 10Mholloway: Add pipeline-based jobs for mediawiki/libs/metrics-platform [integration/config] - 10https://gerrit.wikimedia.org/r/679968 (https://phabricator.wikimedia.org/T279180) [21:32:52] 10Continuous-Integration-Config, 10Better Use Of Data, 10Product-Data-Infrastructure, 10Patch-For-Review: Add CI jobs for mediawiki/libs/metrics-platform - https://phabricator.wikimedia.org/T279180 (10Mholloway) Thanks for the pointer, @Jdforrester-WMF! [22:38:38] (03CR) 10DannyS712: "This change is ready for review." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/679844 (https://phabricator.wikimedia.org/T220719) (owner: 10DannyS712) [22:52:03] 10Release-Engineering-Team-TODO (2021-04-01 to 2021-06-30 (Q4)), 10Patch-For-Review, 10Release, 10Train Deployments: 1.37.0-wmf.1 deployment blockers - https://phabricator.wikimedia.org/T278345 (10Jdforrester-WMF) 05Open→03Resolved [22:54:30] 10MediaWiki-Codesniffer, 10Release, 10User-DannyS712: Release mediawiki-codesniffer v36.0.0 - https://phabricator.wikimedia.org/T278653 (10DannyS712) [22:55:00] 10MediaWiki-Codesniffer, 10Release, 10User-DannyS712: Release mediawiki-codesniffer v36.0.0 - https://phabricator.wikimedia.org/T278653 (10DannyS712) [23:14:25] (03CR) 10DannyS712: MediaWiki.Usage.DeprecatedConstantUsage: Replace DB_MASTER from 1.36.0+ (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/679917 (https://phabricator.wikimedia.org/T278026) (owner: 10Jforrester)