[00:53:13] (03PS1) 10Krinkle: jjb: Change oojs-core-node10 job from 'npm test' to 'npm run jenkins' [integration/config] - 10https://gerrit.wikimedia.org/r/682029 [00:54:24] (03CR) 10jerkins-bot: [V: 04-1] jjb: Change oojs-core-node10 job from 'npm test' to 'npm run jenkins' [integration/config] - 10https://gerrit.wikimedia.org/r/682029 (owner: 10Krinkle) [00:55:48] (03PS2) 10Krinkle: jjb: Change oojs-core-node10 job from 'npm test' to 'npm run jenkins' [integration/config] - 10https://gerrit.wikimedia.org/r/682029 [05:57:18] 10MediaWiki-Codesniffer, 10MediaWiki-General, 10MediaWiki-Vendor, 10Parsoid: New upstream release for composer/semver - https://phabricator.wikimedia.org/T280945 (10LibUp-bot) [06:02:02] 10MediaWiki-Codesniffer, 10MediaWiki-General, 10MediaWiki-Vendor, 10Parsoid: New upstream release for composer/semver - https://phabricator.wikimedia.org/T280945 (10Legoktm) 05Open→03Invalid Already up to date [06:41:17] 10LibUp, 10Phabricator, 10Wikimedia-General-or-Unknown: Create a release monitoring bot for Phabricator - https://phabricator.wikimedia.org/T205365 (10Aklapper) Small note: I wonder if the Phab task title could include the version info (allows easier differentiation when looking at lists of tasks), like `New... [07:02:50] 10LibUp, 10Phabricator, 10Wikimedia-General-or-Unknown: Create a release monitoring bot for Phabricator - https://phabricator.wikimedia.org/T205365 (10Legoktm) >>! In T205365#7028665, @Aklapper wrote: > Small note: I wonder if the Phab task title could include the version info (allows easier differentiation... [07:13:54] (03PS3) 10Gehel: Enable sonar analysis post merge for java projects. [integration/config] - 10https://gerrit.wikimedia.org/r/681988 [07:30:35] 10LibUp: LibUp parsing JSON fails because of outdated caniuse-lite warning - https://phabricator.wikimedia.org/T280958 (10Legoktm) [08:15:27] 10MediaWiki-Codesniffer, 10Voice & Tone: Flagging new usages of inappropriate words - https://phabricator.wikimedia.org/T280471 (10thiemowmde) > […] we have exceptions and ways to make the rule be ignored in certain cases I know, but [as we have seen](https://phabricator.wikimedia.org/T266823#6672755) this doe... [09:06:56] (03PS1) 10Matthias Mullie: Add extensions/MediaSearch [tools/release] - 10https://gerrit.wikimedia.org/r/682101 (https://phabricator.wikimedia.org/T265939) [09:12:36] !log signing puppet certs for deployment-eventlog08 and running puppet for the first time to stop annoying email alerts [09:12:39] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [09:20:10] (03CR) 10Matthias Mullie: [C: 04-2] "DNM until 2 branches after I0a021e6c3a02350493eca2197b2515dbfd1c1c88 has been merged" [tools/release] - 10https://gerrit.wikimedia.org/r/682101 (https://phabricator.wikimedia.org/T265939) (owner: 10Matthias Mullie) [09:21:39] (03CR) 10Matthias Mullie: "(Retracting -2; that was meant for I1e33121c5ce9235d1065e8cab856cabb754e2c81; this is actually very much ready)" [tools/release] - 10https://gerrit.wikimedia.org/r/682101 (https://phabricator.wikimedia.org/T265939) (owner: 10Matthias Mullie) [09:58:10] 10phan-taint-check-plugin, 10Patch-For-Review: Optimize phan-taint-check speed - https://phabricator.wikimedia.org/T203651 (10Daimona) >>! In T203651#7028109, @Jdforrester-WMF wrote: > We should probably have a task for "move phan work into composer test jobs", I guess. We're pretty much there from a performan... [11:05:53] 10Phabricator, 10MediaWiki-extension-requests: MediaWiki extension to embed Phabricator content in wiki pages - https://phabricator.wikimedia.org/T90432 (10dcaro) Just Fyi. I found myself wanting to embed a phabricator search in a wiki page too. [11:06:21] 10LibUp, 10Phabricator, 10Wikimedia-General-or-Unknown: Create a release monitoring bot for Phabricator - https://phabricator.wikimedia.org/T205365 (10Aklapper) No particular opinion - I had naively expected that the bot would create a new task everytime there's a new upstream release, and that it would not... [13:26:27] (03CR) 10Anne Tomasevich: [C: 03+1] Add extensions/MediaSearch [tools/release] - 10https://gerrit.wikimedia.org/r/682101 (https://phabricator.wikimedia.org/T265939) (owner: 10Matthias Mullie) [13:55:57] (03CR) 10Reedy: [C: 04-1] "I don't think this is the file you want to edit." [tools/release] - 10https://gerrit.wikimedia.org/r/682101 (https://phabricator.wikimedia.org/T265939) (owner: 10Matthias Mullie) [14:19:42] 10Project-Admins: Requests for addition to the #acl*Project-Admins group (in comments) - https://phabricator.wikimedia.org/T706 (10ldelench_wmf) Hi there, could @LZaman and I both be added to #acl*Project-Admins group? We are technical program managers who will need to create projects/milestones/components/sprin... [16:30:09] !log remove deployment-prep hiera settings for phabricator, given there is no phabricator instance on that project [16:30:11] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [16:42:31] 10Continuous-Integration-Config, 10phan, 10MediaWiki-Vendor, 10Wikidata, 10wdwb-tech: Wikibase CI, phan & mediawiki-vendor issues. - https://phabricator.wikimedia.org/T279898 (10Jdforrester-WMF) >>! In T279898#7028202, @Addshore wrote: > So the current state would be: > - Make mediawiki & extensions com... [17:04:23] (03PS2) 10Jforrester: Start branching MediaSearch extension for Wikimedia production [tools/release] - 10https://gerrit.wikimedia.org/r/682101 (https://phabricator.wikimedia.org/T265939) (owner: 10Matthias Mullie) [17:06:57] (03CR) 10Jforrester: [C: 03+2] "Passed security review in T266513." [tools/release] - 10https://gerrit.wikimedia.org/r/682101 (https://phabricator.wikimedia.org/T265939) (owner: 10Matthias Mullie) [17:09:03] (03Merged) 10jenkins-bot: Start branching MediaSearch extension for Wikimedia production [tools/release] - 10https://gerrit.wikimedia.org/r/682101 (https://phabricator.wikimedia.org/T265939) (owner: 10Matthias Mullie) [17:11:50] 10Continuous-Integration-Config, 10phan, 10MediaWiki-Vendor, 10Wikidata, 10wdwb-tech: Wikibase CI, phan & mediawiki-vendor issues. - https://phabricator.wikimedia.org/T279898 (10Addshore) > You're meant to use MW's extension dependency system to depend on the extension that provides the composer dependen... [17:17:24] 10Project-Admins: Requests for addition to the #acl*Project-Admins group (in comments) - https://phabricator.wikimedia.org/T706 (10mmodell) >>! In T706#7029611, @ldelench_wmf wrote: > Hi there, could @LZaman and I both be added to #acl*Project-Admins group? Done [17:18:00] 10Continuous-Integration-Config, 10LibUp, 10phan, 10Composer: Run phan as part of composer test, rather than in bespoke CI jobs - https://phabricator.wikimedia.org/T280990 (10Jdforrester-WMF) [17:18:37] 10LibUp, 10phan: Provide AST on the image on which LibUp runs so it can handle phan - https://phabricator.wikimedia.org/T270632 (10Jdforrester-WMF) [17:18:39] 10Continuous-Integration-Config, 10LibUp, 10phan, 10Composer: Run phan as part of composer test, rather than in bespoke CI jobs - https://phabricator.wikimedia.org/T280990 (10Jdforrester-WMF) [17:19:05] 10phan-taint-check-plugin, 10Patch-For-Review: Optimize phan-taint-check speed - https://phabricator.wikimedia.org/T203651 (10Jdforrester-WMF) Filed as {T280990}. [17:19:19] 10Continuous-Integration-Config, 10LibUp, 10phan, 10Composer: Run phan as part of composer test, rather than in bespoke CI jobs - https://phabricator.wikimedia.org/T280990 (10Jdforrester-WMF) [17:19:22] 10phan-taint-check-plugin, 10Patch-For-Review: Optimize phan-taint-check speed - https://phabricator.wikimedia.org/T203651 (10Jdforrester-WMF) [17:26:27] 10Continuous-Integration-Config, 10LibUp, 10phan, 10Composer: Run phan as part of composer test, rather than in bespoke CI jobs - https://phabricator.wikimedia.org/T280990 (10Legoktm) Unless we make the php-ast dependency optional (or support older, packaged versions) and embrace the polyfill parser, I thi... [17:27:55] 10Continuous-Integration-Config, 10LibUp, 10phan, 10Composer: Run phan as part of composer test, rather than in bespoke CI jobs - https://phabricator.wikimedia.org/T280990 (10Jdforrester-WMF) >>! In T280990#7030014, @Legoktm wrote: > Unless we make the php-ast dependency optional (or support older, package... [18:26:31] (03PS7) 10Umherirrender: Add a new StaticClosureSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/662110 (https://phabricator.wikimedia.org/T274038) [18:26:49] (03CR) 10Umherirrender: "Rebased" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/662110 (https://phabricator.wikimedia.org/T274038) (owner: 10Umherirrender) [18:34:20] 10Phabricator: Phab feature request: Cycle time for a task entering a column to resolution, with support for wildcards - https://phabricator.wikimedia.org/T148805 (10thcipriani) [18:34:22] 10Phabricator, 10Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)), 10Developer Productivity: Enhance phabricator project metrics and reporting - https://phabricator.wikimedia.org/T255703 (10thcipriani) [18:34:29] 10Phabricator, 10Developer Productivity: Introduce new task statuses in Phabricator. - https://phabricator.wikimedia.org/T261493 (10thcipriani) [18:34:31] 10Phabricator: Phab feature request: Cycle time for a task entering a column to resolution, with support for wildcards - https://phabricator.wikimedia.org/T148805 (10thcipriani) [18:34:54] 10Phabricator, 10Data³: Phab feature request: Cycle time for a task entering a column to resolution, with support for wildcards - https://phabricator.wikimedia.org/T148805 (10thcipriani) [18:47:21] 10Scap, 10Machine-Learning-Team, 10ORES: Scap deploy for ORES reports success even when uwsgi fails to start up - https://phabricator.wikimedia.org/T280998 (10Halfak) [18:50:02] 10Phabricator, 10Data³: Phab feature request: Cycle time for a task entering a column to resolution, with support for wildcards - https://phabricator.wikimedia.org/T148805 (10thcipriani) This metric was identified during the #data³ MVP meeting as a metric needing experimentation. We came up with a narrow defi... [18:50:19] 10Phabricator, 10Data³: Phab feature request: Cycle time for a task entering a column to resolution, with support for wildcards - https://phabricator.wikimedia.org/T148805 (10thcipriani) p:05Triage→03Medium [18:56:47] 10MediaWiki-Releasing, 10AbuseFilter (Overhaul-2020), 10MW-1.37-release, 10Patch-For-Review: Bundle AbuseFilter extension with MediaWiki - https://phabricator.wikimedia.org/T191740 (10sbassett) [19:24:49] (03CR) 10Matthias Mullie: "> Patch Set 1: Code-Review-1" [tools/release] - 10https://gerrit.wikimedia.org/r/682101 (https://phabricator.wikimedia.org/T265939) (owner: 10Matthias Mullie) [19:33:43] (03CR) 10Jforrester: "> Patch Set 2:" [tools/release] - 10https://gerrit.wikimedia.org/r/682101 (https://phabricator.wikimedia.org/T265939) (owner: 10Matthias Mullie) [20:16:41] 10MediaWiki-Releasing, 10MW-1.37-notes (1.37.0-wmf.1; 2021-04-13), 10Security: Release MediaWiki 1.31.13/1.35.2 - https://phabricator.wikimedia.org/T270458 (10sbassett) [20:16:52] 10MediaWiki-Releasing, 10Security-Team, 10Security, 10user-sbassett: Write and send supplementary release announcement for extensions and skins with security patches (1.31.13/1.35.2) - https://phabricator.wikimedia.org/T270466 (10sbassett) 05Stalled→03Resolved Sent. https://lists.wikimedia.org/piperma... [20:17:18] 10MediaWiki-Releasing, 10Security-Team, 10Security, 10user-sbassett: Write and send supplementary release announcement for extensions and skins with security patches (1.31.13/1.35.2) - https://phabricator.wikimedia.org/T270466 (10sbassett) [21:52:38] (03PS3) 10Krinkle: jjb: Change oojs-core-node10 job from 'npm test' to 'npm run jenkins' [integration/config] - 10https://gerrit.wikimedia.org/r/682029 [21:53:12] (03PS4) 10Krinkle: jjb: Change oojs-core-node10 job from 'npm test' to 'npm run jenkins' [integration/config] - 10https://gerrit.wikimedia.org/r/682029 [21:55:12] James_F: yeah, I'm kind of in the middle on the grunt thing. I think cutting down needless indirection such as for eslint, karma and jsdoc is generally a plus. It moves us closer to upstream, and is easier to understand for new comers used to those tools elsewhere (grunt is getting old for that kind of stuff, and afaik the main reason it was as widely integrated as it was is because people didn't realize the potential of npm-run, and [21:55:12] because it had a promise of "one day" making it run in parallel, somehow, but it never did, so it just makes it slower for no reason). [21:55:39] But, at the same time I also fully agree that there is no point in avoiding Grunt for its own sake when it makes something simpler. No need to add risk or complexity to purposefully avoid it. [21:55:56] And for actual "build" stuff like for oojs/ve/ooui, it makes sense as it it. [21:57:32] Krinkle: Yeah, and the consistency between our 2000 repos is helpful for automation. [21:59:21] Yeah, it's been brought up in FSG a few times. I think we're leaning towards not using it for things where direct use is simpler and more idiomatic. But.. it was also brought up that we should not do it by hand each time. libup makes sense here. [21:59:37] although I forgot to mention libup last time [21:59:43] I'll try to remember it for next time we meet [21:59:47] I'm totally happy to support someone making a patch to LibUp to migrate things. [22:00:12] But just making random changes and then being surprised that the repos no longer get security updates is not cool. [22:06:24] (03PS5) 10Krinkle: jjb: Change oojs-core-node10 job from 'npm test' to 'npm run jenkins' [integration/config] - 10https://gerrit.wikimedia.org/r/682029 [22:08:15] (03CR) 10Krinkle: "Minimal diff as expected:" [integration/config] - 10https://gerrit.wikimedia.org/r/682029 (owner: 10Krinkle) [22:10:14] (03CR) 10Krinkle: "Updated:" [integration/config] - 10https://gerrit.wikimedia.org/r/682029 (owner: 10Krinkle) [22:13:01] (03CR) 10Krinkle: [C: 03+2] jjb: Change oojs-core-node10 job from 'npm test' to 'npm run jenkins' [integration/config] - 10https://gerrit.wikimedia.org/r/682029 (owner: 10Krinkle) [22:14:18] (03Merged) 10jenkins-bot: jjb: Change oojs-core-node10 job from 'npm test' to 'npm run jenkins' [integration/config] - 10https://gerrit.wikimedia.org/r/682029 (owner: 10Krinkle) [22:14:50] !log Reloading Zuul to deploy https://gerrit.wikimedia.org/r/682029 [22:14:52] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [22:48:16] Krinkle: You OK with us back-porting the jQuery bump to REL1_36? [22:48:36] The deadline for RC.0 is essentially now. [22:49:05] James_F: Hm.. well, yes/no. Yes, I'd like to. But also, would be good to have a week or two prod exposure [22:49:10] but rc is fine yeah [22:49:26] and yeah, I guess that's a little backwards :P [22:49:28] We'll have time to fix things from RC.0. [22:49:32] Also yes. :-) [22:50:03] James_F: I saw your comments re: removing gitbuld on ed's patch, I restored it my stack after I read that. [22:50:06] makes sense indeed :) [22:50:19] Ack. [22:50:30] I forgot about the case of running npm-test and then publishing that without running a proper build first after e.g. checking out a differnet commit [22:52:34] James_F: I think rel136 notes are now diverging btw [22:52:45] I think I missed one earlier as well [22:53:11] Yeah, I'll go through them this weekend. [22:53:46] I imagine most are false negative instead of false positive, e.g. properly backported, but notes missing imaster which is fine given we'll remove that file in master at rc.0 I think. But some might be false positive, e.g. in master and meant to backport but havent' yet. [22:54:13] those would be good to know about that yeah [22:54:39] When we "remove" it from master we move it into HISTORY. [22:54:50] So it's important that REL1_36 and master agree, whichever way around. [22:55:15] `git diff REL1_36.. RELEASE-NOTES-1.36` is my friend. [22:55:22] I was going to update https://gerrit.wikimedia.org/r/c/mediawiki/core/+/678086 once 1.36 was tagged and that can be done at the same time [22:56:13] Omnibus commits like that are really complicated. It's much better to write individual back-ports or fixes per commit which can be decided on a per-item basis. [22:56:45] okay, noted [22:59:50] 10MediaWiki-Codesniffer, 10User-DannyS712: PHPCS should send a warning when tests don't call parent::setUp(), parent::tearDown(), etc. - https://phabricator.wikimedia.org/T281008 (10DannyS712) [23:06:12] (03CR) 10DannyS712: "This change is ready for review." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/682165 (https://phabricator.wikimedia.org/T281008) (owner: 10DannyS712)