[01:38:09] 10Phabricator, 10Data³: Phab feature request: Cycle time for a task entering a column to resolution, with support for wildcards - https://phabricator.wikimedia.org/T148805 (10mmodell) a:03mmodell [01:48:01] James_F: thoughts on backporting IncludeMigrate as option to 1.35.x? [01:48:20] I thought it'd be nice to give LTS sites the option to turn it off since it's been spewing warnings since 2017 [01:48:42] Krinkle: Would be nice, yes. [01:48:54] OK, I'm ripping out the IE9 code again [01:48:59] Ha. [01:49:05] backporting that config flag !+ backporting the migrate patch [01:49:08] != * [01:49:28] If you've monkey-patched IE9 to pass our ES5 tests but somehow not open a console object, you deserve what you get. [01:50:14] :) [01:50:37] (Also well done on getting access to the IE9 source code.) [01:52:38] oh, I forgot IE9 doesn't pass ES5 strict [01:52:44] right, yeah, that makes sense [01:52:47] Indeed. [01:52:56] :-D [02:02:34] Managed to golf the delta down to +42 B for adding the more details counters [02:02:49] plus the various KB added in 3.6.0 [02:02:54] but we'll work our way down from now [02:02:58] Yeah. [03:46:30] James_F: huh, so now VE build is failing too, and presumably has been for a while [03:46:44] but hashar did see correctly that deploying Firefox 68 esr passed [03:46:55] https://gerrit.wikimedia.org/r/c/VisualEditor/VisualEditor/+/677666 [03:46:56] https://integration.wikimedia.org/ci/job/visualeditor-node10-browser-docker/2088/console [03:46:59] it was passing 10 days ago [03:47:03] so something else broke it? [03:47:41] last passing build: [03:47:42] exec docker run --shm-size 1g --volume /srv/jenkins/workspace/workspace/visualeditor-node10-browser-docker/src:/src --volume /srv/jenkins/workspace/workspace/visualeditor-node10-browser-docker/cache:/cache --volume /srv/jenkins/workspace/workspace/visualeditor-node10-browser-docker/log:/log --security-opt seccomp=unconfined --init --rm --label jenkins.job=visualeditor-node10-browser-docker --label jenkins.build=2088 --env-file [03:47:42] /dev/fd/63 docker-registry.wikimedia.org/releng/node10-test-browser:0.6.3 [03:47:54] currently: [03:47:55] exec docker run --shm-size 1g --volume /srv/jenkins/workspace/workspace/visualeditor-node10-browser-docker/src:/src --volume /srv/jenkins/workspace/workspace/visualeditor-node10-browser-docker/cache:/cache --volume /srv/jenkins/workspace/workspace/visualeditor-node10-browser-docker/log:/log --security-opt seccomp=unconfined --init --rm --label jenkins.job=visualeditor-node10-browser-docker --label jenkins.build=2091 --env-file [03:47:55] /dev/fd/63 docker-registry.wikimedia.org/releng/node10-test-browser:0.6.3 [03:48:13] looks the same, I got nothing [03:48:43] the passing build also already used Karma 6 despite the deprecation warning from grunt-karma using the karma 5.x style internally [03:48:50] * Krinkle shrugs [03:52:59] maybe the docker version or host system kernal changed in a way that messes up FIrefox [03:53:43] I mean that's grasping at straws but given the version is the same, and I assume we've not like force pushed and overwrote the container registry, it is a completely identical image. [04:00:18] Maybe, yeah. [04:00:28] I have a buster migration for those jobs lying around somewhere. [05:31:03] (03CR) 10DannyS712: [C: 03+2] "Double checked the report against core - all flagged places appear to be correct, plus the tests here show all of the other edge cases, le" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/662110 (https://phabricator.wikimedia.org/T274038) (owner: 10Umherirrender) [05:32:33] (03Merged) 10jenkins-bot: Add a new StaticClosureSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/662110 (https://phabricator.wikimedia.org/T274038) (owner: 10Umherirrender) [08:36:26] (03PS2) 10Umherirrender: build: Split scripts in composer.json from "composer test" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/681489 [08:45:02] (03CR) 10Umherirrender: "This is no longer needed since I9d4771c28160356ff58884e3a58fa28c8db4e8a5" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/682165 (https://phabricator.wikimedia.org/T281008) (owner: 10DannyS712) [08:48:39] 10phan: Enforce use of static closures - https://phabricator.wikimedia.org/T274038 (10Umherirrender) 05Open→03Resolved a:03Umherirrender [08:52:21] (03PS7) 10Umherirrender: Allow non-two-characters prefixes for global variables [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/678304 (https://phabricator.wikimedia.org/T279814) (owner: 10Alex Mashin) [08:52:25] (03CR) 10Umherirrender: [C: 03+2] Allow non-two-characters prefixes for global variables [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/678304 (https://phabricator.wikimedia.org/T279814) (owner: 10Alex Mashin) [08:53:19] 10MediaWiki-Codesniffer, 10Patch-For-Review: ValidGlobalNameSniff assumes that allowed global variable name prefix always consists of two characters - https://phabricator.wikimedia.org/T279814 (10Umherirrender) 05Open→03Resolved [08:54:01] (03Merged) 10jenkins-bot: Allow non-two-characters prefixes for global variables [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/678304 (https://phabricator.wikimedia.org/T279814) (owner: 10Alex Mashin) [08:54:50] (03Abandoned) 10Umherirrender: Fix ValidGlobalNameSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/467117 (owner: 10MGChecker) [08:55:54] (03CR) 10Umherirrender: [C: 03+1] "Ib9aabcb350fbfe7e6ffe6ad7e4a7e4956eb9eaa5 was older and I have merged that first. Please rebase. Thanks." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/681372 (https://phabricator.wikimedia.org/T279968) (owner: 10DannyS712) [12:23:21] 10Release-Engineering-Team (Radar), 10MediaWiki-Docker, 10Developer Productivity, 10Patch-For-Review, 10User-Addshore: Port mediawiki-docker-dev "mwdd" v1 cli in to go - https://phabricator.wikimedia.org/T253313 (10Addshore) https://gerrit.wikimedia.org/r/c/mediawiki/tools/cli/+/682240 gets the code to a... [12:35:56] 10phan-taint-check-plugin, 10Patch-For-Review: Optimize phan-taint-check speed - https://phabricator.wikimedia.org/T203651 (10Daimona) Alright, so, I've reached a conclusion and am going to write a detailed explanation here for future reference. One of the things that make taint-check slow is the following me... [12:36:54] 10phan-taint-check-plugin: Investigate running taint-check with analyze-twice - https://phabricator.wikimedia.org/T269816 (10Daimona) Quick analysis done at T203651#7031088. Comparison for MW core: > time: 2m 2s -> 2m 35s > memory: 3733 MB -> 4125 MB > +99 issues (some are duplicates, some are unused suppressions) [13:21:27] 10Phabricator (Upstream), 10Upstream: Auto calculate story points from subtasks - https://phabricator.wikimedia.org/T122404 (10Aklapper) 05Open→03Declined We don't plan to change this behavior on the Wikimedia side. If this is wanted, please bring this up in https://discourse.phabricator-community.org/ [17:06:32] 10Beta-Cluster-Infrastructure, 10Machine-Learning-Team: ores-beta.wmflabs.org is unreachable - https://phabricator.wikimedia.org/T280420 (10elukey) 05Open→03Resolved a:03elukey Fixed with a deployment, see T278723 [17:32:15] (03CR) 10Jforrester: [C: 03+2] build: Split scripts in composer.json from "composer test" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/681489 (owner: 10Umherirrender) [17:35:01] (03Merged) 10jenkins-bot: build: Split scripts in composer.json from "composer test" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/681489 (owner: 10Umherirrender) [17:41:17] (03PS2) 10Jforrester: Zuul: [mediawiki/extensions/MultimediaViewer] Drop Ruby selenium test job [integration/config] - 10https://gerrit.wikimedia.org/r/681859 [17:45:39] (03CR) 10Jforrester: [C: 03+2] Zuul: [mediawiki/extensions/MultimediaViewer] Drop Ruby selenium test job [integration/config] - 10https://gerrit.wikimedia.org/r/681859 (owner: 10Jforrester) [17:46:50] (03Merged) 10jenkins-bot: Zuul: [mediawiki/extensions/MultimediaViewer] Drop Ruby selenium test job [integration/config] - 10https://gerrit.wikimedia.org/r/681859 (owner: 10Jforrester) [17:47:42] !log Zuul: [mediawiki/extensions/MultimediaViewer] Drop Ruby selenium test job [17:47:45] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [18:43:07] 10Continuous-Integration-Config, 10LibUp, 10phan, 10Composer: Run phan as part of composer test, rather than in bespoke CI jobs - https://phabricator.wikimedia.org/T280990 (10Daimona) >>! In T280990#7030014, @Legoktm wrote: > Unless we make the php-ast dependency optional (or support older, packaged versio... [19:47:39] (03CR) 10DannyS712: "> Patch Set 2:" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/682165 (https://phabricator.wikimedia.org/T281008) (owner: 10DannyS712) [19:47:44] (03PS6) 10DannyS712: ValidGlobalNameSniff: don't return on first valid name [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/681372 (https://phabricator.wikimedia.org/T279968) [19:49:26] (03PS7) 10DannyS712: ValidGlobalNameSniff: don't return on first valid name [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/681372 (https://phabricator.wikimedia.org/T279968) [20:28:10] (03CR) 10Daimona Eaytoy: "I agree with Umherirrender, this can (and should, if possible) be done with annotations in MW core." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/682165 (https://phabricator.wikimedia.org/T281008) (owner: 10DannyS712) [22:12:35] (03CR) 10Umherirrender: [C: 03+2] ValidGlobalNameSniff: don't return on first valid name [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/681372 (https://phabricator.wikimedia.org/T279968) (owner: 10DannyS712) [22:14:11] (03Merged) 10jenkins-bot: ValidGlobalNameSniff: don't return on first valid name [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/681372 (https://phabricator.wikimedia.org/T279968) (owner: 10DannyS712) [22:16:09] 10MediaWiki-Codesniffer, 10User-DannyS712: MediaWiki.NamingConventions.ValidGlobalName stops validation after php reserved global - https://phabricator.wikimedia.org/T279968 (10Umherirrender) 05Open→03Resolved a:03DannyS712 [22:39:11] (03PS1) 10Umherirrender: Add Customization section to README [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/682272 (https://phabricator.wikimedia.org/T274016) [22:48:12] (03CR) 10Umherirrender: "Could extend the test wf_global_function_config.php to test different settings." (033 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/661937 (https://phabricator.wikimedia.org/T274007) (owner: 10DannyS712) [22:49:24] 10MediaWiki-Codesniffer, 10Documentation, 10Patch-For-Review, 10User-DannyS712: Document sniffs that support configuration properties - https://phabricator.wikimedia.org/T274016 (10Umherirrender) p:05Triage→03Medium a:03Umherirrender [22:53:29] 10Continuous-Integration-Config, 10MediaWiki-Codesniffer: Add cache support to PHPCode_Sniffer jobs - https://phabricator.wikimedia.org/T146644 (10Umherirrender) eslint also allows caching and it is enabled on all repos, but there is not a task to enable/use the cache on CI for eslint. It is worth to keep the... [22:56:16] 10phan, 10Patch-For-Review: Sniff or phan rule against use `?:` and `if` on returns that may be a string - https://phabricator.wikimedia.org/T258227 (10Umherirrender) [22:58:09] 10MediaWiki-Codesniffer, 10User-DannyS712: Sniff for wrong order of PHPUnit assert parameters - https://phabricator.wikimedia.org/T253910 (10Umherirrender) 05Open→03Resolved