[00:43:15] 10Release-Engineering-Team (Doing), 10Patch-For-Review, 10Release, 10Train Deployments: 1.37.0-wmf.3 deployment blockers - https://phabricator.wikimedia.org/T278347 (10tstarling) [01:07:29] 10Release-Engineering-Team (Yak Shaving 🐃🪒), 10MediaWiki-Release-Tools, 10User-brennen: branch.py: Convert deleted wmf branches to tags - https://phabricator.wikimedia.org/T250095 (10brennen) > What value do we hope to get from having these tags, indefinitely? I suppose it would offer to know that a certain... [01:13:13] (03PS1) 10Jforrester: Stop branching the JADE extension for production [tools/release] - 10https://gerrit.wikimedia.org/r/683455 (https://phabricator.wikimedia.org/T281418) [01:41:15] (03PS4) 10Jforrester: MediaWiki.Usage.DeprecatedConstantUsage: Replace DB_MASTER from 1.36.0+ [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/679917 (https://phabricator.wikimedia.org/T278026) [01:46:52] (03PS3) 10Jforrester: README: Add Configuration section to document adjustable sniffs [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/682272 (https://phabricator.wikimedia.org/T274016) (owner: 10Umherirrender) [01:47:54] (03CR) 10Jforrester: [C: 03+1] "PS3: Re-wrote into more natural English. A second set of eyes would be appreciated." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/682272 (https://phabricator.wikimedia.org/T274016) (owner: 10Umherirrender) [01:56:46] (03CR) 10Legoktm: [C: 03+2] "> > No, but LibUp will update all the old extension branches too." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/679917 (https://phabricator.wikimedia.org/T278026) (owner: 10Jforrester) [01:58:03] (03CR) 10Jforrester: "> Patch Set 4: Code-Review+2" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/679917 (https://phabricator.wikimedia.org/T278026) (owner: 10Jforrester) [01:58:25] (03Merged) 10jenkins-bot: MediaWiki.Usage.DeprecatedConstantUsage: Replace DB_MASTER from 1.36.0+ [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/679917 (https://phabricator.wikimedia.org/T278026) (owner: 10Jforrester) [01:59:13] legoktm: Thanks! If you're OK with https://gerrit.wikimedia.org/r/c/mediawiki/tools/codesniffer/+/682272 I was going to cut a release. [02:00:08] personally I'd put the docs on-wiki but I'll +2 it [02:00:17] I mean, both would be good. [02:00:28] * James_F grins. [02:00:42] (03CR) 10Legoktm: [C: 03+2] README: Add Configuration section to document adjustable sniffs [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/682272 (https://phabricator.wikimedia.org/T274016) (owner: 10Umherirrender) [02:02:18] (03Merged) 10jenkins-bot: README: Add Configuration section to document adjustable sniffs [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/682272 (https://phabricator.wikimedia.org/T274016) (owner: 10Umherirrender) [02:07:14] * legoktm looks at open LibUp patches [02:21:33] (03PS1) 10Jforrester: Release v36.0.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/683466 (https://phabricator.wikimedia.org/T278653) [02:23:36] (03CR) 10Jforrester: Release v36.0.0 (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/683466 (https://phabricator.wikimedia.org/T278653) (owner: 10Jforrester) [03:50:24] (03CR) 10Legoktm: [C: 03+2] Release v36.0.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/683466 (https://phabricator.wikimedia.org/T278653) (owner: 10Jforrester) [03:52:03] (03Merged) 10jenkins-bot: Release v36.0.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/683466 (https://phabricator.wikimedia.org/T278653) (owner: 10Jforrester) [06:44:31] 10Beta-Cluster-Infrastructure, 10Jade, 10Patch-For-Review, 10User-Ladsgroup: Undeploy JADE extension from beta cluster - https://phabricator.wikimedia.org/T281418 (10jcrespo) I don't really know much about the extension, but please involve #DBA s if it may have generated some tables or extra rows on other... [07:18:49] (03CR) 10Thiemo Kreuz (WMDE): "Nice, thanks for the update!" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/682272 (https://phabricator.wikimedia.org/T274016) (owner: 10Umherirrender) [07:21:47] hashar: Bonjour! Aurais-tu un moment pour jeter un oeil sur https://gerrit.wikimedia.org/r/c/integration/config/+/681988 ? [07:37:02] gehel: ahhh moaaar sonar ;) [07:38:21] gehel: il faut ajouter les nouveaux jobs dans le pipeline postmerge pour qu'ils soient lancés après qu'un change a été merge [07:43:57] (03CR) 10Hashar: [C: 04-1] "The jobs have to be added to the 'postmerge' pipeline of each project in zuul/layout.yaml :)" (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/681988 (owner: 10Gehel) [07:44:06] gehel: on peut paier ça ce matin si tu veux ;] [07:44:20] 10Release-Engineering-Team (Doing), 10Patch-For-Review, 10Release, 10Train Deployments: 1.37.0-wmf.3 deployment blockers - https://phabricator.wikimedia.org/T278347 (10Jakob_WMDE) [07:44:21] avec plaisir! [07:45:15] hashar: https://meet.google.com/jww-sbmi-dbd [07:45:29] je vais chopper mon casque en haut j'arrive [07:51:07] (03PS4) 10Gehel: Enable sonar analysis post merge for java projects. [integration/config] - 10https://gerrit.wikimedia.org/r/681988 [07:51:21] hashar: ^ [07:52:33] (03CR) 10jerkins-bot: [V: 04-1] Enable sonar analysis post merge for java projects. [integration/config] - 10https://gerrit.wikimedia.org/r/681988 (owner: 10Gehel) [07:58:26] (03PS5) 10Gehel: Enable sonar analysis post merge for java projects. [integration/config] - 10https://gerrit.wikimedia.org/r/681988 [07:59:49] (03CR) 10jerkins-bot: [V: 04-1] Enable sonar analysis post merge for java projects. [integration/config] - 10https://gerrit.wikimedia.org/r/681988 (owner: 10Gehel) [08:03:14] 10phan-taint-check-plugin: Correctly process argument links when backpropagating EXEC taintedness - https://phabricator.wikimedia.org/T274780 (10Daimona) [08:03:16] 10phan-taint-check-plugin: Taint-check trust unsafe array if accessed with ?: operator - https://phabricator.wikimedia.org/T274742 (10Daimona) [08:03:42] 10phan-taint-check-plugin: Taint-check trust unsafe array if accessed with ?: operator - https://phabricator.wikimedia.org/T274742 (10Daimona) Assuming this is a duplicate of the other task. Example above confirmed working [[https://taintcheck.toolforge.org/?code=%3C%3Fphp%0A%0A%2F**%0A+*+%40return+array%0A+*+%4... [08:04:06] (03PS6) 10Gehel: Enable sonar analysis post merge for java projects. [integration/config] - 10https://gerrit.wikimedia.org/r/681988 [08:10:49] (03CR) 10Hashar: [C: 03+2] "INFO:jenkins_jobs.builder:Number of jobs generated: 15" [integration/config] - 10https://gerrit.wikimedia.org/r/681988 (owner: 10Gehel) [08:12:14] (03Merged) 10jenkins-bot: Enable sonar analysis post merge for java projects. [integration/config] - 10https://gerrit.wikimedia.org/r/681988 (owner: 10Gehel) [09:03:01] 10Beta-Cluster-Infrastructure, 10Beta-Cluster-reproducible: Exception: Table 'enwiki.wb_items_per_site' doesn't exist - https://phabricator.wikimedia.org/T281450 (10dom_walden) [09:05:31] 10Beta-Cluster-Infrastructure, 10Wikibase, 10wdwb-tech, 10Beta-Cluster-reproducible: Exception: Table 'enwiki.wb_items_per_site' doesn't exist - https://phabricator.wikimedia.org/T281450 (10dom_walden) Tagging wikibase as they might know about it. [09:05:41] 10Beta-Cluster-Infrastructure, 10Wikibase, 10wdwb-tech, 10Beta-Cluster-reproducible: Exception: Table 'enwiki.wb_items_per_site' doesn't exist - https://phabricator.wikimedia.org/T281450 (10Majavah) Aren't those supposed to exist on `wikidatawiki` and not on `enwiki`? ` wikiadmin@172.16.6.39(enwiki)> show... [09:06:58] 10Beta-Cluster-Infrastructure, 10Wikibase, 10wdwb-tech, 10Beta-Cluster-reproducible: Exception: Table 'enwiki.wb_items_per_site' doesn't exist - https://phabricator.wikimedia.org/T281450 (10Majavah) https://github.com/wikimedia/Wikibase/commit/8c912634c1316be52653dc5514701b124809393d looks related, cc @Luc... [09:08:40] 10Beta-Cluster-Infrastructure, 10Wikibase, 10wdwb-tech, 10Beta-Cluster-reproducible: Exception: Table 'enwiki.wb_items_per_site' doesn't exist - https://phabricator.wikimedia.org/T281450 (10Majavah) [09:08:42] 10Release-Engineering-Team (Doing), 10Release, 10Train Deployments, 10User-brennen: 1.37.0-wmf.4 deployment blockers - https://phabricator.wikimedia.org/T281145 (10Majavah) [09:14:52] 10Beta-Cluster-Infrastructure, 10Jade, 10Patch-For-Review, 10User-Ladsgroup: Undeploy JADE extension from beta cluster - https://phabricator.wikimedia.org/T281418 (10Ladsgroup) Hi @jcrespo AFAIK, this extension was never deployed to production. I assume there's nothing to clean there. Did you seen anything... [09:18:16] 10Beta-Cluster-Infrastructure, 10Jade, 10Patch-For-Review, 10User-Ladsgroup: Undeploy JADE extension from beta cluster - https://phabricator.wikimedia.org/T281418 (10jcrespo) I remember some discussions about storage, but I could be confusing it with another similarly-named extension. I will check the sour... [09:44:44] 10Release-Engineering-Team (Doing), 10Patch-For-Review, 10Release, 10Train Deployments: 1.37.0-wmf.3 deployment blockers - https://phabricator.wikimedia.org/T278347 (10LarsWirzenius) Filed {T281455}, but not as a blocker due only happening once. [09:46:45] 10Release-Engineering-Team (Doing), 10Patch-For-Review, 10Release, 10Train Deployments: 1.37.0-wmf.3 deployment blockers - https://phabricator.wikimedia.org/T278347 (10LarsWirzenius) Filed {T281456}, but not as a train blocker yet. [09:49:26] 10Beta-Cluster-Infrastructure, 10Jade, 10Patch-For-Review, 10User-Ladsgroup: Undeploy JADE extension from beta cluster - https://phabricator.wikimedia.org/T281418 (10jcrespo) I double checked, and wasn't able to find any table ever created on production including the *jade* name, as the source code suggest... [09:51:10] 10Project-Admins, 10Jade: Archive Jade project - https://phabricator.wikimedia.org/T281430 (10Mainframe98) [10:06:13] 10Release-Engineering-Team (Deployment Training Requests): Deployment training request for mbsantos - https://phabricator.wikimedia.org/T281458 (10MSantos) [10:10:00] 10Release-Engineering-Team (Deployment Training Requests): Deployment training request for mbsantos - https://phabricator.wikimedia.org/T281458 (10MSantos) a:03ArielGlenn @ArielGlenn I'm tagging you since you're the only person that will be attending the meeting Today. I hope I can still make it despite the la... [10:17:32] 10Release-Engineering-Team (Deployment Training Requests): Deployment training request for mbsantos - https://phabricator.wikimedia.org/T281458 (10ArielGlenn) Yes please, just show up! That would be great! [10:31:44] 10Release-Engineering-Team (Deployment Training Requests): Deployment training request for mbsantos - https://phabricator.wikimedia.org/T281458 (10ArielGlenn) p.s. I think we'll have another trainer in the meeting. But most of the time we don't bother to ack the invite :-D [11:33:10] 10Release-Engineering-Team (Doing), 10Release, 10Train Deployments, 10User-brennen: 1.37.0-wmf.4 deployment blockers - https://phabricator.wikimedia.org/T281145 (10hoo) [11:45:10] 10Project-Admins, 10Jade, 10Machine-Learning-Team: Archive Jade project - https://phabricator.wikimedia.org/T281430 (10Peachey88) @Calbon or someone from the #machine-learning-team should triage the tasks, and close off or re-tag tasks as required. [11:52:27] 10Release-Engineering-Team (Deployment Training Requests): Deployment training request for mbsantos - https://phabricator.wikimedia.org/T281458 (10ArielGlenn) Let's see about getting you that +2 on the MediaWiki config repo. Aaaand done by @Reedy already. Please check but you should have the bits; you needed to... [11:56:15] 10Release-Engineering-Team (Deployment Training Requests): Deployment training request for mbsantos - https://phabricator.wikimedia.org/T281458 (10ArielGlenn) 05Open→03Resolved Thanks for showing up, and please come again AND tell your friends! See you at a deploy window again soon! Adding @thcipriani as a F... [12:01:00] 10Beta-Cluster-Infrastructure, 10Jade, 10MediaWiki-ContentHandler, 10Patch-For-Review, 10User-DannyS712: Beta cluster: The content model 'JadeJudgment' is not registered - https://phabricator.wikimedia.org/T247476 (10Ladsgroup) Jade is undeployed from beta: {T281418} Fixing this should be easier now. May... [12:02:00] 10Release-Engineering-Team (Doing), 10Patch-For-Review, 10Release, 10Train Deployments: 1.37.0-wmf.3 deployment blockers - https://phabricator.wikimedia.org/T278347 (10LarsWirzenius) [12:07:34] 10Beta-Cluster-Infrastructure, 10Jade, 10Patch-For-Review, 10User-Ladsgroup: Undeploy JADE extension from beta cluster - https://phabricator.wikimedia.org/T281418 (10Ladsgroup) I dropped its tables from beta cluster enwiki. There are so many more places (wikis) to drop I assume. [12:10:05] (03PS1) 10Gehel: Fix location of maven site [integration/config] - 10https://gerrit.wikimedia.org/r/683586 [12:11:11] (03PS2) 10Gehel: Fix location of maven site [integration/config] - 10https://gerrit.wikimedia.org/r/683586 [12:11:32] hashar: and of course, there was an issue with those new jobs ^ [12:11:46] ;D [12:12:46] gehel: jobs updated! [12:12:54] thanks! [12:13:11] though hmm [12:13:16] I haven't looked at the jjb diff [12:13:42] https://integration.wikimedia.org/ci/job/integration-config-jjb-diff-docker/3533/console [12:13:46] yeah looks correct [12:14:12] (03CR) 10Hashar: "Jobs updated!" [integration/config] - 10https://gerrit.wikimedia.org/r/683586 (owner: 10Gehel) [12:18:49] 10Gerrit, 10Release-Engineering-Team (Development services), 10Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), 10Security, 10Upstream: Gerrit out of heap - https://phabricator.wikimedia.org/T263008 (10hashar) I wrote a blog post summarizing this adventure: {J232} [12:19:26] hashar: still an issue with publishing the site: https://integration.wikimedia.org/ci/job/analytics-wmde-toolkit-analyzer-maven-java8-docker-site-publish/3/console [12:19:32] meeting time, I'll look into it later [12:19:38] !log dropping jade_diff_judgement, jade_diff_label, jade_revision_judgement, jade_revision_label tables on all-labs.dblist T281418 [12:19:41] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [12:19:41] T281418: Undeploy JADE extension from beta cluster - https://phabricator.wikimedia.org/T281418 [12:23:19] (03PS1) 10Gehel: Fix wrong path in publishing maven site. [integration/config] - 10https://gerrit.wikimedia.org/r/683587 [12:23:40] hashar: ^ and this one shoudl really be godd! [12:23:48] sorry for the mess! [12:23:56] gehel: at least the build orks [12:25:22] (03PS3) 10Hashar: Fix location of maven site [integration/config] - 10https://gerrit.wikimedia.org/r/683586 (owner: 10Gehel) [12:25:44] (03Abandoned) 10Hashar: Fix wrong path in publishing maven site. [integration/config] - 10https://gerrit.wikimedia.org/r/683587 (owner: 10Gehel) [12:25:48] 10Beta-Cluster-Infrastructure, 10Jade, 10Patch-For-Review, 10User-Ladsgroup: Undeploy JADE extension from beta cluster - https://phabricator.wikimedia.org/T281418 (10Ladsgroup) What's next? Removing it from the branching tool? [12:26:04] gehel: jobs updated, and I have squashed the second change in the original one which I hadn't +2ed yet ;) [12:26:17] Oh, I thought it was merged already [12:26:27] (03CR) 10Hashar: "Deployed ;)" [integration/config] - 10https://gerrit.wikimedia.org/r/683586 (owner: 10Gehel) [12:30:20] and it worked! [12:45:35] gehel: merging!! kudos! [12:45:52] (03CR) 10Hashar: [C: 03+2] "Guillaume confirmed it is working ;)" [integration/config] - 10https://gerrit.wikimedia.org/r/683586 (owner: 10Gehel) [12:47:44] (03Merged) 10jenkins-bot: Fix location of maven site [integration/config] - 10https://gerrit.wikimedia.org/r/683586 (owner: 10Gehel) [13:08:06] 10phan-taint-check-plugin: Avoid setting EXEC bits on variables - https://phabricator.wikimedia.org/T281475 (10Daimona) [13:08:45] 10Release-Engineering-Team (Doing), 10Patch-For-Review, 10Release, 10Train Deployments: 1.37.0-wmf.3 deployment blockers - https://phabricator.wikimedia.org/T278347 (10LarsWirzenius) Promoted train to group1. [13:31:03] 10phan-taint-check-plugin: Backpropagate method links without TaintednessBackpropVisitor - https://phabricator.wikimedia.org/T281478 (10Daimona) [13:31:16] 10phan-taint-check-plugin: Avoid setting EXEC bits on variables - https://phabricator.wikimedia.org/T281475 (10Daimona) [13:31:18] 10phan-taint-check-plugin: Backpropagate method links without TaintednessBackpropVisitor - https://phabricator.wikimedia.org/T281478 (10Daimona) [13:32:00] 10phan-taint-check-plugin: Backpropagate method links without TaintednessBackpropVisitor - https://phabricator.wikimedia.org/T281478 (10Daimona) [13:32:36] 10phan-taint-check-plugin: Backpropagate method links without TaintednessBackpropVisitor - https://phabricator.wikimedia.org/T281478 (10Daimona) [13:32:38] 10phan-taint-check-plugin: Correctly process argument links when backpropagating EXEC taintedness - https://phabricator.wikimedia.org/T274780 (10Daimona) [13:33:40] 10phan-taint-check-plugin: Correctly process argument links when backpropagating EXEC taintedness - https://phabricator.wikimedia.org/T274780 (10Daimona) >>! In T274780#7033442, @Daimona wrote: > the case without intermediate variables can be addressed by handling AST_*CALL nodes in TaintednessBackpropVisitor si... [13:38:45] 10phan-taint-check-plugin: Implement NUMKEY propagation the proper way - https://phabricator.wikimedia.org/T281479 (10Daimona) [13:39:02] 10phan-taint-check-plugin: Backpropagate method links without TaintednessBackpropVisitor - https://phabricator.wikimedia.org/T281478 (10Daimona) [13:39:18] 10phan-taint-check-plugin: Implement NUMKEY propagation the proper way - https://phabricator.wikimedia.org/T281479 (10Daimona) [13:39:20] 10phan-taint-check-plugin: Backpropagate method links without TaintednessBackpropVisitor - https://phabricator.wikimedia.org/T281478 (10Daimona) [13:42:05] 10Release-Engineering-Team (Doing), 10Patch-For-Review, 10Release, 10Train Deployments: 1.37.0-wmf.3 deployment blockers - https://phabricator.wikimedia.org/T278347 (10LarsWirzenius) Filed {T281480}, but not as a blocker. [13:42:12] 10phan-taint-check-plugin: Stop setting PRESERVE_TAINT in PreTaintednessVisitor - https://phabricator.wikimedia.org/T281481 (10Daimona) [13:44:18] 10Release-Engineering-Team (Doing), 10Patch-For-Review, 10Release, 10Train Deployments: 1.37.0-wmf.3 deployment blockers - https://phabricator.wikimedia.org/T278347 (10LarsWirzenius) [13:44:52] 10Release-Engineering-Team (Doing), 10Patch-For-Review, 10Release, 10Train Deployments: 1.37.0-wmf.3 deployment blockers - https://phabricator.wikimedia.org/T278347 (10LarsWirzenius) Filed {T281482}, but not as a blocker. [14:58:04] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10Release, 10User-DannyS712: Release mediawiki-codesniffer v36.0.0 - https://phabricator.wikimedia.org/T278653 (10Jdforrester-WMF) 05Open→03Resolved a:03Jdforrester-WMF [15:02:54] liw: what does the IP on https://phabricator.wikimedia.org/T281480 actually resolve too? [15:04:05] RhinosF1, I don't know, sorry [15:04:39] liw: RhinosF1: 102.32.64.10.in-addr.arpa domain name pointer es1022.eqiad.wmnet. [15:06:02] 10phan-taint-check-plugin: Reduce memory usage - https://phabricator.wikimedia.org/T281491 (10Daimona) [15:06:12] Majavah: https://grafana.wikimedia.org/d/000000273/mysql?viewPanel=9&orgId=1&var-server=es1022&var-port=9104 doesn't show it going above max connections [15:07:50] liw: what time were them exceptions? [15:08:08] In UTC [15:09:35] RhinosF1, am in meeting right now, might be able to look that up in an nhour [15:09:36] (03CR) 10Jforrester: [C: 03+2] Stop branching the JADE extension for production [tools/release] - 10https://gerrit.wikimedia.org/r/683455 (https://phabricator.wikimedia.org/T281418) (owner: 10Jforrester) [15:10:23] 10Beta-Cluster-Infrastructure, 10Jade, 10Patch-For-Review, 10User-Ladsgroup: Undeploy JADE extension from beta cluster - https://phabricator.wikimedia.org/T281418 (10Jdforrester-WMF) >>! In T281418#7045393, @Ladsgroup wrote: > What's next? Removing it from the branching tool? Done. [15:10:37] (03Merged) 10jenkins-bot: Stop branching the JADE extension for production [tools/release] - 10https://gerrit.wikimedia.org/r/683455 (https://phabricator.wikimedia.org/T281418) (owner: 10Jforrester) [15:11:53] Ok [15:49:45] RhinosF1, re timestamps, there's tens of messages, spikes around 15:20 and 15:25 [15:51:28] 10Release-Engineering-Team (Doing), 10Patch-For-Review, 10Release, 10Train Deployments: 1.37.0-wmf.3 deployment blockers - https://phabricator.wikimedia.org/T278347 (10LarsWirzenius) [15:51:59] T281480 is now a train blocker [15:51:59] T281480: Cannot access the database: Too many connections - https://phabricator.wikimedia.org/T281480 [15:53:09] liw: seen [16:06:58] (03CR) 10Michael Große: "This is probably not ready to be merged just yet, but I'd appreciate any feedback, both about the fundamental approach and any details tha" [integration/config] - 10https://gerrit.wikimedia.org/r/683589 (https://phabricator.wikimedia.org/T278706) (owner: 10Michael Große) [16:34:16] * addshore gets pissed off by go dependencies [16:43:00] 10Release-Engineering-Team (Doing), 10Patch-For-Review, 10Release, 10Train Deployments: 1.37.0-wmf.3 deployment blockers - https://phabricator.wikimedia.org/T278347 (10LarsWirzenius) Rolled back to group0 due to {T281480} [18:09:28] 10MediaWiki-Releasing, 10MW-1.36-notes, 10MW-1.36-release: Write release announcement for 1.36.0-rc.0 - https://phabricator.wikimedia.org/T279463 (10Jdforrester-WMF) a:03Jdforrester-WMF [18:10:49] 10Release-Engineering-Team (Doing), 10Release, 10Train Deployments, 10User-brennen: 1.37.0-wmf.4 deployment blockers - https://phabricator.wikimedia.org/T281145 (10Pchelolo) ### Not very, but notably risky patch! 🚂🔥 * **Change**: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/682328 * **What it does/... [18:27:12] 10MediaWiki-Releasing, 10MW-1.36-notes, 10MW-1.36-release: Write release announcement for 1.36.0-rc.0 - https://phabricator.wikimedia.org/T279463 (10Jdforrester-WMF) [18:32:30] 10MediaWiki-Codesniffer, 10Documentation, 10User-DannyS712: Document sniffs that support configuration properties - https://phabricator.wikimedia.org/T274016 (10Umherirrender) 05Open→03Resolved [18:33:34] (03CR) 10Umherirrender: [C: 03+1] "The config section in the readme needs now an entry for the new config here (see I9c60ea4995a790842c3648e80257c676613e01f1 for more inform" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/661937 (https://phabricator.wikimedia.org/T274007) (owner: 10DannyS712) [18:35:25] (03PS12) 10Umherirrender: Check for superfluous @return statements and missing void types [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/658070 [18:38:20] 10MediaWiki-Codesniffer, 10Regression, 10User-DannyS712: PHPCS incorrectly autofixing array key access over multiple lines - https://phabricator.wikimedia.org/T273264 (10Umherirrender) 05Open→03Resolved a:03DannyS712 Now part of 36.0.0 [18:44:31] 10Release-Engineering-Team (Doing), 10Instrument-ClientError, 10Documentation, 10User-brennen: Deploy process should be updated so JavaScript errors block the train - https://phabricator.wikimedia.org/T274000 (10Jdlrobson) Are Release Engineering getting these alerts or using them for the 1hr following a t... [18:50:34] 10Gerrit, 10Release-Engineering-Team (Radar): Gerrit: default branch for new projects should be "main" - https://phabricator.wikimedia.org/T279612 (10brennen) > Ideally I'd prefer to rename that branch in all repos (and docs) at once (which breaks things and requires way more work and coordination, obviously).... [18:55:53] 10phan-taint-check-plugin: Investigate running taint-check with analyze-twice - https://phabricator.wikimedia.org/T269816 (10Daimona) So I'd like to proceed in this direction, since --analyze-twice would allow us to simplify and speed up a couple of things in taint-check. Two things, for the record, that are cur... [19:07:31] 10MediaWiki-Codesniffer, 10Composer: Files don't comply with psr-4 autoloading standard - https://phabricator.wikimedia.org/T278282 (10Umherirrender) 05Open→03Resolved the mention files here are tests files and test files are not part of the package. There is no message when using the older package as well... [19:26:20] 10MediaWiki-Releasing, 10MW-1.36-notes, 10MW-1.36-release: Release 1.36.0-rc.0 - https://phabricator.wikimedia.org/T279462 (10Jdlrobson) [19:44:40] kostajh: around at all? [20:00:47] 10phan: Analyze why phan does not report a possible undeclared variable on short-circuit code with pass-by-ref variable - https://phabricator.wikimedia.org/T281524 (10Umherirrender) [20:01:19] 10phan: Analyze why phan does not report a possible undeclared variable on short-circuit code with pass-by-ref variable - https://phabricator.wikimedia.org/T281524 (10Umherirrender) [20:20:58] 10MediaWiki-Releasing, 10MW-1.36-notes, 10MW-1.36-release: Write release announcement for 1.36.0-rc.0 - https://phabricator.wikimedia.org/T279463 (10Reedy) [20:21:41] 10MediaWiki-Releasing, 10MW-1.36-notes, 10MW-1.36-release: Write release announcement for 1.36.0-rc.0 - https://phabricator.wikimedia.org/T279463 (10Reedy) [21:21:32] longma: are you okay if I try and make a mwcli phab board? [21:21:37] (and try not to make a mess) [21:27:25] Yeah! Sounds good! [21:27:46] It's a pretty clear path to getting all the mwdd stuff in now :) [21:27:49] exciting [21:28:39] yeah! [21:40:37] epic ! https://phabricator.wikimedia.org/project/board/5331/ I'm going to go through the tasks on the mediawiki-docker board, and also make some new ones [21:41:52] 10Release-Engineering-Team (Radar), 10mwcli, 10Developer Productivity, 10Patch-For-Review, 10User-Addshore: Port mediawiki-docker-dev "mwdd" v1 cli in to go - https://phabricator.wikimedia.org/T253313 (10Addshore) [21:43:12] 10Release-Engineering-Team (Radar), 10mwcli, 10Developer Productivity, 10Patch-For-Review, 10User-Addshore: Port mediawiki-docker-dev "mwdd" v1 cli in to go - https://phabricator.wikimedia.org/T253313 (10Addshore) [21:43:19] 10Release-Engineering-Team (Seen), 10MediaWiki-Docker, 10Developer Productivity, 10User-Addshore: Provide a way to import or discover new mw cli commands and docker-compose files from multiple sources - https://phabricator.wikimedia.org/T253315 (10Addshore) 05Open→03Declined Declining this in its curre... [21:44:49] 10Release-Engineering-Team (Radar), 10mwcli, 10Developer Productivity, 10Patch-For-Review, 10User-Addshore: mwdd: Port mediawiki-docker-dev "mwdd" v1 cli in to go - https://phabricator.wikimedia.org/T253313 (10Addshore) [21:46:41] 10Release-Engineering-Team (Radar), 10mwcli, 10Developer Productivity, 10Patch-For-Review, 10User-Addshore: [mwcli mwdd] Port mediawiki-docker-dev "mwdd" v1 cli in to go - https://phabricator.wikimedia.org/T253313 (10Addshore) [21:47:13] (03PS4) 10Dduvall: Support email notification upon stage failure [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/681805 [21:48:48] (03PS5) 10Dduvall: Support email notification upon stage failure [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/681805 [21:50:26] 10Release-Engineering-Team (Radar), 10mwcli, 10Developer Productivity, 10Patch-For-Review, 10User-Addshore: [mwcli mwdd] Port mediawiki-docker-dev "mwdd" v1 cli in to go - https://phabricator.wikimedia.org/T253313 (10Addshore) Also: https://gerrit.wikimedia.org/r/c/mediawiki/tools/cli/+/682309 [21:50:41] (03PS6) 10Dduvall: Support email notification upon stage failure [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/681805 [21:50:58] (03CR) 10Dduvall: [C: 03+1] "Sorry for the noise. Finally ready for review." [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/681805 (owner: 10Dduvall) [21:56:04] 10Release-Engineering-Team (Radar), 10mwcli, 10Developer Productivity, 10Patch-For-Review, 10User-Addshore: [mwcli mwdd] Port mediawiki-docker-dev "mwdd" v1 cli in to go - https://phabricator.wikimedia.org/T253313 (10Addshore) In terms of the checklist from a few days ago, ignoring docs and somewhere to... [22:15:14] 10MediaWiki-Releasing, 10MW-1.36-notes, 10MW-1.36-release: Write release announcement for 1.36.0-rc.0 - https://phabricator.wikimedia.org/T279463 (10Reedy) Tarballs are staged and the 1.36.0-rc.0 tag is pushed. [22:22:03] (03CR) 10Ahmon Dancy: [C: 03+1] "Thanks Dan!" [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/681805 (owner: 10Dduvall) [22:35:04] (03PS1) 10Ahmon Dancy: fix: improve scap update-wikiversions error reporting [tools/scap] - 10https://gerrit.wikimedia.org/r/683744 [22:45:15] (03CR) 10Jforrester: [C: 03+1] fix: improve scap update-wikiversions error reporting [tools/scap] - 10https://gerrit.wikimedia.org/r/683744 (owner: 10Ahmon Dancy) [22:45:20] (03CR) 10Jforrester: [C: 03+1] "Nice." [tools/scap] - 10https://gerrit.wikimedia.org/r/683744 (owner: 10Ahmon Dancy) [23:17:55] 10Continuous-Integration-Config, 10Release-Engineering-Team (Next), 10MediaWiki-Core-Testing, 10Code-Health, and 6 others: Reduce runtime of MW shared gate Jenkins jobs to 5 min - https://phabricator.wikimedia.org/T225730 (10Krinkle) [23:20:28] 10Release-Engineering-Team (Next), 10MediaWiki-Core-Testing, 10Readers-Web-Backlog (Tracking), 10User-Jdlrobson, 10User-zeljkofilipin: Provide generic wrapper inside wdio-mediawiki for API requests - https://phabricator.wikimedia.org/T220712 (10Krinkle) 05Open→03Resolved a:03Krinkle You don't have... [23:20:31] 10Release-Engineering-Team (Radar), 10MediaWiki-Core-Testing, 10Quality-and-Test-Engineering-Team (QTE), 10Epic, 10User-zeljkofilipin: Port Selenium tests from Ruby to Node.js - https://phabricator.wikimedia.org/T139740 (10Krinkle) [23:21:21] 10Continuous-Integration-Infrastructure, 10MW-1.31-release, 10Patch-For-Review: Drop CI for REL1_31 branch once it's EOL - https://phabricator.wikimedia.org/T281294 (10Umherirrender) Other places to remove some pieces https://gerrit.wikimedia.org/g/integration/config/+/d1d911e5b5bf5dbe085bc00d4316ba0b325821... [23:29:23] 10Continuous-Integration-Config, 10Release-Engineering-Team (Radar), 10Patch-For-Review, 10User-zeljkofilipin: Drop Ruby Selenium CI jobs; we don't support them any more - https://phabricator.wikimedia.org/T220035 (10Krinkle) [23:29:31] 10Continuous-Integration-Config, 10Two-Column-Edit-Conflict-Merge: Run core browser tests as part of the gate pipeline build process - https://phabricator.wikimedia.org/T212214 (10Krinkle) [23:31:18] 10Release-Engineering-Team (Seen), 10MediaWiki-Vagrant, 10Browser-Tests: Running selenium inside Vagrant with xvfb or X11 does not work - https://phabricator.wikimedia.org/T196646 (10Krinkle) [23:32:12] 10Release-Engineering-Team (Seen), 10MediaWiki-extensions-Other, 10Browser-Tests, 10User-zeljkofilipin, 10ci-test-error: EditSubpages extension fails mediawiki/core webdriver.io tests - https://phabricator.wikimedia.org/T196436 (10Krinkle) [23:40:02] (03PS2) 10Jforrester: [DNM] Zuul: Drop CI support for REL1_31 branch [integration/config] - 10https://gerrit.wikimedia.org/r/683031 (https://phabricator.wikimedia.org/T281294) [23:40:04] (03PS2) 10Jforrester: [DNM] dockerfiles: [composer-scratch] Upgrade to 2.0.13 and cascade [integration/config] - 10https://gerrit.wikimedia.org/r/683030 (https://phabricator.wikimedia.org/T279857) [23:40:06] (03PS1) 10Jforrester: jjb: [mediawiki-quibble*] Drop REL1_31 support [integration/config] - 10https://gerrit.wikimedia.org/r/683751 [23:40:08] (03PS1) 10Jforrester: jjb: [quibble] Update assert-no-errors to drop REL1_31 skip [integration/config] - 10https://gerrit.wikimedia.org/r/683752 [23:40:21] 10Continuous-Integration-Infrastructure, 10MW-1.31-release, 10Patch-For-Review: Drop CI for REL1_31 branch once it's EOL - https://phabricator.wikimedia.org/T281294 (10Jdforrester-WMF) >>! In T281294#7047634, @Umherirrender wrote: > Other places to remove some pieces > > https://gerrit.wikimedia.org/g/integ... [23:40:48] 10Beta-Cluster-Infrastructure, 10Jade, 10MediaWiki-ContentHandler, 10Patch-For-Review, and 2 others: Beta cluster: The content model 'JadeJudgment' is not registered - https://phabricator.wikimedia.org/T247476 (10Ladsgroup) 05Open→03Resolved a:03Ladsgroup I can't reproduce the error anymore given tha... [23:40:56] (03PS1) 10Jeena Huneidi: Add tests for mw-cli [integration/config] - 10https://gerrit.wikimedia.org/r/683753 (https://phabricator.wikimedia.org/T248779) [23:41:57] 10Beta-Cluster-Infrastructure, 10Jade, 10User-Ladsgroup: Undeploy JADE extension from beta cluster - https://phabricator.wikimedia.org/T281418 (10Ladsgroup) 05Open→03Resolved Let's call it done. Any leftovers missing can be done ad-hoc. The main work is done. We do have {T281430} for rest of the clean up... [23:42:02] (03CR) 10Jeena Huneidi: "I would like to make a VM that has golang installed for these tests" [integration/config] - 10https://gerrit.wikimedia.org/r/683753 (https://phabricator.wikimedia.org/T248779) (owner: 10Jeena Huneidi)