[05:04:15] 10MediaWiki-Codesniffer, 10User-DannyS712: Report unused `use`d variables for anonymous functions - https://phabricator.wikimedia.org/T283446 (10DannyS712) [05:31:49] (03CR) 10Hashar: [C: 03+2] Add mediawiki/skins/WMAU repo [integration/config] - 10https://gerrit.wikimedia.org/r/693554 (owner: 10Samwilson) [05:32:54] (03Merged) 10jenkins-bot: Add mediawiki/skins/WMAU repo [integration/config] - 10https://gerrit.wikimedia.org/r/693554 (owner: 10Samwilson) [07:42:50] (03CR) 10DannyS712: "This change is ready for review." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/693531 (https://phabricator.wikimedia.org/T283446) (owner: 10DannyS712) [07:43:47] (03CR) 10DannyS712: "All of the warnings for core appear to be accurate" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/693531 (https://phabricator.wikimedia.org/T283446) (owner: 10DannyS712) [07:43:51] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-DannyS712: Report unused `use`d variables for anonymous functions - https://phabricator.wikimedia.org/T283446 (10DannyS712) It took a couple hours, but I was able to figure it out [08:47:13] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-DannyS712: Analzye if MediaWiki.PHPUni.tAssertionOrder could handle more complex cases - https://phabricator.wikimedia.org/T281910 (10DannyS712) >>! In T281910#7105789, @gerritbot wrote: > Change 693532 had a related patch set uploaded (by DannyS712; author... [08:47:16] (03CR) 10DannyS712: "This change is ready for review." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/693532 (https://phabricator.wikimedia.org/T281910) (owner: 10DannyS712) [08:53:39] (03CR) 10DannyS712: "Checked a bunch of the new errors for core, all appear to be accurate" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/693532 (https://phabricator.wikimedia.org/T281910) (owner: 10DannyS712) [08:55:34] 10phan, 10Upstream: A linter could report unneeded/unused pass-by-references in php code - https://phabricator.wikimedia.org/T279265 (10DannyS712) >>! In T279265#6972380, @Daimona wrote: > I think this goes well beyond the scope of PHPCS. Phan has similar functionality in VariableTrackerPlugin, but not this sp... [09:09:59] (03CR) 10DannyS712: "This change is ready for review." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/693533 (https://phabricator.wikimedia.org/T278471) (owner: 10DannyS712) [09:10:18] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-DannyS712: codesniffer's RedundantVarNameSniff does not remove var name from @var on static class properties - https://phabricator.wikimedia.org/T278471 (10DannyS712) [09:11:52] 10MediaWiki-Codesniffer, 10MediaWiki-Core-Tests: Stop using MockBuilder::setMethods - https://phabricator.wikimedia.org/T278010 (10DannyS712) (accepted since the patch to create the sniff was merged) [09:14:53] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-DannyS712: phpcs should error on unclosed @codingStandardsIgnoreStart annotations - https://phabricator.wikimedia.org/T127241 (10DannyS712) >>! In T127241#6313987, @Krinkle wrote: > I think that's to the credit of people finding it in code review or fixing... [09:16:12] (03CR) 10DannyS712: "All of the warnings for core appear to be accurate" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/693533 (https://phabricator.wikimedia.org/T278471) (owner: 10DannyS712) [09:24:43] (03CR) 10DannyS712: "This change is ready for review." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/693535 (https://phabricator.wikimedia.org/T273352) (owner: 10DannyS712) [09:24:54] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-DannyS712: Codesniffer should prefer assertSame not assertCount when both part of comparision are count() - https://phabricator.wikimedia.org/T273352 (10DannyS712) [09:26:44] (03PS2) 10Awight: Introduce utility to redirect stdout and stderr [integration/quibble] - 10https://gerrit.wikimedia.org/r/693456 [09:26:56] 10MediaWiki-Codesniffer, 10phan: Consider replacing complex or non-style-related PHPCS sniffs with one or more phan plugins - https://phabricator.wikimedia.org/T270398 (10DannyS712) (Marking as "Upstream PHPCS" since there isn't really a better place for it, these would be essentially upstreamed but to a diffe... [09:29:23] (03CR) 10jerkins-bot: [V: 04-1] Introduce utility to redirect stdout and stderr [integration/quibble] - 10https://gerrit.wikimedia.org/r/693456 (owner: 10Awight) [09:30:34] 10MediaWiki-Codesniffer: Check MediaWiki.Commenting.IllegalSingleLineComment.IllegalSingleLineCommentStart and Doxygen use - https://phabricator.wikimedia.org/T168963 (10DannyS712) The specific `IllegalSingleLineCommentStart` warning appears to have been removed in {cabff30f132a1f884d2df993c905c8f3d06fd2d5} as i... [09:38:17] (03PS2) 10Awight: Expand redirection to capture logging [integration/quibble] - 10https://gerrit.wikimedia.org/r/693457 [09:41:44] 10MediaWiki-Codesniffer, 10Technical-Debt: Warn when a method/class has a @deprecated annotation but no call to wfDeprecated - https://phabricator.wikimedia.org/T205938 (10DannyS712) I propose to decline this task - @deprecated marks soft deprecation, and wfDeprecated is for hard deprecation, and there is freq... [09:43:54] 10MediaWiki-Codesniffer: @coversDefaultClass should be allowed on traits as well as classes (MediaWiki.Commenting.PhpunitAnnotations.NotClass) - https://phabricator.wikimedia.org/T230688 (10DannyS712) 05Open→03Declined Per lack of response above, does not appear needed [09:45:16] 10Continuous-Integration-Config, 10MediaWiki-Core-Tests, 10Documentation: Jenkins-bot should remind users to add documentation for new functions - https://phabricator.wikimedia.org/T179632 (10DannyS712) As noted above, not something we can do in codesniffer - codesniffer checks for everything having document... [09:49:49] 10MediaWiki-Codesniffer: Small improve on autofix of MediaWiki.Usage.IsNullSniff possible to avoid unneeded parenthesis - https://phabricator.wikimedia.org/T242780 (10DannyS712) 05Open→03Invalid I tried to figure this out but I think it would be too complex, and there isn't any harm in having the extra (), b... [09:51:44] (03PS1) 10Awight: [DNM] Investigating CI error [integration/quibble] - 10https://gerrit.wikimedia.org/r/693602 [10:12:17] (03CR) 10DannyS712: "This change is ready for review." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/693537 (https://phabricator.wikimedia.org/T267689) (owner: 10DannyS712) [10:53:11] (03CR) 10DannyS712: "This change is ready for review." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/693538 (https://phabricator.wikimedia.org/T266193) (owner: 10DannyS712) [10:54:05] 10MediaWiki-Codesniffer: Sniff to $wmf* -> $wmg* - https://phabricator.wikimedia.org/T186642 (10DannyS712) (patch was abandoned) [10:55:39] 10MediaWiki-Codesniffer: Sniff to $wmf* -> $wmg* - https://phabricator.wikimedia.org/T186642 (10DannyS712) 05Open→03Invalid There is already a sniff for the variable names, MediaWiki.NamingConventions.ValidGlobalName Cannot really autofix since they are not always used as variables directly, but rather array... [10:58:40] 10MediaWiki-Codesniffer: New Sniff for using pointless variables before return - https://phabricator.wikimedia.org/T179768 (10DannyS712) 05Open→03Declined Per above, there are valid reasons to have a variable assigned right before a return, including that its a static variable, a variable passed by reference... [13:12:14] (03CR) 10Ammarpad: "match is only disallowed in" (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/693537 (https://phabricator.wikimedia.org/T267689) (owner: 10DannyS712) [13:16:37] (03CR) 10Ammarpad: [C: 04-1] Add new MatchReservedSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/693537 (https://phabricator.wikimedia.org/T267689) (owner: 10DannyS712) [13:53:35] 10Release-Engineering-Team (Doing), 10MediaWiki-Docker, 10mwcli, 10Patch-For-Review, 10User-brennen: Set up distribution of MediaWiki-Docker CLI - https://phabricator.wikimedia.org/T250241 (10Addshore) For now so that I can more easily get people testing what I am developing I have started publishing dev... [15:19:23] 10phan: Check for unused arguments in closures - https://phabricator.wikimedia.org/T241718 (10matej_suchanek) This is also being implemented in codesniffer: {T283446}. [16:08:38] 10MediaWiki-Codesniffer, 10Technical-Debt: Warn when a method/class has a @deprecated annotation but no call to wfDeprecated - https://phabricator.wikimedia.org/T205938 (10Krinkle) I agree we shouldn't/can't enforce this in either direction. Soft-deprecation is a thing. Deprecating a specific behaviour or para... [17:15:19] (03CR) 10DannyS712: "> Patch Set 2:" (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/693537 (https://phabricator.wikimedia.org/T267689) (owner: 10DannyS712) [19:12:49] See you on libera!