[09:21:53] 10HTTPS, 10Traffic, 10Operations: WMF servers support ESNI? - https://phabricator.wikimedia.org/T205378 (10MoritzMuehlenhoff) p:05Triage>03Normal [10:22:43] 10HTTPS, 10Traffic, 10Operations, 10Upstream: Enable ESNI support on Wikimedia servers - https://phabricator.wikimedia.org/T205378 (10Krenair) [10:52:27] 10netops, 10Operations: Enable cumin1001 in router ACLs - https://phabricator.wikimedia.org/T205513 (10MoritzMuehlenhoff) Works like a charm! [13:06:23] vgutierrez, about? [13:07:35] yup [13:08:23] I held back on https://gerrit.wikimedia.org/r/#/c/operations/software/certcentral/+/458939/ despite the CR+1 because of your comment [13:08:39] where do you think we should document the 0 byte PEM files? [13:09:16] maybe in the README? at least till we have more extensive documentation in wikitech [13:09:33] or even as a comment in the code [13:09:56] but I think the README should be better.. cause it's a behaviour that could affect the users [13:10:29] hm [13:10:31] ok [13:11:09] and I don't expect for every user to read the source code looking for caveats [13:12:09] yes [13:13:11] and IMHO in a non so far away future we should deliver some documentation in wikitech [13:13:39] (even if I'm not the biggest fan of writing documentation) [13:13:43] +1 :) [13:14:02] hahaha, noted paravoid! [13:15:58] vgutierrez, [13:16:03] +One thing to note is that there are two stages when certcentral is outputting certificates: the [13:16:03] +initial, self-signed certificate, and the publicly trusted one issued through ACME. The initial [13:16:03] +stage is done to help with cases where web servers need a dummy certificate to start up, which [13:16:03] +may be required in order to *get* the publicly-trusted certificates at all (thus resolving a [13:16:04] +chicken-and-egg problem). A side-effect of this is zero-byte PEM files for the chain, which [13:16:05] +for self-signed certificates is empty. [13:16:06] how's this? [13:16:45] maybe the ACME one isn't necessarily publicly-trusted? [13:17:01] and s/web // [13:18:19] yup [13:18:22] +1 [13:19:47] speaking of docs, and this is potentially a horrible high-level comment (I'm just a manager forgive me), but... the README right now doesn't sound very exciting or sexy :) [13:20:16] this LE cert management thing is a common problem, I'm not sure if the description there fully captures how great this piece of SW is :) [13:20:52] needs ascii art, got it [13:20:55] :) [13:20:55] hahaha [13:20:55] you're right, it isn't sexy right now [13:21:04] but let's put it in production and then brag about it [13:21:04] but yes [13:21:06] not the other way around [13:21:14] fair fair :) [13:21:38] I hate conference oriented development :) [13:22:05] but it could be FOSDEM worthy IMHO [13:22:52] for sure [13:27:15] vgutierrez, I've updated the change [14:30:00] vgutierrez, was this what you had in mind? https://gerrit.wikimedia.org/r/#/c/operations/software/certcentral/+/459662/3/tests/test_certcentral.py [14:31:40] should make it pretty difficult for someone to accidentally break it without making the test fail