[07:59:21] Change abandoned: John Erling Blad; "Double upload, should be an amend, see https://gerrit.wikimedia.org/r/#/c/10550/" [mediawiki/extensions/WikidataRepo] (master) - https://gerrit.wikimedia.org/r/10570 [08:49:10] New patchset: Tobias Gritschacher; "JSHint supported code cleanup" [mediawiki/extensions/WikidataRepo] (master) - https://gerrit.wikimedia.org/r/10685 [10:10:38] New patchset: John Erling Blad; "Tests and changes for the API." [mediawiki/extensions/WikidataRepo] (master) - https://gerrit.wikimedia.org/r/10689 [10:10:38] New patchset: John Erling Blad; "Only a single file for tests" [mediawiki/extensions/WikidataRepo] (master) - https://gerrit.wikimedia.org/r/10550 [10:16:38] https://gerrit.wikimedia.org/r/#/c/10689 [10:17:06] https://gerrit.wikimedia.org/r/10689 [10:18:08] Change abandoned: John Erling Blad; "This is replaced by https://gerrit.wikimedia.org/r/10689" [mediawiki/extensions/WikidataRepo] (master) - https://gerrit.wikimedia.org/r/9364 [10:18:37] Change abandoned: John Erling Blad; "This is replaced by https://gerrit.wikimedia.org/r/10689" [mediawiki/extensions/WikidataRepo] (master) - https://gerrit.wikimedia.org/r/10550 [11:43:13] Change restored: John Erling Blad; "Getting it back, the new version (https://gerrit.wikimedia.org/r/#/c/10689/) is depending on this one." [mediawiki/extensions/WikidataRepo] (master) - https://gerrit.wikimedia.org/r/10550 [11:43:41] Change restored: John Erling Blad; "Getting it back, the new version (https://gerrit.wikimedia.org/r/#/c/10689/) is depending on this one." [mediawiki/extensions/WikidataRepo] (master) - https://gerrit.wikimedia.org/r/9364 [11:56:56] New review: Jeroen De Dauw; "(no comment)" [mediawiki/extensions/WikidataRepo] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/10685 [14:23:50] New patchset: Jeroen De Dauw; "Added some docs to changenotifier class" [mediawiki/extensions/WikidataRepo] (master) - https://gerrit.wikimedia.org/r/10699 [14:38:21] http://kunsthistorie.com/w/images/3/30/Gaia.i.Bergen.jpg [14:38:38] And the golden duck with an evil mark.. [14:43:32] New patchset: Jeroen De Dauw; "Added changeHandler interface to have some extra layer between change propagation code and handlers" [mediawiki/extensions/WikibaseLib] (master) - https://gerrit.wikimedia.org/r/10701 [14:43:33] New patchset: Jeroen De Dauw; "Make the poll script not die on exceptions comming from handling code" [mediawiki/extensions/WikibaseLib] (master) - https://gerrit.wikimedia.org/r/10702 [14:48:26] New review: Daniel Kinzler; "just docs" [mediawiki/extensions/WikidataRepo] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/10699 [14:48:28] Change merged: Daniel Kinzler; [mediawiki/extensions/WikidataRepo] (master) - https://gerrit.wikimedia.org/r/10699 [14:52:19] Jens_WMDE, Abraham_WMDE2, everyone: sumana asked me to discuss code review bootstrapping with her in #mediawiki [14:52:29] drop in if you like [14:56:43] Daniel_WMDE: thx [15:17:06] Henning_WMDE: poke :D [15:31:32] New patchset: John Erling Blad; "Updates to the API to get a few additional features, and several changes to the tests to make it test as i should. There is also chnanges to the tests to make them work somewhat better when the API is in a test mode and to not expect cleanup from previous" [mediawiki/extensions/WikidataRepo] (master) - https://gerrit.wikimedia.org/r/10704 [15:32:43] I will download and check this patchset, don't use time on review yet. [15:33:50] yay [15:48:15] New review: Jens Ohlig; "See comment in includes/ChangeHandler.php" [mediawiki/extensions/WikibaseLib] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/10701 [15:48:43] New review: Jens Ohlig; "(no comment)" [mediawiki/extensions/WikibaseLib] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/10701 [16:04:42] New patchset: John Erling Blad; "Updates to the API to get a few additional features, and several changes to the tests to make it test as i should. There is also chnanges to the tests to make them work somewhat better when the API is in a test mode and to not expect cleanup from previous" [mediawiki/extensions/WikidataRepo] (master) - https://gerrit.wikimedia.org/r/10704 [16:14:43] Change abandoned: John Erling Blad; "Replaced by https://gerrit.wikimedia.org/r/#/c/10704/ (hopefully)" [mediawiki/extensions/WikidataRepo] (master) - https://gerrit.wikimedia.org/r/10689 [16:16:43] Change abandoned: John Erling Blad; "Replaced by https://gerrit.wikimedia.org/r/#/c/10704/ (hopefully)" [mediawiki/extensions/WikidataRepo] (master) - https://gerrit.wikimedia.org/r/10550 [16:17:05] Change abandoned: John Erling Blad; "Replaced by https://gerrit.wikimedia.org/r/#/c/10704/ (hopefully)" [mediawiki/extensions/WikidataRepo] (master) - https://gerrit.wikimedia.org/r/9364 [16:32:58] New review: Daniel Kinzler; "seems fine to mee except for minor issues." [mediawiki/extensions/WikidataRepo] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/10704 [16:48:39] New review: Daniel Kinzler; "this depends on I3efdbc89 actually" [mediawiki/extensions/WikidataRepo] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/10704 [16:49:36] New review: Daniel Kinzler; "currently fails with a fatal error due to an unmet dependency in WikibaseLib, see I3efdbc89" [mediawiki/extensions/WikidataRepo] (master); V: -1 C: 1; - https://gerrit.wikimedia.org/r/10704 [17:50:21] New review: Jeroen De Dauw; "(no comment)" [mediawiki/extensions/WikibaseLib] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/10701 [18:26:57] New patchset: Daniel Kinzler; "Updates to the API to get a few additional features, and several changes to the tests to make it test as i should. There is also chnanges to the tests to make them work somewhat better when the API is in a test mode and to not expect cleanup from previous" [mediawiki/extensions/WikidataRepo] (master) - https://gerrit.wikimedia.org/r/10704 [18:28:54] New review: Daniel Kinzler; "Amended: removed all functionality related to aliasses for now. Relevant parts of the code are marke..." [mediawiki/extensions/WikidataRepo] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/10704 [18:49:11] New review: Jeroen De Dauw; "(no comment)" [mediawiki/extensions/WikidataRepo] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/10704 [18:49:13] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikidataRepo] (master) - https://gerrit.wikimedia.org/r/10704 [19:40:51] JeroenDeDauw: https://gerrit.wikimedia.org/r/#/c/10725/ [20:48:45] New patchset: Jeroen De Dauw; "Simplified internal structure and get rid of methods that expose internal structure and modified api and tests to match" [mediawiki/extensions/WikidataRepo] (master) - https://gerrit.wikimedia.org/r/10727 [20:48:46] New patchset: Jeroen De Dauw; "Simplified internal structure and get rid of methods that expose internal structure and modified tests to match" [mediawiki/extensions/WikibaseLib] (master) - https://gerrit.wikimedia.org/r/10728 [20:49:20] New review: Jeroen De Dauw; "Depends on https://gerrit.wikimedia.org/r/#/c/10728/" [mediawiki/extensions/WikidataRepo] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/10727 [20:52:14] New review: Jeroen De Dauw; "The dependency here is wrong btw. This change does not depend on the one gerrit is listing." [mediawiki/extensions/WikibaseLib] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/10728 [20:56:26] New patchset: Reedy; "Fix .gitreview" [mediawiki/extensions/WikibaseClient] (master) - https://gerrit.wikimedia.org/r/10730 [20:56:42] New review: Reedy; "(no comment)" [mediawiki/extensions/WikibaseClient] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/10730 [20:56:44] Change merged: Reedy; [mediawiki/extensions/WikibaseClient] (master) - https://gerrit.wikimedia.org/r/10730 [20:56:59] New patchset: Reedy; "Add .gitignore" [mediawiki/extensions/WikibaseClient] (master) - https://gerrit.wikimedia.org/r/10731 [20:57:28] New review: Reedy; "(no comment)" [mediawiki/extensions/WikibaseClient] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/10731 [20:57:30] Change merged: Reedy; [mediawiki/extensions/WikibaseClient] (master) - https://gerrit.wikimedia.org/r/10731 [21:29:55] Gotisch: yeah did you try adding a new entry to the france entry on the repository? [21:30:11] * Lydia_WMDE looks at page [21:32:36] Gotisch: hmmm this should work.... [21:32:47] i am not sure why it doesn't [21:33:15] might be a caching thing [21:34:17] Gotisch: i am super tired and need to get some sleep - can you poke me tomorrow if it still doesn't work? then i will have a closer look [21:34:35] also maybe Danwe_WMDE or JeroenDeDauw know what the problem is [21:34:51] :) [21:34:56] good idea :D [21:34:59] good night [22:57:38] Gotisch: Lydia_WMDE: the client functionality to actually show the links from the repo has not been implemented yet