[00:13:10] New patchset: John Erling Blad; "Simplified internal structure and get rid of methods that expose internal structure and modified api and tests to match" [mediawiki/extensions/WikidataRepo] (master) - https://gerrit.wikimedia.org/r/10727 [00:42:40] New review: John Erling Blad; "Patchset 6 looks good to me, in that set every issue is solved (and some additional issues) and brok..." [mediawiki/extensions/WikidataRepo] (master); V: 1 C: 1; - https://gerrit.wikimedia.org/r/10727 [01:24:01] "new review: John Erling Blad"... for a second, I wondered what a book review feed was doing here :D [09:45:36] New review: Jeroen De Dauw; "(no comment)" [mediawiki/extensions/WikidataRepo] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/10727 [09:49:18] New review: Jeroen De Dauw; "FUUUUU gerrit, why u no decent patchset diff facilities and place my comments at the wrong patchset?" [mediawiki/extensions/WikidataRepo] (master) - https://gerrit.wikimedia.org/r/10727 [09:57:50] New review: Tobias Gritschacher; "(no comment)" [mediawiki/extensions/WikibaseLib] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/10701 [10:07:23] New review: Daniel Kinzler; "I'm rather unhappy with the whole stripKeys() stuff. Besides all the conceptual issues (see comments..." [mediawiki/extensions/WikidataRepo] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/10727 [10:11:06] New review: Jeroen De Dauw; "(no comment)" [mediawiki/extensions/WikidataRepo] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/10727 [10:11:28] New review: Jeroen De Dauw; "I am currently amending the latest patchset" [mediawiki/extensions/WikidataRepo] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/10727 [10:15:11] New review: Jeroen De Dauw; "Daniel: I agree, but this is not a problem with this change, and is not something we should try fixi..." [mediawiki/extensions/WikidataRepo] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/10727 [10:18:01] New review: Daniel Kinzler; "looks ok, but validation pending" [mediawiki/extensions/WikibaseLib] (master); V: 0 C: 2; - https://gerrit.wikimedia.org/r/10745 [10:23:49] New patchset: Jeroen De Dauw; "Simplified internal structure and get rid of methods that expose internal structure and modified api and tests to match" [mediawiki/extensions/WikidataRepo] (master) - https://gerrit.wikimedia.org/r/10727 [10:25:23] New review: Jeroen De Dauw; "I'm done touching this now." [mediawiki/extensions/WikidataRepo] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/10727 [10:34:40] New review: Daniel Kinzler; "still broken logic and possible php warning in stripKeys(), introduced by this change." [mediawiki/extensions/WikidataRepo] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/10727 [10:38:48] New patchset: Daniel Kinzler; "Content is now an interface, use AbstractContent as base class" [mediawiki/extensions/WikibaseLib] (master) - https://gerrit.wikimedia.org/r/10858 [10:41:21] New review: Jeroen De Dauw; "Someone approve and merge already :p" [mediawiki/extensions/WikibaseLib] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/10701 [10:42:57] New review: Jens Ohlig; "(no comment)" [mediawiki/extensions/WikibaseLib] (master); V: 0 C: 2; - https://gerrit.wikimedia.org/r/10701 [10:43:54] New review: Jeroen De Dauw; "Weeee!" [mediawiki/extensions/WikibaseLib] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/10858 [10:43:56] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseLib] (master) - https://gerrit.wikimedia.org/r/10858 [10:57:41] New review: Tobias Gritschacher; "(no comment)" [mediawiki/extensions/WikibaseLib] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/10701 [10:57:44] Change merged: Tobias Gritschacher; [mediawiki/extensions/WikibaseLib] (master) - https://gerrit.wikimedia.org/r/10701 [11:49:44] New review: John Erling Blad; "(no comment)" [mediawiki/extensions/WikidataRepo] (master) - https://gerrit.wikimedia.org/r/10727 [12:26:38] Joined via online freenode client :) [12:26:57] if anyone would like to ask about new bugs or anything... [12:30:22] Gotisch: Jens_WMDE is the guy to ask [12:35:48] New review: Tobias Gritschacher; "(no comment)" [mediawiki/extensions/WikibaseLib] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/10702 [12:35:50] Change merged: Tobias Gritschacher; [mediawiki/extensions/WikibaseLib] (master) - https://gerrit.wikimedia.org/r/10702 [13:17:42] Gotisch: the demos are fixed [13:31:50] New patchset: John Erling Blad; "Simplified internal structure and get rid of methods that expose internal structure and modified api and tests to match" [mediawiki/extensions/WikidataRepo] (master) - https://gerrit.wikimedia.org/r/10727 [13:39:07] Gotisch: it's not enough [13:39:24] we're changing how the back end works [13:39:55] polling for changes on the repo at specified interval (and on page edit) [13:42:53] i think we'll do that also [13:43:34] there will be a shared table between the client and repo [13:43:46] and a feed for external clients (e.g. outside wikimedia) [13:45:00] here are some notes: http://meta.wikimedia.org/wiki/Wikidata/Notes/Caching_investigation [13:45:44] Gotisch: we're focusing on wikipedia now but external feed could be pubsubhubbub or such [13:49:40] right now we're just calling the repo api and [13:49:54] purging or saving the page on the client refreshes the links [13:50:11] it's not what we want, of course [13:51:55] not totally implemented yet [13:54:52] the rebuild links only is not implemented yet [14:32:17] New patchset: L10n-bot; "Localisation updates from http://translatewiki.net." [mediawiki/extensions/WikidataRepo] (master) - https://gerrit.wikimedia.org/r/10938 [14:33:06] New review: L10n-bot; "(no comment)" [mediawiki/extensions/WikidataRepo] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/10938 [14:33:07] Change merged: L10n-bot; [mediawiki/extensions/WikidataRepo] (master) - https://gerrit.wikimedia.org/r/10938 [14:34:30] ok. whoever answersw this one gets a cookie. [14:34:35] what's wrong with this line? [14:34:50] $usekeys = \WBSettings::get( 'apiUseKeys' ) || ( isset( $params['usekeys'] ) ? $params['usekeys'] : false ); [14:34:56] damn you... now i want a cookie [14:34:59] -.- [14:35:05] :P [14:35:13] ask JeroenDeDauw, he probably has a stash :) [14:35:19] is john not here? [14:35:19] :D [14:35:25] he is in the office [14:36:23] ok. hm. i want to yell at him and jeroen about that line :) can you get their attention? [14:37:42] [14:37:45] Daniel_WMDE: the line is confusing, but not wrong per se... [14:38:39] Jens_WMDE: ok, then entlighten me. what happens if \WBSettings::get( 'apiUseKeys' ) returns true but $params['usekeys'] is not defined? [14:38:49] Mmm, it will have the results of the OR, if anything. [14:38:51] $usekeys is set to \WBSettings::get( 'apiUseKeys' ) unless \WBSettings::get( 'apiUseKeys' ) doesn't exist, in which case it is .- [14:39:19] set to $params['usekeys'] if $params['usekeys'] is set or to false otherwise [14:39:29] Daniel_WMDE: poked [14:39:54] wait, am i reading the paranteces wrong? [14:39:59] * Daniel_WMDE does a duble take [14:40:53] huh? [14:40:56] Jens_WMDE: ha, you are right! I did read this wrong. [14:41:03] The later ternary should, for clarity, be inside parentheses. [14:41:13] ok, so it isn't broken per se, but did manage to confuse me [14:41:15] *blush* [14:41:32] it's... the other kind of intuitive. [14:41:46] Amgine: yes. i read the OR as part of the ternaries condition. which *would* be wrong. [14:41:53] [14:42:00] * Daniel_WMDE would not make a good lisp programmer [14:42:29] The ternary part in Api.php? [14:42:34] yes [14:42:40] https://gerrit.wikimedia.org/r/#/c/10727/8/includes/api/Api.php [14:42:44] Ternary operators and precedence is a bitch [14:42:49] it's deliberately obfuscated. [14:42:54] :P [14:43:04] "it's a feature!" [14:43:09] ternary operators pkus || [14:43:36] well, the ternary is in paranteces, so it should be clear. still confused me. [14:43:40] anyway [14:43:52] untangle it, guys. [14:43:54] thanks for unconfusing me :) [14:44:40] I moved the parenthesis to make it clearer.. Or little less confusing.. [14:45:30] New review: Daniel Kinzler; "after uncrossing my eyes with Jen's help, I retract my comment about the logic error. The logic for ..." [mediawiki/extensions/WikidataRepo] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/10727 [14:46:30] Jen :) [14:47:29] my magic superpower lies in my name. Jens sounds similar enought to Jen for Americans who start flirting with me on IRC and give me presents :) [14:47:56] ..but he is kind of cute.. ;) [14:48:09] Jensifer. [14:48:44] Jenseblümchen [15:28:05] Lydia_WMDE: i put your logo contest in the signpost. however, given that springer science media won't deliver its answers within hours, we are unikely to publish today [15:28:54] Jan_eissfeldt: ohhh cool [15:28:55] thx [15:29:03] a day or two in addition is ok i think :) [15:38:44] My kittenlogo shall win!! [16:13:50] New review: Daniel Kinzler; "seems fine, but didn't yet validate." [mediawiki/extensions/WikibaseLib] (master); V: 0 C: 2; - https://gerrit.wikimedia.org/r/10728 [16:16:49] New review: Daniel Kinzler; "tests pass" [mediawiki/extensions/WikibaseLib] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/10745 [16:16:51] Change merged: Daniel Kinzler; [mediawiki/extensions/WikibaseLib] (master) - https://gerrit.wikimedia.org/r/10745 [16:40:49] New review: Daniel Kinzler; "This needs updating." [mediawiki/extensions/WikibaseLib] (master); V: -1 C: 2; - https://gerrit.wikimedia.org/r/10728 [16:59:35] New review: Jeroen De Dauw; "All tests ran fine for me when I created this patchset." [mediawiki/extensions/WikibaseLib] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/10728 [20:22:21] New patchset: L10n-bot; "Localisation updates from http://translatewiki.net." [mediawiki/extensions/WikidataRepo] (master) - https://gerrit.wikimedia.org/r/10994 [20:22:56] New review: L10n-bot; "(no comment)" [mediawiki/extensions/WikidataRepo] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/10994 [20:22:57] Change merged: L10n-bot; [mediawiki/extensions/WikidataRepo] (master) - https://gerrit.wikimedia.org/r/10994 [21:00:34] New patchset: Daniel Kinzler; "Removing cross-dependency between lib and repo extensions." [mediawiki/extensions/WikibaseLib] (master) - https://gerrit.wikimedia.org/r/10997 [21:02:15] New patchset: Daniel Kinzler; "Removing cross-dependency between lib and repo extensions." [mediawiki/extensions/WikidataRepo] (master) - https://gerrit.wikimedia.org/r/10998 [21:03:29] New patchset: Daniel Kinzler; "Removing cross-dependency between lib and repo extensions." [mediawiki/extensions/WikibaseLib] (master) - https://gerrit.wikimedia.org/r/10997