[09:03:04] Jens_WMDE: we have a spam problem [09:03:05] http://wikidata-test-client.wikimedia.de/wiki/Special:Contributions/94.181.160.109 [09:42:10] to prepare for the code review session, please have a look at the current review queue https://gerrit.wikimedia.org/r/#/q/status:open,n,z (note the little "next" button, too) [09:42:17] i suggest to look at some older patches and read through the comments to get a feel for what review means [11:24:07] f00d? [13:22:51] New patchset: Tobias Gritschacher; "added aliases functionality;" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/11611 [15:26:18] New patchset: Jens Ohlig; "Fix relative path in populateInterwiki.php" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/11618 [15:39:35] New review: Aude; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/11618 [15:39:37] Change merged: Aude; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/11618 [16:10:18] Daniel_WMDE_: "Fixed internal structure simplification patch" <- can you expand on this? [16:12:33] Lydia_WMDE: jeroen changed how we represent tdata internally on friday. after he submitted the two patches, there was some discussion with john, and some changes made. [16:12:53] ok [16:12:55] thx [16:13:02] then i found i wasn't able to properly test the changes to WikibaseLib, because there was a cross dependency on the Repo. So I fixed that [16:13:23] in the end, the patches didn't apply any more, and after fixing that, i found that they failed a bunch of tests [16:13:24] k [16:13:36] took me about a day to clean up the cross dependency and fix the patches [16:27:36] So who's going to have fun reviewing the +2283, -1352 line UI commit? :D