[07:38:23] <gerrit-wm>	 New review: Tobias Gritschacher; "Selenium tests are failing because of a JS error occurring when doing the following:" [mediawiki/extensions/Wikibase] (master); V: 0 C: -1;  - https://gerrit.wikimedia.org/r/11955
[08:08:59] <gerrit-wm>	 New review: Daniel Kinzler; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/11865
[08:18:11] <gerrit-wm>	 New patchset: Daniel Kinzler; "(bug 37496) diff display for items, using the ItemDiff class" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/11865
[08:37:07] <gerrit-wm>	 New patchset: Tobias Gritschacher; "bugfix: always making add button invisible when triggering toolbar's hide function" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/11980
[08:37:27] <TobiasG_WMDE>	 Henning_WMDE: https://gerrit.wikimedia.org/r/11980
[09:35:53] <gerrit-wm>	 New patchset: Tobias Gritschacher; "bugfix: always making add button invisible when triggering toolbar's hide function" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/11980
[09:48:01] <gerrit-wm>	 New patchset: Daniel Werner; "Did some cleanup on Aliases + implemented that the enter button will trigger save/cancel patch set 2: used reference to object correctly on _trigger() which failed" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/11955
[10:09:08] <gerrit-wm>	 New patchset: Tobias Gritschacher; "Did some cleanup on Aliases + implemented that the enter button will trigger save/cancel patch set 2: used reference to object correctly on _trigger() which failed patch set 3: added a selenium test to test functionality of saving on pressing return" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/11955
[10:12:11] <gerrit-wm>	 New review: Jens Ohlig; "Nice." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/11842
[10:12:14] <gerrit-wm>	 Change merged: Jens Ohlig; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/11842
[10:20:39] <gerrit-wm>	 New review: Tobias Gritschacher; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/11955
[10:22:05] <gerrit-wm>	 New review: Daniel Werner; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/11980
[10:22:33] <gerrit-wm>	 New review: Daniel Werner; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/11980
[10:22:36] <gerrit-wm>	 Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/11980
[10:36:28] <gerrit-wm>	 New patchset: Daniel Werner; "Did some cleanup on Aliases + implemented that the enter button will trigger save/cancel patch set 2: used reference to object correctly on _trigger() which failed patch set 3: added a selenium test to test functionality of saving on pressing return patch" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/11955
[10:42:30] <gerrit-wm>	 New review: Tobias Gritschacher; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/11955
[10:42:32] <gerrit-wm>	 Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/11955
[12:52:06] <JeroenDeDauw>	 Denny_WMDE: Y U NO JOIN #semantic-mediawiki? :p
[12:54:32] <Denny_WMDE>	 joined
[13:05:43] * aude  waves

[13:24:19] <gerrit-wm>	 New patchset: John Erling Blad; "Agent to access external client sites for information about pages." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/11994
[13:34:50] <gerrit-wm>	 New review: Jeroen De Dauw; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/11865
[13:34:52] <gerrit-wm>	 Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/11865
[13:34:57] <gerrit-wm>	 New review: Jens Ohlig; "I find the checking for the OK status in repo/includes/ClientPage.php way too vague and see potenial..." [mediawiki/extensions/Wikibase] (master); V: 0 C: -1;  - https://gerrit.wikimedia.org/r/11994
[13:41:30] <gerrit-wm>	 New review: Jens Ohlig; "I find the checking for the OK status in repo/includes/ClientPage.php way too vague and see potenial..." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/11994
[13:41:33] <gerrit-wm>	 Change merged: Jens Ohlig; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/11994
[13:43:38] <gerrit-wm>	 New patchset: Henning Snater; "removed cancel event for AliasEditTool attaching its function directly to the cancel button action" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/11996
[13:46:34] <Daniel_WMDE>	 Jens_WMDE: uh, why did you merge 11994 if you noticed that it's broken? isOk() really *is* broken.
[13:46:59] <Daniel_WMDE>	 for one thing, anything >= 200 and < 300 is "ok". 
[13:49:35] <Jens_WMDE>	 Daniel_WMDE: hm.
[13:49:48] <Jens_WMDE>	 you're correct.
[13:50:15] <Jens_WMDE>	 i think i was far too forgiving with that merge :(
[13:50:47] <gerrit-wm>	 New patchset: Jens Ohlig; "Revert "Agent to access external client sites for information about pages."" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/11997
[13:51:10] <gerrit-wm>	 New review: Jens Ohlig; "Reverted." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/11997
[13:51:12] <gerrit-wm>	 Change merged: Jens Ohlig; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/11997
[13:52:31] <Jens_WMDE>	 reverted
[13:52:47] <gerrit-wm>	 New review: Daniel Kinzler; "please improve the isOk() method." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/11994
[13:53:52] <jejebinks>	 hm?
[13:54:16] <Daniel_WMDE>	 Jens_WMDE: but we can't really tell gerrit that it was reverted, right? bah... "un-merging" would be nice to have. and not hard.
[13:54:46] <Daniel_WMDE>	 Jens_WMDE: anyway, in such a case i would probably just a filed a bug report. 
[13:54:46] <Jens_WMDE>	 it was unmerged...
[13:55:15] <Jens_WMDE>	 https://gerrit.wikimedia.org/r/#/c/11997/
[13:55:23] <Daniel_WMDE>	 Jens_WMDE: yes, but does gerrit still has it as "merged". 
[13:55:29] <Daniel_WMDE>	 we can't track it in gerrit any longer
[13:56:12] <Jens_WMDE>	 yeah
[13:57:49] <Daniel_WMDE>	 Jens_WMDE: just make John fix it :) what do you think of my regex suggestion?
[13:58:00] <Jens_WMDE>	 () really *is* broken.
[13:58:00] <Jens_WMDE>	 15:46 < Daniel_WMDE> for one thing, anything >= 200 and < 300 is "ok". 
[13:58:03] <Jens_WMDE>	 15:49 < Jens_WMDE> Daniel_WMDE: hm.
[13:58:05] <Jens_WMDE>	 15:49 < Jens_WMDE> you're correct.
[13:58:06] <Jens_WMDE>	 oops
[13:58:15] <Jens_WMDE>	 yeah, regex.
[13:58:24] <Jens_WMDE>	 the obvious solution.
[13:58:41] <Daniel_WMDE>	 i hope i didn't botch it though, didn't test it :)
[13:58:55] <jejebinks>	 nope, it should be 200
[13:59:06] <Daniel_WMDE>	 !^HTTP/[^ ]+ (2\d\d) !
[13:59:24] <Daniel_WMDE>	 jejebinks: but having a 200 *anywhere* in the status header is not sufficient.
[13:59:35] <jejebinks>	 But tested against a set pattern in the config, testing on the status string is a mess
[13:59:40] <Daniel_WMDE>	 at the *very* least test for " 200 ", but that's still not safe
[14:00:06] <Daniel_WMDE>	 but i still think you can't rely on it being 200
[14:00:11] <Daniel_WMDE>	 i have had problems with this in the past
[14:01:16] <Jens_WMDE>	 any chances that we'll encounter a localized Latin webserver that returns "CC"?
[14:01:24] <Daniel_WMDE>	 :P
[14:01:34] <jejebinks>	 If its not 200, then we're in for something *really* much more complex than this
[14:02:16] <Daniel_WMDE>	 jejebinks: ok, require a 200, but make sure it's the first thing after HTTP/x.x 
[14:02:17] <gerrit-wm>	 New patchset: Daniel Werner; "Moved 'wbSiteDetails' js variable creation from ItemView to be registered in ResourceLoaderGetConfigVars hook" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/11999
[14:02:41] <Daniel_WMDE>	 jejebinks: a simple substring match is a good way to generate random hard to track failures
[14:03:29] <jejebinks>	 Quite frankly I don't think so in this case. I think its a constructed problem.
[14:03:57] <jejebinks>	 But I can see if it can be done in some other way.
[14:04:18] <TobiasG_WMDE>	 Denny_WMDE: wohin ins wiki würdest du sagen, soll ichs geben?
[14:05:41] <Daniel_WMDE>	 jejebinks: it is true that it's unlikely that this will go wrong. but i think it's always a good thing to program to spec, no?
[14:05:59] <Daniel_WMDE>	 jejebinks: HTTP does *not* sepcify the phrase after the code. the server is free to send *anything* there.
[14:06:18] <Daniel_WMDE>	 rfc2612 section 6.1.1
[14:06:19] <Daniel_WMDE>	 The individual values of the numeric status codes defined for HTTP/1.1, and an example set of corresponding Reason-Phrase's, are presented below. The reason phrases listed here are only recommendations -- they MAY be replaced by local equivalents without affecting the protocol. 
[14:07:46] * jejebinks  mumbles about servers putting the code after the string

[14:08:01] <Daniel_WMDE>	 jejebinks: ooohhh, wait. 
[14:08:11] <jejebinks>	 right.. ;p
[14:08:12] <Daniel_WMDE>	 jejebinks: please don't use file_get_contents to access a url
[14:08:19] <Daniel_WMDE>	 use mediawiki's HTTP class
[14:08:38] <Daniel_WMDE>	 it's much more versatile, and has good handling for all sorts of crap, including response codes
[14:08:45] <Daniel_WMDE>	 solves your problem and makes your code much nicer
[14:09:46] <Daniel_WMDE>	 jejebinks: just do Http::get( $url ). 
[14:09:52] <Daniel_WMDE>	 if you need the status, use this:
[14:09:59] <Daniel_WMDE>	 		$req = MWHttpRequest::factory( $url, $options );
[14:10:01] <Daniel_WMDE>	 		$status = $req->execute();
[14:10:25] <Daniel_WMDE>	 Jens_WMDE: fyi --^
[14:11:30] <Jens_WMDE>	 oho!
[14:11:38] <Jens_WMDE>	 this changes EVERYTHING!
[14:13:40] <Denny_WMDE>	 yes, just reuse the Http class
[14:13:45] <Denny_WMDE>	 https://svn.wikimedia.org/doc/
[14:19:11] <Denny_WMDE>	 Daniel_WMDE: whenever you have time: http://meta.wikimedia.org/wiki/Wikidata/Notes/URI_scheme#Proposal_for_Wikidata and http://meta.wikimedia.org/wiki/Wikidata/Notes/Wiki_links for review for you
[14:28:20] <Daniel_WMDE>	 Denny_WMDE: will look into it in a bit
[14:31:52] <Denny_WMDE>	 no hurry
[14:31:56] <gerrit-wm>	 New patchset: Daniel Werner; "return jQuery.Promise rather than jQuery.Deferred wherever possible." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12004
[15:00:49] <gerrit-wm>	 New patchset: Daniel Werner; "Moved resourceloader modeules into their own file." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12017
[15:04:31] <gerrit-wm>	 New review: Jeroen De Dauw; "Please revert this, there are two errors in the change. Missing brackets and undefined variable, bot..." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/11842
[15:05:07] <JeroenDeDauw>	 And once more we have broken code on master >_>
[15:06:20] <gerrit-wm>	 New patchset: Jens Ohlig; "Revert "Autocomments for Wikibase items"" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12019
[15:13:17] <Daniel_WMDE>	 any hints as to writing test cases for the api that need sessions and tokens? i'm running into this:
[15:13:26] <Daniel_WMDE>	 1) ApiEditPageTest::testEdit
[15:13:27] <Daniel_WMDE>	 Argument 1 passed to DerivativeContext::setUser() must be an instance of User, instance of ApiTestUser given, called in /DATA/var/www/daniel/wikidata/tests/phpunit/includes/api/ApiTestCase.php on line 166 and defined
[15:14:33] <gerrit-wm>	 New review: Jeroen De Dauw; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/12019
[15:14:35] <gerrit-wm>	 Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12019
[15:14:50] <Daniel_WMDE>	 ah, found it
[15:15:04] <JeroenDeDauw>	 Jens_WMDE: what's the best way to revert anyway? reverse merge?
[15:15:33] <Reedy>	 Press the revert button in gerrit?
[15:15:48] <Jens_WMDE>	 yeah
[15:15:52] <Jens_WMDE>	 that's what i did.
[15:23:42] <JeroenDeDauw>	 huh
[15:24:04] <JeroenDeDauw>	 heh
[15:24:31] <JeroenDeDauw>	 Where is the "insert kittens" button? :<0
[15:28:10] <gerrit-wm>	 New patchset: Daniel Werner; "Moved resourceloader modeules into their own file. Patch Set 1: global scope won't be polluted anymore." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12017
[15:35:22] <Lydia_WMDE>	 JeroenDeDauw: http://make-everything-ok.com/
[15:35:23] <Lydia_WMDE>	 :P
[15:58:05] <JeroenDeDauw>	 Lydia_WMDE: :d
[15:58:19] <JeroenDeDauw>	 Lydia_WMDE: I was so expecting the thing to raise an error at 99% or so :p
[16:07:17] * DarkoNeko  clicks on the button

[16:07:23] <DarkoNeko>	 AAAH IT CRASHED
[16:07:33] <DarkoNeko>	 just kidding
[16:15:18] <gerrit-wm>	 New review: Daniel Werner; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/11996
[16:15:25] <gerrit-wm>	 Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/11996
[16:38:32] <gerrit-wm>	 New patchset: John Erling Blad; "Autocomments for Wikibase items" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12025
[17:27:15] <gerrit-wm>	 New patchset: Daniel Werner; "cleaned up startup, which is using jQuery( document ).ready() now." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12028
[17:38:12] <Lydia_WMDE>	 JeroenDeDauw: ;-)
[18:05:17] <gerrit-wm>	 New review: Jeroen De Dauw; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 0 C: -1;  - https://gerrit.wikimedia.org/r/12028
[20:09:22] <gerrit-wm>	 New review: John Erling Blad; "This does not generate the previous error condition, and it does not give errors on the Wikibase gro..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/12025
[20:21:58] <gerrit-wm>	 New patchset: John Erling Blad; "Updated the agent to use of Http::get, and with additional changes." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12096
[20:50:42] <gerrit-wm>	 New review: John Erling Blad; "This does not generate the previous error condition, and it does not give errors on the Wikibase gro..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/12096