[09:54:38] New review: Jens Ohlig; "Code looks okay, tests run without errors." [mediawiki/extensions/Wikibase] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/12096 [10:17:45] Denny_WMDE: https://meta.wikimedia.org/wiki/Wikidata/Development/Storyboard_for_linking_Wikipedia_articles_v0.2 [10:18:03] i'll let you update the list of items [10:23:34] Denny_WMDE: https://meta.wikimedia.org/w/index.php?title=Wikidata%2FNotes%2FData_model_primer&diff=3845239&oldid=3843839 [10:34:53] Daniel_WMDE: https://meta.wikimedia.org/w/index.php?title=Wikidata/Notes/Data_model_primer&diff=3845285&oldid=3845239 [10:36:26] New patchset: Jeroen De Dauw; "Work on site handling." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12156 [10:43:07] aude: thank you, it looks great! [10:43:10] Denny_WMDE: https://meta.wikimedia.org/w/index.php?title=Wikidata%2FNotes%2FURI_scheme&diff=3845308&oldid=3843454 [10:43:43] there's one actual change to the spec there, let's see if you spot it :) [10:43:47] Denny_WMDE: i'm sure people will have comments [10:44:52] aude: that's why we make it public :) [10:44:58] Daniel_WMDE: can you has a quick look at https://gerrit.wikimedia.org/r/#/c/12156/ ? [10:45:23] JeroenDeDauw: gah! lots of files! [10:45:40] Denny_WMDE: yep [10:47:30] Daniel_WMDE: half of them being tests that broke :p [10:52:08] Daniel_WMDE: https://meta.wikimedia.org/w/index.php?title=Wikidata/Notes/URI_scheme&diff=next&oldid=3845308 [10:52:34] Daniel_WMDE: did you mean the clarification that the configuration for formats and languages are done via URL parameters? [10:53:44] no. i changed the form of the "official" title based url from en.wikidata.org/title/Foo to wikidata.org/title/en:Foo, because that's the form that is usable for interwiki linking. [10:53:54] both forms are still valid, anyway [10:54:18] Denny_WMDE: anyway, looking good now. [10:54:35] Denny_WMDE: can you fix the data model spec wrt the rank names? [10:54:53] also, the data model spec currently says that aliasses are defined by properties only. [10:55:20] which i would actually find nicht (i think i suggested it), but is currently not true [10:55:32] s/nicht/nice/ [10:59:56] the data model spec is being reworked my markus currently [11:00:04] will wait until this is done for further changes [12:49:59] *by markus [12:51:32] New patchset: John Erling Blad; "Updated the agent to use of Http::get, and with additional changes." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12096 [12:59:48] New review: Daniel Kinzler; "only looked at it superficially, but already got a bunch of questions... " [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/12156 [13:02:16] New review: Jens Ohlig; "I would like to see "\Wikibase\Utils::insetTemporarySites()" get typo-corrected to "\Wikibase\Utils:..." [mediawiki/extensions/Wikibase] (master); V: 1 C: 1; - https://gerrit.wikimedia.org/r/12156 [13:27:19] New patchset: Jeroen De Dauw; "Work on site handling." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12156 [13:28:02] New review: Jeroen De Dauw; "(no comment)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12156 [13:32:47] New review: John Erling Blad; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/12156 [13:53:29] hi [14:04:02] hey Katie_WMDE :) [14:04:16] Katie_WMDE: you got comments on your storyboard talk page from Gregor [14:10:22] Lydia_WMDE: good [14:10:49] * Katie_WMDE trying to have two nicks... confusing [14:18:15] New patchset: Jeroen De Dauw; "Work on site handling." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12156 [14:19:04] New review: Jeroen De Dauw; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/12156 [14:19:06] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12156 [15:00:48] New patchset: Jeroen De Dauw; "Added label and description to item diff" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12184 [15:40:10] New patchset: Daniel Werner; "return jQuery.Promise rather than jQuery.Deferred wherever possible. patch-set 1: promise was not yet returned everywhere and also now attaching the isOngoing... property to the promise." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12004 [15:51:06] New patchset: Henning Snater; "return jQuery.Promise rather than jQuery.Deferred wherever possible. patch-set 1: promise was not yet returned everywhere and also now attaching the isOngoing... property to the promise. patch-set 2: removed unused variable" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12004 [15:52:13] Katie_WMDE: are you going to address the feedback on the talk page of the story board? [15:52:50] New patchset: Henning Snater; "return jQuery.Promise rather than jQuery.Deferred wherever possible. patch-set 1: promise was not yet returned everywhere and also now attaching the isOngoing... property to the promise. patch-set 2: (got lost) patch-set 3: removed unused variable" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12004 [15:58:26] New review: John Erling Blad; "Put this on hold, there could be a problem with this." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/12096 [15:59:05] New review: John Erling Blad; "Put this on hold, there could be a problem with this." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/12025 [16:19:32] New review: Henning Snater; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/12004 [16:19:34] Change merged: Henning Snater; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12004 [16:23:06] Danwe_WMDE: do you want to close #36416 in bugzilla? [16:23:49] Jens_WMDE: do you want to close https://bugzilla.wikimedia.org/show_bug.cgi?id=37495 ? [16:27:27] Denny_WMDE: done, Jens_WMDE who? [16:27:48] Jens_WMDE: forget that [16:29:09] New patchset: Jeroen De Dauw; "Added missing Sites::getGroup method" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12190 [16:36:35] New patchset: Jeroen De Dauw; "Fix path" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12192 [16:36:47] New review: Jeroen De Dauw; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/12192 [16:36:50] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12192 [16:37:24] New patchset: Jeroen De Dauw; "Fix another path" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12194 [16:37:41] New review: Jeroen De Dauw; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/12194 [16:37:43] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12194 [16:39:55] Katie_WMDE: feedback also on the mailing list - would be great if you could reply [16:48:18] New review: Henning Snater; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/12190 [16:48:21] Change merged: Henning Snater; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12190 [16:51:49] New review: Henning Snater; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/12195 [16:51:51] Change merged: Henning Snater; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12195 [16:52:09] New review: Henning Snater; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/12196 [16:52:11] Change merged: Henning Snater; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12196 [17:00:48] Reedy: hello! [17:01:14] Reedy: can you set the correct bugzilla-rights for [17:01:15] jens.ohlig@wikimedia.de [17:01:17] ? [17:01:49] Yup, done [17:02:21] thank you! [17:34:49] New review: Daniel Kinzler; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/12184 [17:34:52] Change merged: Daniel Kinzler; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12184 [17:43:38] New patchset: Daniel Kinzler; "make ItemDiff return atomic diff ops for alias changes" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12201 [17:53:11] New patchset: John Erling Blad; "Updated the agent to use of Http::get, and with additional changes." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12096 [19:53:14] New patchset: Hashar; "Add readme (DO NOT SUBMIT)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12222 [19:54:51] New review: Jeroen De Dauw; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/12201 [19:54:53] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12201