[10:05:53] New patchset: John Erling Blad; "Autocomments for Wikibase items" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12025 [10:33:28] New review: Daniel Werner; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/12028 [10:40:31] New review: Daniel Kinzler; "this fixed bug 37680" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12184 [10:44:19] New review: John Erling Blad; "$continuationMarker is undefined, should be replaced by SUMMARY_CONTINUATION. Also lacks escaping." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/12025 [10:54:13] New patchset: Daniel Werner; "cleaned up startup, which is using jQuery( document ).ready() now. patch-set 1: changed jQuery usage in outer closure into $" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12028 [11:19:06] hi. I think it would be a good idea to give User:MerlIwBot the bot flag. This way http://wikidata-test-repo.wikimedia.de/wiki/Special:RecentChanges could be filtered [11:28:38] New review: Daniel Werner; "True, but then again, it is general information related to the extension, its content is not modifie..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/11999 [11:39:43] Raymond_: actually, it has the bot flag [11:59:21] New patchset: Tobias Gritschacher; "selenium: added documentation following RDoc specification" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12359 [12:04:49] New review: Jens Ohlig; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/12359 [12:04:51] Change merged: Jens Ohlig; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12359 [13:49:34] New patchset: Jeroen De Dauw; "Improve tests for Sites class and fixed a bug found by them :)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12367 [14:24:18] New patchset: Jeroen De Dauw; "Fix fatal error on Special:ItemByLabel and wrote a test to find such errors" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12369 [14:24:52] New patchset: Jeroen De Dauw; "Nicified test registration to match whats in the lib" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12370 [14:31:12] New review: Tobias Gritschacher; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/12369 [14:34:12] New patchset: Jeroen De Dauw; "Updated test registration in client to match lib and repo" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12371 [14:36:02] New review: Tobias Gritschacher; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/12367 [14:36:05] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12369 [14:36:06] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12367 [14:38:13] New patchset: Jeroen De Dauw; "Get rid of duplicated maintenance script - this is an old version of deleteAllData.php" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12372 [14:39:13] New patchset: Jeroen De Dauw; "Fix path of maintenance script after merging of extensions into one repo" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12373 [14:42:24] New patchset: Jeroen De Dauw; "Cleanup of PopulateInterwiki maintenance script" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12374 [14:50:28] New review: Aude; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/12374 [14:50:28] Change merged: Aude; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12374 [14:51:06] New review: Aude; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/12373 [14:51:08] Change merged: Aude; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12373 [14:54:18] New review: Aude; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/12371 [14:54:20] Change merged: Aude; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12371 [15:07:57] New patchset: Jeroen De Dauw; "Added missing placeholder in default site info" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12379 [15:34:37] New patchset: Tobias Gritschacher; "quick & dirty fix for broken sitelinks; still needs to be improved;" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12383 [15:59:12] New review: Jeroen De Dauw; "Next time please put in actual todos in the code for the stuff that should still be taken care off :)" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/12383 [15:59:14] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12383 [16:19:04] Jens_WMDE: aaaaahhhhhhhhhhhhh [16:19:41] JeroenDeDauw: ? [16:20:59] Denny_WMDE1: I'm blocked on review of some trivial change [16:22:05] JeroenDeDauw: "If you're adding multiple values to an array in a loop, it's faster to use array_push than repeated [] = statements that I see all the time" http://www.php.net/manual/en/function.array-push.php#84959 [16:22:15] also: tests fail :( [16:25:26] New review: Jens Ohlig; "Unable to run tests, although I cannot see why this patchset would make tests fail. Also: Consider a..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/12370 [16:25:44] Jens_WMDE: performance difference is complete neglectable in this case [16:26:07] Jens_WMDE: also not that we have a map going on [16:26:11] We do not just add stuff [16:26:17] Else I'd have used array_merge [16:27:23] Daniel_WMDE: can you please review this? https://gerrit.wikimedia.org/r/#/c/12370/ [16:27:57] JeroenDeDauw: add me as a reviewer. i need to fix some tests i broke before i can review anything really. [16:28:29] Daniel_WMDE: I'm blocked on this so I would appreciate it if someone merged the extremely simple change [16:29:35] JeroenDeDauw: ok, looking. why did you rename the files? [16:30:02] Daniel_WMDE: to make it consistent with everything else [16:30:05] JeroenDeDauw: also... did you rename the classes, too? [16:31:17] hi [16:31:56] Daniel_WMDE: nope - that's still inconsistent but at least is not visible anywhere outside those files [16:32:10] aude: hi katie [16:32:10] New patchset: Daniel Kinzler; "fix ApiSetItemTests by commenting out some tests that were using a non-existing data provider. needs follow-up" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12393 [16:32:28] JeroenDeDauw: please review the above in return :) [16:32:34] hi aude [16:32:43] does anyone have any generic slide decks for wikidata? [16:32:48] * aude found older ones [16:32:50] aude: check out the current sprint backlog, i think there are a few client thingies in there [16:32:57] Daniel_WMDE: there are [16:33:12] i'm adding the language edit link thingy [16:33:32] ok. coordinate mit jeroen on die use-cached-item-info stuff [16:33:37] New patchset: Jeroen De Dauw; "Add tests for all of the special pages we has" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12394 [16:34:07] ok [16:34:24] JeroenDeDauw: why didn't you just rename them? any reason not to have that in this change too? [16:34:48] Daniel_WMDE: if you want to fix all the mess gerrits creates, then go ahead and amend [16:34:54] I now have a dependent change on it [16:35:03] aude: i am putting your face on the item and moving it to doing :) [16:35:24] JeroenDeDauw: ugh. yea. don't want to amend, then [16:35:35] New review: Jeroen De Dauw; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/12393 [16:35:37] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12393 [16:35:49] this isn't gerrits fault, btw. amending a commit that is in the history of other commits always creates a mess. [16:36:02] Denny_WMDE1: thanks [16:36:28] i have to do our roundtable event thingy tonight and then [16:36:41] will just be around the next days, including some of the weekend [16:36:52] aude: do you need any material? [16:36:55] slides or stuff? [16:37:04] Denny_WMDE1: yes, would be welcome (not to reinvent stuff) [16:37:14] * aude has brochures :) [16:37:15] New review: Daniel Kinzler; "please also rename the test classes accordingly" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/12370 [16:37:24] JeroenDeDauw: merged [16:37:33] i have powerpoints is that ok? [16:37:42] some important people are rsvp'ed [16:37:47] Denny_WMDE1: yes, ok [16:38:12] Daniel_WMDE: apparently [16:38:13] not [16:38:16] * JeroenDeDauw kicks gerrit [16:38:20] the audience is a bit technical or can handle some technical details [16:38:55] spending more time on merging stuff then on writing it like this [16:39:03] change: 5 minutes, review: 1h [16:39:07] productivity-- [16:40:00] aude: maybe this one is helpful http://simia.net/download/semtechsf2012.pptx — big file! [16:40:09] Denny_WMDE1: i have that one and it's good [16:40:15] New patchset: Jeroen De Dauw; "Nicified test registration to match whats in the lib" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12370 [16:40:16] New review: Jeroen De Dauw; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/12370 [16:40:16] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12370 [16:40:20] i can show the demo [16:40:21] i have something more for wikipedian audience too, searching [16:40:24] yes [16:40:39] and basically tell them what we're doing and what not :) [16:41:00] * aude is sure people have grand ideas and suggestions [16:41:16] New patchset: Jeroen De Dauw; "Add tests for all of the special pages we has" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12394 [16:42:58] this is the set from the hackathon : http://simia.net/download/wikidata-hackathon-2012.pptx [16:43:07] in general my slides are usually not too technical [16:43:17] New patchset: Jeroen De Dauw; "Renamed some test classes to match files names" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12398 [16:43:32] (not a huge diff though to the semtech slides) [16:43:46] aude: make sure to ask someone to make notes about their comments [16:43:51] you will be busy answering :) [16:44:16] Denny_WMDE1: thanks [16:44:25] yes, we'll have note takers [16:44:45] cool [16:45:05] ack, it's just me or 2 of the wikibase repo tests fail? [16:47:37] i think it is not just you [16:49:29] Denny_WMDE1: ok [16:49:44] happy to see special page tests being introduced, though [16:52:37] New patchset: Jeroen De Dauw; "Killed unused varibales" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12400 [16:57:41] New review: Jeroen De Dauw; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/12017 [16:57:43] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12017 [16:59:33] New review: Jeroen De Dauw; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/12028 [16:59:35] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12028 [17:02:17] New review: Aude; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/12394 [17:02:19] Change merged: Aude; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12394 [17:02:23] can anyone point me to the local settings that JeroenDeDauw created that make you give all the reports and error messages? [17:02:26] i cannot find the link [17:02:45] Denny_WMDE1: https://www.mediawiki.org/wiki/User:Jeroen_De_Dauw/LocalSettings.php [17:02:59] aude: thx [17:03:19] New patchset: Jeroen De Dauw; "Moved utils test to lib since utirls class was moved there a while back" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12414 [17:10:48] New patchset: Jens Ohlig; "Updated the agent to use of Http::get, and with additional changes." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12096 [17:12:27] New review: Jens Ohlig; "The new version is much better, especially the graphics. We don't need this file." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/12372 [17:12:29] Change merged: Jens Ohlig; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12372 [17:14:36] signing off [17:14:44] aude: all the best with the meeting! [17:14:53] aude: i am sure it will go great :) [17:15:31] New patchset: Jens Ohlig; "Conflicts: repo/Wikibase.hooks.php repo/tests/phpunit/includes/api/ApiSetItemTest.php" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12420 [17:17:14] New patchset: Jens Ohlig; "Fixed the data provider in repo/tests/phpunit/includes/api/ApiSetItemTest.php and made the tests run again." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12420 [17:18:29] JeroenDeDauw: https://gerrit.wikimedia.org/r/#/c/12420/ I can haz review KTHXBAI. [17:21:56] New review: Jeroen De Dauw; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/12420 [17:23:15] New review: Jeroen De Dauw; "The rest of this looks good though, and passed the tests" [mediawiki/extensions/Wikibase] (master); V: 1 C: -1; - https://gerrit.wikimedia.org/r/12420 [17:30:07] New patchset: Jens Ohlig; "Fixed the data provider in repo/tests/phpunit/includes/api/ApiSetItemTest.php and made the tests run again." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12420 [17:30:24] JeroenDeDauw: okay okay okay .... [17:44:25] New review: Jeroen De Dauw; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/12420 [17:48:31] New patchset: Jens Ohlig; "Fixed the data provider in repo/tests/phpunit/includes/api/ApiSetItemTest.php and made the tests run again." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12420 [17:48:42] sigh. [17:52:49] JeroenDeDauw: happy nao? [17:54:06] nao is pronunciation of "nå" in a local dialect in Norway [17:54:58] There are some pretty cute girls there too.. :D [17:55:08] heh [17:55:35] Ah, that was the time... #meltdown [17:55:45] there there [17:55:47] New review: Jeroen De Dauw; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/12420 [17:55:49] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12420 [17:55:58] \o/ [17:56:38] ...and we have a merge! [17:57:00] Huston, the bird have a lift of, we're airborn.. [17:59:22] New review: Jens Ohlig; "Trivial enough. And it didn't break the tests! :)" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/12379 [17:59:24] Change merged: Jens Ohlig; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12379 [17:59:47] the art of passive-aggressive gerrit review. [18:00:34] New review: Daniel Kinzler; "please improve this:" [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/12096 [18:06:19] okay. [18:06:32] heading home- [18:54:00] New review: Jeroen De Dauw; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/12096 [18:54:12] New review: Jeroen De Dauw; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/12096 [18:54:40] Daniel_WMDE_: your comments seem valid to me [19:15:48] Daniel_WMDE_: https://www.mediawiki.org/wiki/User:Jeroen_De_Dauw/LocalSettings.php [19:17:32] Danwe_WMDE: https://de.wikipedia.org/wiki/Spezial:Verwaltung_Benutzerkonten-Zusammenf%C3%BChrung [19:42:18] New review: John Erling Blad; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/12096 [20:20:33] zzz [20:33:18] JeroenDeDauw1: i'm about to head off [21:22:53] New patchset: Jeroen De Dauw; "Added moar tests" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12537