[07:45:30] New review: Tobias Gritschacher; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/12414 [07:45:33] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12414 [08:00:16] New review: Tobias Gritschacher; "Why not also registering the api/ApiJSONPComplete test since it is there and passing (I've tried it ..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/12398 [08:10:00] New review: Tobias Gritschacher; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/12400 [08:10:02] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12400 [08:17:53] New review: Tobias Gritschacher; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/12537 [08:17:56] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12537 [08:32:45] New patchset: Tobias Gritschacher; "registered missing api/ApiJSONPCompleteTest" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12567 [08:34:23] New review: Tobias Gritschacher; "Checked the api/ApiJSONPCompleteTest again and registered it. see https://gerrit.wikimedia.org/r/#/c..." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/12398 [08:34:26] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12398 [10:28:26] * JeroenDeDauw is sadface at http://www.dreamincode.net/forums/topic/283393-generics/ [10:28:31] * JeroenDeDauw throes stuff at PHP [10:28:34] *throws [10:36:23] ....boinkboinkboink.... [10:44:35] New patchset: Daniel Werner; "Corrected localBasePath, CSS loads again even when JavaScript (resource loader) is disabled." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12579 [10:49:16] It's a jejebinks [10:55:36] New review: Jens Ohlig; "Works as expected." [mediawiki/extensions/Wikibase] (master); V: 1 C: 1; - https://gerrit.wikimedia.org/r/12579 [10:59:31] New review: Jens Ohlig; "Works as expected." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/12579 [10:59:33] Change merged: Jens Ohlig; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12579 [11:01:15] New patchset: Jeroen De Dauw; "Added moar tests, now for SiteList" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12580 [12:28:00] New review: Tobias Gritschacher; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/12580 [12:28:03] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12580 [12:30:34] New review: Jeroen De Dauw; "Is this test not duplicating the ApiJOSNPTest?" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/12567 [12:50:45] New review: Jens Ohlig; "I don't see a repetition of another test here. Seems to work." [mediawiki/extensions/Wikibase] (master); V: 1 C: 1; - https://gerrit.wikimedia.org/r/12567 [12:53:33] New review: Tobias Gritschacher; "ApiJSONPCompleteTest does more stuff than ApiJSONPTest but should include all the stuff from ApiJSON..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/12567 [12:57:28] New review: Jeroen De Dauw; "Either way, the code change here is fine - but we do indeed maybe want to kill one of the two if it'..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 2; - https://gerrit.wikimedia.org/r/12567 [12:57:42] New review: Jeroen De Dauw; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 0 C: 2; - https://gerrit.wikimedia.org/r/12567 [12:57:45] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12567 [12:58:18] New patchset: John Erling Blad; "Fix for broken sitelinks structure in result returned to caller" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12586 [12:59:53] New review: John Erling Blad; "Fix for bug https://bugzilla.wikimedia.org/show_bug.cgi?id=37827" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/12586 [13:13:28] New review: Jeroen De Dauw; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/12586 [13:18:50] New patchset: Jeroen De Dauw; "MOAR tests + some fixes to SiteList." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12588 [13:34:16] New patchset: John Erling Blad; "Fix for broken sitelinks structure in result returned to caller" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12586 [13:36:03] New review: John Erling Blad; "Patch set 2 should work also for wbgetitems and wbgetsitelinks, not only wblinksite, and return cons..." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12586 [13:50:07] New review: Jeroen De Dauw; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/12586 [13:52:04] New patchset: Tobias Gritschacher; "when saving sitelinks globalSiteId is sent now instead of siteId" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12589 [13:56:23] New review: John Erling Blad; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/12586 [14:11:46] New review: Jeroen De Dauw; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 0 C: 2; - https://gerrit.wikimedia.org/r/12589 [14:16:01] New review: Jeroen De Dauw; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/12586 [14:41:44] New patchset: Jeroen De Dauw; "Added more SiteList tests" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12594 [15:04:02] New patchset: Tobias Gritschacher; "fix for sitelinks: added method to strip of the wiki-part from global site key" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12595 [15:11:12] New review: Jeroen De Dauw; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/12595 [15:12:31] AAAAAAAAAAAARG [15:12:39] Why do I AGAIN have broken API tests??? [15:12:43] AAAAAAAAAAAAAAAAAAH [15:13:44] pffft [15:13:48] this time I'm not fixing it [15:14:18] :o [15:15:43] JeroenDeDauw: Did you know this phpStorm feature, local history? saved my day :D [15:15:54] Danwe_WMDE: I do know it yes [15:16:17] Danwe_WMDE: so you found your stash? :d [15:16:18] why didn't you tell earlier? I was albe to get back the files I lost because of stupid git stack stuff [15:16:29] JeroenDeDauw: in changeset https://gerrit.wikimedia.org/r/#/c/12588/ there is a broken test, see http://pastebin.com/TiyR48xy [15:16:31] also all the other changes in existing files [15:16:39] Danwe_WMDE: because I was not thinking about how to solve your problem and it did not occur to me just like that? [15:17:13] TobiasG_WMDE: yeah [15:17:20] TobiasG_WMDE: not sure why I did not run into that earlier [15:17:26] TobiasG_WMDE: but I just did a minute ago [15:17:28] TobiasG_WMDE: fixed now [15:17:33] ok [15:17:34] TobiasG_WMDE: but as part of another commit [15:17:52] TobiasG_WMDE: so just wait with merging that one untill my next one has been approved :) [15:18:31] New patchset: Jeroen De Dauw; "Make SiteRowTest derive from ORMRowTest for adittional coverage" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12596 [15:18:55] don't merge the old bug, merge the new one, its much worse! [15:18:57] TobiasG_WMDE: there you go [15:18:57] * jejebinks hides [15:19:13] TobiasG_WMDE: since it has the dependency thing [15:19:23] TobiasG_WMDE: I suggest you just verify the latest commit [15:19:24] but it depends on the broken thing, right? :-) [15:19:32] It will get the other ones as well [15:19:41] And if that works, you can just CR the individual ones [15:19:46] And merge it all together [15:19:50] ok [15:19:52] lets see [15:20:13] I have a bunch of broken API tests tho [15:20:31] Rage to jejebinks for that :p [15:20:58] Hey! I must make the most out of it when you make some bugs! =) [15:21:41] so, who broke it this time? [15:21:56] jejebinks: the current failures are caused by the tests being order dependent and crap like that, not by the functionality being broken [15:22:28] so, you, fix this first. we should not merge it in till thenm [15:22:55] TobiasG_WMDE: my change did not break it [15:22:58] jejebinks: http://pastebin.com/HVPq6UiX [15:23:04] TobiasG_WMDE: it was already broken [15:23:20] no. not for me [15:23:30] TobiasG_WMDE: summary please! (i need it _now_) [15:23:31] thx [15:23:43] also don't have anything from henning [15:23:45] TobiasG_WMDE: it was broken but not failing [15:23:55] Lydia_WMDE: the henning is not at the office today [15:24:01] ah [15:24:01] tests running until i checkout #12596 [15:24:19] Daniel? [15:24:21] so, thats the right moment to fix it, right? [15:24:24] don't have anything from him either [15:24:34] TobiasG_WMDE: sure, fix it then [15:24:58] those are'nt my tests [15:25:08] TobiasG_WMDE: exactelly, they are not mine either [15:25:21] why weren't they failing before? [15:25:41] TobiasG_WMDE: I don't know [15:25:51] TobiasG_WMDE: but we got similar failures before [15:25:51] Lydia_WMDE: Did some work on normalization, and on autocomments for the revision history. Other than that debugging and a little localization. [15:26:02] jejebinks: thx [15:26:16] Lydia_WMDE: hm? [15:26:22] Danwe_WMDE: the other daniel [15:26:29] mh [15:26:58] wonder if I know whats the problem with the tests.. [15:27:15] But I like to blame jeroen.. [15:27:30] Shit, this is difficult.. [15:27:34] o_O [15:27:53] jejebinks: yeah have fun confusing people - you are wasting my time like this though [15:29:56] Nope, seems correct.. [15:34:15] Lydia_WMDE: http://notes.wikimediadc.org/p/wikidataroundtable [15:34:28] a bit messy but some notes [15:34:43] aude: awesome - can you send this to me by email by chance? [15:34:47] sure [15:34:48] then i will look at it as soon as i can [15:34:50] thanks! [15:35:32] big thing is to think about how we can make the data useful by third parties (via the api) [15:35:53] and also wikipedia mobile apps / site :) [15:36:41] New patchset: Daniel Werner; "Introduced new jQuery widget, jQuery.PersistentPromisor() for WikiData which will handle our usage of jQuery.Promise in all functions where we want to return the same promise as long as it is unresolved. Using this only on EditableValue.remove() for now, " [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12599 [15:41:11] I was a) suspecting a data provider, but its updated [15:41:19] Lydia_WMDE: and the brochures were very popular :) [15:41:28] * aude needs more stickers [15:41:35] then b) a missing update of legal sites, but its updated [15:41:44] aude: hah cool [15:41:58] soon as we have a logo, we should have stickers [15:42:09] yeah [15:43:15] I'm blank.. its only a few sitelinks defined now? [15:43:26] And they are loaded? [15:44:59] New patchset: Daniel Werner; "Introduced new jQuery extension, jQuery.PersistentPromisor for WikiData which will handle our usage of jQuery.Promise in all functions where we want to return the same promise as long as it is unresolved. Using this only on EditableValue.remove() for now," [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12599 [15:55:15] New patchset: Jeroen De Dauw; "Added SiteConfig interface and adittional documentation" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12601 [15:58:37] New patchset: Tobias Gritschacher; "fix for sitelinks: added method to strip of the wiki-part from global site key" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12595 [15:59:50] !changes [15:59:50] https://bit.ly/wdchanges [15:59:57] !changes del [15:59:57] Successfully removed changes [16:00:11] !changes is https://bit.ly/wbchanges [16:00:11] Key was added [16:00:23] !review del [16:00:23] Successfully removed review [16:00:47] !review is https://bit.ly/wbreview [16:00:47] Key was added [16:01:05] New review: Tobias Gritschacher; "(no comment)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12595 [16:38:06] New review: Jeroen De Dauw; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/12589 [16:38:08] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12589 [16:58:02] New review: Jeroen De Dauw; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/12595 [16:58:05] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12595 [18:45:47] New review: Daniel Werner; "Seems good" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/12588 [18:45:49] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12588