[07:42:53] New review: John Erling Blad; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/12586 [09:36:20] New patchset: Jeroen De Dauw; "Added tests for LibHooks and moved hooks file into Wikibase NS" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12843 [09:41:49] New patchset: Jeroen De Dauw; "Renamed WB\DifferenceEngine to WB\ItemDiffView" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12844 [09:56:51] New review: Jeroen De Dauw; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/12586 [09:57:27] New patchset: Jeroen De Dauw; "Added SiteList::offsetUnset test" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12845 [10:21:32] New review: Tobias Gritschacher; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/12594 [10:23:52] New review: Daniel Werner; "works" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/12594 [10:23:55] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12594 [10:24:25] New patchset: Jeroen De Dauw; "Introduce constants for the site type and groups" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12847 [10:25:35] New review: Daniel Werner; "This breaks the API tests. This should be figured out first." [mediawiki/extensions/Wikibase] (master); V: -1 C: -1; - https://gerrit.wikimedia.org/r/12596 [10:28:41] Jens_WMDE: just poke me when you want to do the site import script thinghy [10:29:47] *poke* [10:29:58] or maybe after lunch? [10:31:49] New review: Daniel Werner; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/12843 [10:31:49] after lunch! [10:31:51] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12843 [10:32:00] New review: Tobias Gritschacher; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/12847 [10:32:08] New review: Tobias Gritschacher; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/12847 [10:32:10] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12847 [11:09:02] Denny_WMDE: if I make a [[mw:stuff]] on EN WP, it does not get interpreted as interlanguage link, but [[de:stuff]] does [11:09:02] 10[1] 10http://mediawiki.org/wiki/stuff13 => [11:09:04] 10[2] 10http://de.wikipedia.org/wiki/stuff [11:09:20] Denny_WMDE: so I guess there is some check somewhere that sees if it's in the language code list or something [11:09:27] (that list being static config) [11:10:31] aah [11:11:18] JeroenDeDauw: does this list become redundant through the sites tables then or not? [11:49:30] New patchset: Jeroen De Dauw; "Make SiteRowTest derive from ORMRowTest for adittional coverage" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12596 [11:52:24] New patchset: Jeroen De Dauw; "some style fixes" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12853 [11:53:10] New patchset: Daniel Kinzler; "make the edit action the same as the view action" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12854 [11:54:08] New patchset: Daniel Kinzler; "pass relevant parsing options to from getParserOptions to ItemView" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12855 [11:56:11] New patchset: Daniel Kinzler; "make edit features depend on parser options" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12856 [11:59:47] New patchset: Daniel Kinzler; "Use Article::View to impl ItemViewAction::onView" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12857 [12:04:29] New review: Tobias Gritschacher; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/12596 [12:04:33] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12596 [12:05:34] New patchset: Daniel Kinzler; "show appropriate revision header in diff view" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12858 [12:08:39] New patchset: Daniel Kinzler; "in diffs, link to action=reswet instead of action=edit" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12859 [12:12:12] New patchset: Daniel Kinzler; "Supress edit features in diffs, even for current rev." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12859 [12:15:03] New patchset: Tobias Gritschacher; "fixed some naming issue in UtilsTests" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12860 [12:18:09] New review: Tobias Gritschacher; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/12853 [12:18:12] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12853 [12:30:31] New review: Jeroen De Dauw; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/12860 [12:30:33] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12860 [12:31:28] grr. who broke the tests? [12:31:39] 10) Wikibase\Test\SitesTest::testGetSiteByLocalId [12:31:40] ArrayIterator::current(): Array was modified outside object and internal position is no longer valid [12:31:42] also [12:31:52] 9) Wikibase\Test\SiteListTest::testOffsetSet [12:31:53] MWException: Can only add Site implementing objects to SiteList. [12:34:37] Daniel_WMDE: do you know, is there a url switch for choosing another content language? [12:35:34] Danwe_WMDE: there isn't, because content language is considered constant and global. traditionally, it can't ever change, because that would break links using localized namespace names, etc [12:36:14] changing content language after install is likely to break the wiki [12:36:44] there's a new concept called "page content language", but it's not really used by anything yet, as far as i know. [12:37:00] How about introducing something like content language to the content handler and core? [12:37:01] it's mainly used to make stuff like common.js render left-aligned even on rtl wikis. [12:37:27] Danwe_WMDE: we can introduce a "page language" or "page content language". i was already thinking about that [12:37:43] but we can't mess with THE content language, i.e. $wgLang. that must not change, ever. [12:37:47] yes [12:38:30] however, for use, the page language isn't specific to the page, it's really a transient state of the user's view. [12:39:09] if the COntentHandler provides a language code for a page, mediawiki can assume that this info is cachable [12:39:13] it isn't in our case [12:39:19] so i'm not sure how useful this really is [12:39:54] Danwe_WMDE: what would the content language for an item be? [12:40:43] Danwe_WMDE: isn't what we really need a user content language, as opposed to user interfacde language (and opposed to the wiki's and the page's content language) [12:40:48] ? [12:43:37] JeroenDeDauw: i'm getting a ton of errors from SitesTest and SiteListTest (see above). any idea why? [12:44:09] Daniel_WMDE: I see no errors (on current master) [12:44:41] hm... i do... [12:44:42] Daniel_WMDE: you mean the default content language? I guess it would be dynamic to the user. [12:44:58] but that could cuase problems with caching and so on [12:45:31] Danwe_WMDE: no, i mean there should be two user languages, one for content rendering and one for the ui. [12:45:44] yes [12:45:55] the cache already depends on the user language - it would then just depend on on or the other (or both) of the user languages [12:46:09] uselang should be only for ui, and we could introduce another switch for the page content [12:46:42] Danwe_WMDE: yea... that needs a lot of small and nasty changes in the core though... [12:46:54] Danwe_WMDE: is this urgent? what are you currently trying to do? [12:47:18] I am building the language switcher. Its not urgent but its not nice right now I think [12:47:26] it is about the language switcher [12:47:32] wouldnt it be enough to make uselang sticky? [12:47:38] if that is possible... [12:48:13] Daniel_WMDE: we would make uselang sticky whenever it is set, not just on Data views was Denny_WMDE's suggestion if I understood it right [12:48:34] Danwe_WMDE, Denny_WMDE: just make the user language sticky for now. change the preference when logged in, use a cookie if not. [12:48:50] yea, this is global and for everything [12:49:04] *how* does one make uslang sticky? [12:49:05] making data views special would be confusing [12:49:08] change the linker? [12:49:49] Danwe_WMDE, Denny_WMDE: i would suggest to implement this for logged in users only for the moment [12:49:55] if we would only show the language selector on data sites then it wouldn't be that confusing [12:50:17] Danwe_WMDE, Denny_WMDE: if we make it stick for non-logged-in users, we have to think hard about caching. [12:50:33] how so? [12:50:37] not harder than on commons [12:50:58] Danwe_WMDE: squid caches return full html pages to anon users, without ever hitting php. [12:51:09] Danwe_WMDE: so that content must not depend on a cookie. [12:51:10] ok [12:51:37] how about hacking the linker? [12:51:40] we can change the linker, but that would either bypass the squid caches (uselang does this afaik) [12:52:12] ...or we use somethign in the path. that would work, but we'd have to be careful not to poison the cache [12:52:28] let us use the linker to bypass squid for not-english for now [12:52:37] Danwe_WMDE: hacking the linker works, but as i said, we have to think hard about the implications. [12:52:38] once we have that settled, we can go for the path [12:52:59] ok, so you want to set uselang in every link? [12:53:02] most of the accesses for non-logged in users will be for en anyway [12:53:04] nasty... but possible i guess [12:53:23] in every link, but when it is uselang=en [12:53:29] in case of uselang=en just leave it out [12:53:36] that will use the squids in these cases [12:53:49] which should be at least 40% if not more [12:53:50] leave it out if uselang == wgLang [12:53:56] don't hard code it to "en" [12:53:57] yep [12:54:00] true [12:54:19] wglang is sitelang, right? [12:54:59] yes [12:55:07] good [12:55:16] let's make it so [12:55:17] its the uiser language actually [12:55:25] huh? [12:55:30] sorry, i'm confused then [12:55:44] so, wgContentLang or whatever it'S called :) [12:55:51] yeah, the site language [12:55:52] New review: Tobias Gritschacher; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/12844 [12:55:54] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12844 [12:56:00] if uselang = site language then no uselang [12:56:10] is jeroen hiding? or can someone poke him for me? [12:56:12] I think $wgLanguageCode is what we need [12:56:18] i need his input on the strange errors i'm getting [12:56:29] Daniel_WMDE: Jeroen is busy with jens [12:56:45] Danwe_WMDE: wgLanguageCode should be wgLang->getCode - that weould be the user language, no? [12:57:21] No, the name is confusing but it is the sites language code [12:57:37] urg, no wonder i'm confused ;) [12:57:54] also have to look up the language stuff whenever I am working on it [12:58:12] so, if the user is not logged in and the current language is not the site language, change all links. [12:59:10] (nod) [12:59:27] also for the logged in user, i guess [13:00:04] for the logged in user you can compare with the user language, no? [13:02:11] Danwe_WMDE: for logged inusers, that *is* the user language. there is no other concept of "current language". [13:02:54] Denny_WMDE, Danwe_WMDE: well... for logged in users... do you want to use uselang to override the normal user language?... [13:02:56] then yes [13:03:05] yea, why not [13:03:26] i was thinking just to set the user's language permanently, not just temporarly as uselang currently does [13:03:29] Daniel_WMDE: for us there is because we say the users interface language is the page content language, but there is also the global sites overall, real content language [13:04:09] Danwe_WMDE: i think we figured out uselang vs content language. now we have to figure out uselang vs user language [13:04:35] Daniel_WMDE: we shouldn't overwrite the users language he set in the settings, this is the language we want to display on top of the list [13:05:02] ok. then you need a way to compare uselang vs. the user's "real" language. [13:05:25] not sure where you would find that, afaik uselang will change the apparent user language for the current request [13:05:39] thats shitty [13:05:46] but necessary I guess [13:05:51] not sure, look closely :) [13:06:04] there must be some point where we can grab it [13:06:10] actually why should it not change the user lang preferences? [13:06:26] the idea is funny and it could work [13:06:27] because we want to display it as first choice on top of the list [13:06:42] the top of the list consists of all languages the user has selected [13:06:51] not just the one user lang selected [13:07:10] this means if a user regularly switches between en and de [13:07:13] mh, right, the list [13:07:21] and has only these two it will act just as he wants [13:07:27] he sees it on en [13:07:30] he wants to go to de [13:07:34] it is the first on the list [13:07:36] he switches [13:07:39] he is in de [13:07:42] he sees en on top [13:07:51] New review: Tobias Gritschacher; "This breaks the SiteListTest::testGroupNames when running tests with --group Wikibase. Tests pass wh..." [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/12845 [13:09:10] i could be wrong, but that sounds reasonable [13:09:34] Danwe_WMDE: btw, i just found out: ctrl-click into the marque (why you set breakpoints) will set a bookmark. [13:11:04] Denny_WMDE: Daniel_WMDE: We still have to use the linker for non-logged in users, so switching the users language then would just be another thing to implement. The user probably mostly uses sites set as his user language where we can deactivate the linker hack until he switches again. [13:11:53] Danwe_WMDE: yes [13:12:07] when we remove this system in favor of a nicer system where we have a page content language and can separate it from the interface language, it would be nice if the interface language is still untouched (although the user could go to his preferences once then, wouldn't hurt I guess) [13:14:38] ok [13:16:03] Also nice: if you remove the uselang parameter, you get back to your preferred user language. [13:18:44] Daniel_WMDE: Still confused by the caching: basically the site has to be cached for all languages separatelly by the squid, no? [13:19:16] Danwe_WMDE: or not at all. or only for english and not the rest. [13:19:40] Danwe_WMDE: if we want all languages to be cached, we have toi do some serious path-based magic and/or some hacks in the squid config. [13:19:53] for now, we'd just bypathh the squids by setting uselang [13:19:59] *bypass [13:20:10] the caching does not work when you have query parameters in the url, i.e. ?uselang=de [13:20:26] it must be a query-less URL in order for the cache to kick in [13:20:26] well, it's explicitly disable for that case [13:20:32] yes [13:21:00] so some pretty day there should be some query-less URL for every language to every item [13:21:04] and that will be then cached [13:21:21] then I guess it would be more performant if we decide not use use uselang when the user wants the EN content, but still use uselang when the user uses his user langage [13:21:30] exactly [13:21:46] that is why we said if uselang = language of the site then no uselang [13:21:57] i.e then the links should have no uselang [13:22:04] in that case the cache will kick in [13:22:31] if it is another language, we sticky uselang through all of it [13:22:34] and bypass the caches [13:22:49] bypass the squid caches [13:28:36] New patchset: Daniel Kinzler; "Supress edit features in diffs, even for current rev." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12859 [13:29:27] New patchset: Daniel Kinzler; "show appropriate revision header in diff view" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12858 [13:30:22] Denny_WMDE: make it so ;) [13:31:19] Daniel_WMDE: Jeroen is coming [13:31:54] Denny_WMDE: MWs language list obviously won't become redundant, it will simply stop being abused for this check :) [13:32:30] New patchset: Jens Ohlig; "insertDefaultSites will now get the data for the default sites from http://meta.wikimedia.org/w/api.php?action=sitematrix&format=json" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12866 [13:32:43] JeroenDeDauw: OK, good differentiation [13:33:17] Daniel_WMDE: Might be because you don't have any sites in your table? [13:34:01] Daniel_WMDE: I'm also not getting any errors or warnings [13:34:44] Daniel_WMDE: I tried making the tests in such a way that they always work (regardless of what in the table) [13:34:52] But if it's completely empty, something migh fail [13:34:58] Not supposed to [13:35:11] But I did not test the tests to work in such a situation :d [13:36:21] JeroenDeDauw: should the test really use the actual site list from the database? [13:36:29] shouldn't rather bring it's own list? [13:36:38] JeroenDeDauw: the failure mode is quite confusing [13:37:39] JeroenDeDauw: yea, that fixed it [13:37:52] JeroenDeDauw: pleaser at least check for this situation, and simply skip the test in such a case. [13:37:54] New review: Tobias Gritschacher; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/12866 [13:38:04] (that's what skip is for, i guess) [13:40:18] Daniel_WMDE: if you want to go add a manually constructed list of sites and maintain them, then go ahead [13:40:47] maintain them? [13:40:51] why maintain them? [13:40:59] just make 3 for testing. [13:41:16] Daniel_WMDE: so which tests did you have problems with? [13:41:17] anyway, the test should be skipped if the list is empty, or at least fail in a meaningful way. [13:41:29] Sure - I'll add checks now [13:41:58] Although presumably this really is an edge case that will not occur for most devs ever [13:42:06] Since the thing will have a default list of sites [13:42:13] JeroenDeDauw: http://pastebin.com/JJTD46u9 [13:42:40] afk for a while [13:42:58] Daniel_WMDE: The linker is by far not used everywhere, i think its just used for the content. Any suggestion? Did I miss anything? [13:44:03] New review: Tobias Gritschacher; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/12866 [13:46:04] Daniel_WMDE: thnx [13:46:33] JeroenDeDauw: TobiasG_WMDE is right. Tests shouldn't depend on an external site. [13:46:42] Danwe_WMDE: you missed something - skin derives from linker. [13:47:09] Danwe_WMDE: pretty much all links are constructed via the links, i think. [13:47:19] *linker. [13:47:21] hm... [13:47:23] actually [13:47:48] the URL comes from the Title class [13:47:50] I used LinkBegin, I'll try something else [13:47:51] Jens_WMDE JeroenDeDauw: this might be the right moment to move the test-data-inserting-into-table-thing right to the tests. [13:47:54] but we should probably not mess with that [13:48:27] Danwe_WMDE: ah - I'm pretty sure the linker is used, but it may be that it's a different method... [13:48:42] Danwe_WMDE: let me know what isn't covered by that. [13:48:59] TobiasG_WMDE: yea, that would be nice [13:49:14] Daniel_WMDE: pretty much everything isn't covered by that hook expcept for wikitext links [13:49:48] Danwe_WMDE: special pages too, i should think [13:49:55] but the stuff in the navigation isn't? [13:50:20] Daniel_WMDE: most special pages use Linker::link() to build links, yes, but it doesn't mean they have to [13:50:40] Danwe_WMDE: special pages, nagivation links in diffs and old revisions, the history page... [13:50:58] no, they don't have to. but they SHOULD. [13:51:09] yes, should xD [13:51:11] the question is whether suff in the skin uses it [13:51:19] toolbox, user tools, page tools, etc [13:52:12] Jens_WMDE JeroenDeDauw: it seems that the insertDefaultSites is only called in the ApiSetItemTest - so just put the "old" data in there and avoid the call to insertDefaultSites [13:53:02] Daniel_WMDE: Funny, the navigation doesn't use it but the footer with the disclaimer and about links [13:58:11] New patchset: Jeroen De Dauw; "Skip tests if they cannot run without errors due to setup stuff" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12870 [13:58:54] if ( defined( 'MW_PHPUNIT_TEST' ) ) { [14:00:04] Its bad style if its used in code, but sometimes the devil have to wear dress.. [14:00:25] Or there fall snow in Hell or whatever [14:01:12] Danwe_WMDE: the disclaimer etc is wikitext from a system message, it goes through the parser. [14:01:34] New patchset: Jens Ohlig; "insertDefaultSites will now get the data for the default sites from http://meta.wikimedia.org/w/api.php?action=sitematrix&format=json" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12866 [14:01:45] Danwe_WMDE: the skin doesn't use the linker but constructs links directly? but it takes the navigation urls from some data array... [14:01:52] we can try to mess with that [14:02:02] actually, that's the same place where you would disable the edit tab. [14:02:42] Daniel_WMDE: yes, they are in an array. But there can be more places for links and we might still miss links somewhere where the system will then fail [14:03:30] Danwe_WMDE: https://www.mediawiki.org/wiki/Manual:Hooks/SkinTemplateNavigation [14:03:39] yes, it's not perfect# [14:03:45] it probably can't be [14:04:10] let's go with the 80% use cases we can cover with 20% of the effort ;) [14:04:13] how about a JavaScript solution, you only get the language selector with JS enabled... [14:04:20] would be good to document where it doesn't work, though [14:04:21] or it is only sticky with JS [14:04:41] documenting it where it DOES work is easier [14:04:50] Danwe_WMDE: then it woulkd be impossible to edit stuff in other languages without JS... [14:05:03] not, it just wouldn't be sticky [14:05:09] which would be ok for now, but we do need a real solution [14:05:50] Daniel_WMDE: what's the point in hacking in a buggy solution now if we should make it niece anyhow, with having a real separation of page content and ui language [14:06:55] Danwe_WMDE: because we need a working solution now. and the real solution needs quite a bit of thought and design. if you like, post about it to wikitech-l [14:07:51] Daniel_WMDE: yes, I mean instead of having no solution, doing the easy JS solution for now where it is sticky only when JS is enabled [14:07:57] New patchset: Jens Ohlig; "insertDefaultSites will now get the data for the default sites from http://meta.wikimedia.org/w/api.php?action=sitematrix&format=json" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12866 [14:08:27] Danwe_WMDE: you would rewrite the URLs in links dynamically? [14:09:09] yes [14:09:46] OR overwriting the users language after all for logged in users and ignoring others [14:09:47] New patchset: Jeroen De Dauw; "Added SiteList::offsetUnset test" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12845 [14:09:57] or a cookie [14:11:08] cookie for anons breaks the cache [14:11:47] and overwriting the user language sucks imho, also only works for logged in users [14:12:16] TobiasG_WMDE: have another look. [14:12:27] New review: Jeroen De Dauw; "Error was coming from SiteList itself, fixed by added code there :)" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/12845 [14:13:31] Jens_WMDE: I'm not a friend of code which is just there because of tests. [14:13:47] neither am i. [14:13:56] i feel dirty [14:13:57] I don't like the idea of this MW_PHPUNIT_TEST at all [14:14:10] but what's the alternative? [14:14:53] as I said: move all the stuff from inside the if ( defined( 'MW_PHPUNIT_TEST' ) ) { to the test which needs it [14:21:54] New review: Daniel Kinzler; "Still seeing a lot of errors when the sites table is empty: http://pastebin.com/NW0jK1aL" [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/12870 [14:22:47] New patchset: Jeroen De Dauw; "insertDefaultSites will now get the data for the default sites from http://meta.wikimedia.org/w/api.php?action=sitematrix&format=json" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12866 [14:23:48] New review: Tobias Gritschacher; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/12845 [14:23:50] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12845 [14:32:27] New review: Daniel Kinzler; "i found some issues... sorry for commenting on the wrong patch set. please see patch set 3." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12866 [14:32:44] New review: Daniel Kinzler; "see comments for patch set 3." [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/12866 [14:32:52] New patchset: Jeroen De Dauw; "insertDefaultSites will now get the data for the default sites from http://meta.wikimedia.org/w/api.php?action=sitematrix&format=json" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12866 [14:39:12] New review: Jeroen De Dauw; "(no comment)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12866 [14:43:40] New review: Jens Ohlig; "(no comment)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12866 [14:43:55] New review: Jeroen De Dauw; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/12854 [14:43:57] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12854 [14:46:39] New review: Jeroen De Dauw; "(no comment)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12866 [14:48:49] New review: Jens Ohlig; "(no comment)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12866 [15:11:07] New patchset: Tobias Gritschacher; "insertDefaultSites will now get the data for the default sites from http://meta.wikimedia.org/w/api.php?action=sitematrix&format=json" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12866 [15:15:29] New review: Tobias Gritschacher; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 0 C: 2; - https://gerrit.wikimedia.org/r/12866 [15:19:20] New review: Daniel Kinzler; "still not quite happy (see comments), but not opposing a merge." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/12866 [15:28:55] New review: Jeroen De Dauw; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 0 C: 2; - https://gerrit.wikimedia.org/r/12866 [15:32:56] New review: Jeroen De Dauw; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/12866 [15:32:58] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12866 [15:35:10] New review: Jeroen De Dauw; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/12855 [15:35:12] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12855 [15:49:12] Looks like we're getting a lot of stuff done today :) [15:50:30] * Lydia_WMDE needs some input for today's daily tweet [15:51:05] New review: Jeroen De Dauw; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/12856 [15:51:07] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12856 [15:55:54] New patchset: Jeroen De Dauw; "Use Article::View to impl ItemViewAction::onView" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12857 [15:56:04] New review: Jeroen De Dauw; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/12857 [15:56:07] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12857 [16:09:28] New review: Jeroen De Dauw; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/12858 [16:09:31] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12858 [16:20:58] New review: Daniel Kinzler; "note: the Wikidata branch now contains the necessary core change. Without the core change, this patc..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/12859 [17:12:56] New patchset: Jeroen De Dauw; "Skip tests if they cannot run without errors due to setup stuff" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12870 [17:13:20] New review: Jeroen De Dauw; "Check the diff between patchset 1 and 2 if you want to see some epic fails :)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12870 [17:25:25] Change abandoned: John Erling Blad; "Rewritten" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12096 [17:27:25] New patchset: John Erling Blad; "Added check of page at client before a sitelink is accepted." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12899 [17:36:23] New review: John Erling Blad; "Some cleanup is missing, carry over from earlier abandoned change." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/12899 [17:42:53] New patchset: John Erling Blad; "Added check of page at client before a sitelink is accepted." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12899 [18:00:06] New review: Daniel Kinzler; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/12870 [18:00:09] Change merged: Daniel Kinzler; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12870 [19:01:36] New patchset: John Erling Blad; "Changed from use of "isAllowed" to "userCan" for protection of items through API" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12907 [21:48:55] New patchset: Daniel Kinzler; "Use deleteAllData deleteJoin instead of content_model." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12955 [22:05:49] zzz