[12:39:50] New review: Jens Ohlig; "No obvious errors found, tests are green, no objection to merge." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/12996 [12:39:52] Change merged: Jens Ohlig; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12996 [12:41:04] JeroenDeDauw: I can haz chocolate? [12:49:40] the chocolate by JeroenDeDauw was a lie :'( [13:12:26] New patchset: Jeroen De Dauw; "Added SiteConfigObject tests and made some fixes to site type handling" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13004 [13:13:38] the chocolate by JeroenDeDauw wasn't a lie :) [13:34:20] New patchset: Tobias Gritschacher; "ui: replacing sitelink page with normalized version of title getting from the api; this depends on the normalization-stuff done by the API;" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13007 [13:34:37] Daniel_WMDE: What do you think, should I put the site selector thingy into a separate extension? Might make sense. [13:35:09] Danwe_WMDE: site selector? language selector? [13:35:28] erm, yes, sorry [13:35:33] Danwe_WMDE: like this? https://www.mediawiki.org/wiki/Extension:LanguageSelector [13:35:54] Danwe_WMDE: i told you about it a while back... but don't worry, it's not the same. [13:36:00] that extension uses a cookie. [13:36:11] good enough for most sites, but not for wikimedia. messes with the squids. [13:36:23] but perhaps nice for reference [13:36:27] yes, like that [13:36:40] yera [13:36:49] err. yea. arrr. [13:36:50] New patchset: Tobias Gritschacher; "ui: replacing sitelink page with normalized version of title getting from the api; this depends on the normalization-stuff done by the API;" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13007 [13:37:10] Danwe_WMDE: that means a separate git repo and gerrit project, though [13:37:22] I guess [13:37:28] Or putting it into our repo :p [13:37:29] file a ticket on bugzilla and use a local repo (or github) until it's set up [13:37:51] well... having the 3 wikibase extension in one repo is already awkward. [13:38:12] if this is really independant, let's make it actually independant [13:39:30] Daniel_WMDE: by the way, Denny_WMDE doesn't seem to like the idea of separating page content language from interface language, at least this morning it sounded like this solution I am working on now might be as good at it gets, except that it should work without javaScript at some point [13:40:19] yea, i know. and it does raise quite a few interface issues. it's something that we can discuss again a lot later [13:40:29] for now let's just use the user language, that's it. [13:40:58] Daniel_WMDE: not sure then again whether making a separate extension is worth the effort right now... [13:41:21] so, our current implementation would be to perpetuate the uselang parameter by hooking into the links, unless uselang is the same as the user (!) language. [13:41:28] never mind whether the user is logged in or not. [13:41:58] Danwe_WMDE: code-wise, it's all of 10 minutes extra work, and it may come in very handy later [13:42:10] i could imagine that it would be used standalone on meta and commons, for instance [13:42:14] they would *love* this [13:42:36] Danwe_WMDE: please do make it standalone. [13:42:45] Daniel_WMDE: I think its more effort, have to separate the code again (also the user options) and create the new repo, but yes [13:43:00] user options? why? [13:43:12] preferred languages [13:43:24] that extension doesn't need to know about preferred languages [13:43:25] should be part of the extension then [13:43:28] it does exactly one thing: [13:43:50] if uselang is set, and different from the user language, rewrite all links (as far as possible) to include the uselang parameter [13:44:01] that's it. [13:44:17] i'm not even sure it should contain the code for the language selector in the sidebar... [13:44:40] I would include the selector as well, at least optionally [13:44:52] yea... probably. [13:45:06] and therefore also the user options, since they are kind of handy when having the selector [13:45:17] but it must be optional. sites using this functionality may still have language links (e.g. commons and meta). see the old LanguageSelector extension for some options. [13:45:29] it has code for a selector like this. [13:45:44] also, 3rd parties might be interested in maintaining that stuff then if they find it handy. [13:45:48] yes, optional [13:45:54] oh, and see the Polyglot extension for injecting "fake" language links in the sidebar. [13:46:14] I already managed to do that... [13:46:28] i wrote LanguageSelector and Polyglot to be used together for multilingual sites a while back. [13:46:39] works well enough, though a bit hacky. and not for wmf. [13:46:43] I'll look at it nonetheless [13:46:51] note that the code is quite old [13:47:07] it may be broken in parts, or not doing things the right way. [13:49:08] maybe I better don't look at it then =) The injection of the links is quite simple with the right hook. Just a pitty we can't use the OutputPage::setLanguageLink() but therefore I had to make quite some changes to core, wouldn't be that clean either [13:58:40] !gerrit is https://gerrit.wikimedia.org/r/#q,$1,n,z [13:58:40] Key was added [14:05:15] New patchset: Daniel Kinzler; "Use 'wikibase-item' as content model id." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13014 [14:06:34] I just pushed a breaking change to Wikidata. See the list for details. [14:06:58] ohoh [14:07:24] New patchset: Jeroen De Dauw; "Added interfaces for data and config fields of sites table" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13015 [14:08:08] Danwe_WMDE: Y U NO LIKE BREAKING CHANGE? [14:09:50] Only if its introduced by me, the other Daniel [14:13:58] New patchset: Jeroen De Dauw; "Added getLanguage method to site object" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13016 [14:17:24] aude: is there an ical file of the wikimania schedule somewhere by chance? [14:25:20] Jens_WMDE: need to restart apache on *dev-3, is that ok for you? [14:27:52] sure [14:44:37] Lydia_WMDE: no [14:51:00] Localisation team sprint demo is in about 10 minutes. See http://lists.wikimedia.org/pipermail/mediawiki-i18n/2012-June/000505.html [14:51:23] Nikerabbit: thx for the reminder - Denny_WMDE will join [14:51:40] aude: ok - would be cool to have [14:52:16] Lydia_WMDE: agree [14:54:09] Nikerabbit: if i get the website to work... [14:54:18] Denny_WMDE: windows or linux? [14:54:47] googling webex in latter case should help [14:55:17] mac [14:55:47] that should just work then [14:56:10] flash and quicktime work, windows media doesn't [14:56:15] do i really need all three of them? [14:57:51] hmm I thought Java is enough [14:58:26] New patchset: Jeroen De Dauw; "Added tests for MediaWikiSite class and new Sites::newSite helper method" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13021 [14:59:20] New patchset: Jeroen De Dauw; "Updating the site import code to set the language field" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13022 [15:00:47] Jens_WMDE: there are a few very easy to review changes up on gerrit, just waiting for you to merge them [15:00:48] :p [15:01:30] Winodws media [15:01:32] aaaaaaaaaaah [15:01:33] horror [15:02:23] chocolate... [15:03:50] Jens_WMDE: first review :) [15:04:54] Danwe_WMDE: can you come over for a second? [15:05:36] New review: Jens Ohlig; "Easy enough." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/13021 [15:11:17] Danwe_WMDE: can you go away for a second? [15:11:22] Jens_WMDE: MOOOOOOAAAAR [15:11:32] New patchset: John Erling Blad; "Changes to importInterlang.php and some comments on a working environment." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13023 [15:12:23] win win [15:21:52] Please check my twitter account at http://twitter.com/#!/ShitDanweSays [15:25:51] Please don't... [15:28:13] uh [15:32:30] do i detect some keyboard theft? ;) [15:32:51] I think so [15:33:04] Lydia_WMDE: 2919? [15:33:11] i have it memorized! [15:33:23] please help me forget that # [15:33:25] jeremyb: :D [15:33:25] kthx [15:33:43] * Lydia_WMDE goes Men in Black on jeremyb [15:33:50] ewwwwww [15:33:54] lol [15:34:08] Lydia_WMDE: i'm a *lot* closer to manhattan than you... [15:34:20] ;-) [15:38:01] Denny_WMDE: When do you know about the sticky language stuff? I was just about to outsource all of the language selector related stuff into a separate extension but stopped until this is clear [15:38:20] I mean, did you talk with the responsible people already? [15:40:30] Lydia_WMDE: so, srsly, ??? [15:41:13] New patchset: Jeroen De Dauw; "Kill the evil codes!" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13026 [15:41:38] jeremyb: hmm? i posted the result of the discussion about wikidata.org to the ticket 6 days ago [15:41:41] since then i didn't get a reply [15:41:49] Lydia_WMDE: /me searches [15:42:26] jeremyb: ok - i have to run home - back online in about 45 mins [15:43:01] Lydia_WMDE: it's so early! [16:11:23] Daniel_WMDE: CONTENT_MODEL_WIKIBASE_ITEM as branch name? :p [16:11:28] You drunk or what? :d [16:11:59] TURN_CONTENT_MODEL_WIKIBASE_ITEM_INTO_A_FRIGGIN_STRING_ID_YAY_LOL [16:12:22] gerrit calls it "topic". it fits. [16:13:20] New patchset: Jeroen De Dauw; "Fix indentation" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13033 [16:14:51] New review: Jens Ohlig; "Ok." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/13004 [16:14:54] Change merged: Jens Ohlig; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13004 [16:16:50] New review: Jens Ohlig; "?" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/13015 [16:16:52] Change merged: Jens Ohlig; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13015 [16:33:41] New review: John Erling Blad; "(no comment)" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/12899 [16:34:56] jeremyb: ;-) [16:37:12] Daniel_WMDE: so... are you drunk? ;) [16:37:22] not yet [16:37:38] do you expose drunkenness by SNMP? [16:37:49] via finger [16:37:54] ahh [16:38:20] echo "get wasted" > .plan [16:38:51] i prefer SNMP [16:39:08] also numbers! like BAC [16:40:17] New patchset: John Erling Blad; "Added check of page at client before a sitelink is accepted." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12899 [16:47:35] Denny_WMDE: Jens_WMDE: Y U NO REVIEW ALL OF THE CODES? [16:53:14] bbl [16:58:37] JeroenDeDauw: http://stackoverflow.com/questions/927358/git-undo-last-commit [17:09:55] Jens_WMDE: http://www.wired.com/wiredscience/2012/06/google-x-neural-network/ [17:16:40] JeroenDeDauw: wow. just wow. [17:17:35] Jens_WMDE: I want one of these [17:30:28] Daniel_WMDE: uhhhhh, you know you signed the list for WTM onwiki twice???? ;) [17:31:14] Daniel_WMDE: what email should I use? [17:31:21] for WTM [20:21:29] jeremyb: use daniel at brightbyte.de for WTM [21:09:48] New patchset: Daniel Kinzler; "Use Article::View to impl ItemViewAction::onView" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13092 [21:10:44] New review: Daniel Kinzler; "New attempt in I8936dc2e" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12857 [21:12:08] New review: Daniel Kinzler; "new attempt in I8936dc2e" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/12984 [21:28:08] Daniel_WMDE: so did you decide if you're only one person? ;) [21:28:33] jeremyb: i have tried, but i couldn't convince myself... [21:28:39] uhuh [22:07:58] New review: Daniel Werner; "Henning and me thought about having an explicit language field in the old sites config array before ..." [mediawiki/extensions/Wikibase] (master); V: 0 C: -2; - https://gerrit.wikimedia.org/r/13022