[02:48:30] zzz [04:02:58] New patchset: John Erling Blad; "SGL-file for dropping sites table, and a minor change for a file to drop interwiki table." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13854 [04:24:13] New patchset: John Erling Blad; "Additional changes to get the normalization right when requesting client side information, and also normalization of UTF8 and squashing whitespace." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13492 [04:26:33] New review: John Erling Blad; "Just a quick look through to reset flags." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/13492 [08:54:05] New review: Jeroen De Dauw; "Why the patch file for dropping the sites table?" [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/13854 [09:43:05] New review: John Erling Blad; "It can be done any way you like, but it must be available somehow. The code right now will not updat..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/13854 [09:54:57] New patchset: Daniel Kinzler; "Overhauled permission checks in the API." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13861 [10:01:23] New patchset: John Erling Blad; "Additional changes to get the normalization right when requesting client side information, and also normalization of UTF8 and squashing whitespace." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13492 [10:06:53] New patchset: Jeroen De Dauw; "Add handling for creation and deletion of items in the changes stuff" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13862 [10:12:04] New review: Jeroen De Dauw; "The Item/ItemContent split got merged in on Friday - looks like you still need to rebase." [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/13861 [10:22:31] In soviet russia, you rage to these changes they should review Abraham_WMDE [10:22:31] * https://gerrit.wikimedia.org/r/#/c/13448/ [10:22:31] * https://gerrit.wikimedia.org/r/#/c/13493/ [10:22:31] * https://gerrit.wikimedia.org/r/#/c/13536/ [10:22:31] * https://gerrit.wikimedia.org/r/#/c/13862/ [10:22:46] Danwe_WMDE: Henning_WMDE Jens_WMDE TobiasG_WMDE ^ [10:23:48] JeroenDeDauw: ^^ [10:25:21] New review: Jeroen De Dauw; "> The code right now will not update the table if there are data in it" [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/13854 [10:31:58] New review: Jeroen De Dauw; "So do you want to have this merged - or is this just for CR?" [mediawiki/extensions/Wikibase] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/13475 [10:42:59] New review: Daniel Kinzler; "oh, ok, will do that." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/13861 [10:43:09] New patchset: Jeroen De Dauw; "Added some missing class docs" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13863 [10:46:55] New patchset: John Erling Blad; "Prevent direct editing of item through API." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13191 [10:48:59] Abraham_WMDE: I think you need to rage harder :p [10:50:23] JeroenDeDauw: so no more cookies? :) [10:52:28] New patchset: Jens Ohlig; "Refactored Selenium tests to use code blocks instead of re-using @current_page object." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13864 [10:53:24] TobiasG_WMDE: I can haz review? [10:54:28] New patchset: John Erling Blad; "Additional changes to get the normalization right when requesting client side information, and also normalization of UTF8 and squashing whitespace." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13492 [10:57:04] Jens_WMDE: of course, but a little bit later. does that matter? [10:57:26] take your time. [11:19:08] New patchset: John Erling Blad; "Additional changes to get the normalization right when requesting client side information, and also normalization of UTF8 and squashing whitespace." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13492 [11:26:08] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13299 [11:27:36] New patchset: Jeroen De Dauw; "Added tests for the ChangeHandler class" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13866 [11:32:13] New patchset: Jeroen De Dauw; "Fix item type in tests" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13867 [11:32:48] New review: Jeroen De Dauw; "One item test is broken because I forgot to update the item type there. This has been fixed in follo..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/13862 [12:02:41] New patchset: Jeroen De Dauw; "Moved ChangeNotifier class to lib because it belongs together with all the other base change stuff" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13869 [12:04:56] New patchset: Jeroen De Dauw; "Fix singleton test for Sites class - need to use tripple equals since assertEquals gives true even for different instances" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13870 [12:08:01] why is this wikimedia-wikidata and not #wikidata [12:09:59] petan: because of freenode policies [12:10:15] JeroenDeDauw: there are no policies preventing that [12:10:32] petan: poke Lydia_WMDE and Denny_WMDE1 [12:10:49] #wikipedia is same [12:10:49] there are [12:10:57] otherwise it would be #wikimedia-wikipedia [12:11:26] yeah we'd have to register wikidata as a separate project and that is taking a long time and is currently not possible [12:11:39] wikipedia is wikimedia project just as wikidata [12:11:42] register where? [12:11:46] with freenode [12:11:51] freenode consider all wikimedia projects as one [12:11:51] as a project channel owner [12:11:54] afaik [12:12:04] we have global group contacts [12:12:12] who handle all wikimedia channels [12:12:15] yes i know [12:12:20] boink boink boink [12:12:40] JeroenDeDauw: you called..? [12:12:46] jeblad: https://gerrit.wikimedia.org/r/#/c/13870/1 [12:13:13] New review: Demon; "For future reference, there is also an assertSame() which is I think what you're looking for." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/13870 [12:15:33] petan: it was faster to set up back when we did [12:23:10] New review: John Erling Blad; "There is a feilure, but it seems to be the usual one. Its fixed in a patchset (13492) that is up for..." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/13870 [12:23:12] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13870 [12:25:35] New patchset: Jeroen De Dauw; "Implemented isEMpty method in ItemObject and added tests for it" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13873 [12:25:35] New patchset: Jeroen De Dauw; "Added tests for ItemObject class" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13448 [12:31:37] New patchset: Jeroen De Dauw; "Implemented isEMpty method in ItemObject and added tests for it" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13873 [12:36:28] JeroenDeDauw: http://ubuntuforums.org/showthread.php?t=1977483 [12:37:49] JeroenDeDauw: helpful? [12:39:35] Jens_WMDE: yeah - that fixed it :) thnx! [12:43:26] New review: Daniel Werner; "When running tests I get:" [mediawiki/extensions/Wikibase] (master); V: -1 C: -1; - https://gerrit.wikimedia.org/r/13493 [12:47:55] New review: John Erling Blad; "Can't run tests, fails with" [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/13493 [12:53:48] New patchset: Jeroen De Dauw; "Added moar itemObject tests" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13874 [12:55:06] New patchset: Jeroen De Dauw; "Matching changes in core" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13493 [13:02:59] I now have 10 changes sitting in review... [13:07:33] New patchset: Jeroen De Dauw; "Matching changes in core" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13493 [13:13:58] New review: Daniel Werner; "Seems good, could be documented a bit better though, especially if it goes to core." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/13536 [13:14:02] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13536 [13:23:05] New patchset: Henning Snater; "made aliases widget to pick up the value returned from the API" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13878 [13:25:17] New patchset: Jeroen De Dauw; "Added test for remoevAliases, removeLabel and removeDescription" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13879 [13:27:46] New review: John Erling Blad; "Only the usual failure in Wikibase\Test\ApiLinkSiteTest::testTitleToPage" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/13493 [13:27:49] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13493 [13:31:37] New review: John Erling Blad; "Seems like there is a circular dependency where https://gerrit.wikimedia.org/r/#/c/13867/ depends on..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/13862 [13:44:29] Daniel_WMDE: are you now doing the sitelink object item, or is that one still up for grabs? [13:50:45] New patchset: Jeroen De Dauw; "Remove compatibility code and commented out broken tests using the old internal structure" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13883 [14:10:58] New review: John Erling Blad; "There are two unknown failures on Wikibase\Test\ChangesTest::testNewFromArray but I'm going to submi..." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/13862 [14:11:01] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13867 [14:11:02] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13862 [14:11:18] New patchset: Daniel Kinzler; "Overhauled permission checks in the API." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13861 [14:30:18] New patchset: John Erling Blad; "Prevent direct editing of item through API." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13191 [14:33:11] New patchset: John Erling Blad; "Additional changes to get the normalization right when requesting client side information, and also normalization of UTF8 and squashing whitespace." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13492 [14:35:58] New review: Jeroen De Dauw; "See inline comment on PS6" [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/13492 [14:36:29] New review: Jeroen De Dauw; "Merging, but please take care of inline comment on PS6" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/13492 [14:36:32] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13492 [14:40:34] gggaaaahhhhh!!!! [14:40:43] me and gerrit, we are NOT friends today. [14:42:22] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13863 [14:43:56] New review: Daniel Kinzler; "screwed that one up, will amend in a second." [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/13861 [14:44:45] Daniel_WMDE: oh, you are here now, good. Would you take a look at my mail about the language selector please [14:45:24] Danwe_WMDE: the way things are going for me today, i probably won't get to it, and if i do, i'll screw it up. [14:45:35] meh [14:45:38] anyway. [14:45:43] will have a look [14:53:40] New review: Nikerabbit; "This commit message is not useful to other developers." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13493 [14:54:20] New patchset: Daniel Kinzler; "Overhauled permission checks in the API." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13861 [14:54:56] JeroenDeDauw: could you have a look now? should be much better. [14:57:08] ...or maybe this needs another rebase [14:57:13] * Daniel_WMDE is going totally bonkers [14:57:22] git is driving me nuts today. [14:59:15] New patchset: Tobias Gritschacher; "implemented i18n of UI error handling based on the API error-code" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13890 [15:00:14] Nikerabbit: "This commit message is not useful to other developers." wtf? :p [15:00:27] Daniel_WMDE: at what? [15:00:43] JeroenDeDauw: never mind, have to fix it for the fifth time today. [15:01:05] Daniel_WMDE: at least you are not having merge conflicts with things that are not (and have never been) part of the repository, as John has somehow managed [15:01:07] i'm still trying to get my morning "quick, push this for review" finished. [15:01:38] JeroenDeDauw: i'm having merge conflicts with myself. i got myself into a total mess. [15:01:42] never mind [15:01:47] Daniel_WMDE: I thought the morning thing was about reviewing, not pushing stuff for review... :p [15:02:03] indeed. it should be. [15:02:15] Daniel_WMDE: john also has that, so he still gets the mess-up-git award :) [15:02:29] :P [15:03:29] Daniel_WMDE: If you want to feel productive, you can always review and merge my 6 easy-to-review changes https://bit.ly/wbreview :D [15:10:36] New patchset: Tobias Gritschacher; "implemented i18n of UI error handling based on the API error-code" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13890 [15:10:51] New patchset: Jeroen De Dauw; "Added LocalItem tests" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13891 [15:12:13] New patchset: John Erling Blad; "Prevent direct editing of item through API." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13191 [15:18:22] New review: Jens Ohlig; "Looks okay." [mediawiki/extensions/Wikibase] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/13891 [15:22:20] JeroenDeDauw: that's my opinion, do you disagree? [15:22:53] New patchset: Daniel Kinzler; "Overhauled permission checks in the API." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13861 [15:23:21] JeroenDeDauw: ok, maybe this one works now :) [15:27:21] Nikerabbit: yeah :p [15:28:07] Daniel_WMDE: you want me to review https://gerrit.wikimedia.org/r/13861 ? [15:28:20] JeroenDeDauw: that would be great :) [15:28:34] i'll do a round of reviews myself now [15:28:44] (this took waaayyyy too long) [15:35:22] New review: John Erling Blad; "After rebase one error went away and the other one seems to be unrelated. I'm going to be bold and s..." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/13883 [15:38:40] JeroenDeDauw: well, I'm not gonna start arguing [15:40:57] New review: Nikerabbit; "In future please add blank line after first line in commit message, thanks :)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13299 [15:42:32] Change merged: Daniel Kinzler; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13448 [15:43:37] New patchset: John Erling Blad; "Prevent direct editing of item through API." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13191 [15:51:18] New review: Daniel Kinzler; "seems fine, but could be improved" [mediawiki/extensions/Wikibase] (master); V: 1 C: 1; - https://gerrit.wikimedia.org/r/13873 [15:53:19] New patchset: John Erling Blad; "Prevent direct editing of item through API." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13191 [16:04:27] Change merged: Henning Snater; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13191 [16:20:17] New review: Daniel Kinzler; "I'm still confused why the two methods about user language settings are in this patch..." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13191 [16:21:49] New patchset: John Erling Blad; "Added LocalItem tests" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13891 [16:27:01] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13891 [16:34:34] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13866 [16:49:20] New patchset: John Erling Blad; "Moved ChangeNotifier class to lib because it belongs together with all the other base change stuff" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13869 [17:01:51] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13869 [17:04:09] New review: Jeroen De Dauw; "Danwe +2'd this" [mediawiki/extensions/Wikibase] (master); V: 0 C: 2; - https://gerrit.wikimedia.org/r/13873 [17:04:12] Change merged: Daniel Kinzler; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13874 [17:04:13] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13883 [17:04:14] Change merged: Daniel Kinzler; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13879 [17:04:15] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13873 [17:06:56] New patchset: Jeroen De Dauw; "Overhauled permission checks in the API." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13861 [17:07:12] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13861 [17:13:48] New review: John Erling Blad; "Can't spot anything unusual." [mediawiki/extensions/Wikibase] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/13878 [17:21:48] is denny around? [17:24:42] New review: John Erling Blad; "Nothing unusual, but I am a little suspicious about the use of indexes into arrays without checking ..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/13890 [18:40:55] New patchset: Raimond Spekking; "Replace \n with a real line break per Siebrand" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13901 [19:52:26] Change merged: Siebrand; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13901 [20:01:28] New patchset: Daniel Werner; "Special pages display useful link labels for data item links now." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/13931