[00:01:31] Reedy: right ^ I already told you :P [00:01:41] yup [00:01:45] I so want to break it [00:01:46] :p [00:01:52] I know, I feel it too :P [00:02:05] its so wrong that it works [00:02:33] heh [07:51:37] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14194 [08:02:43] New patchset: John Erling Blad; "Reporting of missing items in reply from ApiGetItems." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14279 [08:06:34] New review: John Erling Blad; "See also https://bugzilla.wikimedia.org/show_bug.cgi?id=37504 and https://bugzilla.wikimedia.org/sho..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/14279 [08:12:49] New patchset: John Erling Blad; "Merge "Moved string handling functions to Utils."" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14280 [08:14:14] Change abandoned: John Erling Blad; "Fail!! Die!!" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14280 [08:18:31] New patchset: John Erling Blad; "Merge "Moved string handling functions to Utils."" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14281 [08:19:08] Change abandoned: John Erling Blad; "Pokker." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14281 [08:23:26] New patchset: John Erling Blad; "Reporting of missing items in reply from ApiGetItems." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14279 [08:35:23] New patchset: John Erling Blad; "Reporting of missing items in reply from ApiGetItems." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14279 [08:37:52] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14279 [09:44:08] New patchset: Daniel Werner; "Language is sticky for form fields now." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14283 [09:47:35] New patchset: Daniel Werner; "Language is sticky for form fields now (DO NOT MERGE)." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14283 [09:54:47] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14203 [10:18:24] New patchset: Tobias Gritschacher; "added basic selenium testing for search functionality" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14202 [10:26:41] Abraham_WMDE: [10:48:17] JeroenDeDauw: did you change Items behavior for getDescription() to return false instead of empty strings lately? [10:49:07] getLabel and others as well^^ [10:56:52] New patchset: Daniel Werner; "Fixed 'title' attribute for links to data items" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14288 [11:14:31] New patchset: Jeroen De Dauw; "Only execute current sql for mysql and sqlite" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14291 [11:16:21] New patchset: Daniel Werner; "links to deleted items won't throw errors anymore" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14292 [11:22:16] New patchset: Daniel Werner; "links to deleted items won't throw errors anymore" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14292 [11:26:15] New patchset: Daniel Werner; "links to deleted items won't throw errors anymore" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14292 [11:35:20] New patchset: Daniel Werner; "Deleting items doesn't throw an error anymore" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14296 [11:38:52] Change abandoned: Daniel Werner; "might break something else" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14296 [11:49:09] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14292 [11:52:05] New patchset: Tobias Gritschacher; "protected page selenium test: also testing for description and aliases now" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14297 [11:53:53] New review: Jens Ohlig; "Top." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/14202 [11:53:55] Change merged: Jens Ohlig; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14202 [12:16:49] New patchset: Tobias Gritschacher; "extended blocked_user selenium test: * added check for description and aliases * added check for item creation special page" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14298 [12:34:06] New patchset: Tobias Gritschacher; "changed text of edit sitelinks placeholder to "site" and "article". was: bug 37543" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14299 [12:56:54] New review: Jens Ohlig; "Works as advertised, A+++ WOULD BUY AGAIN." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/14297 [12:56:58] Change merged: Jens Ohlig; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14297 [13:11:03] New patchset: Daniel Werner; "Deleting items doesn't throw an error anymore" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14300 [13:14:51] New review: Jens Ohlig; "Works like a charm." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/14298 [13:14:54] Change merged: Jens Ohlig; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14298 [13:16:25] New review: Jens Ohlig; "Easy chocolate." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/14299 [13:16:27] Change merged: Jens Ohlig; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14299 [13:24:07] New review: Jens Ohlig; "OK." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/14300 [13:24:10] Change merged: Jens Ohlig; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14300 [13:59:52] JeroenDeDauw: https://gerrit.wikimedia.org/r/14301 [14:33:36] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14288 [15:12:02] Denny_WMDE: apparently I made the change in the extension in two parts, so no need to split [15:12:16] Denny_WMDE: if you get the one change for core on the client [15:12:27] Denny_WMDE: you just need this change on the extension as well: https://gerrit.wikimedia.org/r/#/c/14083/ [15:18:25] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14291 [15:44:55] New patchset: Tobias Gritschacher; "added selenium test to check label and id in recent changes" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14310 [15:45:26] New patchset: Jeroen De Dauw; "Made lib compat with postgres" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14311 [15:46:21] JeroenDeDauw: stupid question, how do I pick that one change? [15:46:34] git cherrypick 14083 ? :) (guessing wildly) [15:49:07] New patchset: Jeroen De Dauw; "Made client compatible with postgres" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14312 [15:52:55] Change merged: Jens Ohlig; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14310 [16:04:58] New patchset: Daniel Werner; "Adding the 'wb-itempage' class only if the page contains an item, not on empty pages." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14313 [16:23:53] New patchset: Jens Ohlig; "Revert "Remove obsolete script to populate interwikitable (since we now have such stuff populating the sites table)"" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14315 [16:24:15] Change merged: Jens Ohlig; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14315 [17:45:05] New patchset: Jeroen De Dauw; "Made repo compatible with postgres" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14339 [17:47:15] New patchset: Jeroen De Dauw; "Remove alias table patch" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14340 [18:04:59] New patchset: Jeroen De Dauw; "Added OnItemStructuredSave hook" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14343 [18:06:15] New patchset: Jeroen De Dauw; "Kill not needed title arg and field - now in itemContent anyway" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14344 [18:15:08] New patchset: Jeroen De Dauw; "Add in check to see if stuff is already loaded for compat" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14345 [18:29:48] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14344 [18:31:22] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14340 [18:42:23] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14313 [18:47:31] JeroenDeDauw: the postgres stuff looks great [18:54:03] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14343 [19:22:47] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14345 [19:34:36] aude: wheeeeeee [19:35:09] aude: you're probably the only one that can review it, since the other ppl are to lazy to install a postgres wiki [19:44:40] ok [20:41:35] New patchset: Jeroen De Dauw; "Added OnItemDeletionUpdate hook" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14406 [21:46:47] New patchset: Daniel Werner; "Core tests should all run again now." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14420