[07:20:12] New patchset: Tobias Gritschacher; "Special:CreateItem keeps the language now when redirecting to items page after creation - patchset 2: more readable var name and using url encode now. - patchset 3: added selenium test to check the functionality" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14493 [07:23:26] New patchset: Henning Snater; "prevent making the site id editable when instantly editing a just created site link" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14494 [07:42:53] Change merged: Henning Snater; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14493 [07:58:57] New review: Henning Snater; "Merge conflicts, please rebase." [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/14073 [08:00:12] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14494 [08:23:43] hello [08:24:01] so somehow I got Jenkins to test out Wikidata branch and the Wikibase extension. [08:24:11] first successful build log is https://integration.mediawiki.org/ci/job/Ext-Wikibase/356/console [08:38:21] New patchset: Tobias Gritschacher; "Behavior fix in site suggestion for site links" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14683 [08:40:11] TobiasG_WMDE: I got Jenkins to run tests on extensions/Wikibase, still experimental though :/ [08:40:19] TobiasG_WMDE: result for your change is in https://integration.mediawiki.org/ci/job/Ext-Wikibase/357/console [08:44:54] hashar: thank you [08:45:09] does not seem to run the extensions tests though :/ [08:47:19] hashar: seems it uses the master branch of the core but should still use the Wikidata branch of core I think [08:49:02] I need to tweak it a bit more :-] [08:49:07] must have failed something in the ant build script [08:50:26] hashar: would it also be possible to display the verify of the jenkins-bot in the gerrit comments somehow (like it happens in core)? [08:50:58] hashar: thx for working on that, btw.! [08:50:58] definitely, I will enable reporting in Gerrit whenever the build script is fully working [09:05:07] might just have to redo it all ;-D [09:37:15] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14684 [10:11:19] New patchset: Henning Snater; "highlighting sitId autocomplete fallback option" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14761 [10:18:11] New patchset: John Erling Blad; "Changes after review of API" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14762 [10:21:25] New patchset: John Erling Blad; "Changes after review of API" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14762 [10:29:14] Change merged: Henning Snater; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14683 [10:49:38] New patchset: John Erling Blad; "Changes after review of API" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14762 [12:18:33] New review: Jens Ohlig; "Please fix the trailing whitespave errors. Tests not run." [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/14762 [13:45:16] I'm heeereeee.. [13:46:07] Merlissimo: Nice bug report, a whole bunch of strange bugs suddenly made sense [13:47:05] jeblad: i am just rewriting my code to use the wiki id [13:47:41] but returning plain text on format=xml makes my sax parser cry [13:48:46] It made a lot of things break.. [13:49:05] Note the updates to the API, it hpefully goes through review today [13:49:26] jeblad: how can i get a list of all accepted wikiids? [13:49:47] sitematrix [13:50:20] There is a special page but you can also get it from the api [13:51:16] but sitematrix also contains e.g. commonswiki [13:51:41] yes, all are legal siteids [13:52:04] But we only use those that are in group wikipedia [13:53:19] commonswiki is in the wikipedia group on wikimedia config [13:53:55] nice.. [13:54:21] like incaubtor and wikispecies. thats why i am asking, so that i can filter them, for not using at wikidata without hardcoding these three in my code [13:54:22] we use the dbkeythingy.. so not "en" but "enwiki" [13:55:01] Hm, we should probably eksport our identifiers somehow.. [13:55:15] i hope dbkey is always the same as wikiid return by api [13:55:49] siteinfo->general->@wikiid [13:56:14] [13:56:15] on a first look it seems to match [13:56:26] its the dbname [13:56:49] within sitename wikipedia, .. [13:57:42] There is a lot of errors there [13:57:52] i'll check the code creating @wikiid at http://no.wikipedia.org/w/api.php?action=query&meta=siteinfo&siprop=general [13:59:09] We had some problems with faulty site ids, it seems like the whole sitematrix is broken.. [14:00:17] only the db table because it isn't used by wmf [14:00:49] Yeah, but we use it for building our representation of the site matrix [14:01:23] We have a bug report about errors on some of the sites, so something is bjoken.. [14:03:05] New patchset: John Erling Blad; "Changes after review of API" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14762 [14:04:09] jeblad: https://www.mediawiki.org/wiki/Special:Code/MediaWiki/59548 makes it possible that dbname and wikiid are different. sitematrix and siteinfo are both using wfWikiID() [14:05:40] * jeblad drags his feets over to the pesky missing languages buggy thingy... [14:13:27] the update caused the change must be happend around 9 day ago. also return format changed [14:13:53] my bot is searchign for /api/items/q [14:17:45] api help page shows a different format for wbsetitem as you used in the bug report [14:18:17] I'll check it, thought it should be the same.. [14:20:09] links should be sitelinks, label should be labels, description should be descriptions [14:20:53] Note that on the bugzilla I show the request, while on th mw page it is the reply [14:21:02] The request is in the url [14:22:37] New patchset: Henning Snater; "making 'more languages' in STTL extension collapsible" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14769 [14:25:25] jeblad: is Scenario a ok on http://meta.wikimedia.org/wiki/User:MerlIwBot/WikiData [14:39:27] Only wikipedia-sites should have sitelinks [14:41:55] other action show: site: One value: aawiki, aawikibooks, aawiktionary, abwiki, abwiktionary, ... [14:43:05] but the steps for checking and creating a new item are ok ? [14:43:08] Hm? Which action? [14:43:28] Ah, I see.. its the whole siteid-thingy [14:43:59] We will only use those that are usable for interlanguage links from wikipedia [14:44:38] Legal as siteid, but not legal as interlanguage links in wikipedia [14:49:46] Not sure if we should enforce the group thingy.. Could lead to more problems than allowing them.. [14:49:48] no more q123 tags - that a great improvement [14:51:41] Actually, what you place in the url is not important, only that you use a POST.. [14:51:45] * jeblad thinks.. [14:52:52] yeah, and you can turn use of the keys on and of if you must [14:53:01] Nice to get valid xml [14:54:08] my bot is always posting everything except format and action [15:00:32] http://meta.wikimedia.org/w/index.php?title=User%3AMerlIwBot%2FWikiData&diff=3890723&oldid=3890668 [15:00:59] My changes show how it will be. [15:04:13] Merlissimo: In Scenario b you can use an undocumented feature I accidentially described.. [15:04:37] http://www.mediawiki.org/wiki/Extension:Wikibase/API#wbsetitem [15:04:41] Last example [15:04:48] But note that this could change. [15:06:05] any news about https://bugzilla.wikimedia.org/show_bug.cgi?id=37306 ? [15:06:14] Basically you do the same as in scenario A but identifies the item that has connection with the item [15:06:41] But only after the thingy is through review [15:08:36] Should be possible now.. But I guess its only interesting where we already have the sitelink. [15:11:25] New patchset: John Erling Blad; "Changes after review of API" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14762 [15:25:36] jeblad: is sitelinks instead of links already working on wbsetitem? Or after it passed review? [15:35:24] jeblad: if i am adding a alswiki page: Which language code have i to use for the label? (languagecode of alswiki is gsw) [15:38:42] changes to wbsetitem (that is the changes to the page at mediawiki.org) is in the review now [15:39:11] site id and language id can be very different [15:40:10] so is use isolang = gsw [15:41:03] I know notheing about alswiki, but the language code should be for the language used on alswiki if you reuse the title as a label I guess it will be gsw [15:43:21] New patchset: Daniel Werner; "Language stickiness now causes cache fragmentation." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14073 [15:43:41] have you removed item=add because it's default or must not be used? [15:45:17] Items should not be created as secondary effects [15:45:33] There is for now only one item that can create items [15:46:25] Three modules are removed, some parameters are removed and a module have changed name [15:48:07] Concert in tha house! =D [15:50:00] can you update the examples on my subpage if something must be changed in future? [15:50:35] I'm probably going to forget it.. :D [15:50:56] But I'm pretty shure nothing is going to change for a while.. [15:51:38] Open questions is "what is an empty item and what to do with them" and "how to delete an item". [15:51:51] i you see many invalid requests on testrepository it will come to your mind ;-) [15:52:13] ..and directly updating the item through wbsetitem is "undocumented".. ;) [15:53:01] We have a few thousand failing items now.. and trying to open them will make the server hang..=) [15:53:27] adding each wiki page on a single request doubles the number of request and currenlty about half about all my request are send to wikidata [15:53:55] on wikipedia i am requesting 30-60 pages at once [15:54:47] Change merged: Henning Snater; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14073 [16:15:55] New review: Nikerabbit; "Using global $wgParser wouldn't pass code review on core." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14073 [16:51:03] jeblad: i you are using a not existing wikiid on wbsetitem an empty html page is returned (because of my fault on a test i always used the wikidata wikiid). content-type text/html on format=xml [16:51:52] now all my bot instances are using the new format [17:47:05] Creating an empty item if the lookup failed was a feature that is deemed to be a bug.. ;) [17:47:50] It will probably take some time before the test repo is using the new call style [17:49:15] http://wikidata-test-repo.wikimedia.de/wiki/Special:RecentChanges looks strange [17:49:30] i checked that login data is send correctly [17:50:46] and the created item have no sitelinks [17:52:25] response is [17:54:04] can anyone login into wikidata-test-repo? [18:17:02] jeblad: can you login at wikidata-test-repo wiki? [20:27:19] New patchset: Daniel Werner; "STTLanguage makes more sense now when it comes to additional url parameters." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14846 [20:36:14] New review: Daniel Werner; "Looking good, got to run selenium tests though." [mediawiki/extensions/Wikibase] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/14769 [20:57:05] New review: Daniel Werner; "Nice idea, but it doesn't work to navigate with up/down to select an item now! It is stuck with the ..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/14761 [20:57:30] New review: Daniel Werner; "(see last comment)" [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/14761