[03:20:04] New patchset: Jeroen De Dauw; "Moved a bunch of stuff to Entity and EntityObject since its not item specific" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/15681 [12:27:08] New patchset: John Erling Blad; "Autocomments and summaries for changes through the api." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/15675 [12:51:28] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/15681 [14:33:29] k [16:15:18] New review: Daniel Werner; "You implemented the enable and disable stuff everywhere, also the getElementsState() which looks lik..." [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/15603 [16:53:49] New patchset: John Erling Blad; "Additions to get the link titles on RecentChanges and similar to use fallback languages" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/15684 [17:01:06] New patchset: Jeroen De Dauw; "Moved aliases stuff to Entity together with some methods I forgot in move of label and description yesterday" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/15685 [17:04:21] New review: John Erling Blad; "This was commited on master.. Didn't see in time that it was not on a separate branch." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/15684 [17:23:56] New review: John Erling Blad; "Surrehue!" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/15685 [17:23:58] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/15685 [17:26:42] New review: Jeroen De Dauw; "Please use proper full English sentences for comments, describing what the code does in a way unders..." [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/15684 [17:53:14] New patchset: Jeroen De Dauw; "move config to example file as it should be in ls but like this we keep an esy way to share the stuffs" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/15686 [18:07:37] New patchset: Jeroen De Dauw; "move config to example file as it should be in ls but like this we keep an esy way to share the stuffs" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/15686 [19:20:07] New review: Nikerabbit; "Have you tried to use rebase instead of merge? git fetch origin; git rebase -i origin/master?" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/15675 [19:21:50] New patchset: John Erling Blad; "Additions to get the link titles on RecentChanges and similar to use fallback languages" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/15684 [19:40:32] New review: John Erling Blad; "No I have not experimented with alternate methods to get around the problems with the i18n-file. Mer..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/15675 [19:50:59] New review: John Erling Blad; "Use of undefined constants WB_NS_DATA and WB_NS_DATA_TALK" [mediawiki/extensions/Wikibase] (master); V: -1 C: 0; - https://gerrit.wikimedia.org/r/15686 [19:52:52] New review: Jeroen De Dauw; "Getting errors during tests, but probably unrelated" [mediawiki/extensions/Wikibase] (master); V: 0 C: 2; - https://gerrit.wikimedia.org/r/15684 [19:55:13] New review: Jeroen De Dauw; "... did you include the file?" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/15686 [20:05:23] New review: Jeroen De Dauw; "Ok, verified" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/15684 [20:05:25] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/15684 [20:09:24] New review: John Erling Blad; "Nothing included or excluded, only the patchset and the usual run with --group Wikibase. A whole lot..." [mediawiki/extensions/Wikibase] (master); V: -1 C: 0; - https://gerrit.wikimedia.org/r/15686 [20:17:00] New review: Jeroen De Dauw; "See my email to the internal list for more info." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/15686 [20:31:23] hello [20:33:02] New review: John Erling Blad; "Works if I do a" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/15686 [20:48:18] New review: Jeroen De Dauw; "I'm writing big follow up commit - will make another one with updated INSTALL info." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/15686 [20:52:36] New patchset: John Erling Blad; "Fix for a method that is used with a previous name." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/15693 [20:55:05] hi iscalunga [20:58:17] Bungyjumping in and out of the net.. [20:58:55] If someone have time, I would be glad if this fix is through review before I go to bed! https://gerrit.wikimedia.org/r/#/c/15693 [21:08:45] New review: John Erling Blad; "Passed with changes to LocalSettings.php." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/15686 [21:08:47] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/15686 [21:11:23] Change abandoned: John Erling Blad; "I abandon this and fixes the original one. It was a miss, I thought it already was merged. ;)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/15693 [21:15:10] Change restored: John Erling Blad; "Darn.. Should not do this now..." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/15693 [21:15:17] Lydia_WMDE: ping [21:15:32] JeroenDeDauw: pong [21:16:58] Lydia_WMDE: plans for getting a food yet? [21:17:22] JeroenDeDauw: i'll have food with my friends tonight [21:17:39] and spend the rest of the night with them then [21:17:51] ok [21:29:09] New review: John Erling Blad; "Fix for fatal bug, should not do this......" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/15693 [21:29:10] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/15693 [21:40:26] It's a jeblad [21:40:45] "Failed asserting that true is false." [21:40:52] jeblad: that's your fault - somehow [21:46:35] New patchset: Jeroen De Dauw; "Added base for Property and Query objects" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/15694 [22:25:20] JeroenDeDauw: boink? [22:26:51] Ouch... I don't think my head is in the mood for this review now.. [22:55:56] New review: John Erling Blad; "There are some comments, but nothing thats blocks.. It was green light after a test run." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/15694 [22:55:57] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/15694