[07:48:30] <gerrit-wm>	 Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/16408
[08:15:37] <gerrit-wm>	 New patchset: Tobias Gritschacher; "fix: added additional normalization of autoExpand width" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/16470
[08:27:34] <gerrit-wm>	 Change merged: Henning Snater; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/16470
[08:27:49] <gerrit-wm>	 New patchset: John Erling Blad; "Fix for missing whitespace squashing." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/16421
[08:31:27] <gerrit-wm>	 Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/16421
[08:42:59] <gerrit-wm>	 New patchset: Tobias Gritschacher; "fix: replaced constant with variable" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/16473
[08:43:12] <gerrit-wm>	 Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/16473
[08:46:23] <gerrit-wm>	 Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/16409
[08:53:08] <gerrit-wm>	 Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/16434
[08:54:11] <gerrit-wm>	 New review: Daniel Kinzler; "some nitpicking about naming and documentation. i havn't really looked into the code yet." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/16409
[09:08:07] <gerrit-wm>	 Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/16436
[09:21:26] <JeroenDeDauw>	 Daniel_WMDE: why did you comment out ItemDeletionUpdate?!
[09:25:28] <gerrit-wm>	 New review: Jeroen De Dauw; "This seems to be a subset of changes in https://gerrit.wikimedia.org/r/#/c/16454" [mediawiki/extensions/Wikibase] (master); V: 0 C: -2;  - https://gerrit.wikimedia.org/r/16450
[09:26:09] <gerrit-wm>	 Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/16439
[09:29:34] <gerrit-wm>	 New review: Jeroen De Dauw; "Wikibase\Test\ItemMoveTest::testMovePrevention" [mediawiki/extensions/Wikibase] (master); V: 0 C: -2;  - https://gerrit.wikimedia.org/r/16454
[09:29:58] * JeroenDeDauw  throws a cookie at DanielK

[09:30:00] <JeroenDeDauw>	 Daniel_WMDE: 
[09:30:18] <JeroenDeDauw>	 Daniel_WMDE: did you run the tests? :p
[09:33:23] <gerrit-wm>	 New patchset: Jeroen De Dauw; "getParserOutput moved to Content hierarchy." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/16454
[09:35:12] <gerrit-wm>	 New review: Jeroen De Dauw; "Failing test, fixed by https://gerrit.wikimedia.org/r/#/c/16476/" [mediawiki/extensions/Wikibase] (master); V: -1 C: 2;  - https://gerrit.wikimedia.org/r/16454
[09:37:01] <gerrit-wm>	 Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/16454
[09:37:16] <gerrit-wm>	 Change abandoned: Jeroen De Dauw; "Already in https://gerrit.wikimedia.org/r/#/c/16454" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/16450
[10:03:03] <gerrit-wm>	 New patchset: John Erling Blad; "Check current user language before fallback languages" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/16480
[10:20:49] <Abraham_WMDE>	 Daniel_WMDE: available?
[10:20:52] <gerrit-wm>	 New review: Daniel Kinzler; "Gah! Guys!" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/16257
[10:21:20] <Daniel_WMDE>	 Abraham_WMDE: yea. got something for you too.
[10:22:22] <Abraham_WMDE>	 Daniel_WMDE: pm
[10:24:46] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Revert "Added user language specific title for ViewItemAction"" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/16481
[10:24:55] <JeroenDeDauw>	 Daniel_WMDE: https://gerrit.wikimedia.org/r/#/c/16481/
[10:33:39] <Daniel_WMDE>	 JeroenDeDauw: yea. probably better that way. was going to do a quick fix, but reverting is probably the right choice here.
[10:33:42] <Daniel_WMDE>	 thanks
[11:25:27] <gerrit-wm>	 Change abandoned: Daniel Kinzler; "merge/rebase conflicts. will create a new revert patch" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/16481
[11:25:47] <gerrit-wm>	 New patchset: Daniel Kinzler; "Revert "Added user language specific title for ViewItemAction"" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/16483
[11:26:30] <Daniel_WMDE>	 gggaaahhhh!!!!
[11:26:52] <Daniel_WMDE>	 JeroenDeDauw: i'm extremly confused now. the revert breaks the codebase in a very unexpected way:
[11:27:00] <Daniel_WMDE>	 Fatal error: Class Wikibase\ItemContent contains 1 abstract method and must therefore be declared abstract
[11:27:04] <Daniel_WMDE>	 master doesn't have this error
[11:27:12] <Daniel_WMDE>	 the revert doesn't touch ItemContent
[11:27:18] <Daniel_WMDE>	 wtf is going on? I don't understant.
[11:27:21] <Daniel_WMDE>	 got an idea?
[11:27:39] <Daniel_WMDE>	 i thought the revert had just grown stale, so i made a new one
[11:27:41] <Daniel_WMDE>	 same problem
[11:30:03] <Daniel_WMDE>	 89bae4548d fixed that error. why does reverting john's patch also revert that? and why doesn't gerrit show this?
[11:32:49] <gerrit-wm>	 New review: Jeroen De Dauw; "Does not merge" [mediawiki/extensions/Wikibase] (master); V: -1 C: 0;  - https://gerrit.wikimedia.org/r/16483
[11:33:17] <gerrit-wm>	 Change abandoned: Daniel Kinzler; "can't get this to apply cleanly. will submit a hotfix instead." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/16483
[11:35:01] <JeroenDeDauw>	 Daniel_WMDE: maybe the revert contains changes needing the latest ones on Wikidata branch that you don't have or something?
[11:35:37] <Daniel_WMDE>	 nope.
[11:35:53] <Daniel_WMDE>	 it fails because it doesn't have the changes that are required by the latest version of the wikidata branch
[11:35:56] <Daniel_WMDE>	 but it should...
[11:35:58] <Daniel_WMDE>	 oh, whatever
[11:37:13] <gerrit-wm>	 Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/16480
[11:39:39] <gerrit-wm>	 New patchset: Daniel Kinzler; "fix: use foreach in lookupMultilangText." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/16484
[11:39:58] <Daniel_WMDE>	 JeroenDeDauw: would you? ---^
[11:40:33] <JeroenDeDauw>	 Daniel_WMDE: well, same issue basically :p
[11:41:02] <Daniel_WMDE>	 hm?
[11:41:12] <gerrit-wm>	 New patchset: Tobias Gritschacher; "fixed selenium test which broke after language fallback for labels got merged" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/16485
[11:41:43] <JeroenDeDauw>	 Daniel_WMDE: hmm, how the fuck did I manage to +1 this? o_O
[11:41:43] <JeroenDeDauw>	  while ( list( $code, $text ) = each( $texts ) ) {
[11:41:48] <JeroenDeDauw>	 Arrr
[11:41:55] <JeroenDeDauw>	 That's so... bad ...
[11:41:57] <Daniel_WMDE>	 uhu
[11:42:02] <Daniel_WMDE>	 and no reset
[11:42:08] <gerrit-wm>	 Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/16485
[11:42:28] <JeroenDeDauw>	 Why the fuck would you go use while, list and each instead of a foreach? >_>
[11:43:03] <Daniel_WMDE>	 JeroenDeDauw: because you don't know the => version of the foreach syntax? could be. it's not a big problem as long as it's done right. anyway.
[11:43:06] <Daniel_WMDE>	 let's fix it.
[11:43:06] <JeroenDeDauw>	 FUUUU gerrit
[11:43:21] <JeroenDeDauw>	 Daniel_WMDE: conflict
[11:43:29] <Daniel_WMDE>	 o_O
[11:43:43] <gerrit-wm>	 New review: Nikerabbit; "New code should avoid using globals like $wgUser, $wgLang, $wgOut, $wgRequest." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/16480
[11:43:43] <Daniel_WMDE>	 somethign was merged into util in the two minutes it took me to make this patch?
[11:43:45] <Daniel_WMDE>	 the fuck?
[11:44:09] <Daniel_WMDE>	 JeroenDeDauw: rebasiong
[11:44:54] <Daniel_WMDE>	 JeroenDeDauw: ah. ok. somone inserted the reset() stuff.
[11:45:00] <Daniel_WMDE>	 fair enough. by fix is obsolete then.
[11:45:20] <JeroenDeDauw>	 Daniel_WMDE: please commit with message "Take off every 'while'. For great sanity!"
[11:45:28] <JeroenDeDauw>	 Jens_WMDE: will like that
[11:45:50] <Jens_WMDE>	 Fotografiona: ich hab gerade die logs i will.
[11:45:55] <Jens_WMDE>	 hä?
[11:46:08] <JeroenDeDauw>	 wot?
[11:46:24] <Jens_WMDE>	 hehe, pastebuffer-fail.
[11:46:31] <Jens_WMDE>	 anyway, i will like it.
[11:46:37] <JeroenDeDauw>	 Daniel_WMDE: what? someone inserted it? How? I don't see it on gerrit
[11:46:48] <JeroenDeDauw>	 If someone pushed it directly I'm going to revoke rights
[11:48:24] <JeroenDeDauw>	 Daniel_WMDE: yeah, here https://gerrit.wikimedia.org/r/#/c/16480/
[11:48:40] <gerrit-wm>	 New patchset: Daniel Kinzler; "fix: use foreach in lookupMultilangText." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/16484
[11:49:02] <JeroenDeDauw>	 Pfft, and it's adding globals
[11:49:23] <gerrit-wm>	 Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/16484
[11:49:33] <Daniel_WMDE>	 JeroenDeDauw: Idcb32a53b2e9b4fe0e8927e39340b6e41888da99
[11:50:16] <Daniel_WMDE>	 yay.
[11:50:22] <Daniel_WMDE>	 mixes the fix with new functionality.
[11:50:25] <Daniel_WMDE>	 >_<
[11:51:01] <Daniel_WMDE>	 JeroenDeDauw: i rebased my fix, but it's not really needed any more. merge it or abandon it, i don't care.
[11:51:04] * Daniel_WMDE  needs a break

[11:51:06] <gerrit-wm>	 New patchset: Tobias Gritschacher; "fix: broken selenium sttl test" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/16486
[11:51:15] <gerrit-wm>	 Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/16486
[12:31:11] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Added view and edit actions for properties and queries, plus did a refactor of the item actions (now mostly entity actions)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/16492
[12:48:23] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Added fixmes, some cleanup and added docs" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/16494
[13:55:19] <Lydia_WMDE>	 Daniel_WMDE: ready for meeting?
[13:55:26] <Lydia_WMDE>	 should we use my laptop and hangout?
[14:02:36] <Daniel_WMDE>	 Lydia_WMDE: sure, just invite me
[14:02:49] <Lydia_WMDE>	 Daniel_WMDE: ok - give me 2 mins
[14:05:10] <Daniel_WMDE>	 Lydia_WMDE: got some links for me? we had a list of volunteers or something...
[15:04:10] <JeroenDeDauw>	 Daniel_WMDE: german support for SMW seriously should go to the list - I think it's probably the best language to ask something in besides EN
[15:04:28] <JeroenDeDauw>	 Daniel_WMDE: got great community members that speak DE and this Markus guy also knows it
[16:54:41] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Adding more GenericArrayObject tests" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/16520
[20:03:19] <gerrit-wm>	 New patchset: John Erling Blad; "Language name in help messages on Special:CreateItem shown as "null"" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/16545