[08:37:19] <gerrit-wm>	 New review: Daniel Kinzler; "Looking good, but please verify that the bot flag is actually set when an edit is performed by a bot..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/16740
[08:40:10] <gerrit-wm>	 New review: Daniel Kinzler; "Looks good, but please add a test case." [mediawiki/extensions/Wikibase] (master); V: 0 C: -1;  - https://gerrit.wikimedia.org/r/16282
[08:44:52] <gerrit-wm>	 New patchset: John Erling Blad; "Some fixes in importInterlang.php" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/16734
[08:55:31] <gerrit-wm>	 New review: Daniel Kinzler; "Control and behavior of fallbacks need more discussion." [mediawiki/extensions/Wikibase] (master); V: 0 C: -1;  - https://gerrit.wikimedia.org/r/15868
[09:02:40] <gerrit-wm>	 New review: John Erling Blad; "Still fails... ;/" [mediawiki/extensions/Wikibase] (master); V: 0 C: -1;  - https://gerrit.wikimedia.org/r/16734
[09:07:19] <gerrit-wm>	 New patchset: John Erling Blad; "Some fixes in importInterlang.php" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/16734
[09:13:08] <gerrit-wm>	 New review: John Erling Blad; "This works on my machine when it runs in debug mode. The script don't use tokens so it will fail wit..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/16734
[09:37:23] <Lydia_WMDE>	 heya :) anyone here who knows a bit more than me about svg and can help me clean up the markup of the wikidata logo file?
[09:51:16] <Merlissimo>	 Lydia_WMDE: ping niabot on #wikipedia-de
[09:51:58] <Lydia_WMDE>	 Merlissimo: thx!
[10:05:48] <Lydia_WMDE>	 Daniel_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=37982 <- is this one of our bugs? if so can you reassign it to the right component please? (just been going through the wikidata bugs)
[10:10:22] <Daniel_WMDE>	 Lydia_WMDE: done.
[10:10:54] <Daniel_WMDE>	 Lydia_WMDE: can you ask for the Wikidata component to be removed? It's quite useless and misleading.
[10:11:00] <Daniel_WMDE>	 or we could start using it for our stuff.
[10:11:06] <Lydia_WMDE>	 Daniel_WMDE: i'll try, yeah
[10:11:13] <Lydia_WMDE>	 nah let's try to get it removed
[10:11:22] <Daniel_WMDE>	 you can file requests about bugzilla on bugzilla :)(
[10:11:28] <Lydia_WMDE>	 :P
[10:12:41] <Daniel_WMDE>	 Lydia_WMDE: abraham should now also be able to re-assign bugs, change status, etc
[10:14:11] <Lydia_WMDE>	 k
[10:14:32] <Merlissimo>	 Daniel_WMDE: what was the reason to make bot flag implizit? https://gerrit.wikimedia.org/r/#/c/16740/  bot-right=_can_ mark edit as bot. on wikipedia we have many bots not marking every edit as bot because of different reasons
[10:44:21] <Daniel_WMDE>	 Merlissimo: hm... really? How? I was unable to find the respective flags in the API, and from what I see in the code, you can programatically force, but not supress, the bot flag. 
[10:44:32] <Daniel_WMDE>	 Merlissimo: maybe I'm confused abotu how this works.
[10:45:46] <Merlissimo>	 on normals edit (action=edit) user having the bot right can use &bot=1. i they don't to that the edit is not marked as bot edit
[10:46:10] <gerrit-wm>	 New review: Daniel Kinzler; "NEEDS INVESTIGATION." [mediawiki/extensions/Wikibase] (master); V: 0 C: -1;  - https://gerrit.wikimedia.org/r/16740
[10:46:18] <Merlissimo>	 same with rollback and other modules, so i think wikidata should use the same behaviour
[10:47:52] <Daniel_WMDE>	 Merlissimo: I have put that patch on hold, pending investigation. I have found flags like this for action=edit and action=rollback.
[10:49:22] <gerrit-wm>	 New review: Daniel Kinzler; "...apparently, action=edit and action=rollback in the core API have an option to mark edits as bot e..." [mediawiki/extensions/Wikibase] (master); V: 0 C: -1;  - https://gerrit.wikimedia.org/r/16740
[10:51:12] <Merlissimo>	 bot=1 can be used for action=edit for all users having bot rifht and for rollback all people having ether bot right or markbotedits right (=admin group)
[10:54:53] <gerrit-wm>	 New review: John Erling Blad; "ApiEditPage.php uses at line 527" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/16740
[10:55:05] <Daniel_WMDE>	 Merlissimo: markbotedits doesn't work for edits? that's... confusing.
[10:55:33] <Daniel_WMDE>	 actually, it should really only depend on the markbotedits right, no? and bots should just have that permission
[10:55:34] <Merlissimo>	 that's only for rollback
[10:55:35] <Daniel_WMDE>	 oh, well.
[10:55:44] <Daniel_WMDE>	 *why* is it only for rollback?
[10:56:00] <Merlissimo>	 because the rollback extension adds its
[10:56:02] <Daniel_WMDE>	 seems inconsistent and confusing
[10:56:19] <Daniel_WMDE>	 why is there a rollback extension? shouldn't this be core?...
[10:56:20] <Merlissimo>	 perhaps rollback extension could have choosen a better nameing
[10:56:21] <Daniel_WMDE>	 bah :)
[10:56:38] <Daniel_WMDE>	 no, perhaps core should do it in a smarter way :)
[10:56:53] <Daniel_WMDE>	 but this is irrelevant to us for now. unless we want to use the same permission. which actually seems like a good idea...
[10:57:25] <Merlissimo>	 on action=rollback&bot=1 for markbotedit also the previous edit is marked as bot edit
[10:57:52] <Daniel_WMDE>	 o_O
[10:57:59] <Daniel_WMDE>	 thaŧ sounds extremly strange
[10:58:02] <Daniel_WMDE>	 anyway, time for lunch
[10:59:33] <Merlissimo>	 it is for vandalism on user talk pages. if you revert it with bot and then both edits are marked as bot no "new edit on talk page" notice is shown for the affected user anymore
[11:01:04] <Merlissimo>	 but i think ony very few admins know about this feature
[12:19:39] <gerrit-wm>	 New review: Daniel Kinzler; "yea. please add documentation for this, though. seems to be missing at the moment." [mediawiki/extensions/Wikibase] (master); V: 0 C: -1;  - https://gerrit.wikimedia.org/r/16740
[13:06:39] <gerrit-wm>	 New review: Denny Vrandecic; "I am not sure what the class hierarchy under Type will be useful for / how it is different from the ..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/16829
[13:18:20] <Abraham_WMDE1>	 Daniel_WMDE: wave
[13:20:12] <gerrit-wm>	 New review: Daniel Kinzler; "@Denny: there could be a single Value class, containing an array structure, with all the knowledge a..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/16829
[13:32:18] <gerrit-wm>	 New review: Denny Vrandecic; "@Daniel: "there could be a single Value class, containing an array structure, with all the knowledge..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/16829
[13:44:04] <gerrit-wm>	 New review: Daniel Kinzler; "@Denny: Type instances do type-specific things that do not require a concrete value - for instance, ..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/16829
[13:52:52] <gerrit-wm>	 New patchset: John Erling Blad; "Flytte en testfil slik at den ikke blir feiltolket som tester for en enkelt klasse" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/16965
[13:54:09] <gerrit-wm>	 New review: John Erling Blad; "To tired, trying an English summary.. :D" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/16965
[13:55:45] <gerrit-wm>	 New patchset: John Erling Blad; "Move a general testfile so its not misinterpreted as a specific test for a class." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/16965
[14:33:11] <gerrit-wm>	 New patchset: John Erling Blad; "Was shoot down the explisit bot flag, but we will keep it." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/16740
[14:35:19] <gerrit-wm>	 New patchset: John Erling Blad; "Was shoot down the explisit bot flag, but we will keep it." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/16740
[14:36:47] <gerrit-wm>	 New review: John Erling Blad; "Only added some doc in the comments that points to similar code in ApiEditPage." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/16740
[19:07:54] <gerrit-wm>	 Change merged: Daniel Kinzler; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/16740