[08:10:07] hello there :-) [08:10:21] so I am polishing up the Wikibase extension testing [08:10:40] and need to inject some settings, going to use the file repo/ExampleSettings.php [08:36:42] New review: Aude; "I think it's Dependent (e.g. dependency) and not Dependant. :)" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/16965 [08:37:31] hi hashar [08:37:41] thanks for helping with the testing :) [08:38:10] it's quiet here..... quiet in the office [08:38:49] hashar: just drop an short status email if you have any news. thx for you support [08:39:43] yeah yeah [08:39:54] hopefully will have finished it by the end of the day [08:41:24] thanks for your support :) [08:45:02] :) [08:46:33] grmblbl still have ton of failing tests https://integration.mediawiki.org/ci/job/MediaWiki-Tests-Extensions/16/#showFailuresLink [08:46:40] https://integration.mediawiki.org/ci/job/MediaWiki-Tests-Extensions/16/testReport/ [08:47:08] related console output https://integration.mediawiki.org/ci/job/MediaWiki-Tests-Extensions/16/console [08:56:16] hmmm.... [09:06:09] hashar: starnge [09:06:24] is the Diff stuff of Jeroen updated? [09:08:00] ahh you are correct [09:08:12] that is the second part of my integration today [09:08:24] the job only trigger on Wikibase change and might not be updating the other extensions :/ [09:09:33] hmm [09:09:36] Diff looks up to date [09:10:33] I will actually have a look at the tests :) [09:13:04] thx [09:17:09] 09:10:38 [exec] Error: 1 near "TRUNCATE": syntax error [09:17:10] ahhh [09:17:18] that is because SQLite does not have TRUNCATE iirc [09:26:45] New patchset: Hashar; "replace query(TRUNCATE ..) by delete( '*' )" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/17053 [09:27:00] the super obvious patch :) [09:28:57] still have to prevent running the extension tests several time [09:47:06] aude: aren't you working on OSM integration? I got an OSM volunteer in my city who was wondering where to find information about that project :) Do you have any link to share ? :) [09:49:41] hashar: we need to do a better job documenting what everyone is doing with osm stuff [09:50:11] it's me, kolossos, apmon, dschwen and other folks doing various things [09:50:34] whaou 4 peoples!!! [09:51:12] 3 of us met at wikimania and moving things along more now [09:51:26] * aude has more spare time too :) [09:51:34] aude: I guess dropping a few paragraphs on http://www.mediawiki.org/wiki/OSM or similar would be fine :) [09:51:40] sure [09:51:54] WMF engineering has some templates to ease the creation of a page ( ex: http://www.mediawiki.org/wiki/Beta_cluster ) [09:52:03] i should learn from wikidata on documenting stuff and status updates [09:52:07] thanks :) [09:52:15] we even have a gadget to easily fill in status update. I am sure Guillaume Paumier could help there [09:52:19] nice [09:52:31] we get stuff like : http://www.mediawiki.org/wiki/Beta_cluster/status [09:52:32] * aude spent the weekend fighting with labs and ldap [09:52:36] hehe [09:52:45] it's working now :) [09:52:52] congratulations! [09:53:18] and of course, osm itself is in limbo with the license change and redacting data :( [09:53:30] we're figuring out the best way forward [09:53:55] like we might have to show "old" data for australia, until it gets remapped enough [09:55:51] australia -- terra incognita :D [09:56:26] heh [10:02:51] moin Jens_WMDE! [10:07:34] Daniel_WMDE_! [10:07:36] Daniel_WMDE_: is this a wikidata bug: revision timestamp order does not corresponsing with revision id order [10:08:13] Merlissimo: very unlikely. [10:08:15] you can see examples on http://wikidata-test-repo.wikimedia.de/w/index.php?title=Special:Contributions/MerlIwBot&offset=20120731100252&limit=100&target=MerlIwBot&uselang=en on modifications where last changes is not marked with (Top) [10:08:23] Daniel_WMDE_: Abraham_WMDE told me you wanted me to commit my work in progress. so i did. branch "undo_items" [10:08:28] Merlissimo: it'S not a bug btw. there's absolutely no guarantee about revision id order. [10:08:32] e.g. Q45019 or Q45760 ‎ [10:08:39] Merlissimo: think for instance about imported revisions. old timestamps, new revision ids. [10:09:18] i am talking about normal contribs by wbsetitem [10:10:00] Merlissimo: sorry, i'm very confused now. what precisely do you consider a bug? [10:11:17] Merlissimo: there are multiple edits in the same second. these may be shown in *any* order in the UI, i'm afraid. revision id may be used as an aid to define the order of edits in a single second. but I don't think mediawiki does this everywhere. [10:11:23] if would think that the last change of an item in times creates the highest revision id on normal edits (no import) [10:11:24] i guess it should. but that's a core issue [10:11:57] Merlissimo: yes, it *usually* should, but there's no guarantee. what makes you think it doesn't? and why is it a problem? [10:12:31] are revisions shown in the wrong order on the history page? [10:13:08] it a but confusing if you look at the contribs of a user that the last but one edit creates to last revision [10:14:14] Merlissimo: yes. mediawiki orders revisions by timestamp. timestamp resolution is one second. sucks. [10:14:19] but that's a core issue. [10:14:22] nothing we can do about it. [10:14:55] i'd suggest to order by timestamp AND THEN by id. that should *usually* do the right thing. [10:15:47] Merlissimo: i can't find any confusing-looking example. can you point me to one? [10:15:49] 2012-07-31T09:55:48 (diff | hist) . . (+32)‎ . . Data:Q45760 ‎ [10:15:49] 2012-07-31T09:55:48 (diff | hist) . . (+31)‎ . . Data:Q45760 ‎ (top) [10:15:49] 2012-07-31T09:55:47 (diff | hist) . . (+37)‎ . . Data:Q45760 ‎ [10:16:03] where? [10:16:03] on http://wikidata-test-repo.wikimedia.de/w/index.php?title=Special:Contributions/MerlIwBot&offset=20120731100252&limit=100&target=MerlIwBot&uselang=en [10:16:52] Merlissimo: the revision ids are in the correct order, the (top) one has the highest id. [10:16:58] or 2012-07-31T10:00:28 (diff | hist) . . (+45)‎ . . Data:Q45019 ‎ [10:16:59] 2012-07-31T10:00:28 (diff | hist) . . (+69)‎ . . Data:Q45019 ‎ (top) [10:17:00] the id is just not used for sorting on that page [10:17:08] it's a core bug. [10:17:12] file it :) [10:18:32] note however that sorting by id is a *heuristic* for solving the 1-second-granularity problem. it's not guranteed to be correct. it's just better than what we have now. [10:20:26] Daniel_WMDE_ /Jens_WMDE: how much space is left on test repository? last time is was filled after about 110000 items [10:21:01] Merlissimo: that'S way more than the "few thousand" Denny_WMDE said would be ok. [10:21:12] i'd suggest to just stop after 50000 or so. [10:21:14] Merlissimo: should be okay now, several TB. [10:21:25] Jens_WMDE: no. [10:21:40] Daniel_WMDE_: there are already about 71000 [10:21:51] Jens_WMDE: if the indexes for some table grows too large for ram, the wiki slows to a crawl [10:21:57] raw disk space is not the limiting factor [10:21:59] RAM is. [10:22:10] Merlissimo: so stop creating new ones. [10:22:24] Daniel_WMDE_: huwiki will possible be the first test wiki? [10:22:31] looks like it [10:22:43] if so i could create only new item if they contain an huwiki sitelink [10:23:20] Jens_WMDE: i don't have a good guess at how large our indexes are now, which indexes are used how often, and how they correlate to the number of items. but it's probably the must important bottle neck [10:23:21] that would slow doen the bot and we possible have one wiki complete in some times [10:23:32] New patchset: Daniel Werner; "Moved 'StickToThatLanguage' extension into https://gerrit.wikimedia.org/r/p/mediawiki/extensions/StickToThatLanguage.git repository" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/17054 [10:23:37] Jens_WMDE: my guess is that the table holding the index for sitelinks is the one we fill fastest at the moment [10:23:56] Merlissimo: what do you mean? [10:24:35] Jens_WMDE: I *guess* this was the reason that the testwiki was unusable during wikimania. could have been something else, but still [10:24:36] it would be interesting to test database performance stuff, but not sure labs is quite setup for that [10:24:47] Jens_WMDE: oh, btw: to we have APC active on our test wiki? [10:25:01] instead of stopping my bot complete i could create new item only if they contain an huwiki sitelink, so that in some week it contains all huwiki articles if db isn'T delete before [10:25:03] Daniel_WMDE_: not yet [10:25:22] Daniel_WMDE_: thanks for the reminder. [10:25:24] Abraham_WMDE: installing APC should be a matter of 5 minutes. ok, 50 with puppet. [10:25:37] will do that, then. [10:26:06] Jens_WMDE: before you dive into that, please push the undo stuff to gerrit so i can look at it. makr it as [DO NOT MERGE] if it's not ready [10:27:01] Daniel_WMDE_: 12:08 < Jens_WMDE> Daniel_WMDE_: Abraham_WMDE told me you wanted me to commit my work in progress. so i did. branch "undo_items" [10:27:27] Merlissimo: ah, i missed your comment regarding "only create items if there'S a huwiki link". that's actually a pretty good idea, do that please! [10:27:43] Jens_WMDE: oh, it's already there! great, thanks [10:27:50] Daniel_WMDE_: :3 [10:28:10] i have another appointment this afternoon, will look at it in the evening probably [10:28:16] or on the train tomorrow [10:28:27] Daniel_WMDE_: sounds great. thank you! [10:28:50] Daniel_WMDE_: if the appointment is a another trip to the doctor: stay strong! [10:29:07] New review: Daniel Werner; "https://gerrit.wikimedia.org/r/#/c/17056/" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/17054 [10:29:07] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/17054 [10:29:13] Daniel_WMDE_: ok, will me active in some hours when by bot restarts [10:29:31] Jens_WMDE: Standesamt. But I'll stay strong ;) [10:29:48] Jens_WMDE: err, I don't see your thingy. can you add me as a reviewer, so it shows up in my queue? [10:30:14] Daniel_WMDE_: ah... it's not pushed to the master branch [10:30:35] Daniel_WMDE_: check out the "undo_item" branch [10:31:10] or do you prefer to have it in gerrit although it's not done? [10:31:53] Jens_WMDE: yes, marked in the commit message with [DO NOT MERGE]. we do that all the time [10:32:19] Jens_WMDE: it'S easier to handle this way, although i admit that your way is cleaner and closer to The True Way Of The Git. [10:34:10] found your branch though, i can take it from there [10:34:17] New patchset: Jens Ohlig; "Undo for items [DO NOT MERGE]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/17057 [10:35:24] Daniel_WMDE_: Noooooooooooooooooooooooooooo! [10:35:36] Daniel_WMDE_: Just when I was done :D [10:35:41] :) [10:35:42] thanks [10:35:48] it's still easer for me this way. [10:36:23] good good [10:36:29] deleted the branch. [10:47:49] Daniel_WMDE_: APC: http://wikidata-test-repo.wikimedia.de/wiki/Special:APC?uselang=en [10:50:47] Jens_WMDE: ha, wusste garnicht, dass es da 'ne extension zu gibt, cool :) [10:51:05] guck mal die hit rate an... schön :) [10:53:05] Jens_WMDE, Abraham_WMDE: mehr zeug: https://www.mediawiki.org/wiki/Manual:Performance_tuning [10:53:58] so, ich bin jetzt erstmal wieder weg. [10:54:34] Daniel_WMDE_: thx, links habe ich intern schon abgelegt ;-) [11:12:41] New review: Jens Ohlig; "Works like a charme for me locally." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/16734 [11:12:41] Change merged: Jens Ohlig; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/16734 [11:41:47] Change on 12mediawiki a page Extension:Wikibase was modified, changed by Katie Filbert (WMDE) link https://www.mediawiki.org/w/index.php?diff=567205 edit summary: download links [11:42:06] Change on 12mediawiki a page Extension:Wikibase Client was modified, changed by Katie Filbert (WMDE) link https://www.mediawiki.org/w/index.php?diff=567207 edit summary: download links [11:42:18] Change on 12mediawiki a page Extension:WikibaseLib was modified, changed by Katie Filbert (WMDE) link https://www.mediawiki.org/w/index.php?diff=567209 edit summary: download links [14:38:29] New review: Jeroen De Dauw; "Awesome - I was wondering how to properly do this :)" [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/17053 [14:39:43] Jens_WMDE: fixed? [14:56:40] * JeroenDeDauw throws an almost-empty bottle of club-mate at Jens_WMDE [14:57:08] JeroenDeDauw: nope [14:57:18] JeroenDeDauw: no change. [15:39:57] New patchset: Daniel Kinzler; "bug 38569: make sitelink URLs optional in API" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/17074 [15:48:24] Abraham_WMDE, Lydia_WMDE: http://en.wikipedia.org/wiki/Honeywell_316#Kitchen_Computer [16:34:33] aude: you want to take care of the stuff here: https://gerrit.wikimedia.org/r/#/c/14295/ [16:35:37] sure i can work on that [16:36:06] * aude thinks postgresql support is required for core changes like this one [17:02:28] aude: why u no make all of the extensions support postgres? :p [18:28:38] JeroenDeDauw: they should! at least the ones deployed on WMF [18:28:48] someday.... [18:29:24] Why the ones deployed on WMF? [18:29:31] It's not like WMF needs postgres support [18:47:26] Reedy: those should be upheld to the highest standards [18:47:34] * aude uses postgresql sometimes [19:44:36] JeroenDeDauw: http://wikidata-test-repo.wikimedia.de [19:48:37] New patchset: Hashar; "replace query(TRUNCATE ..) by delete( '*' )" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/17053 [19:49:38] New review: Hashar; "Fixed the wrong positioning in lib/includes/Utils.php" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/17053 [19:54:38] New review: Jeroen De Dauw; "Yeah - you'd think I'd just allow passing in an empty array to do this, but no, you have to pass a s..." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/17053 [19:54:38] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/17053