[08:34:06] <gerrit-wm>	 New review: Daniel Kinzler; "note ready yet" [mediawiki/extensions/Wikibase] (master); V: 0 C: -1;  - https://gerrit.wikimedia.org/r/17057
[08:34:49] <gerrit-wm>	 New review: Daniel Kinzler; "as per commit message: waiting for dependency" [mediawiki/extensions/Wikibase] (master); V: 0 C: -1;  - https://gerrit.wikimedia.org/r/14083
[09:13:27] <aude>	 Jens_WMDE: if you have any spare time, https://gerrit.wikimedia.org/r/#/c/16749/ needs review
[09:13:45] <aude>	 blocking progress on the client extension
[09:18:27] <Jens_WMDE>	 aude: will have a look at it, but i'm looking into something else right now
[09:22:07] <gerrit-wm>	 New review: Daniel Kinzler; "found a boog" [mediawiki/extensions/Wikibase] (master); V: 0 C: -1;  - https://gerrit.wikimedia.org/r/17057
[09:22:22] <Daniel_WMDE>	 Jens_WMDE: --^
[09:22:35] <aude>	 Jens_WMDE: thanks... doesn't have to be right now but sometime in the near future would be nice :)
[09:27:33] <gerrit-wm>	 New review: Daniel Kinzler; "please use "use" for clarity and sanity." [mediawiki/extensions/Wikibase] (master); V: 0 C: -1;  - https://gerrit.wikimedia.org/r/16749
[09:28:57] <Daniel_WMDE>	 aude: ---^
[09:31:32] <joancreus>	 whoops, right now i don't have time to trace where this comes from, but it seems edits via API are not subject to user rights? as an IP address i can edit via api but i can't via web interface. it might have something to do with action=wbsetitem where things are uploaded in batch
[09:32:08] <joancreus>	 on a side note, pywikidata has the core functions and works!
[09:33:03] <Lydia_WMDE>	 joancreus: yay! :)
[09:33:32] <Daniel_WMDE>	 joancreus: actually, IPs should be able to edit via the web interface just fine
[09:33:35] <Lydia_WMDE>	 joancreus: as for rights: they should be of course - let me see if i can find the bug report on this to see what's the status
[09:33:52] <Daniel_WMDE>	 joancreus: makign sure user rights are checked fro all api actions is on the todo list though
[09:33:57] <Daniel_WMDE>	 thanks for the heads up, anyway!
[09:34:15] <joancreus>	 ok!
[09:35:09] <aude>	 Daniel_WMDE: thanks!
[09:35:38] <Lydia_WMDE>	 joancreus: seems to be part of it
[09:35:39] <Lydia_WMDE>	 https://bugzilla.wikimedia.org/show_bug.cgi?id=37989
[09:35:41] <joancreus>	 Daniel_WMDE: (i changed permissions in the settings, just to see if pywikidata could handle errors)
[09:51:24] <gerrit-wm>	 New patchset: Jens Ohlig; "Undo for items [DO NOT MERGE]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/17057
[09:51:41] <Jens_WMDE>	 Daniel_WMDE: ---^
[09:51:56] <Daniel_WMDE>	 \o/
[09:56:55] <gerrit-wm>	 New patchset: John Erling Blad; "Refactoring autocommets and autosummary for API modules." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/17792
[10:04:02] <gerrit-wm>	 New patchset: John Erling Blad; "Refactoring autocommets and autosummary for API modules." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/17792
[10:08:55] <Daniel_WMDE>	 Jens_WMDE: thanks for the fix. would have done it myself, but didn't want to create conflicts.
[10:09:12] <Daniel_WMDE>	 Jens_WMDE: are you working on the undo stuff now? what's your plan for today?
[10:13:02] <Daniel_WMDE>	 Jens_WMDE: arrr. same problem in EntityDiff::apply(). 
[10:15:02] <gerrit-wm>	 New patchset: Jens Ohlig; "Undo for items [DO NOT MERGE]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/17057
[10:15:56] <Jens_WMDE>	 Daniel_WMDE: done with the system messages in repo/includes/actions/EditEntityAction.php
[10:16:19] <Jens_WMDE>	 Daniel_WMDE: as requested in the e-mail from you. feel welcome to take over from ehere
[10:16:22] <Daniel_WMDE>	 Jens_WMDE: ah, cool. i just found a bunch of logic errors in the apply stuff. will comment in gerrit.
[10:16:40] <Daniel_WMDE>	 please fix these, then i'll take over.
[10:16:47] <Jens_WMDE>	 will do!
[10:16:48] <Daniel_WMDE>	 would be cool if you could look into seleium tests later
[10:16:54] <Jens_WMDE>	 yes yes
[10:17:01] <Jens_WMDE>	 selenium is on my list next
[10:19:07] <gerrit-wm>	 New review: Daniel Kinzler; "found several logic errors in the apply() stuff. please test this, i probably missed some." [mediawiki/extensions/Wikibase] (master); V: 0 C: -1;  - https://gerrit.wikimedia.org/r/17057
[10:20:21] <gerrit-wm>	 New review: Daniel Kinzler; "oops - see patchset 8 for my inline comments." [mediawiki/extensions/Wikibase] (master); V: 0 C: -1;  - https://gerrit.wikimedia.org/r/17057
[10:20:33] <Daniel_WMDE>	 Jens_WMDE: --^
[10:20:54] <Daniel_WMDE>	 Jens_WMDE: didn't want to be pushy, just trying to coordinate.
[10:22:47] <Jens_WMDE>	 yes, it's appreciated :)
[10:23:11] <Jens_WMDE>	 i want to get this off our chest :D
[10:23:24] <Daniel_WMDE>	 would be nice, yea
[10:23:34] * Daniel_WMDE  contamplates a generic framework for testing action classes

[10:24:01] <Jens_WMDE>	 i miss functional programming :(
[10:26:13] <Daniel_WMDE>	 well, you *can* use it with php, but... it doesn't come natural. at all.
[10:26:23] <Daniel_WMDE>	 at least php has closures now.
[10:29:42] <gerrit-wm>	 New patchset: Aude; "add namespaces in the wikibase client" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/16749
[10:30:16] <aude>	 Daniel_WMDE: the code is still ugly but patchset ^
[10:34:40] <gerrit-wm>	 New patchset: Jens Ohlig; "Undo for items [DO NOT MERGE]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/17057
[10:35:36] <Jens_WMDE>	 Daniel_WMDE: ta-da!
[10:35:45] <Jens_WMDE>	 tada.wav
[10:37:00] <gerrit-wm>	 New patchset: John Erling Blad; "Splitting og language attributes in label and description" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/17227
[10:40:48] <gerrit-wm>	 New patchset: Joancreus; "Replacing .then by .done as per bug 37982" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/17794
[10:56:22] <nickanc>	 is there any plan for projs other than wikipedias?
[11:00:38] <Lydia_WMDE>	 nickanc: the main focus is wikipedia for now. however we do keep other projects in mind during development so that these can happen later
[11:00:45] <Lydia_WMDE>	 see also [[Wikidata/Future]]
[11:01:37] <AsimovBot>	 10[1] 10http://meta.wikimedia.org/wiki/Wikidata/Future
[11:01:49] <Lydia_WMDE>	 AsimovBot: you're lagging! :D
[11:01:53] <AsimovBot>	 04Error: Command “you're” not recognized. Please review and correct what you’ve written. - 13Ayuda: -? 
[11:02:04] <Lydia_WMDE>	 i know i know... sorry
[11:02:10] * Lydia_WMDE  pets AsimovBot

[11:03:03] <nickanc>	 ehehe!
[11:03:57] <nickanc>	 an admin on it.wikisource, talking at it.wp village pump, was very interested in wikidata.
[11:04:31] <Lydia_WMDE>	 cool
[11:04:38] <Lydia_WMDE>	 please point them to the link above
[11:04:47] <Sannita>	 no prob, I'll do it
[11:04:52] <Sannita>	 (good morning everyone)
[11:06:06] <nickanc>	 Lydia_WMDE it.wiki village pump is full of '''support''' and ''strong support''', no oppose: https://it.wikipedia.org/wiki/Wikipedia:Bar/Discussioni/Inizio_dei_test_di_Wikidata:_ci_facciamo_avanti%3F
[11:06:26] * Lydia_WMDE  bounces

[11:06:52] <Lydia_WMDE>	 Denny_WMDE1: ^
[11:08:14] * Lydia_WMDE  is off for food for a bit

[11:10:27] <Daniel_WMDE>	 aude: can 'self::compareLinks' as a *string* really work? how and where would "self::" be resolved?
[11:10:45] <Daniel_WMDE>	 same with 'self::noExternalInterlang'
[11:16:35] <gerrit-wm>	 New patchset: John Erling Blad; "Fix invalid siteid in example for wbsetsitelink" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/17797
[11:19:24] <Denny_WMDE1>	 nickanc: that is great to see
[11:19:28] <gerrit-wm>	 New review: Jens Ohlig; "No obvious mistakes found." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/16749
[11:19:28] <gerrit-wm>	 Change merged: Jens Ohlig; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/16749
[11:20:17] <nickanc>	 ehehe! it.wp strongly believes in wikidata.
[11:20:40] <Denny_WMDE1>	 nickanc: we need to select a second language besides hu.wp for early testing purposes, and it.wp has the two advantages that it is very big and has a strong and active community
[11:24:01] <nickanc>	 we would be indeed very proud to be the second proj.
[11:27:14] <nickanc>	 denny_WMDE1 yesterday Lydia was telling us that there was also he.wiki interested.
[11:28:40] <nickanc>	 could both it and he be second proj? we are aware that he.wp is right-to-left and so extremely interesting for debugging
[11:29:47] <Denny_WMDE1>	 nickanc: it could be, but i would prefer to have no big number of projects for testing, for the simple reason that we want to deploy faster :)
[11:31:16] <nickanc>	 ok. We would be really glad to be a testing proj, but just we dont want to usurp any other. :)
[11:54:04] <Denny_WMDE1>	 nickanc: we will come back to you about it. if he.wp goes for it, i would give them preference over it.wp due to RTL, otherwise the spot is free and it.wp is likely to take it.
[11:54:25] <gerrit-wm>	 New review: Daniel Kinzler; "See the two inline comments." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/16749
[11:54:33] <Denny_WMDE1>	 on the other hand, i hope it is just  a question of a few weeks earlier or later, and then all projects can have wikidata language links
[11:54:46] <Daniel_WMDE>	 aude: ---^
[11:54:57] <Daniel_WMDE>	 i'm confused about the "self:" stuff
[11:58:41] <nickanc>	 thank you Denny_WMDE1 :)
[12:31:43] <aude>	 Daniel_WMDE: if it makes sense, i'd like to split the hooks out from the handler classes and put in the WikibaseClient.hook file (like the other extensions do)
[12:32:10] <aude>	 and separate the sorting stuff 
[12:32:48] <Daniel_WMDE>	 aude: sure, why not
[12:33:13] <Daniel_WMDE>	 Jens_WMDE: let me know when you are ready with the undo stuff. i'm working on "disabled edit" until then
[12:34:40] <aude>	 Daniel_WMDE: ok
[12:34:57] <aude>	 one step at a time to get the extension in good shape
[12:35:26] <Jens_WMDE>	 Daniel_WMDE: Did all the changes you wanted in the last changeset
[12:36:21] <gerrit-wm>	 New patchset: Aude; "add use keyword for hooks class" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/17802
[12:40:28] <gerrit-wm>	 New patchset: John Erling Blad; "Forms for SpecialItemByLabel and SpecialItemByTitle" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/17169
[12:49:33] <gerrit-wm>	 New review: Jeroen De Dauw; "I don't think this is a particular useful change - either approach is fine. In fact, if the class is..." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/17802
[12:49:33] <gerrit-wm>	 Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/17802
[12:49:47] <Jens_WMDE>	 Daniel_WMDE: did you get that? feel free to work on the undo stuff now, i'm done.
[12:50:02] <Daniel_WMDE>	 Jens_WMDE: great, thanks!
[12:50:11] * Daniel_WMDE  is fighting with Article::view and ParserOptions

[12:50:38] <Jens_WMDE>	 :(
[18:16:22] <gerrit-wm>	 New review: Daniel Kinzler; "Please use I6efe753e instead, it fixes the same issue but in a way that still tests normalization." [mediawiki/extensions/Wikibase] (master); V: 0 C: -2;  - https://gerrit.wikimedia.org/r/17810
[18:17:58] <gerrit-wm>	 Change merged: Daniel Kinzler; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/17797
[22:41:17] <gerrit-wm>	 New patchset: John Erling Blad; "Fix for two failures in the tests, only a few two missing entries." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/17916