[07:53:49] New review: John Erling Blad; "I would prefer that the siteids reflects the real configuration and not some pony make up data. If s..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/17810 [07:57:15] New review: John Erling Blad; "Note also that sites with this kind of pony data will not use normalization at all, but still should..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/17810 [08:14:40] New review: John Erling Blad; "I would prefer that the siteids reflects the real configuration and not some pony make up data. If s..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/17529 [08:15:04] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/17529 [08:15:45] Change abandoned: John Erling Blad; "Merged in the alternative to reduce the number of failing tests." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/17810 [09:02:17] New review: John Erling Blad; "Use of messages needs cleanup, not sure if its a good idea to just replace one bad solution with ano..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/17660 [09:08:49] New review: John Erling Blad; "Well, it does not trigger new failures... ;)" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/17661 [09:08:49] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/17661 [09:28:26] New review: John Erling Blad; "Just my ?0.05" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/16829 [09:38:24] New review: Aude; "looks sane, generally should work" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/14083 [09:38:24] Change merged: Aude; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/14083 [09:40:20] New patchset: Tobias Gritschacher; "additional reload for sitelinks-tests" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/17933 [09:44:12] New review: Jens Ohlig; "I don't love the "Created by JetBrains PhpStorm." boilerplate :)" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/16829 [09:58:35] New review: Daniel Friesen; "Aren't "Type" and "Value" a little, erm... too generic?" [mediawiki/extensions/Wikibase] (master) C: -1; - https://gerrit.wikimedia.org/r/16829 [10:09:40] hi all [10:13:18] http://0pointer.de/blog/projects/berlin-open-source-meetup.html [10:13:43] * jeremyb prods an aude [10:21:41] jeremyb: i am going ;-) [10:21:56] Lydia_WMDE: okey [10:22:03] who else? ;) [10:22:08] (others are welcome too of course) [10:22:38] Lydia_WMDE: how's my logo doing? ;-) [10:23:00] jeremyb: *sob*... you're touching a sore spot :P [10:23:10] Lydia_WMDE: ;-( ;-( [10:23:20] Lydia_WMDE: i want to use it! [10:23:22] it's with legal at the foundation now [10:23:25] i know! :P [10:23:28] oh, wtf [10:23:31] ;-( [10:23:43] damn lawyers [10:23:46] ;-) [10:23:57] did it go through WMDE lawyers too? [10:24:21] nope - only wmde designers and press people and so on [10:24:28] but anyway [10:24:29] Change abandoned: John Erling Blad; "Wrong fix" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/17916 [10:24:32] hopefully solved soon... [10:24:53] * jeremyb waits... [10:25:27] Lydia_WMDE: is there a favicon generated already or you still need to do that? [10:25:40] not done yet, no [10:28:03] jeremyb: schlaff? :) [10:28:13] aude: idk [10:28:17] heh [10:28:28] aude: prod? [10:28:42] japanese overlap? [10:29:54] * aude can probably go [10:29:59] thanks jeremyb [10:30:27] woot [10:53:46] New patchset: Daniel Kinzler; "Test handling of malformed json by wbsetitem." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/17528 [10:58:03] New review: Daniel Kinzler; "looks sane" [mediawiki/extensions/Wikibase] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/17933 [11:01:12] there are peanutbutter M&Ms from the US here, guys! [11:03:40] New patchset: Jeroen De Dauw; "Added very basic ItemUpdaterTest" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/17937 [11:05:41] New patchset: Jeroen De Dauw; "Coverage should ignore test registration" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/17938 [11:11:37] New patchset: John Erling Blad; "Added filtering of aliases on languages in getAllAliases" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/17939 [11:17:31] Lydia_WMDE: is there the possibility for enthusiastic it.wp users to join Wikidata? In particular, actually, becoming Wikidata user what they can do? (I would like to make many persons join wikidata) [11:17:49] *becoming wikidata users [11:18:40] New review: John Erling Blad; "mumble" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/17528 [11:18:40] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/17528 [11:18:54] (this question is independent from testing on it.wp) [11:19:13] Change merged: Jens Ohlig; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/17933 [11:19:24] nickanc: hey :) [11:19:36] hmm so far no since the system isn't set up yet [11:19:51] but once it is they will be able to log in with their global accounts [11:19:57] is that what you meant? [11:20:00] yes [11:20:17] New review: Daniel Kinzler; "see inline comments. please clearify." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/17792 [11:20:27] ok time for food [11:20:29] laters :) [11:20:35] enjoy your meal! :) [13:03:37] New patchset: Jeroen De Dauw; "Kill outdated and broken code inserting crap into the langlinks table" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/17944 [13:17:36] New review: Aude; "we're still going to be sorting the links, etc. need some of this code in the refactoring" [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/17944 [13:57:13] New patchset: Jeroen De Dauw; "Updated link updating code to use local item cache rather then langlinks and match SiteLink refactor" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/17946 [14:46:38] Daniel_WMDE: https://gerrit.wikimedia.org/r/#/c/17939/ [14:46:53] tnx [14:47:13] JeroenDeDauw: just merge this :) [14:49:23] nvm, i'll do it [14:49:42] Change merged: Daniel Kinzler; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/17939 [14:49:58] JeroenDeDauw: --^ [15:06:32] Change abandoned: Jens Ohlig; "(no reason)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/17950 [15:10:09] TobiasG_WMDE: https://gerrit.wikimedia.org/r/#/c/17951/ should be no problem to review :D [15:16:52] New patchset: John Erling Blad; "Refactoring autocommets and autosummary for API modules." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/17792 [15:22:07] New review: Tobias Gritschacher; "Can you please add a comment saing that this test could be added again as soon as https://gerrit.wik..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/17951 [15:23:00] Jens_WMDE: please add a inline comment (see the gerrit comment) [15:26:45] . [15:28:04] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/17938 [15:28:05] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/17937 [15:29:44] New review: Aude; "looks good" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/17946 [15:29:44] Change merged: Aude; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/17946 [15:40:39] New patchset: Jens Ohlig; "Get rid of warnings in LangLinkHandler.php" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/17955 [15:41:44] Change merged: Aude; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/17955 [15:57:18] New patchset: John Erling Blad; "Refactoring autocommets and autosummary for API modules." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/17792 [16:04:07] Change abandoned: John Erling Blad; "whatever" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/16828 [16:05:14] Change merged: Daniel Kinzler; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/17792 [17:01:40] New patchset: Aude; "use site local key until we take site groups into considerations" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/17960 [17:28:30] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/17960 [18:11:27] New patchset: Daniel Kinzler; "Tests for EditEntityAction" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/17970 [18:28:08] New patchset: Daniel Kinzler; "Tell JS whether editing should be enabled." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/17806 [19:36:43] New patchset: John Erling Blad; "Formatting for the Autocomment stuff." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/17978