[07:25:54] * JeroenDeDauw hands Daniel_WMDE_ a cookie for mentioning IPoAC [09:20:36] New patchset: John Erling Blad; "(Bug 37385) Initial commit for checking edit conflicts [DO NOT MERGE]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20679 [09:27:49] New patchset: John Erling Blad; "(Bug 37385) Initial commit for checking edit conflicts [DO NOT MERGE]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20679 [09:36:23] New patchset: John Erling Blad; "(Bug 37385) Initial commit for checking edit conflicts [DO NOT MERGE]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20679 [09:38:12] New review: Nikerabbit; "Is there a reason you are not reusing the edit conflict logic from core? It's using timestamps inste..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/20679 [09:44:00] New patchset: Jeroen De Dauw; "Added Snaks interface with SnakList implementation + tests" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20682 [09:44:00] New patchset: Jeroen De Dauw; "Added tests for PropertyValueSnak and parent classes after registering all the new stuff" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20111 [09:50:36] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/19995 [09:54:25] New review: John Erling Blad; "We could use timestamps instead of revision ids, but the id seems to be somewhat more intuitive. Tim..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/20679 [10:01:47] New review: Daniel Kinzler; "Some assertions are tautoligic - the test case should provide fixed expected values so we actually c..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/20111 [10:08:00] Lydia_WMDE: the campus party guys are urging me to redeem by vip code. i don't think i have a vip code. or any code. do you know more about this? [10:08:18] btw, i'm thinking about attending the CP community night on wednesday [10:09:16] Lydia_WMDE: also... the two (?) guests that I can bring - are these slots already taken? I have no overview whatsoever who is going to CP and when. [10:11:45] Daniel_WMDE_: hmmm nicole should have an overview of who gets which ticket [10:12:05] Lydia_WMDE: well, she asked me whether these slots are taken :) [10:12:08] Daniel_WMDE_: as for redeeming your code not really. can you forward the email maybe? [10:12:15] oh... [10:12:16] heh [10:12:19] well [10:12:23] Lydia_WMDE: did you get and use a code? [10:12:34] does Abraham_WMDE and Denny_WMDE have a ticket? [10:12:39] i gave mine to Jens_WMDE [10:12:54] and didn't use my second free ticket [10:13:03] i didn't get a code, no [10:14:20] Daniel_WMDE_: hmm i didn't get such an email [10:16:10] Denny_WMDE: no i don't. [10:16:31] Daniel_WMDE_: but i also don't need one, i am busy :) ^ [10:17:19] * aude would be interested, perhaps to attend part? is it in english? [10:17:38] * aude too busy to attend the entire event, however [10:17:42] are the tickets personalised? [10:17:48] or can different people go every day [10:17:53] that would be nice [10:18:19] they are personalized [10:18:25] they're quite paranoid about the whole thing [10:19:11] :( [10:21:12] in that case, i dont want to block a ticket for the whole event just to go to one or two talks [10:31:44] New patchset: Jeroen De Dauw; "Implemented Reference + tests + fixes to SnakList" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20686 [10:32:36] New review: Jeroen De Dauw; "Has some issues I did not catch (since one of the issues was the tests not running). Fixes in https:..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/20682 [10:37:49] New patchset: Tobias Gritschacher; "rakefile: refactoring tasks; now we have tasks which call the tests in all available browsers;" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20687 [10:38:22] New patchset: Jeroen De Dauw; "fix cp error" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20688 [10:39:01] New review: Jeroen De Dauw; "Follow up: https://gerrit.wikimedia.org/r/#/c/20688/" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/20111 [10:53:58] New review: Daniel Kinzler; "huh?!" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/20688 [10:54:19] New patchset: Aude; "add missing message param for wikibase-error-sitelink-already-used" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20689 [10:54:28] New review: Jens Ohlig; "Nifty." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/20687 [10:54:28] Change merged: Jens Ohlig; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20687 [11:15:23] New patchset: Jeroen De Dauw; "Implemented Claim and added tests" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20691 [11:19:09] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20689 [11:27:27] New review: Daniel Kinzler; "this introduces Entity:clear() bot no tests for it. " [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/19210 [11:37:03] New patchset: Daniel Kinzler; "Fixing ItemObject::clear() and adding tests." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20692 [11:42:21] New review: Jeroen De Dauw; "+0. Guess you're not breaking anything, but the static:: thing is rather wrong" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/20692 [11:56:15] New patchset: Daniel Kinzler; "Always ignore "touched" field." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20693 [12:32:28] New review: Daniel Kinzler; "@jeroen: why is it wrong? it can be done differently, but to me it seems like a textbook use case fo..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/20692 [12:57:55] New patchset: Aude; "use item id for edit link" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20453 [13:03:50] Kriegen wir heute hitzefrei? [13:12:57] Daniel_WMDE_: i might go home early and work at home [13:13:30] New patchset: Tobias Gritschacher; "moved output of browser and target OS from Rakefile to spec_helper" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20699 [13:41:04] New patchset: Jeroen De Dauw; "Implemented statement and added some utility classes" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20700 [13:45:03] New review: Jeroen De Dauw; "As far as I can see:" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/20692 [13:48:10] New patchset: Tobias Gritschacher; "fixed client_repo tests" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20703 [13:48:30] New review: Daniel Kinzler; "gah! I was sure cleanStructure() was static - because previously, self:: was used. Well then, never ..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/20692 [13:49:55] New patchset: Daniel Kinzler; "Fixing ItemObject::clear() and adding tests." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20692 [13:50:12] Change merged: Jens Ohlig; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20453 [14:06:45] New patchset: Jeroen De Dauw; "Added tests for MapValueHasher" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20706 [14:07:18] New patchset: Jeroen De Dauw; "Added tests for MapValueHasher" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20706 [14:14:49] * Lydia_WMDE already did [15:02:15] New review: John Erling Blad; "Use of "self" was an error on my part." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/20692 [15:17:03] New patchset: John Erling Blad; "(Bug 37385) Initial commit for checking edit conflicts [DO NOT MERGE]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20679 [15:33:17] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20692 [15:49:00] New patchset: John Erling Blad; "(Bug 39201) Redirect Split:ItemByLabel to item insted of displaying inline" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20446 [15:53:32] New patchset: John Erling Blad; "(Bug 39201) Redirect Split:ItemByTitle to item insted of displaying inline" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20726 [16:07:09] New review: John Erling Blad; "In good faith that the tests are fixed in later patches, which I have not seen yet, I'm going to mer..." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/20111 [16:07:10] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20111 [16:19:36] New review: John Erling Blad; "Empty tests!!" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/20682 [16:19:37] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20682 [16:26:58] New patchset: Jeroen De Dauw; "Added HashArray tests" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20732 [16:28:07] New review: John Erling Blad; "I don't like funny stuff in code, try to keep focus. I hope the omnomnom-stuff is removed as soon as..." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/20686 [16:28:08] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20686 [16:35:42] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20691 [16:38:50] New review: John Erling Blad; "fix this" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/20688 [16:51:24] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20693 [17:16:59] New patchset: Jeroen De Dauw; "Added statement tests" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20736 [17:19:58] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20706 [17:19:58] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20700 [17:26:46] New review: John Erling Blad; "Seems to be okey.." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/20736 [17:27:27] Daniel_WMDE_: you can say `bug dddd, comment dd` (description == comment 0) [17:29:05] New review: Jeroen De Dauw; "It's better then it was before, remove it if you care spending time on it, I'm not going to waste my..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/20688 [17:31:25] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20736 [17:31:25] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20732 [17:36:42] New patchset: John Erling Blad; "(Bug 37385) Initial commit for checking edit conflicts [DO NOT MERGE]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20679