[08:10:55] New patchset: Henning Snater; "fixes required due to jQuery 1.8.0 update" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20863 [08:28:05] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20863 [08:28:52] aude: UI fixed; should work again [08:29:30] TobiasG_WMDE: yay [08:30:19] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20703 [08:52:17] New patchset: John Erling Blad; "(Bug 37385) Initial commit for checking edit conflicts [DO NOT MERGE]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20679 [08:55:30] hi aude and all. [08:55:49] the "edit link" link on the Hebrew test client wiki leads to http://wikidata-test-repo.wikimedia.de/wiki/Special:ItemByTitle/hewiki/%D7%A2%D7%9E%D7%95%D7%93_%D7%A8%D7%90%D7%A9%D7%99 [08:55:49] hi aharoni [08:56:00] which doesn't look a useful page for editing links. [08:56:10] aharoni: it's fixed in gerrit [08:56:24] OK. [08:56:34] there will be no link if there is no corresponding item [08:56:57] That page, whatever it is, also has a grayed-out "enter description" input field which is not useful at all. [08:57:13] if there is, (to be decided), either link directly to the item page (by id) or special page which does redirect [08:57:39] probably the special page, as it's tricky with the Data namespace presumably localized [08:57:54] aharoni: the special page, as is, is not editable [08:57:58] it should be editable [09:22:23] New patchset: Daniel Kinzler; "Fix error when calling EntityContent::save repeatedly." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20865 [09:50:12] New patchset: Daniel Werner; "Improved editable aliases and prepared its DOM structure for grid layout" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20868 [09:50:21] Henning_WMDE: ^^ [10:19:59] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20688 [10:29:42] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20699 [10:39:38] New patchset: Tobias Gritschacher; "fix: we need the clientInterwikiLinkList again!" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20875 [10:41:19] New review: Jens Ohlig; "Finally ;)" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/20875 [10:41:19] Change merged: Jens Ohlig; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20875 [10:54:14] New review: Daniel Kinzler; "@john: see inline reply" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/20865 [11:08:54] New review: Aude; "This redirects to the item page in English. This could be smarter and consider user language prefer..." [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/20726 [11:09:10] New patchset: Jeroen De Dauw; "improve test coverage" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20880 [11:23:41] New patchset: Aude; "(Bug 39201) Redirect Split:ItemByTitle to item insted of displaying inline" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20726 [11:24:52] New patchset: Aude; "(Bug 39201) Redirect Split:ItemByTitle to item insted of displaying inline" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20726 [13:06:24] New patchset: Tobias Gritschacher; "enhanced protected_page test to check for a normal user AND the anonymous user;" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20887 [13:06:50] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20887 [13:51:15] New patchset: Jeroen De Dauw; "Added GUID generator" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20893 [14:57:03] l10n/i18n team sprint demo is about to start [15:25:12] New patchset: Daniel Werner; "Improved editable aliases and prepared its DOM structure for grid layout" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20868 [16:13:33] New review: John Erling Blad; "I think we need a discussion about the wanted properties from this function, or from the context whe..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/20893 [16:20:41] New review: John Erling Blad; "To clearify; I think the code using this function should either request a new UUID if the supplied U..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/20893 [16:27:10] New patchset: Daniel Werner; "Improved editable aliases and prepared its DOM structure for grid layout" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20868 [16:31:48] New review: Jeroen De Dauw; "I already started the discussion on the list. This commit is about adding a GUID generator, not abou..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/20893 [16:34:26] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20865 [16:42:51] New patchset: Jeroen De Dauw; "Implementing subscription support for statements and their sub components [DO NOT MERGE]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20909 [16:55:03] New review: John Erling Blad; "Darn, this takes more and more time to run!" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/20880 [16:55:04] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20880 [17:15:22] New review: John Erling Blad; "The special page is used for identification of an item, not for switching user language" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/20726 [17:24:47] New patchset: John Erling Blad; "(Bug 39201) Redirect Split:ItemByLabel to item insted of displaying inline" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20446 [17:35:06] New review: John Erling Blad; "Should not make anything fail, it only hurt my feeling to merge code that use something named "com_c..." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/20893 [17:35:06] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20893 [17:36:01] * jeblad_WMDE is Master of Disaster [17:50:19] ^^ tell us something new [17:50:27] uga [17:55:50] * jeblad_WMDE eating Salmiakk-bombs [17:56:04] Do you want some Danwe_WMDE ? [17:56:13] New review: Aude; "The default behavior should use the site language (from the request) to determine which language to ..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/20726 [18:00:25] jeblad_WMDE: how do you think special:itembytitle should work? [18:01:10] should it always have uselang=he? (if it's hewiki/pagetitle) [18:01:30] or no uselang at all? [18:02:24] I just think it should not switch language if the user doesn't ask for this, and then it should be handled by language switcher [18:02:58] ugh [18:03:33] i think maybe it should show the item in the language (site) requested [18:03:39] maybe no preferences [18:03:50] But other than that.. we need to figure out how to handle this on first entry.. I try to not think to much about it because I suspects it is more difficult than we really like.. [18:03:59] it would be nice to decouple the interface lang and the item lang [18:04:15] I think so too.. [18:06:04] if we attach the uselang parameter to the special page, it doesn't work [18:07:03] i suggest we bring this up for discussion, but [18:07:25] that leaves no nice way to go from wikipedia (in x language) to wikidata in x langauge [18:08:52] I think we must have an open discussion about it,.. bring it up tomorrow [18:20:30] jeblad_WMDE: i'm sending an email [18:24:33] email sent [18:28:29] New review: Aude; "If the one and only label found is in Hebrew (for example), should it redirect to the item page in H..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/20446 [18:37:32] hah, ASAP [18:42:38] heh [19:07:03] New patchset: Jeroen De Dauw; "Implementing abstract store interface [DO NOT MERGE]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20924 [19:07:57] New patchset: Daniel Werner; "Improved editable aliases and prepared its DOM structure for grid layout" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20868 [20:49:38] New patchset: Daniel Werner; "Some cleanup in documentation, fixed some old ToDo's" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21009 [20:50:57] New review: Daniel Werner; "Just some updated comments" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/21009 [20:50:57] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21009 [20:51:47] Danwe_WMDE: !! [21:01:49] New patchset: Daniel Werner; "Changed @file into @file" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21011 [21:06:21] jeblad_WMDE: what's wrong [21:10:01] jeblad_WMDE: ooops, I did it again [21:11:28] New review: Daniel Werner; "Wanted to do this like forever, core is next" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/21011 [21:11:39] NOW^^ [21:37:39] This will cost you, you're... you're.. Daniel!! [21:38:10] Equally bad weather at the office? [21:50:58] jeblad_WMDE: yes [21:51:00] I am trapped [21:51:11] Can't go home because rain like crazy [21:51:34] The weather Gods saw what you did and now their revenge is over you! =D [21:51:59] actually, Jeroen alloed me to do that before he went home :p [21:52:12] haha [21:52:15] So I guess it's really just the revenge on him because he's biking in the rain now :D [21:52:30] While I am sitting here, coding some awesome stuff [21:54:15] He is biking as crazy thinking "I must home and save the world before Danwe refactor the weather systems! [22:00:18] * aude left at 9pm for a reason [22:00:25] it was raining but not like this [22:01:16] He's probably biking in the underground [22:03:27] heh [22:27:15] I think I'm closing the connection now, the lightning hit the neighbouring building [22:27:20] :) [22:27:23] good night! [22:27:25] still trapped here [22:27:27] Se you all tomorrow [22:27:29] found some cookies though :D [22:27:46] Yummie! [22:28:08] Sleep in the office if it doesn't stop raining [22:31:30] it will [22:31:33] already did [22:31:52] a little^^