[07:50:53] New patchset: Tobias Gritschacher; "small fix to blocked_user test to be more compatible with chrome;" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21550 [08:21:05] New patchset: John Erling Blad; "(Bug 39677) Failing tests in WikibaseLib" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21551 [08:24:11] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21551 [08:51:57] https://bugzilla.wikimedia.org/show_bug.cgi?id=39623 [08:52:16] https://bugzilla.wikimedia.org/show_bug.cgi?id=37459 [08:54:54] New patchset: Tobias Gritschacher; "fixed edit sitelink_test to be compatible with MAC FF;" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21552 [09:23:36] New review: Jeroen De Dauw; "Note: requires running update.php" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/21328 [09:39:15] New patchset: Tobias Gritschacher; "selenium tests console output" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21051 [10:54:01] New patchset: Tobias Gritschacher; "refactoring selenium: added methods for common tasks to page object." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21564 [12:08:38] ffs, someone review https://gerrit.wikimedia.org/r/#/c/20924/ [12:22:04] New review: Jeroen De Dauw; "Yes, looks like Aude is right" [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/21190 [12:35:04] JeroenDeDauw: jeblad_WMDE: our chocolate review box is refilled :-) [12:35:14] New patchset: Jens Ohlig; "Renamed ItemByLabel to "ItemDisambiguation"" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21190 [12:37:55] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21317 [12:56:29] New patchset: Jeroen De Dauw; "Improve documentation" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21583 [13:01:18] New patchset: Jeroen De Dauw; "made snaks immutable" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21585 [13:04:53] New patchset: Aude; "Renamed ItemByLabel to "ItemDisambiguation"" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21190 [13:05:18] New review: Aude; "fixed some merge conflicts in the i18n files" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/21190 [13:51:34] New review: Aude; "looks good to me, passes tests, poked around at repo + client with this patch and don't see any prob..." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/20924 [13:51:34] Change merged: Aude; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20924 [13:52:22] New patchset: Jeroen De Dauw; "Rewriting SQL store implementation" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21328 [13:58:11] New patchset: Jeroen De Dauw; "Rewriting SQL store implementation" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21328 [13:59:37] Change merged: Aude; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21583 [14:04:12] New review: Tobias Gritschacher; "all Selenium & PHPUnit tests still working. seems to be ok to me." [mediawiki/extensions/Wikibase] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/21328 [14:35:25] Jens_WMDE: you now love PHP, because this is valid: [14:35:27] $nyan = array(); [14:35:27] $nyan['nyan'] =& $nyan; [14:35:27] $nyan['cat'] = 'nyan'; [14:35:27] echo $nyan['nyan']['nyan']['nyan']['nyan']['nyan']['nyan']['nyan']['nyan']['nyan']['nyan']['nyan']['nyan']['nyan']['nyan']['nyan']['nyan']['nyan']['nyan']['nyan']['nyan']['cat']; [14:36:35] oh dear [14:36:53] this is ... well. [14:45:15] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21328 [14:50:13] JeroenDeDauw: care to have a look at https://gerrit.wikimedia.org/r/#/c/21190/ ? [14:52:56] New review: Tobias Gritschacher; "Tests running. Looks good to me." [mediawiki/extensions/Wikibase] (master); V: 1 C: 1; - https://gerrit.wikimedia.org/r/21190 [15:09:20] JeroenDeDauw: people added Lisp versions of your PHP madness: https://gist.github.com/3489071 [15:10:52] Jens_WMDE: hehe [15:11:48] Jens_WMDE: those just print it though, that's easy [15:12:07] yeah, lame [15:12:33] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21190 [15:23:18] (def love (write 'love (love))) [15:23:49] (write 'scheme love) [15:24:37] If you have a crappy lisp interpreter it will crash [15:38:36] hm, .. (def love (lambda () (write 'love (love)))) [15:47:14] New patchset: Jeroen De Dauw; "Changed implementation of References interface to use objectStorage rather then hashArray since we can have elements with duplicate values and elements are mutable" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21599 [16:08:28] New review: Jens Ohlig; "Looks good, but I seem to have problems with the setup after refactoring... Probably my fault, though." [mediawiki/extensions/Wikibase] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/21051 [17:28:47] New patchset: Jeroen De Dauw; "Added maintenance script for rebuilding the data and refactored the one for deleting a little" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21610 [17:39:37] New review: Raimond Spekking; "Question related to removal of a message part (inline)." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21190