[08:14:11] New review: Daniel Kinzler; "minor stuff" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/22706 [08:49:23] Sk1d: thanks! :) [08:54:24] New patchset: Tobias Gritschacher; "fixed selenium test for item disambiguation which failed when executed twice due to remainig old items with the same label" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23044 [09:05:46] New patchset: Daniel Kinzler; "Don't check for edit conflicts per default." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23046 [09:34:21] Lydia_WMDE: ? [09:34:40] Sk1d: fix in the office hour log :) [09:34:56] np [09:44:16] New patchset: Jens Ohlig; "Special:ItemByTitle -- needless text removed." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/22737 [09:46:29] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/22909 [10:00:16] New patchset: Henning Snater; "(39581) Special:CreateItem first iteration" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/22706 [10:00:19] New patchset: Daniel Werner; "(bug 40047) links to sites after editing site-links working again" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23050 [10:03:11] New patchset: Jens Ohlig; "Special:ItemByTitle -- needless text removed." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23052 [10:04:16] New review: Daniel Kinzler; "comments to Patch Set 14 have not been addressed" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/22706 [10:04:41] Change abandoned: Jens Ohlig; "Gerrit is on drugs and hallucinates about a recursive merge that cannot be done." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/22737 [10:07:40] New patchset: Tobias Gritschacher; "(39581) Special:CreateItem first iteration" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/22706 [10:09:50] New patchset: Jens Ohlig; "Special:ItemByTitle -- needless text removed." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23052 [10:21:47] New patchset: Henning Snater; "(39581) Special:CreateItem first iteration" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/22706 [10:43:24] New patchset: John Erling Blad; "(Bug 40073) Add URL unconditionally to the result from wbsetsitelink" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23053 [10:49:27] hm, is jeroen not in? [10:49:42] i just found a problem with the Sites table stuff [10:52:22] New review: Henning Snater; "- Daniel's comments to patch set 14 need to be addressed" [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/22706 [10:53:49] jeroen meant to come in later today, he's packing for his vacations [11:10:06] New review: John Erling Blad; "Could it be some hidden dependency? Got this while running group Wikibase. It still persist after a ..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/22917 [11:12:24] New patchset: Tobias Gritschacher; "(39581) Special:CreateItem first iteration" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/22706 [11:18:03] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/22919 [11:21:05] Change merged: Henning Snater; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23044 [11:21:34] Change merged: Henning Snater; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/22706 [11:21:54] i can haz merge? https://gerrit.wikimedia.org/r/#/c/23052/ [11:26:10] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/22922 [11:31:12] New review: John Erling Blad; "Going to take an additional look on this later after the rest of the stuff is merged." [mediawiki/extensions/Wikibase] (master); V: -1 C: 0; - https://gerrit.wikimedia.org/r/22917 [11:32:31] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/22923 [11:38:00] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/22928 [11:45:25] Hi ! Is there a place where I can find the video of the presentation at Wikimania "Technology and Infrastructure V: Data" ? [11:47:38] Benoit-Rochon: it's not online yet unfortunately [11:47:41] only the panel [11:48:34] Ok thanks. Can wait to see that... I missed it at Wikimania. [11:48:43] :) [11:48:59] i'll post it in the weekly summary and on twitter as soon as i have a link to it [11:53:51] New review: John Erling Blad; "Not totally confident in handling of late conflicts, but for now this seems fine." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/23046 [11:53:51] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23046 [11:53:58] New patchset: Daniel Kinzler; "Use EditEntity to implement undo/restore" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/22917 [11:54:27] New review: Daniel Kinzler; "should be fixed by I7e63ae3d and should now work after the rebase." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/22917 [11:57:51] New review: John Erling Blad; "Seems like spourious stuff are in the i18n-file." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/23052 [12:06:29] New patchset: Daniel Kinzler; "Don't use fixed internal IDs for test sites." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23057 [12:06:36] New review: John Erling Blad; "Seems like its working now." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/23050 [12:06:36] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23050 [12:06:43] New patchset: Daniel Kinzler; "Avoid nested transactions in SiteObject::save." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23058 [12:12:16] Change abandoned: Daniel Kinzler; "will be replaced by more complete & consise patch" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23057 [12:14:27] New review: John Erling Blad; "Aw.... :)" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/22917 [12:18:10] New patchset: Daniel Kinzler; "Don't allow setting of internal IDs." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23060 [12:25:15] wikidata test rpository down? [12:25:43] Seems like Gerrit is dead [12:26:01] network perhaps [12:26:18] New patchset: Daniel Kinzler; "Fixed 2 bugs in TestSites::insertIntoDb()" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23061 [12:26:52] Jens_WMDE is updating [12:30:01] hm... [12:30:42] jeblad_WMDE: looks like the wiki thinks it's on "localhost". my have to set $wgServer explicitely. [12:30:50] Jens_WMDE: ---^ [12:31:11] re gerrit: [12:31:25] the web frontend seems to be down, but git review still works [12:33:29] works again [12:45:08] New review: Daniel Kinzler; "That's odd - seems related to Ifa012949, but I can't imagine how you'd have the old implementation b..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/22917 [12:50:15] Lydia_WMDE: were's the google doc for the weekly? I only find 21... [12:54:26] New patchset: Daniel Kinzler; "Use EditEntity to implement undo/restore" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/22917 [12:54:50] New review: Daniel Kinzler; "fixed bad auto-merge" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/22917 [13:06:12] New patchset: Daniel Kinzler; "Fixed 3 bugs in TestSites::insertIntoDb()" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23061 [13:15:32] DanielK_WMDE: Could be the changes to be able to run the selenium tests [13:15:47] jeblad_WMDE: what could? [13:16:09] Change merged: Daniel Kinzler; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23053 [13:17:00] DanielK_WMDE: when $wgServer is set it will confuse the Selenium tests [13:17:07] New patchset: Tobias Gritschacher; "added setup and teardown methods to selenium tests" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23066 [13:20:04] uh, ... goddagmannhosteskaft [13:22:54] Jens_WMDE: were you trying to move the data to the main namespace? [13:27:24] New patchset: John Erling Blad; "(Bug 39839) Add a faster method for "userWasLastToEdit"" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/22200 [13:27:30] New patchset: Jens Ohlig; "Special:ItemByTitle -- needless text removed." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23052 [13:29:24] DanielK_WMDE: nope [13:29:35] hmkay [13:30:53] the wikidata-test-repository is up again and working. [13:32:00] Jens_WMDE: thank you! [13:32:43] New patchset: Tobias Gritschacher; "added setup and teardown methods to selenium tests" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23066 [13:37:28] Jens_WMDE: all user account deleted? [13:37:59] Merlissimo: yes [13:38:26] Merlissimo: had to start from the scratch [13:38:27] ok, then e reregister my bot account [13:38:44] Merlissimo: ping me, i'll give it the rights it needs! [13:39:12] Jens_WMDE: could you add a link to the source snapshot at the main page? [13:39:21] Merlissimo: since i didn't thank you for the work with your bot this week yet: Thanks! :3 [13:39:34] source snapshop? [13:39:38] source snapshot? [13:39:41] git branch/tag [13:40:20] hm wenn ich einen acc erstelle wird zuvor die seite auf deutsch angezeigt und danch wenn (wenn ich auf einstellungen gehe) auf englisch warum wird nicht die "regestrier" sprache, also die spracheinstellungen zur regestrierung übernommen? [13:41:18] Merlissimo: good idea, will do. [13:42:23] http://wikidata-test-repo.wikimedia.de/w/index.php?title=Special:Contributions/127.0.0.1&offset=&limit=500&target=127.0.0.1 ? [13:42:45] Sk1d: einegtragene user haben spracheinstellungen (per cookie), anonyme user nicht [13:43:20] Sk1d: ja, was ist das problem? [13:43:23] fügt der server gerade seine eigenen artikel als localhost wieder hinzu? [13:43:31] ja [13:43:53] maybe we should switch to english, Sk1d [13:44:29] Sk1d: there's a maintainence script that feeds data from localhost into the API. [13:45:08] Sk1d: as mentioned above: the database was deleted and we started from scratch. [13:46:13] New review: John Erling Blad; "Seems okey, will try to merge it." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/22917 [13:46:20] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/22917 [13:46:59] New patchset: Tobias Gritschacher; "added setup and teardown methods to selenium tests" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23066 [13:47:16] https://bugzilla.wikimedia.org/show_bug.cgi?id=40079 if anyone is interested to mentor :) [13:49:17] why do you start from scratch? updates? [13:49:44] Jens_WMDE, aude or TobiasG_WMDE I guess, but could also be jeroen [13:50:27] Lydia_WMDE: add topic bug seems to be fixed nice :) [13:51:29] Sk1d: yay! i wanted to test that next :) [13:51:37] Jens_WMDE: could you please add bot right? http://wikidata-test-repo.wikimedia.de/wiki/Special:UserRights/MerlIwBot [13:51:43] Nischayn22: cool - let me have a look quickly [13:52:21] Merlissimo: done! [13:52:33] Nischayn22: i think Jeroen and Jens_WMDE are the ones to help with that [13:52:37] Jens_WMDE: Bot rights cost 1 kg of pure chocklate, right? [13:52:52] * Lydia_WMDE hands Merlissimo some chocolate [13:52:54] :P [13:53:14] Lydia_WMDE: I even need some other help from Jeroen, but I can't find him [13:53:17] jeblad_WMDE: Merlissimo has already earned more chocolate than most of you :D [13:53:41] Pfrrrttt :p [13:53:42] Nischayn22: he's not in the office - likely busy with something else but i assume he'll be online later [13:53:55] okay [13:55:21] * Merlissimo eats the chocolate (thx Lydia) and ignores jeblads comment [13:55:37] :P [13:55:41] wassup [13:55:47] yo Nischayn22|Away [13:55:49] eh [13:55:51] Nikerabbit [13:56:18] * Lydia_WMDE goes and writes the rest of the weekly summary [13:56:25] all your base are belong to wikidata already? [13:56:44] pretty much [13:56:57] only few left that don't [13:58:33] for great justice [13:59:06] Merlissimo: started your bot armada already? [14:00:58] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23052 [14:01:22] Hand over the choclate Jens_WMDE ! [14:01:28] yes! [14:02:44] Seems like this is going to be one of the days without any useful ting to do except revies.. Here we go again.. [14:03:36] And I start to get sick of all the chocklate. %) [14:07:42] jeblad_WMDE: than give it to meee!!! [14:09:16] jeblad_WMDE: -a +e [14:19:37] New review: John Erling Blad; "The whole transaction level thingy seems to be a little fragile to me, but it doesn't break anything" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/23058 [14:19:38] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23058 [14:22:55] New patchset: Tobias Gritschacher; "added setup and teardown methods to selenium tests" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23066 [14:39:28] DanielK_WMDE: anything to add to the summary still? am good to send it out otherwise [14:40:25] New review: John Erling Blad; "Fails with a lot of errors." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/23061 [14:41:19] New review: John Erling Blad; "There was 1 error:" [mediawiki/extensions/Wikibase] (master); V: -1 C: 0; - https://gerrit.wikimedia.org/r/23060 [14:42:26] DanielK_WMDE: your last patchsets generated errors [14:47:39] Jens_WMDE, are you lonely tonight? [14:48:58] New review: Daniel Werner; "Getting an error when running our tests which don't happen on master." [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/23060 [14:49:17] Jens_WMDE: Aha [14:49:51] Jens_WMDE, are you lonely tonight? [14:56:42] New patchset: John Erling Blad; "(Bug 38675) Review Wikibase API error handling" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23078 [14:59:23] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23078 [15:02:02] Jens_WMDE: Bla. [15:02:57] It's a Jens_WMDE! [15:05:04] Jens_WMDE: Hm. [15:08:12] jeblad_WMDE: can you be more specific? [15:09:20] New review: Daniel Kinzler; "Needs I471cdb9a to be merged first, I guess." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/23060 [15:10:25] gah [15:10:41] ok guys. i tried to package the fixes nicely. but errors only go away if you apply them all [15:10:51] want me to repackage them as one? [15:11:03] jeblad_WMDE, Danwe_WMDE ---^ [15:11:03] yes please [15:11:08] grmbl [15:11:12] kk [15:11:39] gotta finish something else first, though [15:11:50] oh yeah [15:18:48] Jens_WMDE: meep [15:29:42] New patchset: Daniel Kinzler; "Require EDIT_NEW for item creation." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23083 [15:39:02] Jens_WMDE: O hai? [15:41:09] Jens_WMDE: hi [15:55:51] New patchset: Daniel Kinzler; "Fixed 4 bugs in TestSites::insertIntoDb()" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23061 [16:01:16] New patchset: Daniel Kinzler; "Don't allow setting of internal IDs." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23060 [16:05:16] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23061 [16:06:35] New patchset: Daniel Kinzler; "ApiLinkTitles should set bot flag only if asked to." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23084 [16:07:21] ok guys, i think i fixed this stuff [16:09:08] DanielK_WMDE: great, John went home though [16:11:12] Danwe_WMDE: would you have a look? should work now [16:27:35] New review: Daniel Werner; "Especially important, my note from line 170, EditableValue.Interface.js" [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/22891 [16:33:53] New patchset: Henning Snater; "removed invalid HTML structures" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23089 [16:46:33] DanielK_WMDE: I might do so soon, or is it urgent? not sure though whether John shouldn't rather do this [16:55:01] New patchset: Henning Snater; "setting HTML language attributes on site links table and input boxes" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/22891 [16:55:07] New review: Daniel Werner; "All selenium tests should run over this at least once." [mediawiki/extensions/Wikibase] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/23089 [16:57:44] New patchset: Henning Snater; "removed invalid HTML structures" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23089 [17:30:08] New patchset: Henning Snater; "setting HTML language attributes on site links table and input boxes" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/22891 [18:02:36] New patchset: Henning Snater; "setting HTML language attributes on site links table and input boxes" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/22891 [18:48:42] New patchset: Henning Snater; "setting HTML language attributes on site links table and input boxes" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/22891 [18:58:23] New patchset: Henning Snater; "setting HTML language attributes on site links table and input boxes" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/22891 [19:14:08] New review: Daniel Werner; "Looking good now, working fine! A few lines of redundant code can perhaps be removed in a follow-up." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/22891 [19:14:09] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/22891 [21:25:50] hm why isnt [[en:Test]] working on wikidata? [21:25:50] 10[1] 10https://en.wikipedia.org/wiki/Test [21:26:17] see http://wikidata-test-repo.wikimedia.de/wiki/Test [22:32:33] New review: Raimond Spekking; "Translation for these messages disabled with https://gerrit.wikimedia.org/r/23154" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23078 [22:33:54] New review: Raimond Spekking; "Message file will be rebuild with the next update. All existing translation will be removed than." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23078