[04:52:23] <gerrit-wm>	 Change merged: Aude; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23421
[09:25:54] <gerrit-wm>	 New patchset: Henning Snater; "disabled input auto resize for label/description" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23407
[09:48:01] <gerrit-wm>	 New patchset: Jens Ohlig; "Added --verbose option to pollForChanges to dump change object to be processed" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23491
[09:49:19] <gerrit-wm>	 Change merged: Jens Ohlig; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23418
[10:13:33] <gerrit-wm>	 New review: Aude; "this is a bit too verbose, IMHO." [mediawiki/extensions/Wikibase] (master); V: 0 C: -1;  - https://gerrit.wikimedia.org/r/23491
[10:19:16] <gerrit-wm>	 New patchset: Henning Snater; "(bug 40134) fixing UI glitches in RTL languages" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23497
[10:28:20] <gerrit-wm>	 New patchset: John Erling Blad; "Removes the normalize method from ItemObject" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23498
[10:30:44] <gerrit-wm>	 New review: Aude; "This works, though it would be nicer to set the language and class correctly in the mw-content-text ..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/23497
[10:42:26] <gerrit-wm>	 New patchset: Tobias Gritschacher; "(bug 39384) invalidating cache after connecting sitelink got changed" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23500
[10:44:15] <gerrit-wm>	 New patchset: Tobias Gritschacher; "(bug 39384) invalidating cache after connecting sitelink got changed" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23500
[10:44:41] <gerrit-wm>	 New review: John Erling Blad; "This works also for cases where content language is not equal to interface language, which we define..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/23497
[10:44:48] <gerrit-wm>	 New review: John Erling Blad; "https://bugzilla.wikimedia.org/show_bug.cgi?id=40134" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/23497
[11:22:15] <gerrit-wm>	 New review: Dereckson; "Adding Matmarex	as reviewer, as he's willing to review CSS issues." [mediawiki/extensions/Wikibase] (master) C: 0;  - https://gerrit.wikimedia.org/r/23497
[11:44:14] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Cleaned up comparison code" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23501
[11:59:08] <gerrit-wm>	 New review: Daniel Kinzler; "Some thoughts" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/23501
[12:02:12] <gerrit-wm>	 New review: Daniel Kinzler; "question" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/23500
[12:10:13] <gerrit-wm>	 Change merged: Daniel Kinzler; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23498
[12:20:21] <gerrit-wm>	 New review: Henning Snater; "Using the recently added getPageViewLanguage() method inside the skin is causing the original issue ..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/23497
[12:27:29] <TobiasG_WMDE>	 DanielK_WMDE: https://gerrit.wikimedia.org/r/#/c/23500/
[12:31:21] <DanielK_WMDE>	 TobiasG_WMDE: there are several things about that code that I don't understand.
[12:31:35] <DanielK_WMDE>	 TobiasG_WMDE: first off... is $item the state of the item before or after the change?
[12:32:11] <DanielK_WMDE>	 i guess after. So $title will start off as the title of the sitelink's target on the client wiki. right?
[12:32:48] <DanielK_WMDE>	 but there's another thing:
[12:33:21] <DanielK_WMDE>	 if item X used to link to Foo on the client, and now links to Bar, and both exist, then *both* need to be purged.
[12:33:47] <DanielK_WMDE>	 seems to me that with the current code, only Bar would be purged, not Foo.
[12:35:04] <TobiasG_WMDE>	 DanielK_WMDE: ok, let me just sum up, to be sure we're talking about the same thing
[12:36:55] <TobiasG_WMDE>	 the problem was, that if you removed (or changed) the one sitelink which connects an article on the client with the item on the repo, then the cache was not invalidated which led to the behaviour that the interwikilinks still got shown on the client until you made an action=purge.
[12:38:36] <DanielK_WMDE>	 yes. in case the link was removed, the *former* target needs to be purged.
[12:39:29] <DanielK_WMDE>	 TobiasG_WMDE: but if the link was changed to now point to another page, *both* the former and the new target need to be purged.
[12:39:31] <TobiasG_WMDE>	 yes, that's what I did in changeset https://gerrit.wikimedia.org/r/#/c/23418/
[12:39:45] <TobiasG_WMDE>	 at least I guess I did it.. :-)
[12:39:54] <TobiasG_WMDE>	 at least it works.
[12:40:12] <DanielK_WMDE>	 TobiasG_WMDE: yes, that code looks fine.
[12:40:30] <TobiasG_WMDE>	 bt there was still the problem when you changed that sitelink
[12:41:05] <TobiasG_WMDE>	 I was trying to figre out what's happening in that case. but I was a bit confused
[12:41:49] <TobiasG_WMDE>	 but it seems that in this case \Title::newFromText( $siteLink->getPage() ) returns 0
[12:42:06] <TobiasG_WMDE>	 sorry, \Title::newFromText( $siteLink->getPage() )->getArticleID()
[12:43:06] <TobiasG_WMDE>	 so I catch this case, get the old value of the siteling from the diff, and invalidate the cache for that title
[12:43:27] <DanielK_WMDE>	 no... that doesn't make sense
[12:43:33] <TobiasG_WMDE>	 no?
[12:44:09] <DanielK_WMDE>	 no. the new target of the link is an existing page, the ID will not be 0. IF it is, something went wrong (e.g. the page was deleted before the change was processed)
[12:44:26] <DanielK_WMDE>	 (or getPage() somehow messed up the page name)
[12:45:00] <TobiasG_WMDE>	 hm.. ok. but it is 0 when that page does NOT exist, right?
[12:45:05] <DanielK_WMDE>	 yes
[12:45:06] <TobiasG_WMDE>	 in fact it is.
[12:45:10] <TobiasG_WMDE>	 ok.
[12:45:20] <TobiasG_WMDE>	 I did not cover the case when it exists.
[12:45:43] <DanielK_WMDE>	 basically: 
[12:45:49] <DanielK_WMDE>	 a) find out if we need to purge the new link target (yes, if there is a new target, and it exists)
[12:46:03] <DanielK_WMDE>	 b) find out if we need to purge the old link target (yes, if there is an old target, and it exists)
[12:46:47] <DanielK_WMDE>	 so, have an $oldTarget and a $newTarget, set them to the desired page (or null)
[12:46:56] <DanielK_WMDE>	 then, for each, check if it's not null and exists, and then purge
[12:46:58] <TobiasG_WMDE>	 yes, ok. I'll lokk into it again.
[12:48:03] <gerrit-wm>	 New review: Daniel Kinzler; "the logic is warped, as per discussion on irc" [mediawiki/extensions/Wikibase] (master); V: 0 C: -1;  - https://gerrit.wikimedia.org/r/23500
[12:48:21] <DanielK_WMDE>	 TobiasG_WMDE: thanks
[12:51:58] <gerrit-wm>	 New patchset: Aude; "kill unused test file" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23503
[12:52:55] <gerrit-wm>	 New patchset: John Erling Blad; "(Bug 40185) Replace hardcoded prefixes" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23504
[12:53:57] <Abraham_WMDE>	 team, is gerrit down?
[12:57:14] <aude>	 gerrit lives again :)
[13:01:08] <jeblad_WMDE>	 DanielK_WMDE: Are you there?
[13:01:28] <jeblad_WMDE>	 Merge this as it is for now? https://gerrit.wikimedia.org/r/#/c/23497/
[13:01:59] <gerrit-wm>	 Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23503
[13:04:23] <gerrit-wm>	 Change merged: Henning Snater; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23469
[13:11:02] <gerrit-wm>	 New patchset: Aude; "put item disambiguation form above any results, per bug 40184" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23505
[13:16:29] <DanielK_WMDE>	 jeblad_WMDE: i'll have a look
[13:17:53] <gerrit-wm>	 Change merged: Henning Snater; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23470
[13:20:17] <gerrit-wm>	 Change merged: Henning Snater; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23471
[13:28:10] <gerrit-wm>	 New patchset: Aude; "auto suggestions need dir=auto to display correctly" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23506
[13:28:30] <gerrit-wm>	 New patchset: Tobias Gritschacher; "(bug 39384) invalidating cache after connecting sitelink got changed" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23500
[13:29:28] <TobiasG_WMDE>	 DanielK_WMDE: plz h've another look: https://gerrit.wikimedia.org/r/#/c/23500/
[13:30:57] <Denny_WMDE1>	 30 minutes
[13:31:06] <TobiasG_WMDE>	 29
[13:31:20] <Denny_WMDE1>	 please try to empty the review queue
[13:36:16] <gerrit-wm>	 New patchset: John Erling Blad; "(Bug 40132) Added a language specific link" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23507
[13:36:28] <gerrit-wm>	 New patchset: Aude; "put item disambiguation form above any results, per bug 40184" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23505
[13:36:34] <DanielK_WMDE>	 jeblad_WMDE: still investigating.
[13:36:41] <DanielK_WMDE>	 TobiasG_WMDE: sec
[13:38:14] <Sannita>	 sorry, did you erase also the list of users?
[13:38:28] <Denny_WMDE1>	 Sannita: on the test system?
[13:38:30] <gerrit-wm>	 New review: Tobias Gritschacher; "seems fine to me." [mediawiki/extensions/Wikibase] (master); V: 0 C: 1;  - https://gerrit.wikimedia.org/r/23506
[13:38:38] <Sannita>	 Denny_WMDE1: yep
[13:38:50] <Denny_WMDE1>	 Sannita: yes, we blank it from time to time
[13:38:58] <Sannita>	 Denny_WMDE1: ouf, ok :D
[13:39:01] <gerrit-wm>	 Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23505
[13:40:35] <gerrit-wm>	 New review: Daniel Kinzler; "Seems like it should be there anyway, so I'll merge it." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/23497
[13:40:35] <gerrit-wm>	 Change merged: Daniel Kinzler; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23497
[13:42:32] <DanielK_WMDE>	 TobiasG_WMDE: what's with all the whitespace changes?
[13:44:09] <DanielK_WMDE>	 TobiasG_WMDE: ok, now it looks like it should work. Though I think the "deleted" case could share a bit more code with the "changed" case. But whatever. I'll test it.
[13:44:10] <TobiasG_WMDE>	 DanielK_WMDE: aaaahhhrrgggll
[13:44:28] <DanielK_WMDE>	 :P
[13:44:40] <TobiasG_WMDE>	 eclipse. $%"§%&/
[13:44:51] <DanielK_WMDE>	 benutz es halt nicht :)
[13:45:11] <TobiasG_WMDE>	 haha. :)
[13:45:25] <DanielK_WMDE>	 actually... no.
[13:45:28] <TobiasG_WMDE>	 ja, ich mach die whitespaces wieder rückgängig
[13:45:51] <DanielK_WMDE>	 TobiasG_WMDE: i won't have time to test this before the demo, because i don't have client replication set up. I'll +1 for now.
[13:46:25] <gerrit-wm>	 New review: Daniel Kinzler; "Looks good, but not tested. Still havn't got a replication setup." [mediawiki/extensions/Wikibase] (master); V: 0 C: 1;  - https://gerrit.wikimedia.org/r/23500
[13:46:44] <TobiasG_WMDE>	 DanielK_WMDE: ok, the remove part is merged, so I can demo it
[13:46:57] <DanielK_WMDE>	 ok, great
[13:47:06] <DanielK_WMDE>	 or find someone with a working setup to test it.
[13:47:20] <DanielK_WMDE>	 test and merge, i mean
[13:49:16] <Denny_WMDE1>	 i will try to test it. can someone quickly tell me the git review commands to grab the change?
[13:49:17] <gerrit-wm>	 New patchset: Tobias Gritschacher; "(bug 39384) invalidating cache after connecting sitelink got changed" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23500
[13:50:47] <Denny_WMDE1>	 is it this?
[13:50:47] <Denny_WMDE1>	 git fetch https://gerrit.wikimedia.org/r/mediawiki/extensions/Wikibase refs/changes/00/23500/4 && git checkout FETCH_HEAD
[13:53:25] <Denny_WMDE1>	 i pull back my offer, my localhost just broke on me :´(
[13:53:32] <Merlissimo>	 jeblad_WMDE: have you already completed your api-json-redesign?
[13:53:51] <jeblad_WMDE>	 its merged 
[13:53:59] <jeblad_WMDE>	 not yet visible on test
[13:54:05] <gerrit-wm>	 Change merged: Aude; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23507
[13:55:19] <gerrit-wm>	 New review: Aude; "it's okay for now, though i see some RTL issues to fix" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23507
[13:55:32] <Denny_WMDE1>	 Merlissimo:  it is planned to go life tomorrow
[13:55:49] <Merlissimo>	 yes i know, but i have to rewrite some parts of my bot because some other details changes on the last update. Perhaps i could do both changes at the same time. Have you plan when this will be available to test. also DanielK_WMDE supported wiki bugfix?
[13:56:04] <Merlissimo>	 that would be great
[13:56:46] <Denny_WMDE1>	 if DanielK_WMDE 's fix is already merged, it would also go life tomorrow
[13:57:08] <DanielK_WMDE>	 yes it's merged
[13:57:30] * jeblad_WMDE  got lost in his own mind

[14:01:03] <Denny_WMDE1>	 jeblad_WMDE: back here to reality, please
[14:01:08] <Denny_WMDE1>	 DanielK_WMDE: great!
[14:01:40] <DanielK_WMDE>	 Denny_WMDE1: btw, i have shared a few bugzilla searches - go to "saved searches" in your profile and look for "Wikidata".
[14:02:09] <DanielK_WMDE>	 unfortunately, i can only share with groups, and "editbugs" is the only sensible group, but most of the team are not in there.
[14:02:18] <DanielK_WMDE>	 or are they?
[14:03:10] <gerrit-wm>	 New patchset: Jens Ohlig; "Added --verbose option to pollForChanges to show change summary" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23491
[14:03:18] <Denny_WMDE1>	 oh nice, didn't know that feature
[14:05:40] <Denny_WMDE1>	 PHP Fatal error:  Declaration of Wikibase\ItemContent::getDeletionUpdates() must be compatible with that of Content::getDeletionUpdates() in /Users/denny_WMDE/Sites/wikidata/extensions/Wikibase/repo/includes/content/ItemContent.php on line 18
[14:05:48] <Denny_WMDE1>	 when running rebuildall.php
[14:05:52] <Denny_WMDE1>	 anyone have an idea?
[14:06:00] <gerrit-wm>	 Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23475
[14:06:08] <aude>	 Denny_WMDE1: update wikidata core branch
[14:06:18] <Denny_WMDE1>	 ah right
[14:06:19] <Denny_WMDE1>	 thanks
[14:07:23] <Denny_WMDE1>	 thanks, that solved it aude
[14:22:39] <gerrit-wm>	 New review: Jeroen De Dauw; "Looks acceptable to me, although would be good to cleanup further w/ follow up" [mediawiki/extensions/Wikibase] (master); V: 0 C: 2;  - https://gerrit.wikimedia.org/r/23491
[15:38:45] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Move PATH_LINK constant from Site interface to SiteObject class" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23510
[15:44:09] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Fixed typo and docs" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23511
[16:11:02] <gerrit-wm>	 Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23510
[16:13:30] <aharoni>	 Hello from California.
[16:14:09] <aharoni>	 aude, thank you for fixing the is the version at the Hebrew client wiki.
[16:14:43] <aharoni>	 is it the newest version? the same as in English?
[16:16:32] <aharoni>	 Lydia_WMDE, Jens_WMDE ^
[16:18:15] <gerrit-wm>	 Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23511
[16:19:15] <gerrit-wm>	 New patchset: Jens Ohlig; "Added --verbose option to pollForChanges to show change summary" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23491
[16:19:15] <jeblad_WMDE>	 aude is gone for the day
[16:20:24] <Jens_WMDE>	 aharoni: i think it is.
[16:22:20] <aharoni>	 Jens_WMDE, special:version has a different git checksum
[16:23:15] <Jens_WMDE>	 oh.
[16:23:19] <Jens_WMDE>	 well.
[16:23:36] <Jens_WMDE>	 i can look into it tomorrow, if that's okay.
[16:23:49] <Jens_WMDE>	 i actually have to run to catch my train.
[16:26:17] <aharoni>	 no problem
[17:03:36] * aude  is still somewhat on japanese time

[17:03:49] <aude>	 can look in the morning at the hebrew test wiki
[18:11:17] <gerrit-wm>	 New patchset: John Erling Blad; "(Bug 40132) Added language fallbacks for labels and description" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23534
[18:21:52] <gerrit-wm>	 New patchset: John Erling Blad; "(Bug 40185) Replace hardcoded prefixes" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23504
[18:31:05] <gerrit-wm>	 New review: John Erling Blad; "Should be rewritten as a foreach-loop as it is now slightly unreadable." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/23534