[07:27:46] New review: Tobias Gritschacher; "you didn't run the tests. this broke almost every test. please check this next time. ;)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23793 [07:31:22] New patchset: Tobias Gritschacher; "fixed selenium tests to use renamed IDs for textfields on CreateItem special page" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24116 [07:31:35] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24116 [08:02:48] New patchset: Tobias Gritschacher; "made item id prefix configurable in selenium tests" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24117 [08:12:01] New patchset: Tobias Gritschacher; "made item id prefix configurable in selenium tests" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24117 [08:15:12] New patchset: Daniel Kinzler; "adding some profiling points" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23796 [08:18:53] New review: Daniel Kinzler; "was already approved, now merging after rebase" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/23796 [08:18:54] Change merged: Daniel Kinzler; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23796 [08:41:20] New patchset: Henning Snater; "(bug 40131) improved input recognition using input event when available" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24118 [08:48:15] New patchset: Daniel Kinzler; "Prevent direct editing of structured content." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23413 [08:48:17] New patchset: Tobias Gritschacher; "made item id prefix configurable in selenium tests" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24117 [08:52:18] Change merged: Henning Snater; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24117 [08:57:58] New patchset: Daniel Kinzler; "500x speedup for importInterlang" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23787 [08:58:24] New patchset: Daniel Kinzler; "500x speedup for importInterlang" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23787 [08:58:52] New patchset: Jens Ohlig; "(#40228) make sure pollForChanges runs only once" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24004 [08:59:45] New patchset: Denny Vrandecic; "Adapted bracket spacing and removed wgLang" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24119 [09:15:51] ...yyyYYAAAWWwwnn.. [09:15:58] zzz [09:16:41] a [09:17:11] o [09:20:13] damn you win :P [09:21:13] New review: Jens Ohlig; "This makes me very happy." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/23787 [09:21:13] Change merged: Jens Ohlig; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23787 [09:23:58] moin [09:24:53] moin [09:26:15] DanielK_WMDE: merged! [09:26:25] yay! [09:26:30] merged what? [09:26:45] Going to check out and run the tests for Change I2866dc28: Set getPageViewLanguage to user language [09:26:58] ah, the speedup. [09:26:59] great! [09:27:25] * DanielK_WMDE has geerit on /ignore so he doesn't get popups all the time from his name being mentioned on irc. [09:27:38] I notebooknapped your black thingy.. It will cost you chocklate to get it back! [09:27:45] :P [09:27:48] thanks guys! [09:30:21] 33% girls now.. [09:52:22] New review: John Erling Blad; "There were 3 failures:" [mediawiki/extensions/Wikibase] (master); V: -1 C: 0; - https://gerrit.wikimedia.org/r/23658 [09:54:28] New review: John Erling Blad; "Note that the tests failed after rebase." [mediawiki/extensions/Wikibase] (master); V: -1 C: 0; - https://gerrit.wikimedia.org/r/23658 [09:58:52] New patchset: Jeroen De Dauw; "Added id blacklist to sql id generator" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24120 [10:14:03] JeroenDeDauw: merge or rebase https://gerrit.wikimedia.org/r/#/c/23930/ [10:16:25] New review: John Erling Blad; "PHP Fatal error: Interface 'Wikibase\SiteLinkCache' not found in /home/john/Workspace/Wikibase/lib/..." [mediawiki/extensions/Wikibase] (master); V: -1 C: 0; - https://gerrit.wikimedia.org/r/23940 [10:17:26] New review: John Erling Blad; "The failing test is probably due to a lot of changes not being properly merged. Will do a rerun afte..." [mediawiki/extensions/Wikibase] (master); V: -1 C: 0; - https://gerrit.wikimedia.org/r/23940 [10:17:55] New patchset: Tobias Gritschacher; "(#40228) make sure pollForChanges runs only once" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24004 [10:21:27] New patchset: Daniel Kinzler; "Set getPageViewLanguage to user language." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23658 [10:22:27] New review: Daniel Kinzler; "fixed test case" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/23658 [10:22:40] jeblad_WMDE: fixed, i hope [10:23:01] ok, shall check later [10:24:33] New review: Aude; "SiteLinkLookup.php needs improved documentation" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/23930 [10:26:39] TobiasG_WMDE, jeblad_WMDE: turns out, PHP runs under OpenVMS: http://www.openvms.org/stories.php?story=11/07/04/4871417 [10:26:53] coool [10:27:12] however, i think we should really only support unix and windows. [10:29:04] the question arose from correctly replacing directory seperators in paths. VMS has this syntax: DEVICE:[DIR.PATH]FILENAME.EXT;VER [10:29:32] which is neither "/" (unix) nor "\" (windows) [10:30:19] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24004 [10:36:29] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23413 [10:38:03] New review: John Erling Blad; "Is this really somthing we need? I have a real problem seeing a real usecase." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/24120 [10:41:22] gah. [10:41:58] TobiasG_WMDE, Jens_WMDE: i have several issues with the PID stuff in pollForChanges. I guess it took me too long to write them down :/ [10:42:05] i'll file a bug [10:44:20] New review: Aude; "Patchset looks good and tests work for me now." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/23658 [10:49:32] DanielK_WMDE: https://gerrit.wikimedia.org/r/#/c/23658/ needs a rebase [10:49:56] * aude hesitates to push the "rebase change" button [10:51:00] aude: the "rebase change" button only works the the cahnge doesn't *need* a rebase :) [10:51:14] i.e. it works if there are no conflicts - in which case the change would apply without a rebase :) [10:51:17] ah, ok [10:51:33] confusing, but okay :) [10:54:03] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23506 [10:58:45] New patchset: Daniel Kinzler; "Set getPageViewLanguage to user language." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23658 [10:58:48] aude: done [10:58:59] food? [10:59:08] yes! [10:59:10] DanielK_WMDE: thanks [10:59:10] oh, wait# [10:59:21] ;) [10:59:25] Change merged: Aude; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23658 [10:59:30] yay! [11:00:23] DanielK_WMDE: :P [11:00:49] DanielK_WMDE: can u send the link please after you filed the bug for the poll-script? [11:01:49] TobiasG_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=40327 [11:02:05] New patchset: Jeroen De Dauw; "Updated code in Item to use proper store abstraction" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23930 [11:02:44] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24118 [11:03:47] aude: thx [11:04:12] Jens_WMDE: can u have a look at https://gerrit.wikimedia.org/r/#/c/24007/ ? [11:04:53] New patchset: Jeroen De Dauw; "Added client store" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23940 [11:04:53] New patchset: Jeroen De Dauw; "Site link queries now go via the store" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23931 [11:05:41] New review: Daniel Kinzler; "I guess it's for reserving some canonical IDs... but wouldn't it be more useful to support ranges of..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/24120 [11:05:49] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23930 [11:08:10] New review: Daniel Kinzler; "I think there are some issues remaining, see inline comments and bug 40327." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24004 [11:08:26] New patchset: Jeroen De Dauw; "Added client store" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23940 [11:08:26] New patchset: Jeroen De Dauw; "Site link queries now go via the store" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23931 [11:09:01] TobiasG_WMDE, Jens_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=40327 [11:09:09] thx [11:27:00] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23931 [11:28:52] New patchset: Denny Vrandecic; "Patchset from Denny, updating the Special:ItemDisambiguation page" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24020 [11:30:23] Change abandoned: Denny Vrandecic; "Has been now further fixed and amended to the original patchset. Thus this one is abandoned." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24119 [11:45:30] New patchset: Denny Vrandecic; "Patchset from Denny, updating the Special:ItemDisambiguation page" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24020 [11:54:15] Change merged: Denny Vrandecic; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24020 [12:08:15] New review: Aude; "Still getting php fatal error when running unit tests" [mediawiki/extensions/Wikibase] (master); V: -1 C: -2; - https://gerrit.wikimedia.org/r/23940 [12:10:10] New patchset: Henning Snater; "refactoring of AutocompleteInterface introducing custom autocomplete widget" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24001 [12:12:11] New review: Aude; "running the tests on my client instance, I get" [mediawiki/extensions/Wikibase] (master); V: -1 C: -2; - https://gerrit.wikimedia.org/r/23940 [12:16:53] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24001 [12:20:25] New review: Aude; "I also get an error:" [mediawiki/extensions/Wikibase] (master); V: -1 C: -2; - https://gerrit.wikimedia.org/r/23940 [12:54:10] New patchset: Jens Ohlig; "(Bug #40327) PID file for pollForChanges does not work with a wiki family setup." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24122 [12:54:55] DanielW_WMDE, TobiasG_WMDE: Have a look! https://gerrit.wikimedia.org/r/#/c/24122/ [12:56:13] Jens_WMDE: should be DanielK_WMDE, right? :) [12:56:56] That's right! [13:07:50] New patchset: Jens Ohlig; "(Bug #40327) PID file for pollForChanges does not work with a wiki family setup." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24122 [13:18:23] New review: Daniel Kinzler; "looks good, didn't test" [mediawiki/extensions/Wikibase] (master); V: 0 C: 2; - https://gerrit.wikimedia.org/r/24122 [13:19:33] New patchset: Jeroen De Dauw; "Added client store" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23940 [13:25:09] New patchset: Tobias Gritschacher; "fixed createItem msgs" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24125 [13:25:39] New review: Daniel Werner; "I like it" [mediawiki/extensions/Wikibase] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/24120 [13:30:58] New review: Jeroen De Dauw; "John: this allows us to figure out what we want items 1 and 42 to be and actually get them." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/24120 [13:42:21] Change merged: Aude; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24125 [14:02:25] jeremyb: where are the repos for the gerrit-wm bot registered again? [14:03:25] jeremyb: nvm, found it https://gerrit.wikimedia.org/r/#/c/11188/1/templates/gerrit/hookconfig.py.erb [14:04:01] New patchset: Tobias Gritschacher; "fix to some selenium tests, after events of inputfields got changed" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24128 [14:04:48] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24122 [14:15:35] Change merged: Jens Ohlig; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24128 [14:30:30] * multichill pokes DanielK_WMDE [14:30:43] * DanielK_WMDE wiggles [14:31:07] I heard rumours about Wikidata people coming to the Wikimedia Nederland Conference [14:31:10] New review: Jeroen De Dauw; "~=[,,_,,]:3 demands you merge this" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/23940 [14:48:13] JeroenDeDauw: heh, totally missed this [14:57:22] jeremyb: why u no approve [14:57:25] :( [14:57:57] Any idea who that might be DanielK_WMDE? [14:58:03] JeroenDeDauw: i will as soon as you grant me merge rights (and merge on sockpuppet!) [14:59:49] multichill: not entirely decided yet but either me or DanielK_WMDE [15:02:56] New patchset: Daniel Werner; "(bug 40229) Introduce PropertyView (DO NOT MERGE)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24130 [15:24:27] New review: Aude; "On my repo instance:" [mediawiki/extensions/Wikibase] (master); V: -1 C: -1; - https://gerrit.wikimedia.org/r/23940 [15:26:44] Lydia_WMDE: Or both. I think the Europeana people would love to pick your brains ;-) [15:26:45] New review: Aude; "PHP Fatal error: Class 'Wikibase\StoreFactory' not found in /var/www/wikidata-client/extensions/Wik..." [mediawiki/extensions/Wikibase] (master); V: -1 C: -1; - https://gerrit.wikimedia.org/r/23940 [15:33:12] * aude would love to attend some community events [15:48:08] New patchset: Daniel Werner; "Changed variable names in wb.utilities.inherit()" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24133 [15:52:20] New patchset: Henning Snater; "putting disable/enable functionality into a separate extension" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24134 [15:52:28] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24133 [15:59:09] New patchset: Jeroen De Dauw; "Added client store" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23940 [17:42:59] New review: Aude; "Good news is that the tests run without errors on my client instance." [mediawiki/extensions/Wikibase] (master); V: -1 C: -1; - https://gerrit.wikimedia.org/r/23940 [17:45:08] multichill: right but we also need to get development done you know :P [17:45:31] if all we do is travel around no code gets written ;-) [17:45:55] so we need to be a bit careful and decide wisely on whom to send where [18:15:44] New patchset: Jeroen De Dauw; "Added client store" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23940