[08:11:55] New patchset: Henning Snater; "putting disable/enable functionality into a separate extension" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24134 [08:45:10] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24315 [08:59:47] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24290 [09:05:13] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24300 [09:45:07] New review: Tobias Gritschacher; "there are problems with the selenium tests. have to figure out why they are breaking.." [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/24134 [13:03:46] Duesentrieb: can you please add a bug for "Namespace translation with items in main namespace", I am having trouble formulating it [13:08:49] DanielK_WMDE: tricky to change names, but my request remains :) [13:27:48] Denny_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=40397 [14:14:47] Hey folks, remember the weekly summary! https://docs.google.com/a/wikimedia.de/document/d/1ZjQpJ-Ajf1oRTDlcPAnRS5L7qeJuNXf9WWltDOCJPwk [14:15:00] * jeblad_WMDE have a particularly good conscience this week [14:21:53] New review: Tobias Gritschacher; "Well, here is what I found out:" [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/24134 [14:47:27] New patchset: Aude; "assign dir='ltr' to site IDs in the site links table, per bug 40237" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24433 [14:49:29] New patchset: Aude; "assign dir='ltr' to site IDs in the site links table, per bug 40237" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24433 [14:50:03] New patchset: Jeroen De Dauw; "Some cleanup of repo store" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24434 [14:54:11] Review all of the changes! http://s.bn2vs.com/wdrev [14:54:58] New review: Amire80; "Didn't test, but the code mostly makes sense." [mediawiki/extensions/Wikibase] (master) C: 0; - https://gerrit.wikimedia.org/r/24433 [14:59:37] New patchset: Jeroen De Dauw; "Some cleanup of repo store" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24434 [14:59:40] * jeblad_WMDE wants to give JeroenDeDauw a -2 for spelling error in the branch name [15:01:02] New patchset: Jeroen De Dauw; "Some cleanup of repo store" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24434 [15:02:33] jeblad_WMDE: you're not from germany, so are not allowed to be a grammar nazi [15:02:59] Ha! Norwegians have Nynorsk, thats worse than Grammer Nazis! [15:03:40] JeroenDeDauw: I gets errors on the tests,.. probaly something wrong in my setup.. [15:05:43] jeblad_WMDE: which commit? [15:06:05] DataValues.. [15:06:16] jeblad_WMDE: and how does this Nynorsk thing fit into this very objective representation of norway? https://s3.amazonaws.com/data.tumblr.com/tumblr_l03pnyj0T71qzpwi0o1_500.png [15:06:22] jeblad_WMDE: which errors? [15:06:30] https://gerrit.wikimedia.org/r/#/c/24135/ [15:07:56] Singing in atheistic gospel choir? =D [15:08:18] * jeblad_WMDE have (nearly) never heard about such a thing [15:09:23] ValueParser\Test\BoolParserTest::testParse with data set #8 ('foo', ValueParserResultObject) [15:09:25] MWException: Called non-existant assertTypeOrValue method on ValueParser\Test\BoolParserTest [15:09:38] This is probably in some base class we don't have.. [15:09:40] jeblad_WMDE: your core is out of date [15:09:49] this thing got added 2 weeks back or so [15:09:58] Huh? [15:10:03] MW core [15:10:11] you can use master btw [15:10:16] I pulled this morning.. but I'm on Wikidata.. [15:10:16] if it's not in the WD branch yet [15:10:23] Then use master [15:10:25] DanielK_WMDE!!! [15:10:36] Yes, it's his fault obviously [15:10:37] * JeroenDeDauw hides [15:10:43] DanielK_WMDE: You are out of date! [15:11:03] what? who? hm?! [15:11:09] says grandpa Norway [15:11:13] * JeroenDeDauw hdies even more [15:11:16] *hides [15:17:13] rm -fR JeroenDeDauw [15:19:40] New patchset: Aude; "assign dir='ltr' to site IDs in the site links table, per bug 40237" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24433 [15:23:13] Change merged: Jens Ohlig; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/24137 [15:23:14] Change merged: John Erling Blad; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/24135 [15:24:45] jeblad_WMDE: rm: cannot remove JeroenDeDauw: Permission denied [15:24:45] sudo rm -rf jeblad_WMDE [15:25:49] Nah, I'm supergod! [15:26:01] * jeblad_WMDE spanks JeroenDeDauw into submission [15:26:33] Merged as tests passes.. [15:27:43] * JeroenDeDauw removes incorrect and now broken softlink supergod pointing to jeblad_WMDE [15:37:12] Change merged: John Erling Blad; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/24289 [15:41:34] New patchset: Jeroen De Dauw; "Made modification and deletion updates non-item specific" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24438 [15:43:24] Change merged: John Erling Blad; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/24304 [15:44:13] Ok JeroenDeDauw, it was 500€ per patchset merged? [15:45:01] jeblad_WMDE: yeah, so how much do you owe me now? EUR 3000? [15:45:30] You owe me around 47 000 € [15:46:09] New patchset: Jeroen De Dauw; "fix indent of autload line" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24439 [15:47:24] Strange.. got an error.. [15:49:56] New review: John Erling Blad; "john@loke[Wikidata] ~/Workspace/core/tests/phpunit> php phpunit.php --verbose --group DataValueExten..." [mediawiki/extensions/DataValues] (master); V: -1 C: 0; - https://gerrit.wikimedia.org/r/24313 [16:04:59] New review: John Erling Blad; "Empty file but what the heck" [mediawiki/extensions/DataValues] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/24294 [16:05:00] Change merged: Jens Ohlig; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/24296 [16:05:00] Change merged: Jeroen De Dauw; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/24297 [16:05:00] Change merged: John Erling Blad; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/24294 [16:08:29] i saw a knight news challenge announcement. no wikidata? [16:13:05] New review: John Erling Blad; "Passed after commenting out WikibaseLib.php, Wikibase.php and ExampleSettings.php as the errors seem..." [mediawiki/extensions/DataValues] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/24313 [16:13:19] Change merged: John Erling Blad; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/24313 [16:23:16] jeremyb: unfortunately not [16:25:31] ;( [16:28:25] indeed! [16:28:31] but let's see what else comes up [16:32:14] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24434 [17:07:29] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24438 [17:09:23] * aude stabs mapbox [17:09:33] (well, happy for them and osm though) :) [17:18:24] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24439 [17:19:13] New patchset: Jeroen De Dauw; "Added prop and query updates" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24450 [17:19:37] has the database issue been solved [17:19:44] whenever i run php maintenance/update.php it fails [17:19:47] New patchset: Jeroen De Dauw; "Remove dead global" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24451 [17:20:02] joancreus: what error? [17:20:24] * joancreus opening the dev laptop [17:20:51] * joancreus the name for a 2002 box with linux with only a hard drive change [17:21:38] aude: Database returned error "1146: Table 'Wikidata.sites' doesn't exist (localhost) [17:21:40] if you haven't updated your wikidata core branch, that might be an issue [17:21:45] hrm [17:21:46] "SELECT site_id,site_global_key,site_type,site_group,site_source,site_language,site_protocol,site_domain,site_data,site_forward,site_config FROM `sites` WHERE site_global_key = 'cawiki' LIMIT 1 " [17:21:50] i updated everything [17:21:56] doing it again [17:21:57] ... [17:22:59] aude: it still happens [17:23:02] yesterday i cloned from start [17:23:03] bizarre [17:23:05] and it happened [17:23:11] *scratch [17:23:48] aude: full log [17:23:49] http://pastebin.com/6tzKs2WN [17:24:13] looking [17:24:45] * aude can try setting up a new wiki [17:24:57] one minute.... [17:25:06] hmm maybe i have to add the table via a sql file in Wikibase [17:25:08] aude: [17:25:17] it used to work fine... [17:26:31] you shouldn't have to [17:26:48] aude: whoops i did it and it now crashes on another part [17:26:54] Database returned error "1146: Table 'Wikidata.wb_terms' doesn't exist (localhost)" [17:27:13] run update.php (not sure it works) [17:27:21] aude: that's where it crashes [17:27:25] ok [17:27:36] * aude cloning new stuff [17:27:40] it seems the table structure isn't fine [17:27:48] thanks aude [17:28:26] :( [17:30:01] aude: when cloning, it fails with Database returned error "1146: Table 'wikidata2.wbc_items_per_site' doesn't exist (localhost)" [17:30:05] ok, gerrit is slow [17:30:08] dammit, site table [17:30:30] do you have the repo and client enabled on the same wiki? [17:30:33] it should work either way [17:31:22] aude: yes, LocalSettings has both [17:31:26] required, i mean [17:31:46] ok [17:32:08] some reason, gerrit is super slow :( [17:33:34] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24433 [17:36:26] meanwhile to develop wikidata i'll use the test repo [17:36:32] does it use the new api syntax? [17:36:51] jeblad_WMDE: ^ [17:37:18] i am not sure if it was updated today [17:37:32] joancreus: There are changes sitting in the review queue [17:37:39] * aude checks [17:37:51] Not anything dramatic, but there will be larger changes [17:38:08] For items nothing has changed for the moment [17:38:22] updated to 84b9a938b7f20e58e3791a1ee61b225ca404d147 [17:38:23] jeblad_WMDE: it was referring to the syntax change in wbsetitem [17:38:26] *i [17:38:30] Merge "(bug 40230) Changed some JS event names to use 'entity' instead of 'item'" [17:38:45] {enwiki:{title:"blah",lang:"enwiki"}} is no longer allowed [17:38:50] But it is possible to set entitytype=property and you will then set properties for some of the calls [17:39:02] Oh, that is already merged [17:39:15] in the test repo? i can't test it w/ my local box [17:40:09] data={"labels":{"en":{"language":"en","value":"blabla"}}} [17:40:23] or something like [17:40:24] +1 https://gerrit.wikimedia.org/r/#/c/23528/ already! :) [17:40:36] ok [17:40:40] * joancreus working on pywikidata again [17:40:47] data={"labels":[{"language":"en","value":"blabla"}]} [17:40:56] It's a jeblad_WMDE [17:41:16] The last form is now allowed and is rather nice in my opinion [17:41:38] yes, there is no redundancy [17:43:55] joancreus: Both forms are allowed [17:44:12] jeblad_WMDE: i'm getting error: an array was expected but not found [17:44:16] joancreus: still checking [17:44:16] But only one form will be used for outpu, the one with keys [17:44:54] what are you sending in? [17:46:50] jeblad_WMDE: originally, i sent {'descriptions': {u'cs': u'plyn s atomov\xfdm \u010d\xedslem 1'}, 'labels': whatever [note this is a python dict which is json-encoded later] [17:46:56] i'm changing this to the [{}, {}] format [17:47:20] i mean, {'':[{},{}], '':[{},{}]} [17:47:26] Ok.. [17:47:40] Perhaps test are not updated yet [17:47:56] I testing on my own local repo [17:48:23] problem is, it's failing either way. i must be doing something wrong, let me check again [17:50:17] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24450 [17:50:32] joancreus: i got sites table does not exist, skipping new field patch. [17:50:45] aude: same as what i got [17:50:58] but otherwise the update.php completed [17:52:16] the sites table is in my database [17:52:19] oh, mine didn't fail [17:52:27] *failed [17:52:35] i used a brand new database and not the one from the other clone [17:53:41] i set up a new database [17:54:27] i am confused why sites is not there for you [17:56:39] joancreus: i had to checkout the wikidata branch, then run update.php with the extensions disabled [17:56:41] uh oh pywikidata was failing due to sitelinks jeblad_WMDE . the rest was fine, when i put 'sitelinks':[] it worked [17:56:49] and then run update.php with the extensions enabled [17:56:55] ok [17:57:09] was getting other errors, not the one you had [17:58:30] aude: i've run update.php and it went fine. i enabled the extensions, and ran update.php, and it failed [17:58:32] again, with [17:58:33] Database returned error "1146: Table 'wikidata2.wbc_items_per_site' doesn't exist (localhost)" [17:58:36] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24451 [17:59:13] i think that has to do with the shared tables on the client [17:59:41] * aude doesn't have the client enabled as i'm keeping my client and repo instances separate [17:59:49] but think other people have them together and it should work [17:59:54] * aude tries [18:00:14] Sorry, I'm a bit lost in other stuff.. [18:00:22] oh no, i see why it failed (api) [18:00:24] "sitelinks": { "enwiki": { "site": "enwiki", "title": "Berlin" } }, [18:00:28] it doesn't use language-value [18:00:30] but site-title [18:00:35] Just put my name in if there is anything and I'll get a notification [18:00:48] yes [18:00:56] It was confusing for us too [18:01:51] And remember that it uses the form { "site" : "enwiki", "title" : "foo" } [18:01:53] it created wbc_entity_cache and wbc_item_usage tables, which the client has [18:02:23] its easy to forget that sites are with the "wiki" appenden, its global site identifiers [18:05:22] joancreus: wbc_items_per_site is a shared table [18:05:29] * jeblad_WMDE thinks the bot-people is pretty nice even if he constantly messes up the REST API for Wikibase [18:06:20] they are defined in WikibaseClient.php though [18:06:31] shouldn't need to define them in LocalSettings [18:06:47] jeblad_WMDE: aaaaand aliases doesn't allow an array as a value, crashing it again. already adapted :) [18:07:19] aliases have three different forms, that is confusing [18:10:18] joancreus: everything works for me [18:10:36] i'll have to ask JeroenDeDauw if he has any idea [18:10:49] aude: i'll clone again from start [18:10:52] ok [18:10:53] don't worry [18:10:54] thanks [18:11:02] it works with client and repo together [18:11:41] btw, the api sends aaaaall the contents each time. is this preferred over "small commits". pros: only one edit. easier to implement. cons: bandwidth waste [18:12:05] it would need to track changes to the local item dictionary [18:12:11] {"aliases":{"en":[{"language":"en","value":"foo"}]}} [18:12:15] with __setitem__ [18:12:38] so completely opposite of kiss [18:12:50] wbsetitem report back whats changed [18:13:09] it reports back everyhting, i think ? [18:13:15] let me check [18:13:20] The reason is that values are normalized and that will have consequences [18:13:46] If you change labels it will report back labels for the changed language [18:14:00] all of the changed language [18:14:32] jeblad_WMDE: confirmed: it returns all the item instead of only the changed ones [18:14:42] this is ok for me & easiest to work with [18:15:13] hmm i'll enable gzip so that wikidata servers won't explode after some requests :) [18:15:46] darn, a test is lost in time.. [18:16:26] It was at some point only the changed values for the actual languages [18:16:38] I'll add a bug for that [18:16:50] New patchset: Daniel Kinzler; "Make entity namespace use consistent." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24460 [18:16:52] Things should be geared for partial updates [18:17:41] * jeblad_WMDE make a note that his infinite mind isn't completely flawless [18:17:54] ...and ego... [18:18:29] ..a small flaw, as I'm otherwise aquite lovely guy [18:18:30] hmm pywikidata should handle it nevertheless. it is done so that an item, once saved, is updated locally with the updated wikidata output, thus allowing to save again after more changes [18:18:51] Nice! [18:19:42] oh i sometimes struggle with keeping my ego to a size viewable by a microscope, it tends to be rather small. i guess i'm not a true hacker then [18:20:18] my microscope is out of order.. [18:21:52] jeblad_WMDE: how would the output inform that a sitelink has been deleted? [18:22:22] (in the "report only changes"-mode-which-isn't-like-right-now) [18:22:36] You get a flag { ... "removed : "" ...} [18:22:55] But that in the reply on the remove request [18:23:08] It is not repeated in later requests [18:23:26] Then it is { ... "missing" : "" ... } [18:25:00] jeblad_WMDE: why should the missing be kept on already removed sitelinks? [18:25:25] does it serve any purpose? [18:25:26] Sorry, I was thinking about something else [18:25:39] Lookup by sitelinks, the item is flagged as missing [18:26:46] jeblad_WMDE: have you filled the bug for only-changes output, to add me to the cc list so i can update the library? [18:27:25] https://bugzilla.wikimedia.org/show_bug.cgi?id=40405 [18:30:27] https://github.com/jcreus/pywikidata/commit/8ddebcf7848a34cfb3e3caffa236c1d173618cfc :D [18:30:45] joancreus: rock! [18:30:47] * joancreus will now work in enabling gzipping [18:30:48] :) [18:31:20] * joancreus is concerned Wikimedia Deutschland doesn't like web hosting bills [18:32:30] hehe [18:33:29] * jeblad_WMDE wonders if joancreus will continue adding code when he sees the property-claim-reference-datavalue -beast [18:33:54] heh i read about it some time ago, it will be huge [18:34:03] joancreus: the demo? [18:34:04] (but i guess key to wikidata for wikipedia) [18:34:19] aude: it's simply procrastination [18:34:32] I think the most important thing for now is to get the sitelinks working [18:34:37] jeblad_WMDE: done [18:34:39] :) [18:34:47] But the rest is going to be real fun! [18:34:55] oh i thought you meant pywikidata [18:35:03] when is it being deployed to a WMF-wiki? [18:35:11] hungarians? [18:35:33] joancreus: we're a bit blocked on code review by WMF but soon i hope [18:36:17] people like tim starling have to review for security, etc. in the extensions and wikidata core branch [18:36:18] aude: when do you think it'll be in enwiki? how long will the transition last? will bots be allowed to deal with ~4m articles, or not in the beginning? [18:36:32] oh, i can't predict [18:36:42] hope before not too long [18:39:05] I think most of moving sitelinks will be done by bots [18:39:07] :) [18:39:20] New patchset: Daniel Kinzler; "[Bug 40390][Bug 40397] entity namespace fix." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24460 [18:39:21] * joancreus ego boost [18:39:25] I think very few will move them manually [18:39:38] Updates will be manually, but not the massive moving of them [18:40:26] Yeah, it will be an enormous ego boost for the bot operators! =D [18:41:15] They are more important than many of the wikipedia editors are willing to admit [18:41:23] * joancreus Pickup lines for Wikidata developers (&bot developers) +"huh, do you see those links in this bar" -"yeah, why?" +"you're welcome" [18:42:56] I think the bot operators will be able to do other important work when the langlinks updating is easier [18:43:06] Really important stuff [18:43:22] Like updating population statistics.. [18:43:30] Crime statistics.. [18:43:35] :) [18:44:05] And quality assurance of wikidata and also wikipedia [18:44:29] "where does that number come from in that article?" [18:44:52] Oh, the same number is in wikidata and it is sourced from that reference [18:45:03] will references be unified ultimately? [18:45:14] Seems so [18:45:24] Presentation is going to be a pain.. [18:45:38] the cite web mess is unappealing to newcomers [18:45:48] and for translators to other wikis [18:46:01] Family name first, title first, year first or company/university/publisher first.. [18:46:28] But only for referencing claims in wikidata [18:46:50] oh, i thought all references [18:46:54] Even if there has been some people mentioning references for wikipedia in general [18:47:13] jeblad_WMDE: and what about letting each wiki choose, via MediaWiki:Referencesformat [18:47:24] with {{{}}} variables [18:47:31] or a lua module [18:47:57] They can make their own format, or use something we spit out as a chunk of html [18:48:30] But DanielK is the expert on formatting the stuff that ultimatly goes to wikipedia [18:49:01] Perhaps aude can fill in, she works on the client [18:49:15] wikipedia is client in this context [18:50:31] * jcreus-away dinner [18:51:25] * aude brain explode :o [18:51:27] * aude hungry [18:51:43] time to go home (and be back online in a bit) [18:57:54] jcreus-away: i'd love to let wikis format the references as they like, but to do that, you need a way to loop over all references for a statement X. That works with lua, but not with plain parser functions. [18:58:08] So, we'll probably end up allowing it, but requireing lua to do it. [18:58:30] for normal values in an infobox, parserfunctions will be enough. [19:21:53] New patchset: Daniel Kinzler; "Fix change notifications for deletions." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24475 [19:24:42] New patchset: Daniel Kinzler; "Fix change notifications for deletions." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24475