[09:36:47] If someone want to review, this seems to work now https://gerrit.wikimedia.org/r/#/c/24794/ [09:37:05] Its based upon https://gerrit.wikimedia.org/r/#/c/24559/ [09:37:49] Change merged: Denny Vrandecic; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24810 [09:55:30] ..we are the champions, WE ARE THE CHAMPIONS!! [09:55:56] Oh, no headphones, the music is in my head.. :D [10:03:16] New patchset: John Erling Blad; "(Bug 40230) Fix for permissions" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24984 [10:07:48] New patchset: Aude; "rename noexternalinterlang to noexternallanglinks, per bug 40387" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24985 [10:10:34] New patchset: Daniel Werner; "(Bug 40230) Fix for permissions" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24984 [10:10:34] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24948 [10:10:45] New review: John Erling Blad; "Merging this, even if I made the first patchset. Its more or less Daniles work now. (Right pretty th..." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/24559 [10:10:46] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24559 [10:11:03] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24984 [10:11:23] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24794 [10:19:01] New review: Aude; "this change is okay. there's always room for further improvement later but good for now and nothing..." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/24884 [10:19:31] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24563 [10:19:32] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24885 [10:19:32] Change merged: Aude; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24884 [10:23:49] New review: Daniel Werner; "This requires a rebase, merge of some conflicts." [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/23534 [10:26:44] http://gfx.nrk.no/X1nljQMhQzsyn8Pz2G2-XAcGVTI32Y-0qB977N9dpxuA.jpg [10:30:47] Change merged: Aude; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24887 [10:33:34] New patchset: Jeroen De Dauw; "Handle changes in the same way, not caring what output mode is set" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24986 [10:34:13] http://gfx.nrk.no/GlwSCwQb5xbYk2wLJLYkcQctZC8nCxrU0tdcRMuEB8Nw.jpg [10:34:44] New patchset: Jeroen De Dauw; "Moved lib settings to hooks file for great consistency" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24988 [10:51:06] New review: John Erling Blad; "Tested through a later patchset, should work now.." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/24566 [10:51:06] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24567 [10:51:06] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24566 [11:03:06] New patchset: Tobias Gritschacher; "(bug 40388) selenium tests for noexternallanglinks" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24990 [11:04:24] Change merged: Aude; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24988 [11:18:12] New review: John Erling Blad; "john@loke[Wikidata] ~/Workspace/core/tests/phpunit> php phpunit.php --verbose --group Wikibase --con..." [mediawiki/extensions/Wikibase] (master); V: -1 C: 0; - https://gerrit.wikimedia.org/r/24829 [11:19:29] New review: John Erling Blad; "After pull on both Wikibase and DataValues I still gets this." [mediawiki/extensions/Wikibase] (master); V: -1 C: 0; - https://gerrit.wikimedia.org/r/24806 [11:56:04] New review: Jeroen De Dauw; "This change needs I9598595d8f20efc66df0ed930f6f32a8b3625d1d" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/24829 [11:57:01] New review: Jeroen De Dauw; "John: did you see my comment about the dependency?" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/24806 [12:08:20] New review: Tobias Gritschacher; "please update documentation. see inline comment." [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/24985 [12:08:43] aude: small update required: https://gerrit.wikimedia.org/r/#/c/24985/ [12:24:49] New patchset: Jeroen De Dauw; "Match naming changes in DataValues" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24882 [12:24:50] New patchset: Jeroen De Dauw; "Changed DataValue namespace to DataValues and implemented NumberValue" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/24883 [12:26:45] New patchset: Tobias Gritschacher; "(bug 40388) selenium tests for noexternallanglinks" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24990 [12:27:29] New patchset: Daniel Werner; "(Bug 40476) Add a type marker to the entity output by the API" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24808 [12:31:07] New patchset: Aude; "rename noexternalinterlang to noexternallanglinks, per bug 40387" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24985 [12:36:02] New patchset: Aude; "rename noexternalinterlang to noexternallanglinks, per bug 40387" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24985 [12:42:55] New review: Daniel Werner; "This requires some changes on the frontend side. I am taking care of it." [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/24808 [12:43:18] Change merged: John Erling Blad; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/24800 [12:46:07] New patchset: Denny Vrandecic; "First version of a special page for setting a label." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24995 [12:48:25] Change merged: John Erling Blad; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/24801 [12:50:58] Change merged: John Erling Blad; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/24805 [12:51:43] New patchset: Jeroen De Dauw; "Improved clear method of store and clear term cache in entity save test to avoid failiure due to already present data" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24996 [12:54:49] Change merged: John Erling Blad; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/24807 [12:58:24] Change merged: John Erling Blad; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/24868 [13:02:45] jeblad_WMDE: https://www.ohloh.net/p/wikidata/ [13:03:18] Denny_WMDE: https://www.ohloh.net/p/wikidata/analyses/latest/languages_summary [13:03:28] Henning_WMDE: any ideas on http://meta.wikimedia.org/wiki/Wikidata/Development/Entity_selection_widget_design ? [13:03:37] Henning_WMDE: (in case you are working...) [13:03:55] Maintenance... I'm about to reboot wikidata-test... [13:04:58] I did not look at it yet. Been working on the tablesorter so far. Will probably have a look later. [13:05:14] Henning_WMDE: no hurry [13:05:15] ....aaaaatsjIII! [13:05:44] New review: John Erling Blad; "john@loke[Wikidata] ~/Workspace/core/tests/phpunit> php phpunit.php --verbose --group DataValueExten..." [mediawiki/extensions/DataValues] (master); V: -1 C: 0; - https://gerrit.wikimedia.org/r/24883 [13:06:33] New patchset: Tobias Gritschacher; "made data NS configuarable in client and removed hardcoded stuff" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24997 [13:11:29] New review: Aude; "this is a bit hacky and think we can do better" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/24997 [13:19:04] New review: John Erling Blad; "Darn, it passes... ;p" [mediawiki/extensions/DataValues] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/24883 [13:19:26] Change merged: John Erling Blad; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/24883 [13:28:52] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24985 [13:30:42] New review: John Erling Blad; "Still fails after a rebase." [mediawiki/extensions/Wikibase] (master); V: -1 C: 0; - https://gerrit.wikimedia.org/r/24829 [13:32:49] New review: John Erling Blad; "Seems like this should be DataValues\StringValue and not DataValue\StringValue.." [mediawiki/extensions/Wikibase] (master); V: -1 C: 0; - https://gerrit.wikimedia.org/r/24829 [13:41:06] New review: Tobias Gritschacher; "Hackier than before?" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/24997 [13:50:05] New review: John Erling Blad; "Disregarding the failing tests as this works in a later patchset." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/24829 [13:50:07] New patchset: Jeroen De Dauw; "Added testLabelUniquenessRestriction test" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25000 [13:50:12] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24882 [13:50:12] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24829 [13:51:47] JeroenDeDauw: in Wikibase\TermCache::getMatchingTerms what is entityType? it says string, but "item" does not work? [13:52:23] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24806 [13:56:16] (+ contribute link) [13:57:39] Denny_WMDE: originally it was "item" yes, but this got changed to "wikibase-item" [13:57:45] We're going to change it back though [13:57:50] As it makes no sense to prefix this [13:58:01] Denny_WMDE: you should obtain the value via the constant though [13:58:14] ie Property::ENTITY_TYPE [13:58:17] where is the constant? [13:58:20] ah OK [13:58:21] or ITEM::ENTITY_TYPE [13:58:22] thx [13:58:24] *Item [13:58:54] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24543 [13:59:08] aude: if you've time you can make https://gerrit.wikimedia.org/r/#/c/24997/ nicer.. I've to finish my tickets. it was just a fix to make it work again. but u can make it nice. [13:59:27] JeroenDeDauw: thx, that's what i was looking for [14:00:39] New review: Tobias Gritschacher; "tests are working, approved by aude." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/24990 [14:00:39] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24990 [14:00:44] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24545 [14:11:47] New review: John Erling Blad; "The code passes with no problems on other parts of the codex, but it will probably have some issues ..." [mediawiki/extensions/Wikibase] (master); V: 1 C: -1; - https://gerrit.wikimedia.org/r/24995 [14:12:29] New review: John Erling Blad; "And for the record, it needs a rebase to pass." [mediawiki/extensions/Wikibase] (master); V: 1 C: -1; - https://gerrit.wikimedia.org/r/24995 [14:14:47] New patchset: Aude; "add @group WikibaseSnak to SnakListTest" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25004 [14:16:15] New patchset: Tobias Gritschacher; "splitted off uls, aliases & sitelinks from item pageobject" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25005 [14:17:45] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25004 [14:19:49] New patchset: Denny Vrandecic; "New function getFromTerm that searches over both aliases and labels." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25006 [14:22:21] New review: John Erling Blad; "Rebase, merge conflicts" [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/24996 [14:22:55] New patchset: Daniel Werner; "(Bug 40476) Add a type marker to the entity output by the API" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24808 [14:24:08] New patchset: Jeroen De Dauw; "Added testLabelUniquenessRestriction test" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25000 [14:24:08] New patchset: Jeroen De Dauw; "Improved clear method of store and clear term cache in entity save test to avoid failiure due to already present data" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24996 [14:33:48] New patchset: Daniel Werner; "added entity::getPrefixedId()" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25008 [14:34:21] New review: Jeroen De Dauw; "This is the kind of thing you really want to write a test for in advance - would likely have caught ..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/25006 [14:38:47] New patchset: Aude; "removed hardcoded "Data:" and "Q" in client" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24997 [14:39:39] New review: Aude; "switched this back to using Special:ItemByTitle which should be more reliable and not depend on know..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/24997 [14:43:20] New patchset: Daniel Werner; "(Bug 40476) Add a type marker to the entity output by the API" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24808 [14:57:14] New patchset: Henning Snater; "putting disable/enable functionality into a separate extension" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24134 [15:01:48] New patchset: Denny Vrandecic; "First version of a special page for setting a label." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24995 [15:05:41] New patchset: Tobias Gritschacher; "new pageobjects for create entity" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25020 [15:17:42] New review: Aude; "spaces is not a problem here and should be handled correctly in Special:ItemByTitle. " [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/24997 [15:23:10] New patchset: Tobias Gritschacher; "removed hardcoded "Data:" and "Q" in client" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24997 [15:27:36] New patchset: Tobias Gritschacher; "removed hardcoded "Data:" and "Q" in client" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24997 [15:28:20] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24997 [15:39:35] New patchset: Aude; "handle encoded page titles" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25026 [16:13:12] New patchset: Daniel Werner; "added entity::getPrefixedId()" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25008 [16:14:34] New patchset: Tobias Gritschacher; "handle encoded page titles" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25026 [16:15:37] New patchset: Tobias Gritschacher; "handle encoded page titles" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25026 [16:16:05] New patchset: Denny Vrandecic; "Prefix search on labels" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25028 [16:31:28] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25008 [16:37:51] New patchset: Aude; "handle encoded page titles" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25026 [16:38:40] New patchset: Matmarex; "(Bug 40476) Add a type marker to the entity output by the API" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24808 [16:39:26] New review: Matmarex; "PS5: rebased on master, dumping the dependency." [mediawiki/extensions/Wikibase] (master) C: 0; - https://gerrit.wikimedia.org/r/24808 [16:41:00] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25026 [16:41:03] New patchset: Denny Vrandecic; "Put real values into the DataTypeSelector Widget in CreateProperty" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25035 [16:51:52] New review: Daniel Werner; "Looking good actually, the confusion about breaking frontend was not really justified, got some othe..." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/24808 [16:51:52] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24808 [17:20:50] I just debugged this query [17:20:52] SELECT terms0.term_entity_type,terms0.term_type,terms0.term_language,terms0.term_text,terms0.term_entity_id FROM unittest_wb_terms "terms0" LEFT OUTER JOIN unittest_wb_terms "terms1" ON ((terms0.term_entity_id=terms1.term_entity_id) AND (terms0.term_entity_type=terms1.term_entity_type)) WHERE (terms0.term_language='en' AND terms0.term_text='testLabelAndDescriptionUniquenes' AND terms0.term_type='label' AND terms0.term_entity_type=' [17:21:03] To find out that the error is not in the query [17:21:05] :/ [18:57:23] New patchset: Denny Vrandecic; "Values for DataTypeSelector Widget in CreateProperty" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25035 [20:50:39] Lydia_WMDE: ihr habt jetzt das neue favicon.ico.. ich habs gerade auf den Cluster geschoben [20:50:42] http://www.wikidata.org/favicon.ico [20:50:50] mutante: \o/ [20:50:55] thx [20:51:00] np:) [21:28:25] New patchset: Denny Vrandecic; "Closed one XSS problem with labels from DB" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25180