[00:27:04] hm is this an error in the api? if i want to add en interlang link to be-x-old do i have to use be-x-oldwiki:.... or not? [00:33:38] Sk1d: x-oldwiki is the site code [00:33:52] usually language code + project code [00:34:36] the project code is there to distinguish between be-x-old wikipedia and be-x-old witionary or whatever [02:42:57] can i have botrights for Skidbot? [07:18:14] New patchset: Aude; "strip page input if it has invalid chars" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25229 [07:22:04] New patchset: Aude; "strip page input in special itembytitle if it has invalid chars" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25229 [08:59:26] New review: Aude; "If there's an invalid character in the title, newFromText() returns false and getText() does not wor..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/25229 [09:35:31] New patchset: Denny Vrandecic; "Prefix search on labels" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25028 [09:55:25] hi DanielK_WMDE [10:03:09] hi aude [10:03:39] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25180 [10:16:06] DanielK_WMDE: the recent changes thing is ready for review? [10:16:19] although i realize further work is needed, obviously [10:17:00] aude: yes, ready for review. it doesn't fully implement the item, but it works and is a good baseline, i think. [10:18:21] ok [10:19:00] are you further working on it or is that something i can work on? [10:19:55] and i do have a fix for propogating item deletion to the client, but it just involves the explode( '~', .... ) thing which is ugly [10:20:02] * aude would like to fix it more properly [10:23:52] New patchset: Aude; "strip page input in special itembytitle if it has invalid chars" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25229 [10:30:06] New patchset: John Erling Blad; "(Bug 40523) Add escaping to output in EditEntityAction" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25242 [10:45:05] hey [10:45:33] hey Sk1d [10:45:44] can i have botrights for Skidbot [10:46:04] aude: did you already give them for Sk1d? [10:46:33] Sk1d: yes your bot has rights now [10:47:05] oh thanks [10:47:07] New patchset: John Erling Blad; "(Bug 40523) Add escaping to output in SpecialCreateEntity" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25244 [10:48:27] Denny_WMDE: for messages, it's wfMessage( 'tpt-diff-old' )->escaped() [10:51:57] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25229 [10:53:40] aude: to reduce the uglyness of the the explode( '~', .... ) stuff, just give the CHange class getters that do this internally. that way, it can easily be replaced later without changin much code. [10:53:57] DanielK_WMDE: ok [10:54:08] Sk1d: hey :) hwat's your bot going to do? (I wanna know it all! :D) [10:54:20] aude: i will probably not work on the recentchanges stuff today. i think it would be godd to discuss the architectural issues at the office tomorrow [10:54:34] (example: what local user shall we point to?) [10:54:59] DanielK_WMDE: ok [10:56:02] aude: oh, another thing: please commit the getters for change type and item type separately. then the fix for delete/undelete on top of that. [10:56:18] make more changes on gerrit! small change sets are your friend! [10:56:29] * DanielK_WMDE has to repeat that every morning to himself [10:57:17] ok :) [10:57:25] New patchset: John Erling Blad; "(Bug 40523) Add escaping to output in SpecialItemByTitle" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25246 [11:12:02] New patchset: Jens Ohlig; "(#40232) List all datatypes" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25247 [11:12:34] New patchset: Jens Ohlig; "(#40232) List all datatypes" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25247 [11:13:24] New patchset: Jens Ohlig; "(Bug 40232) List all datatypes" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25247 [11:17:41] New review: Denny Vrandecic; "Really minor changes." [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/25247 [11:17:53] New review: Denny Vrandecic; "Really minor changes." [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/25247 [11:19:27] New review: Jeroen De Dauw; "Ahhhh, Denny beat me to it :)" [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/25247 [11:21:30] New patchset: Daniel Werner; "ViewEntityAction now serves the right entity view for different entity types" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25248 [11:22:24] New patchset: John Erling Blad; "(Bug 40523) Add escaping to output in ItemView" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25249 [11:24:36] New patchset: Daniel Werner; "(bug 40230) make property view work in JavaScript" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25250 [11:28:50] New patchset: Jens Ohlig; "(Bug 40232) List all datatypes" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25247 [11:30:28] New patchset: Jens Ohlig; "(Bug 40232) List all datatypes" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25247 [11:33:44] New review: Denny Vrandecic; "An entry in repo/Wikibase.i18n.alias.php so I get notices when I go to Special:SpecialPages and Spec..." [mediawiki/extensions/Wikibase] (master); V: -1 C: -1; - https://gerrit.wikimedia.org/r/25247 [11:45:42] New patchset: Jens Ohlig; "(Bug 40232) List all datatypes" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25247 [11:47:19] Change merged: Denny Vrandecic; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25247 [12:12:26] Change abandoned: John Erling Blad; "Html::element does a partial escaping, seems to be good enough." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25249 [12:23:20] New patchset: John Erling Blad; "(Bug 40523) Add escaping to output in SpecialItemByTitle" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25246 [12:30:21] Change merged: Henning Snater; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25035 [12:37:09] Change abandoned: John Erling Blad; "Good enough." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25244 [12:42:21] JeroenDeDauw: WikibaseLib depends on the ValueParsers extension [12:42:25] JeroenDeDauw: well... where is it? [12:42:31] i can't find it on gerrit. [12:42:31] New patchset: John Erling Blad; "(Bug 40523) Add escaping to output in EditEntityAction" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25242 [12:42:40] Its in DataValues [12:43:23] o_O [12:43:29] why? [12:44:32] Because they simply like to be there? :D [12:44:56] the error message should be fixed and point to datavalues [12:45:08] Btw; forgot the rudimentary escaping in the element methos.. ;/ [12:45:58] Also, it seems like addWikiTxt on special pages does not escape, that is a bit scary [12:46:55] Everything that is not armoured will be subject to the sanitizer and that kills a lot of possible security holes [12:47:15] ..but don't depend on the sanitizer.. [12:48:03] New review: Daniel Kinzler; "This works, but makes the debug output slightly less useful. And I don't see which problem it solves..." [mediawiki/extensions/Wikibase] (master); V: 1 C: 0; - https://gerrit.wikimedia.org/r/24986 [12:53:09] what do i have to do to edit with using the botflag? [12:54:25] is it? action=wbsetlabel?bot [13:02:01] Sk1d: action=wbsetlabel&bot=1 i guess [13:02:09] &bot alone may be enough, i don't know [13:02:40] Change merged: Jens Ohlig; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25020 [13:02:41] Change merged: Jens Ohlig; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25005 [13:03:51] New patchset: John Erling Blad; "(Bug 40523) Add escaping to output in SpecialItemByTitle" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25246 [13:04:35] JeroenDeDauw: should that be https://www.mediawiki.org/wiki/Extension:ValueParser or https://www.mediawiki.org/wiki/Extension:ValueParsers ? [13:15:12] New review: Jeroen De Dauw; "Both issues I mentioned are still there" [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/25246 [13:15:24] ..&bot&.. should be enough if the bot flag is set [13:15:41] But this is done by the pywikipediabot -framework [13:16:28] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24996 [13:18:52] jeblad_WMDE: https://www.mediawiki.org/wiki/Special:Code/MediaWiki/77777 [13:19:02] jeblad_WMDE: https://www.mediawiki.org/wiki/Special:Code/MediaWiki/66666 [13:19:23] jeblad_WMDE: https://www.mediawiki.org/wiki/Special:Code/MediaWiki/88888 [13:20:49] Denny_WMDE: plural [13:21:06] Denny_WMDE: I changed it to plural for consistency reasons, mw.org not updated yet though [13:22:07] Change abandoned: Daniel Kinzler; "i'll do this properly, by moving wb_changes to the repo's responsibility" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24910 [13:23:05] New review: John Erling Blad; "Feel free to fix it yourself." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/25246 [13:25:39] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25000 [13:31:34] New review: John Erling Blad; "I would like some documentation on the fuzzy search, as for now it is a bit unclear what to expect f..." [mediawiki/extensions/Wikibase] (master); V: 1 C: 0; - https://gerrit.wikimedia.org/r/25028 [13:36:01] New patchset: Daniel Werner; "ViewEntityAction now serves the right entity view for different entity types" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25248 [13:36:35] New patchset: Denny Vrandecic; "Added a few more doc files. Not perfect yet." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25254 [13:37:02] New review: Aude; "This works nicely for me and is a good starting point for further improvements. Only have a few com..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/24889 [13:37:15] DanielK_WMDE: see my comments [13:37:19] ^ [13:37:35] * aude is ready to merge but would like to perhaps discuss the issue in my comments  [13:38:51] Change abandoned: John Erling Blad; "I guess nothing is going to be used from this patchset." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/23534 [13:40:20] aude: i agree that the \Bla stuff should be removed, but we have inconsistencies like this all over the place. [13:40:20] Change abandoned: John Erling Blad; "Only bitching." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25246 [13:40:35] i think we can clean that up in one fell swoop soon. [13:40:46] DanielK_WMDE: ok [13:40:51] it would be nice if you could merge the change if there are no other issues, so we can demo it [13:40:54] * aude will approve this change [13:40:57] thanks [13:41:06] Change merged: Aude; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/24889 [13:41:10] :) [13:43:19] JeroenDeDauw: Fatal error: Class 'DataValue\StringValue' not found in /DATA/var/www/daniel/wikidata/extensions/Wikibase/lib/tests/phpunit/claim/ClaimObjectTest.php on line 54 [13:43:21] ?? [13:46:11] New patchset: Aude; "remove unused 3rd message param for create item link" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25255 [13:47:41] does anyone have the same problem? [13:47:43] Jens_WMDE: do you know if there is a "cd -" for git branches? [13:48:05] git checkout master? ;) [13:48:06] JeroenDeDauw: any idea why that happens? [13:48:07] DanielK_WMDE: you updated one and not the other [13:48:19] it got renamed to DataValues [13:49:01] i pulled DataValues to try and fix this... i guess is whould also pull WIkibase ;) [13:53:05] Silke_WMDE_: will you invite me? [13:53:49] New patchset: Daniel Werner; "ViewEntityAction now serves the right entity view for different entity types" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25248 [13:55:33] Change merged: Henning Snater; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25248 [13:56:16] DanielK_WMDE: how do i git review to not master? [13:56:28] i want to backport one change to the branch being reviewed [13:56:30] Denny_WMDE: git review somebranchname [13:56:34] thanks [13:57:14] New patchset: Denny Vrandecic; "Closed one XSS problem with labels from DB" [mediawiki/extensions/Wikibase] (wikidata-wmfphase1beta) - https://gerrit.wikimedia.org/r/25256 [13:57:39] New patchset: Daniel Kinzler; "Move wb_changes to the repo." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25257 [13:59:31] DanielK_WMDE: should be the last of that hopefully - now everything is in the correct NS [14:01:10] New patchset: Daniel Werner; "(bug 40230) make property view work in JavaScript" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25250 [14:02:29] Change merged: Henning Snater; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25250 [14:06:54] JeroenDeDauw: I'd like to change something in IORMTable: it should be able to access a table on a different wiki using the load balancer's foreign connection facility. [14:07:24] check the third parameter of wfGetDB [14:08:06] basically, ORMTable should have a wiki option, that is used to optain the correct database connection. [14:10:07] DanielK_WMDE: this is for pollforchanges? [14:11:01] yes [14:13:11] ok [14:24:36] when the huwiki will use wikidata will there be all interwikilinks transfered and deleted in huwiki or will there be bots checking if the wikidata interwikilinks are the same as in huwiki and then delet them and if no they will set a templates? [14:45:58] Sk1d: it'll not happen magically - the old system will still work and then editors/bots will migrate it one by one [15:09:59] New review: Jeroen De Dauw; "Again, these checks are implicit and will cause problems for any string that is false after cast to ..." [mediawiki/extensions/Wikibase] (wikidata-wmfphase1beta); V: 1 C: 2; - https://gerrit.wikimedia.org/r/25256 [15:10:00] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (wikidata-wmfphase1beta) - https://gerrit.wikimedia.org/r/25256 [15:10:50] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25255 [15:15:40] New review: Jeroen De Dauw; "RELEASE-NOTES at the top level seem odd to me. Also not sure about having an INSTALL there. Fine wit..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/25254 [15:49:51] JeroenDeDauw: https://gerrit.wikimedia.org/r/25264 [15:55:25] FYI: I'm about to update the test system. [15:57:19] are you going to reset also the client? [15:57:25] (just asking, eh) [15:59:01] New patchset: Reedy; "Simplify getNewOffset()" [mediawiki/extensions/Diff] (master) - https://gerrit.wikimedia.org/r/25266 [16:00:10] Sannita: What do you mean by 'reset'? [16:00:22] Silke_WMDE_: I mean delete all the stuff [16:00:41] Shall I? [16:01:18] dunno, but it seems that the articles on the client are not connected with the entries on the repo [16:02:41] http://wikidata-test-client.wikimedia.de/wiki/Hanover i.e. [16:06:36] New patchset: Reedy; "Simplify getNewOffset()" [mediawiki/extensions/Diff] (master) - https://gerrit.wikimedia.org/r/25266 [16:12:45] New patchset: John Erling Blad; "(Bug 40227) Add title and remove returnto" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25269 [16:19:02] New patchset: John Erling Blad; "(Bug 40227) Add title and remove returnto" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25269 [16:30:21] Silke_WMDE_: still haz teh problem? [16:30:44] yep [16:51:13] Yeah, well... Our test system is broken right now. Sorry for that! [16:52:30] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25257 [19:18:28] Change merged: Jeroen De Dauw; [mediawiki/extensions/Diff] (master) - https://gerrit.wikimedia.org/r/25266 [19:29:36] New patchset: Jeroen De Dauw; "Attempt to fix item lang+label+desc uniqueness restriction" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25284 [19:29:36] New patchset: Jeroen De Dauw; "Re-implemented lang+label+desc uniqueness restriction for items" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25285 [19:39:58] DanielK_WMDE: Danwe_WMDE: why can't you hold the silly discussion here? :p [19:40:02] * JeroenDeDauw hides [19:40:18] JeroenDeDauw: because then we can't speak german ;) [19:40:27] naw - didn't know you were still active [19:40:31] should have guessed though [19:40:48] anyway [19:41:06] currently we are discussiong what EntityHandler::getSpecialPageForCreation() should be returning [19:41:09] DanielK_WMDE: you managed to have Danwe_WMDE not want to write PHP anymore now :p [19:41:19] an instance of the special page? a title object? class name? page name? what? [19:41:25] DanielK_WMDE: sure, let's also waste my time with it [19:41:31] hehehe... why's that? [19:41:35] or wait, I have better stuff to do :) [19:41:43] Just pick one already ffs [19:41:50] I vote string [19:41:55] end of story [19:42:30] lol, you vote string, daniel votes Title, I vote SpecialPage... [19:43:08] Danwe_WMDE: i said title a while back, but since i found SpecialPage::getSafeTitleFor, i also favor the page name as a string [19:43:32] you can get to all the other stuff from there, with minmal effort [19:44:15] alright, string it is [19:50:03] New patchset: Jeroen De Dauw; "Re-implemented lang+label+desc uniqueness restriction for items" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25285 [19:50:03] New patchset: Jeroen De Dauw; "Attempt to fix item lang+label+desc uniqueness restriction" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25284 [20:04:31] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25028 [20:22:09] New patchset: Jeroen De Dauw; "re-add config removed in 29505a8eb38e8847620032cfc45778c274e84563" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25411 [21:02:47] New patchset: Daniel Werner; "added Entity::getLocalType for getting localized name of an entity" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25426 [21:12:54] New patchset: Daniel Werner; "ViewEntityAction on non-existing pages displays right link to create entity" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25429 [21:18:42] New patchset: Daniel Werner; "added Entity::getLocalizedType for getting localized name of an entity" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25426 [21:21:25] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25242 [21:30:56] New review: Daniel Werner; "The change set description could be more descriptive, I don't really know what to test here, at leas..." [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/25269 [21:50:19] New review: Daniel Kinzler; "or not?" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/25242